Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

l be at end of _mesa_texstore_can_use_memcpy() function: if (baseInternalFormat == GL_DEPTH_COMPONENT && srcType == GL_FLOAT)) return GL_FALSE; /* can't use memcpy */ I'll send out an updated patch if it looks good to you. > Marek > > On Sat, Jul 19, 2014 at 12:53 AM, Anuj

Re: [Mesa-dev] [PATCH] mesa: Don't use memcpy() in _mesa_texstore() for depth texture data

On Mon, Jul 21, 2014 at 3:27 PM, Marek Olšák wrote: > On Tue, Jul 22, 2014 at 12:09 AM, Anuj Phogat > wrote: > > On Fri, Jul 18, 2014 at 5:54 PM, Marek Olšák wrote: > >> > >> Shouldn't the function return TRUE for floating-point depth textures > only? >

[Mesa-dev] [PATCH V2] mesa: Don't use memcpy() in _mesa_texstore() for float depth texture data

. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/texstore.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index d363f9f..c87e407 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -3830,6 +3830,21

[Mesa-dev] [PATCH 2/2] i965: Bail on FS copy propagation for scratch writes with source modifiers

Signed-off-by: Anuj Phogat --- I don't have a test case though it might be useful to also include the check for FS_OPCODE_FB_WRITE here? src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

Fixes Khronos GLES3 CTS test: dynamic_expression_array_access_vertex Cc: Signed-off-by: Anuj Phogat --- I don't have a test case though it might be useful to also include the check for VS_OPCODE_URB_WRITE here? src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 4 1 file ch

Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

On Tue, Jul 29, 2014 at 7:18 AM, Matt Turner wrote: > > On Mon, Jul 28, 2014 at 8:47 PM, Anuj Phogat wrote: > > Fixes Khronos GLES3 CTS test: > > dynamic_expression_array_access_vertex > > > > Cc: > > Signed-off-by: Anuj Phogat > > --- > > I don

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

ture target related functions. > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/glformats.h | 3 +++ >> src/mesa/main/teximage.c | 12 ++-- >> 2 files changed, 9 insertion

[Mesa-dev] [PATCH V2] mesa: Turn target_can_be_compressed() in to a utility function

V2: Declare the function in teximage.h Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 12 ++-- src/mesa/main/teximage.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index a069594..6532e5b

[Mesa-dev] [PATCH 4/5] meta: Fix datatype computation in get_temp_image_type()

Changes in the patch will cause datatype to be computed correctly for 8 and 16 bit integer formats. For example: GL_RG8I, GL_RG16I etc. Fixes many failures in gles3 Khronos CTS test: copy_tex_image_conversions_required copy_tex_image_conversions_forbidden Cc: Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH 2/5] meta: Use _mesa_get_format_bits() to get the GL_RED_BITS

We currently get red bits from ctx->DrawBuffer->Visual.redBits by making a false assumption that the texture we're writing to (in glCopyTexImage2D()) is used as a DrawBuffer. Fixes many failures in gles3 Khronos CTS test: copy_tex_image_conversions_required Cc: Signed-off-by:

[Mesa-dev] [PATCH 3/5] meta: Move the call to _mesa_get_format_datatype() out of switch

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index ba84eb8..e94 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers

[Mesa-dev] [PATCH 1/5] meta: Initialize the variable in declaration statement

Saves one line of code :) Signed-off-by: Anuj Phogat --- Realized today that I never really sent this series out to the list. src/mesa/drivers/common/meta.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 5/5] meta: Add an assertion check for datatype of integer formats

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fdac546..78bfd57 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers/common/meta.c @@ -2877,6

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

On Tue, Jul 29, 2014 at 5:04 PM, Jason Ekstrand wrote: > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> >> Fixes few failures in gles3 Khronos CTS test: packed_pixels >> >> Cc: "10.2" >> Signed-off-by: Anuj Phogat >> --- >> sr

Re: [Mesa-dev] [PATCH 11/15] mesa: Add a helper function _mesa_is_enum_format_unsized()

On Tue, Jul 29, 2014 at 5:02 PM, Jason Ekstrand wrote: > > > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> >> Function is utilized by next patch in the series. >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main

[Mesa-dev] [PATCH V2] mesa: Add utility function _mesa_is_enum_format_unorm()

V2: Add missing formats. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 71 +++ src/mesa/main/glformats.h | 3 ++ 2 files changed, 74 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 77eee4f

Re: [Mesa-dev] [PATCH 13/15] mesa: Add gles3 error condition for GL_RGBA10_A2 buffer format in glCopyTexImage*()

On Tue, Jul 29, 2014 at 5:05 PM, Jason Ekstrand wrote: > > > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> >> Fixes many failures in gles3 Khronos CTS test: packed_pixels >> >> Khronos bug# 9807 >> Cc: >> Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

Courtney, Should I consider this r-b you? On Wed, Jun 11, 2014 at 11:34 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Very good. I thought there might be something limiting the inputs but > wasn't immediately obvious. > > > On Wed, Jun 11, 2014 at 12:0

[Mesa-dev] [PATCH V2] mesa: Add a helper function _mesa_is_enum_format_unsized()

Function is utilized by next patch in the series. V2: Add missing formats. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 56 +++ src/mesa/main/glformats.h | 3 +++ 2 files changed, 59 insertions(+) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

On Fri, Aug 1, 2014 at 3:03 PM, Jason Ekstrand wrote: > > On Wed, Jun 11, 2014 at 11:09 AM, Anuj Phogat wrote: >> >> Adding mesa-dev to the conversation. >> >> On Wed, Jun 11, 2014 at 10:52 AM, Anuj Phogat >> wrote: >> > >> > On We

[Mesa-dev] [PATCH] meta: Fix blitting a framebuffer with renderbuffer attachment

-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index c62927c..155c4fa 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa

[Mesa-dev] [PATCH 0/3] i965/blorp: Add blorp implementation of single sample scaled blit with linear filter

Anuj Phogat (3): i965/blorp: Use more appropriate variable names i965/blorp: Define a function to clamp texture coordinates i965/blorp: Add support for single sample scaled blit with bilinear filter src/mesa/drivers/dri/i965/brw_blorp.h | 15 +- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/3] i965/blorp: Use more appropriate variable names

filter. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp.h| 8 +++- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 24 +++- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers

[Mesa-dev] [PATCH 2/3] i965/blorp: Define a function to clamp texture coordinates

New function clamp_tex_coords() clamps the texture coordinates to texture boundaries. This function will also be utilized later for the BLORP implementation of single-sample scaled blit with bilinear filter. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 63

[Mesa-dev] [PATCH 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

implementation are out on piglit mailing list. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp.h | 7 +- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 157 -- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +- 3 files changed, 132 insertions

Re: [Mesa-dev] [PATCH 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

On Tue, Aug 6, 2013 at 3:05 PM, Paul Berry wrote: > On 5 August 2013 15:37, Anuj Phogat wrote: > >> Currently single sample scaled blits with GL_LINEAR filter falls >> back to meta path. Patch removes this limitation in BLORP engine >> and implements single sample s

[Mesa-dev] [PATCH V2 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

implementation are out on piglit mailing list. V2: Use "sample" message in place of "LD" message to utilize the linear/nearest filtering (of single-sampled texture) functionality built in to hardware. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp.h

Re: [Mesa-dev] [PATCH] meta: Fix blitting a framebuffer with renderbuffer attachment

On Mon, Aug 5, 2013 at 3:00 PM, Anuj Phogat wrote: > > This patch fixes a case of framebuffer blitting with renderbuffer > as color attachment and GL_LINEAR filter. Meta implementation of > glBlitFrambuffer() converts source color buffer to a texture and > uses it to do the scaled

Re: [Mesa-dev] [PATCH V2 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

On Wed, Aug 14, 2013 at 10:25 AM, Paul Berry wrote: > On 9 August 2013 19:01, Anuj Phogat wrote: >> >> Currently single sample scaled blits with GL_LINEAR filter falls >> back to meta path. Patch removes this limitation in BLORP engine >> and implements single sampl

Re: [Mesa-dev] [PATCH] meta: Fix blitting a framebuffer with renderbuffer attachment

On Wed, Aug 14, 2013 at 1:46 PM, Paul Berry wrote: > On 5 August 2013 15:00, Anuj Phogat wrote: >> >> This patch fixes a case of framebuffer blitting with renderbuffer >> as color attachment and GL_LINEAR filter. Meta implementation of >> glBlitFrambuffer() conver

[Mesa-dev] [PATCH V3 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

message to utilize the linear filtering functionality built in to hardware. V3: Define a bool variable (bilinear_filter) to handle the conditions for GL_LINEAR blits. Signed-off-by: Anuj Phogat --- One subtest of piglit test fbo-blit-stetch fails on Sandybridge with following logs: 45x79 (0,

Re: [Mesa-dev] [PATCH 4/4] glsl: Give a warning, not an error, for UBO qualifiers on struct fields.

* way to get row-major layouts on matrices contained in structures. > -- > 1.8.3.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev This series is Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

g5<8,8,1>F0F > (+f0) if(8) > > For Sandybridge, the hardware designers extended IF to support built-in > comparisons, so you can simply do: > > if.l(8)g5<8,8,1>F0F > > They immediately dropped this with Ivybridge; it's not been present on any > oth

Re: [Mesa-dev] [PATCH 2/2] mesa: Never advertise _S3TC compressed formats

1_RGB8_texture spec says: > * > -- > 1.8.1.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Both patches are: Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Don't try to fall back when creating unrecognized program targets.

n", > target); > + return NULL; > } > } > > -- > 1.8.3.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Allow precision qualifiers for sampler types

ualifiers to be set for sampler types in GLSL (commit d5948f2). This patch makes it follow GLSL ES rules and also allow declaring sampler variables with a precision qualifier in GLSL. This fixes a shader compilation error in Khronos OpenGL conformance test "depth_texture_mipmap". S

Re: [Mesa-dev] [PATCH] glsl: Allow precision qualifiers for sampler types

On Tue, Aug 27, 2013 at 11:53 AM, Ian Romanick wrote: > On 08/27/2013 10:45 AM, Anuj Phogat wrote: >> >> GLSL 1.30 doesn't allow precision qualifiers on sampler types, >> but in GLSL ES, sampler types are also allowed. This seems like >> an oversight (since the

Re: [Mesa-dev] [PATCH] glsl: Allow precision qualifiers for sampler types

On Wed, Aug 28, 2013 at 4:56 PM, Ian Romanick wrote: > On 08/27/2013 12:52 PM, Anuj Phogat wrote: >> On Tue, Aug 27, 2013 at 11:53 AM, Ian Romanick wrote: >>> On 08/27/2013 10:45 AM, Anuj Phogat wrote: >>>> >>>> GLSL 1.30 doesn't allow precision q

Re: [Mesa-dev] [PATCH 1/2] glsl: don't allow non-flat integral types in varying structs/arrays.

pler_index() const > { > diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h > index b0db2bf..8cfd8dd 100644 > --- a/src/glsl/glsl_types.h > +++ b/src/glsl/glsl_types.h > @@ -360,6 +360,12 @@ struct glsl_type { > } > > /** > +* Query whether or not type is an integra

[Mesa-dev] [PATCH] meta: Allocate texture before initializing texture coordinates

tex->Sright and tex->Ttop are initialized during texture allocation. This fixes depth buffer blitting failures in khronos conformance tests when run on desktop GL 3.0. Note: This is a candidate for stable branches. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c

Re: [Mesa-dev] [PATCH] meta: Allocate texture before initializing texture coordinates

On Fri, Feb 15, 2013 at 11:20 AM, Anuj Phogat wrote: > tex->Sright and tex->Ttop are initialized during texture allocation. > This fixes depth buffer blitting failures in khronos conformance tests > when run on desktop GL 3.0. > > Note: This is a candidate for stable branch

Re: [Mesa-dev] [PATCH] meta: Allocate texture before initializing texture coordinates

On Fri, Feb 22, 2013 at 12:28 PM, Patrick Baggett wrote: > > > On Fri, Feb 22, 2013 at 2:23 PM, Ian Romanick wrote: >> >> On 02/15/2013 11:20 AM, Anuj Phogat wrote: >>> >>> tex->Sright and tex->Ttop are initialized during texture allocation. >

Re: [Mesa-dev] Khronos Conformance test

On Mon, Feb 25, 2013 at 6:13 AM, Alle Mahesh wrote: > > Hi, > > > > > > We have run the Khronos test suite on for OpenGLES2.0. There are few failures > in the GL tests because of the difference in the images generated. > > We have found that the images generated using our development board are g

Re: [Mesa-dev] [PATCH] intel: Remove intel_mipmap_tree::wraps_etc

do the > following > -* on calls to glCompressedTexImage2D() with an ETC1/ETC2 texture format: > -* 1. Create a miptree whose format is a suitable uncompressed mesa > format > -* with the wraps_etc flag set. > -* 2. Translate the ETC1/ETC2 data i

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

On Mon, Mar 4, 2013 at 11:38 AM, Matt Turner wrote: > Reported-by: Marek Olšák > --- > src/mesa/main/teximage.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 0dcf88a..e5260d1 100644 > --- a/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

On Mon, Mar 4, 2013 at 11:41 AM, Ian Romanick wrote: > On 03/04/2013 11:38 AM, Matt Turner wrote: >> >> Reported-by: Marek Olšák > > > Do our ETC2 piglit tests run in this mode? It would be good to see this > change actually fix a bug by making a failing test pass. :) > ETC2 tests currently runs

[Mesa-dev] [PATCH] mesa: Fix FB blitting in case of zero size src or dst rect

Framebuffer blitting operation should be skipped if any of the dimensions (width/height) of src/dst rect are zero. Fixes: fbblit(negative.nullblit.zeroSize) in Intel oglconform https://bugs.freedesktop.org/show_bug.cgi?id=59495 Note: Candidate for all the stable branches. Signed-off-by: Anuj

Re: [Mesa-dev] [PATCH] mesa: Fix FB blitting in case of zero size src or dst rect

On Fri, Mar 8, 2013 at 8:02 AM, Paul Berry wrote: > On 7 March 2013 14:15, Anuj Phogat wrote: >> >> Framebuffer blitting operation should be skipped if any of the >> dimensions (width/height) of src/dst rect are zero. >> >> Fixes: fbblit(negative.nullblit.zeroS

[Mesa-dev] [PATCH V2] mesa: Fix FB blitting in case of zero size src or dst rect

=59495 Note: Candidate for all the stable branches. Signed-off-by: Anuj Phogat --- src/mesa/main/fbobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index d6acc58..0126e29 100644 --- a/src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

nternalFormat) { >case GL_COMPRESSED_RGB8_ETC2: >case GL_COMPRESSED_SRGB8_ETC2: > -- > 1.7.8.6 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/blorp: Add INTEL_DEBUG=blorp flag.

fine DEBUG_CLIP 0x200 > #define DEBUG_AUB 0x400 > #define DEBUG_SHADER_TIME 0x800 > +#define DEBUG_BLORP 0x1000 > #define DEBUG_NO16 0x2000 > > #ifdef HAVE_ANDROID_PLATFORM > -- > 1.8.2 > Thanks for this feature. Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] intel: Add a null pointer check before dereferencing the pointer

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/intel/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c index 16750f2..27b992c 100644 --- a/src/mesa/drivers/dri/intel/intel_screen.c

Re: [Mesa-dev] [PATCH] intel: Add a null pointer check before dereferencing the pointer

On Tue, Apr 16, 2013 at 3:06 PM, Matt Turner wrote: > On Tue, Apr 16, 2013 at 11:11 AM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/intel/intel_screen.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >

[Mesa-dev] [PATCH V2] intel: Add a null pointer check before dereferencing the pointer

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/intel/intel_screen.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c index 16750f2..00e7bc6 100644 --- a/src/mesa/drivers/dri/intel

Re: [Mesa-dev] [PATCH 7/7] i965/gen7+: Implement fast color clears for MSAA buffers.

; + */ > + switch (irb->mt->num_samples) { > + case 4: > +x_scaledown = 8; > +break; > + case 8: > +x_scaledown = 2; > +break; > + default: > +assert(!&

Re: [Mesa-dev] [PATCH 7/7] i965/gen7+: Implement fast color clears for MSAA buffers.

gt; contain in-bounds pixels. In theory I believe we could do partial clears if > we first verified that they were aligned, but (a) the bspec doesn't > recommend it, and (b) I doubt there would be much benefit, since > sufficiently aligned clears that don

[Mesa-dev] [PATCH] glsl: Set ARB_texture_rectangle_enable to false if version 100 shader

eck to disable ARB_texture_rectangle for GLSL ES shaders. This fixes Khronos OpenGL CTS test(Texture_Rectangle_Samplers_frag.test) failure on mesa. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/glsl/builtin_types.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --

[Mesa-dev] [PATCH] mesa: Fix error code generation in glBeginConditionalRender()

of a query currently in progress." Signed-off-by: Anuj Phogat Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/condrender.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 3d9b0ec..2632f7a 100644 ---

[Mesa-dev] [PATCH] i965: Fix the region's pitch condition to use blitter

mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c| 6 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH V2 10/10] i965/Gen7: Allow CMS layout for multisample textures

On Sat, Nov 30, 2013 at 3:30 PM, Chris Forbes wrote: > Now that all the pieces are in place, this should provide > a nice performance boost for apps using multisample textures. > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 18 +- > 1 file

[Mesa-dev] [PATCH] glsl: Fix condition to generate shader link error

them allow linking a version 100 shader program in OpenGL context, when one of the shaders is absent. Makes following Khronos CTS tests to pass: successfulcompilevert_linkprogram.test successfulcompilefrag_linkprogram.test Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat ---

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote: > Noticed by tex3d-maxsize on my next commit to check that our addresses > don't overflow. > --- > src/mesa/drivers/dri/i965/intel_blit.c| 20 > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23

Re: [Mesa-dev] [Mesa-stable] [PATCH 7/7] i965: Fix handling of MESA_pack_invert in blit (PBO) readpixels.

format, type, 0, 0, 0); > > if (!_mesa_clip_copytexsubimage(ctx, > -- > 1.8.5.1 > > ___ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > http://lists.f

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

On Sun, Jan 5, 2014 at 2:28 PM, Eric Anholt wrote: > Anuj Phogat writes: > >> On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote: >>> Noticed by tex3d-maxsize on my next commit to check that our addresses >>> don't overflow. >>> --- >>>

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

On Mon, Jan 6, 2014 at 11:00 AM, Kenneth Graunke wrote: > On 01/05/2014 02:28 PM, Eric Anholt wrote: >> Anuj Phogat writes: >> >>> On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote: >>>> Noticed by tex3d-maxsize on my next commit to check th

[Mesa-dev] [PATCH V2] i965: Fix the region's pitch condition to use blitter

intelEmitCopyBlit uses a signed 16-bit integer to represent buffer pitch, so it can only handle buffer pitches < 32k. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- Dropping few changes made in earlier patch. If region->bo->size >= max_gtt_map_object_size, w

[Mesa-dev] [PATCH] i965: Use sample barycentric coordinates with per sample shading

ple barycentric coordinates in case of a fragment shader variable declared with 'sample' qualifier. e.g. sample in vec4 pos; A piglit test to verify the implementation has been posted on piglit mailing list for review. Signed-off-by: Anuj Phogat Cc: Chris Forbes Cc: mesa-sta...@lists

Re: [Mesa-dev] [PATCH 2/2] i965: Fix clears of layered framebuffers with mismatched layer counts.

is_desktop_gl(ctx) && !ctx->Extensions.ARB_ES2_compatibility) { >/* Check that all DrawBuffers are present */ > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index a5294b0..0db7070 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src

Re: [Mesa-dev] [PATCH] i965: Use sample barycentric coordinates with per sample shading

On Thu, Jan 9, 2014 at 4:34 PM, Chris Forbes wrote: > Hi Anuj, > > There's one fiddly interaction that I don't think this handles quite > right, although I think it does conform. > > Suppose we have this fragment shader: > >#version 330 >#extension ARB_gpu_shader5: require > >sample in

Re: [Mesa-dev] [PATCH] i965: Use sample barycentric coordinates with per sample shading

On Fri, Jan 10, 2014 at 5:25 PM, Anuj Phogat wrote: > On Thu, Jan 9, 2014 at 4:34 PM, Chris Forbes wrote: >> Hi Anuj, >> >> There's one fiddly interaction that I don't think this handles quite >> right, although I think it does conform. >&

Re: [Mesa-dev] [PATCH] i965: Use sample barycentric coordinates with per sample shading

On Mon, Jan 13, 2014 at 1:06 PM, Anuj Phogat wrote: > > On Fri, Jan 10, 2014 at 5:25 PM, Anuj Phogat wrote: > > On Thu, Jan 9, 2014 at 4:34 PM, Chris Forbes wrote: > >> Hi Anuj, > >> > >> There's one fiddly interaction that I don't think this h

[Mesa-dev] [PATCH V2 1/3] i965: Add an option to ignore sample qualifier

This will be useful in my next patch which depends on a functionality of _mesa_get_min_invocations_per_fragment() to ignore the sample qualifier (prog->IsSample) based on a flag passed to it. Signed-off-by: Anuj Phogat Cc: Chris Forbes Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/driv

[Mesa-dev] [PATCH V2 3/3] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

quot; But, this text got deleted in later versions of GLSL. NVIDIA's and AMD's proprietary linux drivers (at OpenGL 4.3) interpolates at sample position. This convinces me to use the similar approach on intel hardware. Signed-off-by: Anuj Phogat Cc: Chris Forbes Cc: mesa-sta...@lists.f

[Mesa-dev] [PATCH V2 2/3] i965: Use sample barycentric coordinates with per sample shading

osition if fragment shader uses 'sample' qualifier with one of them. For example we have a fragment shader: #version 330 #extension ARB_gpu_shader5: require sample in vec4 a; in vec4 b; main() { ... } Only 'a' should be sampled at sa

Re: [Mesa-dev] [PATCH 2/5] glsl: Disable ARB_texture_rectangle in shader version 100.

On Fri, Jan 17, 2014 at 9:09 PM, Matt Turner wrote: > From: Anuj Phogat > > OpenGL with ARB_ES2_compatibility allows shaders that specify #version > 100. > > This fixes the Khronos OpenGL test(Texture_Rectangle_Samplers_frag.test) > failure. > > Cc: mesa-sta...@lists

[Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

I missed this change in commit f5cfb4a. It fixes the incorrect rendering caused in Dolphin Emulator. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73915 Cc: Markus wick Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_wm.c | 3 ++- 1

Re: [Mesa-dev] [PATCH 0/3] Update gles2/3 headers

and 3 builds still work afterwards. > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Verified that GLES2 and 3 build work fine. This

[Mesa-dev] [PATCH] mesa: Generate correct error code in glDrawBuffers()

hanges the behaviour to match OpenGL 4.0 spec Fixes Khronos OpenGL CTS draw_buffers_api.test. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/main/buffers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buf

[Mesa-dev] [PATCH V2] mesa: Generate correct error code in glDrawBuffers()

hanges the behaviour to match OpenGL 4.0 spec Fixes Khronos OpenGL CTS draw_buffers_api.test. V2: Update the comment in code. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/main/buffers.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src

[Mesa-dev] [PATCH] mesa: Use location VERT_ATTRIB_GENERIC0 for vertex attribute 0

In OpenGL 3.1 attribute 0 becomes non-magic, just like in OpenGL ES 2.0. Earlier versions of OpenGL used attribute 0 exclusively for vertex position. Fixes 4 Khronos OpenGL CTS failures: glGetVertexAttrib depth24_basic depth24_precision rgb8_rgba8_rgb Cc: Signed-off-by: Anuj Phogat --- src

Re: [Mesa-dev] [PATCH] mesa: fix check for dummy renderbuffer in _mesa_FramebufferRenderbufferEXT()

return; > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] i965: Mark is_tex() and friends as const.

st; > + bool is_control_flow() const; > + bool can_do_source_mods() const; > + bool can_do_saturate() const; > > /** > * True if the instruction has side effects other than writing to > -- > 1.8.3.2 > > __

[Mesa-dev] [PATCH] mesa: Fix querying location of nth element of an array variable

nd NVIDIA matches current output on Mesa (i.e. returns -1). Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/shader_query.cpp | 76 +- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp

[Mesa-dev] [PATCH] mesa: Fix error condition for multisample proxy texture targets

Fixes failures in Khronos OpenGL CTS test proxy_textures_invalid_samples Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 57a766f..aac3887

[Mesa-dev] [PATCH] i965: Add glBlitFramebuffer to commands affected by conditional rendering

Fixes failures in Khronos OpenGL CTS test conditional_render_test9 Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_fbo.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index d0e1349

[Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_blit.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_blit.c index 1ba188c..e3b45f1 100644 --- a/src/mesa/swrast/s_blit.c +++ b/src/mesa/swrast/s_blit.c @@ -29,6 +29,7 @@ #include "

Re: [Mesa-dev] [PATCH 1/2] mesa: Track max enabled tex image unit

gt; > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Looks good to me. Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] i965: Put an assertion to check valid varying_to_slot[varying]

Cc: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/drivers/dri/i965/gen7_sol_state.c index 1b58efb..06a4cdf 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 3/3] i965: Fix component mask and varying_to_slot mapping for gl_ViewportIndex

test glsl-1.50-transform-feedback-builtins pass for 'gl_ViewportIndex'. Cc: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/d

[Mesa-dev] [PATCH 2/3] i965: Fix component mask and varying_to_slot mapping for gl_Layer

glsl-1.50-transform-feedback-builtins pass for 'gl_Layer'. Cc: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/d

Re: [Mesa-dev] Accelerated meta CopyTexSubImage

On Tue, Apr 8, 2014 at 2:54 PM, Ian Romanick wrote: > On 04/08/2014 02:03 PM, Eric Anholt wrote: >> Here's a rework of the series for meta CopyTexSubImage (required for >> i965's gen8 support, since we're probably going to avoid doing blorp at >> all for it). Ken had almost-reviewed a previous ve

Re: [Mesa-dev] [PATCH] meta: Clip src/dest rects in BlitFramebuffer, using the scissor

able the scissor to clip to it. > +*/ > + if (clip.dstX0 != dstX0 || clip.dstY0 != dstY0 || > + clip.dstX1 != dstX1 || clip.dstY1 != dstY1) { > + _mesa_set_enable(ctx, GL_SCISSOR_TEST, GL_TRUE); > + _mesa_Scissor(MIN2(clip.dstX0, clip.dstX1), > +

Re: [Mesa-dev] [Mesa-stable] Old, outstanding patches nominated for the stable branch

t; nv30: report the correct max varying limit (Jan 29, Ilia Mirkin) > > mesa: Fix error code generation in glReadPixels() (Feb 14, Anuj Phogat) > > mesa: Add GL_TEXTURE_CUBE_MAP_ARRAY to > legal_get_tex_level_parameter_target() (Feb 14, Anuj Phogat)

Re: [Mesa-dev] [PATCH] i965: Add glBlitFramebuffer to commands affected by conditional rendering

It would be nice to pick it up to the stable branches. Adding mesa-sta...@lists.freedesktop.org. On Wed, Apr 16, 2014 at 10:48 PM, Kenneth Graunke wrote: > On 04/07/2014 10:55 AM, Anuj Phogat wrote: >> Fixes failures in Khronos OpenGL CTS test conditional_render_test9 >> >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Add an error condition in glGetFramebufferAttachmentParameteriv()

On Fri, Apr 18, 2014 at 4:17 PM, Ian Romanick wrote: > On 03/11/2014 05:33 PM, Anuj Phogat wrote: >>>From the OpenGL 4.4 spec page 275: >> "If pname is FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE, param will >>contain the format of components of the specified attach

Re: [Mesa-dev] [PATCH] i965: Use uint16_t for control/src index tables.

atic void > set_uncompacted_src1(struct brw_instruction *dst, > struct brw_compact_instruction *src) > { > - uint32_t uncompacted = src_index_table[src->dw1.src1_index]; > + uint16_t uncompacted = src_index_table[src->dw1.src1_index]; > > dst->bits3.ud |= uncompacted << 13; > } > -- > 1.8.3.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965: Put an assertion to check valid varying_to_slot[varying]

On Mon, Apr 21, 2014 at 11:48 AM, Carl Worth wrote: > Anuj Phogat writes: >>decl |= buffer << SO_DECL_OUTPUT_BUFFER_SLOT_SHIFT; >> + assert(vue_map->varying_to_slot[varying] >= 0); >>decl |= vue_map->varying_to_slot[varying] <<

Re: [Mesa-dev] [Mesa-stable] [PATCH V3 03/10] mesa: Add error condition for integer formats in glGetTexImage()

On Mon, Apr 21, 2014 at 11:42 AM, Carl Worth wrote: > Anuj Phogat writes: >> OpenGL 4.0 spec, page 306 suggests an INVALID_OPERATION in glGetTexImage >> if : >>"format is one of the integer formats in table 3.3 and the internal >> format of the texture im

Re: [Mesa-dev] [Mesa-stable] [PATCH V2] glsl: Allow overlapping locations for vertex input attributes

On Fri, Apr 18, 2014 at 4:11 PM, Ian Romanick wrote: > On 03/24/2014 04:33 PM, Anuj Phogat wrote: >> Currently overlapping locations of input variables are not allowed for all >> the shader types in OpenGL and OpenGL ES. >> >>>From OpenGL ES 3.0 spec, page 56

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Use location VERT_ATTRIB_GENERIC0 for vertex attribute 0

On Fri, Apr 18, 2014 at 3:52 PM, Ian Romanick wrote: > On 03/31/2014 02:00 PM, Anuj Phogat wrote: >> In OpenGL 3.1 attribute 0 becomes non-magic, just like in >> OpenGL ES 2.0. Earlier versions of OpenGL used attribute 0 >> exclusively for vertex position. >> &g

<    1   2   3   4   5   6   7   8   9   10   >