Re: [Mesa-dev] [PATCH v2] gallium: Implement APPLE_object_purgeable (iris, freedeno, vc4)

2019-02-27 Thread Chris Wilson
Quoting Eric Anholt (2019-02-27 02:19:32) > Overall, I'm hesitatant to land support for actually doing anything with > APPLE_object_purgeable when there are no functional tests of it. I > don't mean to actually have tests that force purging, but at least > making sure that we don't accidentally br

Re: [Mesa-dev] [PATCH v4 33/40] intel/compiler: also set F execution type for mixed float mode in BDW

2019-02-27 Thread Iago Toral
On Tue, 2019-02-26 at 13:55 -0800, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > The section 'Execution Data Types' of 3D Media GPGPU volume, which > > describes execution types, is exactly the same in BDW and SKL+. > > > > Also, this section states that there is a single execution t

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-02-27 Thread Iago Toral
On Tue, 2019-02-26 at 14:54 -0800, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > --- > > src/intel/compiler/brw_eu_validate.c| 64 - > > src/intel/compiler/test_eu_validate.cpp | 122 > > > > 2 files changed, 185 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH v4 35/40] intel/compiler: validate conversions between 64-bit and 8-bit types

2019-02-27 Thread Iago Toral
On Tue, 2019-02-26 at 15:50 -0800, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > --- > > src/intel/compiler/brw_eu_validate.c| 10 +- > > src/intel/compiler/test_eu_validate.cpp | 46 > > + > > 2 files changed, 55 insertions(+), 1 deletion(-) > > > >

[Mesa-dev] [Bug 109535] [Tracker] Mesa 19.0 release tracker

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109535 Bug 109535 depends on bug 109594, which changed state. Bug 109594 Summary: totem assert failure: totem: src/intel/genxml/gen9_pack.h:72: __gen_uint: La declaración `v <= max' no se cumple. https://bugs.freedesktop.org/show_bug.cgi?id=109594

Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit

2019-02-27 Thread Christian Gmeiner
Am Mi., 27. Feb. 2019 um 05:48 Uhr schrieb Alyssa Rosenzweig : > > Signed-off-by: Alyssa Rosenzweig > --- > src/gallium/drivers/panfrost/include/panfrost-job.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h > b/src/gallium/drivers/p

Re: [Mesa-dev] [PATCH v2 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Lucas Stach
Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > Changes v1 -> v2: >  - Avoid the GPU sampling from the resource that gets mutated by the the >    transfer map by setting DRM_ETNA_PREP_WRITE. > > > Signed-off-by: Christian Gmeiner > --- >  .../drivers/etnaviv/etnaviv_resource

Re: [Mesa-dev] [PATCH v2 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Lucas Stach
Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > ETC2 is supported with HALTI0, however that implementation is buggy > in hardware. The blob driver does per-block patching to work around > this. We need to swap colors for t-mode etc2 blocks. > > > Signed-off-by: Christian Gmei

Re: [Mesa-dev] [PATCH v2 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-27 Thread Lucas Stach
Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >  src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- >  1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/src/gallium/drivers/etnavi

[Mesa-dev] [PATCH v5 33/40] intel/compiler: also set F execution type for mixed float mode in BDW

2019-02-27 Thread Iago Toral Quiroga
The section 'Execution Data Types' of 3D Media GPGPU volume, which describes execution types, is exactly the same in BDW and SKL+. Also, this section states that there is a single execution type, so it makes sense that this is the wider of the two floating point types involved in mixed float mode,

Re: [Mesa-dev] [PATCH] st/dri: allow direct UYVY import

2019-02-27 Thread Lionel Landwerlin
On 27/02/2019 06:55, Kenneth Graunke wrote: On Tuesday, February 26, 2019 9:41:07 AM PST Christian Gmeiner wrote: Push this format to the pipe driver unchanged. Signed-off-by: Christian Gmeiner --- include/GL/internal/dri_interface.h | 1 + src/gallium/state_trackers/dri/dri2.c | 2 ++ 2

[Mesa-dev] [PATCH] nir/spirv: return after emitting a branch in block

2019-02-27 Thread Juan A. Suarez Romero
When emitting a branch in a block, it does not make sense to continue processing further instructions, as they will not be reachable. This fixes a nasty case with a loop with a branch that both then-part and else-part exits the loop: %1 = OpLabel OpLoopMerge %2 %3 None OpBranchCondition

[Mesa-dev] [Bug 109788] vulkan-overlay-layer: Only installs 64bit version

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109788 Lionel Landwerlin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #48 from asimiklit --- (In reply to Mark Janes from comment #46) > I confirmed that the cross file is overriding our 32 bit flags that we pass > through the environment. (In reply to Dylan Baker from comment #47) > Created attachmen

[Mesa-dev] [PATCH 1/3] intel/compiler: allow constant propagation for int quotient and reminder

2019-02-27 Thread Iago Toral Quiroga
And let combine constants promote the constants if needed. --- src/intel/compiler/brw_fs_combine_constants.cpp | 2 ++ src/intel/compiler/brw_fs_copy_propagation.cpp | 4 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_fs_combine_constants.cpp b/src/int

[Mesa-dev] [PATCH 0/3] intel: propagate constants to first source of 2-src instructions

2019-02-27 Thread Iago Toral Quiroga
This little series lives on top of my VK_KHR_shader_float16_int8 branch, since it depends on having a more flexible combine constants pass, which is included with that work. A branch with that on this series is available here: https://github.com/Igalia/mesa/tree/itoral/VK_KHR_shader_float16_int8_c

[Mesa-dev] [PATCH 3/3] intel/compiler: implement more algebraic optimizations

2019-02-27 Thread Iago Toral Quiroga
Now that we propagate constants to the first source of 2src instructions we see more opportunities of constant folding in the backend. Shader-db results on KBL: total instructions in shared programs: 14965607 -> 14855983 (-0.73%) instructions in affected programs: 3988102 -> 3878478 (-2.75%) help

[Mesa-dev] [PATCH 2/3] intel/compiler: allow constant propagation to first source of 2-src instructions

2019-02-27 Thread Iago Toral Quiroga
Even if it is not supported by the hardware, we will fix it up in the combine constants pass. --- .../compiler/brw_fs_combine_constants.cpp | 37 ++--- .../compiler/brw_fs_copy_propagation.cpp | 55 +-- 2 files changed, 56 insertions(+), 36 deletions(-) diff --git

[Mesa-dev] [Bug 109791] The mesa release configuration can't be build using meson 0.45.0

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109791 Bug ID: 109791 Summary: The mesa release configuration can't be build using meson 0.45.0 Product: Mesa Version: git Hardware: Other OS: All Sta

[Mesa-dev] [Bug 109791] The mesa release configuration can't be build using meson 0.45.0

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109791 asimiklit changed: What|Removed |Added CC||andrey.simiklit.1989@gmail.

[Mesa-dev] [Bug 109791] The mesa release configuration can't be build using meson 0.45.0

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109791 --- Comment #1 from Eero Tamminen --- >The mesa release configuration can't be build using meson 0.45.0 Does this mean that the build actually fails, or... > -DNDEBUG is not passed to GCC, even if buildtype=release b_ndebug=true ...just that

[Mesa-dev] [Bug 109791] The mesa release config doesn't define NDEBUG when building using meson 0.45.0

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109791 asimiklit changed: What|Removed |Added Summary|The mesa release|The mesa release config |

Re: [Mesa-dev] [PATCH v2 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:19 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > Changes v1 -> v2: > > - Avoid the GPU sampling from the resource that gets mutated by the the > >transfer map by setting DRM_ETNA_PREP_WRITE. > > > > >

Re: [Mesa-dev] [PATCH v2 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:22 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > ETC2 is supported with HALTI0, however that implementation is buggy > > in hardware. The blob driver does per-block patching to work around > > this. We nee

Re: [Mesa-dev] [PATCH v2] gallium: Implement APPLE_object_purgeable (iris, freedeno, vc4)

2019-02-27 Thread Eric Anholt
Chris Wilson writes: > Quoting Eric Anholt (2019-02-27 02:19:32) >> Overall, I'm hesitatant to land support for actually doing anything with >> APPLE_object_purgeable when there are no functional tests of it. I >> don't mean to actually have tests that force purging, but at least >> making sure

Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit

2019-02-27 Thread Alyssa Rosenzweig
> super nitpicking: What is the purpose of this change? Should this > define be added when it really gets used? I mean, we don't have explicit documentation on the cmdstream; if I don't add the define / enum / struct / whatever in, it will be forgotten to time.

[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #7 from Alex Granni --- I'd go for this way as 3.0.4 is also affected: diff --git a/scons/gallium.py b/scons/gallium.py index 963834a5fbc..565f19f3f1a 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -308,7 +308,10 @@ def gen

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #49 from Ian Romanick --- After discussing https://github.com/KhronosGroup/OpenGL-API/issues/46 in the Khronos call today, I realized that my thinking about this bug may have been slightly incorrect. I believe that there are two sep

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: implement more algebraic optimizations

2019-02-27 Thread Ian Romanick
On 2/27/19 4:45 AM, Iago Toral Quiroga wrote: > Now that we propagate constants to the first source of 2src instructions we > see more opportunities of constant folding in the backend. All the benefit of the series is from more constant folding? Once upon a time, I had a patch that added another

Re: [Mesa-dev] [PATCH] nir/spirv: return after emitting a branch in block

2019-02-27 Thread Jason Ekstrand
Those fuzzing guys are mean... This stuff is subtle but I think this is correct. Assuming you've run it through our CI and everything is good, Reviewed-by: Jason Ekstrand On Wed, Feb 27, 2019 at 5:05 AM Juan A. Suarez Romero wrote: > When emitting a branch in a block, it does not make sense

Re: [Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-02-27 Thread Gurchetan Singh
On Mon, Feb 25, 2019 at 12:35 AM Boris Brezillon wrote: > > From: Daniel Stone > > pipe_boxes are x/y + width/height, rather than x0/y0 -> x1/y1. This > means that (x+width) is not included in the box. > > The box intersection check was seemingly written for inclusive regions, > and would falsely

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-02-27 Thread Francisco Jerez
Iago Toral writes: > On Tue, 2019-02-26 at 14:54 -0800, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > --- >> > src/intel/compiler/brw_eu_validate.c| 64 - >> > src/intel/compiler/test_eu_validate.cpp | 122 >> > >> > 2 files changed, 185

[Mesa-dev] [PATCH 3/3] omx: add a compute path in enc_LoadImage_common

2019-02-27 Thread Marek Olšák
From: Marek Olšák --- .../state_trackers/omx/bellagio/vid_enc.c | 3 + .../state_trackers/omx/tizonia/h264eprc.c | 3 + .../state_trackers/omx/vid_enc_common.c | 219 +++--- .../state_trackers/omx/vid_enc_common.h | 8 +- 4 files changed, 196 insertions(+),

[Mesa-dev] [PATCH 1/3] gallium: add pipe_grid_info::last_block

2019-02-27 Thread Marek Olšák
From: Marek Olšák The OpenMAX state tracker will use this. RadeonSI is adapted to use pipe_grid_info::last_block instead of its internal state. --- src/gallium/auxiliary/util/u_screen.c | 3 +++ src/gallium/docs/source/screen.rst| 2 ++ src/gallium/drivers/radeonsi/si_comp

[Mesa-dev] [PATCH 2/3] omx: clean up enc_LoadImage_common

2019-02-27 Thread Marek Olšák
From: Marek Olšák - add *pipe - add documentation --- .../state_trackers/omx/vid_enc_common.c | 53 +-- 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_enc_common.c b/src/gallium/state_trackers/omx/vid_enc_common.c index 2

[Mesa-dev] [PATCH 1/2] st/nine: Ignore window size if error

2019-02-27 Thread Axel Davy
Check GetWindowInfo and ignore the computed sizes if there is an error. Fixes the regression caused by: commit 2318ca68bbeb4fa6e21a4d8c650cec3f64246596 "st/nine: Handle window resize when a presentation buffer is used" when using old wine gallium nine patches Related issues: https://github.com/iX

[Mesa-dev] [PATCH 2/2] st/nine: Ignore multisample quality level if no ms

2019-02-27 Thread Axel Davy
Apparently instead of returning error when passing a quality level different than 0 for D3DMULTISAMPLE_NONE, we should pass. Fixes: https://github.com/iXit/Mesa-3D/issues/340 Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_pipe.h | 4

[Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-02-27 Thread marcandre . lureau
From: Marc-André Lureau Since commit d877451b48a59ab0f9a4210fc736f51da5851c9a ("util/u_queue: add UTIL_QUEUE_INIT_SET_FULL_THREAD_AFFINITY"), mesa calls sched_setaffinity syscall. Unfortunately, qemu crashes with SIGSYS when sandboxing is enabled (by default with libvirt), as this syscall is filt

[Mesa-dev] [PATCH] radeonsi: fix assertion failure by using the correct type

2019-02-27 Thread Marek Olšák
From: Marek Olšák src/gallium/drivers/radeonsi/si_state_viewport.c:196: si_emit_guardband: Assertion `vp_as_scissor.maxx <= max_viewport_size[vp_as_scissor.quant_mode] && vp_as_scissor.maxy <= max_viewport_size[vp_as_scissor.quant_mode]' failed. The comparison was unsigned, so negative maxx or m

Re: [Mesa-dev] [PATCH v5 33/40] intel/compiler: also set F execution type for mixed float mode in BDW

2019-02-27 Thread Francisco Jerez
Iago Toral Quiroga writes: > The section 'Execution Data Types' of 3D Media GPGPU volume, which > describes execution types, is exactly the same in BDW and SKL+. > > Also, this section states that there is a single execution type, so it > makes sense that this is the wider of the two floating poi

Re: [Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-02-27 Thread Marek Olšák
I'd rather have something more robust than an env var, like catching SIGSYS. Marek On Wed, Feb 27, 2019 at 6:13 PM wrote: > From: Marc-André Lureau > > Since commit d877451b48a59ab0f9a4210fc736f51da5851c9a ("util/u_queue: > add UTIL_QUEUE_INIT_SET_FULL_THREAD_AFFINITY"), mesa calls > sched_set

Re: [Mesa-dev] [PATCH] glsl: fix shader cache for packed param list

2019-02-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 27, 2019 at 2:26 AM Timothy Arceri wrote: > Some types of params such as some builtins are always padded. We > need to keep track of this so we can restore the list correctly. > > Here we also remove a couple of cache entries that are not actually > r

Re: [Mesa-dev] [PATCH] gallium: Implement APPLE_object_purgeable (iris, freedeno, vc4)

2019-02-27 Thread Marek Olšák
On Tue, Feb 26, 2019 at 4:39 PM Chris Wilson wrote: > A few of the GEM drivers provide matching ioctls to allow control of > their bo caches. Hook these up to APPLE_object_purgeable to allow > clients to discard video memory under pressure where they are able to > fallback to restoring content th

Re: [Mesa-dev] [PATCH] radeonsi/nir: move si_lower_nir() call into compiler thread

2019-02-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Feb 26, 2019 at 10:30 PM Timothy Arceri wrote: > This helps improve compile times. For example the shader-db dolphin > shader shaders/dolphin/ubershaders/120.shader_test goes from > ~1.69 -> ~1.57 seconds on my machine with this change. > --- > src/galli

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: implement more algebraic optimizations

2019-02-27 Thread Ian Romanick
On 2/27/19 4:45 AM, Iago Toral Quiroga wrote: > Now that we propagate constants to the first source of 2src instructions we > see more opportunities of constant folding in the backend. > > Shader-db results on KBL: > > total instructions in shared programs: 14965607 -> 14855983 (-0.73%) > instruc

[Mesa-dev] [PATCH v3 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-27 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index de822fc85

[Mesa-dev] [PATCH v3 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Changes v2 -> v3: - Drop redundant format check Signed-off-by: Christian Gmeiner Acked-by: Lucas Stach --

[Mesa-dev] [PATCH v3 2/4] etnaviv: keep track of mapped bo address

2019-02-27 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19 ++

[Mesa-dev] [PATCH v3 0/4] Add ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
HALTI0 GPUs have broken ETC2 support (for RGB and RGBA) formats. The blob driver does per-block patching. The patching is quite simple: color swaping. This patch series adds support for the needed block patching and enabled ETC2 support for HALTI0. Passes all tested formats of the following pigli

[Mesa-dev] [PATCH v3 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Christian Gmeiner
Changes v1 -> v2: - Avoid the GPU sampling from the resource that gets mutated by the the transfer map by setting DRM_ETNA_PREP_WRITE. Changes v2 -> v3: - make use of likely(..) - drop minor optimization regarding rsc->layout == ETNA_LAYOUT_LINEAR - better documentation why DRM_ETNA_PREP_WR

Re: [Mesa-dev] [PATCH v3 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Lucas Stach
Am Donnerstag, den 28.02.2019, 07:26 +0100 schrieb Christian Gmeiner: > Changes v1 -> v2: > - Avoid the GPU sampling from the resource that gets mutated by the the >transfer map by setting DRM_ETNA_PREP_WRITE. > > Changes v2 -> v3: > - make use of likely(..) > - drop minor optimization rega

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-02-27 Thread Iago Toral
On Wed, 2019-02-27 at 13:47 -0800, Francisco Jerez wrote: > Iago Toral writes: > > > On Tue, 2019-02-26 at 14:54 -0800, Francisco Jerez wrote: > > > Iago Toral Quiroga writes: > > > > > > > --- > > > > src/intel/compiler/brw_eu_validate.c| 64 - > > > > src/intel/compiler/test

Re: [Mesa-dev] [PATCH v5 33/40] intel/compiler: also set F execution type for mixed float mode in BDW

2019-02-27 Thread Iago Toral
On Wed, 2019-02-27 at 15:44 -0800, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > The section 'Execution Data Types' of 3D Media GPGPU volume, which > > describes execution types, is exactly the same in BDW and SKL+. > > > > Also, this section states that there is a single execution t

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: implement more algebraic optimizations

2019-02-27 Thread Iago Toral
On Wed, 2019-02-27 at 17:04 -0800, Ian Romanick wrote: > On 2/27/19 4:45 AM, Iago Toral Quiroga wrote: > > Now that we propagate constants to the first source of 2src > > instructions we > > see more opportunities of constant folding in the backend. > > > > Shader-db results on KBL: > > > > total