Re: [Mesa-dev] [PATCH 01/18] meson: don't require glx/egl/gbm with gallium drivers

Quoting Emil Velikov (2018-12-13 08:05:50) > From: Emil Velikov > > The gallium drivers do not require a DRI loader. Drop the artificial > and unnecessary restriction. > > Fixes: af9d276134d ("meson: build libmesa_gallium") > Signed-off-by: Emil Velikov > --- > There are a few use cases: > >

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

Quoting Emil Velikov (2018-12-13 08:15:57) > From: Emil Velikov > > Reasonably often people will want to build the loader w/o any drivers. > Be that debugging an issue in the former, distribution bundle or other. > > Currently there is an artificial restriction preventing people to build > a con

Re: [Mesa-dev] last call for autotools

On Fri, Dec 14, 2018 at 11:25 AM Andre Heider wrote: > On 14/12/2018 17:53, Dylan Baker wrote: > > Quoting Gert Wollny (2018-12-14 03:44:32) > >> Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > >> (2) It would be nice if Meson would distribute some default cross build > >> files, cu

[Mesa-dev] [PATCH] radv: don't set surf_index for stencil-only images

Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116 Signed-off-by: Rhys Perry --- Unfortunately I was not able to test this patch on a Polaris due to hardware issues. It fixed the deqp-vk tests mentioned in the

Re: [Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

Quoting Christian Gmeiner (2018-12-13 12:07:23) > Signed-off-by: Christian Gmeiner > --- > meson.build | 2 +- > meson_options.txt | 2 +- > src/gallium/drivers/etnaviv/meson.build | 3 ++- > 3 files changed, 4 insertions(+), 3 deletions(-) > > d

[Mesa-dev] [PATCH 0/2] appveyor: add Cygwin

This is a refresh of my patch set from [1], which I posted, and then kind of forgot about. [1] https://lists.freedesktop.org/archives/mesa-dev/2018-February/185066.html Jon Turney (2): appveyor: put build steps in a script, rather than inline in appveyor.yml appveyor: Add a Cygwin build

[Mesa-dev] [PATCH 2/2] appveyor: Add a Cygwin build script

Signed-off-by: Jon Turney --- appveyor.yml| 19 +- scripts/appveyor_cygwin.bat | 40 + 2 files changed, 54 insertions(+), 5 deletions(-) create mode 100644 scripts/appveyor_cygwin.bat diff --git a/appveyor.yml b/appveyor.yml in

[Mesa-dev] [PATCH 1/2] appveyor: put build steps in a script, rather than inline in appveyor.yml

Signed-off-by: Jon Turney --- appveyor.yml | 32 +++- scripts/appveyor_msvc.bat | 38 ++ 2 files changed, 41 insertions(+), 29 deletions(-) create mode 100644 scripts/appveyor_msvc.bat diff --git a/appveyor.yml b/appve

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On 14/12/2018 15:15, Emil Velikov wrote: On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as functions prototyped by it are used in the

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] pci_ids: add new vega10 pci ids

Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:01 PM Alex Deucher wrote: > Ping? > > Alex > On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > > > Signed-off-by: Alex Deucher > > Cc: mesa-sta...@lists.freedesktop.org > > --- > > include/pci_ids/radeonsi_pci_ids.h | 8 +++-

Re: [Mesa-dev] [PATCH] st/nir: Use nir_src_as_uint for tokens

Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:20 PM Jason Ekstrand wrote: > --- > src/mesa/state_tracker/st_nir_lower_builtin.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c > b/src/mesa/state_tracker/st

Re: [Mesa-dev] last call for autotools

On Fri, 14 Dec 2018 at 16:19, Ilia Mirkin wrote: > > I have to say that the user experience for autotools is WAY better > than for meson. As a concrete example, I had a meson build. Then I > updated meson (0.48.1 to 0.48.2). Now ninja -C foo doesn't work. meson > --reconfigure (which presumably is

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

For patches 1-3: Reviewed-by: Marek Olšák I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y,z,undef) and (x,y,undef,undef) where the vertex shader is a SSO. Marek On Mon, D

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

Can you please call it invalidate_subresource and inline relevant pipe_surface variables inside the parameters? Thanks, Marek On Wed, Dec 12, 2018 at 10:48 AM Rob Clark wrote: > A new API to implement glInvalidateFramebuffer() and friends. It is > similar to invalidate_resource() but can be us

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

I don't mind renaming it to invalidate_subsurface() if you prefer that, but I really prefer that it takes a surface rather than a resource... pipe_resource is the wrong level to do this. Even though surfaces are transient, tracking the invalidate state in the surface works out much easier in the d

[Mesa-dev] [PATCH v2] nvc0/ir: replace cvt instructions with add to improve shader performance

gives me an performance boost of 0.2% in pixmark_piano on my gk106, gm204 and gp107. changes in shader-db: total instructions in shared programs : 7614782 -> 7614782 (0.00%) total cvt instructions in shared programs : 139343 -> 95856 (-31.21%) total gprs used in shared programs: 79804

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

The way I see it, pipe_surface is a render target view for pipe_framebuffer_state. The fact that other functions also accept pipe_surface is a historic artifact. resource_copy_region used to accept 2 pipe_surfaces before it was changed to 2 pipe_resources + parameters. Somebody might decide to chan

[Mesa-dev] [PATCH 1/6] radeonsi: don't emit redundant PKT3_NUM_INSTANCES packets

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 3 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 9 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h index 1d677d29e

[Mesa-dev] [PATCH 3/6] radeonsi: make si_cp_wait_mem more configurable

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_fence.c | 6 ++ src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_query.c | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++-

[Mesa-dev] [PATCH 5/6] radeonsi: remove unused variables in si_insert_input_ptr

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 68afff449fd..250e0cc5db4 100644 --- a/src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 2/6] radeonsi: call si_fix_resource_usage for the GS copy shader as well

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index ee0c668431c..68afff449fd 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/s

[Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

From: Marek Olšák Team Fortress 2 32-bit version runs out of the CPU address space. --- src/gallium/drivers/radeonsi/si_texture.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_texture.c b/src/gallium/drivers/radeonsi/si_texture.c index 95f

[Mesa-dev] [PATCH 4/6] radeonsi: use u_decomposed_prims_for_vertices instead of u_prims_for_vertices

From: Marek Olšák It seems to be the same, but this doesn't use integer division with a variable divisor. --- src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/ra

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

https://bugs.freedesktop.org/show_bug.cgi?id=108946 Andrew Keller changed: What|Removed |Added CC||andrew@thekellers.email -- You are rec

[Mesa-dev] [PATCH v3 07/24] mapi: move genCommon.py to src/mapi/new

From: Emil Velikov The helper will also be used by the new Khronos gl.xml aware generator. v2: Move existing one, instead of duplicating it. v3: Correct genCommon.py references in meson [Erik] Suggested-by: Kyle Brenneman Signed-off-by: Emil Velikov --- src/egl/Makefile.am

[Mesa-dev] [PATCH v3 17/24] meson: wire the new generator for es1 and es2

From: Emil Velikov v2: use ${foo})_py naming (Dylan) v3: use symbolic name for genCommon.py Signed-off-by: Emil Velikov --- src/mapi/es1api/meson.build| 6 +++--- src/mapi/es2api/meson.build| 6 +++--- src/mapi/glapi/gen/meson.build | 7 +++ src/mapi/meson.build | 1 + 4

Re: [Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

On Fri, 14 Dec 2018 at 14:33, Erik Faye-Lund wrote: > > On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > > From: Emil Velikov > > > > The helper will also be used by the new Khronos gl.xml aware > > generator. > > > > v2: Move existing one, instead of duplicating it. > > > > Suggested-by:

Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

Hi Marek, That seems a good idea. Several 32bits games have virtual address space issues as well with both Nine and Wine (but Nine seems a bit more affected because more libs are loaded). Maybe the patch could go a little bit further by doing the same for buffers the first time they si_buffe

[Mesa-dev] [PATCH 3/3] nv50/ir: convert slct with boolean result to set

From: Karol Herbst helps mainly feral ported games changes in shader-db: total instructions in shared programs : 7565661 -> 7545812 (-0.26%) total gprs used in shared programs: 797213 -> 797088 (-0.02%) total shared used in shared programs : 639636 -> 639636 (0.00%) total local

[Mesa-dev] [PATCH 2/3] nv50/ir: optimize slct(b, c, set(a, 0)) to slct(b, c, a)

From: Karol Herbst helps mainly feral ported games shader-db changes: total instructions in shared programs : 7614782 -> 7565661 (-0.65%) total gprs used in shared programs: 798045 -> 797213 (-0.10%) total shared used in shared programs : 639636 -> 639636 (0.00%) total local use

[Mesa-dev] [PATCH 1/3] nv50/ir: clean up src2 in ConstantFolding

no changes in shader-db Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 5d3b4aba

Re: [Mesa-dev] last call for autotools

Quoting Dave Airlie (2018-12-14 12:27:35) > On Fri, 14 Dec 2018 at 16:19, Ilia Mirkin wrote: > > > > I have to say that the user experience for autotools is WAY better > > than for meson. As a concrete example, I had a meson build. Then I > > updated meson (0.48.1 to 0.48.2). Now ninja -C foo does

[Mesa-dev] [PATCH] i965: Don't override subslice count to 4 on Gen11.

Gen9-10 have fewer than 4 subslices per slice, so they need this to be rounded up. Gen11 isn't documented as needing this hack, and it can also have more than 4 subslices, so the hack actually can break things. --- src/mesa/drivers/dri/i965/brw_program.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] SPIR-V: Use NIR deref instructions for UBO/SSBO access

New MR: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/17 This MR begins the process of being able to optimize external memory access by first moving us over to using deref instructions for UBO/SSBO access. Many of the patches are cleanups or fairly small refactors of NIR or SPIR-V. More

[Mesa-dev] [PATCH] st/mesa: remove sampler associated with buffer texture in pbo logic

A long time ago, when this was first implemented, not having a sampler bound would cause problems on Fermi. I didn't work out the reasons, but the solution was simple -- just put the samplers back in. Since then, regular texturing paths appear to have lost their associated samplers which required

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák mailto:marek.ol...@amd.com>> Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 1:16 pm, Timothy Arceri wrote: On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák > Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,unde

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: clean up src2 in ConstantFolding

On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > no changes in shader-db > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp > b/

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On Fri, Dec 14, 2018 at 9:16 PM Timothy Arceri wrote: > On 15/12/18 7:32 am, Marek Olšák wrote: > > For patches 1-3: > > > > Reviewed-by: Marek Olšák marek.ol...@amd.com>> > > > > Thanks! > > > I'm not so knowledgeable to be able to comment on patch 4. > > > > Does it also merge varyings such as

Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

I don't plan to do anything else if this patch is enough to fix certain 32-bit games. Marek On Fri, Dec 14, 2018 at 6:10 PM Axel Davy wrote: > Hi Marek, > > That seems a good idea. > Several 32bits games have virtual address space issues as well with both > Nine and Wine (but Nine seems a bit m

<    1   2