Pointer dri2_dpy->device_name is probably NULL when calling
dri2_display_destory, check this before releasing it.
Signed-off-by: Zhaowei Yuan
---
src/egl/drivers/dri2/egl_dri2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/driver
On 10/30/18 8:26 AM, Zhaowei Yuan wrote:
Pointer dri2_dpy->driver_name is probably NULL when calling
dri2_display_destory, check this before releasing it.
It's fine for it to be NULL though and it looks like all the drivers set
it correctly, there is no need for such check. Does this change fi
Yeah, this looks correct. I did not realize x86.mk does not have it
since all the targets we use with Celadon have it set.
Reviewed-by: Tapani Pälli
On 10/29/18 1:59 PM, Mauro Rossi wrote:
x86 32 bit generic target does not enable ARCH_X86_HAVE_SSE4_1
for this reason all Android library modul
Some quick comments on this after experimenting with it:
Intel hardware produces booleans of the same bit-size as the operations
that generates them so I am working on expanding this to add another
lowering pass that can lower them to smaller bit-sizes.
I have a work-in-progress prototype of this
wt., 30 paź 2018, 06:08 :
> From: Mathias Fröhlich
>
> On finishing a display list playback the VBO_SAFE_FALLBACK bit
>
s/SAFE/SAVE/g (here and in the title)
Regards,
Gustaw Smolarczyk
is still kept in vbo_save_context::replay_flags. But examining
> replay_flags and the display list flags that
From: Michał Janiszewski
Signed-off-by: Michał Janiszewski
---
src/glx/dri2_priv.h | 5 +
src/glx/drisw_priv.h | 5 +
src/glx/glx_error.h | 6 ++
3 files changed, 16 insertions(+)
diff --git a/src/glx/dri2_priv.h b/src/glx/dri2_priv.h
index 30ab2cdd87..a93551b146 100644
--- a/src
From: Michał Janiszewski
Signed-off-by: Michał Janiszewski
---
src/mesa/main/texcompress_bptc_tmp.h | 5 +
src/mesa/main/texcompress_s3tc_tmp.h | 5 +
src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 +
src/mesa/state_tracker/st_shader_cache.h | 5 +
4 files changed, 20 inse
From: Michał Janiszewski
Signed-off-by: Michał Janiszewski
---
src/compiler/glsl/ir_builder.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/ir_builder.h b/src/compiler/glsl/ir_builder.h
index ff1ff709c9..9309039f9d 100644
--- a/src/compiler/glsl/ir_builder.h
+++ b/s
From: Michał Janiszewski
Signed-off-by: Michał Janiszewski
---
src/gallium/drivers/svga/include/svga3d_surfacedefs.h | 5 +
src/gallium/winsys/svga/drm/vmw_shader.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/src/gallium/drivers/svga/include/svga3d_surfacedefs.h
b/sr
To match latest spec.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 63a1fd6dff..c43e12f6d6 100644
--- a/src/amd/vul
https://bugs.freedesktop.org/show_bug.cgi?id=108508
--- Comment #13 from Samuel Pitoiset ---
Can you please record a renderdoc capture of the problem?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
Reviewed-by: Samuel Pitoiset
On 10/29/18 10:39 PM, Marek Olšák wrote:
From: Marek Olšák
v2: fix enabling primitive binning
---
src/amd/addrlib/amdgpu_asic_addr.h | 2 ++
src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +-
src/amd/common/ac_gpu_info.c
https://bugs.freedesktop.org/show_bug.cgi?id=108245
--- Comment #4 from Alex Smith ---
Were you able to look at this at all?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mail
Building of 32bit Mesa may fail if __SSE__ is not specified.
Added missed dependency from libm.
CC: Dylan Baker
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
Signed-off-by: Sergii Romantsov
---
src/util/Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Thanks for a comments. I see the most of that patches have no sense,
probably, except one:
Yeah, I think we should land that if it fixes the build for 32bit x86.
Here is: https://patchwork.freedesktop.org/patch/259176/
On Mon, Oct 29, 2018 at 6:04 PM Dylan Baker wrote:
> Quoting Sergii Romants
https://bugs.freedesktop.org/show_bug.cgi?id=108245
--- Comment #5 from Samuel Pitoiset ---
Not yet sorry, I will let you know.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev m
Fixes: 6ccc435e7ad92bb0ba77d "pipe-loader: move dup(fd) within
pipe_loader_drm_probe_fd"
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
src/gallium/auxiliary/vl/vl_winsys_drm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/auxiliary/vl/vl_winsys_drm.c
b/src/gallium/auxilia
I don't think it's fine, usually, freeing an NULL pointer will cause
unexpected errors. It's better to check this for the robustness.
On 10/30/18 3:17 PM, Tapani Pälli wrote:
> On 10/30/18 8:26 AM, Zhaowei Yuan wrote:
>> Pointer dri2_dpy->driver_name is probably NULL when calling
>> dri2_display_
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 28 +++
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index 149c256218..5f621ec3fb 10
In case we failed to submit the CS correctly.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
i
I don't think we want to wait for something that hasn't been
correctly submitted. This is similar to the fallback path.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/winsys/a
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_radeon_winsys.h| 3 ---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 7 ---
2 files changed, 10 deletions(-)
diff --git a/src/amd/vulkan/radv_radeon_winsys.h
b/src/amd/vulkan/radv_radeon_winsys.h
index 526661754f
v2: - fix format definition line
- disable for desktop GL
- don't add GL_R8_EXT to glext.h since it is already in
GLES2/gl2ext.h in glext.h and include this header where needed
(all Emil)
v3: - swrast: Fill the function table for sRGB_R8
The size of the function table is
Enables on R600 and makes pass:
dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.*
dEQP-GLES31.functional.texture.filtering.cube_array.formats.sr8*
v2: remove chunk for dri/radeon (Emil)
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/r600_state_common.c | 1 +
1 file chan
This only adds support on the Gallium core level, for the drivers
it is likely that additional changes are needed to support the
new texture format and thereby enable the extension.
Enables on softpipe and makes pass:
dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.*
v2: - add includ
Dear all,
This is an update to the series send yesterday. Changes applied as suggested by
Ilia and Roland:
- split the Gallium-mesa/st patch in two according parts (Roland)
- do away most of the SVGA changes and only keep the additional entry
in the format table to make the code compile (I
This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new
format enum, the format entries in Gallium and and svga, the mapping between
sRGB and linear formats, and tests.
v2: - add mapping to linear format for PIPE_FORMATR_R8_SRGB
v3: - Add texture format to svga format table
On Tue, 30 Oct 2018 at 07:13, Zhaowei Yuan wrote:
>
> Pointer dri2_dpy->device_name is probably NULL when calling
> dri2_display_destory, check this before releasing it.
>
According to the man page, free(NULL) is perfectly valid and safe.
-Emil
___
mesa
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 10 +++---
src/amd/vulkan/radv_pipeline.c | 1 +
src/amd/vulkan/si_cmd_buffer.c | 1 +
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 508fbb2
Hi,
> > On finishing a display list playback the VBO_SAFE_FALLBACK bit
> >
>
> s/SAFE/SAVE/g (here and in the title)
>
> Regards,
> Gustaw Smolarczyk
Thanks, changed locally ...
best
Mathias
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
On Tue, Oct 30, 2018 at 6:46 AM Gert Wollny wrote:
>
> This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new
> format enum, the format entries in Gallium and and svga, the mapping between
> sRGB and linear formats, and tests.
>
> v2: - add mapping to linear format for PIPE_F
Reviewed-by: Ilia Mirkin
On Tue, Oct 30, 2018 at 6:46 AM Gert Wollny wrote:
>
> v2: - fix format definition line
> - disable for desktop GL
> - don't add GL_R8_EXT to glext.h since it is already in
> GLES2/gl2ext.h in glext.h and include this header where needed
> (all Emil)
https://bugs.freedesktop.org/show_bug.cgi?id=108560
--- Comment #2 from Sergii Romantsov ---
Seems series is not valid.
Only one patch may be used: https://patchwork.freedesktop.org/patch/259176/
It fixes error:
../../src/util/.libs/libmesautil.a(libmesautil_la-half_float.o): In function
`_mesa_
Aaaactually, just noticed this in 3/4 but it's here as well:
On Tue, Oct 30, 2018 at 7:03 AM Ilia Mirkin wrote:
>
> Reviewed-by: Ilia Mirkin
> On Tue, Oct 30, 2018 at 6:46 AM Gert Wollny wrote:
> >
> > v2: - fix format definition line
> > - disable for desktop GL
> > - don't add GL_R8_
Hi;
On 10/30/18 1:28 AM, Timothy Arceri wrote:
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote:
Hi Timothy,
Thanks for the review. Piglit patch is updated with the additional out
var: https://patchwork.freedesktop.org/patch/258899/
Original reporter confirmed that issue is finally fixed with th
On Tue, 2018-10-30 at 18:28 +0800, Zhaowei YUan wrote:
> I don't think it's fine, usually, freeing an NULL pointer will cause
> unexpected errors. It's better to check this for the robustness.
>
From http://pubs.opengroup.org/onlinepubs/009695399/functions/free.html
:
"If ptr is a null pointer,
Signed-off-by: Samuel Pitoiset
---
src/amd/common/sid.h| 1 +
src/amd/vulkan/radv_query.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h
index d88ecf5580..5c53133147 100644
--- a/src/amd/common/sid.h
+++ b/src/amd/common/s
Fixes: ea83a1d304dc97d1d155a "intel: tools: import ImGui"
Signed-off-by: Eric Engestrom
---
meson_options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson_options.txt b/meson_options.txt
index 606ae9de6a4f760f84e6..97b3c8f0461f5713a98e 100644
--- a/meson_options.txt
+
https://bugs.freedesktop.org/show_bug.cgi?id=108596
Samuel Pitoiset changed:
What|Removed |Added
Summary|The Gallium3D Heads-Up |[RADV] Implement a HUD for
On Fri, 2018-10-26 at 13:14 +0200, Erik Faye-Lund wrote:
> On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote:
> > Please confirm that this passes the piglit tests you sent to the
> > list
> > when run with ES2 forced, i.e. not ES3.
> > (MESA_GLES_VERSION_OVERRIDE=2.0 iirc.) I'm concerned that th
https://bugs.freedesktop.org/show_bug.cgi?id=108596
Samuel Pitoiset changed:
What|Removed |Added
Summary|[RADV] Implement a HUD for |[RADV] Implement a HUD for
On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
wrote:
>
> From: Marek Olšák
>
> The spec was modified to support GLES.
>
> Tested-by: Erik Faye-Lund
> ---
> This replaces this patch:
> https://patchwork.freedesktop.org/patch/257423/
>
> docs/relnotes/18.3.0.html| 1 +
> src/mesa/main/e
Ping?
(Added Timothy the the CC-list, as he's the most recent person to
modify the parser, it seems)
On Wed, 2018-08-29 at 13:59 +0200, Erik Faye-Lund wrote:
> Ping?
>
> On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > There's seems to be nothing in t
On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
> ---
> src/egl/drivers/dri2/egl_dri2.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index c5fa935657e8165b
On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote:
> On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> wrote:
> >
> > From: Marek Olšák
> >
> > The spec was modified to support GLES.
> >
> > Tested-by: Erik Faye-Lund
> > ---
> > This replaces this patch:
> > https://patchwork.freedesktop.or
On Tue, 30 Oct 2018 at 10:22, Eric Engestrom wrote:
>
> Fixes: 6ccc435e7ad92bb0ba77d "pipe-loader: move dup(fd) within
> pipe_loader_drm_probe_fd"
> Cc: Emil Velikov
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev maili
Cc: Lionel Landwerlin
Signed-off-by: Eric Engestrom
---
src/intel/tools/aubinator_viewer_decoder.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/tools/aubinator_viewer_decoder.cpp
b/src/intel/tools/aubinator_viewer_decoder.cpp
index 697009894e6d02a09b5a..5311a8
The series looks great, Mathias.
Reviewed-by: Brian Paul
A comment/question below...
On 10/29/2018 11:07 PM, mathias.froehl...@gmx.net wrote:
> From: Mathias Fröhlich
>
> The array type draw is no longer directly dependent on the vbo module.
> Thus move array type draws into mesa/main/draw.c
For the series, Reviewed-by: Brian Paul
I'll push these for you.
-Brian
On 10/29/2018 03:51 PM, janisoz...@gmail.com wrote:
> From: Michał Janiszewski
>
> Signed-off-by: Michał Janiszewski
> ---
> src/mesa/main/texcompress_bptc_tmp.h | 5 +
> src/mesa/main/texcompress_s3tc_tmp.h
On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund
wrote:
>
> On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote:
> > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> > wrote:
> > >
> > > From: Marek Olšák
> > >
> > > The spec was modified to support GLES.
> > >
> > > Tested-by: Erik Faye-Lund
>
Rb
On 30/10/2018 11:28, Eric Engestrom wrote:
Fixes: ea83a1d304dc97d1d155a "intel: tools: import ImGui"
Signed-off-by: Eric Engestrom
---
meson_options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson_options.txt b/meson_options.txt
index 606ae9de6a4f760f84e6..97
On Tuesday, 2018-10-30 06:07:20 +0100, mathias.froehl...@gmx.net wrote:
> From: Mathias Fröhlich
>
> Instead of coding additional information into the primitive
> mode, make the only remaining flag there a direct argument to
> vbo_save_NotifyBegin.
>
> Signed-off-by: Mathias Fröhlich
> ---
> s
Rb
On 30/10/2018 12:05, Eric Engestrom wrote:
Cc: Lionel Landwerlin
Signed-off-by: Eric Engestrom
---
src/intel/tools/aubinator_viewer_decoder.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/tools/aubinator_viewer_decoder.cpp
b/src/intel/tools/aubinator_vi
On Tue, 2018-10-30 at 08:20 -0400, Ilia Mirkin wrote:
> On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund
> wrote:
> >
> > On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote:
> > > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> > > wrote:
> > > >
> > > > From: Marek Olšák
> > > >
> > > > The
On 29/10/2018 11:56, Toni Lönnberg wrote:
Use the 'DWord Length' and 'bias' fields from the instruction definition to
parse the packet length from the command stream when possible. The hardcoded
mechanism is used whenever an instruction doesn't have this field.
Reviewed-by: Lionel Landwerlin
This patch and the previous one pushed to master.
Thanks!
On 30/10/2018 12:41, Lionel Landwerlin wrote:
On 29/10/2018 11:56, Toni Lönnberg wrote:
Use the 'DWord Length' and 'bias' fields from the instruction
definition to
parse the packet length from the command stream when possible. The
hardc
https://bugs.freedesktop.org/show_bug.cgi?id=108594
soredake changed:
What|Removed |Added
CC||fds...@krutt.org
--
You are receiving this
If the client has requested that AcquireNextImage not block at all, with
a timeout of 0, then don't make any non-blocking calls.
This will still potentially block infinitely given a non-infinte
timeout, but the fix for that is much more involved.
Signed-off-by: Daniel Stone
Cc: mesa-sta...@lists
On Tuesday, 2018-10-30 12:56:53 +, Daniel Stone wrote:
> If the client has requested that AcquireNextImage not block at all, with
> a timeout of 0, then don't make any non-blocking calls.
Indeed; per spec:
> If timeout is zero, then vkAcquireNextImageKHR does not wait, and will
> either succes
Jason, JFYI, I have been looking into the cases where the boolean
bitsize lowering pass was producing worse instruction counts that the
default 32-bit pass and I have tracked it down to this patch. Reverting
this makes the instruction count much better for some tests, I'll check
why this happens to
Not needed to recompute the stride.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_query.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 5a326c9df54..318d6c7afee 100644
--- a/src/amd/vulkan/radv_que
Weird. I didn't expect this patch to have any impact whatsoever. I thought
it was just moving around the way we emit stuff.
On October 30, 2018 08:40:01 Iago Toral wrote:
Jason, JFYI, I have been looking into the cases where the boolean
bitsize lowering pass was producing worse instruction c
On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
I'd add some commit message here. The check/macro was required in the
earlier days, when MSVC did not provide the header.
Since the 2013 version (or was it earlier) it's around... just 14
years after the C99 st
On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Preliminary work for adding handling of different pipes to gen_decoder. Each
instruction needs to have a definition describing which engine it is meant for.
If left undefined, by default, the instruction is defined for all engines.
---
src/intel/common/gen_decoder.c | 9 +
src/intel/common
These patches add an engine parameter to the instructions defined in the genxml
files so that they can be distinguished when sending them to different engines.
By default, an instruction is defined to be used by all engines and is defined
for a specific engine by adding the parameter "engine" to
Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a
bitmask. The enumeration needs to be defined in a single place that can be used
by the decoder and tools.
---
src/intel/common/gen_decoder.h | 6 ++
src/intel/tools/aub_read.c | 1 +
src/intel/tools/aub_read.h
The engine to which the batch was sent to is now passed along when decoding the
batch. This is needed so that we can distinguish between instructions as the
render and video pipe share some of the instruction opcodes.
---
src/intel/common/gen_batch_decoder.c | 21 ++-
src/
On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
> ---
> src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
> b/src/mesa/drivers/dri/i965/inte
On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
> ---
> src/util/u_dynarray.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h
> index c1aa79c8ac6ca8fce810..9bed2b9c25c879672e22 100644
> -
Acked-by: Jason Ekstrand
On Tue, Oct 30, 2018 at 7:56 AM Daniel Stone wrote:
> If the client has requested that AcquireNextImage not block at all, with
> a timeout of 0, then don't make any non-blocking calls.
>
> This will still potentially block infinitely given a non-infinte
> timeout, but t
Hi Eric,
On Thu, 25 Oct 2018 at 17:39, Eric Anholt wrote:
>
> This allows vc4 to initialize on the Adafruit PiTFT 3.5" touchscreen with
> the new tinydrm driver I just submitted. If this series extending the
> pl111/kmsro driver is accepted, then I'll extend kmsro with the other
> tinydrm driver
I think we should switch to use drm_i915_gem_engine_class from
include/drm-uapi/i915_drm.h and just have macro for class id -> mask.
On 30/10/2018 14:32, Toni Lönnberg wrote:
Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a
bitmask. The enumeration needs to be define
Since a batch will be given to a specific engine, the engine won't
change change while decoding.
So I would just store the engine into gen_batch_decode_ctx and set it in
the init function, that'll reduce the diff a bit.
Then just introduce a local find_instruction() function that calls
gen_spe
If you could put the branch somewhere so I could skim through the xml
changes.
Thanks,
-
Lionel
On 30/10/2018 14:32, Toni Lönnberg wrote:
These patches add an engine parameter to the instructions defined in the genxml
files so that they can be distinguished when sending them to different engi
On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote:
>
> ---
> src/intel/vulkan/anv_device.c | 11 +++
> src/intel/vulkan/anv_util.c | 4
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 79d3f
On Tue, Oct 30, 2018 at 10:04 AM Emil Velikov
wrote:
> On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote:
> >
> > ---
> > src/intel/vulkan/anv_device.c | 11 +++
> > src/intel/vulkan/anv_util.c | 4
> > 2 files changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/
On Tue, Oct 30, 2018 at 2:50 AM Iago Toral wrote:
> Some quick comments on this after experimenting with it:
>
> Intel hardware produces booleans of the same bit-size as the operations
> that generates them so I am working on expanding this to add another
> lowering pass that can lower them to sm
On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote:
>
> On Tuesday, 2018-10-23 10:49:26 -0400, mesa-dev-boun...@lists.freedesktop.org
> wrote:
> > In the pursuit of lowering driver overhead, it became clear that some
> > amount of redesign of how libdrm_freedreno constructs the submit ioctl
> > w
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2018-10-30 04:28:56)
> Fixes: ea83a1d304dc97d1d155a "intel: tools: import ImGui"
> Signed-off-by: Eric Engestrom
> ---
> meson_options.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson_options.txt b/meson_options
Reviewed-by: Dylan Baker
Quoting Sergii Romantsov (2018-10-30 02:45:14)
> Building of 32bit Mesa may fail if __SSE__ is not specified.
> Added missed dependency from libm.
>
> CC: Dylan Baker
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> Signed-off-by: Sergii Romantsov
> --
https://bugs.freedesktop.org/show_bug.cgi?id=108601
Bug ID: 108601
Summary: gen_xmlpool.py fails if LANG=C.*
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Dylan Baker changed:
What|Removed |Added
Depends on||108601
Referenced Bugs:
https://bugs.fr
https://bugs.freedesktop.org/show_bug.cgi?id=108601
Dylan Baker changed:
What|Removed |Added
Blocks||108530
Referenced Bugs:
https://bugs.fr
I was thinking the exact same thing earlier but I didn't feel like changing too
much of what was already there, thus keeping the enum. Can change it use the
definition from uapi for v2.
On Tue, Oct 30, 2018 at 02:58:28PM +, Lionel Landwerlin wrote:
> I think we should switch to use drm_i915_
On Tue, 30 Oct 2018 at 15:07, Jason Ekstrand wrote:
>
> On Tue, Oct 30, 2018 at 10:04 AM Emil Velikov
> wrote:
>>
>> On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote:
>> >
>> > ---
>> > src/intel/vulkan/anv_device.c | 11 +++
>> > src/intel/vulkan/anv_util.c | 4
>> > 2 files
https://bugs.freedesktop.org/show_bug.cgi?id=108508
--- Comment #14 from Ahmed Elsayed ---
I tried many times to record both games with DXVK on but it failed to run. But
when I opened both games with DXVK off, the textures were very dark but there
were no graphic glitches.
--
You are receiving
With the format ordering in svga_format.c as Ilia mentioned fixed
Reviewed-by: Roland Scheidegger
Am 30.10.18 um 11:46 schrieb Gert Wollny:
> This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new
> format enum, the format entries in Gallium and and svga, the mapping between
>
Suggested-by: Emil Velikov
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index ee35e013329005671391..d0e83546b1197e362874 100644
--- a/src/in
On Tuesday, 2018-10-30 16:09:49 +, Eric Engestrom wrote:
> Suggested-by: Emil Velikov
> Signed-off-by: Eric Engestrom
> ---
Sent the patch for the discussion, but I'm not sure this is that
important; this code is for when a device is lost, which is not very
common to say the least, and shavi
NAK. There's really no reason to do this. If you're in the lost device
case, you've just done an ioctl (expensive) and got a GPU hang (5 second
watchdog timer). Also, it adds complexity to something that very badly
needs to "just work".
--Jason
On Tue, Oct 30, 2018 at 11:09 AM Eric Engestrom
The engine doesn't change inside a batch but it can change between batches,
right? The options are either to pass the engine around or have it in the
decoder context but it would need to be updated in the there before decoding a
new batch.
On Tue, Oct 30, 2018 at 02:58:32PM +, Lionel Landwe
This isn't true for Vulkan so we have to whack it to "main" in anv which
is silly. Instead of walking the list of functions and asserting that
everything is named "main" and hoping there's only one function named
"main", just use the nir_shader_get_entrypoint() helper which has better
assertions a
Reviewed-by: Lionel Landwerlin
On 29/10/2018 14:44, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_extensions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index ab9240f9fd8..e9afe06bb13 100644
On 30/10/2018 16:26, Jason Ekstrand wrote:
This isn't true for Vulkan so we have to whack it to "main" in anv which
is silly. Instead of walking the list of functions and asserting that
everything is named "main" and hoping there's only one function named
"main", just use the nir_shader_get_entr
EXT_shader_implicit_conversions is a useful extension that adds implicit
conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and
Mesa already has support for implicit conversions, it seems reasonable to
allow for the extension. This ended up mostly as code-cleanups anyway.
While e
Yeah, true.
Maybe put a default value on init (likely render) and let the caller of
gen_print_batch() set the field on the line above.
I could just like to leave the decode somewhat agnostic about what type
of engine it's dealing with.
-
Lionel
On 30/10/2018 16:21, Toni Lönnberg wrote:
The e
1 - 100 of 159 matches
Mail list logo
