Re: [Mesa-dev] [PATCH mesa 2/6] nouveau: silence paranoid compiler's -Wclass-memaccess

2018-09-22 Thread Karol Herbst
yeah, I agree here. Either the code was wrong in the first place, which means it would have to be fixed properly or the warning is wrong. The proper fix here is that GCC should detect itself if it's safe to do or not, otherwise that warning becomes a "might be a problem" thing which doesn't help at

[Mesa-dev] [Bug 107170] Build fails if building against X server/libxrandr with no leases support

2018-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107170 --- Comment #3 from network...@rkmail.ru --- Is this bug is still being worked on? It seems that patch never reached GIT master... -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] st/mesa: do not call update_framebuffer_size with NULL pointer

2018-09-22 Thread Guillaume Charifi
Reviewed-by: Guillaume Charifi Le 20/09/2018 à 10:27, Erik Faye-Lund a écrit : In st_renderbuffer_alloc_storage, we avoid allocating storage for zero-sized buffers, leading to this pointer being NULL. We already take care to avoid dereferencing these pointers for color-buffers, but not for dept

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 Rafał Cieślak changed: What|Removed |Added CC||rafalcieslak...@ubuntu.com -- You are

Re: [Mesa-dev] [PATCH mesa 2/6] nouveau: silence paranoid compiler's -Wclass-memaccess

2018-09-22 Thread Jan Vesely
The warning is correct. In the first case, memset tries to zero "Target" object which has a non-trivial constructor and non-trivial copy-constructor. The original code is broken in the way it mixes C and C++ initialization and the patch only papers over the issue. The correct fix would be to provid

Re: [Mesa-dev] [PATCH] Update counter reading shaders to new NVC0_CB_AUX_MP_INFO

2018-09-22 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Sep 20, 2018 at 1:10 PM, Rhys Perry wrote: > Fixes: 66ca7e400b8 ('nvc0: add support for programmable sample locations') > Signed-off-by: Rhys Perry > --- > .../drivers/nouveau/nvc0/nvc0_query_hw_sm.c | 36 +-- > 1 file changed, 18 insertions(+

Re: [Mesa-dev] [PATCH] nvc0: warn about changing NVC0_CB_AUX_MP_INFO and NVC0_CB_AUX_DRAW_INFO

2018-09-22 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Sep 20, 2018 at 1:44 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_context.h > b/

Re: [Mesa-dev] [PATCH v3] nvc0: fix bindless multisampled images on Maxwell+

2018-09-22 Thread Ilia Mirkin
On Mon, Sep 17, 2018 at 12:19 PM, Rhys Perry wrote: > NVC0_CB_AUX_BINDLESS_INFO isn't written to on Maxwell+ and it's too small > anyway. > > With these changes, TXQ is used to determine the number of samples and > the coordinate adjustment information looked up in a small array in the > driver co

Re: [Mesa-dev] [PATCH mesa 2/6] nouveau: silence paranoid compiler's -Wclass-memaccess

2018-09-22 Thread Eric Engestrom
On Saturday, 2018-09-22 10:27:50 -0400, Jan Vesely wrote: > The warning is correct. In the first case, memset tries to zero "Target" > object which has a non-trivial constructor and non-trivial > copy-constructor. The original code is broken in the way it mixes C and C++ > initialization and the pa

Re: [Mesa-dev] [PATCH mesa 1/2] docs: update repo URLs after GitLab move

2018-09-22 Thread Eric Engestrom
On Friday, 2018-09-21 16:29:48 +0100, Emil Velikov wrote: > On 21 September 2018 at 14:46, Eric Engestrom > wrote: > > I also updated the developer instructions; presumably someone who's been > > given commit rights already knows how to clone a repository :) > > > > A more useful thing is to show

[Mesa-dev] [PATCH 1/5] nir/cf: Remove phi sources if needed in nir_handle_add_jump

2018-09-22 Thread Jason Ekstrand
If the block in which the jump is inserted is the predecessor of a phi then we need to remove phi sources otherwise the phi may end up with things improperly connected. Found by running the Vulkan CTS with SPIR-V optimizations enabled. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/n

[Mesa-dev] [PATCH 0/5] nir,spirv: Fix bugs uncovered by spirv-opt

2018-09-22 Thread Jason Ekstrand
This little series fixes three bugs encountered while running the Vulkan CTS with SPIR-V optimizations enabled. The optimizations shouldn't, in theory, change the behavior of the shader but it does change some of the SPIR-V patterns and triggered a number of compiler bugs. I'd like to CC the whol

[Mesa-dev] [PATCH 3/5] spirv: Move function call handling to vtn_cfg

2018-09-22 Thread Jason Ekstrand
It makes way more sense for it to live there with the rest of function handling. --- src/compiler/spirv/spirv_to_nir.c | 63 --- src/compiler/spirv/vtn_cfg.c | 63 +++ src/compiler/spirv/vtn_private.h | 2 + 3 files changed, 65 inserti

[Mesa-dev] [PATCH 2/5] nir/from_ssa: Don't rewrite derefs destinations to registers

2018-09-22 Thread Jason Ekstrand
We already call nir_rematerialize_derefs_in_use_blocks_impl prior to calling nir_lower_ssa_defs_to_regs_block so the assertion that all deref uses in the block should hold. This fixes validation errors in some Vulkan CTS tests with SPIR-V optimizations enabled. Fixes: 606eb56ab9449b "intel/nir: O

[Mesa-dev] [PATCH 4/5] spirv: Pass SSA values through functions

2018-09-22 Thread Jason Ekstrand
Previously, we would create temporary variables and fill them out. Instead, we create as many function parameters as we need and pass them through as SSA defs. --- src/compiler/spirv/vtn_cfg.c | 180 +++ 1 file changed, 139 insertions(+), 41 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] spirv: Make images, samplers, and sampled images normal SSA values

2018-09-22 Thread Jason Ekstrand
Instead of treating image, sampler, and combined image sampler SSA values as pointers and special-casing them various places, we now allow them to be part of regular SSA values. Among other things, this means that composites of opaque types should now work correctly. --- src/compiler/spirv/spirv_

[Mesa-dev] [PATCH] docs: Update FAQ with current OpenGL API version supported

2018-09-22 Thread Stuart Young
Used a variation on the standard boilerplate version info that is used in the release notes. --- docs/faq.html | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/faq.html b/docs/faq.html index 6270a071da..080c6b6da7 100644 --- a/docs/faq.html +++ b/docs/faq.html

[Mesa-dev] [Bug 108024] [Debian Stretch]Fail to build because "xcb_randr_lease_t"

2018-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108024 Bug ID: 108024 Summary: [Debian Stretch]Fail to build because "xcb_randr_lease_t" Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [Bug 108024] [Debian Stretch]Fail to build because "xcb_randr_lease_t"

2018-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108024 --- Comment #1 from Stuart Young --- Probably needs libxcb-1.13 (released March 2018). From the xcb release notes https://lists.freedesktop.org/archives/xcb/2018-March/011090.html : This release of xcb-proto brings support for buffer modifiers

[Mesa-dev] [Bug 108024] [Debian Stretch]Fail to build because "xcb_randr_lease_t"

2018-09-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108024 --- Comment #2 from Stuart Young --- Suspect this is the related commit where the randr leases code was added: https://cgit.freedesktop.org/mesa/mesa/commit/?id=7ab1fffcd2a504024b16e408de329f7a94553ecc A quick look at similar commits for radv a