Re: [Mesa-dev] [PATCH 1/2] meson: Be a bit more helpful when arch or OS is unknown

2018-08-25 Thread Stuart Young
On Fri, 24 Aug 2018 at 22:23, Guido Günther wrote: > > @@ -230,7 +236,8 @@ if _platforms.contains('auto') >elif ['haiku'].contains(host_machine.system()) > _platforms = ['haiku'] >else > -error('Unknown OS. Please pass -Dplatforms to set platforms. Patches > gladly accepted to fi

[Mesa-dev] [PATCH] st/mesa: Disable blending for integer formats.

2018-08-25 Thread Kenneth Graunke
Blending isn't valid for integer formats. Rather than having drivers worry about this, just disable blending in this case. This hopefully will increase hits in the CSO cache as well, by eliminating most of the meaningless fields in this case. --- src/mesa/state_tracker/st_atom_blend.c | 1 + 1 f

[Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

2018-08-25 Thread Kenneth Graunke
When faking an RGB format with an RGBA format, there may be a channel of data containing garbage. st/mesa already overrides texture swizzles to replace the A channel with ONE. This patch makes it override blend factors to achieve a similar effect. It appears that st_update_blend is already calle

[Mesa-dev] [PATCH] intel: tools: Fix aubinator_error's fprintf call (format-security)

2018-08-25 Thread Kai Wasserbäch
The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced the new function aubinator_error() which is a trivial wrapper around fprintf() to STDERR. The call to fprintf() however is passed the message msg directly: fprintf(stderr, msg); This is a format-security violation and leads to

Re: [Mesa-dev] [PATCH 2/3] nir: Create sampler variables in prog_to_nir.

2018-08-25 Thread Jason Ekstrand
On Fri, Aug 24, 2018 at 8:24 PM Kenneth Graunke wrote: > This is needed for nir_gather_info to actually count the textures, > since it operates solely on variables. > --- > src/mesa/program/prog_to_nir.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH 2/9] nir: Export deref comparison functions

2018-08-25 Thread Jason Ekstrand
On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Reviewed-by: Timothy Arceri > --- > src/compiler/nir/nir_deref.c | 109 > src/compiler/nir/nir_deref.h | 10 ++ > src/compiler/nir/nir_opt_copy_prop_vars

Re: [Mesa-dev] [PATCH 6/9] nir: Make dead_write_vars pass global

2018-08-25 Thread Jason Ekstrand
Sorry I haven't given you any in-line review yet. I've been letting this pass simmer in my brain a bit and thinking about complexity and data structures. Here's a few questions for which I do not expect you to have actual answers: 1) How many unique derefs should we expect to see in a shader?

Re: [Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

2018-08-25 Thread Ilia Mirkin
You have to make sure to flip blend->independent_blend_enable to 1 in that case, and that will only work on some (well, most, but not all) hardware. Pre-something Tesla-era and I assume r600-era gpu's must have all rt's configured the same way. I'm also not 100% sure that it's OK to access the dra

Re: [Mesa-dev] [PATCH 6/9] nir: Make dead_write_vars pass global

2018-08-25 Thread Jason Ekstrand
On Sat, Aug 25, 2018 at 9:40 AM Jason Ekstrand wrote: > Sorry I haven't given you any in-line review yet. I've been letting this > pass simmer in my brain a bit and thinking about complexity and data > structures. Here's a few questions for which I do not expect you to have > actual answers: >

Re: [Mesa-dev] [PATCH] intel: tools: Fix aubinator_error's fprintf call (format-security)

2018-08-25 Thread Lionel Landwerlin
On 25/08/2018 11:00, Kai Wasserbäch wrote: The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced the new function aubinator_error() which is a trivial wrapper around fprintf() to STDERR. The call to fprintf() however is passed the message msg directly: fprintf(stderr, msg); Th

Re: [Mesa-dev] [PATCH] intel: tools: Fix aubinator_error's fprintf call (format-security)

2018-08-25 Thread Kai Wasserbäch
Hey Lionel, Lionel Landwerlin wrote on 8/25/18 5:50 PM: > On 25/08/2018 11:00, Kai Wasserbäch wrote: >> The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced >> the new function aubinator_error() which is a trivial wrapper around >> fprintf() to STDERR. The call to fprintf() however

[Mesa-dev] [PATCH] intel: decoder: handle 0 sized structs

2018-08-25 Thread Lionel Landwerlin
Gen7.5 has a BLEND_STATE of size 0 which includes a variable length group. We did not deal with that very well, leading to an endless loop. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107544 --- src/intel/common/gen_decoder.c | 12 1 file

[Mesa-dev] [PATCH] anv: Fill holes in the VF VUE to zero

2018-08-25 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104809 --- src/intel/vulkan/genX_pipeline.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeli

Re: [Mesa-dev] [PATCH 2/3] nir: Create sampler variables in prog_to_nir.

2018-08-25 Thread Kenneth Graunke
On Saturday, August 25, 2018 6:05:57 AM PDT Jason Ekstrand wrote: > On Fri, Aug 24, 2018 at 8:24 PM Kenneth Graunke > wrote: > > > This is needed for nir_gather_info to actually count the textures, > > since it operates solely on variables. > > --- > > src/mesa/program/prog_to_nir.c | 15 +++

[Mesa-dev] [PATCH] intel/tools: Add 0x in front of a couple of hex values

2018-08-25 Thread Jason Ekstrand
--- src/intel/common/gen_batch_decoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index 6884a999401..1a5c8c37968 100644 --- a/src/intel/common/gen_batch_decoder.c +++ b/src/intel/common/gen_

Re: [Mesa-dev] [PATCH] anv: Fill holes in the VF VUE to zero

2018-08-25 Thread Jason Ekstrand
Added to the commit message: This fixes a GPU hang in DOOM 2016 running under wine. On Sat, Aug 25, 2018 at 5:17 PM Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104809 > --- > src/intel/vulkan/genX_pipeline.c | 29 ++

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #16 from mirh --- (In reply to mirh from comment #5) > (In reply to mirh from comment #1) > > Can confirm it fixes shader 2 and 5 of GraphicsFuzz demo > > http://www.graphicsfuzz.com/benchmark/android-v1.html > > > > Should I wait

Re: [Mesa-dev] [PATCH] intel/tools: Add 0x in front of a couple of hex values

2018-08-25 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 25/08/2018 23:34, Jason Ekstrand wrote: --- src/intel/common/gen_batch_decoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index 6884a999401..1a5c8c379

Re: [Mesa-dev] [PATCH] anv: Fill holes in the VF VUE to zero

2018-08-25 Thread Lionel Landwerlin
I don't know how you find this stuff... Reviewed-by: Lionel Landwerlin On 25/08/2018 23:17, Jason Ekstrand wrote: Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104809 --- src/intel/vulkan/genX_pipeline.c | 29 - 1 fi

Re: [Mesa-dev] [PATCH] anv: Fill holes in the VF VUE to zero

2018-08-25 Thread Jason Ekstrand
On Sat, Aug 25, 2018 at 5:56 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I don't know how you find this stuff... > Hours and hours of painfully reading through aub dumps looking for stuff that's out of place and many experiments. This hang has probably taken me near enough to

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 104809, which changed state. Bug 104809 Summary: anv: DOOM 2016 and Wolfenstein II:The New Colossus crash due to not having depthBoundsTest https://bugs.freedesktop.org/show_bug.cgi?id=104809 What|Removed

Re: [Mesa-dev] [PATCH] intel: decoder: handle 0 sized structs

2018-08-25 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sat, Aug 25, 2018 at 12:23 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Gen7.5 has a BLEND_STATE of size 0 which includes a variable length > group. We did not deal with that very well, leading to an endless > loop. > > Signed-off-by: Lionel Landw