On Ubuntu 16.04 xcb-randr version is 1.11.1.
Thats enough to build Intel dri-driver.
But Intel Vulkan with enabled xlib-lease requires xcb-randr version 1.13.
Added such checking on configuration stage.
-v2: corrected bugzilla link
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106976
Fix
https://bugs.freedesktop.org/show_bug.cgi?id=107601
fin4...@hotmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 33 +++--
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index cc88abb57a..e11005a1f8 100644
--- a/src/amd/vulkan/radv_device.c
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 127 +
src/intel/vulkan/anv_device.c | 50 +++-
src/intel/vulkan/anv_private.h | 18 ++
3 files changed,
Hi;
Here's VK_ANDROID_external_memory_android_hardware_buffer patches with
some fixes to get more dEQP tests passing (20 pass, 5 fail, 4 not
supported). I'd be happy to get any comments on what might be still
missing. I'm planning to continue with this but wanted to send this out
in case someone w
Since we don't know the exact format at creation time, some initialization
is done only when bound with memory in vkBindImageMemory.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 40 ++
src/intel/vulkan/anv_image.c | 115 +
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/vk_format_info.h | 43 +++
1 file changed, 43 insertions(+)
diff --git a/src/intel/vulkan/vk_format_info.h
b/src/intel/vulkan/vk_format_info.h
index a1cc6952c8f..0ae0a2d43ee 100644
--- a/src/intel/vulkan/vk_for
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 22 +++---
src/intel/vulkan/anv_private.h | 5 +
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/intel/vulkan/anv_f
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index dc398306a70..f1506b8acbe 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/s
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index cafb6060c6b..f5d126edf6b 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan/anv
TODO - need to figure out implementation-defined external format identifier
- YUV support
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 91 ++
1 file changed, 91 insertions(+)
diff --git a/src/intel/vulkan/anv_android.c b/src/intel
On 14 August 2018 at 11:16, Christian Gmeiner
wrote:
> Am Fr., 10. Aug. 2018 um 19:52 Uhr schrieb Emil Velikov
> :
>>
>> On 10 August 2018 at 13:25, Martin Fuzzey
>> wrote:
>> > Hi Christian,
>> >
>> > On 01/08/18 23:07, Christian Gmeiner wrote:
>> >>
>> >> Add an improved drmOpenWithType(..) cl
All of our Vulkan games rely on the presence of "RADV" somewhere in the
device name string to distinguish between RADV and AMDVLK/GPU-PRO, and
that's used to check whether the driver version is supported, whether to
enable bug workarounds, etc. This will certainly break that.
Thanks,
Alex
On 17 A
Yeah, ignore this patch.
On 8/17/18 11:25 AM, Alex Smith wrote:
All of our Vulkan games rely on the presence of "RADV" somewhere in the
device name string to distinguish between RADV and AMDVLK/GPU-PRO, and
that's used to check whether the driver version is supported, whether to
enable bug wor
FWIW, putting "RADV" inside the brackets (e.g. " (RADV, LLVM ...)") would
still work for us.
On 17 August 2018 at 10:38, Samuel Pitoiset
wrote:
> Yeah, ignore this patch.
>
> On 8/17/18 11:25 AM, Alex Smith wrote:
>
>> All of our Vulkan games rely on the presence of "RADV" somewhere in the
>> de
https://bugs.freedesktop.org/show_bug.cgi?id=107601
--- Comment #2 from Timothy Arceri ---
(In reply to fin4478 from comment #1)
> Deleting all folders and files in the ~/.cache/mesa_shader_cache/ folder
> fixes this bug.
This should never be required. There is likely a subtle bug somewhere, th
On 16 August 2018 at 21:28, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-08-16 09:52:05)
>> On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote:
>> > From: Emil Velikov
>> >
>> > Currently we use AC_CHECK_PROGS looking for python2.7, python2 and
>> > finally python. That is due to the
On 16 August 2018 at 21:47, Dylan Baker wrote:
> Quoting Emil Velikov (2018-08-16 09:19:06)
>> On 16 August 2018 at 14:27, Emil Velikov wrote:
>> > On 15 August 2018 at 17:18, Dylan Baker wrote:
>> >> We don't want to support older versions of python 2 anymore, and we
>> >> don't support python
https://bugs.freedesktop.org/show_bug.cgi?id=105371
--- Comment #13 from amonpaike ---
today the repository padoka ppa has updated the drivers so I could test blender
2.8 ... all the problems are now solved! (Except the shadow ESMs that probably
depend on blender, I will present to the blender de
https://bugs.freedesktop.org/show_bug.cgi?id=105371
--- Comment #14 from Gert Wollny ---
If by ESM error you refer to the overgright light blue artifact in the SPACE
RACESHIP scene, then is is a driver problem. If you run
R600_DEBUG=nosb blender
it should go away. Unfortunately, things mi
On 16 August 2018 at 19:56, Mathieu Bridon wrote:
> * src/compiler/glsl/tests/optimization_test.py
> * src/compiler/glsl/glcpp/tests/glcpp_test.py
>
> Both are run directly (they are executables), and their shebang is
> Python 2. :-/
>
> They just aren't hooked up using prog_python like all the b
On 16 August 2018 at 23:00, Mathieu Bridon wrote:
> On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
>> ---
>>
>> I didn't see any patches from anyone else, so I wrote some real
>> quick. Please
>> point to them if other patches already exist.
>
> I was about to send mine, but you were faster
From: Emil Velikov
Just like the rest of the tree - these should be run either as part of
the build system check target, or at the very least with an explicitly
versioned python executable.
Cc: Dylan Baker
Fixes: db8cd8e3677 ("glcpp/tests: Convert shell scripts to a python script")
Fixes: 97c28
From: Dylan Baker
There are multiple reasons why the python scripts are executed
explicitly via $PYTHON or equivalent. In random order:
- env is rarely a thing on Windows
- env can be outside of /usr/bin/
- the python executable varies across platforms - pythonX.Y, python
- we want to use th
This change caused one of our MSVC build machines to fail with
scons: Building targets ...
Generating build\windows-x86-debug\util\xmlpool\options.h ...
Traceback (most recent call last):
File "src\util\xmlpool\gen_xmlpool.py", line 221, in
print(line, end='')
UnicodeEncodeError: 'ascii'
When the number of unique BO is 0, we optimize the list creation
by copying all buffers of the current CS directly into it. But
this is only valid if the CS doesn't have virtual buffers,
otherwise they are not added and hw might report VM faults.
This fixes VM faults with:
dEQP-VK.sparse_resources
Thanks!
Reviewed-by: Bas Nieuwenhuizen
On Fri, Aug 17, 2018 at 2:45 PM, Samuel Pitoiset
wrote:
> When the number of unique BO is 0, we optimize the list creation
> by copying all buffers of the current CS directly into it. But
> this is only valid if the CS doesn't have virtual buffers,
> other
From: Emil Velikov
Add the files otherwise things just won't build.
Haven't actually tested it, but it's a small step in the right
direction.
Fixes: de3b34df973 ("freedreno: Add a6xx backend")
Cc: Kristian H. Kristensen
Cc: Rob Clark
Signed-off-by: Emil Velikov
---
In hind-sight, we might as
On Thursday, 2018-08-16 09:39:28 -0700, Caio Marcelo de Oliveira Filho wrote:
> On Thu, Aug 16, 2018 at 04:00:16PM +0100, Eric Engestrom wrote:
> > These are all already assigned when declared, a few lines above.
> >
> > Signed-off-by: Eric Engestrom
> > ---
> > Note: I'm not 100% certain the val
Hi Andrey,
Thanks for the report and all the analysis work on your side. I am on
holidays at the momentand from tomorrow onwards I won't have reliable
internet access but Samuel will be back fromhis vacaction next week and
he might be be able to have a look at the problem and your patch.
Thanks,Iag
On Fri, 2018-08-17 at 13:29 +0100, Jose Fonseca wrote:
> This change caused one of our MSVC build machines to fail with
>
> scons: Building targets ...
>Generating build\windows-x86-debug\util\xmlpool\options.h ...
> Traceback (most recent call last):
>File "src\util\xmlpool\gen_xmlpool.py
On 17/08/18 14:03, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 13:29 +0100, Jose Fonseca wrote:
This change caused one of our MSVC build machines to fail with
scons: Building targets ...
Generating build\windows-x86-debug\util\xmlpool\options.h ...
Traceback (most recent call last):
Fil
---
Jose, can you test whether this patch fixes your build issues?
I don't have access to a Windows machine, and I can't reproduce your
problem on Linux.
src/util/xmlpool/gen_xmlpool.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/ge
On 16 August 2018 at 21:37, Ray Strode wrote:
> From: Ray Strode
>
> At the moment, depending on pipe transfer flags, the dumb
> buffer map address can end up at either kms_sw_dt->ro_mapped
> or kms_sw_dt->mapped.
>
> When it's time to unmap the dumb buffer, both locations get unmapped,
> even th
On 17/08/18 14:22, Mathieu Bridon wrote:
---
Jose, can you test whether this patch fixes your build issues?
I don't have access to a Windows machine, and I can't reproduce your
problem on Linux.
src/util/xmlpool/gen_xmlpool.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/util
On 17/08/18 14:30, Jose Fonseca wrote:
On 17/08/18 14:22, Mathieu Bridon wrote:
---
Jose, can you test whether this patch fixes your build issues?
I don't have access to a Windows machine, and I can't reproduce your
problem on Linux.
src/util/xmlpool/gen_xmlpool.py | 5 +
1 file changed
On 17/08/18 14:52, Jose Fonseca wrote:
On 17/08/18 14:30, Jose Fonseca wrote:
On 17/08/18 14:22, Mathieu Bridon wrote:
---
Jose, can you test whether this patch fixes your build issues?
I don't have access to a Windows machine, and I can't reproduce your
problem on Linux.
src/util/xmlpool/g
On 17/08/18 15:06, Jose Fonseca wrote:
On 17/08/18 14:52, Jose Fonseca wrote:
On 17/08/18 14:30, Jose Fonseca wrote:
On 17/08/18 14:22, Mathieu Bridon wrote:
---
Jose, can you test whether this patch fixes your build issues?
I don't have access to a Windows machine, and I can't reproduce your
These 3 patches are:
Reviewed-by: Leo Liu
On 2018-08-16 04:56 PM, boyuan.zh...@amd.com wrote:
From: Boyuan Zhang
Move the previous get_mjpeg_slice_heaeder function and eoi from
"radeon/vcn" to "st/va".
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_uvd.c | 147 ---
On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
> On 17/08/18 15:06, Jose Fonseca wrote:
> > On 17/08/18 14:52, Jose Fonseca wrote:
> > > On 17/08/18 14:30, Jose Fonseca wrote:
> > > > On 17/08/18 14:22, Mathieu Bridon wrote:
> > > > > ---
> > > > > Jose, can you test whether this patch fixe
On 17/08/18 15:26, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
On 17/08/18 15:06, Jose Fonseca wrote:
On 17/08/18 14:52, Jose Fonseca wrote:
On 17/08/18 14:30, Jose Fonseca wrote:
On 17/08/18 14:22, Mathieu Bridon wrote:
---
Jose, can you test whether this pa
Hey,
while building Mesa I saw several warnings scroll by and this series
addresses the first four I saw in my build log.
The changes have been compile-tested in a clean chroot (pbuilder)
environment.
If you accept the patches, please apply them for me, as I don't have
commit access for Mesa. The
Supresses a maybe-uninitialized warning with GCC 8.
Note: image_index should always be initialised due to the result check,
but the compiler doesn't see that.
Signed-off-by: Kai Wasserbäch
---
src/vulkan/wsi/wsi_common_x11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Only used, when asserts are enabled.
Fixes an unused-variable warning with gcc-8:
../../../src/util/half_float.c: In function '_mesa_half_to_unorm8':
../../../src/util/half_float.c:189:14: warning: unused variable 's'
[-Wunused-variable]
const int s = (val >> 15) & 0x1;
^
S
Only used, when asserts are enabled.
Fixes an unused-but-set-variable warning with GCC 8:
../../../src/amd/addrlib/addrinterface.cpp: In function 'int
ElemGetExportNorm(ADDR_HANDLE, const ELEM_GETEXPORTNORM_INPUT*)':
../../../src/amd/addrlib/addrinterface.cpp:835:23: warning: variable
'returnC
Only used, when asserts are enabled.
Fixes an unused-variable warning with gcc-8:
../../../src/compiler/nir/nir_opt_if.c: In function 'opt_peel_loop_initial_if':
../../../src/compiler/nir/nir_opt_if.c:109:15: warning: unused variable
'prev_block' [-Wunused-variable]
nir_block *prev_block =
Reviewed-by: Bas Nieuwenhuizen
for this patch.
On Fri, Aug 17, 2018 at 4:32 PM, Kai Wasserbäch
wrote:
> Supresses a maybe-uninitialized warning with GCC 8.
>
> Note: image_index should always be initialised due to the result check,
> but the compiler doesn't see that.
> Signed-off-by: Kai
On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote:
> On 17/08/18 15:26, Mathieu Bridon wrote:
> > On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
> > > On 17/08/18 15:06, Jose Fonseca wrote:
> > > > On 17/08/18 14:52, Jose Fonseca wrote:
> > > > > On 17/08/18 14:30, Jose Fonseca wrote:
>
On 17/08/18 15:49, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote:
On 17/08/18 15:26, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
On 17/08/18 15:06, Jose Fonseca wrote:
On 17/08/18 14:52, Jose Fonseca wrote:
On 17/08/18 14:30, Jos
Reviewed-by: Jose Fonseca
---
src/util/xmlpool/gen_xmlpool.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py
index 327709c7f8d..12177dc50f5 100644
--- a/src/util/xmlpool/gen_xmlpool.py
+++ b/src/util/xmlpool/gen_xmlpool.p
This is follow up to my recent patches which made the Python build
scripts compatible with both Python 2 and 3, then moved the Meson build
system to using Python 3 for them.
Unfortunately, one thing I hadn't tested was running them on Windows,
where the changes broke the build.
See the exchange w
In commit bd27203f4d808763ac24ac94eb677cacf3e7cb99 we changed this to
open in binary mode, to then explicitly decode the lines with the right
encoding.
Unfortunately, that broke the build on Windows, where the template file
can have '\r\n' as line terminators: opening in binary mode would keep
tho
On 08/08/18 09:12, Jason Ekstrand wrote:
Because lower_ycbcr gets called before apply_pipeline_layout, the
indices are all logical and the binding layout HW size is actually too
big for the bounds check. We should just use the regular logical array
size instead.
Fixes: f3e91e78a33 "anv: add nir
On 08/08/18 09:12, Jason Ekstrand wrote:
This commit makes three changes. One is to only walk the descriptors once
and set bind map sizes at the same time as filling out the entries. The
second is to make the pass additive so that we can put stuff in the bind
map before applying the pipeline la
Reviewed-by: Lionel Landwerlin
On 08/08/18 09:12, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_pipeline.c | 37 +++--
1 file changed, 21 insertions(+), 16 deletions(-)
diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
index 23af0f1c
On 08/17/2018 09:16 AM, Mathieu Bridon wrote:
This is follow up to my recent patches which made the Python build
scripts compatible with both Python 2 and 3, then moved the Meson build
system to using Python 3 for them.
Unfortunately, one thing I hadn't tested was running them on Windows,
where
On Fri, 2018-08-17 at 09:23 -0600, Brian Paul wrote:
> On 08/17/2018 09:16 AM, Mathieu Bridon wrote:
> > This is follow up to my recent patches which made the Python build
> > scripts compatible with both Python 2 and 3, then moved the Meson
> > build
> > system to using Python 3 for them.
> >
> >
On 17/08/18 16:08, Jose Fonseca wrote:
On 17/08/18 15:49, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote:
On 17/08/18 15:26, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
On 17/08/18 15:06, Jose Fonseca wrote:
On 17/08/18 14:52, Jos
On 08/17/2018 09:32 AM, Jose Fonseca wrote:
On 17/08/18 16:08, Jose Fonseca wrote:
On 17/08/18 15:49, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote:
On 17/08/18 15:26, Mathieu Bridon wrote:
On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote:
On 17/08/18 15:06
Build mesa 8634 failed
Commit 0a8cf88172 by Jose Fonseca on 8/17/2018 3:39 PM:
Debug git CRLF
Configure your notification preferences
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.f
Build mesa 8635 completed
Commit d9ea015ced by Jason Ekstrand on 8/7/2018 10:47 PM:
anv/pipeline: Lower pipeline layouts etc. after linking\n\nThis allows us to use the link-optimized shader for determining binding\ntable layouts and, more importantly, URB layo
On 15 August 2018 at 13:29, Emil Velikov wrote:
> On 6 August 2018 at 04:19, Qiang Yu wrote:
>> This patch series is discussed in thread:
>> https://lists.freedesktop.org/archives/mesa-dev/2018-July/201348.html
>>
>> amdgpu-pro driver can use drirc config to override the mesa radeonsi
>> dri driv
https://bugs.freedesktop.org/show_bug.cgi?id=107098
Emil Velikov changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Quoting Emil Velikov (2018-08-17 03:12:56)
> On 16 August 2018 at 21:28, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-08-16 09:52:05)
> >> On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote:
> >> > From: Emil Velikov
> >> >
> >> > Currently we use AC_CHECK_PROGS looking for python2
Quoting Mathieu Bridon (2018-08-16 15:00:39)
> On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
> > ---
> >
> > I didn't see any patches from anyone else, so I wrote some real
> > quick. Please
> > point to them if other patches already exist.
>
> I was about to send mine, but you were faste
Quoting Mathieu Bridon (2018-08-16 15:00:39)
> On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
> > ---
> >
> > I didn't see any patches from anyone else, so I wrote some real
> > quick. Please
> > point to them if other patches already exist.
>
> I was about to send mine, but you were faste
v2: - explicitly decode the output of subprocesses
- handle bytes and string types consistently rather than relying on
python 2's coercion for bytes and ignoring them in python 3
---
src/compiler/glsl/tests/lower_jump_cases.py | 2 +-
src/compiler/glsl/tests/optimization_test.py | 6 +
---
src/compiler/glsl/tests/meson.build | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/compiler/glsl/tests/meson.build
b/src/compiler/glsl/tests/meson.build
index fc7b863a278..2a41e30a28d 100644
--- a/src/compiler/glsl/tests/meson.build
+++ b/src/compiler/glsl
I don't care one way or the other on this, but it needs to wait for the series I
have to make two of the test cases py 3 ready, and for a patch from Mathieu to
make another py 3 ready.
Just for reference, it is convention (though I don't care to keep it) to use
such a shebang to mark whether a scr
This extension can be supported on SKL+. With this patch,
all corresponding tests (6K+) in CTS can pass. No test fails.
I verified CTS with the command below:
deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce*
v2: 1) support all depth formats, not depth-only formats, 2) fix
a wrong i
On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote:
> diff --git a/src/compiler/glsl/tests/optimization_test.py
> b/src/compiler/glsl/tests/optimization_test.py
> index 577d2dfc20f..65bac676963 100755
> --- a/src/compiler/glsl/tests/optimization_test.py
> +++ b/src/compiler/glsl/tests/optimizatio
Quoting Emil Velikov (2018-08-17 04:11:32)
> From: Dylan Baker
>
> There are multiple reasons why the python scripts are executed
> explicitly via $PYTHON or equivalent. In random order:
>
> - env is rarely a thing on Windows
windows does something completely different based on file extensions
On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote:
> Quoting Mathieu Bridon (2018-08-16 15:00:39)
> > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
> > > ---
> > >
> > > I didn't see any patches from anyone else, so I wrote some real
> > > quick. Please
> > > point to them if other patc
Quoting Mathieu Bridon (2018-08-17 10:58:38)
> On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote:
> > diff --git a/src/compiler/glsl/tests/optimization_test.py
> > b/src/compiler/glsl/tests/optimization_test.py
> > index 577d2dfc20f..65bac676963 100755
> > --- a/src/compiler/glsl/tests/optimizat
On Tue 14 Aug 2018, Tapani Pälli wrote:
> Hi Chad;
>
> On 08/08/2018 06:53 PM, Tapani Pälli wrote:
> >
> >
> > On 07.08.2018 21:16, Chad Versace wrote:
> > > On Mon 06 Aug 2018, Chad Versace wrote:
> > > > On Fri 03 Aug 2018, Tapani Pälli wrote:
> > > > > One tiny nit below but for patches 3,4 a
v2: - explicitly decode the output of subprocesses
- handle bytes and string types consistently rather than relying on
python 2's coercion for bytes and ignoring them in python 3
v3: - explicitly set encode as well as decode
- python 2.7 and 3.x `bytes` instead of defining an alias
--
---
src/compiler/glsl/tests/meson.build | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/compiler/glsl/tests/meson.build
b/src/compiler/glsl/tests/meson.build
index fc7b863a278..2a41e30a28d 100644
--- a/src/compiler/glsl/tests/meson.build
+++ b/src/compiler/glsl
Quoting Mathieu Bridon (2018-08-17 11:01:23)
> On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote:
> > Quoting Mathieu Bridon (2018-08-16 15:00:39)
> > > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
> > > > ---
> > > >
> > > > I didn't see any patches from anyone else, so I wrote some r
Reviewed-by: Dylan Baker
Quoting Emil Velikov (2018-08-16 09:58:53)
> From: Emil Velikov
>
> The requirement was bumped a while back, but we forgot to update the
> docs.
>
> Fixes: ed871af91c2 ("configure.ac: raise Mako required version to
> 0.8.0")
> Cc: Eric Engestrom
> Signed-off-by: Emil
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2018-08-16 08:03:23)
> Signed-off-by: Eric Engestrom
> ---
> src/util/xmlpool/t_options.h | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/src/util/xmlpool/t_options.h b/src/util/xmlpool/t_opt
On Mon, Jul 23, 2018 at 3:03 AM Timothy Arceri
wrote:
> Since we know what side of the branch we ended up on we can just
> replace the use with a constant.
>
> All the spill changes in shader-db are from Dolphin uber shaders,
> despite some small regressions the change is clearly positive.
>
> sh
Thanks for your review, Lionel.
The reduction mode in Intel bspec has the 4th option (COMPARISON), in addition
to 3 options in Vulkan spec: standard/min/max sampling.
I disabled reduction mode when compare mode in sampler state is enabled. It
looks like the hardware can set appropriate reductio
It took me a while to figure out what you're doing here but, once I've
grokked it, I like it. That said, I'd like to see your response to my
comments on patch 1 as that would cause this to get restructured a good
bit. (I think it will be much improved for it.)
--Jason
On Mon, Jul 23, 2018 at 3:
---
src/compiler/glsl/glcpp/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/glcpp/meson.build
b/src/compiler/glsl/glcpp/meson.build
index 09d44ddd687..769406f5331 100644
--- a/src/compiler/glsl/glcpp/meson.build
+++ b/src/compiler/glsl/glcpp/mes
We are testing the behaviour of a tool, for different input files, each
one using a different newline sequence. ('\n' on UNIX, '\r\n' on
Windows, …)
Unfortunately, when opening a file in text mode, Python 3 will by
default enable the "universal newlines" mode, which means it replaces
all the known
Python 3 does not automatically convert from bytes to unicode strings
like Python 2 used to do.
This commit makes sure we pass unicode strings to difflib.unified_diff,
so that the script works on both Python 2 and 3.
---
src/compiler/glsl/glcpp/tests/glcpp_test.py | 3 ++-
1 file changed, 2 inser
Thanks for the explanation and fixing the boolean mess
Reviewed-by: Jason Ekstrand
On Mon, Jul 23, 2018 at 3:02 AM Timothy Arceri
wrote:
> The innermost check was added to stop us from unrolling multiple
> loops in a single pass, and to stop outer loops from unrolling.
>
> When we successfully
Ugh... Now that I think about it more, my suggestions on the previous patch
conflict quite a bit. :( Let me think some more.
On Fri, Aug 17, 2018 at 2:27 PM Jason Ekstrand wrote:
> It took me a while to figure out what you're doing here but, once I've
> grokked it, I like it. That said, I'd li
for the series:
Reviewed-by: Dylan Baker
Quoting Mathieu Bridon (2018-08-17 12:32:16)
> Python 3 does not automatically convert from bytes to unicode strings
> like Python 2 used to do.
>
> This commit makes sure we pass unicode strings to difflib.unified_diff,
> so that the script works on both
Quoting Mathieu Bridon (2018-08-17 12:32:18)
> ---
> src/compiler/glsl/glcpp/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/glsl/glcpp/meson.build
> b/src/compiler/glsl/glcpp/meson.build
> index 09d44ddd687..769406f5331 100644
> --- a/src/comp
On Fri, 2018-08-17 at 12:54 -0700, Dylan Baker wrote:
> Quoting Mathieu Bridon (2018-08-17 12:32:18)
> > ---
> > src/compiler/glsl/glcpp/meson.build | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/glsl/glcpp/meson.build
> > b/src/compiler/glsl/glcpp/m
If it's not the right bit-size, it may not actually be the correct
extraction. For now, we'll only worry about 32-bit versions.
Fixes: 905ff8619824 "nir: Recognize open-coded extract_u16"
Fixes: 76289fbfa84a "nir: Recognize open-coded extract_u8"
---
src/compiler/nir/nir_opt_algebraic.py | 4 ++-
This patch series has been on my mind to write for a very long time now.
It moves the storage image lowering we have to do for Intel hardware into
NIR. This series makes several improvements:
1) The NIR optimizer can go to town on it and we can just improve the
optimizer instead of spending
Found by inspection. This doesn't help much now but we'll see this
pattern with images if you load UNORM and then store UNORM.
Shader-db results on Kaby Lake:
total instructions in shared programs: 15166916 -> 15166910 (<.01%)
instructions in affected programs: 761 -> 755 (-0.79%)
he
This adds the "(a << N) >> M" family of mask or sign-extensions. Not a
huge win right now but this pattern will soon be generated by NIR format
lowering code.
Shader-db results on Kaby Lake:
total instructions in shared programs: 15166918 -> 15166916 (<.01%)
instructions in affected prog
---
src/compiler/nir/nir_format_convert.h | 35 +--
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git a/src/compiler/nir/nir_format_convert.h
b/src/compiler/nir/nir_format_convert.h
index b1345f7263b..305273cdfdd 100644
--- a/src/compiler/nir/nir_format_convert.
---
src/compiler/nir/nir_format_convert.h | 37 +--
1 file changed, 29 insertions(+), 8 deletions(-)
diff --git a/src/compiler/nir/nir_format_convert.h
b/src/compiler/nir/nir_format_convert.h
index 45532b74884..b1345f7263b 100644
--- a/src/compiler/nir/nir_format_convert.
---
src/compiler/nir/nir_format_convert.h | 56 +++
1 file changed, 56 insertions(+)
diff --git a/src/compiler/nir/nir_format_convert.h
b/src/compiler/nir/nir_format_convert.h
index f2eafcbf5b4..75793733ea6 100644
--- a/src/compiler/nir/nir_format_convert.h
+++ b/src/comp
We have a name for that, it's called a uvec. This just makes the
function name a bit shorter. While we're here, we also add an assert
for one of the assumptions this function makes.
---
src/compiler/nir/nir_format_convert.h | 5 +++--
src/intel/blorp/blorp_blit.c | 2 +-
2 files changed
---
src/intel/isl/isl_storage_image.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/intel/isl/isl_storage_image.c
b/src/intel/isl/isl_storage_image.c
index e2bd4ddebad..43398e8a020 100644
--- a/src/intel/isl/isl_storage_image.c
+++ b/src/intel/isl/isl_storage_imag
1 - 100 of 135 matches
Mail list logo
