Re: [Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

2018-08-02 Thread Andres Gomez
On Wed, 2018-08-01 at 15:31 -0700, Dylan Baker wrote: > I pushed a patch earlier that *should* make mkdir and getpid work with msvc Thanks for the heads up. I'll drop this patch, then. > > Dylan > > Quoting Andres Gomez (2018-08-01 11:53:04) > > Opt-out the code using mkdir() and getpid() which

[Mesa-dev] [PATCH] docs/features: update vulkan 1.1 status

2018-08-02 Thread Fabio Pedretti
--- docs/features.txt | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 46e5a25a75..1225042580 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -356,29 +356,29 @@ Vulkan 1.0 -- a

Re: [Mesa-dev] [PATCH] glx: Add checks for context being direct before calling GetGLXDRIDrawable

2018-08-02 Thread Danylo Piliaiev
On 01.08.18 19:42, Adam Jackson wrote: On Wed, 2018-08-01 at 17:15 +0300, Danylo Piliaiev wrote: If indirect context is explicitly created by application and not with LIBGL_ALWAYS_INDIRECT=1 then dri may be initialized in __glXInitialize which allows Mesa to take invalid code paths due to GetG

[Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-02 Thread Juan A. Suarez Romero
If color buffer is locked, do not set its wayland buffer to NULL; otherwise it can not be freed later. This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. --- src/egl/drivers/dri2/platform_wayland.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/e

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-02 Thread Michel Dänzer
On 2018-08-01 01:10 PM, Qiang Yu wrote: > Add two places for hosting drirc config files: > /usr/share/drirc.d/ /etc/drirc.d/ > > Driver and application can put their drirc files in > these places with name xxx.conf. Config files will be > read and applied in file name alphabete order. > > So ther

Re: [Mesa-dev] [PATCH 2/2] loader: add dri_driver drirc option to override dri driver to load

2018-08-02 Thread Michel Dänzer
On 2018-08-01 01:10 PM, Qiang Yu wrote: > drirc implementation of MESA_LOADER_DRIVER_OVERRIDE which can be > used to override dri driver to load. > > Usage: > > override dri driver for device with spec kernel driver name: > > > I still think a separate kernel_driver attribute would be clean

[Mesa-dev] [PATCH 02/14] intel: tools: aubwrite: reuse canonical address helper

2018-08-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_write.h | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h index 2e42e3d4009..b421679b9eb 100644 --- a/src/intel/tools/aub_write.h +++ b/src/int

[Mesa-dev] [PATCH 03/14] intel: decoder: remove unused variable

2018-08-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index d8add4ccdb7..a80c50b6647 100644 --- a/src/intel/common/gen_decoder.h +++ b/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH 01/14] intel: aubinator: fix read the context/ring

2018-08-02 Thread Lionel Landwerlin
Up to now we've been lucky that the buffer returned was always exactly at the address we requested. Fixes: 144b40db5411 ("intel: aubinator: drop the 1Tb GTT mapping") Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 00/14] intel: tools: Add a UI aub editor/viewer

2018-08-02 Thread Lionel Landwerlin
Hi all, This is an iteration on a series I sent about 8 months ago to add a new tool to inspect aub files. Rafael expressed some interest so here is an updated version. This version isn't as feature complete as the previous version but we can iterate on that later. The main new addition here is t

[Mesa-dev] [PATCH 05/14] intel: aubinator: simplify decoding

2018-08-02 Thread Lionel Landwerlin
Since we don't support streaming an aub file, we can drop the decoding status enum. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index

[Mesa-dev] [PATCH 06/14] intel: tools: simplify meson build

2018-08-02 Thread Lionel Landwerlin
Remove the if tools condition and just put it through the install: parameter. Signed-off-by: Lionel Landwerlin --- src/intel/tools/meson.build | 96 +++-- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/src/intel/tools/meson.build b/src/intel/tools

[Mesa-dev] [PATCH 04/14] intel: common: add missing stdint include

2018-08-02 Thread Lionel Landwerlin
--- src/intel/common/gen_gem.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/common/gen_gem.h b/src/intel/common/gen_gem.h index 7dd9ae6d548..8df2c249e48 100644 --- a/src/intel/common/gen_gem.h +++ b/src/intel/common/gen_gem.h @@ -24,6 +24,8 @@ #ifndef GEN_GEM_H #define GEN_GEM

[Mesa-dev] [PATCH 10/14] intel: tools: aubwrite: wrap function declarations for c++

2018-08-02 Thread Lionel Landwerlin
--- src/intel/tools/aub_write.h | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h index b421679b9eb..6a09c1747b9 100644 --- a/src/intel/tools/aub_write.h +++ b/src/intel/tools/aub_write.h @@ -31,6 +31,10 @@ #include "dev/gen_devi

[Mesa-dev] [PATCH 13/14] intel: tools: add aubinator viewer

2018-08-02 Thread Lionel Landwerlin
A graphical user interface version of aubinator. Allows you to : - simultaneously look at multiple points in the aub file (using all the goodness of the existing decoding in aubinator) - edit an aub file Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer.cpp

[Mesa-dev] [PATCH 07/14] intel: tools: split aub parsing from aubinator

2018-08-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_read.c | 307 ++ src/intel/tools/aub_read.h | 75 + src/intel/tools/aubinator.c | 324 +--- src/intel/tools/meson.build | 2 +- 4 files changed, 426 insertions(+),

[Mesa-dev] [PATCH 08/14] util: rb_tree: add safe iterators

2018-08-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/util/rb_tree.h | 36 1 file changed, 36 insertions(+) diff --git a/src/util/rb_tree.h b/src/util/rb_tree.h index c77e9255ea2..df1a4197b8a 100644 --- a/src/util/rb_tree.h +++ b/src/util/rb_tree.h @@ -243,6 +243,24 @@ st

[Mesa-dev] [PATCH 14/14] intel: tools: ui: fix edition in memory view

2018-08-02 Thread Lionel Landwerlin
Based on https://github.com/ocornut/imgui_club/pull/5 Signed-off-by: Lionel Landwerlin --- src/intel/tools/imgui/imgui_memory_editor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/imgui/imgui_memory_editor.h b/src/intel/tools/imgui/imgui_memory_editor.h in

[Mesa-dev] [PATCH 09/14] intel: tools: split memory management out of aubinator

2018-08-02 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_mem.c | 391 src/intel/tools/aub_mem.h | 72 +++ src/intel/tools/aubinator.c | 379 +++--- src/intel/tools/meson.build | 2 +- 4 files changed, 491 insertions(+), 3

[Mesa-dev] [PATCH 11/14] intel: tools: aubmem: map gtt data to aub file

2018-08-02 Thread Lionel Landwerlin
This will allow the aubinator viewer tool to modify the aub data that was loaded at a particular gtt address. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_mem.c | 29 + src/intel/tools/aub_mem.h | 6 ++ 2 files changed, 35 insertions(+) diff --git a/

Re: [Mesa-dev] [PATCH 0/1] swr: Remove unnecessary memset call

2018-08-02 Thread Eric Engestrom
On Wednesday, 2018-08-01 20:56:22 +0300, Vlad Golovkin wrote: > This patch is identical to the previous one, but that time I forgot to > mention that I didn't have commit rights, so I am sending the rebased > patch for the review. Reviewed and pushed, thanks :) > > Vlad Golovkin (1): > swr: Re

Re: [Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs on gen8

2018-08-02 Thread Lionel Landwerlin
On 10/07/18 05:59, Jason Ekstrand wrote: On all other platforms, it's safe to use the usual PTE settings for both internal and external BOs. On Broadwell, however, we can't get the right caching behavior for scanout without disabling eLLC and we really don't want to do this on everything. In or

[Mesa-dev] [PATCH mesa] loader: fix indentation

2018-08-02 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/loader/loader.c | 4 ++-- src/loader/loader_dri3_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 43275484cc2e0c845e10..fda49521aae4056214d5 100644 --- a/src/loader/loa

[Mesa-dev] [PATCH mesa] egl/main: fix indentation

2018-08-02 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- egl platforms are full of randomly-indented lines, so I won't bother to avoid rebase conflicts and blurring the history. --- src/egl/main/eglconfig.c | 2 +- src/egl/main/egldisplay.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl

Re: [Mesa-dev] [PATCH mesa] loader: fix indentation

2018-08-02 Thread Frank Binns
Reviewed-by: Frank Binns Eric Engestrom writes: > Signed-off-by: Eric Engestrom > --- > src/loader/loader.c | 4 ++-- > src/loader/loader_dri3_helper.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/loader/loader.c b/src/loader/loader.c > index 432

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Eric Engestrom
On Wednesday, 2018-08-01 23:07:02 +0200, Christian Gmeiner wrote: > Add an improved drmOpenWithType(..) clone which fixes some serious > flaws. Some highlights: > - using busid works only with PCI devices > - open() w/o O_CLOEXEC > - when build w/o udev - it creates a node: mkdir, chown(root), c

Re: [Mesa-dev] [PATCH mesa] egl/main: fix indentation

2018-08-02 Thread Frank Binns
Reviewed-by: Frank Binns Eric Engestrom writes: > Signed-off-by: Eric Engestrom > --- > egl platforms are full of randomly-indented lines, so I won't bother > to avoid rebase conflicts and blurring the history. > --- > src/egl/main/eglconfig.c | 2 +- > src/egl/main/egldisplay.c | 2 +- > 2

[Mesa-dev] [PATCH v3] mesa: enable EXT_render_snorm extension

2018-08-02 Thread Tapani Pälli
Patch sets additional formats renderable and enables the extension when OpenGL ES 3.1 is supported. v2: instead of dummy_true, have a separate toggle for extension (Eric Anholt) v3: add missing checks, simplify some existing checks and fix glCopyTexImage2D check (Nanley Chery) add SH

[Mesa-dev] [PATCH] i965: enable EXT_render_snorm

2018-08-02 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 2e28445ae3..f1c3aeff13 100644 --- a/src/mesa/drivers/dri/i965/intel_e

[Mesa-dev] [PATCH 10/15] compiler/spirv: add XFB and GeometryStreams capability check support

2018-08-02 Thread Alejandro Piñeiro
FWIW, this is the only patch pending to be reviewed on the series (sorry Timothy, I used wrong patch numbers when I pinged you on IRC). BR On 20/07/18 17:08, Alejandro Piñeiro wrote: > --- > src/compiler/shader_info.h| 2 ++ > src/compiler/spirv/spirv_to_nir.c | 10 -- > 2 file

[Mesa-dev] [PATCH 0/1] swr: Remove unnecessary memset call

2018-08-02 Thread Vlad Golovkin
This patch is identical to the one I sent in April, but that time I forgot to mention that I didn't have commit rights, so I am sending the rebased patch for the review. Vlad Golovkin (1): swr: Remove unnecessary memset call src/gallium/drivers/swr/swr_screen.cpp | 1 - 1 file changed, 1 delet

[Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Marek Olšák
From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77 +--- include/GL/glxext.h| 22 -- include/GLES2/gl2.h| 8 +-- include/GLES2/gl2ext.h | 159 +++-- include/GLES3/gl3.h| 8 +-

[Mesa-dev] [PATCH 4/7] dri: Add param driCreateConfigs(mutable_render_buffer)

2018-08-02 Thread Chad Versace
If set, then the config will have __DRI_ATTRIB_MUTABLE_RENDER_BUFFER, which translates to EGL_MUTABLE_RENDER_BUFFER_BIT_KHR. Not used yet. --- src/gallium/state_trackers/dri/dri_screen.c | 4 ++-- src/mesa/drivers/dri/common/utils.c | 9 +++-- src/mesa/drivers/dri/common/utils.h

[Mesa-dev] [PATCH] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v3)

2018-08-02 Thread Marek Olšák
From: Marek Olšák v2: need to do MAX{start+count} instead of MAX{count} added piglit tests v3: use malloc --- src/gallium/auxiliary/util/u_vbuf.c | 204 1 file changed, 180 insertions(+), 24 deletions(-) diff --git a/src/gallium/auxiliary/util/u_vbuf.c b/src/ga

[Mesa-dev] [PATCH 6/7] egl/android: Implement EGL_KHR_mutable_render_buffer

2018-08-02 Thread Chad Versace
Specifically, implement the extension DRI_MutableRenderBufferLoader. However, the loader enables EGL_KHR_mutable_render_buffer only if the DRI driver implements its half of the extension, DRI_MutableRenderBufferDriver. --- src/egl/drivers/dri2/egl_dri2.c | 38 +- src/egl/drivers/dri2/

Re: [Mesa-dev] [PATCH 2/2] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v2)

2018-08-02 Thread Marek Olšák
On Fri, Jul 27, 2018 at 5:46 PM, Marek Olšák wrote: > On Fri, Jul 27, 2018 at 5:08 PM, Eric Anholt wrote: >> Marek Olšák writes: >> >>> From: Marek Olšák >>> >>> v2: need to do MAX{start+count} instead of MAX{count} >>> added piglit tests >>> --- >>> src/gallium/auxiliary/util/u_vbuf.c | 1

Re: [Mesa-dev] [PATCH] drisw: Fix build on Android Nougat, which lacks shm (v2)

2018-08-02 Thread David Airlie
On Tue, Jul 31, 2018 at 1:17 PM, Chad Versace wrote: > In commit cf54bd5e8, dri_sw_winsys.c began using to support > the new functions putImageShm, getImageShm in DRI_SWRastLoader. But > Android began supporting System V shared memory only in Oreo. Nougat has > no shm headers. > > Fix the build

Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-08-02 Thread Marek Olšák
On my machine, the global drirc resides in /usr/etc/. I guess it's in a different place for each person. :) Marek On Tue, Jul 31, 2018 at 2:08 PM, Adam Jackson wrote: > On Tue, 2018-07-31 at 08:03 +, Yu, Qiang wrote: >> Seems the mesa driconf infrastructure is just what I need: >> https://dr

Re: [Mesa-dev] [PATCH 2/2] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v2)

2018-08-02 Thread Eric Anholt
Marek Olšák writes: > On Fri, Jul 27, 2018 at 5:46 PM, Marek Olšák wrote: >> On Fri, Jul 27, 2018 at 5:08 PM, Eric Anholt wrote: >>> Marek Olšák writes: >>> From: Marek Olšák v2: need to do MAX{start+count} instead of MAX{count} added piglit tests --- src/ga

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-02 Thread Marek Olšák
On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel wrote: > Am 01.08.2018 05:56, schrieb Timothy Arceri: >> >> On 01/08/18 13:09, Dieter Nützel wrote: >>> >>> Am 31.07.2018 13:34, schrieb Timothy Arceri: On 31/07/18 13:50, Dieter Nützel wrote: > > Am 30.07.2018 05:24, schrieb Dieter N

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-02 Thread Dieter Nützel
Am 30.07.2018 05:24, schrieb Dieter Nützel: For the series Tested-by: Dieter Nützel with glmark2, glxgears, UH, UV, Blender 2.79 and FreeCAD 0.17 on RX 580. With UH I saw some small light blue triangles spreading around. Have to bisect which patch set was the culprit. (If I have some time.)

Re: [Mesa-dev] [PATCH] vc4: Fix automake linking error.

2018-08-02 Thread Andres Gomez
The problem seemed to be scons itself. Therefore, this is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 18:03 +0300, Andres Gomez wrote: > This looks good but, unfortunately, it seems to be breaking Travis > build for the scons targets: > https://travis-ci.org/Igalia/mesa/jobs/410431266 >

Re: [Mesa-dev] [PATCH 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Ilia Mirkin
On Wed, Aug 1, 2018 at 2:53 PM, Andres Gomez wrote: > The binary constant notation "0b" is a GCC extension. Instead, we use > hexadecimal notation to fix the MSVC 2013 build: > > Compiling src\mesa\main\texcompress_astc.cpp ... > texcompress_astc.cpp > src\mesa\main\texcompress_astc.cpp(111) : err

Re: [Mesa-dev] [PATCH] glx: Add checks for context being direct before calling GetGLXDRIDrawable

2018-08-02 Thread Adam Jackson
On Wed, 2018-08-01 at 17:15 +0300, Danylo Piliaiev wrote: > If indirect context is explicitly created by application and not > with LIBGL_ALWAYS_INDIRECT=1 then dri may be initialized in > __glXInitialize which allows Mesa to take invalid code paths > due to GetGLXDRIDrawable returning non-null val

Re: [Mesa-dev] [PATCH 01/12] util/list: Make some helpers take const lists

2018-08-02 Thread Ian Romanick
Yes, please! I have a similar patch around somewhere that was waiting for a user before sending. Reviewed-by: Ian Romanick On 07/26/2018 08:59 AM, Jason Ekstrand wrote: > They're all just querying things about the list and not mutating > anything. > --- > src/util/list.h | 8 > 1 file

Re: [Mesa-dev] [PATCH 2/2] egl/surfaceless: Allow DRMless fallback.

2018-08-02 Thread Chad Versace
On Tue 17 Jul 2018, Eric Engestrom wrote: > On Thursday, 2018-07-12 16:13:55 -0700, David Riley wrote: > > Allow platform_surfaceless to use swrast even if DRM is not available. > > To be used to allow a fuzzer for virgl to be run on a jailed VM without > > hardware GL or DRM support. > > > > Sign

[Mesa-dev] [PATCH] docs/features: update vulkan 1.1 status

2018-08-02 Thread Fabio Pedretti
--- docs/features.txt | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 46e5a25a75..1225042580 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -356,29 +356,29 @@ Vulkan 1.0 -- a

[Mesa-dev] [PATCH 3/6] kutil/queue: use util_snprintf() in util_queue_init

2018-08-02 Thread Andres Gomez
Instead of plain snprintf(). To fix the MSVC 2013 build: Compiling src\util\u_queue.c ... u_queue.c src\util\u_queue.c(325) : warning C4013: 'snprintf' undefined; assuming extern returning int ... mesautil.lib(u_queue.obj) : error LNK2001: unresolved external symbol _snprintf scons: building

[Mesa-dev] [PATCH 4/6] ddebug: use util_snprintf() in dd_get_debug_filename_and_mkdir

2018-08-02 Thread Andres Gomez
Instead of plain snprintf(). To fix the MSVC 2013 build: Compiling src\gallium\auxiliary\driver_ddebug\dd_draw.c ... dd_draw.c c:\projects\mesa\src\gallium\auxiliary\driver_ddebug\dd_util.h(60) : warning C4013: 'snprintf' undefined; assuming extern returning int ... gallium.lib(dd_draw.obj) :

[Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-02 Thread Olivier Fourdan
st_renderbuffer_delete() can segfault if we get a non-NULL context pointer but if the st_context is NULL: Thread 1 "Xwayland" received signal SIGSEGV, Segmentation fault. in st_renderbuffer_delete () at state_tracker/st_cb_fbo.c:241 241 pipe_surface_release(st->pipe, &strb->surface_srgb);

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-02 Thread Eric Engestrom
On Thursday, 2018-08-02 11:33:05 +0200, Michel Dänzer wrote: > On 2018-08-01 01:10 PM, Qiang Yu wrote: > > Add two places for hosting drirc config files: > > /usr/share/drirc.d/ /etc/drirc.d/ > > > > Driver and application can put their drirc files in > > these places with name xxx.conf. Config fi

Re: [Mesa-dev] [PATCH 05/14] intel: aubinator: simplify decoding

2018-08-02 Thread Eric Engestrom
On Thursday, 2018-08-02 10:39:17 +0100, Lionel Landwerlin wrote: > Since we don't support streaming an aub file, we can drop the decoding > status enum. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-02 Thread Michel Dänzer
On 2018-08-02 02:50 PM, Eric Engestrom wrote: > On Thursday, 2018-08-02 11:33:05 +0200, Michel Dänzer wrote: >> On 2018-08-01 01:10 PM, Qiang Yu wrote: >>> Add two places for hosting drirc config files: >>> /usr/share/drirc.d/ /etc/drirc.d/ >>> >>> Driver and application can put their drirc files i

[Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

2018-08-02 Thread Jon Turney
With a sufficently recent meson, the following warning is produced: WARNING: Passed invalid keyword argument "extra_args". WARNING: This will become a hard error in the future. It seems that compiler.links(args:) is meant here. Signed-off-by: Jon Turney --- meson.build | 2 +- 1 file changed,

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

2018-08-02 Thread Eric Engestrom
On Thursday, 2018-08-02 14:58:07 +0100, Jon Turney wrote: > With a sufficently recent meson, the following warning is produced: > > WARNING: Passed invalid keyword argument "extra_args". > WARNING: This will become a hard error in the future. > > It seems that compiler.links(args:) is meant here.

Re: [Mesa-dev] [PATCH 0/8] GL_AMD_framebuffer_multisample_advanced for RadeonSI

2018-08-02 Thread Brian Paul
On 08/01/2018 05:25 PM, Marek Olšák wrote: Hi, This implements GL_AMD_framebuffer_multisample_advanced, which is AMD EQAA. I have also sent out a piglit test that tests the new API. Please review. I did a quick read-through and it looks OK to me. Reviewed-by: Brian Paul ___

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Christian Gmeiner
Hi Eric Thanks for you code review! Am Do., 2. Aug. 2018 um 13:09 Uhr schrieb Eric Engestrom : > > On Wednesday, 2018-08-01 23:07:02 +0200, Christian Gmeiner wrote: > > Add an improved drmOpenWithType(..) clone which fixes some serious > > flaws. Some highlights: > > - using busid works only wit

[Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Brian Paul
Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). I don't know of any driver which only supports GL 2.0, but adding this switch case avoids a failure if the app queries GL_SHADING_LANGUAGE_VERSION. --- src/mesa/main/version.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Guang Bai
All, I'm seeing build failures on mesa 18.2 & master branches with "--with-vulkan-drivers=intel" And also notice some web-posting that libxcb-xrandr 1.13 would be needed to get the build successful. What's the correct solution for my build issue? (I'm still new to mesa) Thanks! Guang __

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Emil Velikov
On 1 August 2018 at 22:07, Christian Gmeiner wrote: > Add an improved drmOpenWithType(..) clone which fixes some serious > flaws. Some highlights: > - using busid works only with PCI devices > - open() w/o O_CLOEXEC > - when build w/o udev - it creates a node: mkdir, chown(root), chmod, mknod >

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Emil Velikov
On 2 August 2018 at 07:47, Mauro Rossi wrote: > Hi, > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz > ha scritto: >> >> Just as a heads up, with mesa3d master (plus my other build fixups I >> just sent out), I'm seeing a new build failure when building under >> AOSP/master: >> >> external

[Mesa-dev] [ANNOUNCE] mesa 18.0-0-rc1

2018-08-02 Thread Andres Gomez
The first release candidate for Mesa 18.2.0 is now available. The plan is to have one release candidate every Wednesday, until the anticipated final release on 22nd August 2018. The expectation is that the 18.1 branch will remain alive with bi- weekly releases until the 18.2.1 release. NOTE: Bui

Re: [Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-02 Thread Emil Velikov
On 2 August 2018 at 00:20, John Stultz wrote: > From: Sumit Semwal > > This is a forward port of a patch from the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ > > Since https://android-review.googlesource.com/c/718

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Hi It would be helpful if you posted the failure output, without it its difficult to diagnose I'm not seeing any issues with the master branch on the meson build Is this your first time building mesa, or has something suddenly stopped working? Cheers Mike On Thu, 2 Aug 2018 at 16:46 Guang Bai

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
The subject was obviously wrong 😕 On Thu, 2018-08-02 at 18:52 +0300, Andres Gomez wrote: > The first release candidate for Mesa 18.2.0 is now available. > > The plan is to have one release candidate every Wednesday, until the > anticipated final release on 22nd August 2018. > > The expectation i

[Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Andres Gomez
Tarball distribution is done through "make distcheck". We include the meson targets also into autotools so they won't fail when building from the tarball. Fixes: 6a60beba408 ("intel/tools: Add an error state to aub translator") Cc: Jason Ekstrand Cc: Lionel Landwerlin Cc: Dylan Baker Signed-off

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Lionel Landwerlin
On 02/08/18 17:39, Andres Gomez wrote: Tarball distribution is done through "make distcheck". We include the meson targets also into autotools so they won't fail when building from the tarball. Fixes: 6a60beba408 ("intel/tools: Add an error state to aub translator") Cc: Jason Ekstrand Cc: Lione

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

2018-08-02 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Jon Turney (2018-08-02 06:58:07) > With a sufficently recent meson, the following warning is produced: > > WARNING: Passed invalid keyword argument "extra_args". > WARNING: This will become a hard error in the future. > > It seems that compiler.links(args:) is m

[Mesa-dev] [Bug 107455] [TRACKER] Mesa 18.3 feature tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107455 Bug ID: 107455 Summary: [TRACKER] Mesa 18.3 feature tracker Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Pri

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Which distro are you using? On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > This is the reason for me to look for helps from our mesa-dev community. > Thanks, > Guang > > On Thu, 2 Aug 2018 17:10:16 +0100 > Mike Lothian wrote: > > > Yeah the lease stuff was added in the newer version of xcb-prot

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Marek Olšák
On Thu, Aug 2, 2018, 2:42 AM Andres Gomez wrote: > On Wed, 2018-08-01 at 19:54 -0400, Marek Olšák wrote: > > For patches 5 & 6: > > > > Reviewed-by: Marek Olšák > > Thanks, Marek! > > > I can't see patches 3 & 4 on the list. > > The list has been having some troubles in the last hours. I will re

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Guang Bai
On Thu, 2 Aug 2018 17:55:21 +0100 Mike Lothian wrote: > Which distro are you using? uBuntu-14.045 & uBuntu-16.04 Thanks, Guang > > On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > > > This is the reason for me to look for helps from our mesa-dev > > community. Thanks, > > Guang > > > > On Thu,

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Andres Gomez
On Thu, 2018-08-02 at 12:55 -0400, Marek Olšák wrote: > > > On Thu, Aug 2, 2018, 2:42 AM Andres Gomez wrote: > > On Wed, 2018-08-01 at 19:54 -0400, Marek Olšák wrote: > > > For patches 5 & 6: > > > > > > Reviewed-by: Marek Olšák > > > > Thanks, Marek! > > > > > I can't see patches 3 & 4 on t

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug ID: 107457 Summary: [Tracker] Mesa 18.2 release tracker Product: Mesa Version: 18.2 Hardware: Other OS: All Status: NEW Severity: normal Pr

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
That's packaged for bionic, might be worth creating your own PPA and base the pkgbuild on that - apologies if I'm getting the lingo wrong - I don't use Ubuntu myself Alternatively maybe check for other PPAs that might have them already packaged for you, I think Padoka and Oibaf might have what you

[Mesa-dev] [Bug 106156] [TRACKER] Mesa 18.2 feature tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106156 Andrés Gómez García changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
Forgot to mention that, in the path to 18.2.0, there is now a tracker bug for the regressions found since 18.1: https://bugs.freedesktop.org/show_bug.cgi?id=107457 On Thu, 2018-08-02 at 19:05 +0300, Andres Gomez wrote: > The subject was obviously wrong 😕 > > On Thu, 2018-08-02 at 18:52 +0300, An

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Mauro Rossi
Hi, Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov < emil.l.veli...@gmail.com> ha scritto: > On 2 August 2018 at 07:47, Mauro Rossi wrote: > > Hi, > > > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz < > john.stu...@linaro.org> > > ha scritto: > >> > >> Just as a heads up, with mes

[Mesa-dev] meas master branch build failure related with vulkan

2018-08-02 Thread Guang Bai
All, Is there any fix expected for mesa/master branch build failures related with vulkan? And the "xcb-randr" 1.13+ has to be installed to build the mesa/master branch? Where can I download the xcb-randr 1.13 - I can only find the 1.12 package now. Regards, Guang _

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-02 09:46:59) > On 02/08/18 17:39, Andres Gomez wrote: > > Tarball distribution is done through "make distcheck". We include the > > meson targets also into autotools so they won't fail when building > > from the tarball. > > > > Fixes: 6a60beba408 ("intel/tools: A

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Dylan Baker
This seems like a fine thing to do, I don't know how many people actually build tools from the tarball, but making them work seems useful. Reviewed-by: Dylan Baker Quoting Andres Gomez (2018-08-02 09:39:06) > Tarball distribution is done through "make distcheck". We include the > meson targets a

[Mesa-dev] [PATCH] anv/pipeline: Disable FS dispatch for pointless fragment shaders

2018-08-02 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 85f38da60ff..86e0211a29d 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/intel/v

Re: [Mesa-dev] meas master branch build failure related with vulkan

2018-08-02 Thread Bai, Guang
Please ignore this mail - I posted before joining the "mesa-dev" mailing list. There is already a new email loop to address my questions. Thanks, Guang -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Guang Bai Sent: Wednesday, August 01, 2018

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread John Stultz
On Thu, Aug 2, 2018 at 10:25 AM, Mauro Rossi wrote: > Hi, > > > Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov > ha scritto: >> >> On 2 August 2018 at 07:47, Mauro Rossi wrote: >> > Hi, >> > >> > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz >> > >> > ha scritto: >> >> >> >> Just as

Re: [Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Eric Anholt
Brian Paul writes: > Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). > I don't know of any driver which only supports GL 2.0, but adding > this switch case avoids a failure if the app queries > GL_SHADING_LANGUAGE_VERSION. Reviewed-by: Eric Anholt signature.asc Descript

Re: [Mesa-dev] [PATCH] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v3)

2018-08-02 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > v2: need to do MAX{start+count} instead of MAX{count} > added piglit tests > v3: use malloc > --- > src/gallium/auxiliary/util/u_vbuf.c | 204 > 1 file changed, 180 insertions(+), 24 deletions(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/02/2018 08:45 AM, Brian Paul wrote: > Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). > I don't know of any driver which only supports GL 2.0, but adding > this switch case avoids a failure if the app queries > GL_SHADING_LANGUAGE_VERSION. >

[Mesa-dev] [PATCH 03/13] nir: Don't compare i2f or u2i with zero

2018-08-02 Thread Ian Romanick
From: Ian Romanick Broadwell and Skylake had similar results. (Skylake shown) total instructions in shared programs: 14277620 -> 14277230 (<.01%) instructions in affected programs: 36905 -> 36515 (-1.06%) helped: 101 HURT: 6 helped stats (abs) min: 1 max: 6 x̄: 4.46 x̃: 6 helped stats (rel) min:

[Mesa-dev] [PATCH 02/13] nir: Remove f2i(i2f(x)) conversions

2018-08-02 Thread Ian Romanick
From: Ian Romanick Broadwell and Skylake had similar results. (Skylake shown) total instructions in shared programs: 14277978 -> 14277620 (<.01%) instructions in affected programs: 36957 -> 36599 (-0.97%) helped: 76 HURT: 1 helped stats (abs) min: 2 max: 90 x̄: 4.89 x̃: 4 helped stats (rel) min:

[Mesa-dev] [PATCH 07/13] nir: Transform expressions of b2f(a) and b2f(b) to a || b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen6+ platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277184 -> 14276964 (<.01%) instructions in affected programs: 10082 -> 9862 (-2.18%) helped: 37 HURT: 1 helped stats (abs) min: 1 max: 30 x̄: 5.97 x̃: 4 helped stats (rel) m

[Mesa-dev] [PATCH 01/13] nir: Mark the 0.0 < abs(a) transformation as imprecise

2018-08-02 Thread Ian Romanick
From: Ian Romanick Unlike the much older -abs(a) >= 0.0 transformation, this is not precise. The behavior changes if the source is NaN. No shader-db changes on any platform. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[Mesa-dev] [PATCH 05/13] nir: Rearrange bcsel with two bcsel sources

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277220 -> 14277216 (<.01%) instructions in affected programs: 422 -> 418 (-0.95%) helped: 2 HURT: 0 total cycles in shared programs: 532577908 -> 532577848 (<.01%) cycles in

[Mesa-dev] [PATCH 11/13] nir: Transform expressions of b2f(a) and b2f(b) to !(a && b)

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total cycles in shared programs: 532578400 -> 532578397 (<.01%) cycles in affected programs: 2784 -> 2781 (-0.11%) helped: 1 HURT: 1 helped stats (abs) min: 4 max: 4 x̄: 4.00 x̃: 4 helped stats (rel) min: 0.26% max:

[Mesa-dev] [PATCH 08/13] nir: Transform -fabs(a) >= 0 to a == 0

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276964 -> 14276961 (<.01%) instructions in affected programs: 411 -> 408 (-0.73%) helped: 3 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.4

[Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277230 -> 14277220 (<.01%) instructions in affected programs: 751 -> 741 (-1.33%) helped: 4 HURT: 0 helped stats (abs) min: 2 max: 3 x̄: 2.50 x̃: 2 helped stats (rel) min: 1.2

[Mesa-dev] [PATCH 12/13] nir: Transform expressions of b2f(a) and b2f(b) to a ^^ b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276892 -> 14276886 (<.01%) instructions in affected programs: 484 -> 478 (-1.24%) helped: 2 HURT: 0 total cycles in shared programs: 532578397 -> 532578395 (<.01%) cycles in

[Mesa-dev] [PATCH 09/13] nir: Transform expressions of b2f(a) and b2f(b) to !(a || b)

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen6+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276961 -> 14276892 (<.01%) instructions in affected programs: 3215 -> 3146 (-2.15%) helped: 28 HURT: 0 helped stats (abs) min: 1 max: 6 x̄: 2.46 x̃: 2 helped stats (rel) min: 0.47%

[Mesa-dev] [PATCH 10/13] nir: Transform expressions of b2f(a) and b2f(b) to a && b

2018-08-02 Thread Ian Romanick
From: Ian Romanick No changes on any Gen platform. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index 64400f92ddc..629cae5f381 100644 -

[Mesa-dev] [PATCH 06/13] nir: Transform -fabs(a) < 0 to a != 0

2018-08-02 Thread Ian Romanick
From: Ian Romanick Unlike the much older -abs(a) >= 0.0 transformation, this is not precise. The behavior changes if a is NaN. All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277216 -> 14277184 (<.01%) instructions in affected programs: 230

[Mesa-dev] [PATCH 13/13] nir: Transform expressions of b2f(a) and b2f(b) to a == b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen7+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276886 -> 14276838 (<.01%) instructions in affected programs: 312 -> 264 (-15.38%) helped: 2 HURT: 0 total cycles in shared programs: 532578395 -> 532570985 (<.01%) cycles in affe

  1   2   >