Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

On Tue, Apr 10, 2018 at 12:27 PM, Roland Scheidegger wrote: > Yes, there is indeed plenty hw (all with d3d heritage, d3d10 doesn't > support different ref/masks) which don't actually have full support for > two-sided stencil. > I think all drivers just cheat and fail though since they really want

[Mesa-dev] [PATCH 2/3] nir: remove unnecessary check when lowering to SSA

Only fully-qualified direct derefs, collected in direct_deref_nodes, are checked for aliasing, so it is already known up front that they have only array derefs of type direct. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/

[Mesa-dev] [PATCH 1/3] nir: remove leftover return value when lowering to SSA

The return value was needed to make use of the old nir_foreach_block helper, but not needed anymore with the macro version. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/n

[Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 73 +++- 1 file changed, 32

[Mesa-dev] [Bug 105952] radv causes GPU hang on SI

https://bugs.freedesktop.org/show_bug.cgi?id=105952 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

https://bugs.freedesktop.org/show_bug.cgi?id=100424 --- Comment #5 from Samuel Pitoiset --- Hi Darren, Can you still reproduce the hang? I regularly test Serious Sam Fusion on Polaris/Vega, and it never hung for me. -- You are receiving this mail because: You are the assignee for the bug. You

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Reviewed-by: Marek Olšák Marek On Tue, Apr 10, 2018 at 12:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Virtually every driver that supports ATI_separate_stencil > also supports EXT_stencil_two_side. > > Use the latter boolean for both extension. With that in mind we can drop > the expl

Re: [Mesa-dev] [PATCH v2 11/12] meson: build tests for gallium mesa state tracker

Quoting Eric Anholt (2018-04-10 11:05:03) > Dylan Baker writes: > > > Signed-off-by: Dylan Baker > > --- > > src/mesa/state_tracker/tests/meson.build | 40 +- > > src/meson.build | 3 ++- > > 2 files changed, 43 insertions(+) > > create mode 10

[Mesa-dev] [Bug 102390] centroid interpolation causes broken attribute values

https://bugs.freedesktop.org/show_bug.cgi?id=102390 Samuel Pitoiset changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Samuel P

Re: [Mesa-dev] [PATCH v2 01/12] glsl/tests: reimplement warnings-test in python

Quoting Eric Anholt (2018-04-10 10:50:32) > Dylan Baker writes: > > > This reimplements the test in python with a shell script wrapper that > > allows autotools to continue to run the test without realizing that > > anything has changed. > > > > Using python has two advantages, first it's portabl

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

https://bugs.freedesktop.org/show_bug.cgi?id=105942 --- Comment #6 from kaspar.t...@gmail.com --- Thank you! I my self probably don't have the know-how to compile & replace your patched mesa with my system's mesa to verify the fix. -- You are receiving this mail because: You are the QA Contact

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Ah neat trick. Unless you submit each prim individually I have some doubts about correctness though. But should be enough to pass piglits I suppose... svga also can't do this (it will just report this via debug callback). Roland Am 10.04.2018 um 21:50 schrieb Marek Olšák: > On Tue, Apr 10, 2018

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #9 from Timothy Arceri --- (In reply to Alan Swanson from comment #7) > Just to confirm with Ben, this very definitely affects radeonsi not just > i965. Forcing MESA_GLSL_VERSION_OVERRIDE=130 resolves issue so perhaps a > game issue

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

https://bugs.freedesktop.org/show_bug.cgi?id=105942 --- Comment #7 from Bas Nieuwenhuizen --- Since you use Arch, it may be worth building/running https://aur.archlinux.org/packages/mesa-git/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for t

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

On 11/04/18 00:34, Ilia Mirkin wrote: What about GL 2.1 and 2.0 (and earlier where you could still have GLSL as an ext)? And does the GLSL version have to line up exactly for those? Or does this just need to be default: if (ctx->Version < 31) ctx->Const.GLSLVersion = MIN2(ctx->Const.GLSLVersi

[Mesa-dev] [Bug 105320] Storage texel buffer access produces wrong results (RX Vega)

https://bugs.freedesktop.org/show_bug.cgi?id=105320 --- Comment #4 from Józef Kucia --- (In reply to Samuel Pitoiset from comment #3) > This should be fixed with > https://cgit.freedesktop.org/mesa/mesa/commit/ > ?id=4503ff760c794c3bb15b978a47c530037d56498e The attached sample program still does

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

I think this used to work previously because something would clamp GLSLVersion to 130 for compat, and it no longer does. So probably just adding 30 is enough... On Tue, Apr 10, 2018 at 5:51 PM, Timothy Arceri wrote: > On 11/04/18 00:34, Ilia Mirkin wrote: >> >> What about GL 2.1 and 2.0 (and earl

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #10 from Timothy Arceri --- (In reply to Timothy Arceri from comment #9) > (In reply to Alan Swanson from comment #7) > > Just to confirm with Ben, this very definitely affects radeonsi not just > > i965. Forcing MESA_GLSL_VERSION_OV

[Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

This is what radeonsi does. --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65e6..35b686ab7f02 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 01:11, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst > wrote: If the bindless image is passed through a struct we ended up getting the glsl_type of the struct, not the image. variable_referenced points to the declaration

Re: [Mesa-dev] [PATCH v3 000/104] nir: Move to using instructions for derefs

> I've skipped 21 and 28 because I wanted to give a deeper look at the > originals. OK. Patches 21 and 28 are Reviewed-by: Caio Marcelo de Oliveira Filho Patch 12 seems a candidate to get in early. (It is R-B'ed in my previous mail). Thanks, Caio _

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri wrote: > > > On 11/04/18 01:11, Jason Ekstrand wrote: > >> On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst > > wrote: >> >> If the bindless image is passed through a struct we ended up getting >> the >> glsl_type of

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri > wrote: On 11/04/18 01:11, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst mailto:kher...@redhat.com>

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 09:18, Timothy Arceri wrote: On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri > wrote:     On 11/04/18 01:11, Jason Ekstrand wrote:     On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst     mailto:kher...

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 09:22, Timothy Arceri wrote: On 11/04/18 09:18, Timothy Arceri wrote: On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri mailto:tarc...@itsqueeze.com>> wrote:     On 11/04/18 01:11, Jason Ekstrand wrote:     On Tue, Apr 10, 2018 at 8:05

Re: [Mesa-dev] [PATCH] vulkan: Drop vk_android_native_buffer.xml

Quoting Jason Ekstrand (2018-04-09 22:04:02) > All the information in vk_android_native_buffer.xml is now in vk.xml. > The only exception is the extension type attribute which we can work > around in the generators while we wait for the XML to be fixed. > > Cc: Dylan Baker > Cc: Tapani Pälli > -

[Mesa-dev] [PATCH] radv: Enable RB+ on Raven.

--- src/amd/vulkan/radv_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65e..22e8f1e7a78 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -293,7 +293,8 @@ radv_ph

Re: [Mesa-dev] [PATCH 1/4] ac/surface: don't set the display flag for obviously unsupported cases (v2)

What is the addrlib assertion we are hitting? On Tue, Apr 10, 2018 at 11:44 AM, Michel Dänzer wrote: > On 2018-04-06 07:12 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This enables the tile swizzle for some cases of the displayable micro mode, >> and it also fixes an addrlib assertion failu

[Mesa-dev] [PATCH] ac/surface: Allow S swizzle for displayable surfaces.

For dcn1 && < 64 bpp displayable surfaces, addrlib only accepts S swizzles. At the same time addrlib prefers D swizzles is allowed, so we can just allow S swizzles as fallback. Fixes: b64b712558 "ac/surface/gfx9: request desired micro tile mode explicitly" --- src/amd/common/ac_surface.c | 7 +++

Re: [Mesa-dev] [PATCH] vulkan: Drop vk_android_native_buffer.xml

On Tue, Apr 10, 2018 at 4:29 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-04-09 22:04:02) > > All the information in vk_android_native_buffer.xml is now in vk.xml. > > The only exception is the extension type attribute which we can work > > around in the generators while we wait for the

Re: [Mesa-dev] [PATCH] fix gcc 8 parenthesis warning

On 24/03/18 02:55, Eric Engestrom wrote: On Friday, 2018-03-23 08:09:46 -0700, Ian Romanick wrote: On 03/23/2018 03:52 AM, Eric Engestrom wrote: On Friday, 2018-03-23 11:01:23 +0100, Marc Dietrich wrote: fixes warnings like this: [184/1137] Compiling C++ object 'src/compiler/glsl/glsl@sta/lowe

Re: [Mesa-dev] [PATCH] fix gcc 8 parenthesis warning

On 11/04/18 12:13, Timothy Arceri wrote: On 24/03/18 02:55, Eric Engestrom wrote: On Friday, 2018-03-23 08:09:46 -0700, Ian Romanick wrote: On 03/23/2018 03:52 AM, Eric Engestrom wrote: On Friday, 2018-03-23 11:01:23 +0100, Marc Dietrich wrote: fixes warnings like this: [184/1137] Compiling

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

For the series (except 9-10): Tested-by: Dieter Nützel with glmark2, UH, UV and KDE Plasma 5 on RX580 Dieter Am 10.04.2018 06:34, schrieb Timothy Arceri: --- src/compiler/glsl/glsl_to_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/compiler/glsl/glsl_to

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all. Is that correct? If so, would it make sense to just repeatedly call do_function_inlining until it stops making progress when we're running with minimal optimizatio

Re: [Mesa-dev] [PATCH 1/3] nir: remove leftover return value when lowering to SSA

On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The return value was needed to make use of the old nir_foreach_block > helper, but not needed anymore with the macro version. > Nice bit of archaeology there. :-) > --- > src/compiler/nir/nir_l

Re: [Mesa-dev] [PATCH 2/3] nir: remove unnecessary check when lowering to SSA

Reviewed-by: Jason Ekstrand On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Only fully-qualified direct derefs, collected in direct_deref_nodes, > are checked for aliasing, so it is already known up front that they > have only array derefs of

Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The matching code doesn't make real use of the return value. The main > function return value is ignored, and while the worker function > propagate its return value, the actual callback never retur

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

On 11/04/18 15:05, Jason Ekstrand wrote: If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all.  Is that correct?  If so, would it make sense to just repeatedly call do_function_inlining until it stops making progr

[Mesa-dev] How about vulkan status in Mesa

Hi, We have an image processing project libxcam (https://github.com/intel/libxcam/wiki) which has been based on OpenCL to support amount of features. Recently, we decide to porting kernels to GLES compute-shader language and based on Vulkan APIs. Certainly the driver is Mesa. There are my quest

Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

On Tue, Apr 10, 2018 at 10:15:45PM -0700, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > > > The matching code doesn't make real use of the return value. The main > > function return value is ignored, and while the wor

[Mesa-dev] [PATCH v2 1/3] nir: remove leftover return value when lowering to SSA

The return value was needed to make use of the old nir_foreach_block helper, but not needed anymore with the macro version. Then go one step further and move the foreach directly into the register variable uses function. v2: Move foreach to register_variable_uses(). (Jason) Reviewed-by: Jason Eks

[Mesa-dev] [PATCH v2 2/3] nir: remove unnecessary check when lowering to SSA

Only fully-qualified direct derefs, collected in direct_deref_nodes, are checked for aliasing, so it is already known up front that they have only array derefs of type direct. Reviewed-by: Jason Ekstrand --- This is really the same as v1, but with Reviewed-by and resent together with the series.

[Mesa-dev] [PATCH v2 3/3] nir: simplify node matching code when lowering to SSA

The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. v2: Style fixes. (Jason) --- src/compiler/nir/nir_lower_vars_to_ssa.c | 67 +++

Re: [Mesa-dev] [PATCH v2 1/3] nir: remove leftover return value when lowering to SSA

On Tue, Apr 10, 2018 at 11:13:38PM -0700, Caio Marcelo de Oliveira Filho wrote: > The return value was needed to make use of the old nir_foreach_block > helper, but not needed anymore with the macro version. Then go one > step further and move the foreach directly into the register variable > uses

Re: [Mesa-dev] How about vulkan status in Mesa

On 04/11/2018 09:01 AM, Yuan, Feng wrote: Hi, We have an image processing project libxcam (https://github.com/intel/libxcam/wiki) which has been based on OpenCL to support amount of features. Recently, we decide to porting kernels to GLES compute-shader language and based on Vulkan APIs. Cer

<    1   2