Hi;
On 02/04/2018 11:57 PM, Mauro Rossi wrote:
Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow")
Fixes the following building errors:
In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer.c:30:
In file included from external/mesa/src/intel/vulkan/anv_private
The loop goes through the list of enabled extensions marking them as
enabled in the list, but this relies on every other extension being
initialized to false by default.
This bug would make us, for example, advertise certain device extension
entry points as available even when the corresponding ex
Reviewed-by: Lionel Landwerlin
Fixes: abc62282b5c "anv: Add a per-device table of enabled extensions"
We want it in 18.0 too I think.
Thanks a lot!
On 05/02/18 09:46, Iago Toral Quiroga wrote:
The loop goes through the list of enabled extensions marking them as
enabled in the list, but this r
Hi Ilia,
On 4 February 2018 at 19:09, Ilia Mirkin wrote:
> One might have split this up into multiple patches, but it's just very
> repetitive and similar code.
You probably want to add this into gbm_to_dri_image_formats[] inside
src/gbm/backends/dri/gbm_dri.c, so Wayland compositors running on
On Mon, Feb 5, 2018 at 6:24 AM, Daniel Stone wrote:
> Hi Ilia,
>
> On 4 February 2018 at 19:09, Ilia Mirkin wrote:
>> One might have split this up into multiple patches, but it's just very
>> repetitive and similar code.
>
> You probably want to add this into gbm_to_dri_image_formats[] inside
> s
https://bugs.freedesktop.org/show_bug.cgi?id=104949
Bug ID: 104949
Summary: swrast: Epiphany WEB browser core dumps under Mesa
17.3.3
Product: Mesa
Version: 17.3
Hardware: Other
OS: All
Status: N
https://bugs.freedesktop.org/show_bug.cgi?id=104949
Daniel Stone changed:
What|Removed |Added
CC||emil.l.veli...@gmail.com
--- Comment #1
Hi Dylan,
Am Freitag, 2. Februar 2018, 20:30:36 CET schrieb Dylan Baker:
> The linkage of all of the gallium media targets is broken in various
> ways in the meson build. This series should correct that by doing more
> what the autotools build does.
>
> You may note in the last 5 patches the addi
On Sun, 2018-02-04 at 10:58 -0800, Matt Turner wrote:
> On Wed, Dec 13, 2017 at 11:21 PM, Iago Toral
> wrote:
> > On Tue, 2017-12-12 at 08:20 +0100, Iago Toral wrote:
> >
> > On Mon, 2017-12-11 at 08:01 -0800, Jason Ekstrand wrote:
> >
> > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral
> > wrote:
Otherwise loop unrolling will fail to see the actual cost of
the unrolling operations when the loop body contains 64-bit integer
instructions, and very specially when the divmod64 lowering applies,
since its lowering is quite expensive.
Without this change, some in-development CTS tests for int64
On Sun, 2018-02-04 at 14:40 -0500, Connor Abbott wrote:
> On Mon, Dec 11, 2017 at 11:01 AM, Jason Ekstrand t> wrote:
> > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral
> > wrote:
> > >
> > > This didn't get any reviews yet. Any takers?
> > >
> > > On Fri, 2017-12-01 at 13:46 +0100, Iago Toral Qui
Similar for the 4 case.
Suggested by Bas.
Signed-off-by: Samuel Pitoiset
---
src/compiler/nir/nir_opt_algebraic.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compiler/nir/nir_opt_algebraic.py
b/src/compiler/nir/nir_opt_algebraic.py
index 6dc19d9b12..b30d1df199 100644
--- a/src/c
On 1 February 2018 at 11:35, Emil Velikov wrote:
> On 25 January 2018 at 15:11, Stephan Gerhold wrote:
>> On Thu, Jan 25, 2018 at 11:22:10AM +, Emil Velikov wrote:
>>> On 24 January 2018 at 14:13, Stephan Gerhold wrote:
>>> > build_id_find_nhdr_for_addr() fails to find the build-id if the fi
https://bugs.freedesktop.org/show_bug.cgi?id=104949
--- Comment #2 from Emil Velikov ---
Created attachment 137171
--> https://bugs.freedesktop.org/attachment.cgi?id=137171&action=edit
Force-disable extension/error out if using API while extension is not set
(In reply to Daniel Stone from comm
Otherwise the code size increases because the original fexp2()
instructions can't be deleted.
Signed-off-by: Samuel Pitoiset
---
src/compiler/nir/nir_opt_algebraic.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_opt_algebraic.py
b/src/compiler/nir/nir
On 5 February 2018 at 07:02, Tapani Pälli wrote:
> v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
> adapt to earlier ctx->screen changes
>
> v3: remove useless checking, add _eglSetFuncName (Emil Velikov)
>
> Signed-off-by: Tapani Pälli
> Reviewed-by: Jordan Justen (v2)
>
On 5 February 2018 at 07:02, Tapani Pälli wrote:
> Next patch will allow disk_cache instance to be created without
> path set for it, modify some test cases that assume disk_cache
> creation to fail with invalid path. Creation should succeed but
> simple put/get test fail.
>
> v2: leave tests as i
On Mon, Feb 05, 2018 at 09:22:15AM +1100, Timothy Arceri wrote:
> This has been unused since 8761a04d0d93.
Reviewed-by: Elie Tournier
> ---
> src/intel/compiler/brw_nir.c | 8
> src/intel/compiler/brw_nir.h | 1 -
> 2 files changed, 9 deletions(-)
>
> diff --git a/src/intel/compiler/br
On 5 February 2018 at 08:09, Tapani Pälli wrote:
> Hi;
>
>
> On 02/04/2018 11:57 PM, Mauro Rossi wrote:
>>
>> Similar to 90dd6e5 ("Android: egl: add dependency on libnativewindow")
>>
>> Fixes the following building errors:
>>
>> In file included from external/mesa/src/intel/vulkan/gen7_cmd_buffer
On 05.02.2018 17:26, Emil Velikov wrote:
On 5 February 2018 at 07:02, Tapani Pälli wrote:
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
adapt to earlier ctx->screen changes
v3: remove useless checking, add _eglSetFuncName (Emil Velikov)
Signed-off-by: Tapani Pälli
Reviewed-by: Brian Paul
On 02/04/2018 04:01 PM, srol...@vmware.com wrote:
From: Roland Scheidegger
This parameter for _mesa_get_min_incations_per_fragment() was once used
by the intel driver, but it's long gone.
---
src/mesa/program/program.c| 11 ---
src/mesa/program
Reviewed-by: Jason Ekstrand
On Mon, Feb 5, 2018 at 3:08 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Reviewed-by: Lionel Landwerlin
> Fixes: abc62282b5c "anv: Add a per-device table of enabled extensions"
>
> We want it in 18.0 too I think.
>
> Thanks a lot!
>
> On 05/02/18 0
On 02/04/2018 02:12 PM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich
Instead of updating all modified gl_vertex_array_object::_VertexArray
entried just update those ones that are modified and enabled.
"entries"
"those ones that" -> "those that"
Also release buffer object from t
Reviewed-by: Jason Ekstrand
On Tue, Jan 23, 2018 at 5:11 AM, Iago Toral Quiroga
wrote:
> The SPIR-V parser splits in/out struct variables and creates
> a separate variable for each first-level member of the struct.
> When the struct variable has an initializer this means that we also
> need to
Tested-By: Karol Herbst
On Mon, Feb 5, 2018 at 6:15 AM, Ilia Mirkin wrote:
> The hardware skips over unallocated slots, so we have to make sure those
> registers are packed together.
>
> Fixes KHR-GL45.enhanced_layouts.fragment_data_location_api
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Tested o
Signed-off-by: James Zhu
---
src/gallium/drivers/radeon/Makefile.sources | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeon/Makefile.sources
b/src/gallium/drivers/radeon/Makefile.sources
index b756d72..f8ee860 100644
--- a/src/gallium/drivers/radeon/Makefile.source
Implement required IBs for UVD HEVC encode.
Signed-off-by: James Zhu
---
src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 965
1 file changed, 965 insertions(+)
create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c
diff --git a/src/gallium/drivers/radeon/
Add UVD hevc encode pipe video codec creation entry
Signed-off-by: James Zhu
---
src/gallium/drivers/radeonsi/si_uvd.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_uvd.c
b/src/gallium/drivers/radeonsi/si_uvd.c
index 64f2f8e..f
Add hevc encode hardware interface for UVD
Signed-off-by: James Zhu
---
src/gallium/drivers/radeon/radeon_uvd_enc.h | 459
1 file changed, 459 insertions(+)
create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.h
diff --git a/src/gallium/drivers/radeon/radeo
Implement UVD hevc encode functions
Signed-off-by: James Zhu
---
1 | 21 ++
src/gallium/drivers/radeon/radeon_uvd_enc.c | 340
2 files changed, 361 insertions(+)
create mode 100644 1
create mode 100644 src/gallium/drivers/
Signed-off-by: James Zhu
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 1927a3a..6f305b7 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
+++
Based on amdgpu hardware query information to check if UVD hevc enc support
Signed-off-by: James Zhu
---
src/amd/common/ac_gpu_info.c | 10 +-
src/amd/common/ac_gpu_info.h | 1 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common
Enable UVD encode for HEVC main profile
Signed-off-by: James Zhu
---
src/gallium/drivers/radeonsi/si_get.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_get.c
b/src/gallium/drivers/radeonsi/si_get.c
index 8002362..64f76b4 100644
--- a/src
https://bugs.freedesktop.org/show_bug.cgi?id=104777
Juan A. Suarez changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Split out some of the code into three new helper functions:
buffer_target_to_bind_flags(), storage_flags_to_buffer_flags(),
buffer_usage() to make the code more managable.
---
src/mesa/state_tracker/st_cb_bufferobjects.c | 191 +++
1 file changed, 104 insertions(+), 87 dele
Use a new helper function, st_access_flags_to_transfer_flags(), to
convert the GL_MAP_x flags to PIPE_TRANSFER_x flags.
We'll be able to use this function in a couple other places.
---
src/mesa/state_tracker/st_cb_bufferobjects.c | 38
src/mesa/state_tracker/st_cb_buf
---
src/mesa/state_tracker/st_cb_fbo.c | 18 +-
src/mesa/state_tracker/st_cb_texture.c | 17 -
2 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_fbo.c
b/src/mesa/state_tracker/st_cb_fbo.c
index 3a5c03c..0800f5b 100644
Since the type is gl_vertex_array. Update comment to explain that
these arrays are only used by the VBO module.
Also rename some local variables in _mesa_update_vao_derived_arrays().
---
src/mesa/main/arrayobj.c | 13 ++---
src/mesa/main/attrib.c| 2 +-
src/mesa/main/mtypes
https://bugs.freedesktop.org/show_bug.cgi?id=104949
--- Comment #3 from Daniel Stone ---
Yeah, good catch! Bug filed: https://bugs.webkit.org/show_bug.cgi?id=182490
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug._
On Mon, Feb 5, 2018 at 12:16 PM, James Zhu wrote:
> Implement UVD hevc encode functions
>
> Signed-off-by: James Zhu
> ---
> 1 | 21 ++
> src/gallium/drivers/radeon/radeon_uvd_enc.c | 340
>
> 2 files changed, 361 insertion
On Mon, Feb 5, 2018 at 5:40 AM, Iago Toral Quiroga wrote:
> Otherwise loop unrolling will fail to see the actual cost of
> the unrolling operations when the loop body contains 64-bit integer
> instructions, and very specially when the divmod64 lowering applies,
> since its lowering is quite expens
Quoting Jon Turney (2018-02-03 13:19:20)
> On 03/02/2018 18:07, Dylan Baker wrote:
> > Quoting Jon Turney (2018-02-03 05:49:40)
> >> - if not ['darwin', 'windows'].contains(host_machine.system())
> >> + if not ['darwin', 'windows', 'cygwin'].contains(host_machine.system())
> >> +# TODO: PPC,
The first 2 patches of this series should be added to branch 18.0 too.
On Fri, Jan 26, 2018 at 11:32:38AM -0800, Rafael Antognolli wrote:
> Fixes: ca19ee33d7d39cb89d948b1c983763065975ce5b
> Signed-off-by: Rafael Antognolli
> Cc: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_pipe_control
On 2018-02-05 01:04 PM, Alex Deucher wrote:
On Mon, Feb 5, 2018 at 12:16 PM, James Zhu wrote:
Implement UVD hevc encode functions
Signed-off-by: James Zhu
---
1 | 21 ++
src/gallium/drivers/radeon/radeon_uvd_enc.c | 340 +
On Sat, Feb 3, 2018 at 2:58 PM, Jordan Justen
wrote:
> On 2018-02-03 14:24:06, Jason Ekstrand wrote:
> > On February 3, 2018 13:59:40 Jordan Justen
> wrote:
> >
> > > Signed-off-by: Jordan Justen
> > > Reviewed-by: Timothy Arceri
> > > ---
> > > docs/relnotes/18.1.0.html | 1
On 05/02/2018 17:34, Dylan Baker wrote:
Quoting Jon Turney (2018-02-03 13:19:20)
On 03/02/2018 18:07, Dylan Baker wrote:
Quoting Jon Turney (2018-02-03 05:49:40)
- if not ['darwin', 'windows'].contains(host_machine.system())
+ if not ['darwin', 'windows', 'cygwin'].contains(host_machine.syst
Implement UVD hevc encode functions
Signed-off-by: James Zhu
---
src/gallium/drivers/radeon/radeon_uvd_enc.c | 340
1 file changed, 340 insertions(+)
create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.c
diff --git a/src/gallium/drivers/radeon/radeon_uvd_e
On 2018-02-05 12:16 PM, James Zhu wrote:
Add UVD hevc encode pipe video codec creation entry
Signed-off-by: James Zhu
---
src/gallium/drivers/radeonsi/si_uvd.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_uvd.c
b/src/gal
RadeonSI and RADV lower fdiv.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index b211832b47..e25bae600f 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++
Clang defines __GNUC__ macro, so one doesn't need to check __clang__
macro in this particular case.
---
src/util/macros.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/macros.h b/src/util/macros.h
index 432d513930..d36ca095d5 100644
--- a/src/util/macros.h
+++ b/src/
On 02/05/2018 01:44 PM, Vlad Golovkin wrote:
Clang defines __GNUC__ macro, so one doesn't need to check __clang__
macro in this particular case.
Perhaps mention that in a comment below so there's no confusion.
-Brian
---
src/util/macros.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 2018-02-05 12:16 PM, James Zhu wrote:
Based on amdgpu hardware query information to check if UVD hevc enc support
Signed-off-by: James Zhu
---
src/amd/common/ac_gpu_info.c | 10 +-
src/amd/common/ac_gpu_info.h | 1 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git
Hey,
I haven't seen any feedback, but am looking for an ACK/LGTM.
If anyone has a cycle to spare, it would be helpful :)
Thanks,
Rob.
On 01/29/2018 06:37 PM, Robert Foss wrote:
This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm,
since at least 4 implementations exist, and shar
On 2017-10-24 11:47, Emil Velikov wrote:
Hi Jerome,
On 23 October 2017 at 16:58, Jerome Duval
wrote:
* configure.ac:
-pthread is not available on Haiku.
Haiku doesn't require --enable-dri
build hgl on Haiku
* egl/Makefile.am: define backendfiles for Haiku
* src/gallium/Makefile.am: buil
On 2018-02-05 12:16 PM, James Zhu wrote:
Signed-off-by: James Zhu
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 1927a3a..6f305b7 100644
---
Add UVD hevc encode pipe video codec creation entry
Signed-off-by: James Zhu
---
src/gallium/drivers/radeonsi/si_uvd.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_uvd.c
b/src/gallium/drivers/radeonsi/si_uvd.c
index 64f2f8e
Reviewed-by: Timothy Arceri
On 06/02/18 07:37, Samuel Pitoiset wrote:
RadeonSI and RADV lower fdiv.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
i
Quoting kallisti5 (2018-02-05 12:58:30)
> On 2017-10-24 11:47, Emil Velikov wrote:
> > Hi Jerome,
> >
> > On 23 October 2017 at 16:58, Jerome Duval
> > wrote:
> >> * configure.ac:
> >> -pthread is not available on Haiku.
> >> Haiku doesn't require --enable-dri
> >> build hgl on Haiku
> >>
In this file there are similar cases with macros PUBLIC, USED and
ATTRIBUTE_NOINLINE, before defining which as __attribute__(...), code
only checks for __GNUC__.
Should I add comments there as well?
2018-02-05 22:51 GMT+02:00 Brian Paul :
> On 02/05/2018 01:44 PM, Vlad Golovkin wrote:
>>
>> Clang
In file included from ../src/gallium/targets/dri/target.c:1:
In file included from ../src/gallium/auxiliary/target-helpers/drm_helper.h:8:
../src/util/xmlpool.h:103:10: fatal error: 'xmlpool/options.h' file not found
See also 26bde1e3.
Signed-off-by: Jon Turney
---
src/gallium/targets/dri/meson
Reviewed-by: Bas Nieuwenhuizen
On Mon, Feb 5, 2018 at 9:37 PM, Samuel Pitoiset
wrote:
> RadeonSI and RADV lower fdiv.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/am
On 2018-02-05 15:39, Dylan Baker wrote:
Quoting kallisti5 (2018-02-05 12:58:30)
On 2017-10-24 11:47, Emil Velikov wrote:
> Hi Jerome,
>
> On 23 October 2017 at 16:58, Jerome Duval
> wrote:
>> * configure.ac:
>> -pthread is not available on Haiku.
>> Haiku doesn't require --enable-dri
>> b
From: Mathias Fröhlich
Instead of updating all modified gl_vertex_array_object::_VertexArray
entries just update those that are modified and enabled.
Also release buffer object from the _VertexArray that belong
to disabled attributes.
v2: Also set Ptr and Size to zero.
Signed-off-by: Mathias Fr
From: Mathias Fröhlich
Hi Brian,
Actually after incorporating your review requests to set
gl_vertex_array::Size and gl_vertex_array::Ptr to zero, radeonsi
started to assert in Bitmap/CopyPixels/DrawPixels.
So, here the updated series including the requested changes.
And additoinally for review
From: Mathias Fröhlich
When changing the attribute binding in the VAO we also need to
account for getting rid of non vbo bits from VertexAttribBufferMask.
Signed-off-by: Mathias Fröhlich
Reviewed-by: Brian Paul
---
src/mesa/main/varray.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/s
From: Mathias Fröhlich
Set the _DrawArray pointer to NULL when calling into the Drivers
Bitmap/CopyPixels/DrawPixels hooks. This fixes an assert that gets
uncovered with the following patch gets applied.
Signed-off-by: Mathias Fröhlich
---
src/mesa/main/drawpix.c | 10 ++
1 file change
Hi Brian,
On Monday, 5 February 2018 18:23:17 CET Brian Paul wrote:
> Since the type is gl_vertex_array. Update comment to explain that
> these arrays are only used by the VBO module.
>
> Also rename some local variables in _mesa_update_vao_derived_arrays().
Makes sense to me and the change loo
This little series just shuffles code around to make things a bit more
clear. (At least I think it does!) The basic idea is to split set_subpass
into begin_subpass and end_subpass and then move all of resolve and clear
code into those two helpers. This means that we no longer have 3 or 4
differe
This unifies things a bit because we now handle depth and stencil at the
same time. It also ensures that clears happen for input attachments.
---
src/intel/vulkan/genX_cmd_buffer.c | 77 --
1 file changed, 32 insertions(+), 45 deletions(-)
diff --git a/src/int
---
src/intel/vulkan/anv_blorp.c | 243 -
src/intel/vulkan/anv_private.h | 17 ++-
src/intel/vulkan/genX_cmd_buffer.c | 68 ++-
3 files changed, 188 insertions(+), 140 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan
These are the same as pending clear aspects only for the "load"
operation.
---
src/intel/vulkan/anv_private.h | 1 +
src/intel/vulkan/genX_cmd_buffer.c | 22 --
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulka
This requires us to ditch the VkAttachmentReference struct in favor of
an anv-specific struct. However, we can now easily identify from just
the subpass attachment what kind of an attachment it is. This will make
iteration over anv_subpass::attachments a little easier in some case.
---
src/intel
This is quite a bit cleaner because we now sync the clear values at the
same time as we do the fast clear. For loading the clear values into
the surface state, we now do it once when we handle the LOAD_OP_LOAD
instead of every subpass.
---
src/intel/vulkan/genX_cmd_buffer.c | 148
This is a bit less awkward than passing in the subpass because it means
we don't have to extract the subpass id from the subpass.
---
src/intel/vulkan/genX_cmd_buffer.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/
---
src/intel/vulkan/genX_cmd_buffer.c | 50 ++
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 4eee85a..2d17c28 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/
This is similar to blorp_gen8_hiz_clear_attachments except that it takes
actual images instead of trusting in the already set depth state.
---
src/intel/blorp/blorp.h | 11 ++
src/intel/blorp/blorp_clear.c | 50 +++
2 files changed, 61 insertio
This seems slightly more correct because it means that the flushes
happen before any clears or resolves implied by the subpass transition.
---
src/intel/vulkan/genX_cmd_buffer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/in
This doesn't really change much now but it will give us more/better
control over clears in the future. The one interesting functional
change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and
friends for each clear. However, this only happens at begin_subpass
time so it shouldn't be su
This moves the decision out of begin_subpass and into BeginRenderPass
like the decision for color clears. We use a similar name for the
function for depth/stencil as for color even though no aux usage is
really getting computed.
---
src/intel/vulkan/genX_cmd_buffer.c | 84 +++-
Having begin/end_subpass is a bit nicer than the begin/next/end hooks
that Vulkan gives us.
---
src/intel/vulkan/genX_cmd_buffer.c | 55 +-
1 file changed, 31 insertions(+), 24 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/gen
Previously, we would always apply the layout transition at the beginning
of the subpass and then do the clear whether fast or slow. This meant
that there were some cases, specifically when the initial layout is
VK_IMAGE_LAYOUT_UNDEFINED, where we would end up doing a fast-clear or
ambiguate follow
---
src/intel/vulkan/genX_cmd_buffer.c | 190 +
1 file changed, 68 insertions(+), 122 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 2d17c28..2732ef3 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b
This little series adds support for enabling CCS_E for images which may
have VK_IMAGE_USAGE_STORAGE_BIT set. Previously, we just bailed on these
images and disabled CCS. However, so long as we do a full resolve when
entering VK_IMAGE_LAYOUT_GENERAL, we can support CCS_E for all the other
layouts
Checking the sample count is almost as good as aux usage in this case.
---
src/intel/vulkan/genX_cmd_buffer.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 056528f..afe577c 100644
--- a/src/int
If we don't have HiZ, then anv_layout_to_aux_usage will return NONE for
both layouts. If the two layouts are the same, they will get the aux
usage. In either case, the code below will give us ISL_AUX_OP_NONE and
we'll return without doing anything.
---
src/intel/vulkan/genX_cmd_buffer.c | 12 ---
---
src/intel/vulkan/genX_cmd_buffer.c | 53 +-
1 file changed, 35 insertions(+), 18 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index a7950cf..056528f 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/
Instead of having aux usage and ANV_AUX_USAGE_DEFAULT to mean "give me
something reasonable" we now use anv_layout_to_aux_usage whenever a
layout is available. If a layout is available, we ignore the aux_usage
parameter. For the cases where we have an explicit aux usage such as
clears and aux ops
We have to do resolves whenever we go into the general layout for these
images. However, it also means that images which declare the storage
usage but don't actually need it most of the time will still get
compression.
---
src/intel/vulkan/anv_image.c | 18 +++---
1 file changed, 15 i
This fixes a regression for now, in the future we should gather
the used components properly.
Fixes: be973ed21f6e "radeonsi: load the right number of components for VS
inputs and TBOs"
Cc: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader_nir.c | 7 +--
1 file changed, 5 insertions(+)
On 05/02/18 15:04, Dieter Nützel wrote:
Am 02.02.2018 10:24, schrieb Timothy Arceri:
On 02/02/18 19:26, Dieter Nützel wrote:
Hello Tim,
_this_ version brake UH, UV, mpv, blender 2.79 (some test files not
all).
Must be something with the cache file(s).
The cache currently needs to be delete
CC r600_shader.lo
r600_shader.c: In function ‘egcm_int_to_double’:
r600_shader.c:4543:12: error: ‘ctx’ is a pointer; did you mean to use ‘->’?
if (ctx.bc->chip_class == CAYMAN)
^
->
Fixes: 35b430157776 ("r600/fp64: fix integer->double conversion")
Signed-off-by
Do you have any data from shader-db for this change (and the other patch)?
On 02/05/2018 06:08 AM, Samuel Pitoiset wrote:
> Similar for the 4 case.
>
> Suggested by Bas.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/compiler/nir/nir_opt_algebraic.py | 2 ++
> 1 file changed, 2 insertions(+)
>
I just wrote the same patch:
Reviewed-by: Dylan Baker
Quoting Vinson Lee (2018-02-05 15:24:45)
> CC r600_shader.lo
> r600_shader.c: In function ‘egcm_int_to_double’:
> r600_shader.c:4543:12: error: ‘ctx’ is a pointer; did you mean to use ‘->’?
> if (ctx.bc->chip_class == CAYMAN)
>
This is turning our CI red, so I'm going to go ahead and push this.
Quoting Vinson Lee (2018-02-05 15:24:45)
> CC r600_shader.lo
> r600_shader.c: In function ‘egcm_int_to_double’:
> r600_shader.c:4543:12: error: ‘ctx’ is a pointer; did you mean to use ‘->’?
> if (ctx.bc->chip_class ==
On 2018-02-05 16:14, kallisti5 wrote:
On 2018-02-05 15:39, Dylan Baker wrote:
Quoting kallisti5 (2018-02-05 12:58:30)
On 2017-10-24 11:47, Emil Velikov wrote:
> Hi Jerome,
>
> On 23 October 2017 at 16:58, Jerome Duval
> wrote:
>> * configure.ac:
>> -pthread is not available on Haiku.
>> Ha
Quoting kallisti5 (2018-02-05 14:14:42)
> On 2018-02-05 15:39, Dylan Baker wrote:
> > Quoting kallisti5 (2018-02-05 12:58:30)
> >> On 2017-10-24 11:47, Emil Velikov wrote:
> >> > Hi Jerome,
> >> >
> >> > On 23 October 2017 at 16:58, Jerome Duval
> >> > wrote:
> >> >> * configure.ac:
> >> >> -pth
I'm tempted to say the other places which only check for __GNUC__ should
also check for __clang__, just to be move obvious (or does everyone know
that __clang__ implies __GNUC_?). Maybe others have an opinion.
Anyway, the location in question below seems to be first place this
appears in th
On 02/05/2018 03:19 PM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich
Hi Brian,
Actually after incorporating your review requests to set
gl_vertex_array::Size and gl_vertex_array::Ptr to zero, radeonsi
started to assert in Bitmap/CopyPixels/DrawPixels.
Which assertion, exactly? And
I don't have a test case hitting this assert. But, it's nice to have
an assert checking the limit.
Signed-off-by: Anuj Phogat
---
src/intel/isl/isl_surface_state.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/isl/isl_surface_state.c
b/src/intel/isl/isl_surface_state.c
index b
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index aa4d64d08e..67fb328dbc 100644
--- a/src/mesa/driv
1 - 100 of 129 matches
Mail list logo
