Re: [Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

2018-01-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 16, 2018 at 7:45 AM, Timothy Arceri wrote: > Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads" > --- > src/amd/common/ac_nir_to_llvm.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_nir_to_llvm

Re: [Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_b2i for doubles

2018-01-18 Thread Marek Olšák
On Fri, Jan 12, 2018 at 4:42 PM, Bas Nieuwenhuizen wrote: > Maybe just zero-extend the 32-bit value? (or truncate for 16-bit?) I > don't know what generates better machinecode. It depends on what result type you want. ZExt and Trunc are essentially typecasts that change the bit size. LLVM passes

[Mesa-dev] [PATCH] i965/screen: Allow drirc to set 'allow_rgb10_configs' again.

2018-01-18 Thread Mario Kleiner
Since setup of ALLOW_RGB10_CONFIGS was moved to i965's own brw_config_options.xml, this was hard-coded to false and could not be overriden by drirc. Add some parsing into i965's private screen->optionCache to enable drirc again. Fixes: b391fb26df9f1b ("dri_util: remove ALLOW_RGB10_CONFIGS option (

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

2018-01-18 Thread Andres Rodriguez
On 2018-01-17 08:01 AM, Nicolai Hähnle wrote: On 04.01.2018 18:37, Andres Rodriguez wrote: On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like everything would be fine if we used the "fence" name for semaphores. The rename was requested by nha. We could k

[Mesa-dev] [Bug 104677] radv_generate_graphics_pipeline_key reads input rate from incorrect binding

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104677 --- Comment #1 from Philip Rebohle --- Created attachment 136814 --> https://bugs.freedesktop.org/attachment.cgi?id=136814&action=edit Proposed fix -- You are receiving this mail because: You are the QA Contact for the bug. You are the assig

[Mesa-dev] [Bug 104677] radv_generate_graphics_pipeline_key reads input rate from incorrect binding

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104677 Bug ID: 104677 Summary: radv_generate_graphics_pipeline_key reads input rate from incorrect binding Product: Mesa Version: 17.3 Hardware: Other OS: All

Re: [Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbols exposed

2018-01-18 Thread Dylan Baker
I dug into what autotools is doing. It's using -Wl,--whole-archive to link everything, in this target, not just the state tracker. I think I'm okay with this patch given that, so I'm going to apply the same change to the other media state trackers and send it out as a series. Quoting Dylan Baker (

Re: [Mesa-dev] [PATCH] meson: generate translations for driconf

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > Currently meson implements the same logic as SCons for translations, > namely it doesn't do them. This patch changes meson to use logic more > like autotools, and generate translations. To do this we have to go > behind meson's back a bit, and wrap the whole thing up in a si

[Mesa-dev] [PATCH 2/6] meson: fix vdpau target linkage

2018-01-18 Thread Dylan Baker
The VDPAU state tracker needs to be linked with whole-archive (autotools does this), and a few dependeies can be cleaned up Signed-off-by: Dylan Baker --- src/gallium/targets/vdpau/meson.build | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/targe

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock with X11

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #9 from Chad Versace --- No, that's not guaranteed to work. If the app destroys the X11 window before calling vkDestroySwapchainKHR, then the X connection may recycle the window's XID between the two calls, causing havoc. The manpage

[Mesa-dev] [PATCH 5/6] meson: fix xa target linkage

2018-01-18 Thread Dylan Baker
This needs to link the state-tracker with whole archive, and needs a few extra window-system deps. Signed-off-by: Dylan Baker --- src/gallium/targets/xa/meson.build | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/targets/xa/meson.build b/src/gal

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

2018-01-18 Thread Rob Herring
On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: > Let's expose this only when we have formats. There are some > known issues when this is exposed without formats (on Android). This is fixed now at least for master. Rob ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH v4] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

2018-01-18 Thread Jason Ekstrand
On Tue, Jan 16, 2018 at 11:35 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/intel/vulkan/anv_image.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulka

Re: [Mesa-dev] [PATCH v3] anv/query: implement multiview interactions

2018-01-18 Thread Jason Ekstrand
On Wed, Jan 17, 2018 at 4:59 AM, Iago Toral Quiroga wrote: > From the Vulkan spec with KHX extensions: > > "If queries are used while executing a render pass instance that has >multiview enabled, the query uses N consecutive query indices >in the query pool (starting at query) where N i

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

2018-01-18 Thread Marek Olšák
On Wed, Jan 17, 2018 at 8:22 PM, Andres Rodriguez wrote: > > > On 2018-01-17 08:01 AM, Nicolai Hähnle wrote: >> >> On 04.01.2018 18:37, Andres Rodriguez wrote: >>> >>> >>> >>> >>> On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like everything would be fine

Re: [Mesa-dev] [PATCH] nir/spirv: add gl_spirv_validation method

2018-01-18 Thread Jason Ekstrand
On Wed, Jan 17, 2018 at 3:31 AM, Alejandro Piñeiro wrote: > ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new > method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 > "Shader Specialization", error table: > >INVALID_VALUE is generated if does not name a valid >en

Re: [Mesa-dev] [PATCH] meson: Don't confuse the install and search paths for dri drivers

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will default to the value of > `dri-driver

[Mesa-dev] [Bug 104182] Seti@Home OpenCL program starts then returns: "CL file build failure"

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104182 PMouse changed: What|Removed |Added CC||porcelain_mo...@vfemail.net -- You are receiv

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

2018-01-18 Thread Dylan Baker
The meson build for omx-bellagio has landed along with the other media state trackers that are in tree. Currently there is a known bug with at least vdpau and va-api (I suspect that the omx, va, and xvmc are affected as well) which causes required symbols to not be exported, I'm still trying to res

Re: [Mesa-dev] [GSOC] DriConf Replacement

2018-01-18 Thread Jean Hertel
Hello Michel, Hello Nicolai, I have spent some more time reading the Mesa source code and trying to figure out how the prime configuration works. If i understood correctly the driconf XML format should have an option inside each application indicating if PRIME should be used. This option is name

[Mesa-dev] [PATCH 4/6] meson: Fix omx-bellagio target linkage

2018-01-18 Thread Dylan Baker
There were a couple of problems, first we need to link the whole state tracker in (like autotools does), then we need to link with bellagio (like autotools does), then we need a few extra dependencies that were being lost because the state tracker wasn't being properly linked. Signed-off-by: Dylan

[Mesa-dev] [PATCH] intel: Add Geminilake brand strings

2018-01-18 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- include/pci_ids/i965_pci_ids.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index 9616f7de21..e947b026bd 100644 --- a/include/pci_ids/i965_pci_ids.h +++ b/include/pci_ids/i965

[Mesa-dev] [PATCH 1/4] vbo: whitespace, formatting fixes in vbo_split.[ch]

2018-01-18 Thread Brian Paul
--- src/mesa/vbo/vbo_split.c | 88 +--- src/mesa/vbo/vbo_split.h | 37 ++-- 2 files changed, 65 insertions(+), 60 deletions(-) diff --git a/src/mesa/vbo/vbo_split.c b/src/mesa/vbo/vbo_split.c index 611d4ca..df192e4 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

2018-01-18 Thread Dylan Baker
The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. Dylan Baker (6): meson: link dri3 xcb libs into vlwinsys instead of into each target meson: fix vdpau target linkage meso

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-18 Thread Tapani Pälli
On 01/18/2018 12:03 AM, Rob Herring wrote: On Mon, Jan 15, 2018 at 6:31 AM, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file c

[Mesa-dev] [PATCH] i965: Bind null render targets for shadow sampling + color.

2018-01-18 Thread Kenneth Graunke
Portal 2 appears to bind RGBA_UNORM textures to a sampler2DShadow, and calls shadow2D() on it. This causes undefined behavior in OpenGL. Unfortunately, our sampler appears to hang in this scenario, which is not acceptable. Just give them a null surface instead, which returns all zeroes. Fix

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

2018-01-18 Thread Andres Rodriguez
On 2018-01-17 06:35 PM, Marek Olšák wrote: On Wed, Jan 17, 2018 at 8:22 PM, Andres Rodriguez wrote: On 2018-01-17 08:01 AM, Nicolai Hähnle wrote: On 04.01.2018 18:37, Andres Rodriguez wrote: On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like everyth

[Mesa-dev] [PATCH 1/2] radv: Remove DCC check on CS resolve dst image.

2018-01-18 Thread Bas Nieuwenhuizen
Gives a warning when the assert is disabled, and not even necessarily true. --- src/amd/vulkan/radv_meta_resolve_cs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c b/src/amd/vulkan/radv_meta_resolve_cs.c index 7c569aa920..5b3bc89832 100644 --- a/src/a

[Mesa-dev] [PATCH 2/2] radv: Replace an assert with unreachable.

2018-01-18 Thread Bas Nieuwenhuizen
Otherwise we get uninitialized variable warnings for es_vgpr_comp_cnt. --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 9819a522d7..3bcaac168a 100644 --- a/src/amd/vulkan/radv_shad

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-18 Thread Rob Herring
On Mon, Jan 15, 2018 at 6:31 AM, Tapani Pälli wrote: > This can/should be modified depending on needs. AFAIK by default, > this is the only path that can be read/written to by anyone. > > Signed-off-by: Tapani Pälli > --- > Android.common.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Fix vector extraction if source vector has >4 elements.

2018-01-18 Thread Timothy Arceri
On 18/01/18 00:34, Bas Nieuwenhuizen wrote: Fixes: 91074bb11bda "radv/ac: Implement Float64 SSBO stores." --- src/amd/common/ac_nir_to_llvm.c | 46 +++-- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/am

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

2018-01-18 Thread Mark Janes
Hi Juan, I filed a bug about a test that was regressed by this patch: https://bugs.freedesktop.org/show_bug.cgi?id=104668 -Mark "Juan A. Suarez Romero" writes: > According with OpenGL GLSL 4.20 spec, section 4.3.9, page 57: > >"It is a link-time error if any particular shader interface >

[Mesa-dev] [PATCH 6/6] meson: fix xvmc target linkage

2018-01-18 Thread Dylan Baker
This needs to link the state tracker with whole-archive, it needs to link with libxvmc, and it needs a few extra window system dependencies. Signed-off-by: Dylan Baker --- meson.build | 5 - src/gallium/targets/xvmc/meson.build | 18 -- 2 files chang

Re: [Mesa-dev] [PATCH] intel: Future-proof ring names for aubinator_error_decode

2018-01-18 Thread Kenneth Graunke
On Wednesday, January 17, 2018 7:47:05 AM PST Chris Wilson wrote: > The kernel is moving to a $class$instance naming scheme in preparation > for accommodating more rings in the future in a consistent manner. It is > already using the naming scheme internally, and now we are looking at > updating so

[Mesa-dev] [PATCH 3/6] meson: fix va-api target linkage

2018-01-18 Thread Dylan Baker
The state tracker needs to be linked with whole-archive (like autotools), and we need a few window system deps. Signed-off-by: Dylan Baker --- src/gallium/targets/va/meson.build | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/targets/va/meson.build

Re: [Mesa-dev] [PATCH] meson: Don't confuse the install and search paths for dri drivers

2018-01-18 Thread Dylan Baker
Quoting Eric Anholt (2018-01-17 12:32:32) > Dylan Baker writes: > > > Currently there is not a separate option for setting the search path of > > DRI drivers in meson, like there is in scons and autotools. This is an > > oversight and needs to be fixed. This adds an extra option > > `dri-search-p

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Wu, Zhongmin
Below is the dEQP result for all the dEQP-EGL.*swap_interval tests 11-11 18:22:44.164 12737 12737 I dEQP: Device has at least 832.00 MiB total system memory per Android CDD 11-11 18:22:44.164 12737 12737 I dEQP: Writing test log into /sdcard/dEQP-Log.qpa 11-11 18:22:44.165 12737 12737 I

Re: [Mesa-dev] [ANNOUNCE] mesa 17.2.8

2018-01-18 Thread Juan A. Suarez Romero
On Wed, 2018-01-17 at 18:03 +, Emil Velikov wrote: > On 22 December 2017 at 23:05, Andres Gomez wrote: > > Mesa 17.2.8 is now available. > > > > In this release we have: > > > > The SPIR-V compiler has seen corrected a possible SEGFAULT. > > > > The Intel i965 driver includes a correction f

[Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Zhongmin Wu
Implement the eglSwapinterval for Android platform to enable the async mode for some GFX benchmarks such as Daimler C217, CityBench. Signed-off-by: Zhongmin Wu --- src/egl/drivers/dri2/platform_android.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/egl/drivers/d

Re: [Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

2018-01-18 Thread Bas Nieuwenhuizen
On Tue, Jan 16, 2018 at 7:45 AM, Timothy Arceri wrote: > Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads" > --- > src/amd/common/ac_nir_to_llvm.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-18 Thread Nanley Chery
On Tue, Jan 16, 2018 at 10:21:44PM -0800, Jason Ekstrand wrote: > On Tue, Jan 16, 2018 at 4:30 PM, Nanley Chery wrote: > > > On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > > > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > > > Sorry for all the list spam, but

[Mesa-dev] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

2018-01-18 Thread Jason Ekstrand
Without this, we may end up dereferencing blend before we check for binding->index != UINT32_MAX. However, Vulkan allows the blend state to be NULL so long as you don't have any color attachments. This fixes a segfault when running The Talos Principal. Fixes: 12f4e00b69e724a23504b7bd3958fb75dc46

[Mesa-dev] [AppVeyor] mesa master #6629 failed

2018-01-18 Thread AppVeyor
Build mesa 6629 failed Commit d67ef48580 by Mario Kleiner on 1/18/2018 6:16 AM: i965/screen: Allow drirc to set 'allow_rgb10_configs' again.\n\nSince setup of ALLOW_RGB10_CONFIGS was moved to i965's own\nbrw_config_options.xml, this was hard-coded to false and\

Re: [Mesa-dev] [PATCH 04/23] radv: Add a PM4 sequence data structure + utils.

2018-01-18 Thread Dave Airlie
On 17 January 2018 at 21:06, Bas Nieuwenhuizen wrote: > On Wed, Jan 17, 2018 at 11:38 AM, Samuel Pitoiset > wrote: >> Can't this be moved into a new file? Or event better in AMD common code? > > Would you think this is usable by radeonsi? They already have their > own PM4 structure integrating bo

Re: [Mesa-dev] [PATCH mesa] docs: ask for backport nominations to cc: the author

2018-01-18 Thread Kenneth Graunke
On Friday, January 12, 2018 8:08:46 AM PST Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/submittingpatches.html | 4 > 1 file changed, 4 insertions(+) > > diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html > index 0581391b2958253b8f4d..ba09aa4ad73293

Re: [Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

2018-01-18 Thread Bas Nieuwenhuizen
On Thu, Jan 18, 2018 at 1:46 AM, Timothy Arceri wrote: > > > On 18/01/18 11:35, Bas Nieuwenhuizen wrote: >> >> On Tue, Jan 16, 2018 at 7:45 AM, Timothy Arceri >> wrote: >>> >>> Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads" >>> --- >>> src/amd/common/ac_nir_to_llvm.c | 5 - >>>

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2018-01-18 Thread Nanley Chery
On Sat, Jan 13, 2018 at 10:12:53AM -0800, Jason Ekstrand wrote: > On Sat, Jan 13, 2018 at 9:55 AM, Jason Ekstrand > wrote: > > > On Wed, Dec 13, 2017 at 4:46 PM, Nanley Chery > > wrote: > > > >> On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > >> > Currently, this helper does no

[Mesa-dev] [PATCH 1/2] radv: precalculate some vertex info in the binding. (v2)

2018-01-18 Thread Dave Airlie
From: Dave Airlie This just moves some calcs from the emission to the binding. Probably won't affect much, just reduced some time spent in binding v2: Precalculate size as well, to avoid accessing ->buffer at all in the hw writes. (Bas) --- src/amd/vulkan/radv_cmd_buffer.c | 19 ++-

[Mesa-dev] [PATCH 1/6] meson: link dri3 xcb libs into vlwinsys instead of into each target

2018-01-18 Thread Dylan Baker
This makes the dependencies easier to manage, since each media target doesn't need to worry about linking to half a dozen libraries. Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/me

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

2018-01-18 Thread Gurkirpal Singh
On Wed, Jan 17, 2018 at 10:39 PM, Dylan Baker wrote: > The meson build for omx-bellagio has landed along with the other media > state > trackers that are in tree. Currently there is a known bug with at least > vdpau > and va-api (I suspect that the omx, va, and xvmc are affected as well) > which

[Mesa-dev] [PATCH v2 2/2] ac/nir: Fix vector extraction if source vector has >4 elements.

2018-01-18 Thread Bas Nieuwenhuizen
v2: Add forgotten argument and start offset. Fixes: 91074bb11bda "radv/ac: Implement Float64 SSBO stores." --- src/amd/common/ac_nir_to_llvm.c | 48 +++-- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/

Re: [Mesa-dev] [PATCH 09/29] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-18 Thread Nanley Chery
On Fri, Jan 12, 2018 at 04:26:44PM -0800, Jason Ekstrand wrote: > On Wed, Dec 13, 2017 at 11:00 AM, Nanley Chery > wrote: > > > On Mon, Nov 27, 2017 at 07:05:59PM -0800, Jason Ekstrand wrote: > > > This moves it to being based on layout_to_aux_usage instead of being > > > hard-coded based on bits

Re: [Mesa-dev] [PATCH v2 1/4] anv/query: implement multiview interactions

2018-01-18 Thread Jason Ekstrand
On Wed, Jan 17, 2018 at 1:27 AM, Iago Toral wrote: > On Tue, 2018-01-16 at 08:07 -0800, Jason Ekstrand wrote: > > On Mon, Jan 8, 2018 at 4:57 AM, Iago Toral Quiroga > wrote: > > From the Vulkan spec with KHX extensions: > > "If queries are used while executing a render pass instance that has >

[Mesa-dev] [PATCH 3/4] vbo: replace assert(0) with unreachable()

2018-01-18 Thread Brian Paul
--- src/mesa/vbo/vbo_context.h| 8 src/mesa/vbo/vbo_exec_array.c | 2 +- src/mesa/vbo/vbo_exec_draw.c | 4 ++-- src/mesa/vbo/vbo_save_api.c | 5 ++--- src/mesa/vbo/vbo_save_draw.c | 2 +- 5 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/mesa/vbo/vbo_context.h b

Re: [Mesa-dev] [PATCH 08/29] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

2018-01-18 Thread Nanley Chery
On Fri, Jan 12, 2018 at 04:10:14PM -0800, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 3:57 PM, Nanley Chery wrote: > > > On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/genX_cmd_buffer.c | 17 - > > > 1 file changed, 8 insertio

[Mesa-dev] [PATCH] ac: fix visit_ssa_undef() for doubles

2018-01-18 Thread Timothy Arceri
Fixes: f4e499ec7914 "radv: add initial non-conformant radv vulkan driver" --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5d582cb0ed..43486fdd6c 100644 --- a/src/amd

[Mesa-dev] [PATCH] ac/nir: account for view index in the user sgpr allocation.

2018-01-18 Thread Dave Airlie
From: Dave Airlie The view index user sgpr wasn't being accounted for properly, this refactors out the code to decide if it's required and then uses that info to account for it. Fixes: 180c1b924e (ac/nir: Add shader support for multiviews.) Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_

[Mesa-dev] [Bug 104681] Seti@Home, Eistein@Home, and Milkyway@Home BOINC GPU apps crash since Fedora Summer 2015

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104681 Bug ID: 104681 Summary: Seti@Home, Eistein@Home, and Milkyway@Home BOINC GPU apps crash since Fedora Summer 2015 Product: Mesa Version: 17.2 Hardware: Other

Re: [Mesa-dev] [PATCH] r600: add support for ARB_shader_clock.

2018-01-18 Thread Gert Wollny
Am Donnerstag, den 18.01.2018, 13:41 +1000 schrieb Dave Airlie: > > Oh I had a local piglit patch to fix the test, I'll just push it. Thanks, now it also passes for me on BARTS. Gert ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://l

Re: [Mesa-dev] DRI Configurator replacement announcement

2018-01-18 Thread Jean Hertel
De: Gert Wollny Enviado: terça-feira, 16 de janeiro de 2018 05:33 Para: Jean Hertel; mesa-dev@lists.freedesktop.org Assunto: Re: [Mesa-dev] DRI Configurator replacement announcement   >> - Applications with empty options (all options are the same as >> system-wide config or driver default) will b

[Mesa-dev] [PATCH v2 1/2] ac/nir: Use correct 32-bit component writemask for 64-bit SSBO stores.

2018-01-18 Thread Bas Nieuwenhuizen
Fixes: 91074bb11bda "radv/ac: Implement Float64 SSBO stores." --- src/amd/common/ac_nir_to_llvm.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 337dfdb5ec..12f7772a5c 100644 --- a/

[Mesa-dev] [AppVeyor] mesa master #6625 completed

2018-01-18 Thread AppVeyor
Build mesa 6625 completed Commit 44a27cdcec by Dave Airlie on 1/10/2018 6:08 AM: r600/sb: add lds related peepholes.\n\nif no destination:\na) convert _RET instructions to non _RET variants if no dst\nb) set src0 to undefined if it's a READ, this should get DCE

Re: [Mesa-dev] [PATCH] meson: generate translations for driconf

2018-01-18 Thread Dylan Baker
ping Quoting Dylan Baker (2018-01-09 11:36:36) > Currently meson implements the same logic as SCons for translations, > namely it doesn't do them. This patch changes meson to use logic more > like autotools, and generate translations. To do this we have to go > behind meson's back a bit, and wrap

[Mesa-dev] [PATCH v2 3/4] mesa/program/prog_execute.c: Silence -Wunused-param

2018-01-18 Thread Gert Wollny
v2: Remove the unused ctx parameter from fetch_vector4_deriv v1: Annotate unused parameter v1 was Reviewed-by: Emil Velikov Signed-off-by: Gert Wollny --- src/mesa/program/prog_execute.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/prog_execute.

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Roland Scheidegger
Looks alright to me. Reviewed-by: Roland Scheidegger Am 17.01.2018 um 23:57 schrieb Brian Paul: > The optimization in change 8e4efdc895ea ("vbo: optimize some display > list drawing") missed the loopback case. This is used when the > glBegin/End primitive doesn't have a uniform set of vertex at

[Mesa-dev] [PATCH] ac: image size builtin for GLSL_SAMPLER_DIM_3D

2018-01-18 Thread Timothy Arceri
This is what radeonsi does. Fixes remaing piglit subtest in: ./bin/arb_shader_image_size-builtin --quick -auto -fbo --- src/amd/common/ac_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d5b

[Mesa-dev] [PATCH v2] ac: fix visit_ssa_undef() for doubles

2018-01-18 Thread Timothy Arceri
V2: use LLVMIntTypeInContext() Fixes: f4e499ec7914 "radv: add initial non-conformant radv vulkan driver" --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5d582cb0ed.

Re: [Mesa-dev] [PATCH] r600: fix relocs for PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE query

2018-01-18 Thread Roland Scheidegger
Am 17.01.2018 um 13:54 schrieb Nicolai Hähnle: > On 11.01.2018 23:54, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The command parser is very sad if we don't emit the relocs per hw >> query... >> >> However, don't enable it. It mostly works, but piglit >> arb_transform_feedback_over

[Mesa-dev] [PATCH 2/2] radv/winsys: skip padded empty buffers in chain. (v2)

2018-01-18 Thread Dave Airlie
From: Dave Airlie When chaining buffers if we see an empty one (just padded) skip over it. v2: set empty_padded on init/reset, and unset on grow, then check once (Bas). --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions

[Mesa-dev] [PATCH v4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-18 Thread Kenneth Graunke
Growing the batch/state buffer is a lot more dangerous than I thought. A number of places emit multiple state buffer sections, and then write data to the returned pointer, or save a pointer to brw->batch.state.bo and then use it in relocations. If each call can grow, this can result in stale map

Re: [Mesa-dev] [PATCH] r600: add support for ARB_shader_clock.

2018-01-18 Thread Dave Airlie
On 12 January 2018 at 02:35, Gert Wollny wrote: > I can't test it with my 6870 HD, piglit clock2x32 > need OGL 4.3 (wich I force), and then it fails with > > evergreen_state.c:4762: evergreen_emit_atomic_buffer_setup: > Assertion `resource' failed. > > Compute shader piglits with atomics wo

Re: [Mesa-dev] [PATCH] r600: add support for ARB_shader_clock.

2018-01-18 Thread Dave Airlie
On 18 January 2018 at 13:28, Dave Airlie wrote: > On 12 January 2018 at 02:35, Gert Wollny wrote: >> I can't test it with my 6870 HD, piglit clock2x32 >> need OGL 4.3 (wich I force), and then it fails with >> >> evergreen_state.c:4762: evergreen_emit_atomic_buffer_setup: >> Assertion `reso

Re: [Mesa-dev] [PATCH] nir/spirv: add gl_spirv_validation method

2018-01-18 Thread Alejandro Piñeiro
On 17/01/18 22:25, Jason Ekstrand wrote: > On Wed, Jan 17, 2018 at 3:31 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new > method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 > "Shader Specializa

[Mesa-dev] [PATCH 4/4] i965: Implement GenerateMipmap directly, rather than using Meta.

2018-01-18 Thread Kenneth Graunke
Meta is awful and we'd like to stop using it. Implementing this using BLORP allows us to stop trashing a bunch of GL state every time. This follows the structure of st_generate_mipmap(). compute_num_levels is lifted directly from there. Improves performance in Gl41HdrBloom by about 11.794% +/- 1

[Mesa-dev] [PATCH 2/4] vbo: fix, add comment in vbo_save.h

2018-01-18 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 274d667..04b9e38 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -88,7 +88,7 @@ struct vbo_save_vertex_list { /** -

[Mesa-dev] [PATCH v2 4/4] mesa/program: Fix -Wunused-param warning

2018-01-18 Thread Gert Wollny
v2: Remove the unused ctx parameter from _mesa_optimize_program. v1: Annotate the unused parameter v1 was reviewed by Reviewed-by: Emil Velikov Signed-off-by: Gert Wollny --- src/mesa/program/arbprogparse.c | 2 +- src/mesa/program/ir_to_mesa.cpp | 2 +- src/mesa/program/prog_optimize.c | 3

[Mesa-dev] [PATCH 2/4] i965: Make texture validation code use texture objects, not units.

2018-01-18 Thread Kenneth Graunke
This requires moving the _MaxLevel handling up to the callers. Another user of intel_finalize_mipmap_tree will be added later that depends on _MaxLevel not being modified. --- src/mesa/drivers/dri/i965/intel_tex.h | 3 ++- src/mesa/drivers/dri/i965/intel_tex_validate.c | 30

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-18 Thread Dylan Baker
I'd like to get meson into the tarball for this release. There's a couple of patches on the list that will need to land, but I can CC those to stable if they don't land before the branch on Friday. Dylan Quoting Emil Velikov (2018-01-16 11:18:13) > Hi all, > > As you've know the Mesa 18.0.0 rele

Re: [Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

2018-01-18 Thread Timothy Arceri
On 18/01/18 11:35, Bas Nieuwenhuizen wrote: On Tue, Jan 16, 2018 at 7:45 AM, Timothy Arceri wrote: Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads" --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_t

[Mesa-dev] [PATCH 3/4] mesa: Move compute_num_levels from st_gen_mipmap.c to mipmap.c.

2018-01-18 Thread Kenneth Graunke
I want to use compute_num_levels inside i965. Rather than duplicating it, move it from mesa/st to core Mesa, and make it non-static. --- src/mesa/main/mipmap.c | 24 src/mesa/main/mipmap.h | 4 src/mesa/state_tracker/st_gen_mipmap.c |

[Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread George Kyriazis
The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so that we move the xyzw components correctly to the outputs. cc: Jose Fonseca --- src/gallium/auxiliary/gallivm/lp_bld_pack.c | 40

Re: [Mesa-dev] compiling OpenCL C to NIR

2018-01-18 Thread Eric Anholt
Tomeu Vizoso writes: > Hi, > > I'm still trying to estimate the work required to support OpenCL on > Freedreno, and as part of that I have given a try to put Khronos' > LLVM-SPIRV into a shape that Mesa can depend on: > > https://gitlab.collabora.com/tomeu/llvm-spirv > > I basically took Khrono

[Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

2018-01-18 Thread Dave Airlie
From: Dave Airlie Only one piglit test fails, sso-vs-gs-fs-array-interleave There are 3 tests using ssbo without checking sizes failing also but those are test bugs. Signed-off-by: Dave Airlie --- docs/features.txt| 4 ++-- docs/relnotes/17.4.0.html| 1 + src/g

Re: [Mesa-dev] [PATCH v3] anv/query: implement multiview interactions

2018-01-18 Thread Iago Toral
On Wed, 2018-01-17 at 13:14 -0800, Jason Ekstrand wrote: > On Wed, Jan 17, 2018 at 4:59 AM, Iago Toral Quiroga m> wrote: > > From the Vulkan spec with KHX extensions: > > > > > > > > "If queries are used while executing a render pass instance that > > has > > > >multiview enabled, the qu

[Mesa-dev] [PATCH v2 2/4] mesa: Make numSamples an unsigned int

2018-01-18 Thread Gert Wollny
As a followup to the previous patch propagate the change of numSamples from int to unsigned to gl_config::samples and consequently fix some -Wsign-compare warnings. Signed-off-by: Gert Wollny --- src/mesa/main/context.c| 4 ++-- src/mesa/main/context.h| 4 ++-- src/mesa/m

[Mesa-dev] [PATCH 1/4] i965: Pass tObj into intel_update_max_level instead of intel_obj.

2018-01-18 Thread Kenneth Graunke
We want both anyway, but this will simplify things a tiny bit in an upcoming patch. --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_validate.c b/src/mesa/drivers/dri/i965/intel_tex_val

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-18 Thread Timothy Arceri
On 18/01/18 04:25, Kenneth Graunke wrote: On Wednesday, January 17, 2018 4:00:26 AM PST Nicolai Hähnle wrote: On 17.01.2018 01:23, Jordan Justen wrote: On 2018-01-16 13:57:37, Kenneth Graunke wrote: On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: Hi all, As you've know the M

[Mesa-dev] [AppVeyor] mesa master #6624 failed

2018-01-18 Thread AppVeyor
Build mesa 6624 failed Commit 9041730d1c by Dave Airlie on 11/20/2017 9:29 PM: r600: add support for ARB_shader_clock.\n\nReviewed-by: Gert Wollny \nSigned-off-by: Dave Airlie Configure your notification preferences _

[Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Brian Paul
The optimization in change 8e4efdc895ea ("vbo: optimize some display list drawing") missed the loopback case. This is used when the glBegin/End primitive doesn't have a uniform set of vertex attributes. The new Piglit gl-1.0-dlist-materials test hits this. So check the aligned_vertex_buffer_offse

[Mesa-dev] [PATCH] radv/ws: get rid of useless return value

2018-01-18 Thread Dave Airlie
From: Dave Airlie This also used boolean, so nice to kill that. Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/ra

Re: [Mesa-dev] [PATCH v4 01/38] mesa/st: translate SO info in glsl_to_nir() case

2018-01-18 Thread Timothy Arceri
On 11/01/18 12:16, Marek Olšák wrote: On Wed, Jan 10, 2018 at 3:54 AM, Karol Herbst wrote: From: Rob Clark This was handled for VS, but not for GS. Fixes for gallium drivers using nir: spec@arb_gpu_shader5@arb_gpu_shader5-xfb-streams-without-invocations spec@arb_gpu_shader5@arb_gpu_shader5-x

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-18 Thread Nanley Chery
On Mon, Jan 15, 2018 at 03:29:07PM +0200, Pohjolainen, Topi wrote: > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > > it on the list for all to read. > > > > I'm thinking that what we want this list t

[Mesa-dev] [PATCH v2 1/4] gallium: Make (num_)samples an unsigned int

2018-01-18 Thread Gert Wollny
According to the ARB_multisample num_samples is a non-negative integer. Consequently define it as such, fail in glx/choose_visual if a negative number is given. v2: split patch into gallium and mesa part Signed-off-by: Gert Wollny --- src/gallium/include/state_tracker/st_api.h| 2 +- src/ga

Re: [Mesa-dev] [PATCH v2 1/4] anv/query: implement multiview interactions

2018-01-18 Thread Iago Toral
On Wed, 2018-01-17 at 13:07 -0800, Jason Ekstrand wrote: > On Wed, Jan 17, 2018 at 1:27 AM, Iago Toral > wrote: > > On Tue, 2018-01-16 at 08:07 -0800, Jason Ekstrand wrote: > > > On Mon, Jan 8, 2018 at 4:57 AM, Iago Toral Quiroga > > .com> wrote: > > > > From the Vulkan spec with KHX extensions:

[Mesa-dev] [PATCH v2 0/4] Fix unm_sampes and some warnings

2018-01-18 Thread Gert Wollny
with the pointers that Emil gave me I prepared a second version of the series: Changes in v2: Patch 1: * split the first patch into gallium and mesa part (as suggested) * also correct the according parameter of st_new_renderbuffer_fb Patch 2 & 3 (now 3 & 4) * instead of annotating the unu

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

2018-01-18 Thread Tapani Pälli
On 01/17/2018 11:59 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: Let's expose this only when we have formats. There are some known issues when this is exposed without formats (on Android). This is fixed now at least for master. OK cool .. then I guess we d

Re: [Mesa-dev] [GSOC] DriConf Replacement

2018-01-18 Thread Michel Dänzer
On 2018-01-17 09:50 PM, Jean Hertel wrote: > Hello Michel, > Hello Nicolai, > > I have spent some more time reading the Mesa source code and trying to figure > out how the prime configuration works. > If i understood correctly the driconf XML format should have an option inside > each applicatio

Re: [Mesa-dev] [GSOC] DriConf Replacement

2018-01-18 Thread Axel Davy
Hi all, Don't hesitate to recycle parts of my old try at DriConf Replacement: https://github.com/axeldavy/driCenter It had automatic detection of prime system and of the device_id. It detected also on which card apps run, and running apps. Yours, Axel On 18/01/2018 11:07, Michel Dänzer wrot

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 --- Comment #1 from Gert Wollny --- A trace can be found at: https://www.dropbox.com/s/ctkq3b7l9wp05oy/bioshock.i386.trace.xz Creating it had some warnings: apitrace: warning: _gl_param_size: unknown GLenum 0x90DF [ more of the same

Re: [Mesa-dev] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

2018-01-18 Thread Alex Smith
Oops, sorry about that. Reviewed-by: Alex Smith On 18 January 2018 at 01:16, Jason Ekstrand wrote: > Without this, we may end up dereferencing blend before we check for > binding->index != UINT32_MAX. However, Vulkan allows the blend state to > be NULL so long as you don't have any color atta

  1   2   3   >