Re: [Mesa-dev] [PATCH 2/2] mesa: add const qualifier on _mesa_is_renderable_texture_format()

Series: Reviewed-by: Timothy Arceri On 06/12/17 06:08, Brian Paul wrote: --- src/mesa/main/teximage.c | 3 ++- src/mesa/main/teximage.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 572e380..e5f8bb0 100644

Re: [Mesa-dev] [PATCH v4 28/44] i965/fs: Use untyped_surface_read for 16-bit load_ssbo (v2)

On Tue, Dec 5, 2017 at 1:36 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > SSBO loads were using byte_scattered read messages as they allow > reading 16-bit size components. byte_scattered messages can only > operate one component at a time so we needed to emit as many messages >

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> Reviewed-by: Timothy Arceri >> >> >> >> Mark may want to consider adding some of the once a day type CI runs for >> >> this. For example runn

Re: [Mesa-dev] [PATCH v4 28/44] i965/fs: Use untyped_surface_read for 16-bit load_ssbo (v2)

On 05/12/17 23:47, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 1:36 PM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > SSBO loads were using byte_scattered read messages as they allow > reading 16-bit size components. byte_scattered messages can only > operat

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 06/12/17 09:49, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Mark may want to consider adding some of the once a day type CI runs for this. For example

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

On Monday, December 4, 2017 12:12:49 PM PST Antia Puentes wrote: > The new order is: > * VE 1: > * VE 2: > > Previously it was: > * VE 1: > * VE 2: > > The gl_BaseVertex is in a new location now, and firstvertex occupies > the old gl_BaseVertex place. This way we can keep pointing to the > in

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen writes: > > > On 2017-12-05 09:13:11, Mark Janes wrote: > >> Jordan Justen writes: > >> > >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: > >> >> Reviewed-by: Timothy Arceri > >> >> > >> >> Mark may want to consider adding some of t

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

On 05/12/17 22:25, Chema Casanova wrote: > On 05/12/17 19:53, Jason Ekstrand wrote: >> On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova > > wrote: >> >> El 30/11/17 a las 23:58, Jason Ekstrand escribió: >> > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp help

[Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

From: Jason Ekstrand load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit surface format defined. So when reading 16-bit components with the sampler we need to unshuffle two 16-bit components from each 32-bit component. Using the sampler avoids the use of the byte_scattered_read mes

Re: [Mesa-dev] [PATCH 1/1] radv: use a faster version for nir_op_pack_half_2x16

On 6 December 2017 at 03:02, Samuel Pitoiset wrote: > This patch is ported from RadeonSI and it has two effects. > > It fixes a rendering issue which affects F1 2017 and Dawn > of War 3 (Vega only) because LLVM was ending up by generating > the new v_mad_mix_{hi,lo} instructions which appear to be

[Mesa-dev] [PATCH] intel/compiler/gen10: Disable push constants.

We still have gpu hangs on Cannonlake when using push constants, so disable them for now until we have a proper fix for these hangs. Signed-off-by: Rafael Antognolli --- src/intel/compiler/brw_fs.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/compiler/brw_fs.cpp b/src

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

Looks good to me. On Tue, Dec 5, 2017 at 3:47 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > From: Jason Ekstrand > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading 16-bit components with the > sampler we need to unsh

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

I can confirm this fixes the Dead Island crash, which makes this the first time I've been able to play the game since purchasing it :D The patches doesn't apply cleanly to master so I used the following fixup https://github.com/FireBurn/mesa/tree/gallium-program-binary If you're happy with that f

Re: [Mesa-dev] [PATCH 03/29] anv/blorp: Support ISL_AUX_USAGE_HIZ in surf_for_anv_image

On Mon, Nov 27, 2017 at 07:05:53PM -0800, Jason Ekstrand wrote: > If the function gets passed ANV_AUX_USAGE_DEFAULT, it still has the old > behavior of setting ISL_AUX_USAGE_NONE for depth/stencil which is what > we want for blits/copies. > --- > src/intel/vulkan/anv_blorp.c | 22 ++---

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > This replaces image_fast_clear and ccs_resolve with two new helpers that > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > is a bit cleaner as it separates performing the aux operation from which > blorp help

Re: [Mesa-dev] [PATCH v4 00/44] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

On 05/12/17 18:31, Chema Casanova wrote: > El 05/12/17 a las 06:16, Jason Ekstrand escribió: >> A couple of notes: >> >>  1) I *think* I gave you enough reviews to land the UBO/SSBO part and >> the optimizations in 26-28.  If reviews are still missing anywhere, >> please let me know.  If not, let's

Re: [Mesa-dev] [PATCH 04/29] anv/blorp: Rework HiZ ops to look like MCS and CCS

On Mon, Nov 27, 2017 at 07:05:54PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 38 > ++ > src/intel/vulkan/anv_private.h | 9 + > src/intel/vulkan/genX_cmd_buffer.c | 11 ++- > 3 files changed, 33 insertions(+)

Re: [Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

On Thu, Nov 30, 2017 at 9:15 PM, Jason Ekstrand wrote: > After talking with Kristian a bit on IRC, I think there is a bit more > explanation needed. I would be happy to add something like this to the > commit message or as a comment upon request. > > There is an interesting edge case in the varia

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen writes: >> >> >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> >> Reviewed-by: Timothy Arceri >> >> >> >> >> >> Mark ma

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 06/12/17 12:04, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Mark may want to consi

Re: [Mesa-dev] screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

Hi Michel, I debug deep into the source code, found out that: In si_shader.c file about 7039 line: if (key->ps_prolog.color_interp_vgpr_index[i] != -1) { unsigned interp_vgpr = key->ps_prolog.num_input_sgprs +

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Timothy Arceri writes: > On 06/12/17 12:04, Mark Janes wrote: >> Jordan Justen writes: >> >>> On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen writes: >> >>> On 2017-11-08 17:26:47, Timothy A

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

On 2017-12-05 18:30:30, Mark Janes wrote: > Timothy Arceri writes: > > > On 06/12/17 12:04, Mark Janes wrote: > >> Jordan Justen writes: > >> > >>> On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen writes: > > It could be interesting to define a MESA extension to control or qu

[Mesa-dev] 答复: Re: screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

Hi Michel, We solve the glxgears segmentation fault problem by add the compile flags: -fsigned-char. In arm platform, char variant default to "unsigned-char", that makes problem of glxgears segmentation fault. But after we recompile mesa with -fsigned-char. The

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 11/30/2017 10:48 AM, Rob Clark wrote: On Thu, Nov 30, 2017 at 1:28 AM, James Jones wrote: On 11/29/2017 01:10 PM, Rob Clark wrote: On Wed, Nov 29, 2017 at 12:33 PM, Jason Ekstrand wrote: On Sat, Nov 25, 2017 at 1:20 PM, Rob Clark wrote: On Sat, Nov 25, 2017 at 12:46 PM, Jason Ekstra

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 11/30/2017 12:06 PM, Lyude Paul wrote: On Thu, 2017-11-30 at 13:20 -0500, Rob Clark wrote: On Thu, Nov 30, 2017 at 12:59 AM, James Jones wrote: On 11/29/2017 04:09 PM, Miguel Angel Vico wrote: On Wed, 29 Nov 2017 16:28:15 -0500 Rob Clark wrote: Do we need to define both in-place and co

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 12/01/2017 10:34 AM, Nicolai Hähnle wrote: On 01.12.2017 18:09, Nicolai Hähnle wrote: [snip] As for the actual transition API, I accept that some metadata may be required, and the metadata probably needs to depend on the memory layout, which is often vendor-specific. But even linear layouts

Re: [Mesa-dev] [PATCH v3 24/25] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

On 12/05/2017 06:10 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > Thanks, Timothy. Any chance to review the remaining patches in the series? It would be nice to land this batch soon to focus on the actual linker stuff. cheers, Eduardo > On 04/12/17 20:21, Eduardo Lima Mitev wrote:

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On 12/01/2017 01:52 PM, Miguel Angel Vico wrote: On Fri, 1 Dec 2017 13:38:41 -0500 Rob Clark wrote: On Fri, Dec 1, 2017 at 12:09 PM, Nicolai Hähnle wrote: On 01.12.2017 16:06, Rob Clark wrote: On Thu, Nov 30, 2017 at 5:43 PM, Nicolai Hähnle wrote: Hi, I've had a chance to look a bit

Re: [Mesa-dev] 答复: Re: screen blurred and glxgears segment fault on ubuntu17.10 for arm architecture server with amdgpu(AMD RADEON PRO WX7100)

On Tue, Dec 5, 2017 at 8:18 PM, Lvzhihong (ReJohn) wrote: > Hi Michel, > > We solve the glxgears segmentation fault problem by add the compile > flags: -fsigned-char. > In arm platform, char variant default to "unsigned-char", that makes > problem of glxgears segmentation fault.

<    1   2