Re: [Mesa-dev] [PATCH 6/6] i965: Add some batchbuffer debugging code.

2017-11-29 Thread Kenneth Graunke
On Tuesday, November 28, 2017 4:13:21 PM PST Kenneth Graunke wrote: > Uncommenting these blocks stress tests the batch/state growth code by > trying to "grow" a buffer to the same size at least once per batch. > > When anything goes wrong with this code, dumping the validation list > is a useful w

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-29 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-11-28 at 12:49 -0800, Ian Romanick wrote: > Based on my (weak) understanding things in this part of the code, I > think this is ok. There are a couple minor nits below. With those > addressed and unless Jason has (time to give) some objections, this > patch is > > Reviewed-by: Ian R

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

2017-11-29 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-11-28 at 12:59 -0800, Jason Ekstrand wrote: > On Tue, Nov 14, 2017 at 10:39 PM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > > > We can write to the same output but in different components, like > > in this example: > > > > layout(location = 0, component = 0) out ivec

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-29 Thread Nicolai Hähnle
On 27.11.2017 23:05, Alex Deucher wrote: On Mon, Nov 27, 2017 at 5:01 PM, Adam Jackson wrote: On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: Hi everybody, Mario, feel free to push your patches if you haven't yet. (except the workaround) For AMD, I applied Mario's patches (except Wayla

[Mesa-dev] [PATCH] i965: Program the dynamic state heap size to MAX_STATE_SIZE.

2017-11-29 Thread Kenneth Graunke
STATE_BASE_ADDRESS specifies a maximum size of the dynamic state section, beyond which data supposedly reads back as 0. On Gen8+, we were programming it to the size of the buffer. This worked fine until we started growing the state buffer in commit 2dfc119f22f25708. When the state buffer grows, t

Re: [Mesa-dev] [PATCH] i965: Program the dynamic state heap size to MAX_STATE_SIZE.

2017-11-29 Thread Chris Wilson
Quoting Kenneth Graunke (2017-11-29 09:08:23) > STATE_BASE_ADDRESS specifies a maximum size of the dynamic state > section, beyond which data supposedly reads back as 0. On Gen8+, > we were programming it to the size of the buffer. This worked fine > until we started growing the state buffer in c

Re: [Mesa-dev] [PATCH 01/23] radeonsi: move all clear() code into si_clear.c

2017-11-29 Thread Nicolai Hähnle
On 28.11.2017 22:38, Marek Olšák wrote: From: Marek Olšák The commit message should mention that this also contains some preliminary work for MSAA DCC. Cheers, Nicolai --- src/gallium/drivers/radeon/r600_pipe_common.h | 13 +- src/gallium/drivers/radeon/r600_texture.c | 547 +---

Re: [Mesa-dev] [PATCH 11/23] mesa: add driver callbacks for serialising ProgramBinary blobs

2017-11-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-11-28 17:24:47, Timothy Arceri wrote: > --- > src/mesa/main/dd.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h > index da03b2e8b94..4e4d2a6f37d 100644 > --- a/src/mesa/main/dd.h > +++ b/src/

Re: [Mesa-dev] [PATCH 01/23] radeonsi: move all clear() code into si_clear.c

2017-11-29 Thread Nicolai Hähnle
On 29.11.2017 10:29, Nicolai Hähnle wrote: On 28.11.2017 22:38, Marek Olšák wrote: From: Marek Olšák The commit message should mention that this also contains some preliminary work for MSAA DCC. Unless you plan to land this after the series, that is? I was comparing to the code in master.

Re: [Mesa-dev] [PATCH 20/23] radeonsi: remove query/apply_opaque_metadata callbacks

2017-11-29 Thread Nicolai Hähnle
On 28.11.2017 22:38, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 8 -- src/gallium/drivers/radeon/r600_texture.c | 110 -- src/gallium/drivers/radeonsi/si_state.c | 98 --- 3 files changed

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Christian König
Am 29.11.2017 um 05:02 schrieb Gurkirpal Singh: These are the refactored commits related to the GSoC project involving adding a st/omx state tracker using tizonia. There are still some parts of code that i didn't refactor yet as explained below: 1) I wasn't sure if it's okay to use #if-#else decl

Re: [Mesa-dev] [PATCH 00/24] RadeonSI huge cleanup

2017-11-29 Thread Nicolai Hähnle
On 28.11.2017 22:38, Marek Olšák wrote: Hi, Most of this series deals with the dissolution of the drivers/radeon directory, but this is just one small iteration of that. Patch 7 should be the only functional change and it's an optimization. Nice cleanups! Minor comments on patches 1 & 20. Apa

Re: [Mesa-dev] [PATCH v2] radeonsi: Adding tiled to linear conversion functionality

2017-11-29 Thread Nicolai Hähnle
On 29.11.2017 08:10, Sahu, Satyajit wrote: On 11/28/2017 9:33 PM, Nicolai Hähnle wrote: On 28.11.2017 09:34, Sahu, Satyajit wrote: [snip] --- a/src/gallium/targets/dri/dri.sym +++ b/src/gallium/targets/dri/dri.sym @@ -4,6 +4,11 @@    __driDriverGetExtensions*;    nouveau_drm_s

Re: [Mesa-dev] [PATCH] i965: Program the dynamic state heap size to MAX_STATE_SIZE.

2017-11-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-11-29 01:08:23, Kenneth Graunke wrote: > STATE_BASE_ADDRESS specifies a maximum size of the dynamic state > section, beyond which data supposedly reads back as 0. On Gen8+, > we were programming it to the size of the buffer. This worked fine > until we started

Re: [Mesa-dev] [PATCH 3/6] radeonsi: clear PIPE_IMAGE_ACCESS_WRITE when it's invalid to be on the safe side

2017-11-29 Thread Nicolai Hähnle
On 28.11.2017 22:17, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 69371ea..471c93a 100644

Re: [Mesa-dev] [PATCH 0/6] RadeonSI DCC for MSAA on VI

2017-11-29 Thread Nicolai Hähnle
On 28.11.2017 22:17, Marek Olšák wrote: Hi, This series enables DCC for MSAA on VI. MSAA array textures don't enable DCC because the fast clear would be slightly more complicated. GFX9 doesn't enable DCC for MSAA at all, because the only way to do fast clear is to use a compute shader and manua

Re: [Mesa-dev] [PATCH 1/6] i965: Don't grow batch/state buffer on every emit after an overflow.

2017-11-29 Thread Jordan Justen
On 2017-11-28 18:41:44, Kenneth Graunke wrote: > On Tuesday, November 28, 2017 6:15:59 PM PST Ian Romanick wrote: > > On 11/28/2017 04:13 PM, Kenneth Graunke wrote: > > > Once we reach the intended size of the buffer (BATCH_SZ or STATE_SZ), we > > > try and flush. If we're not allowed to flush, we

Re: [Mesa-dev] [PATCH 2/6] i965: Use old_bo->align when growing batch/state buffer instead of 4096.

2017-11-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-11-28 16:13:17, Kenneth Graunke wrote: > The intention here is make the new BO use the same alignment as the old > BO. This isn't strictly necessary, but we would have to update the > 'alignment' field in the validation list when swapping it out, and we > don't

Re: [Mesa-dev] [PATCH 2/6] i965: Use old_bo->align when growing batch/state buffer instead of 4096.

2017-11-29 Thread Chris Wilson
Quoting Kenneth Graunke (2017-11-29 00:13:17) > The intention here is make the new BO use the same alignment as the old > BO. This isn't strictly necessary, but we would have to update the > 'alignment' field in the validation list when swapping it out, and we > don't bother today. > > The batch

Re: [Mesa-dev] [PATCH] radeonsi: always initialize max_forced_staging_uploads

2017-11-29 Thread Henri Verbeet
On 28 November 2017 at 20:20, Marek Olšák wrote: > Most of the corruption goes away if I flush IBs after every command. > This suggests that the staging upload is done in one context while > drawing is done in another context. The solution is to flush all > contexts before BufferData/BufferSubData

Re: [Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

2017-11-29 Thread Nicolai Hähnle
On 21.11.2017 04:28, Timothy Arceri wrote: V2: fix matrix support, non-array matrices were being skipped in v1 --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h | 1 +

[Mesa-dev] [PATCH] i965/vec4: use a temp register to compute offsets for pull loads

2017-11-29 Thread Iago Toral Quiroga
64-bit pull loads are implemented by emitting 2 separate 32-bit pull load messages, where the second message loads from an offset at +16B. That addition of 16B to the original offset should not alter the original offset register used as source for the pull load instruction though, since the compil

Re: [Mesa-dev] [PATCH 5/8] nir: add varying component packing helpers

2017-11-29 Thread Nicolai Hähnle
On 21.11.2017 04:28, Timothy Arceri wrote: v2: update shader info input/output masks when pack components v3: make sure interpolation loc matches, this is required for the radeonsi NIR backend. Reviewed-by: Bas Nieuwenhuizen (v1) --- src/compiler/nir/nir.h | 2 + src/c

Re: [Mesa-dev] [PATCH 01/15] nir: add array lowering function that assumes there are no indirects

2017-11-29 Thread Nicolai Hähnle
On 22.11.2017 11:29, Timothy Arceri wrote: The gallium glsl->nir pass currently lowers away all indirects on both inputs and outputs. This fuction allows us to lower vs inputs and fs outputs and also lower things one stage at a time as we don't need to worry about indirects on the other side of t

Re: [Mesa-dev] [PATCH 02/15] nir: allow builin arrays to be lowered

2017-11-29 Thread Nicolai Hähnle
On 22.11.2017 11:29, Timothy Arceri wrote: Galliums nir drivers expect this to be done. --- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c b/src/compil

Re: [Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

2017-11-29 Thread Timothy Arceri
On 29/11/17 21:47, Nicolai Hähnle wrote: On 21.11.2017 04:28, Timothy Arceri wrote: V2: fix matrix support, non-array matrices were being skipped in v1 ---   src/compiler/Makefile.sources  |   1 +   src/compiler/nir/meson.build   |   1 +   src/compiler/nir

Re: [Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

2017-11-29 Thread Nicolai Hähnle
On 29.11.2017 12:20, Timothy Arceri wrote: On 29/11/17 21:47, Nicolai Hähnle wrote: On 21.11.2017 04:28, Timothy Arceri wrote: +  nir_ssa_dest_init(&element_intr->instr, &element_intr->dest, +    intr->num_components, intr->dest.ssa.bit_size, NULL); + +  if (intr->

Re: [Mesa-dev] V2 Initial GS NIR support for radeonsi

2017-11-29 Thread Nicolai Hähnle
On 22.11.2017 11:29, Timothy Arceri wrote: This series depends on [1] and [2]. V2 - use driver_location as per Nicolais suggestion - tidy ups as per Mareks suggestions - bug fixes (many more piglit tests now passing) Thanks again for doing this, and my apologies for taking so long to fi

Re: [Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

2017-11-29 Thread Timothy Arceri
On 29/11/17 22:27, Nicolai Hähnle wrote: On 29.11.2017 12:20, Timothy Arceri wrote: On 29/11/17 21:47, Nicolai Hähnle wrote: On 21.11.2017 04:28, Timothy Arceri wrote: +  nir_ssa_dest_init(&element_intr->instr, &element_intr->dest, +    intr->num_components, intr->de

Re: [Mesa-dev] [PATCH 05/14] st/glsl_to_nir: split linking loop in two in prep of nir linking opts

2017-11-29 Thread Nicolai Hähnle
On 21.11.2017 04:37, Timothy Arceri wrote: --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index bb0ba07012..8c2

Re: [Mesa-dev] [PATCH 12/14] radeonsi/nir: add support for packed inputs

2017-11-29 Thread Nicolai Hähnle
On 21.11.2017 04:37, Timothy Arceri wrote: Because NIR can create non vec4 variables when implementing component packing we need to make sure not to reprocess the same slot again. Also we can drop the fs_attr_idx counter and just use driver_location. --- src/gallium/drivers/radeonsi/si_shader_

Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

2017-11-29 Thread Nicolai Hähnle
On 21.11.2017 04:37, Timothy Arceri wrote: This series depends on: https://patchwork.freedesktop.org/series/34131/ Tested without regression on radeonsi. > Shader-db results (still limited to GLSL 1.40 so not to interesting): Totals from affected shaders: SGPRS: 29440 -> 30464 (3.48 %) VGPRS: 1

Re: [Mesa-dev] [PATCH 06/14] meson: use driver_deps for gallium osmesa

2017-11-29 Thread Marc Dietrich
Hi Dylan, Am Mittwoch, 29. November 2017, 00:30:27 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > --- > src/gallium/targets/osmesa/meson.build | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/src/gallium/targets/osmesa/meson.build > b/src/gallium/

Re: [Mesa-dev] [PATCH 06/14] meson: use driver_deps for galliumosmesa

2017-11-29 Thread Marc Dietrich
Am Mittwoch, 29. November 2017, 12:59:30 CET schrieb Marc Dietrich: > Hi Dylan, > > Am Mittwoch, 29. November 2017, 00:30:27 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > --- > > > > src/gallium/targets/osmesa/meson.build | 13 +++-- > > 1 file changed, 3 insertions(+), 10

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Nicolai Hähnle
On 25.11.2017 18:46, Jason Ekstrand wrote: I'm not quite some sure what I think about this.  I think I would like to see $new_thing at least replace the guts of GBM. Whether GBM becomes a wrapper around $new_thing or $new_thing implements the GBM API, I'm not sure.  What I don't think I want is

[Mesa-dev] [PATCH v3 10/15] etnaviv: GC7000: State changes for HALTI3..5

2017-11-29 Thread Wladimir J. van der Laan
Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 249 +++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 + src/gall

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

2017-11-29 Thread Marc Dietrich
Hi Dylan, Am Mittwoch, 29. November 2017, 00:30:21 CET schrieb Dylan Baker: > This series is the gallium media state trackers, the "nine" Direct3D state > tracker, and an architectural change in the way gallium drivers are linked > into the final targets. > > This architectural change results in

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

2017-11-29 Thread Timothy Arceri
On 29/11/17 00:54, Gert Wollny wrote: Am Dienstag, den 28.11.2017, 08:45 +1100 schrieb Timothy Arceri: If I understand the comments in opt_array_splitting, arrays of arrays are not properly handled there. Curretly, I don't see how I can fix this, because I simply didn't look at any code ther

Re: [Mesa-dev] [PATCH 14/14] meson: build gallium nine state_tracker

2017-11-29 Thread Marc Dietrich
Am Mittwoch, 29. November 2017, 00:30:35 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > --- > include/meson.build| 8 ++ > meson.build| 17 +++- > meson_options.txt | 12 +++ > src/g

Re: [Mesa-dev] [RFC] r600/evergreen compute shader + glsl 4.30 support

2017-11-29 Thread Gert Wollny
Am Mittwoch, den 29.11.2017, 14:36 +1000 schrieb Dave Airlie: > This set of patches enables compute shaders on r600 and exposes GLSL > 4.30 support. They are pretty alpha level, but I'd like to land some > of them (maybe disabled) so I can avoid the rebasing fun with the > more intrusive ones. > >

[Mesa-dev] testing for certain compiler options does not work

2017-11-29 Thread Marc Dietrich
Hi, just found that my gcc 'gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch revision 253932]' does not warn when using the negative form of unsupported warning options. So all the configure tests for such options erroneously succeed, e.g: gcc -Wno-bob test.c # works fine gcc -Walice test.c # war

[Mesa-dev] [PATCH] configure: avoid testing for negative compiler options

2017-11-29 Thread Marc Dietrich
gcc seems to always accept unsupported negative compiler warning options: echo "int i;" | gcc -c -xc -Wno-bob - # no error echo "int i;" | gcc -c -xc -Walice - # unsupported compiler option Inverting the options fixes the tests. Signed-off-by: Marc Dietrich --- configure.ac | 4 ++-- meson.bu

[Mesa-dev] [PATCH] radv: do not allocate CMASK or DCC for small surfaces

2017-11-29 Thread Samuel Pitoiset
The idea is ported from RadeonSI, but using 512x512 instead of 256x256 seems slightly better. This improves dota2 performance by +2%. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/a

[Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

2017-11-29 Thread Rob Clark
Add a new helper that drivers can use to emulate various things that need special handling in particular in transfer_map: 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth and stencil interleaved but hardware frequently treats this as separate z32 and s8 buffers. Specia

[Mesa-dev] [PATCH 2/2] freedreno: use u_transfer helper

2017-11-29 Thread Rob Clark
Also removes usage of u_resource, which was basically useless for freedreno. Perhaps that should be two commits, but that would have required undoing and then re-doing &rsc->base.b stuff. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 8 +- src/gallium/drive

[Mesa-dev] [Bug 103732] [swr] often gets stuck in piglit's glx-multi-context-single-window test

2017-11-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #9 from Andrés Gómez García --- (In reply to Bruce Cherniak from comment #8) > The root cause to this bug was fixed in a post-17.2 patch (b9aa0fa7) "swr: > Handle resource across context changes". It's in mesa master and the > forth

Re: [Mesa-dev] [PATCH 3/6] radeonsi: clear PIPE_IMAGE_ACCESS_WRITE when it's invalid to be on the safe side

2017-11-29 Thread Marek Olšák
On Wed, Nov 29, 2017 at 10:59 AM, Nicolai Hähnle wrote: > On 28.11.2017 22:17, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_descriptors.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

2017-11-29 Thread Eric Engestrom
On Tuesday, 2017-11-28 16:56:38 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > meson.build | 11 +++ > meson_options.txt | 7 +++ > src/gallium/drivers/etnaviv/meson.build | 2 +- > src/gallium/drivers/freedreno

Re: [Mesa-dev] [PATCH] anv: Check if memfd_create is already defined.

2017-11-29 Thread Eric Engestrom
On Wednesday, 2017-11-29 07:29:40 +, Vinson Lee wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103909 > Signed-off-by: Vinson Lee > --- > configure.ac | 1 + > meson.build | 2 +- > src/intel/vulkan/anv_allocator.c | 2 ++ > src/intel/

[Mesa-dev] [PATCH mesa] gallium/hud: use #ifdef to test for macro existence

2017-11-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/hud/hud_context.c | 10 +- src/gallium/auxiliary/hud/hud_cpufreq.c | 2 +- src/gallium/auxiliary/hud/hud_diskstat.c | 2 +- src/gallium/auxiliary/hud/hud_nic.c | 2 +- src/gallium/auxiliary/hud/hud_private.h

Re: [Mesa-dev] [PATCH 03/23] radeonsi: move r600_test_dma.c into si_test_dma.c

2017-11-29 Thread Eric Engestrom
On Tuesday, 2017-11-28 22:38:31 +0100, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/Makefile.sources| 1 - > src/gallium/drivers/radeon/r600_pipe_common.h | 3 --- > src/gallium/drivers/radeonsi/Makefile.sources | 1 + > src/gallium/drivers/rad

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Eric Engestrom
On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > These are the refactored commits related to the GSoC project involving > adding a st/omx state tracker using tizonia. > There are still some parts of code that i didn't refactor yet as > explained below: > 1) I wasn't sure if it's ok

Re: [Mesa-dev] [PATCH 20/22] nv50, nvc0: Support BGRX1010102 format for visuals.

2017-11-29 Thread Ilia Mirkin
Why is this required? Can't you just use the BGR10_A2 format directly? The problem with exposing these sorts of formats is that blending with DST_ALPHA would be incorrect -- it should get read in as 1.0, but will end up with bogus values. Cheers, -ilia On Tue, Nov 28, 2017 at 11:21 PM, Mario

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

2017-11-29 Thread Eric Engestrom
On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > This series is the gallium media state trackers, the "nine" Direct3D state > tracker, and an architectural change in the way gallium drivers are linked > into > the final targets. > > This architectural change results in a good deal of c

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-29 Thread Jon Turney
On 27/11/2017 18:35, Dylan Baker wrote: Quoting Jon Turney (2017-11-27 05:58:32) --- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode 1006

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-29 Thread Jon Turney
On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef=true, to catch these issues as part of the build process. We already do so in the auto

Re: [Mesa-dev] [PATCH 01/23] radeonsi: move all clear() code into si_clear.c

2017-11-29 Thread Marek Olšák
On Wed, Nov 29, 2017 at 10:32 AM, Nicolai Hähnle wrote: > On 29.11.2017 10:29, Nicolai Hähnle wrote: >> >> On 28.11.2017 22:38, Marek Olšák wrote: >>> >>> From: Marek Olšák >> >> >> The commit message should mention that this also contains some preliminary >> work for MSAA DCC. > > > Unless you p

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

2017-11-29 Thread Emil Velikov
On 27 November 2017 at 19:36, Rob Herring wrote: > AOSP master has changed the build default to -Werror making all the > warnings errors. Override that with -Wno-error. > For both Mesa and libdrm patches Reviewed-by: Emil Velikov Mildly related: Quick grep|sort|unique through your build log sho

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

2017-11-29 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-29 06:41:32) > On Tuesday, 2017-11-28 16:56:38 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > meson.build | 11 +++ > > meson_options.txt | 7 +++ > > src/gallium/drivers/etnav

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

2017-11-29 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-29 06:41:32) > On Tuesday, 2017-11-28 16:56:38 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > meson.build | 11 +++ > > meson_options.txt | 7 +++ > > src/gallium/drivers/etnav

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-29 Thread Dylan Baker
Quoting Jon Turney (2017-11-29 08:23:00) > On 27/11/2017 18:35, Dylan Baker wrote: > > Quoting Jon Turney (2017-11-27 05:58:32) > >> --- > >> src/glx/meson.build | 25 +-- > >> src/glx/windows/meson.build | 48 > >> + > >>

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Jason Ekstrand
On Sat, Nov 25, 2017 at 1:20 PM, Rob Clark wrote: > On Sat, Nov 25, 2017 at 12:46 PM, Jason Ekstrand > wrote: > > On November 24, 2017 09:29:43 Rob Clark wrote: > >> > >> > >> On Mon, Nov 20, 2017 at 8:11 PM, James Jones > wrote: > >>> > >>> As many here know at this point, I've been working o

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-29 Thread Dylan Baker
Quoting Jon Turney (2017-11-29 08:22:54) > On 28/11/2017 18:21, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-27 06:31:35) > >> IIRC Windows mandates binaries with unresolved symbols. > >> Other platforms allow such behaviour. > >> > >> I think we want to set b_lundef=true, to catch these is

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Jason Ekstrand
On Wed, Nov 29, 2017 at 4:19 AM, Nicolai Hähnle wrote: > On 25.11.2017 18:46, Jason Ekstrand wrote: > >> I'm not quite some sure what I think about this. I think I would like to >> see $new_thing at least replace the guts of GBM. Whether GBM becomes a >> wrapper around $new_thing or $new_thing i

Re: [Mesa-dev] [PATCH 06/14] meson: use driver_deps for gallium osmesa

2017-11-29 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-29 03:59:30) > Hi Dylan, > > Am Mittwoch, 29. November 2017, 00:30:27 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > --- > > src/gallium/targets/osmesa/meson.build | 13 +++-- > > 1 file changed, 3 insertions(+), 10 deletions(-) > > > > diff -

Re: [Mesa-dev] Refactored st/omx/tizonia commits

2017-11-29 Thread Gurkirpal Singh
If you are referring to earlier discussion about having tizonia build problems then it was about disabling some extra CPU intensive features like the tizonia player which isn't needed here. This was only required if you wanted to build from source instead of downloading it. Later Juan added an opti

Re: [Mesa-dev] [PATCH 14/14] meson: build gallium nine state_tracker

2017-11-29 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-29 04:41:15) > Am Mittwoch, 29. November 2017, 00:30:35 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > --- > > include/meson.build| 8 ++ > > meson.build| 17 +++- > > meson_option

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

2017-11-29 Thread Rob Herring
On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov wrote: > On 27 November 2017 at 19:36, Rob Herring wrote: >> AOSP master has changed the build default to -Werror making all the >> warnings errors. Override that with -Wno-error. >> > For both Mesa and libdrm patches > > Reviewed-by: Emil Velikov >

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

2017-11-29 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-29 04:31:07) > Hi Dylan, > > Am Mittwoch, 29. November 2017, 00:30:21 CET schrieb Dylan Baker: > > This series is the gallium media state trackers, the "nine" Direct3D state > > tracker, and an architectural change in the way gallium drivers are linked > > into the f

[Mesa-dev] [PATCH] docs/release-calendar: update and extend

2017-11-29 Thread Emil Velikov
From: Emil Velikov Cc: Juan A. Suárez Cc: Andres Gomez Signed-off-by: Emil Velikov --- Gents, I have no objections if you want to do any of the releases listed ;-) --- docs/release-calendar.html | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/d

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-29 Thread Nanley Chery
On Mon, Nov 27, 2017 at 11:44:21AM -0800, Jason Ekstrand wrote: > On Mon, Nov 27, 2017 at 11:41 AM, Nanley Chery > wrote: > > > On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote: > > > When sampling from fast-cleared sRGB textures on gen10, the hardware > > > will not decode the clear

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2017-11-29 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 58 > ++ > src/intel/vulkan/anv_private.h | 5 > 2 files changed, 63 insertions(+) This seems to be pretty much inline with anv_layout_to_aux_usa

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-29 Thread Robert Foss
Hey, On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote: > On 28 November 2017 at 10:45, Tapani Pälli > wrote: > > Hi; > > > > > > On 11/27/2017 04:14 PM, Robert Foss wrote: > > > > > > From: Tomasz Figa > > > > > > There is no API available to properly query the > > > IMPLEMENTATION_DEFI

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-29 Thread Tapani Pälli
On 29.11.2017 20:43, Robert Foss wrote: Hey, On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote: On 28 November 2017 at 10:45, Tapani Pälli wrote: Hi; On 11/27/2017 04:14 PM, Robert Foss wrote: From: Tomasz Figa There is no API available to properly query the IMPLEMENTATION_DEFINED

[Mesa-dev] [PATCH] intel/isl: Declare private array as static const

2017-11-29 Thread Chad Versace
It's array isl_drm.c:modifier_info[] . --- src/intel/isl/isl_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl_drm.c b/src/intel/isl/isl_drm.c index eb3c6f59138..31895e15e16 100644 --- a/src/intel/isl/isl_drm.c +++ b/src/intel/isl/isl_drm.c @@ -71,7 +71,7

Re: [Mesa-dev] [PATCH 07/29] anv/image: Support color aspects in layout_to_aux_usage

2017-11-29 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:05:57PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 48 > ++-- > 1 file changed, 29 insertions(+), 19 deletions(-) I did a little grepping and it looks anv_layout_to_aux_usage() isn't at this point ever ca

[Mesa-dev] [PATCH v2 04/15] meson: use the driver dependencies for the gallium dri target

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/gallium/targets/dri/meson.build | 126 1 file changed, 26 insertions(+), 100 deletions(-) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index 323b337266f..42033a16211 100644 --- a/sr

[Mesa-dev] [PATCH v2 01/15] meson: Combine gallium target subdirs

2017-11-29 Thread Dylan Baker
So that state trackers, targets, and special winsys requirements are all in a single if statement. This is a cosmetic only cleanup with no functional changes. Signed-off-by: Dylan Baker --- src/gallium/meson.build | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH v2 02/15] meson: sort gallium drivers after winsys

2017-11-29 Thread Dylan Baker
This is a requirement of the next patch. Since meson does not have forward declarations, and we're going to define the driver dependencies in the drivers folder they need to be after the winsys so that the winsys libs are defined first. Signed-off-by: Dylan Baker --- src/gallium/meson.build | 16

[Mesa-dev] [PATCH v2 08/15] meson: extend install_megadrivers script to handle symmlinking

2017-11-29 Thread Dylan Baker
Which is required for the gallium media state trackers. v2: - Make symlinks local instead of absolute Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom (v1) --- bin/install_megadrivers.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/bin/install_megadrivers.py b/bin/

[Mesa-dev] [PATCH v2 07/15] meson: Add osmesa.sym script as a link dependency (gallium-osmesa)

2017-11-29 Thread Dylan Baker
v2: - Add this patch Signed-off-by: Dylan Baker --- src/gallium/targets/osmesa/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/targets/osmesa/meson.build b/src/gallium/targets/osmesa/meson.build index 760703d418f..cbf0e3d096a 100644 --- a/src/gallium/targets/osmes

[Mesa-dev] [PATCH v2 00/15] Most of gallium

2017-11-29 Thread Dylan Baker
This is a pretty tame v2, some fixes for gallium osmesa and xlib, including a new patch because I didn't add the osmesa linker script to the target's link depends, some more series work in gallium nine, and more changes for the install_megadrivers script, so that the symlinks it produces are relati

[Mesa-dev] [PATCH v2 11/15] meson: build gallium xvmc state tracker

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 40 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 +++- src/gallium/state_trackers/xvmc/meson.build | 53 +++ src/gallium

[Mesa-dev] [PATCH v2 10/15] meson: build gallium vdpau state tracker

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 46 +- meson_options.txt| 13 + src/gallium/meson.build | 7 ++- src/gallium/state_trackers/vdpau/meson.build | 32 + src/gallium/targets

[Mesa-dev] [PATCH v2 12/15] meson: build gallium omx state tracker

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build| 60 +- meson_options.txt | 13 + src/gallium/meson.build| 7 ++- .../state_trackers/omx_bellagio/meson.build| 30 ++

[Mesa-dev] [PATCH v2 14/15] meson: build gallium xa state tracker

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 22 meson_options.txt | 7 src/gallium/meson.build | 7 +++- src/gallium/state_trackers/xa/meson.build | 45 +++ src/gallium/targets/xa/meso

[Mesa-dev] [PATCH v2 09/15] meson: drop gallium-media argument

2017-11-29 Thread Dylan Baker
This argument is the wrong approach for handling gallium media state trackers, since it doesn't allow for an auto option. Instead we'll use tristates, which do allow for auto. This option has never been wired to anything anyway. Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- meson.

[Mesa-dev] [PATCH v2 06/15] meson: use driver_deps for gallium osmesa

2017-11-29 Thread Dylan Baker
v2: - Put driver_swrast in the correct field (dependencies) - Remove unused osmesa_deps Signed-off-by: Dylan Baker --- src/gallium/targets/osmesa/meson.build | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/gallium/targets/osmesa/meson.build b/src/g

[Mesa-dev] [PATCH v2 13/15] meson: build gallium va state tracker

2017-11-29 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 41 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/va/meson.build | 39 + src/gallium/targets/va/mes

[Mesa-dev] [PATCH v2 15/15] meson: build gallium nine state_tracker

2017-11-29 Thread Dylan Baker
v2: - set d3d_drivers_path instead of dri_drivers_path - Fix nine guard to check for all relavent gallium drivers - Link with libswdri and libswkmsdri when necessary - Fix pkg-config generation - Add missing comma Signed-off-by: Dylan Baker --- include/meson.build

[Mesa-dev] [PATCH v2 05/15] meson: Use driver dependencies for libgl-xlib target

2017-11-29 Thread Dylan Baker
v2: - put driver_swrast in the right field - add dep_threads (dep_llvm requires threads, so it masked this previously) Signed-off-by: Dylan Baker --- src/gallium/targets/libgl-xlib/meson.build | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH v2 03/15] meson: define driver dependencies

2017-11-29 Thread Dylan Baker
This allow us to encapsulate the compiler and linkage requirements of each driver in a reusable way. The result will be that each target that needs a specific driver can simply add `driver_` to its dependencies line and the necessary libraries and compiler args will be added. This will allow for a

[Mesa-dev] [PATCH 1/2] meson: fix GLES3/gl31.h install

2017-11-29 Thread Dylan Baker
This is a typo, gl32.h is installed twice. Reported-by: Marc Dietrich Signed-off-by: Dylan Baker --- include/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/meson.build b/include/meson.build index b5f533bd185..c6aa9248247 100644 --- a/include/meson.build

[Mesa-dev] [PATCH 2/2] meson: fix glxext.h install

2017-11-29 Thread Dylan Baker
Another typo, the glext.h header was being install instead. Reported-by: Marc Dietrich Signed-off-by: Dylan Baker --- include/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/meson.build b/include/meson.build index c6aa9248247..35e7791507c 100644 --- a/inc

[Mesa-dev] [PATCH 4/5] xlib: remove dummy GLX_MESA_set_3dfx_mode implementation

2017-11-29 Thread Emil Velikov
From: Emil Velikov The implementation is a simple 'return EGL_FALSE'. Stop pretending and simply remove it. Cc: Brian Paul Cc: Ian Romanick Signed-off-by: Emil Velikov --- docs/relnotes/17.4.0.html | 2 +- src/mesa/drivers/x11/fakeglx.c | 13 - src/mesa/drivers/x11/glxapi.c

[Mesa-dev] [PATCH 3/5] docs/specs: annotate MESA_agp_offset as obsolete

2017-11-29 Thread Emil Velikov
From: Emil Velikov No Mesa driver has implemented the extension in ages. Seemingly non Mesa drivers don't implement it either. As mentioned by Ian, the extension is effectively superseded by ARB_vertex_buffer_object. Cc: Brian Paul Cc: Ian Romanick Signed-off-by: Emil Velikov --- Should be c

[Mesa-dev] [PATCH 2/5] xlib: remove empty GLX_MESA_agp_offset stubs

2017-11-29 Thread Emil Velikov
From: Emil Velikov The extension was never implemented and seemingly never will. The DRI based libGL dropped support for it over 10 years ago. Cc: Brian Paul Cc: Ian Romanick Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/fakeglx.c | 3 --- src/mesa/drivers/x11/glxapi.c | 17

[Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-29 Thread Emil Velikov
From: Emil Velikov The extension was never implemented and seemingly never will. The DRI based libGL dropped support for it over 10 years ago. Cc: Brian Paul Cc: Ian Romanick Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/fakeglx.c | 26 -- src/mesa/drivers/x11/

[Mesa-dev] [PATCH 5/5] docs/specs: annotate MESA_set_3dfx_mode as obsolete

2017-11-29 Thread Emil Velikov
From: Emil Velikov Aimed to work with Glide, which hasn't been a thing in over 10 years. There are no drivers that implement it, so annotate it as obsolete Cc: Brian Paul Cc: Ian Romanick Signed-off-by: Emil Velikov --- Should be commit this locally and then upstream to Khronos? Worth moving

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Miguel Angel Vico
Many of you may already know, but James is going to be out for a few weeks and I'll be taking over this in the meantime. See inline for comments. On Wed, 29 Nov 2017 09:33:29 -0800 Jason Ekstrand wrote: > On Sat, Nov 25, 2017 at 1:20 PM, Rob Clark wrote: > > > On Sat, Nov 25, 2017 at 12:46 PM

  1   2   >