Re: [Mesa-dev] [PATCH] st/glsl_to_mesa: make use of driver_cache_blob with the disk cache

2017-11-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 27, 2017 at 6:30 AM, Timothy Arceri wrote: > driver_cache_blob was introduced with the i965 disk cache, it allows > us to simplify the cache a little and possibly offers some minor > speed improvements since we load the GLSL metadata and TGSI from > di

Re: [Mesa-dev] [PATCH] r600/cayman: looks like cmpxchg moved to Z

2017-11-27 Thread Constantine Kharlamov
On понедельник, 27 ноября 2017 г. 9:41:35 MSK Dave Airlie wrote: > From: Dave Airlie > > On cayman it appears the cmp component is now in Z. > > Fixes: > arb_shader_image_load_store-dead-fragments on cayman. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_shader.c | 7 +++

Re: [Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-27 Thread Alejandro Piñeiro
On 27/11/17 03:22, Timothy Arceri wrote: > I suspect this patch doesn't compile. I think pEntryPoint is meant to > be passed as an argument to this function. It is the second parameter of the method. But it is true that it doesn't appear on this patch. Seems that the diff skipped some lines there.

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

2017-11-27 Thread Eric Engestrom
On Sunday, 2017-11-26 17:24:09 -0800, Eric Anholt wrote: > Eric Engestrom writes: > > > On Wednesday, 2017-11-22 12:28:17 -0800, Eric Anholt wrote: > >> Jordan Justen writes: > >> > >> > On 2017-11-22 09:59:34, Eric Engestrom wrote: > >> >> A recent thread [1] made me check our local specs to s

[Mesa-dev] [Bug 102218] Nier:Automata (through wine) - Bloom too bright

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102218 Nicolai Hähnle changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

2017-11-27 Thread Gert Wollny
Am Sonntag, den 26.11.2017, 18:01 -0800 schrieb Eric Anholt: > Gert Wollny writes: > > > Array who's elements are only accessed directly are replaced by the > > according number of temporary registers. By doing so the otherwise > > > reserved register range becomes subject to further optimization

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

2017-11-27 Thread Tapani Pälli
On 11/15/2017 03:22 PM, Eduardo Lima Mitev wrote: From: Alejandro Piñeiro Ideally this should be generated somehow. One option would be gather all the extension dependencies listed on the core grammar, but there would be the possibility of not including some of the extensions. Note that spir

[Mesa-dev] [PATCH mesa] util: add mesa-sha1 test to meson

2017-11-27 Thread Eric Engestrom
Fixes: 513d7ffa23d42e96f831 "util: Add a SHA1 unit test program" Signed-off-by: Eric Engestrom --- src/util/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/meson.build b/src/util/meson.build index ac86c9e111eeb89a0249..b54c20796ff01012759b 100644 --- a/src/util/m

Re: [Mesa-dev] [PATCH] docs: annotate MESA_program_debug as obsolete

2017-11-27 Thread Nicolai Hähnle
On 23.11.2017 17:56, Emil Velikov wrote: From: Emil Velikov It has been obsolete for years - state it explicitly. Signed-off-by: Emil Velikov Reviewed-by: Nicolai Hähnle --- docs/specs/OLD/MESA_program_debug.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc

Re: [Mesa-dev] [PATCH 2/2] radeonsi: remove an old hack for evergreen

2017-11-27 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 23.11.2017 20:35, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_tex

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 Thread Nicolai Hähnle
On 23.11.2017 20:35, Marek Olšák wrote: From: Marek Olšák The next commit will reduce the size even more. v2: typecast to uint64_t manually --- src/amd/common/ac_surface.c| 2 +- src/amd/common/ac_surface.h| 3 ++- src/amd/vulkan/radv_image

Re: [Mesa-dev] [PATCH v2] radeonsi: Adding tiled to linear conversion functionality

2017-11-27 Thread Nicolai Hähnle
On 24.11.2017 06:22, Satyajit Sahu wrote: Add tiled to linear conversion and expose outside mesa. This function converts tiled image to linear and vice versa. One of the use-case is, a chromiumos test case where the captured fb is compared against a reference image. As the fb is tiled mode it nee

Re: [Mesa-dev] [PATCH] glsl: Fix typo nagivation -> navigation

2017-11-27 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 25.11.2017 15:08, Gwan-gyeong Mun wrote: Signed-off-by: Mun Gwan-gyeong --- src/compiler/glsl/ir_hierarchical_visitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_hierarchical_visitor.h b/src/compiler/glsl/ir_hier

Re: [Mesa-dev] [PATCH] radeonsi: always initialize max_forced_staging_uploads

2017-11-27 Thread Nicolai Hähnle
On 24.11.2017 22:32, Marek Olšák wrote: From: Marek Olšák r600_resource is malloc'd. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103808 Could you please explain how this actually caused the mentioned bug(s)? I would have thought that it only leads to more forced staging uploads,

Re: [Mesa-dev] [PATCH] radeonsi: always initialize max_forced_staging_uploads

2017-11-27 Thread Marek Olšák
On Mon, Nov 27, 2017 at 1:02 PM, Nicolai Hähnle wrote: > On 24.11.2017 22:32, Marek Olšák wrote: >> >> From: Marek Olšák >> >> r600_resource is malloc'd. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103808 > > > Could you please explain how this actually caused the mentioned bug(s

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-27 Thread Jon Turney
On 26/11/2017 00:46, Matt Turner wrote: I've committed what I hope is the final fix. After this series, if we are building on a target unknown to u_endian.h, so it can't determine the endianess, sha1.c now builds for big-endian. This choice is made silently, but fortunately mesa-sha1_test fa

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 Thread Marek Olšák
On Mon, Nov 27, 2017 at 12:54 PM, Nicolai Hähnle wrote: > On 23.11.2017 20:35, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The next commit will reduce the size even more. >> >> v2: typecast to uint64_t manually >> --- >> src/amd/common/ac_surface.c| 2 +- >> src/a

[Mesa-dev] [PATCH mesa] i965: const a few structs and vars to avoid writing to them by accident

2017-11-27 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This is why I like to const everything ;) Feel free to push this patch when you land yours. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 Thread Gustaw Smolarczyk
2017-11-27 14:43 GMT+01:00 Marek Olšák : > On Mon, Nov 27, 2017 at 12:54 PM, Nicolai Hähnle > wrote: > > On 23.11.2017 20:35, Marek Olšák wrote: > >> > >> From: Marek Olšák > >> > >> The next commit will reduce the size even more. > >> > >> v2: typecast to uint64_t manually > >> --- > >> src/a

[Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-27 Thread Jon Turney
--- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode 100644 src/glx/windows/meson.build diff --git a/src/glx/meson.build b/src/glx/meson.build i

[Mesa-dev] [PATCH 1/7] meson: fix generated source inclusion on macOS and Windows

2017-11-27 Thread Jon Turney
From: Dylan Baker --- src/mapi/glapi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index 14ffa68ad0d..8856a95fb66 100644 --- a/src/mapi/glapi/meson.build +++ b/src/mapi/glapi/meson.build @@ -26,7 +26,7 @@ s

[Mesa-dev] [PATCH 4/7] meson: set _GNU_SOURCE on cygwin

2017-11-27 Thread Jon Turney
--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d0618f97344..cf6e028746a 100644 --- a/meson.build +++ b/meson.build @@ -467,7 +467,7 @@ if cc.compiles('int foo(void) { return 0; } int bar(void) __attribute__((alias(" endif #

[Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-27 Thread Jon Turney
--- meson.build | 6 -- src/glx/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 68361fc4606..524a03eaa97 100644 --- a/meson.build +++ b/meson.build @@ -866,7 +866,7 @@ if with_platform_x11 dep_x11 = dependency('x11'

[Mesa-dev] [PATCH 6/7] meson: don't require dri2proto for darwin or windows

2017-11-27 Thread Jon Turney
--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index cf6e028746a..68361fc4606 100644 --- a/meson.build +++ b/meson.build @@ -888,7 +888,9 @@ if with_platform_x11 endif endif if with_glx == 'dri' -dep_dri2proto = depen

[Mesa-dev] [PATCH 2/7] meson: Don't build egl on macOS or Windows

2017-11-27 Thread Jon Turney
From: Dylan Baker --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 53013e47ec4..c24225c0297 100644 --- a/meson.build +++ b/meson.build @@ -261,7 +261,10 @@ endif _egl = get_option('egl') if _egl == 'auto' - with_egl = wi

[Mesa-dev] [PATCH 3/7] meson: set windows glx defines

2017-11-27 Thread Jon Turney
--- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index c24225c0297..d0618f97344 100644 --- a/meson.build +++ b/meson.build @@ -378,6 +378,8 @@ if with_platform_x11 endif if with_dri_platform == 'drm' pre_args += '-DGLX_USE_DRM' +

[Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-27 Thread Jon Turney
This series lets me build a mesa for Cygwin configured with: -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless -Dglx=dri -Dvulkan-drivers= I'm really not sure about (2/8), the autotools build does something totally different... Dylan Baker (2): meson: fix generated source

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

2017-11-27 Thread Gert Wollny
Am Montag, den 27.11.2017, 12:14 +0100 schrieb Gert Wollny: > Am Sonntag, den 26.11.2017, 18:01 -0800 schrieb Eric Anholt: > > > > > > This looks like something that should be done with (at most) a > > small change to opt_array_splitting.cpp, rather than reimplementing > > it here. > > It seems

[Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-27 Thread Robert Foss
From: Tomasz Figa There is no API available to properly query the IMPLEMENTATION_DEFINED format. As a workaround we rely here on gralloc allocating either an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized by lock_ycbcr failing. Reviewed-on: https://chromium-review.googlesou

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 Thread Marek Olšák
On Mon, Nov 27, 2017 at 2:55 PM, Gustaw Smolarczyk wrote: > 2017-11-27 14:43 GMT+01:00 Marek Olšák : >> >> On Mon, Nov 27, 2017 at 12:54 PM, Nicolai Hähnle >> wrote: >> > On 23.11.2017 20:35, Marek Olšák wrote: >> >> >> >> From: Marek Olšák >> >> >> >> The next commit will reduce the size even m

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

2017-11-27 Thread Alejandro Piñeiro
On 27/11/17 12:21, Tapani Pälli wrote: > > > On 11/15/2017 03:22 PM, Eduardo Lima Mitev wrote: >> From: Alejandro Piñeiro >> >> Ideally this should be generated somehow. One option would be gather >> all the extension dependencies listed on the core grammar, but there >> would be the possibility

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-27 Thread Emil Velikov
IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef=true, to catch these issues as part of the build process. We already do so in the autotools, android and at least partially in scons. One would need a workaround for the s

[Mesa-dev] [PATCH] intel/blorp: Fix possible NULL pointer dereferencing

2017-11-27 Thread vadim . shovkoplias
From: Vadym Shovkoplias Fix incomplete check of input params in blorp_surf_convert_to_uncompressed() which can lead to NULL pointer dereferencing. --- src/intel/blorp/blorp_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blo

Re: [Mesa-dev] [PATCH] intel/blorp: Fix possible NULL pointer dereferencing

2017-11-27 Thread Emil Velikov
Hi Vadym, Welcome to Mesa. On 27 November 2017 at 14:41, wrote: > From: Vadym Shovkoplias > > Fix incomplete check of input params in blorp_surf_convert_to_uncompressed() > which can lead to NULL pointer dereferencing. Nicely spotted. Fortunately, all the callers do the sane thing so in practi

Re: [Mesa-dev] [PATCH 06/14] intel/blorp: Add initial support for indirect clear colors

2017-11-27 Thread Jason Ekstrand
On Wed, Nov 22, 2017 at 12:57 PM, Nanley Chery wrote: > On Mon, Nov 13, 2017 at 08:12:46AM -0800, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp.c | 1 + > > src/intel/blorp/blorp.h | 7 +++ > > src/intel/blorp/blorp_genX_exec.h | 77 >

[Mesa-dev] [Bug 93723] vblank_mode=3 segfaults SynMark2 EGL versions to: intelDestroyContext() -> _mesa_meta_free() -> _mesa_make_current()

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93723 Eero Tamminen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 93723] vblank_mode=3 segfaults SynMark2 EGL versions to: intelDestroyContext() -> _mesa_meta_free() -> _mesa_make_current()

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93723 Eero Tamminen changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail

[Mesa-dev] [PATCH] util: hash_table: move NULL assert to string hashing function

2017-11-27 Thread Lionel Landwerlin
Hash maps might use pointer keys (which people surely might want to use to hash values) in which case a 0 value is perfectly acceptable. It's only if the hash function needs to deference the pointer that we want to be sure it's not NULL. Signed-off-by: Lionel Landwerlin --- src/util/hash_table.c

Re: [Mesa-dev] [PATCH 04/14] intel/blorp: Add fast-clear to the special case in MSAA resolves

2017-11-27 Thread Nanley Chery
On Mon, Nov 13, 2017 at 08:12:44AM -0800, Jason Ekstrand wrote: > This doesn't go all the way of avoiding the txf_ms if it's fast-cleared, > however it does at least make us only do it once. This should improve > performance of MSAA resolves in the presence of lots of clear color. > Without the pa

[Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-27 Thread Juan A. Suarez Romero
Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. But actually it is a 64-bit integer, and as such it is used in other parts of Mesa code. It is worth to note that bits from the entire range are used, and not only

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Eric Engestrom
On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > Signed-off-by: Eric Engestrom > > --- > >  src/util/ralloc.c | 18 +- > >  src/util/slab.c   |  4 ++-- > >  2 files changed, 11 insertions(+), 11 deletion

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-27 Thread Matt Turner
On Mon, Nov 27, 2017 at 5:41 AM, Jon Turney wrote: > On 26/11/2017 00:46, Matt Turner wrote: >> >> I've committed what I hope is the final fix. > > > After this series, if we are building on a target unknown to u_endian.h, so > it can't determine the endianess, sha1.c now builds for big-endian. >

Re: [Mesa-dev] [PATCH] mesa: deal with vs_inputs as 64-bit unsigned integer

2017-11-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 27, 2017 at 6:37 PM, Juan A. Suarez Romero wrote: > Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses > vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer. > > But actually it is a 64-bit integer, and as such it is used

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Nanley Chery
Ping. -Nanley On Mon, Nov 20, 2017 at 05:18:12PM -0800, Nanley Chery wrote: > On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote: > > On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote: > > > > > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > > > > On Mon, Nov 20

Re: [Mesa-dev] [PATCH mesa] util: add mesa-sha1 test to meson

2017-11-27 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 12/16] compiler: use NDEBUG to guard asserts

2017-11-27 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 13/16] compiler: fix typo

2017-11-27 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

2017-11-27 Thread Dylan Baker
This seems reasonable, Reviewed-by: Dylan Baker Quoting Emil Velikov (2017-11-24 06:25:03) > From: Emil Velikov > > Analogous to the other build systems. > > Cc: Eric Engestrom > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > meson.build | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Nanley Chery
On Mon, Nov 20, 2017 at 05:18:12PM -0800, Nanley Chery wrote: > On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote: > > On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote: > > > > > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > > > > On Mon, Nov 20, 2017 at 2:10 P

Re: [Mesa-dev] [PATCH 04/51] glsl: Print 16-bit constants

2017-11-27 Thread Matt Turner
On 11/24, Topi Pohjolainen wrote: --- src/compiler/glsl/ir_print_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index ea14cdeb6c..ab9a35d73f 100644 --- a/src/compiler/glsl/ir_print_visitor.cpp +++ b/s

Re: [Mesa-dev] [PATCH 01/51] nir: Prepare constant folding for 16-bits

2017-11-27 Thread Matt Turner
On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/nir/nir_opt_constant_folding.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_opt_constant_folding.c b/src/compiler/nir/nir_opt_constant_folding.c index d6be807b3d..b63660ea4d 100644 --

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-27 Thread Dylan Baker
Quoting Jon Turney (2017-11-27 05:58:32) > --- > src/glx/meson.build | 25 +-- > src/glx/windows/meson.build | 48 > + > 2 files changed, 63 insertions(+), 10 deletions(-) > create mode 100644 src/glx/windows/meson.build >

Re: [Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-27 Thread Dylan Baker
I had a few comments on the "build src/glx/windows" patch, but the rest of the patches are: Reviewed-by: Dylan Baker Quoting Jon Turney (2017-11-27 05:58:27) > This series lets me build a mesa for Cygwin configured with: > > -Ddri-drivers=swrast -Dgallium-drivers= -Dplatforms=x11,surfaceless >

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

2017-11-27 Thread Dylan Baker
Although now that I think about it, meson does have a b_undef option, so actually the right way to do this is to add 'b_undef=true' to the default options in the project() call. Sorry for the confusion, Dylan Quoting Dylan Baker (2017-11-27 10:22:40) > This seems reasonable, > Reviewed-by: Dylan

Re: [Mesa-dev] [PATCH mesa 02/16] anv: tie anv_assert() enablement to regular assert()

2017-11-27 Thread Eric Engestrom
On Sunday, 2017-11-26 10:12:46 +1100, Timothy Arceri wrote: > On 25/11/17 08:02, Timothy Arceri wrote: > > On 25/11/17 05:07, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > --- > > >   src/intel/vulkan/anv_private.h | 2 +- > > >   1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

2017-11-27 Thread Dylan Baker
Quoting Dylan Baker (2017-11-27 10:40:18) > Although now that I think about it, meson does have a b_undef option, so > actually the right way to do this is to add > 'b_undef=true' to the default options in the project() call. > > Sorry for the confusion, > > Dylan > And I can't read documentati

Re: [Mesa-dev] [PATCH 04/51] glsl: Print 16-bit constants

2017-11-27 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 11:40:49AM -0800, Matt Turner wrote: > On 11/24, Topi Pohjolainen wrote: > > --- > > src/compiler/glsl/ir_print_visitor.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/compiler/glsl/ir_print_visitor.cpp > > b/src/compiler/glsl/ir_print_visitor.cpp > >

Re: [Mesa-dev] [PATCH 01/51] nir: Prepare constant folding for 16-bits

2017-11-27 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 11:42:53AM -0800, Matt Turner wrote: > On 11/24, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/compiler/nir/nir_opt_constant_folding.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/compiler/nir/nir_opt_constant_folding.c

Re: [Mesa-dev] [PATCH 07/51] glsl: Add conversion ops to/from 16-bit floats

2017-11-27 Thread Matt Turner
On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/glsl_to_nir.cpp| 2 ++ src/compiler/glsl/ir.cpp | 8 src/compiler/glsl/ir_expression_operation.py | 5 + src/compiler/glsl/ir_validate.cpp| 8 src

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-27 09:46:57) > On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > > Signed-off-by: Eric Engestrom > > > --- > > >  src/util/ralloc.c | 18 +- > > >  src/util/slab.c   |  4

Re: [Mesa-dev] [PATCH 09/51] glsl: Allow 16-bit neg() and dot()

2017-11-27 Thread Matt Turner
On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/ir_validate.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index a20f52e527..735e862141 100644 --- a/src

Re: [Mesa-dev] [PATCH 10/51] glsl: Allow 16-bit math

2017-11-27 Thread Matt Turner
On 11/24, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/compiler/glsl/ir_validate.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index 735e862141..d246af866d 100644 --- a/src/c

[Mesa-dev] [PATCH v2 1/2] util/srgb: Add a float sRGB -> linear helper

2017-11-27 Thread Nanley Chery
From: Jason Ekstrand Reviewed-by: Nanley Chery --- src/util/format_srgb.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h index 34b50afe3d..596af56f4c 100644 --- a/src/util/format_srgb.h +++ b/src/util/format_srgb.h @@ -54,6 +5

[Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Nanley Chery
When sampling from fast-cleared sRGB textures on gen10, the hardware will not decode the clear color to linear. We must therefore do it in software. This makes the following piglit tests pass: * spec@arb_framebuffer_srgb@arb_framebuffer_srgb-fast-clear-blend * spec@arb_framebuffer_srgb@fbo-fast-cl

Re: [Mesa-dev] i965: Kicking off fp16 glsl support

2017-11-27 Thread Matt Turner
1-14, except 4 are Reviewed-by: Matt Turner I started getting to things that made me realize I needed to review Igalia's work before I continued here. signature.asc Description: Digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] Android: disable warnings causing errors

2017-11-27 Thread Rob Herring
AOSP master has changed the build default to -Werror making all the warnings errors. Override that with -Wno-error. Signed-off-by: Rob Herring --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index 5671c1c1a595..fcd9a874d538 100644 -

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Roland Scheidegger
If you use a float input color, does it mean it isn't quantized? I'm just wondering if you actually get (slightly) different values with sampling from fast-cleared surfaces than you'd get when you'd have cleared the surface normally. In any case, patch 1/2 of this series looks alright (I was just w

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Nanley Chery
On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote: > When sampling from fast-cleared sRGB textures on gen10, the hardware > will not decode the clear color to linear. We must therefore do it in > software. > > This makes the following piglit tests pass: > * spec@arb_framebuffer_srgb@arb

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-27 Thread Rob Herring
On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss wrote: > From: Tomasz Figa > > There is no API available to properly query the IMPLEMENTATION_DEFINED > format. As a workaround we rely here on gralloc allocating either > an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized > by loc

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Jason Ekstrand
On Mon, Nov 27, 2017 at 11:02 AM, Nanley Chery wrote: > When sampling from fast-cleared sRGB textures on gen10, the hardware > will not decode the clear color to linear. We must therefore do it in > software. > > This makes the following piglit tests pass: > * spec@arb_framebuffer_srgb@arb_frameb

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Jason Ekstrand
On Mon, Nov 27, 2017 at 11:41 AM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote: > > When sampling from fast-cleared sRGB textures on gen10, the hardware > > will not decode the clear color to linear. We must therefore do it in > > software. > > > > This makes

[Mesa-dev] [PATCH 0/2] docs/llvmpipe.html: Add PPC64LE

2017-11-27 Thread Ben Crocker
IBM PPC64LE (Power8, Power8NV, and Power9) are supported on an equal footing with X86. Ben Crocker (2): docs/llvmpipe.html: Add ppc64le as alternative architecture to x86. docs/llvmpipe.html: Minor edits docs/llvmpipe.html | 30 +- 1 file changed, 21 insertions(+)

Re: [Mesa-dev] [PATCH v2 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

2017-11-27 Thread Jason Ekstrand
On Mon, Nov 27, 2017 at 11:37 AM, Roland Scheidegger wrote: > If you use a float input color, does it mean it isn't quantized? > I'm just wondering if you actually get (slightly) different values with > sampling from fast-cleared surfaces than you'd get when you'd have > cleared the surface norma

[Mesa-dev] [PATCH 2/2] docs/llvmpipe.html: Minor edits

2017-11-27 Thread Ben Crocker
Language and spelling fixups in three places. Cc: "17.2" "17.3" Signed-off-by: Ben Crocker --- docs/llvmpipe.html | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 5f93c0b807..a36a31ece3 100644 --- a/docs/llvmpipe.html +

[Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

2017-11-27 Thread Ben Crocker
Power8, Power8NV, and Power9 are supported on an equal footing with X86. Cc: "17.2" "17.3" Signed-off-by: Ben Crocker --- docs/llvmpipe.html | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 12dccb5eae..5f93c0

Re: [Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

2017-11-27 Thread Matt Turner
On Mon, Nov 27, 2017 at 11:44 AM, Ben Crocker wrote: > Power8, Power8NV, and Power9 are supported on an equal footing > with X86. > > Cc: "17.2" "17.3" > Signed-off-by: Ben Crocker > --- > docs/llvmpipe.html | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff

Re: [Mesa-dev] i965: Kicking off fp16 glsl support

2017-11-27 Thread Chema Casanova
El 27/11/17 a las 21:11, Matt Turner escribió: > 1-14, except 4 are > > Reviewed-by: Matt Turner > > I started getting to things that made me realize I needed to review > Igalia's work before I continued here. I'm submitting tomorrow the v4 for our VK_KHR_16bit_storage series. So better have a lo

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

2017-11-27 Thread Ian Romanick
On 11/20/2017 06:04 PM, Roland Scheidegger wrote: > Am 21.11.2017 um 01:40 schrieb Ian Romanick: >> On 11/20/2017 04:07 PM, Miklós Máté wrote: >>> This fixes crash when: >>> - first pass begins with alpha inst >>> - first pass ends with color inst, second pass begins with alpha inst >>> >>> Also, u

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-27 Thread Ian Romanick
On 11/21/2017 04:22 PM, Miklós Máté wrote: > On 21/11/17 02:09, Ian Romanick wrote: >> On 11/20/2017 04:07 PM, Miklós Máté wrote: >>> This patch fixes multiple problems: >>> - the interpolator check was duplicated >>> - both had arg instead of argRep >>> - I split it into color and alpha for better

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

2017-11-27 Thread Ian Romanick
On 11/27/2017 10:46 AM, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-27 09:46:57) >> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: >>> Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: Signed-off-by: Eric Engestrom ---  src/util/ralloc.c | 18 +

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-11-27 Thread Robert Foss
Hey Rob, On Mon, 2017-11-27 at 13:42 -0600, Rob Herring wrote: > On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss om> wrote: > > From: Tomasz Figa > > > > There is no API available to properly query the > > IMPLEMENTATION_DEFINED > > format. As a workaround we rely here on gralloc allocating either

Re: [Mesa-dev] [PATCH] util: hash_table: move NULL assert to string hashing function

2017-11-27 Thread Ian Romanick
On 11/27/2017 08:27 AM, Lionel Landwerlin wrote: > Hash maps might use pointer keys (which people surely might want to > use to hash values) in which case a 0 value is perfectly acceptable. > It's only if the hash function needs to deference the pointer that we > want to be sure it's not NULL. > >

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Ideally this should be generated somehow. One option would be gather > all the extension dependencies listed on the core grammar, but there > would be the possibility of not including some of the extensions. > > Note

Re: [Mesa-dev] [PATCH 12/24] spirv_extensions: define spirv_extensions_supported

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Add a struct to maintain which SPIR-V extensions are supported, and an > utility method to initialize it based on > nir_spirv_supported_capabilities. > --- > src/compiler/spirv/spirv_extensions.c | 29 +++

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

2017-11-27 Thread Roland Scheidegger
Am 27.11.2017 um 21:29 schrieb Ian Romanick: > On 11/20/2017 06:04 PM, Roland Scheidegger wrote: >> Am 21.11.2017 um 01:40 schrieb Ian Romanick: >>> On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst

Re: [Mesa-dev] [PATCH] mesa/st: glsl_to_tgsi: Dissolve arrays who's elements are only accessed directly

2017-11-27 Thread Timothy Arceri
On 28/11/17 01:01, Gert Wollny wrote: Am Montag, den 27.11.2017, 12:14 +0100 schrieb Gert Wollny: Am Sonntag, den 26.11.2017, 18:01 -0800 schrieb Eric Anholt: This looks like something that should be done with (at most) a small change to opt_array_splitting.cpp, rather than reimplementing i

Re: [Mesa-dev] [PATCH] glsl: Fix typo nagivation -> navigation

2017-11-27 Thread Timothy Arceri
On 27/11/17 23:02, Nicolai Hähnle wrote: Reviewed-by: Nicolai Hähnle Pushed. Thanks! On 25.11.2017 15:08, Gwan-gyeong Mun wrote: Signed-off-by: Mun Gwan-gyeong ---   src/compiler/glsl/ir_hierarchical_visitor.h | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compi

Re: [Mesa-dev] [PATCH] mesa/gles: adjust internal format in glTexSubImage2D error checks

2017-11-27 Thread Matt Turner
Thanks Tapani. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-27 Thread Adam Jackson
On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: > Hi everybody, > > Mario, feel free to push your patches if you haven't yet. (except the > workaround) > > For AMD, I applied Mario's patches (except Wayland - that didn't > apply) and added initial Gallium support: > https://cgit.freedesktop

Re: [Mesa-dev] [PATCH 09/24] i965: initialize SPIR-V capabilities

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Needed for ARB_gl_spirv. Right now those are the same that the intel > vulkan driver, but those are not shared. From the ARB_spirv_extensions > spec: > >"3. If a new GL extension is added that includes SPIR-V sup

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 5:01 PM, Adam Jackson wrote: > On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: >> Hi everybody, >> >> Mario, feel free to push your patches if you haven't yet. (except the >> workaround) >> >> For AMD, I applied Mario's patches (except Wayland - that didn't >> apply)

Re: [Mesa-dev] [PATCH 07/24] spirv_extensions: rename nir_spirv_supported_extensions

2017-11-27 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Renamed to nir_spirv_supported_capabilities. > > The original name seemed to suggest that it was directly related to > the SPIR-V extensions supported, but that is not the c

Re: [Mesa-dev] [PATCH 12/24] spirv_extensions: define spirv_extensions_supported

2017-11-27 Thread Ian Romanick
On 11/27/2017 01:25 PM, Ian Romanick wrote: > On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: >> From: Alejandro Piñeiro >> >> Add a struct to maintain which SPIR-V extensions are supported, and an >> utility method to initialize it based on >> nir_spirv_supported_capabilities. >> --- >> src/co

Re: [Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > --- > src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 2 ++ > src/mesa/Makefile.sources

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

2017-11-27 Thread Adam Jackson
On Thu, 2017-11-23 at 16:32 +, Emil Velikov wrote: > On 23 November 2017 at 16:04, Eric Engestrom > wrote: > > On Thursday, 2017-11-23 13:32:47 +, Emil Velikov wrote: > > > > > > > - GLX_MESA_release_buffers > > > > > > Extension is implemented only for Xlib based libGL. The DRI codepat

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

2017-11-27 Thread Ian Romanick
On 11/27/2017 02:15 PM, Ian Romanick wrote: > On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: >> From: Nicolai Hähnle >> >> --- >> src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ >> src/mapi/glapi/gen/Makefile.am | 1 + >> src/mapi/glapi/gen/gl_API.xml | 4 +++

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > --- > src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 4 +++ > src/mapi/glapi/gen/gl_genexec.py| 1 + >

Re: [Mesa-dev] [PATCH 03/24] mesa: refuse to compile SPIR-V shaders or link mixed shaders

2017-11-27 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > Note that gl_shader::CompileStatus will also indicate whether a shader > has been successfully specialized. > --- > src/mesa/main/shaderapi.c | 12 > src/mes

Re: [Mesa-dev] [PATCH 04/24] mesa/glspirv: Add struct gl_spirv_module

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > v2: Make the SPIR-V module struct part of a larger gl_shader_spirv_data > struct that will be introduced later, and don't reference it directly > in gl_shader. (Eduardo Lima) > --- > src/mesa/main/glspirv.c | 19

Re: [Mesa-dev] [PATCH 05/24] mesa/glspirv: Add struct gl_shader_spirv_data

2017-11-27 Thread Ian Romanick
On 11/15/2017 05:22 AM, Eduardo Lima Mitev wrote: > This is a per-shader structure holding the SPIR-V data associated with the > shader (binary module, specialization constants and entry-point). > > This is needed because both gl_shader and gl_linked_shader need to share this > data. Instead of co

  1   2   >