Re: [Mesa-dev] [Mesa-stable] [PATCH] gallium/winsys/kms: fix leaking gem handle.

Thanks for your review. I got some reply from somebody eles that these functions actually doesn't work with mainline kernel and it's supposed to work with modified kernel on chrome os. So perhaps a right fix should be still on kernel side instead of mesa side. So I will draw back this now. Here is

[Mesa-dev] [PATCH 03/15] st/glsl_to_nir: use nir_lower_io_arrays_to_elements() to lower arrays

This pass is more fully featured, it supports geom and tess shaders. It also supports interpolation intrinsics. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH 02/15] nir: allow builin arrays to be lowered

Galliums nir drivers expect this to be done. --- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c b/src/compiler/nir/nir_lower_io_arrays_to_elements.c index

[Mesa-dev] [PATCH 04/15] st/glsl_to_nir: add gs support to st_nir_assign_var_locations()

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index af6b6e2607..d1cd2ec3ab 100644 --- a/src/mesa/state_tracker/st_glsl

[Mesa-dev] V2 Initial GS NIR support for radeonsi

This series depends on [1] and [2]. V2 - use driver_location as per Nicolais suggestion - tidy ups as per Mareks suggestions - bug fixes (many more piglit tests now passing) [1] https://patchwork.freedesktop.org/series/34131/ [2] https://patchwork.freedesktop.org/series/34132/ ___

[Mesa-dev] [PATCH 07/15] radeonsi: add nir support for gs epilogue

v2: add emit_gs_epilogue() helper function to reduce duplication. --- src/gallium/drivers/radeonsi/si_shader.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 8

[Mesa-dev] [PATCH 01/15] nir: add array lowering function that assumes there are no indirects

The gallium glsl->nir pass currently lowers away all indirects on both inputs and outputs. This fuction allows us to lower vs inputs and fs outputs and also lower things one stage at a time as we don't need to worry about indirects on the other side of the shaders interface. --- src/compiler/nir/n

[Mesa-dev] [PATCH 05/15] radeonsi: add nir support for ls epilogue

v2: make use of existing si_tgsi_emit_epilogue() --- src/gallium/drivers/radeonsi/si_shader.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e6b14f9205..d

[Mesa-dev] [PATCH 14/15] ac: add si_nir_load_input_gs() to the abi

V2: make use of driver_location and don't expose NIR to the ABI. --- src/amd/common/ac_nir_to_llvm.c | 39 +++ src/amd/common/ac_shader_abi.h| 9 ++ src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 13/15] ac: move build_varying_gather_values() to ac_llvm_build.h and expose

--- src/amd/common/ac_llvm_build.c | 22 ++ src/amd/common/ac_llvm_build.h | 4 src/amd/common/ac_nir_to_llvm.c | 34 ++ 3 files changed, 32 insertions(+), 28 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_l

[Mesa-dev] [PATCH 06/15] radeonsi: add nir support for es epilogue

v2: make use of existing si_tgsi_emit_epilogue() --- src/gallium/drivers/radeonsi/si_shader.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index defe833c30..8

[Mesa-dev] [PATCH 08/15] radeonsi: pass llvm type to si_llvm_emit_fetch_64bit()

v2: use LLVMBuildBitCast() directly --- src/gallium/drivers/radeonsi/si_shader.c| 11 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 2 +- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 17 ++--- 3 files changed, 18 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH 09/15] radeonsi: add llvm_type_is_64bit() helper

--- src/gallium/drivers/radeonsi/si_shader.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0df9454edb..c68ffad8ea 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gallium/driver

[Mesa-dev] [PATCH 15/15] radeonsi: enable gs support for nir backend

--- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 -- src/mesa/state_tracker/st_glsl_to_nir.cpp| 12 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gal

[Mesa-dev] [PATCH 10/15] radeonsi: pass llvm type to lds_load()

v2: use LLVMBuildBitCast() directly --- src/gallium/drivers/radeonsi/si_shader.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index c68ffad8ea..ce90c7beb5 100644 ---

[Mesa-dev] [PATCH 11/15] radeonsi: create si_llvm_load_input_gs()

This creates a common function that can be shared by the tgsi and nir backends. v2: use LLVMBuildBitCast() directly --- src/gallium/drivers/radeonsi/si_shader.c | 61 ++- src/gallium/drivers/radeonsi/si_shader_internal.h | 6 +++ 2 files changed, 44 insertions(+), 23

[Mesa-dev] [PATCH 12/15] ac: add basic nir -> llvm type helper

--- src/amd/common/ac_nir_to_llvm.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1ecdeca063..a38db0c9b7 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -151,

Re: [Mesa-dev] [PATCH 15/15] radeonsi: enable gs support for nir backend

On 22/11/17 21:30, Timothy Arceri wrote: --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 -- src/mesa/state_tracker/st_glsl_to_nir.cpp| 12 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH mesa] genxml: fix assert guards

This removes a few hundred warnings on debug builds with asserts off. Signed-off-by: Eric Engestrom --- src/intel/genxml/gen_pack_header.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py in

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

On Tuesday, 2017-11-21 10:50:29 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-21 10:38:25) > > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > > > This is still not fully correct (haiku and BSD is notably probably not > > > correct), but Linux is not regressed and this sho

Re: [Mesa-dev] [PATCH 15/15] radeonsi: enable gs support for nir backend

On Wed, Nov 22, 2017 at 5:30 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- > src/gallium/drivers/radeonsi/si_shader_nir.c | 10 -- > src/mesa/state_tracker/st_glsl_to_nir.cpp| 12 > 3 files changed, 22 insertions(+), 3 deletions(

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

Hi Wladimir, Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > The blob does this, as DRAW_INSTANCED can replace fully all the other > draw commands. It is also required to handle integer vertex formats. > The other path is only there for compatibility and might go away (

Re: [Mesa-dev] [PATCH v2 02/17] etnaviv: Put HALTI level in specs

I've pushed the first 2 patches of this series to upstream, as they look fine, have seen enough review and I want to have them out of the way should we need another rev of the series. Regards, Lucas Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > The HALTI level is an

Re: [Mesa-dev] [PATCH v2 05/17] etnaviv: GC7000: Support BLT as recipient for etna_stall

2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan : > When the BLT is involved as source or target, add an extra BLT > enable/disable sequence around the sync sequence. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_emit

Re: [Mesa-dev] [PATCH v2 07/17] etnaviv: GC7000: Factor out RS blit functionality

2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan : > Prepare for BLT-based blitting path by moving RS-based > blitting to the RS implementation file, making this > self-contained. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/

Re: [Mesa-dev] [PATCH v2 08/17] etnaviv: GC7000: BLT engine blitting support

2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan : > Add an implemenation of key clear_blit functions using the BLT engine > that replaced the RS on GC7000. > > Also set level->size correctly for imported resources. This is important > for the BLT resolve-in-place path to work for them. > > Sign

[Mesa-dev] [PATCH 0/2] Fix radeonsi and freedreno for the BaseVertex patches

Here are two bonus patches to address the problems mentioned that it might break radeonsi and freedreno. The radeonsi patch doesn’t solve the problem that the value for gl_BaseVertex is presumably wrong, but it at least should stop it from breaking gl_VertexID entirely. I haven’t been able to test

[Mesa-dev] [PATCH 1/2] freedreno: Update to handle rename of the base vertex ID intrinsic

The old intrinsic called base_vertex that is used to add to gl_VertexID is now called base_vertex_id so that base_vertex can be used for the value of gl_BaseVertex, which is different. As far as I can tell freedreno doesn’t support GL_ARB_shader_draw_parameters so it won’t need any changes to gener

[Mesa-dev] [PATCH 2/2] st/glsl_to_tgsi: Add support for SYSTEM_VALUE_BASE_VERTEX_ID

SYSTEM_VALUE_BASE_VERTEX has changed to be the correct value for gl_BaseVertex, which means it will be zero when used with a non-indexed call. The new BASE_VERTEX_ID value can be used as before as an offset to calculate a value for gl_VertexID. These values should be different, but this patch just

[Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

It is useful for staging/shadow transfers for drivers to be able to blit BUFFERs. Treat them as R8 1D textures for this purpose. Signed-off-by: Rob Clark --- This works at least if 1D textures are linear, so I suppose might not work for all drivers. Although I'm not entirely sure what the point

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

Are you sure you're not looking for resource_copy_region? BUFFERs can be wide (128MB in many impls), 1D textures can't. There are probably other differences. On Wed, Nov 22, 2017 at 9:43 AM, Rob Clark wrote: > It is useful for staging/shadow transfers for drivers to be able to blit > BUFFERs. Tr

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

yes, because that ends up being a cpu copy for BUFFER (ie. stall), which is what I'm trying to avoid in the first place ;-) Maybe this needs to map things to a linear 2d buffer for larger sizes, not sure. One way or another at the hw level this gets treated like a 2d render target (which might ha

[Mesa-dev] [PATCH] Revert "radv: remove unnecessary memset() in radv_AllocateCommandBuffers()"

This fixes two CTS regressions: - dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary - dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary These two tests are part the mustpass lists, so presumably they are correct and my change was

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

I don't think this is a good idea. 1D and buffer resources are fundamentally incompatible, it is highly illegal to use targets in views which are incompatible, so I'd rather not see such atrocities in shared code. I think you really want to fix up your resource_copy_region implementation one way or

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

So, I could potentially do this for a5xx, which actually has a sort of blit engine. But for earlier gen's, everything is a glDraw(), and I don't want to duplicate the functionality of u_blitter. I suppose I could bypass util_blitter_blit() and use util_blitter_blit_generic() directly.. BR, -R O

[Mesa-dev] [PATCH] radeonsi: try flushing unflushed fences in si_fence_finish even when timeout == 0

From: Nicolai Hähnle Under certain conditions, waiting on a GL sync objects should act like a flush, regardless of the timeout. Portal 2, CS:GO, and presumably other Source engine games rely on this behavior and hang during loading without this fix. Fixes: bc65dcab3bc4 ("radeonsi: avoid syncing

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

On Tuesday, 2017-11-21 11:24:48 -0800, Jordan Justen wrote: > On 2017-11-21 05:45:36, Eric Engestrom wrote: > > On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > > > Similar idea to Tim's "spec: MESA_program_binary", but simplified and > > > written to support both ARB_get_program_binary

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

Hello Lucas, On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote: > Hi Wladimir, > > Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > > The blob does this, as DRAW_INSTANCED can replace fully all the other > > draw commands. It is also required to handle integer

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

Am Mittwoch, den 22.11.2017, 18:16 +0100 schrieb Wladimir J. van der Laan: > Hello Lucas, > > On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote: > > Hi Wladimir, > > > > Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > > > The blob does this, as DRAW_INSTANCED

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

I don't have anything against driver-specific hacks in u_blitter, because it already contains a lot of that, although separated in special functions. For buffer blitting, I recommend using DMA. Your hw should have it, because it's roughly based on radeon, which has had CP DMA since r200. If not,

Re: [Mesa-dev] [RFC] gallium/u_blitter: support blitting PIPE_BUFFERs

Am 22.11.2017 um 16:56 schrieb Rob Clark: > So, I could potentially do this for a5xx, which actually has a sort of > blit engine. But for earlier gen's, everything is a glDraw(), and I > don't want to duplicate the functionality of u_blitter. > > I suppose I could bypass util_blitter_blit() and u

Re: [Mesa-dev] [PATCH] radeonsi: try flushing unflushed fences in si_fence_finish even when timeout == 0

Reviewed-by: Marek Olšák Marek On Wed, Nov 22, 2017 at 5:52 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Under certain conditions, waiting on a GL sync objects should act like > a flush, regardless of the timeout. > > Portal 2, CS:GO, and presumably other Source engine games rely on th

[Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

A recent thread [1] made me check our local specs to see which ones were upstream. This series removes the ones that are identical upstream (modulo "TBD" extension numbers in some cases). There are a few more specs left that are upstream, but have typo fixes that I'm going to submit to Khronos, an

[Mesa-dev] [PATCH mesa 2/7] docs/specs: remove upstreamed spec MESA_image_dma_buf_export

Spec is now available on Khronos: https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_image_dma_buf_export.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_image_dma_buf_export.txt | 147 --- 1 file changed, 147 deletions(-) delete mode 100644 docs/spe

[Mesa-dev] [PATCH mesa 1/7] docs/specs: remove upstreamed spec EGL_MESA_platform_surfaceless

Spec is now available on Khronos: https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_surfaceless.txt Signed-off-by: Eric Engestrom --- docs/specs/EGL_MESA_platform_surfaceless.txt | 120 --- 1 file changed, 120 deletions(-) delete mode 100644 docs/spe

[Mesa-dev] [PATCH mesa 3/7] docs/specs: remove upstreamed spec MESA_shader_integer_functions

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/MESA_shader_integer_functions.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_shader_integer_functions.txt | 522 --- 1 file changed, 522 deletions(-) delete mode 100644 docs/

[Mesa-dev] [PATCH mesa 7/7] docs/specs: remove upstreamed spec MESA_set_3dfx_mode

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_set_3dfx_mode.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_set_3dfx_mode.spec | 85 -- 1 file changed, 85 deletions(-) delete mode 100644 docs/specs/ME

[Mesa-dev] [PATCH mesa 6/7] docs/specs: remove upstreamed spec MESA_pixmap_colormap

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_pixmap_colormap.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_pixmap_colormap.spec | 90 1 file changed, 90 deletions(-) delete mode 100644 docs/specs/

[Mesa-dev] [PATCH mesa 5/7] docs/specs: remove upstreamed spec MESA_agp_offset

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_agp_offset.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_agp_offset.spec | 95 - 1 file changed, 95 deletions(-) delete mode 100644 docs/specs/MESA_

[Mesa-dev] [PATCH mesa 4/7] docs/specs: remove upstreamed spec EXT_shader_integer_mix

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_shader_integer_mix.txt Signed-off-by: Eric Engestrom --- docs/specs/EXT_shader_integer_mix.spec | 138 - 1 file changed, 138 deletions(-) delete mode 100644 docs/specs/EX

Re: [Mesa-dev] [PATCH mesa] genxml: fix assert guards

On Wednesday, November 22, 2017 3:11:22 AM PST Eric Engestrom wrote: > This removes a few hundred warnings on debug builds with asserts off. > > Signed-off-by: Eric Engestrom > --- > src/intel/genxml/gen_pack_header.py | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) #ifndef N

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On 2017-11-22 09:59:34, Eric Engestrom wrote: > A recent thread [1] made me check our local specs to see which ones were > upstream. This series removes the ones that are identical upstream > (modulo "TBD" extension numbers in some cases). While I don't have too strong of an opinion on it, I think

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

> I would really like to know what's wrong with this patch, as using the > new draw command should be fine on GC3000 and we certainly want to > support instanced drawing at some point. Did you also apply the "etnaviv: Emit SCALE for vertex attributes" patch? If so maybe there's something wrong w

Re: [Mesa-dev] [PATCH 2/9] ac: change legacy_surf_level::slice_size to dword units

On 21.11.2017 18:30, Marek Olšák wrote: From: Marek Olšák The next commit will reduce the size even more. --- src/amd/common/ac_surface.c| 2 +- src/amd/common/ac_surface.h| 2 +- src/amd/vulkan/radv_image.c| 8 -

Re: [Mesa-dev] [PATCH 9/9] radeonsi: expose all CB performance counters on Stoney

Patches 3-9: Reviewed-by: Nicolai Hähnle On 21.11.2017 18:30, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH 1/9] ac: pack ac_surface better

On 21.11.2017 18:30, Marek Olšák wrote: From: Marek Olšák r600_texture: 1736 -> 1488 bytes --- src/amd/common/ac_surface.h | 9 + src/gallium/drivers/r600/r600_texture.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 12 ++-- 3 files changed, 12 inser

Re: [Mesa-dev] [PATCH 12/12] gallium/hud: add HUD sharing within a context share group

On 21.11.2017 18:46, Marek Olšák wrote: From: Marek Olšák This is needed for profiling multi-context applications like Chrome. One context can record queries and another context can draw the HUD. --- src/gallium/auxiliary/hud/hud_context.c | 103 +++ src/gallium/

Re: [Mesa-dev] [PATCH 00/20] Mesa: Reducing sizes of gl_context etc.

On 21.11.2017 19:01, Marek Olšák wrote: Hi, This series reduces sizes of many driver structures. For example: gl_context: 152488 -> 72944 bytes vbo_context: 22696 -> 20008 bytes st_context: 10120 -> 3704 bytes The idea is to decrease CPU cache usage on smaller CPUs. I have not noticed a perfo

[Mesa-dev] [PATCH 2/2] radv/winsys: improve error messages when the buffer list creation failed

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index 67dc4a8ccc..e5ea312aee 100644 --- a/sr

[Mesa-dev] [PATCH 1/2] radv/winsys: do not try to create a BO list with 0 buffers

This happens when all BOs have the RADEON_FLAG_NO_INTERPROCESS_SHARING (DRM version >= 3.23) flag set. This flag is mainly used for reducing overhead on the userspace side because we don't have to put those BOs inside the list. Though, if the driver tries to create a list with 0 buffers inside it,

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

Jordan Justen writes: > On 2017-11-22 09:59:34, Eric Engestrom wrote: >> A recent thread [1] made me check our local specs to see which ones were >> upstream. This series removes the ones that are identical upstream >> (modulo "TBD" extension numbers in some cases). > > While I don't have too str

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

Quoting Eric Engestrom (2017-11-22 03:16:17) > On Tuesday, 2017-11-21 10:50:29 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-21 10:38:25) > > > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > > > > This is still not fully correct (haiku and BSD is notably probably not >

Re: [Mesa-dev] [PATCH 11/12] spirv: Generate code to track SPIR-V capability dependencies

On 11/21/2017 03:29 AM, Eric Engestrom wrote: > On Monday, 2017-11-20 17:24:09 -0800, Ian Romanick wrote: >> diff --git a/src/compiler/Makefile.spirv.am b/src/compiler/Makefile.spirv.am >> index 9841004..4bc684a 100644 >> --- a/src/compiler/Makefile.spirv.am >> +++ b/src/compiler/Makefile.spirv.am

Re: [Mesa-dev] [PATCH 12/12] spirv: Generate SPIR-V builder infrastructure

On 11/21/2017 03:56 AM, Eric Engestrom wrote: >> diff --git a/src/compiler/Makefile.spirv.am b/src/compiler/Makefile.spirv.am >> index 4bc684a..dc3c01c 100644 >> --- a/src/compiler/Makefile.spirv.am >> +++ b/src/compiler/Makefile.spirv.am >> @@ -20,13 +20,17 @@ >> # FROM, OUT OF OR IN CONNECTION W

Re: [Mesa-dev] [PATCH 11/12] spirv: Generate code to track SPIR-V capability dependencies

With the one thing Eric pointed out changed, this patch and the next one are: Reviewed-by: Dylan Baker Thanks for making those changes for me. Quoting Ian Romanick (2017-11-20 17:24:09) > From: Ian Romanick > > v2: Clean ups. Remove some functions that never ended up being used. > > v3: Afte

Re: [Mesa-dev] [PATCH 06/14] intel/blorp: Add initial support for indirect clear colors

On Mon, Nov 13, 2017 at 08:12:46AM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.c | 1 + > src/intel/blorp/blorp.h | 7 +++ > src/intel/blorp/blorp_genX_exec.h | 77 > + > src/intel/blorp/blorp_priv.h

Re: [Mesa-dev] [PATCH 05/14] i965/blorp: Use a designated initializer for blorp_surf

On Mon, Nov 13, 2017 at 08:12:45AM -0800, Jason Ekstrand wrote: > This way uninitialized fields get automatically zeroed and it's safe to > add more fields to blorp_surf. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > This

Re: [Mesa-dev] [PATCH 1/9] ac: pack ac_surface better

On Wed, Nov 22, 2017 at 7:48 PM, Nicolai Hähnle wrote: > On 21.11.2017 18:30, Marek Olšák wrote: >> >> From: Marek Olšák >> >> r600_texture: 1736 -> 1488 bytes >> --- >> src/amd/common/ac_surface.h | 9 + >> src/gallium/drivers/r600/r600_texture.c | 2 +- >> src/gall

Re: [Mesa-dev] [PATCH 03/20] mesa: separate legacy stuff from gl_texture_unit into gl_fixedfunc_texture_unit

On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/drivers/common/meta.c | 18 +++--- > src/mesa/drivers/dri/i915/i830_texblend.c | 3 +- > src/mesa/drivers/dri/nouveau/nouveau_util.h | 2 +- > src/mesa/drivers/dri/nouveau/nv04_context.

Re: [Mesa-dev] [PATCH 00/20] Mesa: Reducing sizes of gl_context etc.

On 11/22/2017 11:02 AM, Nicolai Hähnle wrote: > On 21.11.2017 19:01, Marek Olšák wrote: >> Hi, >> >> This series reduces sizes of many driver structures. For example: >> >> gl_context: 152488 -> 72944 bytes >> vbo_context: 22696 -> 20008 bytes >> st_context: 10120 ->  3704 bytes >> >> The idea is t

Re: [Mesa-dev] [PATCH v3 06/15] meson: build virgl driver

Dylan Baker writes: > Build tested only. I haven't done a detailed comparison to the autotools build, but this all looks fine. Patches 1-6: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH 04/20] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > This makes piglit/texunits fail, because we can't do glTexEnv and > glGetTexEnv with 192 texture units anymore. Not that it ever made sense. It's just the test_texture_env subtest that fails, right? Does this test pass on any cl

Re: [Mesa-dev] [PATCH 2/9] ac: change legacy_surf_level::slice_size to dword units

On Wed, Nov 22, 2017 at 7:46 PM, Nicolai Hähnle wrote: > On 21.11.2017 18:30, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The next commit will reduce the size even more. >> --- >> src/amd/common/ac_surface.c| 2 +- >> src/amd/common/ac_surface.h

Re: [Mesa-dev] [PATCH 07/14] intel/blorp: Take a range of layers in blorp_ccs_resolve

On Mon, Nov 13, 2017 at 08:12:47AM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 3 ++- > src/intel/blorp/blorp_clear.c | 7 +-- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- > 3 files changed, 8 insertions(+), 4 deletions(-) This patch is Reviewed-by:

Re: [Mesa-dev] [PATCH 06/20] vbo: decrease the size of vbo_context slightly

On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > vbo_context: 21520 -> 20344 bytes > --- > src/mesa/main/mtypes.h | 8 > src/mesa/vbo/vbo_context.h | 4 ++-- > src/mesa/vbo/vbo_exec_draw.c | 2 +- > src/mesa/vbo/vbo_save_draw.c | 2 +- > 4 files changed, 8 inse

Re: [Mesa-dev] [PATCH 07/20] mesa: don't assign numbers to vertex attrib enums manually

Patches 7, 8, and 9 are Reviewed-by: Ian Romanick On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > I plan to remove one of them. > --- > src/compiler/shader_enums.h | 68 ++-- > src/mesa/tnl/t_context.h| 106 > ++-

Re: [Mesa-dev] [PATCH 10/20] mesa: reduce the size of gl_image_unit

On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > gl_context::ImageUnits: 6144 -> 4608 bytes > gl_context: 74608 -> 73072 bytes > --- > src/mesa/main/mtypes.h | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/mtypes.h b/src/mes

Re: [Mesa-dev] [PATCH 03/20] mesa: separate legacy stuff from gl_texture_unit into gl_fixedfunc_texture_unit

On Wed, Nov 22, 2017 at 10:15 PM, Ian Romanick wrote: > On 11/21/2017 10:01 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/drivers/common/meta.c | 18 +++--- >> src/mesa/drivers/dri/i915/i830_texblend.c | 3 +- >> src/mesa/drivers/dri/nouveau/nouveau_ut

Re: [Mesa-dev] [PATCH 11/20] mesa: reduce the size of gl_vertex_array_object

On 11/21/2017 10:01 AM, Marek Olšák wrote: > From: Marek Olšák > > RelativeOffset should actually be uint, not intptr, > according to ARB_vertex_attrib_binding. > > gl_vertex_array_object: 3632 -> 3112 bytes > --- > src/mesa/main/mtypes.h | 17 - > 1 file changed, 8 insertions(+

Re: [Mesa-dev] [PATCH 00/20] Mesa: Reducing sizes of gl_context etc.

On Wed, Nov 22, 2017 at 10:18 PM, Ian Romanick wrote: > On 11/22/2017 11:02 AM, Nicolai Hähnle wrote: >> On 21.11.2017 19:01, Marek Olšák wrote: >>> Hi, >>> >>> This series reduces sizes of many driver structures. For example: >>> >>> gl_context: 152488 -> 72944 bytes >>> vbo_context: 22696 -> 200

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On Wed, Nov 22, 2017 at 7:54 AM, Jason Ekstrand wrote: > On Tue, Nov 21, 2017 at 1:21 PM, Grazvydas Ignotas > wrote: >> >> On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand >> wrote: >> > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas >> > wrote: >> >> >> >> On Sun, Nov 19, 2017 at 1:51 AM, J

Re: [Mesa-dev] [PATCH 08/14] anv: Move get_fast_clear_state_address into anv_private.h

On Mon, Nov 13, 2017 at 08:12:48AM -0800, Jason Ekstrand wrote: > While we're at it, we break it into two nicely named functions. > --- > src/intel/vulkan/anv_private.h | 27 ++ > src/intel/vulkan/genX_cmd_buffer.c | 56 > -- > 2 files chang

Re: [Mesa-dev] [PATCH 04/20] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

On Wed, Nov 22, 2017 at 10:28 PM, Ian Romanick wrote: > On 11/21/2017 10:01 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This makes piglit/texunits fail, because we can't do glTexEnv and >> glGetTexEnv with 192 texture units anymore. Not that it ever made sense. > > It's just the test_textur

Re: [Mesa-dev] [PATCH] r600: set DX10_CLAMP for compute shader too

On 22 November 2017 at 13:27, wrote: > From: Roland Scheidegger > > I really intended to set this for all shader stages by > 3835009796166968750ff46cf209f6d4208cda86 but missed it for compute shaders > (because it's in a different source file...). Reviewed-by: Dave Airlie _

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

https://bugs.freedesktop.org/show_bug.cgi?id=103852 Bug ID: 103852 Summary: Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee) Product: Mesa Version: 17.2 Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #16 from Jan Vesely --- (In reply to Dave Gilbert from comment #15) > Hi Jan, > Yes, doing: > --- a/ocl.cpp > +++ b/ocl.cpp > @@ -65,6 +65,7 @@ static int got_dev(cl::Platform &plat, > std::vector &devices, cl::Dev > events.pu

Re: [Mesa-dev] [PATCH 09/14] anv: Let blorp handle indirect clear colors for CCS resolves

On Mon, Nov 13, 2017 at 08:12:49AM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 32 +--- > src/intel/vulkan/anv_private.h | 4 +-- > src/intel/vulkan/genX_cmd_buffer.c | 51 > +- > 3 files changed, 20 insert

Re: [Mesa-dev] [PATCH 15/15] radeonsi: enable gs support for nir backend

On 23/11/17 00:24, Ilia Mirkin wrote: On Wed, Nov 22, 2017 at 5:30 AM, Timothy Arceri wrote: --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 -- src/mesa/state_tracker/st_glsl_to_nir.cpp| 12 3 files chan

Re: [Mesa-dev] [PATCH 10/14] intel/blorp: Drop blorp_resolve_ccs_attachment

On Mon, Nov 13, 2017 at 08:12:50AM -0800, Jason Ekstrand wrote: > The only reason why we needed that version was because the Vulkan driver > needed to be able to create the surface states so it could handle > indirect clear colors. Now that blorp handles them natively, there's no > need for the ex

Re: [Mesa-dev] [PATCH 13/14] anv/blorp: Add an mcs_partial_resolve helper

On Mon, Nov 13, 2017 at 08:12:53AM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 31 +++ > src/intel/vulkan/anv_private.h | 6 ++ > 2 files changed, 37 insertions(+) > > diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp

Re: [Mesa-dev] [PATCH 01/20] mesa: replace GLenum with GLenum16 in common structures (v2)

On Wednesday 22 November 2017, Ian Romanick wrote: > There are a couple small nits below. > > I haven't reviewed this with the rigor that I would like because there > are just so many enums changed all at once. I fear the day someone has > a bug that bisects to this commit. > > The difficult par

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On November 22, 2017 15:12:20 Grazvydas Ignotas wrote: On Wed, Nov 22, 2017 at 7:54 AM, Jason Ekstrand wrote: On Tue, Nov 21, 2017 at 1:21 PM, Grazvydas Ignotas wrote: On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand wrote: > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas > wrote: >>

Re: [Mesa-dev] [PATCH 14/14] anv: Add support for MSAA fast-clears

On Mon, Nov 13, 2017 at 08:12:54AM -0800, Jason Ekstrand wrote: > This speeds up the Sascha Willems multisampling demo by around 25% when > using 8x MSAA. > --- > src/intel/vulkan/anv_blorp.c | 6 ++ > src/intel/vulkan/genX_cmd_buffer.c | 22 -- > 2 files changed, 18

Re: [Mesa-dev] [PATCH 06/20] vbo: decrease the size of vbo_context slightly

On Wed, Nov 22, 2017 at 10:53 PM, Ian Romanick wrote: > On 11/21/2017 10:01 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> vbo_context: 21520 -> 20344 bytes >> --- >> src/mesa/main/mtypes.h | 8 >> src/mesa/vbo/vbo_context.h | 4 ++-- >> src/mesa/vbo/vbo_exec_draw.c | 2 +- >>

Re: [Mesa-dev] V2 Initial GS NIR support for radeonsi

Am 22.11.2017 10:29, schrieb Timothy Arceri: This series depends on [1] and [2]. V2 - use driver_location as per Nicolais suggestion - tidy ups as per Mareks suggestions - bug fixes (many more piglit tests now passing) [1] https://patchwork.freedesktop.org/series/34131/ [2] https://patchwork

Re: [Mesa-dev] V2 Initial GS NIR support for radeonsi

On 23/11/17 15:09, Dieter Nützel wrote: Am 22.11.2017 10:29, schrieb Timothy Arceri: This series depends on [1] and [2]. V2  - use driver_location as per Nicolais suggestion  - tidy ups as per Mareks suggestions  - bug fixes (many more piglit tests now passing) [1] https://patchwork.freedeskto

[Mesa-dev] [PATCH] mesa: add AllowGLSLCrossStageInterpolationMismatch workaround

This fixes issues seen with certain versions of Unreal Engine 4 editor and games built with that using GLSL 4.30. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97852 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103801 --- src/compiler/glsl/link_vary