Re: [Mesa-dev] [PATCH 17/24] mesa/main: Add a 'spirv' flag to gl_shader_program_data

2017-11-21 Thread Eduardo Lima Mitev
On 11/20/2017 01:54 PM, Timothy Arceri wrote: On 20/11/17 21:56, Eduardo Lima Mitev wrote: On 11/20/2017 11:31 AM, Timothy Arceri wrote: On 20/11/17 19:00, Eduardo Lima Mitev wrote: On 11/16/2017 12:23 AM, Timothy Arceri wrote: On 16/11/17 00:22, Eduardo Lima Mitev wrote: This will be used b

Re: [Mesa-dev] [PATCH v5 07/13] meson: extend install_megadrivers script to handle symmlinking

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 11:09:39 -0800, Dylan Baker wrote: > Which is required for the gallium media state trackers. > > v4: - Make the full version the hard link and the partial so versiions > the symlinks > v5: - drop --so-version all-together. Instead pass the full name of the > DSO a

Re: [Mesa-dev] [PATCH v4 2/4] meson: disable x86 asm in fewer cases.

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 11:30:13 -0800, Dylan Baker wrote: > This patch allows building asm for x86 on x86_64 platforms, when the > operating system is the same. Previously cross compile always turned off > assembly. This allows using a cross file to cross compile x86 binaries > on x86_64 with asm. >

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-21 Thread Gert Wollny
Am Donnerstag, den 16.11.2017, 22:52 +0100 schrieb Gert Wollny: > Am Donnerstag, den 16.11.2017, 17:13 + schrieb Emil Velikov: > > > > According to the spec both of these are 'Z + Non-negative integer > > or enumerated value' Worth doing that instead? > > After having a short look into it, I

Re: [Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

2017-11-21 Thread Nicolai Hähnle
Hi Thomas, On 20.11.2017 18:19, Thomas Hellstrom wrote: Is this a multithreaded test? Do you see the error with Ubuntu 17.10 + Xorg? The dEQP-GLES31 tests are all single-threaded. I could finally test with the Ubuntu 17.10 on Xorg desktop on the same system (some other tests were running bef

Re: [Mesa-dev] [PATCH 10/12] spirv: Move SPIR-V building to Makefile.spirv.am and spirv/meson.build

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 17:24:08 -0800, Ian Romanick wrote: > From: Ian Romanick > > Future changes will add generated files used only from > src/compiler/glsl. These can't be built from Makefile.nir.am, and we > can't move all the rules from Makefile.nir.am to Makefile.spirv.am (and > it would be

[Mesa-dev] [PATCH 3/4] st/dri2: Propagate stapi make_current failure

2017-11-21 Thread George Barrett
dri_make_current discards the return value of st_api_make_current, preventing callers up the stack being made aware of any failures. --- src/gallium/state_trackers/dri/dri_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri_context.c

[Mesa-dev] [PATCH 1/4] st/mesa: Propagate framebuffer validation failure

2017-11-21 Thread George Barrett
st_framebuffer_validate discards the result of the validate interface method, preventing functions up the call stack from being notified of any failure. Update st_framebuffer_validate to resolve this, and amend st_api_make_current to propagate this failure up the stack. --- src/mesa/state_tracker/

[Mesa-dev] [PATCH 4/4] glx/dri2: Try and detect invalid DRI buffers

2017-11-21 Thread George Barrett
DRI routines in X drivers can return null buffers if they're unable to allocate them as requested (for example, [1]) but the DRI 2 protocol doesn't expose a mechanism to communicate this explicitly. Instead, we assume that zeroed out buffer info structs are invalid and go from there. This commit a

[Mesa-dev] [PATCH 2/4] st/dri2: Notify on texture allocation failure

2017-11-21 Thread George Barrett
Callers of dri_drawable->allocate_textures are unaware of failures occurring in the provided allocation function, happily chugging along with potentially invalid state. Update the interface and {dri2,drisw}_allocate_textures to return a boolean indicating success. --- src/gallium/state_trackers/dr

Re: [Mesa-dev] [PATCH v2 16/17] i965: Add ARB_get_program_binary support using nir_serialization

2017-11-21 Thread Timothy Arceri
On 21/11/17 09:27, Jordan Justen wrote: This works-around an apparent game bug described in 85564. It appears Change this to: This resolves an apparent game bug ??? that the game doesn't properly handle ARB_get_program_binary with 0 supported formats. Fixes: https://bugs.freedesktop.org/sho

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-21 Thread Timothy Arceri
On 21/11/17 15:54, Timothy Arceri wrote: On 21/11/17 15:34, Jordan Justen wrote: On 2017-11-20 19:00:28, Timothy Arceri wrote: I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dep

Re: [Mesa-dev] [PATCH v2 17/17] docs: Update GL_ARB_get_program_binary docs to support 1 format

2017-11-21 Thread Timothy Arceri
You could change 1 to GL_PROGRAM_BINARY_FORMAT_MESA here. Either way: Reviewed-by: Timothy Arceri On 21/11/17 09:27, Jordan Justen wrote: Signed-off-by: Jordan Justen --- docs/features.txt | 2 +- docs/relnotes/17.4.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) di

Re: [Mesa-dev] [PATCH 11/12] spirv: Generate code to track SPIR-V capability dependencies

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 17:24:09 -0800, Ian Romanick wrote: > From: Ian Romanick > > v2: Clean ups. Remove some functions that never ended up being used. > > v3: After updating spirv.core.grammar.json, fix the handling of > ShaderViewportMaskNV. See the comment around line 71 of > spirv_capabili

[Mesa-dev] [PATCH] meson: add si_driinfo.h in libgallium_dri

2017-11-21 Thread Juan A. Suarez Romero
v2: generate target conditionally (Dylan) --- src/gallium/targets/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index c591b75d037..595fd0a1a54 100644 --- a/src/gallium/targets/dri/meson.build +++ b/src

[Mesa-dev] [PATCH v2] meson: add si_driinfo.h in libgallium_dri

2017-11-21 Thread Juan A. Suarez Romero
v2: generate target conditionally (Dylan) --- src/gallium/targets/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index c591b75d037..595fd0a1a54 100644 --- a/src/gallium/targets/dri/meson.build +++ b/src

Re: [Mesa-dev] [PATCH 12/12] spirv: Generate SPIR-V builder infrastructure

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 17:24:10 -0800, Ian Romanick wrote: > From: Ian Romanick > > v2: Don't try to automatically set SpvCapabilityGeometry or > SpvCapabilityTessellation. > > v3: Move some changes from a later patch back into this patch. They > were only in the later patch because of rebase fa

Re: [Mesa-dev] [PATCH 1/2] nir/gather_info: recognize load_patch_vertices_in as a system value

2017-11-21 Thread Iago Toral
Anyone willing to review these 2 patches? They are needed to pass some of the OpenGL CTS tests. Iago On Thu, 2017-11-16 at 08:53 +0100, Iago Toral Quiroga wrote: > This intrinsic is produced to load SYSTEM_VALUE_VERTICES_IN, which is > generated to load gl_PatchVerticesIn in the SPIR-V path for b

Re: [Mesa-dev] GPU (and system) monitoring

2017-11-21 Thread Eero Tamminen
Hi, On 21.11.2017 02:39, Gordon Haverland wrote: On Mon, 20 Nov 2017 13:25:26 +0100 Nicolai Hähnle wrote: ... umr does that for the amdgpu kernel module I downloaded the source tree, compiled umr, mounted the debugfs to use umr, and ran umr --top switching to sensor mode, you could see

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > Similar idea to Tim's "spec: MESA_program_binary", but simplified and > written to support both ARB_get_program_binary and > OES_get_program_binary. > > This spec was merged into the OpenGL Registry in version > 667c5a253781834b40a6ae9eb

Re: [Mesa-dev] [PATCH 7/8] glapi: Don't search through subdirs from glapitable.h

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 15:12:51 -0800, Dylan Baker wrote: > Because meson won't put it in that folder. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/tests/check_table.cpp | 2 +- > src/mesa/main/tests/Makefile.am | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --g

Re: [Mesa-dev] [PATCH 0/6] meson: some non-linux OS work

2017-11-21 Thread Eric Engestrom
On Monday, 2017-11-20 16:50:32 -0800, Dylan Baker wrote: > This is a rough cross section of work to get the meson build working on macOS > and on Haiku, with one radeonsi fixup added. Most of this work is pretty > straight forward, turning some options that can be assumed on Linux into > tri-states

[Mesa-dev] [PATCH mesa] meson: fix strtof locale support check

2017-11-21 Thread Eric Engestrom
Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 383ebb366625edf9f262..4918194de48799f594d3 100644 --- a/meson.build +++ b/mes

Re: [Mesa-dev] [PATCH 5/6] meson: add logic to select apple and windows dri

2017-11-21 Thread Jon Turney
On 21/11/2017 00:50, Dylan Baker wrote: This is still not fully correct (haiku and BSD are probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file changed, 13 insertions(+), 2

[Mesa-dev] [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

2017-11-21 Thread Brian Paul
where the other format-related functions live. --- src/gallium/drivers/svga/svga_format.c | 119 src/gallium/drivers/svga/svga_format.h | 10 +++ src/gallium/drivers/svga/svga_screen.c | 121 - 3 files changed, 129 insertions(+), 12

[Mesa-dev] [PATCH 1/2] svga: s/unsigned/SVGA3dDevCapIndex/

2017-11-21 Thread Brian Paul
--- src/gallium/drivers/svga/svga_screen.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index ab604b9..86f53b2 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/driv

[Mesa-dev] [PATCH 2/8] ac/surface: fix indentation

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index f7600a35b26..41a2a492ca6 100644 --- a/src/amd/common/ac_surface.c +++ b/src/amd/common/ac_surface.c @@ -854,21

[Mesa-dev] [PATCH 1/8] amd/common: sid.h cleanups

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle Fix a bunch of labels indicating when registers were added/removed and normalize the SI-class GRBM_GFX_INDEX. --- src/amd/common/sid.h| 42 +++-- src/amd/vulkan/si_cmd_buffer.c | 14 ++- src/gallium/drivers/rad

[Mesa-dev] [PATCH 5/8] radeonsi: cleanup si_initialize_color_surface

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 2f9241f02f8..ae92a3c85a2 100644 --- a/src/galli

[Mesa-dev] [PATCH 7/8] radeonsi: clarify that si_shader_selector::esgs_itemsize is set for the ES part

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/si_shader.h index 148356b87ff..bcb5c9da4ce 100644 --- a/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 0/8] amd/common,radeonsi: misc cleanups

2017-11-21 Thread Nicolai Hähnle
Hi all, this is just a bunch of random cleanups of things that I happened to notice while passing by and that accumulated over time. The one thing that perhaps ties into a kind of theme is cleaning up sid.h, which I did while exploring some possibilities for moving to fully auto-generating most p

[Mesa-dev] [PATCH 8/8] radeonsi/gfx9: simplify condition for on-chip ESGS

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 61adb6b1dcc..898e2f89514 100644 --- a/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 6/8] radeonsi: use si_shader_context instead of lp_build_context in more places

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 50 +++- 1 file changed, 23 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e6b14f92056..61adb6b1dcc 100644 ---

[Mesa-dev] [PATCH 3/8] radeonsi: check that we don't leak fine.buf references

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle Just as an added precaution. --- src/gallium/drivers/radeonsi/si_fence.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers/radeonsi/si_fence.c index 9d6bcfe1027..1bf99dd0239 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH 4/8] radeonsi: avoid attempting to create CMASK if the tiling mode doesn't have it

2017-11-21 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_texture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 5f6e9139d0f..cdb700465ca 100644 --- a/src/gallium/drivers/radeon/r600_texture.c ++

[Mesa-dev] [PATCH mesa 1/2] meson: reorder subdirs to avoid directly including more than one level

2017-11-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/glapi/meson.build | 2 ++ src/mapi/meson.build | 2 +- src/meson.build| 1 - 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index d2d86afd6c1f07e06489..c2295b431404

[Mesa-dev] [PATCH mesa 2/2] meson: add variable for mapi_abi.py instead of going back up the tree

2017-11-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es1api/meson.build | 2 +- src/mapi/es2api/meson.build | 2 +- src/mapi/glapi/gen/meson.build| 2 +- src/mapi/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) dif

Re: [Mesa-dev] [PATCH v2 16/17] i965: Add ARB_get_program_binary support using nir_serialization

2017-11-21 Thread Emil Velikov
Hi Jordan, There's a small question below and a few nitpicks. Latter can be quite subjective, so please don't bother with them if you don't like the approach. On 20 November 2017 at 22:27, Jordan Justen wrote: > +void > +brw_program_binary_init(unsigned device_id) > +{ > + const struct build_

Re: [Mesa-dev] [PATCH 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-21 Thread Rob Clark
On Thu, Nov 16, 2017 at 9:19 PM, Eric Anholt wrote: > --- > src/gallium/auxiliary/util/u_transfer.c | 118 > > src/gallium/auxiliary/util/u_transfer.h | 18 + > 2 files changed, 136 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_transfer.c > b/

Re: [Mesa-dev] [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

2017-11-21 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, November 21, 2017 6:33:22 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c whe

[Mesa-dev] [PATCH 4/9] radeonsi: do 64-bit LDS loads recursively

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e6b14f9..d7c130a 100644 --- a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 1/9] ac: pack ac_surface better

2017-11-21 Thread Marek Olšák
From: Marek Olšák r600_texture: 1736 -> 1488 bytes --- src/amd/common/ac_surface.h | 9 + src/gallium/drivers/r600/r600_texture.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 12 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/am

[Mesa-dev] [PATCH 2/9] ac: change legacy_surf_level::slice_size to dword units

2017-11-21 Thread Marek Olšák
From: Marek Olšák The next commit will reduce the size even more. --- src/amd/common/ac_surface.c| 2 +- src/amd/common/ac_surface.h| 2 +- src/amd/vulkan/radv_image.c| 8 src/gallium/drivers/r600/evergreen_state

[Mesa-dev] [PATCH 5/9] radeonsi: use ac.lds for shared memory

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 2 -- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_sha

[Mesa-dev] [PATCH 0/9] RadeonSI tiny changes

2017-11-21 Thread Marek Olšák
Hi, This series contains tiny changes and small cleanups. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 7/9] radeonsi: fix a typo in creating monolithic ES-GS

2017-11-21 Thread Marek Olšák
From: Marek Olšák This has no effect because both occupy the same memory in a union. --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 16036e3

[Mesa-dev] [PATCH 6/9] radeonsi: don't write undefined output channels to LDS in LS

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index bca0ca9..16036e3 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/galliu

[Mesa-dev] [PATCH 3/9] ac: pack legacy_surf_level better

2017-11-21 Thread Marek Olšák
From: Marek Olšák r600_texture: 1488 -> 1248 bytes --- src/amd/common/ac_surface.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_surface.h b/src/amd/common/ac_surface.h index ec89f6b..f18548f 100644 --- a/src/amd/common/ac_surface.h +++ b/src/amd/com

[Mesa-dev] [PATCH 9/9] radeonsi: expose all CB performance counters on Stoney

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index 56af0a0..5029af0 100644 --- a/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 8/9] radeonsi: handle imported textures with DCC robustly

2017-11-21 Thread Marek Olšák
From: Marek Olšák now you can hack the driver to enable DCC for displayable textures and Glamor that doesn't enable that by default won't crash anymore. --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 02/12] st/dri: remove dead code and incorrect comment around make_current

2017-11-21 Thread Marek Olšák
From: Marek Olšák Core Mesa already handles flushing based on ContextReleaseBehavior, so the comment is wrong. Also, old_st is always NULL, because unbind_context always precedes make_current. --- src/gallium/state_trackers/dri/dri_context.c | 13 - 1 file changed, 13 deletions(-)

[Mesa-dev] [PATCH 01/12] st/dri: clean up dri_unbind_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri_context.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_context.c b/src/gallium/state_trackers/dri/dri_context.c index 18bbfa0..f5400ab 100644 --- a/src/gallium/state_tracker

[Mesa-dev] [PATCH 05/12] cso: add cso_get_pipe_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/cso_cache/cso_context.c | 4 src/gallium/auxiliary/cso_cache/cso_context.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index 757bcf3..df5543c

[Mesa-dev] [PATCH 00/12] Gallium HUD for multi-context applications

2017-11-21 Thread Marek Olšák
Hi, This series enables more flexibility for the HUD with multi-context applications like Google Chrome. (with --single-process parameter) It allows capturing queries from one context and draw the HUD in a different context. For example, you want to profile a WebGL context on a web page, but you

[Mesa-dev] [PATCH 06/12] gallium/hud: use cso_get_pipe_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 5 +++-- src/gallium/auxiliary/hud/hud_context.h | 2 +- src/gallium/state_trackers/dri/dri_context.c | 2 +- src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +- src/gallium/state_trackers/nine/device9.c| 2 +- src/ga

[Mesa-dev] [PATCH 03/12] gallium/hud: split hud_draw into 3 separate functions

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 168 +-- src/gallium/auxiliary/hud/hud_context.h | 2 +- src/gallium/state_trackers/dri/dri_drawable.c| 2 +- src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +- src/gallium/state

[Mesa-dev] [PATCH 07/12] gallium/hud: don't use hud->pipe in hud_parse_env_var

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 92d607f..810c2ea 100644 --- a/src/gallium/auxiliary/hud/hud_con

[Mesa-dev] [PATCH 12/12] gallium/hud: add HUD sharing within a context share group

2017-11-21 Thread Marek Olšák
From: Marek Olšák This is needed for profiling multi-context applications like Chrome. One context can record queries and another context can draw the HUD. --- src/gallium/auxiliary/hud/hud_context.c | 103 +++ src/gallium/auxiliary/hud/hud_context.h | 3 + sr

[Mesa-dev] [PATCH 11/12] gallium/hud: update the HUD interface for multiple contexts

2017-11-21 Thread Marek Olšák
From: Marek Olšák This is the boring subset of the following commit. All new parameters are optional. --- src/gallium/auxiliary/hud/hud_context.c | 7 --- src/gallium/auxiliary/hud/hud_context.h | 7 --- src/gallium/state_trackers/dri/dri_context.c | 4 ++-- src/gal

[Mesa-dev] [PATCH 04/12] gallium/hud: pass pipe_context explicitly to most functions

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 38 ++--- src/gallium/auxiliary/hud/hud_cpu.c | 8 ++--- src/gallium/auxiliary/hud/hud_driver_query.c | 51 +++- src/gallium/auxiliary/hud/hud_fps.c | 4 +-- src/galli

[Mesa-dev] [PATCH 10/12] gallium/hud: prevent a crash if the recording context is inactive

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index e3fcad2..7502416 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++

[Mesa-dev] [PATCH 08/12] gallium/hud: separate code for draw context init/release

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 181 1 file changed, 111 insertions(+), 70 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 810c2ea..6689006 100644 --- a/src/galliu

[Mesa-dev] [PATCH 09/12] gallium/hud: separate code for record context init/release

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 49 ++--- src/gallium/auxiliary/hud/hud_private.h | 4 +++ 2 files changed, 37 insertions(+), 16 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_contex

Re: [Mesa-dev] [PATCH mesa 1/2] meson: reorder subdirs to avoid directly including more than one level

2017-11-21 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-21 07:09:40) > Signed-off-by: Eric Engestrom > --- > src/mapi/glapi/meson.build | 2 ++ > src/mapi/meson.build | 2 +- > src/meson.build| 1 - > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [PATCH v5 07/13] meson: extend install_megadrivers script to handle symmlinking

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 02:39:44) > On Monday, 2017-11-20 11:09:39 -0800, Dylan Baker wrote: > > Which is required for the gallium media state trackers. > > > > v4: - Make the full version the hard link and the partial so versiions > > the symlinks > > v5: - drop --so-version all-

[Mesa-dev] [PATCH 03/20] mesa: separate legacy stuff from gl_texture_unit into gl_fixedfunc_texture_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/drivers/dri/i915/i830_texblend.c | 3 +- src/mesa/drivers/dri/nouveau/nouveau_util.h | 2 +- src/mesa/drivers/dri/nouveau/nv04_context.c | 14 +++-- src/mesa/drivers/dri/nouveau/nv04_state

[Mesa-dev] [PATCH 00/20] Mesa: Reducing sizes of gl_context etc.

2017-11-21 Thread Marek Olšák
Hi, This series reduces sizes of many driver structures. For example: gl_context: 152488 -> 72944 bytes vbo_context: 22696 -> 20008 bytes st_context: 10120 -> 3704 bytes The idea is to decrease CPU cache usage on smaller CPUs. I have not noticed a performance difference with microbenchmarks. It

[Mesa-dev] [PATCH 05/20] mesa: further reduce the size of ctx->Texture

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_context: 75072 -> 74672 bytes --- src/mesa/main/glheader.h | 5 - src/mesa/main/mtypes.h | 44 ++-- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h index 37296

[Mesa-dev] [PATCH 02/20] mesa: inline init_texture_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák because this is going to be changed --- src/mesa/main/texstate.c | 90 +--- 1 file changed, 39 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 2146723..62c3572 100644 --- a/src/me

[Mesa-dev] [PATCH 04/20] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

2017-11-21 Thread Marek Olšák
From: Marek Olšák This makes piglit/texunits fail, because we can't do glTexEnv and glGetTexEnv with 192 texture units anymore. Not that it ever made sense. If people are OK with this, we can adjust the test to check only 8 texture units, so that it doesn't fail. See also code comments. gl_cont

[Mesa-dev] [PATCH 06/20] vbo: decrease the size of vbo_context slightly

2017-11-21 Thread Marek Olšák
From: Marek Olšák vbo_context: 21520 -> 20344 bytes --- src/mesa/main/mtypes.h | 8 src/mesa/vbo/vbo_context.h | 4 ++-- src/mesa/vbo/vbo_exec_draw.c | 2 +- src/mesa/vbo/vbo_save_draw.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/mtypes.

[Mesa-dev] [PATCH 07/20] mesa: don't assign numbers to vertex attrib enums manually

2017-11-21 Thread Marek Olšák
From: Marek Olšák I plan to remove one of them. --- src/compiler/shader_enums.h | 68 ++-- src/mesa/tnl/t_context.h| 106 ++-- src/mesa/vbo/vbo_attrib.h | 92 +++--- 3 files changed, 133 inser

[Mesa-dev] [PATCH 08/20] mesa: remove unused vertex attrib WEIGHT

2017-11-21 Thread Marek Olšák
From: Marek Olšák We don't support ARB_vertex_blend. Note that the attribute aliasing check for ARB_vertex_program had to be rewritten. vbo_context: 20344 -> 20008 bytes gl_context: 74672 -> 74616 bytes --- src/compiler/shader_enums.c | 1 - src/compiler/shader_enums.h

[Mesa-dev] [PATCH 10/20] mesa: reduce the size of gl_image_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_context::ImageUnits: 6144 -> 4608 bytes gl_context: 74608 -> 73072 bytes --- src/mesa/main/mtypes.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f16ff4e..6ddef05 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 12/20] mesa: reduce the size of gl_program

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_program: 1456 -> 976 bytes --- src/compiler/glsl/link_uniforms.cpp | 9 - src/mesa/main/mtypes.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 46c

[Mesa-dev] [PATCH 11/20] mesa: reduce the size of gl_vertex_array_object

2017-11-21 Thread Marek Olšák
From: Marek Olšák RelativeOffset should actually be uint, not intptr, according to ARB_vertex_attrib_binding. gl_vertex_array_object: 3632 -> 3112 bytes --- src/mesa/main/mtypes.h | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/

[Mesa-dev] [PATCH 17/20] mesa: reduce the size of gl_texture_image

2017-11-21 Thread Marek Olšák
From: Marek Olšák 80 -> 40 bytes. --- src/mesa/main/mtypes.h | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9f3df70..950d156 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/

[Mesa-dev] [PATCH 13/20] mesa: reduce the size of gl_texture_object

2017-11-21 Thread Marek Olšák
From: Marek Olšák We are technically incorrect by not allowing the full range of non-sensical values. Like BaseLevel = 1. Do we really care about that though? gl_texture_object: 1032 -> 984 bytes. --- src/mesa/main/mtypes.h | 48 src/mesa/m

[Mesa-dev] [PATCH 14/20] mesa: reduce the size of gl_viewport_attrib

2017-11-21 Thread Marek Olšák
From: Marek Olšák All drivers convert these to float, so there is no reason to use double. This makes piglit/arb_viewport_array/viewport-indices fail, because glDepthRange accepts double and piglit expects glGetDoublei_v(GL_DEPTH_RANGE) to return the same value, but this patch rounds it to float

[Mesa-dev] [PATCH 18/20] mesa: move STATE_LENGTH to shader_enums.h and use it everywhere

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/ir.h | 2 +- src/compiler/nir/nir.h | 10 +- src/compiler/nir/nir_lower_drawpixels.c | 2 +- src/compiler/shader_enums.h | 6 ++ src/mesa/program/prog_statevars.h | 6 -- 5 files chang

[Mesa-dev] [PATCH 16/20] mesa: reduce the size of gl_program_parameter

2017-11-21 Thread Marek Olšák
From: Marek Olšák 40 -> 24 bytes, which includes the gl_state_index16 change. --- src/mesa/program/prog_parameter.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/prog_parameter.h b/src/mesa/program/prog_parameter.h index ce5d2cb..41b3fe8 100644 --- a

[Mesa-dev] [PATCH 15/20] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2017-11-21 Thread Marek Olšák
From: Marek Olšák Let's use the new gl_state_index16 type everywhere and remove the typecasts. This helps reduce the size of gl_program_parameter. --- src/compiler/glsl/ir.h | 2 +- src/compiler/glsl/shader_cache.cpp | 2 +- src/compiler/glsl/standalone_sca

[Mesa-dev] [PATCH 20/20] st/mesa: remove out_num_textures from update_textures

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_texture.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index 105fa79..ce7755f 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 09/20] mesa: shrink VERT_ATTRIB bitfields to 32 bits

2017-11-21 Thread Marek Olšák
From: Marek Olšák There are only 32 vertex attribs now. --- src/compiler/shader_enums.h | 46 ++--- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++--- src/mesa/main/arrayobj.c| 14 - src/mesa/main/enable.c

[Mesa-dev] [PATCH 19/20] st/mesa: don't store non-fragment sampler states and views in st_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák those are unused. st_context: 10120 -> 3704 bytes --- src/mesa/state_tracker/st_atom_sampler.c | 35 +-- src/mesa/state_tracker/st_atom_texture.c | 56 +-- src/mesa/state_tracker/st_cb_bitmap.c | 8 ++--- src/mesa/state_tracke

Re: [Mesa-dev] [PATCH v2] meson: add si_driinfo.h in libgallium_dri

2017-11-21 Thread Dylan Baker
Thanks for making that change. Reviewed-by: Dylan Baker Quoting Juan A. Suarez Romero (2017-11-21 03:40:51) > v2: generate target conditionally (Dylan) > --- > src/gallium/targets/dri/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/targets/dri/meson.build > b/s

Re: [Mesa-dev] [PATCH 7/8] glapi: Don't search through subdirs from glapitable.h

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 06:06:33) > On Monday, 2017-11-20 15:12:51 -0800, Dylan Baker wrote: > > Because meson won't put it in that folder. > > > > Signed-off-by: Dylan Baker > > --- > > src/mapi/glapi/tests/check_table.cpp | 2 +- > > src/mesa/main/tests/Makefile.am | 2 ++ > >

Re: [Mesa-dev] [Mesa-stable] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-21 Thread Anuj Phogat
On Mon, Nov 20, 2017 at 4:30 PM, Andres Gomez wrote: > Anuj, these 4 patches series landed in master without the "mesa-stable" > tag, hence, just confirming that you dropped the nomination. > Yes, I dropped the mesa-stable tag. Thanks for confirming. > Let me know if that was not the case. > > On

[Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Dylan Baker
This is still not fully correct (haiku and BSD is notably probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. v2: - set the dri_platform to windows on Cygwin as well (Jon) Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file cha

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Eric Engestrom
On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > This is still not fully correct (haiku and BSD is notably probably not > correct), but Linux is not regressed and this should be correct for > macOS and Windows. > > v2: - set the dri_platform to windows on Cygwin as well (Jon) R-b stand

Re: [Mesa-dev] [PATCH v3] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-21 Thread Nanley Chery
On Fri, Nov 17, 2017 at 10:22:37AM -0800, Nanley Chery wrote: > On Fri, Nov 17, 2017 at 05:07:09PM +0100, Juan A. Suarez Romero wrote: > > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > > > An INVALID_OPERATION error is generated by CompressedTexImage3D > > if internalformat is one of t

Re: [Mesa-dev] [PATCH 2/2] ac/nir: don't write tcs outputs to LDS that aren't read back.

2017-11-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 20, 2017 at 2:57 AM, Dave Airlie wrote: > From: Dave Airlie > > If the TCS doesn't read back the outputs, no need to store them > to LDS in the first place. (except for tess factors). > > This seems to give about 50fps (3290->3330) with tessellation d

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 10:38:25) > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > > This is still not fully correct (haiku and BSD is notably probably not > > correct), but Linux is not regressed and this should be correct for > > macOS and Windows. > > > > v2: - set the d

Re: [Mesa-dev] [PATCH mesa] meson: fix strtof locale support check

2017-11-21 Thread Dylan Baker
Oops, that's what I get for not copy-n-pasting. Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-21 06:26:03) > Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

2017-11-21 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > This function is used to determine when we need to re-allocate a > miptree. Since we do nothing different in miptree allocation for > sRGB vs. linear, loosening this should be safe and may lead to less > copying and reallocating in some odd cases. > > Cc

Re: [Mesa-dev] [PATCH 1/2] nir/gather_info: recognize load_patch_vertices_in as a system value

2017-11-21 Thread Marek Olšák
This patch: Reviewed-by: Marek Olšák Marek On Thu, Nov 16, 2017 at 8:53 AM, Iago Toral Quiroga wrote: > This intrinsic is produced to load SYSTEM_VALUE_VERTICES_IN, which is > generated to load gl_PatchVerticesIn in the SPIR-V path for both > Vulkan and OpenGL. > --- > src/compiler/nir/nir_ga

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Notify on texture allocation failure

2017-11-21 Thread Marek Olšák
Where is patch 1? Marek On Tue, Nov 21, 2017 at 12:16 PM, George Barrett wrote: > Callers of dri_drawable->allocate_textures are unaware of failures > occurring in the provided allocation function, happily chugging along > with potentially invalid state. Update the interface and > {dri2,drisw}_a

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Notify on texture allocation failure

2017-11-21 Thread George Barrett
On Tue, Nov 21, 2017 at 08:01:16PM +0100, Marek Olšák wrote: > Where is patch 1? The patches didn't end up in the same thread. Really sorry about that, still getting used to sending patches via mailing list. The subject is > [Mesa-dev] [PATCH 1/4] st/mesa: Propagate framebuffer validation failure

Re: [Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

2017-11-21 Thread Thomas Hellstrom
Hi, Nicolai, On 11/21/2017 11:50 AM, Nicolai Hähnle wrote: Hi Thomas, On 20.11.2017 18:19, Thomas Hellstrom wrote: Is this a multithreaded test? Do you see the error with Ubuntu 17.10 + Xorg? The dEQP-GLES31 tests are all single-threaded. I could finally test with the Ubuntu 17.10 on Xorg d

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-21 Thread Jordan Justen
On 2017-11-21 05:45:36, Eric Engestrom wrote: > On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > > Similar idea to Tim's "spec: MESA_program_binary", but simplified and > > written to support both ARB_get_program_binary and > > OES_get_program_binary. > > > > This spec was merged into

  1   2   >