[Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2017-11-14 Thread Samuel Iglesias Gonsálvez
The HW has some limits but, according to the spec, we can create the image as it has not yet any memory backing it. This patch logs a debug error and set the size to the UINT64_MAX in order to avoid allocating actual memory later. Fixes the crashes on BDW for the following tests: dEQP-VK.pipeline

Re: [Mesa-dev] [PATCH] radv: it isn't an error to not support a format or driver

2017-11-14 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 11/14/2017 04:27 AM, Dave Airlie wrote: From: Dave Airlie This reverts two of the vk_error changes: reporting unsupported format is common, and testing non-amdgpu drivers and ignoring them is also common. Fixes: cd64a4f70 (radv: use vk_error() everywhere an e

Re: [Mesa-dev] [PATCH 1/2] radv: Free syncobj with multiple imports.

2017-11-14 Thread Samuel Pitoiset
For the series: Reviewed-by: Samuel Pitoiset On 11/14/2017 04:30 AM, Dave Airlie wrote: Reviewed-by: Dave Airlie On 14 November 2017 at 09:45, Bas Nieuwenhuizen wrote: Otherwise we can leak the old syncobj. Fixes: eaa56eab6da "radv: initial support for shared semaphores (v2)" --- src/a

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 Bug ID: 103732 Summary: swr often gets stuck in piglit's glx-multi-context-single-window test Product: Mesa Version: 17.2 Hardware: Other OS: All

[Mesa-dev] [PATCH v2 0/5] etnaviv: Add sampler TS support

2017-11-14 Thread Wladimir J. van der Laan
Sampler TS is an hardware optimization that can be used when rendering to textures. After rendering to a resource with TS enabled, the texture unit can use this to bypass lookups to empty tiles. This also means a resolve-in-place can be avoided to flush the TS. This patch series adds support for s

[Mesa-dev] [PATCH v2 3/5] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-14 Thread Wladimir J. van der Laan
Sampler TS introduces yet another format enumeration for renderable+textureable formats. Introduce it into the etnaviv_format table as another column. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_format.c | 162 +++ src/gallium/drivers/e

[Mesa-dev] [PATCH v2 1/5] etnaviv: rnndb update

2017-11-14 Thread Wladimir J. van der Laan
Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++-- src/gallium/drivers/etnaviv/hw/state_3d.xml.h

[Mesa-dev] [PATCH v2 5/5] etnaviv: Add sampler TS support

2017-11-14 Thread Wladimir J. van der Laan
Sampler TS is an hardware optimization that can be used when rendering to textures. After rendering to a resource with TS enabled, the texture unit can use this to bypass lookups to empty tiles. This also means a resolve-in-place can be avoided to flush the TS. This commit is also an optimization

[Mesa-dev] [PATCH v2 4/5] etnaviv: Flush TS cache before changing TS configuration

2017-11-14 Thread Wladimir J. van der Laan
This is to make sure that the TS is properly flushed to memory before rendering to a new surface starts. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.c b/s

[Mesa-dev] [PATCH v2 2/5] etnaviv: Check that resource has a valid TS in etna_resource_needs_flush

2017-11-14 Thread Wladimir J. van der Laan
Resources only need a resolve-to-itself if their TS is valid for any level, not just if it happens to be allocated. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 + src/gallium/drivers/etnaviv/etnaviv_resource.h | 6 +- 2 files c

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 Andrés Gómez García changed: What|Removed |Added CC||ago...@igalia.com,

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Julien Isorce
Thx for pointing that. Gentle ping, anyone wants to mark 'reviewed' this patch ? On 10 November 2017 at 16:18, Rafael Antognolli wrote: > On Fri, Nov 10, 2017 at 10:46:03AM +, Julien Isorce wrote: > > Thx for the suggestions. > > > > Anyone familiar with _mesa_get_format_block_size and > _m

Re: [Mesa-dev] [PATCH v3 04/15] meson: build r600 driver

2017-11-14 Thread Marc Dietrich
Hi Dylan, Am Dienstag, 14. November 2017, 02:09:08 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > Tested-by: Aaron Watry > --- > meson.build | 22 -- > src/gallium/drivers/r600/meson.build | 128 > +++ src/gallium/meson.build

Re: [Mesa-dev] [PATCH v3 14/15] meson: build gallium va state tracker

2017-11-14 Thread Marc Dietrich
Hi Dylan, Am Dienstag, 14. November 2017, 02:09:18 CET schrieb Dylan Baker: > v2: - set with_gallium_va when -Dgallium-va=true > - Fix megadrivers install > - only use cflags from pkg-config, don't add linker flags. > - Don't get version from pkg-config, it's not tracking the same >

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Chris Wilson
Quoting Julien Isorce (2017-11-09 17:03:13) > v2: add early return if (flag & MAP_INTERNAL_MASK) > v3: take input rect into account and test with kmscube and piglit. > v4: handle wraparound and bo reference. > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tests: >

[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102891 --- Comment #11 from jdr...@gmail.com --- Created attachment 135446 --> https://bugs.freedesktop.org/attachment.cgi?id=135446&action=edit with zerovram on mesa-git I installed mesa-git+vulkan-radeon-git+xf86-video-amdgpu-git My new test was do

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #1 from Michel Dänzer --- I've run into this with radeonsi as well. It didn't happen for me until September 13th, using a CPU with 4 cores and 4 logical threads. After a break, I started running piglit again on October 9th, using a

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-14 Thread Jose Fonseca
On 11/11/17 01:37, Jordan Justen wrote: On 2017-11-09 19:40:40, Jordan Justen wrote: On 2017-11-09 08:07:57, Jose Fonseca wrote: On 09/11/17 13:19, Emil Velikov wrote: On 9 November 2017 at 06:42, Jordan Justen wrote: Signed-off-by: Jordan Justen Currently zlib is a dependency for !WIndows

Re: [Mesa-dev] [PATCH v3 15/15] meson: build gallium xa state tracker

2017-11-14 Thread Marc Dietrich
Hi Dylan, Am Dienstag, 14. November 2017, 02:09:19 CET schrieb Dylan Baker: > v2: - set with_gallium_xa when -Dgallium-xa=true > - install pkg config file > --- > meson.build | 22 > meson_options.txt | 7 +++ > src/gallium/meson

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Andy Furniss
Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations Zhang, Boyuan wrote: diff

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Julien Isorce
Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tests: By porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. kmscube --mode=rgba kmscube --mode=nv12-1img kmscube --mode=nv12-2img piglit ext_image_dma_buf_import-refcount -auto piglit ext_image_dma_buf_import

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-14 Thread Chris Wilson
Quoting Julien Isorce (2017-11-14 11:05:52) > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tests: > By porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > kmscube --mode=rgba > kmscube --mode=nv12-1img > kmscube --mode=nv12-2img > piglit ext_image

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 Emil Velikov changed: What|Removed |Added Component|Other |Drivers/Gallium/swr --- Comment #2 from

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #4 from sergio.calleg...@gmail.com --- > BTW how did you install plasma 5.11.3? Kubuntu artful has 5.10.5 by default. sudo add-apt-repository ppa:kubuntu-ppa/backports There is a specific repo for kde updates. > Or maybe not since

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #5 from Tapani Pälli --- I've reproduced this and trying to understand what's going on. This is caused by my patch that exposes sRGB visuals. -- You are receiving this mail because: You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH 00/23] Silence some warnings that show up when compiling gallium/aux/util

2017-11-14 Thread Emil Velikov
On 12 November 2017 at 13:55, Gert Wollny wrote: > Hello all, > > this might be a bit over-zealos, but I usually prefer to compile with > -Wall -Wextra, and with mesa this gives many warnings. This series > silences most of the warnings that are issued when compiling the > C files in gallium/aux/u

[Mesa-dev] [AppVeyor] mesa master #6147 failed

2017-11-14 Thread AppVeyor
Build mesa 6147 failed Commit 7df9a3609a by Jon Turney on 11/13/2017 10:13 AM: meson: if dep_dl is an empty list, it's not a dependency object\n\nIt's ok to use an empty list for dependencies:, but it's not ok to try to\nuse the found() method of it.\n\nSee als

Re: [Mesa-dev] [PATCH] spirv: fix typo on DO NOT EDIT header

2017-11-14 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2017-11-14 at 08:34 +0100, Alejandro Piñeiro wrote: > Introduced on commit 157c9a13414b524ce98ea0ea07fce819efc1ba65 > --- >  src/compiler/spirv/spirv_info_c.py | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spir

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-14 Thread Jon Turney
On 13/11/2017 17:41, Dylan Baker wrote: I thought I'd fixed this already, Reviewed-by: Dylan Baker This workaround is already in place for dep_xxf86vm. I took a brief look, and didn't see anywhere the same problem could occur with any of the other uses of [] for a dependency. Quoting Jon

[Mesa-dev] [AppVeyor] mesa master #6148 completed

2017-11-14 Thread AppVeyor
Build mesa 6148 completed Commit b498172d0e by Alejandro Piñeiro on 11/14/2017 7:32 AM: spirv: fix typo on DO NOT EDIT header\n\nIntroduced on commit 157c9a13414b524ce98ea0ea07fce819efc1ba65\n\nReviewed-by: Iago Toral Quiroga Configure your notificat

Re: [Mesa-dev] [PATCH 18/18] intel/tools: add command line GEN shader disassembler tool

2017-11-14 Thread Rogovin, Kevin
Hi, I've made a preliminary meson.build in src/intel/tools for the stuff; One can see it in the commit " src/intel/tools: add BatchbufferLogger to meson build system " at https://github.com/krogueintel/asem/tree/batchbuffer-logger . Comments welcome. Best Regards, -Kevin P.S. This was my

Re: [Mesa-dev] [PATCH 00/23] Silence some warnings that show up when compiling gallium/aux/util

2017-11-14 Thread Nicolai Hähnle
On 14.11.2017 12:55, Emil Velikov wrote: On 12 November 2017 at 13:55, Gert Wollny wrote: Hello all, this might be a bit over-zealos, but I usually prefer to compile with -Wall -Wextra, and with mesa this gives many warnings. This series silences most of the warnings that are issued when compi

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-14 Thread Marek Olšák
On Mon, Nov 13, 2017 at 10:19 PM, Ian Romanick wrote: > On 11/08/2017 07:16 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> For lower CPU cache usage. All enums fit within 2 bytes. > > Have you benchmarked this on anything? My recollection is that for many > things loads and stores of 16-bit v

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Mark Thompson
On 14/11/17 10:53, Andy Furniss wrote: > Zhang, Boyuan wrote: >> >> >> -Original Message- >> From: Zhang, Boyuan >> Sent: November-13-17 11:41 AM >> To: Andy Furniss; Koenig, Christian; Mark Thompson; >> mesa-dev@lists.freedesktop.org >> Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn: ad

Re: [Mesa-dev] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

2017-11-14 Thread Lionel Landwerlin
On 13/11/17 22:07, Jason Ekstrand wrote: On Mon, Nov 13, 2017 at 1:30 PM, Nanley Chery > wrote: On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason Ekstrand wrote: > Found by inspection > Good catch. > Cc: mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 02/14] anv/cmd_buffer: Take bo_offset into account in fast clear state addresses

2017-11-14 Thread Lionel Landwerlin
Oh dear... Reviewed-by: Lionel Landwerlin On 13/11/17 16:12, Jason Ekstrand wrote: Otherwise, if the image is not bound to the start of the buffer, we're going to be reading and writing its fast clear state in the wrong spot. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/genX_c

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 01/48] intel/fs: Pass builders instead of blocks into emit_[un]zip

2017-11-14 Thread Andres Gomez
Jason, after checking more in detail these 3 nominated commits from this series: fcd4adb9d08094520fb8d118d3448b04c6ec1fd1 intel/fs: Pass builders instead of blocks into emit_[un]zip. 0d905597fe2997c89022c76cdf84dc4fba5eb055 intel/fs: Be more explicit about our placement of [un]zip. 6c00240bc6508

[Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc4

2017-11-14 Thread Emil Velikov
The fourth release candidate for Mesa 17.3.0 is now available. As per the issue tracker [1] we still have a number of outstanding bugs blocking the release. [1] https://bugs.freedesktop.org/show_bug.cgi?id=103491 Andreas Boll (3): broadcom/vc5: Add vc5_drm.h to the release tarball br

Re: [Mesa-dev] [PATCH 04/14] intel/blorp: Add fast-clear to the special case in MSAA resolves

2017-11-14 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/14] i965/blorp: Use a designated initializer for blorp_surf

2017-11-14 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 09/15] meson: extend install_megadrivers script to handle symmlinking

2017-11-14 Thread Eric Engestrom
On Monday, 2017-11-13 17:09:13 -0800, Dylan Baker wrote: > which is required for the gallium media state trackers. > --- > bin/install_megadrivers.py | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py > index a98d7dd177b..581ff97

Re: [Mesa-dev] [PATCH 1/2] r600/shader: reserve first register of vertex shader.

2017-11-14 Thread Andres Gomez
Dave, this nominated patch landed without mentioning any specific stable queue. From what I'm seeing, they depend on ea1b97714d9b which didn't make it for 17.2 so I'm dropping it for that queue. Let me know what you think. On Mon, 2017-11-13 at 14:18 +1000, Dave Airlie wrote: > From: Dave Airli

Re: [Mesa-dev] [PATCH 02/13] i965: remove ARB_compute_shader extension override

2017-11-14 Thread Emil Velikov
On 10 November 2017 at 23:39, Jordan Justen wrote: > On 2017-11-10 08:19:38, Emil Velikov wrote: >> On 7 November 2017 at 11:54, Emil Velikov wrote: >> > From: Emil Velikov >> > >> > Checking the override was useful in the early stages of developing the >> > extension. >> > >> > Now that everyth

[Mesa-dev] [PATCH 2/2] radv: do not add the image BO in radv_set_dcc_need_cmask_elim_pred()

2017-11-14 Thread Samuel Pitoiset
radv_fill_buffer() ensures that the image BO is added to the list. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 95e3953118..6503c031bd 100644 ---

[Mesa-dev] [PATCH 1/2] radv: do not add the image BO in radv_set_color_clear_regs()

2017-11-14 Thread Samuel Pitoiset
radv_fill_buffer() ensures that the image BO is added to the list. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 2e94c125be..95e3953118 100644 ---

[Mesa-dev] [PATCH] egl/wayland: Add a fallback when fourcc query isn't supported

2017-11-14 Thread Derek Foreman
When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients will die with a NULL derefence in wl_proxy_add_listener. Attempt to provide a simple fallback to keep ancient systems working. Signed-off-by: Derek Foreman --- src/egl/drivers/dri2/platform_wayland.c | 32

Re: [Mesa-dev] [PATCH v3 13/48] intel/fs: Use the original destination region for int MUL lowering

2017-11-14 Thread Jason Ekstrand
On Mon, Nov 13, 2017 at 3:32 PM, Matt Turner wrote: > On Wed, Oct 25, 2017 at 4:25 PM, Jason Ekstrand > wrote: > > Some hardware (CHV, BXT) have special restrictions on register regions > > when doing integer multiplication. We want to respect those when we > > lower to DxW multiplication. > >

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 Michel Dänzer changed: What|Removed |Added Component|Drivers/Gallium/swr |Mesa core --- Comment #3 from Michel Dä

Re: [Mesa-dev] [PATCH] egl/wayland: Add a fallback when fourcc query isn't supported

2017-11-14 Thread Derek Foreman
Please disregard, I misunderstood a comment in the bug tracker and this has been posted here before. Sorry for the line noise. On 2017-11-14 09:39 AM, Derek Foreman wrote: When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients will die with a NULL derefence in wl_proxy_add_l

Re: [Mesa-dev] [PATCH 06/14] intel/blorp: Add initial support for indirect clear colors

2017-11-14 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: remove has_cp_dma, has_streamout flags (v2)

2017-11-14 Thread Nicolai Hähnle
On 09.11.2017 17:34, Marek Olšák wrote: From: Marek Olšák v2: remove r600_can_dma_copy_buffer Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_buffer_common.c | 17 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 -- src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH 2/3] mesa: minor tidy up for memory object error strings

2017-11-14 Thread Nicolai Hähnle
On 11.11.2017 01:07, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez Reviewed-by: Nicolai Hähnle --- src/mesa/main/externalobjects.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/externalobjects.c b/src/mesa/ma

Re: [Mesa-dev] [PATCH 3/3] mesa/st: add missing copyright headers to memoryobjects files

2017-11-14 Thread Nicolai Hähnle
On 11.11.2017 01:07, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_memoryobjects.c | 24 src/mesa/state_tracker/st_cb_memoryobjects.h | 24 2 files changed, 48 inser

Re: [Mesa-dev] [PATCH 2/2] st/mesa: move st_manager_destroy() earlier in file

2017-11-14 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 11.11.2017 03:40, Brian Paul wrote: To avoid forward declaration. --- src/mesa/state_tracker/st_manager.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/s

[Mesa-dev] [PATCH 3/3] radv: add the vertex buffers BO to the list at bind time

2017-11-14 Thread Samuel Pitoiset
This should reduce the overhead of adding a BO to the current list, especially when the list is huge. Also, when a new pipeline is bound, we only need to update the descriptor, the buffer objects should already be in the list. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c |

[Mesa-dev] [PATCH 2/3] radv: replace vb_dirty with RADV_CMD_DIRTY_VERTEX_BUFFER

2017-11-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 7 --- src/amd/vulkan/radv_private.h| 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 6503c031bd..5e5e5e4d4b 100644 --- a/sr

[Mesa-dev] [PATCH 1/3] radv: drop radv_cmd_dirty_mask_t typedef

2017-11-14 Thread Samuel Pitoiset
I don't think we will need a 64-bit unsigned integer for the dirty flags in the future, and there is still 20 bits left. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- src/amd/vulkan/radv_private.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gallium/radeon: disable the cache when nir backend enabled

2017-11-14 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.11.2017 01:42, Timothy Arceri wrote: --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 68bde2ad18..ce

Re: [Mesa-dev] [PATCH] gallium/radeon: disable the cache when nir backend enabled

2017-11-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 13, 2017 at 1:42 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c > b/src/gallium/drivers/radeon/r600_pipe_commo

[Mesa-dev] [PATCH] radv: use an unsigned 32-bit integer for radv_queue::family_index

2017-11-14 Thread Samuel Pitoiset
VkDeviceQueueCreateInfo::queueFamilyIndex is an unsigned 32-bit integer. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_private.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH 4/4] st/glsl_to_tgsi: use tgsi_get_gl_varying_semantic() for gs/tes outputs

2017-11-14 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 13.11.2017 02:56, Timothy Arceri wrote: --- src/mesa/state_tracker/st_program.c | 96 ++--- 1 file changed, 5 insertions(+), 91 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tr

Re: [Mesa-dev] [PATCH] r600: fix isoline tess factor component swapping.

2017-11-14 Thread Nicolai Hähnle
On 13.11.2017 06:41, Dave Airlie wrote: From: Dave Airlie As per radeonsi, the tess factor components for isolines are reversed. Fixes: tests/spec/arb_tessellation_shader/execution/isoline.shader_test Signed-off-by: Dave Airlie Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/r600/r

[Mesa-dev] [Bug 103658] addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103658 --- Comment #1 from Nicolai Hähnle --- Looks like you're not building with C++11 enabled? The recent changes to addrlib require that. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 00/23] Silence some warnings that show up when compiling gallium/aux/util

2017-11-14 Thread Gert Wollny
Am Dienstag, den 14.11.2017, 14:53 +0100 schrieb Nicolai Hähnle: > On 14.11.2017 12:55, Emil Velikov wrote: > > On 12 November 2017 at 13:55, Gert Wollny > > wrote: > > > Hello all, > > > > > > this might be a bit over-zealos, but I usually prefer to compile > > > with -Wall -Wextra, and with mes

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-14 Thread Nicolai Hähnle
On 09.11.2017 04:16, Marek Olšák wrote: From: Marek Olšák For lower CPU cache usage. All enums fit within 2 bytes. gl_context = 152400 -> 136824 bytes vbo_context = 22696 -> 21520 bytes Reviewed-by: Nicolai Hähnle --- src/mesa/drivers/dri/nouveau/nv04_state_frag.c | 4 +- src/mesa/d

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-14 Thread Gustaw Smolarczyk
2017-11-14 15:04 GMT+01:00 Marek Olšák : > On Mon, Nov 13, 2017 at 10:19 PM, Ian Romanick wrote: >> On 11/08/2017 07:16 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> For lower CPU cache usage. All enums fit within 2 bytes. >> >> Have you benchmarked this on anything? My recollection is th

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Zhang, Boyuan
On 14/11/17 10:53, Andy Furniss wrote: >> Zhang, Boyuan wrote: >>> >>> >>> -Original Message- >>> From: Zhang, Boyuan >>> Sent: November-13-17 11:41 AM >>> To: Andy Furniss; Koenig, Christian; Mark Thompson; >>> mesa-dev@lists.freedesktop.org >>> Subject: RE: [Mesa-dev] [PATCH 10/18] rade

[Mesa-dev] [PATCH mesa 1/2] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

2017-11-14 Thread Eric Engestrom
From: Eric Engestrom This is a revert of Marek's 84f3afc2e122cb418573 revert, with a missing line added back. I failed a rebase and dropped that crucial line, and didn't do a runtime test after my rebase, and as a result broke EGL for everyone. This commit has been tested by Intel's CI and I re-r

[Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-11-14 Thread Eric Engestrom
This is a revert of Marek's 2cb9ab53dd3ae6850a26 revert. It was needed to revert the previous commit, and didn't have any issue itself. -- The "DRI2" name was reported as confusing when printing EGL infos (one user reported thinking DRI3 was not working on his X server), and the only alternative i

Re: [Mesa-dev] [PATCH 08/14] anv: Move get_fast_clear_state_address into anv_private.h

2017-11-14 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/14] intel/blorp: Take a range of layers in blorp_ccs_resolve

2017-11-14 Thread Lionel Landwerlin
On 13/11/17 16:12, Jason Ekstrand wrote: --- src/intel/blorp/blorp.h | 3 ++- src/intel/blorp/blorp_clear.c | 7 +-- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blor

Re: [Mesa-dev] [PATCH] swr/rast: Use gather instruction for i32gather_ps on simd16/avx512

2017-11-14 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Nov 13, 2017, at 8:03 PM, Tim Rowley wrote: > > Speed up avx512 platforms; fixes performance regression caused > by swithc to simdlib. > > Cc: mesa-sta...@lists.freedesktop.org > --- > .../drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 12 +

Re: [Mesa-dev] [PATCH] swr/rast: Faster emulated simd16 permute

2017-11-14 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Nov 13, 2017, at 8:03 PM, Tim Rowley wrote: > > Speed up simd16 frontend (default) on avx/avx2 platforms; > fixes performance regression caused by switch to simdlib. > > Cc: mesa-sta...@lists.freedesktop.org > --- > .../swr/rasterizer/common/simdlib_512_emu.in

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-14 Thread Ian Romanick
On 11/13/2017 10:49 PM, Timothy Arceri wrote: > > > On 14/11/17 13:30, Ian Romanick wrote: >> On 11/10/2017 02:35 AM, Timothy Arceri wrote: >>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h >>> index 6b5c5bbb36..7c357b07ee 100644 >>> --- a/src/mesa/main/mtypes.h >>> +++ b/src/mesa/

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

2017-11-14 Thread Michel Dänzer
On 13/11/17 04:39 AM, Matias N. Goldberg wrote: > > I am on a Radeon RX 560 2GB; using mesa git-57c8ead0cd (So... not too new not > too old), Kernel 4.12.10 > > I've been having complaints about our WIP branch of Ogre 2.2 about out of > memory crashes, and I fixed them. > > I made a stress tes

Re: [Mesa-dev] [PATCH 09/14] anv: Let blorp handle indirect clear colors for CCS resolves

2017-11-14 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Fix extract_i8/u8 to a 64-bit destination

2017-11-14 Thread Matt Turner
On Mon, Nov 13, 2017 at 11:20 PM, Jason Ekstrand wrote: > On November 13, 2017 22:54:02 Matt Turner wrote: > >> On Mon, Nov 13, 2017 at 10:06 PM, Jason Ekstrand >> wrote: >>> >>> On Mon, Nov 13, 2017 at 3:23 PM, Matt Turner wrote: The MOV instruction can extract bytes to words/do

Re: [Mesa-dev] [PATCH 11/14] intel/blorp: Add a helper for filling out VERTEX_BUFFER_STATE

2017-11-14 Thread Lionel Landwerlin
On 13/11/17 16:12, Jason Ekstrand wrote: There are enough #ifs in there that it's kind-of pointless to duplicate it for each buffer. --- src/intel/blorp/blorp_genX_exec.h | 69 +++ 1 file changed, 33 insertions(+), 36 deletions(-) diff --git a/src/intel/blo

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Andy Furniss
Mark Thompson wrote: On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn: a

[Mesa-dev] [PATCH 2/3] vulkan/wsi: Drop the memory field from wsi_image in favor of driver_private

2017-11-14 Thread Jason Ekstrand
We don't actually need the memory object for anything, it's entirely private to the driver. We're about to have stuff that's even more private to the driver so we will want a driver_private anyway. --- src/amd/vulkan/radv_wsi.c | 4 ++-- src/intel/vulkan/anv_wsi.c | 5 +++-- src/vulkan/wsi/wsi

[Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

2017-11-14 Thread Jason Ekstrand
This commit significantly reworks the way prime support works and lets us pull it even further into radv. The old mechanism required the specific WSI layer to be aware of the linear shadow copy that has to be done in order for prime to work. In the new paradigm, we better define what bits of wsi_

[Mesa-dev] [PATCH 1/3] vulkan/wsi: Add a wsi_image structure

2017-11-14 Thread Jason Ekstrand
From: Daniel Stone This is used to hold information about the allocated image, rather than an ever-growing function argument list. v2 (Jason Ekstrand): - Rename wsi_image_base to wsi_image Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/amd/vulkan/radv_wsi.c | 31 +

[Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

2017-11-14 Thread Gert Wollny
Although the EOP bit is documented for the vertex fetch clause, it is not properly interpreted. As a result the piglit spec/arb_tessellation_shader/execution/trivial-tess-gs_no-gs-inputs creates a TESS_EVAL shader that does not have an EOP clause, which might result in a GPU lockup. This patch f

Re: [Mesa-dev] [PATCH] i965: disable BLORP color clears for gen 4-5

2017-11-14 Thread Matt Turner
On Thu, Nov 9, 2017 at 9:23 AM, Jason Ekstrand wrote: > This is a really rubbish solution. Yes, it fixes a crash in MPV but unless > we disable all blorp on gen4-5 (which I don't think is possible anymore), we > haven't actually fixed it for real. Are you planning to look into it? It's one week

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc4

2017-11-14 Thread Matt Turner
On Tue, Nov 14, 2017 at 6:37 AM, Emil Velikov wrote: > The fourth release candidate for Mesa 17.3.0 is now available. > > As per the issue tracker [1] we still have a number of outstanding bugs > blocking the release. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=103491 > > Andreas Boll (3)

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Andy Furniss
Zhang, Boyuan wrote: On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn:

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc4: fix indentation in vc4_screen.c

2017-11-14 Thread Eric Anholt
Andres Rodriguez writes: > Stumbled into this when adding a new PIPE_CAP. > > Signed-off-by: Andres Rodriguez Reviewed this one, and pushed the series with nh's reviews added. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Zhang, Boyuan
Zhang, Boyuan wrote: >> >> On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: > > > -Original Message- > From: Zhang, Boyuan > Sent: November-13-17 11:41 AM > To: Andy Furniss; Koenig, Christian; Mark Thompson; > mesa-dev@lists.freedesktop.org >>>

[Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

2017-11-14 Thread Adam Jackson
This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. v3: Fix glvnd path and dri2_convert_glx_attribs() Khronos: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 Reviewed-by: Kenneth Graunke Signed-off-by: Adam Jackson

[Mesa-dev] [PATCH 0/6] glx: Implement GLX_EXT_no_config_context

2017-11-14 Thread Adam Jackson
The first three here are mostly cleanup, but after that it got complicated. 4/6 addresses a longstanding bug in the GLX client code where direct contexts would generate no protocol on MakeCurrent, which means the server was unable to know what drawables were bound to a context. We're not presently

[Mesa-dev] [PATCH 1/6] glx: Simplify some dummy vtable interactions

2017-11-14 Thread Adam Jackson
The dummy vtable has these slots as NULL already, no need to check for the dummy context explicitly. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index c707d0cedf..bc93d62510

[Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

2017-11-14 Thread Adam Jackson
Somewhat terrifyingly, we never sent this for direct contexts, which means the server never knew the context/drawable bindings. To handle this sanely, pull the request code up out of the indirect backend, and rewrite the context switch path to call it as appropriate. This attempts to preserve the

[Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

2017-11-14 Thread Adam Jackson
Only relevant for indirect contexts, so let's get that code out of the common path. Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 12 src/glx/indirect_glx.c | 18 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/glx/glxcurrent.c b/sr

[Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts

2017-11-14 Thread Adam Jackson
When we look up the DRI drawable state we need to associate an fbconfig with the drawable. With GLX_EXT_no_config_context we can no longer infer that from the context and must instead query the server. Signed-off-by: Adam Jackson --- src/glx/dri_common.c | 22 -- src/glx/glx

[Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-14 Thread Adam Jackson
This also fixes a bug, the error path through MakeCurrent didn't translate the error code by the extension's error base. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c| 10 +- src/glx/glxcurrent.c | 20 +++- 2 files changed, 4 insertions(+), 26 deletions(-) diff -

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-11-14 Thread Mun, Gwan-gyeong
Hi all, I am sorry that I didn't have enough discussion about why new window system code is needed for Tizen on mesa. This is a brief architecture of Tizen Window System. +--+ |

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-14 Thread Andy Furniss
Zhang, Boyuan wrote: Zhang, Boyuan wrote: On 14/11/17 10:53, Andy Furniss wrote: Zhang, Boyuan wrote: -Original Message- From: Zhang, Boyuan Sent: November-13-17 11:41 AM To: Andy Furniss; Koenig, Christian; Mark Thompson; mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATC

Re: [Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-14 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/14/2017 12:13 PM, Adam Jackson wrote: > This also fixes a bug, the error path through MakeCurrent didn't > translate the error code by the extension's error base. > > Signed-off-by: Adam Jackson > --- > src/glx/glxcmds.c| 10 +- > src/

Re: [Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

2017-11-14 Thread Ian Romanick
On 11/14/2017 12:13 PM, Adam Jackson wrote: > Only relevant for indirect contexts, so let's get that code out of the > common path. > > Signed-off-by: Adam Jackson > --- > src/glx/glxcurrent.c | 12 > src/glx/indirect_glx.c | 18 +++--- > 2 files changed, 15 insertions

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-14 Thread Zhang, Boyuan
If there is no objection, the patches will be pushed by the end of the week. Thanks, Boyuan -Original Message- From: Zhang, Boyuan Sent: November-08-17 1:08 PM To: mesa-dev@lists.freedesktop.org Cc: alexdeuc...@gmail.com; dy...@pnwbakers.com; mar...@gmail.com; ckoenig.leichtzumer...@gma

  1   2   >