Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-24 Thread Jordan Justen
On 2017-10-23 19:48:51, Jason Ekstrand wrote: > > On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen > wrote: > > > + #define SET_UPLOAD_PARAMS(sh, sh_caps, prog) \ > > + do { \ > > + prog_key.sh.program_st

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] auxiliary: use vl_drm_screen_create method for surfaceless

2017-10-24 Thread Sharma, Deepak
Hi Emil, Is your suggestion is to build mesa in chrome using --with-platforms=drm and --with-platforms=surfaceless both ? I am not sure if that is required for chrome. The approach we are taking here is to build mesa only with --with-platforms=surfaceless and leverage existing VA_DISPLAY_DRM*

Re: [Mesa-dev] [PATCH] radv: only emit dfsm packets if dfsm is allowed.

2017-10-24 Thread Bas Nieuwenhuizen
r-b On Tue, Oct 24, 2017 at 5:04 AM, Dave Airlie wrote: > From: Dave Airlie > > radeonsi only emits these when dfsm is enabled, so for now > just hinge them on a flag we never set. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- > src/amd/vulkan/radv_private

[Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/formatquery.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 9c53d7c..619904f 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -919,20 +919,25 @@ _mesa_Ge

Re: [Mesa-dev] [PATCH] loader/dri3: Try to make sure we only process our own NotifyMSC events

2017-10-24 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 20.10.2017 18:22, Michel Dänzer wrote: From: Michel Dänzer We were using a sequence counter value to wait for a specific NotifyMSC event. However, we can receive events from other clients as well, which may already be using higher sequence numbers than us. In t

Re: [Mesa-dev] [PATCH 0/3] OpenGL 3.1 with ARB_compatibility

2017-10-24 Thread Nicolai Hähnle
On 21.10.2017 14:54, Marek Olšák wrote: Hi, This shouldn't be a surprise to some of you. Let's say this is a new trend in Mesa. Hooray! :) For the series: Reviewed-by: Nicolai Hähnle OpenGL 3.1 with ARB_compatibility is tiny since most of the work was done a long time ago. This is not

Re: [Mesa-dev] [PATCH] radeonsi: add a workaround for weird s_buffer_load_dword behavior on SI

2017-10-24 Thread Nicolai Hähnle
On 22.10.2017 23:19, Marek Olšák wrote: From: Marek Olšák See my LLVM patch which fixes the root cause. Users have to apply this patch and then they have 2 choices: - Downgrade to LLVM 5.0 - Update to LLVM git after my LLVM patch is pushed. It won't be possible to use current and earlier deve

Re: [Mesa-dev] [PATCH] radv: only emit dfsm packets if dfsm is allowed.

2017-10-24 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/24/2017 05:04 AM, Dave Airlie wrote: From: Dave Airlie radeonsi only emits these when dfsm is enabled, so for now just hinge them on a flag we never set. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- src/amd/vulkan/radv_pri

[Mesa-dev] [PATCH v2 1/8] glsl/linker: report linker errors for invalid explicit locations on inputs

2017-10-24 Thread Iago Toral Quiroga
We were assuming that if an input has an invalid explicit location it would fail to link because it would not find the corresponding output, however, since we look for the matching output by indexing the explicit_locations array with the input location, we still need to ensure that we don't index o

[Mesa-dev] [PATCH v2 2/8] glsl/linker: refactor link-time validation of output locations

2017-10-24 Thread Iago Toral Quiroga
Move the checks for explicit locations to a separate function. We will use this in a follow-up patch to validate locations for interface variables where we need to validate each interface member rather than the interface variable itself. Reviewed-by: Timothy Arceri --- src/compiler/glsl/link_var

[Mesa-dev] [PATCH v2 4/8] glsl/linker: outputs in the same location must share interpolation

2017-10-24 Thread Iago Toral Quiroga
From ARB_enhanced_layouts: "[...]when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer) and the same auxiliary storage and interpolation qualification.[...]" Add code to the linker to validate that aliased locations do

[Mesa-dev] [PATCH v2 3/8] glsl/linker: fix location aliasing checks for interface variables

2017-10-24 Thread Iago Toral Quiroga
The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to check aliasing for each member in the interface variable. Surprisingly, there are piglit tests that verify this and were passing due to a bug in the existing code: when we wer

[Mesa-dev] [PATCH v2 0/8] glsl/linker: fix location aliasing checks

2017-10-24 Thread Iago Toral Quiroga
This v2 series is in fact an update and merge of the these two series: "glsl/linker: fix location aliasing checks" and "Implement location aliasing checks for SSO programs" This v2 series introduces 3 changes: 1. Use MAX_VARYINGS instead of MAX_VARYINGS_INCL_PATCH to define the size of the ex

[Mesa-dev] [PATCH v2 7/8] glsl/linker: generalize validate_explicit_variable_location for SSO

2017-10-24 Thread Iago Toral Quiroga
For non-SSO programs, we only need to validate outputs, since the cross validation of outputs to inputs will ensure that we produce linker errors for invalid inputs too. Hoever, for the SSO path there is no output to input validation, so we need to validate inputs explicitly. Generalize the functi

[Mesa-dev] [PATCH v2 5/8] glsl/linker: outputs in the same location must share auxiliary storage

2017-10-24 Thread Iago Toral Quiroga
From ARB_enhanced_layouts: "[...]when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer) and the same auxiliary storage and interpolation qualification.[...]" Add code to the linker to validate that aliased locations

[Mesa-dev] [PATCH v2 8/8] glsl/linker: validate explicit locations for SSO programs

2017-10-24 Thread Iago Toral Quiroga
v2: - we only need to validate inputs to the first stage and outputs from the last stage, everything else has already been validated during cross_validate_outputs_to_inputs (Timothy). - Use MAX_VARYING instead of MAX_VARYINGS_INCL_PATCH (Illia) --- src/compiler/glsl/link_varyings.cpp | 55

[Mesa-dev] [PATCH v2 6/8] glsl/linker: create a helper function to validate explicit locations

2017-10-24 Thread Iago Toral Quiroga
Currently, we only validate explicit locations for non-SSO programs. This creates a helper that we can call from both SSO and non-SSO paths directly, so we can reuse all the logic behind this. Reviewed-by: Timothy Arceri --- src/compiler/glsl/link_varyings.cpp | 94 ++

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 24/10/17 11:02, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/formatquery.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c > index 9c53d7c..619904f 100644 > --- a/src/m

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Alejandro Piñeiro
Well, I have just realized one thing: "more TBO fixes"? did I miss the first TBO fixes? On 24/10/17 11:02, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/formatquery.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/for

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

2017-10-24 Thread Muthukumar, Aravindan
> -Original Message- > From: Ian Romanick [mailto:i...@freedesktop.org] > Sent: Friday, October 20, 2017 9:51 AM > To: Muthukumar, Aravindan ; mesa- > d...@lists.freedesktop.org > Cc: J Karanje, Kedar ; Tamminen, Eero T > > Subject: Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index c

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 11:41, Alejandro Piñeiro wrote: > Well, I have just realized one thing: "more TBO fixes"? did I miss the > first TBO fixes? Never mind, I found it on the ARB_compatibility thread. Sorry for the noise. > > On 24/10/17 11:02, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/me

Re: [Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-24 Thread Alejandro Piñeiro
On 21/10/17 14:54, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/formatquery.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c > index 77c7faa..05b7810 100644 > --- a/src/mesa/main/formatquery.c > +++ b/src/m

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Marek Olšák
Also: "mesa: fix GL_{COLOR,DEPTH,STENCIL}_COMPONENTS queries for TBOs" Marek On Tue, Oct 24, 2017 at 11:44 AM, Alejandro Piñeiro wrote: > On 24/10/17 11:41, Alejandro Piñeiro wrote: >> Well, I have just realized one thing: "more TBO fixes"? did I miss the >> first TBO fixes? > > Never mind, I fo

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 11:38, Alejandro Piñeiro wrote: > Reviewed-by: > Alejandro Piñeiro I would need to withdraw this. Sorry for all this noise. Not a really good morning. > > On 24/10/17 11:02, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/main/formatquery.c | 8 >> 1 file cha

Re: [Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-24 Thread Marek Olšák
On Tue, Oct 24, 2017 at 11:47 AM, Alejandro Piñeiro wrote: > On 21/10/17 14:54, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/main/formatquery.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c >> index 77c

Re: [Mesa-dev] [PATCH] mesa: more TBO fixes for ARB_internalformat_query2

2017-10-24 Thread Marek Olšák
On Tue, Oct 24, 2017 at 11:52 AM, Alejandro Piñeiro wrote: > On 24/10/17 11:38, Alejandro Piñeiro wrote: >> Reviewed-by: >> Alejandro Piñeiro > > I would need to withdraw this. Sorry for all this noise. Not a really > good morning. See the beginning of _is_resource_supported. Marek

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-24 Thread Daniel Stone
Hi, On 24 October 2017 at 07:01, Pekka Paalanen wrote: > On Mon, 23 Oct 2017 16:41:14 +0100 > Daniel Stone wrote: >> When a compositor wants to import a buffer into GBM, it calls >> gbm_bo_import(), which will call wl_drm_buffer_get(). >> wl_drm_buffer_get will test (resource->interface == >> &w

[Mesa-dev] [PATCH] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-24 Thread Samuel Pitoiset
It appears that flushing the DB metadata is actually not sufficient since the driver uses the new VS blit shaders. This looks quite strange though, but it seems like we need to flush DB for fixing the corruption. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102955 Fixes: 69ccb9dae7 (rade

Re: [Mesa-dev] [PATCH v2 0/8] glsl/linker: fix location aliasing checks

2017-10-24 Thread Timothy Arceri
1 & 8: Reviewed-by: Timothy Arceri Thanks! On 24/10/17 20:28, Iago Toral Quiroga wrote: This v2 series is in fact an update and merge of the these two series: "glsl/linker: fix location aliasing checks" and "Implement location aliasing checks for SSO programs" This v2 series introduces 3 cha

Re: [Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 11:53, Marek Olšák wrote: > On Tue, Oct 24, 2017 at 11:47 AM, Alejandro Piñeiro > wrote: >> On 21/10/17 14:54, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/mesa/main/formatquery.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/src/mesa/main/format

Re: [Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-24 Thread Marek Olšák
On Tue, Oct 24, 2017 at 12:09 PM, Alejandro Piñeiro wrote: > On 24/10/17 11:53, Marek Olšák wrote: >> On Tue, Oct 24, 2017 at 11:47 AM, Alejandro Piñeiro >> wrote: >>> On 21/10/17 14:54, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/formatquery.c | 5 + 1 f

Re: [Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 12:18, Marek Olšák wrote: > On Tue, Oct 24, 2017 at 12:09 PM, Alejandro Piñeiro > wrote: >> On 24/10/17 11:53, Marek Olšák wrote: >>> On Tue, Oct 24, 2017 at 11:47 AM, Alejandro Piñeiro >>> wrote: On 21/10/17 14:54, Marek Olšák wrote: > From: Marek Olšák > > ---

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-24 Thread Daniel Stone
Hi Emil, On 7 September 2017 at 19:05, Emil Velikov wrote: > diff --git a/src/egl/wayland/wayland-drm/wayland-drm.h > b/src/egl/wayland/wayland-drm/wayland-drm.h > index 77e8d273042..8dc7f6089ae 100644 > --- a/src/egl/wayland/wayland-drm/wayland-drm.h > +++ b/src/egl/wayland/wayland-drm/wayland-

Re: [Mesa-dev] [PATCH] i965: Don't disable CCS for RT dependencies when dispatching compute.

2017-10-24 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga BTW, thanks for fixing the original dependency issue, I was about to start looking into those test failures when you landed the fix :) Iago On Mon, 2017-10-23 at 22:21 -0700, Kenneth Graunke wrote: > Compute shaders don't have access to the framebuffer, so there'

Re: [Mesa-dev] [PATCH v3 05/43] nir: Populate conversion opcodes to/from 16-bit types

2017-10-24 Thread Chema Casanova
El 21/10/17 a las 11:44, Pohjolainen, Topi escribió: > On Sat, Oct 21, 2017 at 11:22:45AM +0300, Pohjolainen, Topi wrote: >> On Thu, Oct 12, 2017 at 08:37:54PM +0200, Jose Maria Casanova Crespo wrote: >>> From: Eduardo Lima Mitev >>> >>> This will include the following NIR ALU opcodes: >>> * nir_

Re: [Mesa-dev] [PATCH v3 29/43] i965/fs: Unpack 16-bit from 32-bit components in VS load_input

2017-10-24 Thread Chema Casanova
El 15/10/17 a las 12:59, Pohjolainen, Topi escribió: > On Thu, Oct 12, 2017 at 08:38:18PM +0200, Jose Maria Casanova Crespo wrote: >> The VS load input for 16-bit values receives pairs of 16-bit values >> packed in 32-bit values. Because of the adjusted format used at: >> >> anv/pipeline: Use 32-b

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #4 from Vedran Miletić --- (In reply to Cris from comment #2) > Oh yeah, I blacklisted radeon (and checked with lsmod | grep radeon) and it > still didn't work. That's not enough. You have to recompile the kernel with AMDGPU CIK sup

[Mesa-dev] [PATCH v3 27/43] anv/pipeline: Use 32-bit surface formats for 16-bit formats (v2)

2017-10-24 Thread Jose Maria Casanova Crespo
From: Alejandro Piñeiro From Vulkan 1.0.50 spec, Section 3.30.1. Format Definition: VK_FORMAT_R16G16_SFLOAT A two-component, 32-bit signed floating-point format that has a 16-bit R component in bytes 0..1, and a 16-bit G component in bytes 2..3. So this format expects those 16-b

Re: [Mesa-dev] [PATCH v3 27/43] anv/pipeline: Use 32-bit surface formats for 16-bit formats

2017-10-24 Thread Chema Casanova
El 16/10/17 a las 08:57, Alejandro Piñeiro escribió: > On 15/10/17 12:14, Pohjolainen, Topi wrote: >> On Thu, Oct 12, 2017 at 08:38:16PM +0200, Jose Maria Casanova Crespo wrote: >>> From: Alejandro Piñeiro >>> >>> From Vulkan 1.0.50 spec, Section 3.30.1. Format Definition: >>> VK_FORMAT_R16G16

Re: [Mesa-dev] [PATCH v3 38/43] i965/fs: Optimize 16-bit SSBO stores by packing two into a 32-bit reg

2017-10-24 Thread Chema Casanova
El 22/10/17 a las 12:31, Eduardo Lima Mitev escribió: > On 10/12/2017 08:38 PM, Jose Maria Casanova Crespo wrote: >> From: Eduardo Lima Mitev >> >> Currently, we use byte-scattered write messages for storing 16-bit >> into an SSBO. This is because untyped surface messages have a fixed >> 32-bit si

[Mesa-dev] [PATCH] radv: allow to use a compute shader for resetting the query pool

2017-10-24 Thread Samuel Pitoiset
Serious Sam Fusion 2017 uses a huge number of occlusion queries, and the allocated query pool buffer is greater than 4096 bytes. This slightly improves performance (tested in Ultra) from 117.2 FPS to 119.7 FPS (~+2%) on my RX480. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c |

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

2017-10-24 Thread Eric Engestrom
Hi, I had a quick glance, but there's too much at once. On Monday, 2017-10-23 17:58:46 +0200, Jerome Duval wrote: > * configure.ac: > -pthread is not available on Haiku. > Haiku doesn't require --enable-dri > build hgl on Haiku > * egl/Makefile.am: define backendfiles for Haiku > * src/gall

Re: [Mesa-dev] [PATCH] gallium/util: use util_snprintf() in u_socket_connect()

2017-10-24 Thread Eric Engestrom
On Monday, 2017-10-23 15:27:31 -0600, Brian Paul wrote: > Instead of plain snprintf(). To fix the MSVC build. > > snprintf() is used in various places in Mesa/gallium, but apparently, > not in code built with MSVC. Not sure I understand this sentence, but the patch is Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] automake: intel: correctly append to the LIBADD variable

2017-10-24 Thread Eric Engestrom
On Monday, 2017-10-23 13:29:30 +0100, Emil Velikov wrote: > From: Emil Velikov > > Commit 05fc62d89f5 sets the variable, yet it forgot the update the > existing reference to append (instead of assign). > > Thus as-is the expat library was discarded from the link chain when > building with Androi

Re: [Mesa-dev] [PATCH 2/5] loader: use drmGetDeviceNameFromFd2 from libdrm

2017-10-24 Thread Eric Engestrom
On Monday, 2017-10-23 23:20:40 +0300, Greg V wrote: > Reduce code duplication and automatically benefit from OS-specific > fixes to libdrm (e.g. in FreeBSD ports). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103283 drmGetDeviceNameFromFd2 was introduced in libdrm-2.4.74, and we alr

Re: [Mesa-dev] [PATCH 5/5] util: use OpenBSD/NetBSD code on FreeBSD/DragonFly

2017-10-24 Thread Eric Engestrom
On Monday, 2017-10-23 23:20:43 +0300, Greg V wrote: > Obtained from: FreeBSD ports > --- > src/util/u_endian.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/u_endian.h b/src/util/u_endian.h > index b9d563dd43..7be33dd3a5 100644 > --- a/src/util/u_endian.h > +++

Re: [Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 03:28, Ilia Mirkin wrote: > On Mon, Oct 23, 2017 at 9:16 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/main/formatquery.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c >> index 05

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

2017-10-24 Thread Vedran Miletić
On 10/23/2017 05:24 AM, Jan Vesely wrote: > From: Jan Vesely > > v2: use a more generic compat function > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103388 > Signed-off-by: Jan Vesely > --- > src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 5 ++--- > src/gallium/stat

Re: [Mesa-dev] [PATCH] gallium/util: use util_snprintf() in u_socket_connect()

2017-10-24 Thread Brian Paul
On 10/24/2017 06:57 AM, Eric Engestrom wrote: On Monday, 2017-10-23 15:27:31 -0600, Brian Paul wrote: Instead of plain snprintf(). To fix the MSVC build. snprintf() is used in various places in Mesa/gallium, but apparently, not in code built with MSVC. Not sure I understand this sentence, bu

Re: [Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-24 Thread Marek Olšák
On Tue, Oct 24, 2017 at 3:30 PM, Alejandro Piñeiro wrote: > On 24/10/17 03:28, Ilia Mirkin wrote: >> On Mon, Oct 23, 2017 at 9:16 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/mesa/main/formatquery.c | 11 +++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/

[Mesa-dev] [PATCH mesa] meson: be explicit about the version required

2017-10-24 Thread Eric Engestrom
This way, we know what we're allowed to use (no nested include lists for instance) and users get immediate feedback when trying to use unsupported versions, rather than a cryptic crash or things being silently not built correctly. Cc: Dylan Baker Signed-off-by: Eric Engestrom --- meson.build |

Re: [Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 15:59, Marek Olšák wrote: > On Tue, Oct 24, 2017 at 3:30 PM, Alejandro Piñeiro > wrote: >> On 24/10/17 03:28, Ilia Mirkin wrote: >>> On Mon, Oct 23, 2017 at 9:16 PM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/formatquery.c | 11 +++ 1 fi

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

2017-10-24 Thread Eric Engestrom
On Monday, 2017-10-23 15:39:48 -0600, Benjamin Gordon wrote: > On Mon, Oct 23, 2017 at 11:10 AM, Eric Engestrom > wrote: > > > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: > > > I'm working on radeonsi support in the Chrome OS Android container > > > (ARC++). Mesa in ARC++ uses a

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

2017-10-24 Thread Fredrik Höglund
On Tuesday 17 October 2017, Henri Verbeet wrote: > In particular, if the window was destroyed before the present request > completed, xcb_wait_for_special_event() may never return. > > Note that the usage of xcb_poll_for_special_event() requires a version > of libxcb that includes commit fad81b634

[Mesa-dev] [AppVeyor] mesa master #5916 completed

2017-10-24 Thread AppVeyor
Build mesa 5916 completed Commit 7a6c6e73a8 by Brian Paul on 10/23/2017 9:25 PM: gallium/util: use util_snprintf() in u_socket_connect()\n\nInstead of plain snprintf(). To fix the MSVC build.\n\nsnprintf() is used in various places in Mesa/gallium, but apparen

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #5 from Cris --- (In reply to Emil Velikov from comment #3) > Adding some debug information in radv_EnumeratePhysicalDevices and/or > stepping through it with a debugger might be a good idea. There are multiple > reasons why enumerat

Re: [Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-24 Thread Marek Olšák
These are failing: checks for pnames related to arb_image_load_store that return values from table 3.22 (opengl 4.2): gl_image_compatibility_class gl_image_pixel_format gl_image_pixel_type gl_image_texel_size image_format_compatibility_type pname checks: gl_image_format_compatibility_type Marek

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #6 from Cris --- Apparently beginning with linux 4.13 you have to append "radeon.si_support=0 radeon.cik_support=0 amdgpu.si_support=1 amdgpu.cik_support=1" to the kernel command line. I did, and everything's working just fine. --

[Mesa-dev] [PATCH] meson: add opt-out of libunwind

2017-10-24 Thread Erik Faye-Lund
Libunwind has some issues on some platforms, so let's allow people who have issues to opt-out. This is similar to what we do in automake, and the implementation is modelled after our opt-out for valgrind. Signed-off-by: Erik Faye-Lund --- This fixes a build-problem for me on Arch Linux for ARM.

Re: [Mesa-dev] XDC 2017 feedback

2017-10-24 Thread Andres Gomez
Hi, Just chipping in to leave a couple of additional notes. As other have said before me, I also think the organization was very good. Things mentioned before: * Tables layout: kind of agree it was not great for following the talks but they were also making it easier to talk with other a

Re: [Mesa-dev] [PATCH] meson: add opt-out of libunwind

2017-10-24 Thread Rob Clark
On Tue, Oct 24, 2017 at 10:44 AM, Erik Faye-Lund wrote: > Libunwind has some issues on some platforms, so let's allow people > who have issues to opt-out. This is similar to what we do in automake, > and the implementation is modelled after our opt-out for valgrind. > > Signed-off-by: Erik Faye-Lu

[Mesa-dev] [PATCH 3/3] meson: build freedreno

2017-10-24 Thread Rob Clark
Mostly copy/pasta from Dylan Baker's conversion of nouveau and i965. Signed-off-by: Rob Clark --- meson.build | 6 + meson_options.txt| 2 +- src/gallium/drivers/freedreno/meson.build| 221 +++ src/galli

[Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

2017-10-24 Thread Rob Clark
Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, to prep for meson build support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/Android.gen.mk | 2 +- src/gallium/drivers/freedreno/Makefil

[Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

2017-10-24 Thread Rob Clark
Also needed in freedreno/ir3. Signed-off-by: Rob Clark --- src/compiler/nir/meson.build | 2 ++ src/intel/compiler/meson.build | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build index 144cf01d2c4..4a75c5c8b0d 100644

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

2017-10-24 Thread Henri Verbeet
On 24 October 2017 at 16:11, Fredrik Höglund wrote: >> @@ -934,9 +938,18 @@ x11_manage_fifo_queues(void *state) >> >>while (chain->last_present_msc < target_msc) { >> xcb_generic_event_t *event = >> -xcb_wait_for_special_event(chain->conn, chain->special_event); >> -

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

2017-10-24 Thread Gurchetan Singh
Hi Gwan-yeong, I'm fine with the conventions you suggested -- my main nit was with the verbosity. The downside is you're going to have to downcast every single time. Your call .. On Mon, Oct 23, 2017 at 1:22 PM, Mun, Gwan-gyeong wrote: > Hi Emil and Gurchetan, > > Thank you for reviewing the

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

2017-10-24 Thread Eric Engestrom
On Tuesday, 2017-10-24 11:12:48 -0400, Rob Clark wrote: > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson build support. > > Signed-off-by: Rob Clark Reviewed-by: Eric Engestrom > --

[Mesa-dev] [PATCH] radv: print NIR before LLVM IR and disassembly

2017-10-24 Thread Samuel Pitoiset
It's still printed after linking, but it makes more sense to have SPIRV->NIR->LLVM IR->ASM. Fixes: f0a2bbd1a4 (radv: move nir print after linking is done) Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) d

Re: [Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

2017-10-24 Thread Eric Engestrom
On Tuesday, 2017-10-24 11:12:49 -0400, Rob Clark wrote: > Also needed in freedreno/ir3. > > Signed-off-by: Rob Clark > --- > src/compiler/nir/meson.build | 2 ++ > src/intel/compiler/meson.build | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/meson.

Re: [Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

2017-10-24 Thread Gurchetan Singh
Hi Gwan-gyeong, You should use dri2_surface_free_image in the next patchset you send out (should be pretty easy to implement), but can save the polishing of struct dri2_egl_surface for later. On Mon, Oct 23, 2017 at 1:46 PM, Mun, Gwan-gyeong wrote: > Hi Gurchetan, > > 2017-10-18 6:02 GMT+09:00

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-24 Thread Jason Ekstrand
looks good On Tue, Oct 24, 2017 at 12:06 AM, Jordan Justen wrote: > On 2017-10-23 19:48:51, Jason Ekstrand wrote: > > > > On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen < > jordan.l.jus...@intel.com> > > wrote: > > > > > + #define SET_UPLOAD_PARAMS(sh, sh_caps, prog) \ > >

[Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

2017-10-24 Thread Chris Wilson
Through the use of mocs, we can define the cache usage for any surface used by the GPU. In particular, we can request that L3 cache be allocated for either a read/write miss so that subsequent reads can be fetched from cache rather than memory. A consequence of this is that if we allocate a L3/LLC

[Mesa-dev] [PATCH v2 1/8] Haiku: add src/hgl/Makefile.am and its pkgconfig file

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/hgl/Makefile.am | 50 src/hgl/Makefile.sources | 8 src/hgl/gl.pc.in | 11 +++ 3 files changed, 69 insertions(+) create mode 100644 src/hgl/Makefile.am create mode 100644 src/hgl/Makefile

[Mesa-dev] [PATCH v2 5/8] Haiku: add src/gallium/winsys/sw/hgl/Makefile.am

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/gallium/winsys/sw/hgl/Makefile.am | 34 ++ src/gallium/winsys/sw/hgl/Makefile.sources | 3 +++ 2 files changed, 37 insertions(+) create mode 100644 src/gallium/winsys/sw/hgl/Makefile.am create mode 100644 src/gallium/winsys/sw/hgl/Ma

[Mesa-dev] [PATCH v2 0/8] Haiku: convert to autotools

2017-10-24 Thread Jerome Duval
From: Jérôme Duval Resend as a patch series as requested by Eric Engestrom. Jérôme Duval (8): Haiku: add src/hgl/Makefile.am and its pkgconfig file Haiku: add src/hgl/Makefile.am to the build Haiku: add support in src/egl/Makefile.am Haiku: add src/gallium/state_trackers/hgl/Makefile.am

[Mesa-dev] [PATCH v2 7/8] Haiku: add gallium Haiku components to the build.

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/gallium/Makefile.am | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/Makefile.am b/src/gallium/Makefile.am index ea20799..37800b9 100644 --- a/src/gallium/Makefile.am +++ b/src/gallium/Makefile.am @@ -119,6 +119,10 @@ if HAVE_DRIS

[Mesa-dev] [PATCH v2 4/8] Haiku: add src/gallium/state_trackers/hgl/Makefile.am

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/gallium/state_trackers/hgl/Makefile.am | 39 + src/gallium/state_trackers/hgl/Makefile.sources | 3 ++ 2 files changed, 42 insertions(+) create mode 100644 src/gallium/state_trackers/hgl/Makefile.am create mode 100644 src/gallium/state_t

[Mesa-dev] [PATCH v2 6/8] Haiku: add src/gallium/targets/haiku-softpipe/Makefile.am

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/gallium/targets/haiku-softpipe/Makefile.am | 69 ++ .../targets/haiku-softpipe/SoftwareRenderer.cpp| 2 + 2 files changed, 71 insertions(+) create mode 100644 src/gallium/targets/haiku-softpipe/Makefile.am diff --git a/src/gallium/targets

[Mesa-dev] [PATCH v2 2/8] Haiku: add src/hgl/Makefile.am to the build

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index 5ef2d4f..7ef63f7 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -108,6 +108,10 @@ if HAVE_PLATFORM_WAYLAND SUBDIRS += egl/wayland/wayland-egl endif +i

[Mesa-dev] [PATCH v2 8/8] Haiku: convert to autotools

2017-10-24 Thread Jerome Duval
From: Jérôme Duval * -pthread is not available on Haiku. * Haiku doesn't require --enable-dri --- configure.ac | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 9aa02f5..58795e5 100644 --- a/configure.ac +++ b/co

[Mesa-dev] [PATCH v2 3/8] Haiku: add support in src/egl/Makefile.am

2017-10-24 Thread Jerome Duval
From: Jérôme Duval --- src/egl/Makefile.am | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am index eeb745f..9b8528645 100644 --- a/src/egl/Makefile.am +++ b/src/egl/Makefile.am @@ -52,6 +52,7 @@ libEGL_common_la_LIB

[Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-24 Thread Emil Velikov
From: Emil Velikov The function is effectively a direct function call into libwayland-server.so. Thus GBM no longer depends on the wayland-drm static library, making the build more straight forward. And the resulting binary is a bit smaller. Note: we need to move struct wayland_drm_callbacks fu

Re: [Mesa-dev] Build mesa-dev on Windows with AVX instruction set problem

2017-10-24 Thread Fabrício Ceolin
Hi, I am trying to build mesa-dev on windows. I am learning how to do it, through the project https://github.com/ pal1000/mesa-dist-win/tree/master/buildscript I tried to use the binaries from pal1000, but I got an illegal instruction problem in opengl32.dll when I tried to run my application (V

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #7 from Vedran Miletić --- (In reply to Cris from comment #6) > Apparently beginning with linux 4.13 you have to append "radeon.si_support=0 > radeon.cik_support=0 amdgpu.si_support=1 amdgpu.cik_support=1" to the kernel > command lin

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-24 Thread Emil Velikov
Hi Marek, On 21 October 2017 at 13:54, Marek Olšák wrote: > From: Marek Olšák > > We already have piglit tests testing alpha, luminance, and intensity > formats. They were skipped by piglit until now. > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run > with the compa

Re: [Mesa-dev] [PATCH 3/3] meson: build freedreno

2017-10-24 Thread Eric Engestrom
On Tuesday, 2017-10-24 11:12:50 -0400, Rob Clark wrote: > Mostly copy/pasta from Dylan Baker's conversion of nouveau and i965. > > Signed-off-by: Rob Clark > --- > meson.build | 6 + > meson_options.txt| 2 +- > src/gallium/drivers

Re: [Mesa-dev] [PATCH 2/3] meson: extract out variable for nir_algebraic.py

2017-10-24 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-24 08:24:39) > On Tuesday, 2017-10-24 11:12:49 -0400, Rob Clark wrote: > > Also needed in freedreno/ir3. > > > > Signed-off-by: Rob Clark > > --- > > src/compiler/nir/meson.build | 2 ++ > > src/intel/compiler/meson.build | 2 +- > > 2 files changed, 3 insertion

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

2017-10-24 Thread Jérôme Duval
Hi, 2017-10-24 14:46 GMT+02:00 Eric Engestrom : > I had a quick glance, but there's too much at once. > > On Monday, 2017-10-23 17:58:46 +0200, Jerome Duval wrote: >> * configure.ac: >> -pthread is not available on Haiku. >> Haiku doesn't require --enable-dri >> build hgl on Haiku >> * egl/M

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

2017-10-24 Thread Dylan Baker
The python is correct, and I believe that the autotools is correct, Reviewed-by: Dylan Baker Quoting Rob Clark (2017-10-24 08:12:48) > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson bu

Re: [Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

2017-10-24 Thread Emil Velikov
On 21 October 2017 at 13:54, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/mtypes.h | 1 + > src/mesa/main/version.c | 13 - > 3 files changed, 10 insertions(+), 5 deletions(-) > Do we want to update src/

Re: [Mesa-dev] [PATCH 3/3] meson: build freedreno

2017-10-24 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Rob Clark (2017-10-24 08:12:50) > Mostly copy/pasta from Dylan Baker's conversion of nouveau and i965. > > Signed-off-by: Rob Clark > --- > meson.build | 6 + > meson_options.txt| 2 +- > src/gall

Re: [Mesa-dev] [PATCH mesa] meson: be explicit about the version required

2017-10-24 Thread Dylan Baker
This seems reasonable, could you wrap the hanging indent like meson_options with the closing brace on it's own line and with each option on its own line? ie: project( mesa ... ) With that: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-24 07:04:01) > This way, we know what we're al

[Mesa-dev] [PATCH v2] clover/llvm: Drop support for LLVM < 3.9.

2017-10-24 Thread Vedran Miletić
v2: remove/inline compat stuff Reviewed-by: Francisco Jerez --- .../state_trackers/clover/llvm/codegen/native.cpp | 8 +- src/gallium/state_trackers/clover/llvm/compat.hpp | 109 + .../state_trackers/clover/llvm/invocation.cpp | 22 +++-- .../state_trackers/clover/l

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

2017-10-24 Thread Emil Velikov
Hi Jerome, On 23 October 2017 at 16:58, Jerome Duval wrote: > * configure.ac: > -pthread is not available on Haiku. > Haiku doesn't require --enable-dri > build hgl on Haiku > * egl/Makefile.am: define backendfiles for Haiku > * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/h

Re: [Mesa-dev] [PATCH 1/3] freedreno/ir3: use a flag instead of setting PYTHONPATH

2017-10-24 Thread Emil Velikov
On 24 October 2017 at 16:12, Rob Clark wrote: > Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to > ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, > to prep for meson build support. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/Androi

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

2017-10-24 Thread Emil Velikov
On 17 October 2017 at 15:18, Henri Verbeet wrote: > In particular, if the window was destroyed before the present request > completed, xcb_wait_for_special_event() may never return. > > Note that the usage of xcb_poll_for_special_event() requires a version > of libxcb that includes commit fad81b63

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

2017-10-24 Thread Emil Velikov
On 23 October 2017 at 18:10, Eric Engestrom wrote: > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: >> I'm working on radeonsi support in the Chrome OS Android container >> (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all >> the necessary EGL bits are there, so t

Re: [Mesa-dev] [PATCH] meson: add opt-out of libunwind

2017-10-24 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Erik Faye-Lund (2017-10-24 07:44:21) > Libunwind has some issues on some platforms, so let's allow people > who have issues to opt-out. This is similar to what we do in automake, > and the implementation is modelled after our opt-out for valgrind. > > Signed-off-

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-10-24 Thread Emil Velikov
On 24 October 2017 at 02:10, Harish Krupo wrote: > Hi Emil, > > Emil Velikov writes: > >> On 23 October 2017 at 11:50, Harish Krupo wrote: >>> This passes 33/37 deqp tests related to partial_update, 4 are not >>> supported. Tests not supported: >>> dEQP-EGL.functional.negative_partial_update.not

Re: [Mesa-dev] [PATCH] vulkan/wsi: Avoid waiting indefinitely for present completion in x11_manage_fifo_queues().

2017-10-24 Thread Henri Verbeet
On 24 October 2017 at 20:31, Emil Velikov wrote: > On 17 October 2017 at 15:18, Henri Verbeet wrote: >> Note that the usage of xcb_poll_for_special_event() requires a version >> of libxcb that includes commit fad81b63422105f9345215ab2716c4b804ec7986 >> to work properly. >> > What should we expect

  1   2   >