Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

Reviewed-by: Samuel Pitoiset On 10/12/2017 01:34 AM, Dave Airlie wrote: From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 Fixes: 65d3ef7cd

Re: [Mesa-dev] [PATCH] radv: take unsafe_math and sisched into account when hashing shaders.

Reviewed-by: Samuel Pitoiset On 10/12/2017 06:11 AM, Dave Airlie wrote: From: Dave Airlie We want to generate different variants for sisched and unsafe_math shader variants, so add them to the hash key. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 24 +

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

On Wed, Oct 11, 2017 at 12:25:29PM -0700, Kenneth Graunke wrote: > On Wednesday, October 11, 2017 9:30:27 AM PDT Pohjolainen, Topi wrote: > > On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > > > From: Topi Pohjolainen > > > > I really don't qualify as an author anymore, you two

[Mesa-dev] [PATCH v2 1.2/3] nir: Make nir_shader_gather_info() track texelFetch texture accesses.

For TGSI-based drivers, st_glsl_to_tgsi records this information. For NIR-based drivers, nir_shader_gather_info() will do so. --- src/compiler/nir/nir_gather_info.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) Patches 1.1 and 1.2 here replace: [PATCH 1/3] compiler: Track w

[Mesa-dev] [PATCH v2 1.1/3] compiler: Move gl_program::TexelFetchSamplers to shader_info.

I'd like to put this sort of metadata in the shader_info structure, rather than adding more things to gl_program. --- src/compiler/shader_info.h | 3 +++ src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_atom_texture.c | 2 +- src/mesa/state_tracker/st_g

Re: [Mesa-dev] [PATCH v2 1.2/3] nir: Make nir_shader_gather_info() track texelFetch texture accesses.

On 12.10.2017 09:44, Kenneth Graunke wrote: For TGSI-based drivers, st_glsl_to_tgsi records this information. For NIR-based drivers, nir_shader_gather_info() will do so. --- src/compiler/nir/nir_gather_info.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) Patches 1.1 and

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

On 12 Oct. 2017 15:40, "Tapani Pälli" wrote: On 10/12/2017 02:34 AM, Dave Airlie wrote: > From: Dave Airlie > > When I realigned the bufferobj code, I didn't see the getters > were different, realign the getters to work the same as ssbo. > Alternatively you could set these values as 0 in bin

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

On 10/12/2017 11:14 AM, Dave Airlie wrote: On 12 Oct. 2017 15:40, "Tapani Pälli" > wrote: On 10/12/2017 02:34 AM, Dave Airlie wrote: From: Dave Airlie mailto:airl...@redhat.com>> When I realigned the bufferobj code, I didn't see the gett

Re: [Mesa-dev] [PATCH 00/20] meson, gallium edition

On Wed, Oct 11, 2017 at 7:41 PM, Dylan Baker wrote: > This series is somewhat larger than the one to enable classic drivers. I've > made > an effort to split the patches up better this go around, so hopefully that > will > make review easier. > > I have enabled 3 drivers here, which are probably

[Mesa-dev] [PATCH] amd/common/gfx9: workaround DCC corruption more conservatively

From: Nicolai Hähnle Fixes KHR-GL45.texture_swizzle.smoke and others on Vega. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102809 Cc: mesa-sta...@lists.freedesktop.org --- src/amd/common/ac_surface.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(

Re: [Mesa-dev] [PATCH] anv: Implement VK_ANDROID_native_buffer (v5)

On 10/09/2017 06:56 PM, Chad Versace wrote: On Mon 25 Sep 2017, Tapani Pälli wrote: On 09/22/2017 03:09 AM, Chad Versace wrote: On Thu 21 Sep 2017, Tapani Pälli wrote: Hi Chad; The build works ok now on Android-IA. There is still something wrong with 'exec async' though. It behaves differ

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #2 from Greg V --- (In reply to Pekka Paalanen from comment #1) WL_HIDE_DEPRECATED is what I ended up doing in https://github.com/swaywm/wlroots/pull/252 — the project maintainer told me to report this *because* of WL_HIDE_DEPRECATED

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #3 from Emil Velikov --- (In reply to Greg V from comment #2) > (In reply to Pekka Paalanen from comment #1) > WL_HIDE_DEPRECATED is what I ended up doing in > https://github.com/swaywm/wlroots/pull/252 — the project maintainer told

[Mesa-dev] [PATCH] eglmesaext: add forward declaration for struct wl_buffers

From: Emil Velikov The user does not need to know the specifics of the struct, as only a pointer to it is used. Just forward declare the struct making the header self-contained and effectively removing the deprecation warning coming from the Wayland headers. Cc: Greg V Fixes: 5cddb1ce3c9 ("way

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #4 from Emil Velikov --- Greg there should be a copy of the patch in your inbox. Alternatively you can grab it from patchwork https://patchwork.freedesktop.org/patch/182020/ -- You are receiving this mail because: You are the QA C

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #5 from Greg V --- (In reply to Emil Velikov from comment #3) > Eek... wlroots. Have you tried libweston - I doubt people will > object any sensible API additions if it doesn't suite your needs. My goal was to get wlroots (and by ex

[Mesa-dev] [PATCH] meson: fix typo in isl

Signed-off-by: Elie Tournier --- src/intel/isl/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/meson.build b/src/intel/isl/meson.build index 789175e256..54024b4d11 100644 --- a/src/intel/isl/meson.build +++ b/src/intel/isl/meson.build @@ -101,5 +101,5

Re: [Mesa-dev] [PATCH] meson: fix typo in isl

Reviewed-by: Antia Puentes On 12/10/17 13:24, Elie Tournier wrote: Signed-off-by: Elie Tournier --- src/intel/isl/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/meson.build b/src/intel/isl/meson.build index 789175e256..54024b4d11 100644 --- a/

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #6 from Emil Velikov --- (In reply to Greg V from comment #5) > > - A local forward declaration (like the struct wl_resource one) should > > handle the issue, I'll send a patch in a minute > Just tried that. The warning is still th

Re: [Mesa-dev] [PATCH] eglmesaext: add forward declaration for struct wl_buffers

On Thursday, 2017-10-12 10:39:46 +, Emil Velikov wrote: > From: Emil Velikov > > The user does not need to know the specifics of the struct, as only a > pointer to it is used. > > Just forward declare the struct making the header self-contained and > effectively removing the deprecation warn

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

Tested-by: Mark Janes Dave Airlie writes: > From: Dave Airlie > > When I realigned the bufferobj code, I didn't see the getters > were different, realign the getters to work the same as ssbo. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 > Fixes: 65d3ef7cd (mesa: align atom

[Mesa-dev] [PATCH mesa] egl: remove left over _EGLMain_t

Fixes: b174a1ae720cb404738c "egl: Simplify the "driver" interface" Cc: Adam Jackson Signed-off-by: Eric Engestrom --- src/egl/main/egldriver.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/main/egldriver.h b/src/egl/main/egldriver.h index a8b0cab2b1aa8bcb1fac..d80c768af1bf1a5c84f

Re: [Mesa-dev] [PATCH] eglmesaext: add forward declaration for struct wl_buffers

On 12 October 2017 at 13:51, Eric Engestrom wrote: > On Thursday, 2017-10-12 10:39:46 +, Emil Velikov wrote: >> From: Emil Velikov >> >> The user does not need to know the specifics of the struct, as only a >> pointer to it is used. >> >> Just forward declare the struct making the header self

Re: [Mesa-dev] [PATCH mesa] egl: remove left over _EGLMain_t

On 12 October 2017 at 14:32, Eric Engestrom wrote: > Fixes: b174a1ae720cb404738c "egl: Simplify the "driver" interface" > Cc: Adam Jackson > Signed-off-by: Eric Engestrom Out of curiosity: did you spot this with some tool or by observation? Reviewed-by: Emil Velikov -Emil

[Mesa-dev] Mesa 17.3.0 release plan

Hi all, As you've know the Mesa 17.3.0 release plan has been available for a while on the mesa3d.org website [1]. In case you've missed it here it is: Oct 20 2017 - Feature freeze/Release candidate 1 Oct 27 2017 - Release candidate 2 Nov 03 2017 - Release candidate 3 Nov 10 2017 - Release ca

Re: [Mesa-dev] [PATCH mesa] egl: remove left over _EGLMain_t

On Thursday, 2017-10-12 13:38:47 +, Emil Velikov wrote: > On 12 October 2017 at 14:32, Eric Engestrom wrote: > > Fixes: b174a1ae720cb404738c "egl: Simplify the "driver" interface" > > Cc: Adam Jackson > > Signed-off-by: Eric Engestrom > Out of curiosity: did you spot this with some tool or b

Re: [Mesa-dev] [PATCH v2] etnaviv: Do GC3000 resolve-in-place when possible

Am Dienstag, den 10.10.2017, 13:57 +0200 schrieb Lucas Stach: > Am Samstag, den 30.09.2017, 10:11 +0200 schrieb Wladimir J. van der > Laan: > > If an RS blit is done with source exactly the same as destination, > > and > > the hardware supports this, do an in-place resolve. This only fills > > in >

[Mesa-dev] [PATCH 1/2] etnaviv: skip unused vertex attributes when assigning VS inputs

When not all of the vertex attributes are actually used in the shader, we end up with some inputs without an assigned reg. Those are marked as invalid and must be skipped when assigning the inputs, as those would overwrite other valid inputs otherwise. Fixes piglit drawpixels and a bunch of other

[Mesa-dev] [PATCH 2/2] etnaviv: rework TS enable to be a derived state

Draw operations should not use the TS if the TS buffer content is invalid, as this leads to wrong rendering or even GPU hangs. As the TS valid status can change between draws (clear operations changing it to valid, blits using the RS to the color or ZS buffer changing it to invalid), the TS_MEM_CON

Re: [Mesa-dev] [PATCH v2 0/5] i965: add support for loadable OA configs

On 10/10/17 05:28, Kenneth Graunke wrote: On Tuesday, August 29, 2017 6:05:00 AM PDT Lionel Landwerlin wrote: Hi again, Improvement on detection of loadable configs as suggested by Chris. Change is in patch 4. Patches 1-3 are: Reviewed-by: Kenneth Graunke I'm still not sure about this whole

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 5 October 2017 at 18:11, Tom Stellard wrote: > On 10/05/2017 08:40 AM, Emil Velikov wrote: >> On 5 October 2017 at 16:16, Tom Stellard wrote: >>> On 10/05/2017 06:33 AM, Michel Dänzer wrote: On 05/10/17 12:19 PM, Emil Velikov wrote: > From: Emil Velikov > > A while back Miche

[Mesa-dev] [PATCH] amd/common: run the EarlyCSEMemSSA LLVM pass

It's recommended by the instruction combining pass, and RadeonSI also runs it. The code size should decrease but the number of register might increase a little bit. Though, after comparing the shader stats with DOW3, it appears that the number of registers has been decreased and it gives a very mi

[Mesa-dev] [PATCH mesa v2 1/3] egl_dri2: move glFlush out of struct dri2_egl_driver

From: Eric Engestrom There's no reason to store this there, it doesn't depend on the driver. Signed-off-by: Eric Engestrom --- v2: add lock around setting `glFlush` (Emil) --- src/egl/drivers/dri2/egl_dri2.c | 47 +++-- src/egl/drivers/dri2/egl_dri2.h | 2 -

Re: [Mesa-dev] [PATCH 01/15] i965: Complete 'expose RGBA visuals only on Android'

On 10/11/2017 05:25 PM, Emil Velikov wrote: On 10 October 2017 at 11:34, Tapani Pälli wrote: Reviewed-by: Tapani Pälli I think this fix can/should land separately from the set. Yes, please. Thanks for catching that Mario. Reviewed-by: Emil Velikov -Emil I assume you just pull that patc

Re: [Mesa-dev] [PATCH] meson: fix typo in isl

For list posterity, since my intel mail isn't subscribed to the list... Reviewed-by: Dylan Baker Quoting Elie Tournier (2017-10-12 04:24:10) > Signed-off-by: Elie Tournier > --- > src/intel/isl/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/isl/

Re: [Mesa-dev] [PATCH] meson: fix typo in isl

On 12 October 2017 at 17:12, Dylan Baker wrote: > For list posterity, since my intel mail isn't subscribed to the list... > > Reviewed-by: Dylan Baker Ack. Feel free to push this patch for me. (I don't have git access) > > Quoting Elie Tournier (2017-10-12 04:24:10) >> Signed-off-by: Elie Tourni

Re: [Mesa-dev] [PATCH 00/20] meson, gallium edition

Quoting Erik Faye-Lund (2017-10-12 01:32:51) > On Wed, Oct 11, 2017 at 7:41 PM, Dylan Baker wrote: > > This series is somewhat larger than the one to enable classic drivers. I've > > made > > an effort to split the patches up better this go around, so hopefully that > > will > > make review easi

Re: [Mesa-dev] [PATCH mesa v2 1/3] egl_dri2: move glFlush out of struct dri2_egl_driver

Sorry, misleading subject line: I'm only sending this patch in v2 as the rest of them don't change. On Thursday, 2017-10-12 15:05:01 +, Eric Engestrom wrote: > From: Eric Engestrom > > There's no reason to store this there, it doesn't depend on the driver. > > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 12/10/17 04:14 PM, Emil Velikov wrote: > On 5 October 2017 at 18:11, Tom Stellard wrote: >> On 10/05/2017 08:40 AM, Emil Velikov wrote: >>> On 5 October 2017 at 16:16, Tom Stellard wrote: On 10/05/2017 06:33 AM, Michel Dänzer wrote: > On 05/10/17 12:19 PM, Emil Velikov wrote: >> F

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 10/12/2017 07:14 AM, Emil Velikov wrote: > On 5 October 2017 at 18:11, Tom Stellard wrote: >> On 10/05/2017 08:40 AM, Emil Velikov wrote: >>> On 5 October 2017 at 16:16, Tom Stellard wrote: On 10/05/2017 06:33 AM, Michel Dänzer wrote: > On 05/10/17 12:19 PM, Emil Velikov wrote: >>

[Mesa-dev] [PATCH 1/2] meson: Fix xf86vm dep

From: Ville Syrjälä The pkg-config file is called xxf86vm.pc not xf86vm.pc. Cc: Dylan Baker Cc: Eric Anholt Signed-off-by: Ville Syrjälä --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index bff40f697d37..4ba00283cec7 100644 --- a

[Mesa-dev] [PATCH 2/2] meson: Build i915

From: Ville Syrjälä Build i915 with meson. More or less copied from i965, with all the unneeded cruft removed, and the libdrm_intel dependency added. Cc: Dylan Baker Cc: Eric Anholt Signed-off-by: Ville Syrjälä --- meson.build | 7 +++ meson_options.txt

Re: [Mesa-dev] [PATCH] meson: fix typo in isl

Pushed. Quoting tournier.elie (2017-10-12 09:22:41) > On 12 October 2017 at 17:12, Dylan Baker wrote: > > For list posterity, since my intel mail isn't subscribed to the list... > > > > Reviewed-by: Dylan Baker > > Ack. > Feel free to push this patch for me. (I don't have git access) > > > > Qu

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 12 October 2017 at 17:33, Tom Stellard wrote: > On 10/12/2017 07:14 AM, Emil Velikov wrote: >> On 5 October 2017 at 18:11, Tom Stellard wrote: >>> On 10/05/2017 08:40 AM, Emil Velikov wrote: On 5 October 2017 at 16:16, Tom Stellard wrote: > On 10/05/2017 06:33 AM, Michel Dänzer wrote

Re: [Mesa-dev] [PATCH mesa v2 1/3] egl_dri2: move glFlush out of struct dri2_egl_driver

On 12 October 2017 at 16:05, Eric Engestrom wrote: > From: Eric Engestrom > > There's no reason to store this there, it doesn't depend on the driver. > > Signed-off-by: Eric Engestrom > --- > v2: add lock around setting `glFlush` (Emil) Reviewed-by: Emil Velikov Please give it some time for o

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] radeonsi: hard-code pixel center for interpolateAtSample without multisample buffers

Hi Nicolai, On 11 September 2017 at 16:11, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The GLSL rules for interpolateAtSample are unfortunate: > >"Returns the value of the input interpolant variable at > the location of sample number sample. If > multisample buffers are not avai

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] st/glsl_to_tgsi: fix DFRACEXP with only one destination

On 10 October 2017 at 13:11, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Replace the undefined destination by a new temporary register. > > Cleanup merge_two_dsts while we're at it. > --- Small reminder - this and 3/3 have landed without the tag. Please let me know if we should pick them or

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 12/10/17 06:49 PM, Emil Velikov wrote: > On 12 October 2017 at 17:33, Tom Stellard wrote: >> On 10/12/2017 07:14 AM, Emil Velikov wrote: >>> On 5 October 2017 at 18:11, Tom Stellard wrote: On 10/05/2017 08:40 AM, Emil Velikov wrote: > On 5 October 2017 at 16:16, Tom Stellard wrote: >

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/4] i965/gen10: Enable float blend optimization

Hi Anuj, On 3 October 2017 at 00:07, Anuj Phogat wrote: > This optimization is enabled for previous generations too. > See Mesa commit c17e214a6b > On CNL this bit is moved to 3DSTATE_3D_MODE. > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- Seems like this (and 2/4 a

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] anv: fix push descriptors with set > 0

On 6 October 2017 at 16:42, Lionel Landwerlin wrote: > When writing to set > 0, we were just wrongly writing to set 0. This > commit fixes this by lazily allocating each set as we write to them. > > We didn't go for having them directly into the command buffer as this > would require an additional

Re: [Mesa-dev] [PATCH 2/2] meson: Build i915

Ville Syrjala writes: > From: Ville Syrjälä > > Build i915 with meson. More or less copied from i965, with all > the unneeded cruft removed, and the libdrm_intel dependency added. Both are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] anv: fix push descriptors with set > 0

On 12/10/17 18:15, Emil Velikov wrote: On 6 October 2017 at 16:42, Lionel Landwerlin wrote: When writing to set > 0, we were just wrongly writing to set 0. This commit fixes this by lazily allocating each set as we write to them. We didn't go for having them directly into the command buffer as

Re: [Mesa-dev] [PATCH 7/7] configure.ac: static link LLVM by default

On 12 October 2017 at 18:06, Michel Dänzer wrote: > On 12/10/17 06:49 PM, Emil Velikov wrote: >> On 12 October 2017 at 17:33, Tom Stellard wrote: >>> On 10/12/2017 07:14 AM, Emil Velikov wrote: On 5 October 2017 at 18:11, Tom Stellard wrote: > On 10/05/2017 08:40 AM, Emil Velikov wrote:

[Mesa-dev] [PATCH v2 03/21] meson: add checks for version script and dynamic list

These are used by gallium drivers. Signed-off-by: Dylan Baker --- meson.build | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 48e9e1db08e..8d890e53e12 100644 --- a/meson.build +++ b/meson.build @@ -426,14 +426,28 @@ endif

[Mesa-dev] [PATCH v2 02/21] configure: commit test files

These are currently auto-generated, but meson needs the same files, so lets commit them to reduce duplication. Signed-off-by: Dylan Baker --- .build/conftest.dyn | 3 +++ .build/conftest.map | 6 ++ Makefile.am | 4 +++- configure.ac| 18 ++ 4 files changed

[Mesa-dev] [PATCH v2 01/21] meson: Add switch for texture float

Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 4 meson_options.txt | 2 ++ 2 files changed, 6 insertions(+) diff --git a/meson.build b/meson.build index bff40f697d3..48e9e1db08e 100644 --- a/meson.build +++ b/meson.build @@ -37,6 +37,10 @@ with_vulkan_icd_dir

[Mesa-dev] [PATCH v2 11/21] meson: Build gallium pipe-loader

Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 + src/gallium/auxiliary/pipe-loader/meson.build | 63 +++ src/gallium/meson.build | 2 + 3 files changed, 67 insertions(+) create mode 100644 src/gallium/auxiliary/pi

[Mesa-dev] [PATCH v2 12/21] meson: build gallium helper drivers

This builds ddebug, noop, rbug, and trace drivers. Signed-off-by: Dylan Baker --- src/gallium/{ => drivers/ddebug}/meson.build | 13 - src/gallium/{ => drivers/noop}/meson.build | 12 +++- src/gallium/{ => drivers/rbug}/meson.build | 13 - src/gallium/{ => dri

[Mesa-dev] [PATCH v2 10/21] meson: split and simplify depdendncies

Rather than group dependencies in complex groups, use a flatter structure with split dependencies to avoid checking for the same dependencies twice. v2: - Fix building vulkan drivers without gallium or dri drivers Signed-off-by: Dylan Baker --- meson.build| 197 +

[Mesa-dev] [PATCH v2 00/21] Meson, gallium edition, v2

Notable changes from v1: - LLVM toggle is earlier in the series, which fixes not having LLVm in a number of cases - add nouveau compiler - fix building vulkan drivers without dri or gallium drivers - fix building gallium without llvm Dylan Baker (21): meson: Add switch for texture float conf

[Mesa-dev] [PATCH v2 09/21] meson: Build gallium auxiliary

v2: - guard gallivm files with "with_llvm" instead of "dep_llvm.found()" Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v1) --- meson.build | 36 ++- meson_options.txt | 4 +- src/gallium/auxiliary/meson.build | 528

[Mesa-dev] [PATCH v2 18/21] meson: build softpipe

This doesn't include llvmpipe. v2: - Fix inconsistent use of with_gallium_swrast and with_gallium_softpipe. Signed-off-by: Dylan Baker --- meson.build | 5 ++ meson_options.txt| 4 +- src/gallium/drivers/softpipe/meson.build | 85

[Mesa-dev] [PATCH v2 19/21] meson: build llvmpipe

Signed-off-by: Dylan Baker --- meson.build | 4 +- src/gallium/drivers/llvmpipe/meson.build | 116 +++ src/gallium/meson.build | 2 +- src/gallium/targets/dri/meson.build | 4 ++ 4 files changed, 124 insertions(+

[Mesa-dev] [PATCH v2 04/21] meson: Set _GNU_SOURCE

When we start adding non-free software platforms support we'll need to guard this, but for now it should be fine as is. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 8d890e53e12..b6f6c32d92

[Mesa-dev] [PATCH v2 21/21] .travis: Add meson configuration for gallium drivers

--- This fails to build on ubuntu 14.04 because it fails to link with libgalpi to get glx_tls symbols. On 16.04 it works, on arch it works, on debian testing it works. So I don't know. .travis.yml | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.tr

[Mesa-dev] [PATCH v2 14/21] meson: build radeonsi

This builds the radeonsi (and radeon) window system bits and gallium driver bits. Signed-off-by: Dylan Baker --- meson.build | 18 -- src/gallium/{ => drivers/radeon}/meson.build| 43 +++--- src/gallium/drivers/radeonsi/meson.build| 78

[Mesa-dev] [PATCH v2 08/21] meson: build libmesa_gallium

Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 19 --- meson_options.txt| 2 + src/mesa/meson.build | 143 ++- 3 files changed, 155 insertions(+), 9 deletions(-) diff --git a/meson.build b/meson.build ind

[Mesa-dev] [PATCH v2 07/21] meson: Add option to toggle LLVM

Signed-off-by: Dylan Baker --- meson.build | 35 --- meson_options.txt | 1 + 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index 70199a57a25..a96f2a1aa65 100644 --- a/meson.build +++ b/meson.build @@ -38,6 +38,7

[Mesa-dev] [PATCH v2 05/21] meson: Don't try to install dri drivers unless one is built

This confused the with_dri flag which is meant to control Direct Rendering Infrastructure, not classic drivers Signed-off-by: Dylan Baker --- src/mesa/drivers/dri/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/meson.build b/src/mesa/drivers/d

[Mesa-dev] [PATCH v2 06/21] meson: always set GLX_USE_TLS

This can be applied to all GLX implementations, and in autotools this is guarded only by the --enable-glx-tls flag. Since this is on by default in autotools, and is strictly better than being off, the meson build doesn't even have a toggle for it. Signed-off-by: Dylan Baker --- meson.build | 2 +

[Mesa-dev] [PATCH v2 20/21] meson: refactor meson_options

To put one argument on each line. This results in the file being much longer, but I think much more readable. Suggested-by: Eero Tamminen Signed-off-by: Dylan Baker --- meson_options.txt | 170 +- 1 file changed, 129 insertions(+), 41 deletion

[Mesa-dev] [PATCH v2 13/21] meson: Build gallium dri state tracker

Signed-off-by: Dylan Baker --- meson.build | 1 + src/gallium/meson.build | 1 + src/gallium/{ => state_trackers/dri}/meson.build | 46 +++- 3 files changed, 39 insertions(+), 9 deletions(-) copy src/gallium/{ =>

[Mesa-dev] [PATCH v2 15/21] meson: build gallium winsys for dri, null, and wrapper

Signed-off-by: Dylan Baker --- meson.build | 4 ++ src/gallium/auxiliary/pipe-loader/meson.build | 12 -- src/gallium/meson.build | 8 ++-- src/gallium/{ => winsys/sw/dri}/meson.build | 55 +++- src/galliu

[Mesa-dev] [PATCH v2 17/21] meson: build nouveau (gallium) driver

Tested with a GK107. v2: - Add target for nouveau standalone compiler. This target is not built by default. Signed-off-by: Dylan Baker --- meson.build | 6 + src/gallium/drivers/nouveau/meson.build | 224 +++ src/gallium/

[Mesa-dev] [PATCH v2 16/21] meson: build radeonsi gallium driver

This hooks up the bits necessary to build gallium dri drivers, with radeonSI as the first example driver. This isn't tested yet. --- meson.build | 4 +- src/gallium/drivers/radeonsi/meson.build | 2 +- src/gallium/meson.build | 3 +- src/gallium/tar

Re: [Mesa-dev] [PATCH 1/2] mapi: Update extension number of MESA_tile_raster_order.

On Wednesday, October 11, 2017 10:04:22 AM PDT Eric Anholt wrote: > --- > src/mapi/glapi/gen/MESA_tile_raster_order.xml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mapi/glapi/gen/MESA_tile_raster_order.xml > b/src/mapi/glapi/gen/MESA_tile_raster_order.xml > ind

Re: [Mesa-dev] [PATCH v2 4/6] glsl: mark xfb inputs as always_active_io

Timothy Arceri writes: > We won't split varyings marked as always active because there > is no point in doing so. This means we need to mark both > sides of the interface as always active otherwise we will have > a mismatch and start removing things we shouldn't. > --- > src/compiler/glsl/link_v

Re: [Mesa-dev] [PATCH v2 3/6] nir: add variant of lower_io_to_scalar to be called earlier

Timothy Arceri writes: > This is intended to be called before nir_lower_io() so that we > can do some linking optimisations with the results. It can also > be used with drivers that don't use nir_lower_io() at all such > as RADV. > > v2: pass mode mask rather than first and last stage integer. R

Re: [Mesa-dev] [Mesa-stable] [PATCH] amd/common/gfx9: workaround DCC corruption more conservatively

Reviewed-by: Marek Olšák Marek On Thu, Oct 12, 2017 at 11:24 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes KHR-GL45.texture_swizzle.smoke and others on Vega. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102809 > Cc: mesa-sta...@lists.freedesktop.org > --- > src/amd/

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] radeonsi: hard-code pixel center for interpolateAtSample without multisample buffers

On 12.10.2017 18:55, Emil Velikov wrote: Hi Nicolai, On 11 September 2017 at 16:11, Nicolai Hähnle wrote: From: Nicolai Hähnle The GLSL rules for interpolateAtSample are unfortunate: "Returns the value of the input interpolant variable at the location of sample number sample. If

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] st/glsl_to_tgsi: fix DFRACEXP with only one destination

On 12.10.2017 19:05, Emil Velikov wrote: On 10 October 2017 at 13:11, Nicolai Hähnle wrote: From: Nicolai Hähnle Replace the undefined destination by a new temporary register. Cleanup merge_two_dsts while we're at it. --- Small reminder - this and 3/3 have landed without the tag. Please let

[Mesa-dev] [PATCH v3 00/43] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

Hello, this is the V3 series for the implementation of the SPV_KHR_16bit_storage and VK_KHR_16bit_storage extensions on the anv vulkan driver, in addition to the GLSL and NIR support needed. The original series can be found here [1], and the V2 is available here [2]. In short V3 includes the fol

[Mesa-dev] [PATCH v3 01/43] glsl: Add 16-bit types

From: Eduardo Lima Mitev Adds new INT16, UINT16 and FLOAT16 base types. The corresponding GL types for half floats were reused from the AMD_gpu_shader_half_float extension. The int16 and uint16 types come from NV_gpu_shader_5 extension. This adds the builtins and the lexer support. To avoid a

[Mesa-dev] [PATCH v3 03/43] nir: Add support for 16-bit types (half float, int16 and uint16)

From: Eduardo Lima Mitev v2: Renamed glsl_half_float_type() to glsl_float16_t_type(). (Jason Ekstrand) Signed-off-by: Jose Maria Casanova Crespo Signed-off-by: Eduardo Lima --- src/compiler/nir/nir.c | 6 ++ src/compiler/nir/nir.h | 9 + src

[Mesa-dev] [PATCH v3 06/43] nir: Handle fp16 rounding modes at nir_type_conversion_op

nir_type_conversion enables new operations to handle rounding modes to convert to fp16 values. Two new opcodes are enabled nir_op_f2f16_rtne and nir_op_f2f16_rtz. The undefined behaviour doesn't has any effect and uses the original nir_op_f2f16 operation. v2: Indentation fixed (Jason Ekstrand) --

[Mesa-dev] [PATCH v3 09/43] spirv/nir: Add support for SPV_KHR_16bit_storage

From: Eduardo Lima Mitev v2: Minor changes after rebase against recent master (Alejandro Pinheiro) --- src/compiler/spirv/nir_spirv.h| 1 + src/compiler/spirv/spirv_to_nir.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/spirv/nir_spirv.h b/src/compiler/spirv/ni

[Mesa-dev] [PATCH v3 02/43] mesa/st: Handle 16-bit types at st_glsl_storage_type_size()

From: Eduardo Lima Mitev This is basically to avoid "not handle in switch" warnings. v2: Let the new types hit the assertion instead. (Marek Olšák and Jason Ekstrand) Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_types.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH v3 10/43] i965/vec4: Handle 16-bit types at type_size_xvec4

From: Alejandro Piñeiro These types have similar vec4 sizes as their 32-bit counterparts. The vec4 backend doesn't support 16-bit types and probably never will, but this method is called by the scalar backend at fs_visitor::nir_setup_outputs(), so we still need to provide valid vec4 sizes for 16

[Mesa-dev] [PATCH v3 04/43] nir: Add rounding modes enum

v2: Added comments describing each of the rounding modes. (Jason Ekstrand) --- src/compiler/nir/nir.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 3ab2f7dff1..fb269fcb28 100644 --- a/src/compiler/nir/nir.h +++ b/src/compi

[Mesa-dev] [PATCH v3 08/43] spirv: Enable FPRoundingMode decorator to nir operations

SpvOpFConvert now manages the FPRoundingMode decorator for the returning values enabling the nir_rounding_mode in the conversion operation to fp16 values. v2: Fixed breaking of specialization constants. (Jason Ekstrand) --- src/compiler/spirv/vtn_alu.c | 32 1 fil

[Mesa-dev] [PATCH v3 05/43] nir: Populate conversion opcodes to/from 16-bit types

From: Eduardo Lima Mitev This will include the following NIR ALU opcodes: * nir_op_i2i16 * nir_op_i2f16 * nir_op_u2u16 * nir_op_u2f16 * nir_op_f2i16 * nir_op_f2u16 * nir_op_f2f16 Reviewed-by: Jason Ekstrand --- src/compiler/nir/nir_opcodes_c.py | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH v3 07/43] spirv/nir: Handle 16-bit types

From: Eduardo Lima Mitev v2: Added more missing implementations of 16-bit types. (Jason Ekstrand) Signed-off-by: Jose Maria Casanova Crespo Signed-off-by: Eduardo Lima --- src/compiler/spirv/spirv_to_nir.c | 46 -- src/compiler/spirv/vtn_variables.c | 21 +

[Mesa-dev] [PATCH v3 12/43] i965/fs: Add brw_reg_type_from_bit_size utility method

From: Alejandro Piñeiro Returns the brw_type for a given ssa.bit_size, and a reference type. So if bit_size is 64, and the reference type is BRW_REGISTER_TYPE_F, it returns BRW_REGISTER_TYPE_DF. The same applies if bit_size is 32 and reference type is BRW_REGISTER_TYPE_HF it returns BRW_REGISTER_

[Mesa-dev] [PATCH v3 13/43] i965/fs: Remove BRW_REGISTER_TYPE_HF assert at get_exec_type

From: Alejandro Piñeiro Note that we don't remove the assert at i965/vec4. At this point half float support is only for the scalar backend. --- src/intel/compiler/brw_ir_fs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/compiler/brw_ir_fs.h b/src/intel/compiler/brw_ir_fs.h ind

[Mesa-dev] [PATCH v3 17/43] i965/fs: Enable rounding mode on f2f16 ops

From: Alejandro Piñeiro By default we don't set the rounding mode. We only set round-to-near-even or round-to-zero mode if explicitly set from nir. v2: Use a single SHADER_OPCODE_RND_MODE opcode taking an immediate with the rounding mode (Curro) Signed-off-by: Jose Maria Casanova Crespo Si

[Mesa-dev] [PATCH v3 15/43] i965: Add support for control register

Control register cr0 in i965 can be used to change the rounding modes in 32-bit to 16-bit floating-point conversions. From intel Skylake PRM, vol 07, section "Register and Tegister Regions", subsection "Control Register" (page 754): "Subregister cr0.0:ud contains normal operation control fields

[Mesa-dev] [PATCH v3 14/43] i965/fs: Handle 32-bit to 16-bit conversions

From: Alejandro Piñeiro Conversions to 16-bit need having aligment between the 16-bit and 32-bit types. So the conversion operations unpack 16-bit types to with an stride=2 and then applies a MOV with the conversion. v2 (Jason Ekstrand): - Avoid the general use of stride=2 for 16-bit register

[Mesa-dev] [PATCH v3 11/43] i965: Support for 16-bit base types in helper functions

v2: Fixed calculation of scalar size for 16-bit types. (Jason Ekstrand) Signed-off-by: Jose Maria Casanova Crespo Signed-off-by: Eduardo Lima --- src/intel/compiler/brw_fs.cpp | 4 src/intel/compiler/brw_nir.c | 16 src/intel/compiler/brw_shader.cpp | 6 ++

[Mesa-dev] [PATCH v3 18/43] i965/fs: Add remove_extra_rounding_modes optimization

From: Alejandro Piñeiro Although from SPIR-V point of view, rounding modes are attached to the operation/destination, on i965 it is a status, so we don't need to explicitly set the rounding mode if the one we want is already set. Taking into account that the default mode is RTE, one possible opt

[Mesa-dev] [PATCH v3 22/43] i965/fs: Use byte_scattered_write on 16-bit store_ssbo

From: Alejandro Piñeiro We need to rely on byte scattered writes as untyped writes are 32-bit size. We could try to keep using 32-bit messages when we have two or four 16-bit elements, but for simplicity sake, we use the same message for any component number. We revisit this in this serie. v2: R

  1   2   3   >