Re: [Mesa-dev] [PATCH] glsl: Disallow unsized array of atomic_uint

2017-09-12 Thread Kenneth Graunke
On Monday, September 11, 2017 11:15:05 PM PDT Iago Toral Quiroga wrote: > This was a bugfix to the spec addressed in OpenGL 4.5 and there is > a CTS test to check this. > > Fixes: > KHR-GL45.shader_atomic_counters.negative-unsized-array > --- > src/compiler/glsl/ast_to_hir.cpp | 11 +++ >

Re: [Mesa-dev] [PATCH] glsl: Disallow unsized array of atomic_uint

2017-09-12 Thread Iago Toral
On Tue, 2017-09-12 at 00:03 -0700, Kenneth Graunke wrote: > On Monday, September 11, 2017 11:15:05 PM PDT Iago Toral Quiroga > wrote: > > This was a bugfix to the spec addressed in OpenGL 4.5 and there is > > a CTS test to check this. > > > > Fixes: > > KHR-GL45.shader_atomic_counters.negative-uns

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Jordan Justen
On 2017-09-10 17:15:48, Timothy Arceri wrote: > Ccing list. > > On 11/09/17 09:50, Timothy Arceri wrote: > > Hi Daniel, > > > > Here is the code that does the caching of tgsi in Gallium. > > > > https://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/state_tracker/st_shader_cache.c > > > > > >

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Timothy Arceri
On 12/09/17 16:55, Jordan Justen wrote: On 2017-09-11 21:44:32, Timothy Arceri wrote: On 12/09/17 14:23, Ian Romanick wrote: On 09/08/2017 01:59 AM, Kenneth Graunke wrote: We shouldn't use SPIR-V for the shader cache. The compilation process for GLSL is: GLSL -> GLSL IR -> NIR -> i965 IRs. S

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102564 --- Comment #4 from Alex Granni --- Sorry, I didn't mention that GPU Caps Viewer is 32-bit even if running on 64-bit Windows so it goes in \windows\syswow64 on a 64-bit Windows. The way I get it to use Mesa is by copying or rather create symlink

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-12 Thread Marathe, Yogesh
Hi Jason, On the asserts you’ve mentioned below, I assume we need to add them after ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 initially. Another clarification on ~1%, we meant approx. 1% there, that’s an improvement we saw in 3Dmark total not a degradation, we’ll correct

Re: [Mesa-dev] [PATCH] r600/sb: remove superfluos assert

2017-09-12 Thread Gert Wollny
Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin: > On 09/11/2017 07:09 PM, Emil Velikov wrote: > Anyway, if num_arrays is 0 there, I suspect it can be a result of > some other issue. At the very least it looks like a potential > performance problem, because in that case we assume all

[Mesa-dev] [PATCH] anv: fix build issues on release build

2017-09-12 Thread Tapani Pälli
Fixes: d083bc1c4b ("anv: wire up vk_errorf macro to do debug reporting") Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index b42c76d8fe..df8de8d940

[Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

2017-09-12 Thread Gert Wollny
> > This doesn't seem right. GALLIUM_COMMON_LIB_DEPS already has > > $(LIBUNWIND_LIBS) so this change should not be needed. > > I already started looking at this, but haven't been able to figure > out why in this specific configuration GALLIUM_COMMON_LIB_DEPS seems > to be empty, or at least it d

Re: [Mesa-dev] [PATCH] anv: fix build issues on release build

2017-09-12 Thread Daniel Stone
On 12 September 2017 at 11:11, Tapani Pälli wrote: > Fixes: d083bc1c4b ("anv: wire up vk_errorf macro to do debug reporting") > Signed-off-by: Tapani Pälli Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://list

[Mesa-dev] [PATCH 00/15] radv: GPU hangs should now be easier to detect

2017-09-12 Thread Samuel Pitoiset
Hi, Currently, it's not easy to debug a GPU hang with radv because only a trace file is generated (cf. RADV_TRACE_FILE). That file contains all packets and commands emitted into the IB, that's useful but definitely not enough. For example, the active shaders at the moment of the hang are not dumpe

[Mesa-dev] [PATCH 04/15] radv: add debug flags for syncing shaders after every draw call

2017-09-12 Thread Samuel Pitoiset
To improve GPU hangs detection when shaders are stucked. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 15 +++ src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 1 + 3 files changed, 17 insertions(+) diff --git a/src/amd/vulkan/radv

[Mesa-dev] [PATCH 01/15] radv: add a comment that describes the trace BO layout

2017-09-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index d52ba5d86d..052daaef2f 100644 --- a/src/amd/vulkan/radv_debug.c +++ b/src/amd/vulkan/radv_debug.c @@ -32,6 +32,1

[Mesa-dev] [PATCH 06/15] radv: add radv_shader_dump_stats() helper

2017-09-12 Thread Samuel Pitoiset
To dump the shader stats when a hang is detected. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 64 +- src/amd/vulkan/radv_shader.c | 70 ++ src/amd/vulkan/radv_shader.h | 6 3 files chang

[Mesa-dev] [PATCH 03/15] radv: add radv_cmd_buffer_after_draw() helper function

2017-09-12 Thread Samuel Pitoiset
To share common code after every draw/compute calls. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 9b6c8c6106..2

[Mesa-dev] [PATCH 10/15] radeonsi: move si_get_wave_info() to AMD common code

2017-09-12 Thread Samuel Pitoiset
This will allow us to use it from radv. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_debug.c | 76 ++ src/amd/common/ac_debug.h | 18 +++ src/gallium/drivers/radeonsi/si_debug.c | 96 ++--- 3 files change

[Mesa-dev] [PATCH 02/15] radv: save the bound pipeline pointers into the trace BO

2017-09-12 Thread Samuel Pitoiset
When a GPU hang is detected in radv_gpu_hang_occured() we know which command buffer is faulty but the bound pipelines might have been updated during the execution. The pointers to the radv_pipeline objects are emitted just after the second trace ID, that way it would be easy to dump the active sha

[Mesa-dev] [PATCH 07/15] radv: dump shader stats when a hang occured

2017-09-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index fe9d9cfdba..4abdb6489e 100644 --- a/src/amd/vulkan/radv_debug.c +++ b/src/amd/vulkan/radv_debug.c @@ -86,6 +86,8 @@

[Mesa-dev] [PATCH 12/15] radv: save all descriptor pointers into the trace BO

2017-09-12 Thread Samuel Pitoiset
To dump them when a hang is detected. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 32 src/amd/vulkan/radv_debug.c | 3 +++ 2 files changed, 35 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_b

[Mesa-dev] [PATCH 08/15] radv/winsys: add a read_registers() callback

2017-09-12 Thread Samuel Pitoiset
To dump some status MMIO registers when a hang is detected. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_radeon_winsys.h | 3 +++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 11 +++ 2 files changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_radeo

[Mesa-dev] [PATCH 09/15] radv: dump some status MMIO registers when a hang occured

2017-09-12 Thread Samuel Pitoiset
Might report some useful information to help figuring out where does the hang happened. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 57 + 1 file changed, 57 insertions(+) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/r

[Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Samuel Pitoiset
Only the disassembly is currently dumped. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 78 ++--- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index 0dc2d3a22b..

[Mesa-dev] [PATCH 11/15] radv: dump annotated shaders using UMR

2017-09-12 Thread Samuel Pitoiset
This might be very useful in order to figure out where a shader is stucked. This uses UMR to detect which instruction is executing bad things. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 166 1 file changed, 166 insertions(+) dif

[Mesa-dev] [PATCH 13/15] radv: dump descriptors when a hang occured

2017-09-12 Thread Samuel Pitoiset
Might be useful for checking if all descriptors are sets by the application. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 181 1 file changed, 181 insertions(+) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.

[Mesa-dev] [PATCH 15/15] radv: dump the list of enabled options when a hang occured

2017-09-12 Thread Samuel Pitoiset
Useful to know which debug/perftest options were enabled when a hang report is generated. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 25 + src/amd/vulkan/radv_device.c | 14 ++ src/amd/vulkan/radv_private.h | 7 +++ 3 files change

[Mesa-dev] [PATCH 14/15] radv: dump last 60 lines of dmesg when a hang occured

2017-09-12 Thread Samuel Pitoiset
Copied from dd_dump_dmesg(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 20 1 file changed, 20 insertions(+) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index 741bf76f15..106c6e4f64 100644 --- a/src/amd/vulkan/radv_debug.c ++

Re: [Mesa-dev] [PATCH] anv: fix build issues on release build

2017-09-12 Thread Emil Velikov
On 12 September 2017 at 11:11, Tapani Pälli wrote: > Fixes: d083bc1c4b ("anv: wire up vk_errorf macro to do debug reporting") > Signed-off-by: Tapani Pälli FWIW Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

[Mesa-dev] [Bug 102665] test_glsl_to_tgsi_lifetime.cpp:53:67: error: ‘?=>>=?UTF-8?Q?’ should be ‘?=> >=?UTF-8?Q?’ within a nested template argument list

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102665 --- Comment #2 from Emil Velikov --- One option is to add space between the two >> - it's compatible with older C++ standards and part of Mesa already uses it. Alternatively, move '&' one character to the right (again we have some instances in

[Mesa-dev] [PATCH mesa] r600: extend use of HAS_SIZE() macro

2017-09-12 Thread Eric Engestrom
The macro was only used a few times; let's use it everywhere, simplifying the code. I also uniformised the use of curly brackets by adding them around all uses of the macro, removed a few unnecessary `else` after `return`, and turned a ternary op into an `if`. Signed-off-by: Eric Engestrom --- s

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

2017-09-12 Thread Emil Velikov
On 12 September 2017 at 11:17, Gert Wollny wrote: > >> > This doesn't seem right. GALLIUM_COMMON_LIB_DEPS already has >> > $(LIBUNWIND_LIBS) so this change should not be needed. >> >> I already started looking at this, but haven't been able to figure >> out why in this specific configuration GALLI

Re: [Mesa-dev] [PATCH 10/15] radeonsi: move si_get_wave_info() to AMD common code

2017-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > This will allow us to use it from radv. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_debug.c | 76 ++ > src/amd/common/ac_debug.h | 18

Re: [Mesa-dev] [PATCH] glsl: remove assert in lower_packed_varyings

2017-09-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 11, 2017 at 3:37 PM, Ilia Mirkin wrote: > It's obviously misformed, and it's triggering on > > dEQP-GLES31.functional.program_interface_query.program_input.type.separable_geometry.int > > and a few related tests, which have a geometry shader with > > "

[Mesa-dev] [PATCH] i965: add BRW_NEW_BLORP to the list of dirty state for render targets

2017-09-12 Thread Iago Toral Quiroga
Commit b96313c0e1289b removed BRW_NEW_BLORP for a bunch of SURFACE_STATE setup code, including render targets, on the basis that blorp invalidates binding tables but not surface states, however, at least on Broadwell, this seems to be causing a regression in a CTS test that seems related to render

[Mesa-dev] [PATCH mesa] swr: use ARRAY_SIZE macro

2017-09-12 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/swr/rasterizer/memory/StoreTile.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/StoreTile.h b/src/gallium/drivers/swr/rasterizer/memory/StoreTile.h index c3d14e9509..6

[Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Leo Liu
In code: template.height = align(tmpl->height / array_size, VL_MACROBLOCK_HEIGHT); ... template.height *= array_size; It turns out the height will be aligned with 2*VL_MACROBLOCK_HEIGHT. The problematic case for example is when VA-API postproc scaling with blit between int

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Emil Velikov
Hi Leo, On 12 September 2017 at 14:56, Leo Liu wrote: > In code: > template.height = align(tmpl->height / array_size, > VL_MACROBLOCK_HEIGHT); > ... > template.height *= array_size; > > It turns out the height will be aligned with 2*VL_MACROBLOCK_HEIGHT. > The problematic

[Mesa-dev] [Bug 102665] test_glsl_to_tgsi_lifetime.cpp:53:67: error: ‘?=>>=?UTF-8?Q?’ should be ‘?=> >=?UTF-8?Q?’ within a nested template argument list

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102665 --- Comment #3 from Gert Wollny --- @Vinson: on Travis with the exact same version of g++ you reported (gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 [1] the build runs through without modifying the source (I had to enable "make check" for this), so

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Leo Liu
On 09/12/2017 10:24 AM, Emil Velikov wrote: Hi Leo, On 12 September 2017 at 14:56, Leo Liu wrote: In code: template.height = align(tmpl->height / array_size, VL_MACROBLOCK_HEIGHT); ... template.height *= array_size; It turns out the height will be aligned with 2*

[Mesa-dev] [PATCH mesa] docs/egl: remove reference to EGL_DRIVERS_PATH

2017-09-12 Thread Eric Engestrom
Support for external egl drivers was dropped a few years ago. Fixes: 209360bbb91bb10346eb "egl/main: drop support for external egl drivers" Signed-off-by: Eric Engestrom --- docs/egl.html | 21 - 1 file changed, 21 deletions(-) diff --git a/docs/egl.html b/docs/egl.html inde

[Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-12 Thread Eric Engestrom
The function is only called from one place, which is hidden behind the same `#ifdef DEBUG`. Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_validate.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/glsl/ir_val

Re: [Mesa-dev] [PATCH mesa] docs/egl: remove reference to EGL_DRIVERS_PATH

2017-09-12 Thread Emil Velikov
On 12 September 2017 at 15:38, Eric Engestrom wrote: > Support for external egl drivers was dropped a few years ago. > > Fixes: 209360bbb91bb10346eb "egl/main: drop support for external egl drivers" > Signed-off-by: Eric Engestrom Thanks! Reviewed-by: Emil Velikov -Emil ___

Re: [Mesa-dev] [PATCH mesa] glx: remove dead code

2017-09-12 Thread Eric Engestrom
On Wednesday, 2017-09-06 17:25:29 +0100, Emil Velikov wrote: > On 6 September 2017 at 17:17, Adam Jackson wrote: > > On Fri, 2017-09-01 at 15:04 +0100, Eric Engestrom wrote: > >> These fields were added in 2d94601582 but never used; hasPresent was > >> never set, while the other ones were set but

[Mesa-dev] [PATCH mesa] radv: compile out unused code

2017-09-12 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index aa44b7d78a..8a551c48bb 100644 --- a/src/amd/vulkan/radv_wsi.c +++ b/src/amd/vulkan/radv_wsi.c @@ -28,9 +28,11 @@ #include

Re: [Mesa-dev] [PATCH mesa] glx: remove dead code

2017-09-12 Thread Adam Jackson
On Tue, 2017-09-12 at 16:08 +0100, Eric Engestrom wrote: > On Wednesday, 2017-09-06 17:25:29 +0100, Emil Velikov wrote: > > I'm not that much of an expert on things XCB, so perhaps a silly question. > > Isn't the presence checked with the code just above the removed hunk? > > Namely: > > > > exte

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Christian König
I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Instead we should rather fix the scaler to use the original width/height of the video buffer and not the adjusted width/height of the resources. Regards, Chris

Re: [Mesa-dev] [PATCH mesa] radv: compile out unused code

2017-09-12 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

2017-09-12 Thread Gert Wollny
Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: > On 12 September 2017 at 11:17, Gert Wollny > wrote: > > > > > > Is there a docker image available that resembles the travis-ci > > build environment as it is set up in mesa/.travis.yml (i.e. > > Ubuntu/Trusty with all the manually

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-12 Thread Jason Ekstrand
On Tue, Sep 12, 2017 at 2:40 AM, Marathe, Yogesh wrote: > Hi Jason, > > > > On the asserts you’ve mentioned below, I assume we need to add them after > ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 initially. > Yes, because otherwise bucket_for_size will return NULL all the t

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Leo Liu
On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only affects 720p video, so I did quite a bit tests on 720p video dec/enc, and haven't see any

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Christian König
Am 12.09.2017 um 17:32 schrieb Leo Liu: On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only affects 720p video, so I did quite a bit tests on

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Leo Liu
On 09/12/2017 11:37 AM, Christian König wrote: Am 12.09.2017 um 17:32 schrieb Leo Liu: On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only

[Mesa-dev] [Bug 102677] [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102677 Bug ID: 102677 Summary: [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails Product: Mesa Version: unspecified Hardware: Other

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

2017-09-12 Thread Eric Engestrom
On Tuesday, 2017-09-12 17:26:43 +0200, Gert Wollny wrote: > Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: > > On 12 September 2017 at 11:17, Gert Wollny > > wrote: > > > > > > > > > Is there a docker image available that resembles the travis-ci > > > build environment as it is s

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102682 Bug ID: 102682 Summary: vblank_mode ignored from ~/.drirc Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal Prio

[Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-12 Thread Ian Romanick
From: Ian Romanick glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, _mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’: glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter] merge_bindless_qualifier(YYLTYPE *loc,

[Mesa-dev] [PATCH 3/3] glsl: Unify ir_constant::const_elements and ::components

2017-09-12 Thread Ian Romanick
From: Ian Romanick There was no reason to treat array types and record types differently. Unifying them saves a bunch of code and saves a few bytes in every ir_constant. Signed-off-by: Ian Romanick --- src/compiler/glsl/glsl_to_nir.cpp | 11 --- src/compiler/glsl/ir.cpp

[Mesa-dev] [PATCH 2/3] glsl: Rename ir_constant::array_elements to ::const_elements

2017-09-12 Thread Ian Romanick
From: Ian Romanick The next patch will unify ::array_elements and ::components, so the name ::array_elements wouldn't be appropriate. A lot of things use the names array_elements and components, so grepping for either is pretty useless. Signed-off-by: Ian Romanick --- src/compiler/glsl/glsl_t

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Ian Romanick
On 09/11/2017 09:44 PM, Timothy Arceri wrote: > On 12/09/17 14:23, Ian Romanick wrote: >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >>> On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: > Hello together! > Recently,

[Mesa-dev] [PATCH 1/3] radv: remove useless 'cmd_buffer' param from radv_buffer_view_init()

2017-09-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 ++--- src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufimage.c | 2 +- src/amd/vulkan/radv_private.h | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv

[Mesa-dev] [PATCH 3/3] radv: clear push_constant_stages when resetting a command buffer

2017-09-12 Thread Samuel Pitoiset
Per the spec: "Resetting a command buffer is an operation that discards any previously recorded commands and puts a command buffer in the initial state." As far I'm concerned, that flag can be changed by calling VkCmdPushConstants() (or any other functions which update it), so it should

[Mesa-dev] [PATCH 2/3] radv: add more radv_emit_XXX() helpers for the dynamic state

2017-09-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 117 ++- 1 file changed, 77 insertions(+), 40 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 4d33c2f1d2..6a82867c82 100644 --- a/src/amd/

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Ian Romanick
On 09/11/2017 11:17 PM, Kenneth Graunke wrote: > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >>> On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: > Hello

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-12 Thread Ian Romanick
On 09/08/2017 08:38 AM, Jason Ekstrand wrote: > In general, I'm very concerned about how this handles rounding > behavior. Almost everywhere, you round down when what you want to do is > round up. Also, as I said on IRC, I'd like to see some asserts in > add_bucket so that we are sure this calcul

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-12 Thread Ian Romanick
On 09/12/2017 02:40 AM, Marathe, Yogesh wrote: > Hi Jason, > > > > On the asserts you’ve mentioned below, I assume we need to add them > after ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 > initially. Another clarification on ~1%, we meant approx. 1% there, > that’s an impr

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

2017-09-12 Thread Anuj Phogat
On Mon, Sep 11, 2017 at 10:10 AM, Rodrigo Vivi wrote: > On Mon, Sep 11, 2017 at 04:11:33PM +, Anuj Phogat wrote: >> See Mesa commits: ebc5ccf and b2dae9f > > I believe we need to be in sync between multiple gfx stack components, > but I don't believe we should remove ids. > > In the past we h

Re: [Mesa-dev] [PATCH mesa] radv: compile out unused code

2017-09-12 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On 12 Sep 2017 5:11 PM, "Eric Engestrom" wrote: Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index aa44b7d78a..8a551c48bb 100644 --- a/src/

Re: [Mesa-dev] [PATCH] r600/sb: remove superfluos assert

2017-09-12 Thread Vadim Girlin
On 09/12/2017 12:49 PM, Gert Wollny wrote: Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin: On 09/11/2017 07:09 PM, Emil Velikov wrote: Anyway, if num_arrays is 0 there, I suspect it can be a result of some other issue. At the very least it looks like a potential performance pro

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #1 from Gustaw Smolarczyk --- Hi, The problem seems to be with the `driver="radeonsi"' part (the screen attribute is not used when driver is present). It seems that there is a bug and an incorrect driver name "loader" is passed to t

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-12 Thread Matt Turner
On Tue, Sep 12, 2017 at 8:01 AM, Eric Engestrom wrote: > The function is only called from one place, which is hidden behind > the same `#ifdef DEBUG`. > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" > Signed-off-by: Eric Engestrom As long as make check continues passing (I broke th

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #2 from Niklas Haas --- Verifying that your work-around does, indeed, work around the issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #3 from Gustaw Smolarczyk --- Was too fast. The passed driver name is not "loader" but "dri2". And I think it's intentional, since vblank_mode is not an option of a device driver but of the dri infrastructure. I will let the more ex

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

2017-09-12 Thread Matt Turner
On Tue, Sep 12, 2017 at 10:19 AM, Ian Romanick wrote: > On 09/12/2017 02:40 AM, Marathe, Yogesh wrote: >> Hi Jason, >> >> >> >> On the asserts you’ve mentioned below, I assume we need to add them >> after ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 >> initially. Another clari

[Mesa-dev] [Bug 102665] test_glsl_to_tgsi_lifetime.cpp:53:67: error: ‘?=>>=?UTF-8?Q?’ should be ‘?=> >=?UTF-8?Q?’ within a nested template argument list

2017-09-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102665 --- Comment #4 from Vinson Lee --- In the travis build, the -std=c++11 option comes from LLVM_CXXFLAGS with llvm-3.9. Older llvm versions or builds without llvm will not have -std=c++11. -- You are receiving this mail because: You are the QA C

Re: [Mesa-dev] [PATCH 3/3] radv: clear push_constant_stages when resetting a command buffer

2017-09-12 Thread Bas Nieuwenhuizen
The series is Reviewed-by: Bas Nieuwenhuizen On Tue, Sep 12, 2017 at 7:08 PM, Samuel Pitoiset wrote: > Per the spec: > >"Resetting a command buffer is an operation that discards any >previously recorded commands and puts a command buffer in the >initial state." > > As far I'm concer

Re: [Mesa-dev] [PATCH 01/15] radv: add a comment that describes the trace BO layout

2017-09-12 Thread Bas Nieuwenhuizen
add something that the offsets are in multiple of 4 bytes? On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_debug.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/ra

Re: [Mesa-dev] [PATCH 02/15] radv: save the bound pipeline pointers into the trace BO

2017-09-12 Thread Bas Nieuwenhuizen
On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > When a GPU hang is detected in radv_gpu_hang_occured() we know > which command buffer is faulty but the bound pipelines might > have been updated during the execution. > > The pointers to the radv_pipeline objects are emitted just > after

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Jason Ekstrand
On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick wrote: > On 09/11/2017 11:17 PM, Kenneth Graunke wrote: > > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: > >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: > >>> On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote:

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Bas Nieuwenhuizen
On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > Only the disassembly is currently dumped. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_debug.c | 78 > ++--- > 1 file changed, 73 insertions(+), 5 deletions(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH 15/15] radv: dump the list of enabled options when a hang occured

2017-09-12 Thread Bas Nieuwenhuizen
Okay, if you fix the few comments I sent, this series is Reviewed-by: Bas Nieuwenhuizen On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > Useful to know which debug/perftest options were enabled when > a hang report is generated. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vul

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

2017-09-12 Thread Christian König
Am 12.09.2017 um 18:10 schrieb Leo Liu: On 09/12/2017 11:37 AM, Christian König wrote: Am 12.09.2017 um 17:32 schrieb Leo Liu: On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what yo

Re: [Mesa-dev] [PATCH 01/15] radv: add a comment that describes the trace BO layout

2017-09-12 Thread Samuel Pitoiset
On 09/12/2017 08:05 PM, Bas Nieuwenhuizen wrote: add something that the offsets are in multiple of 4 bytes? Okay. On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Samuel Pitoiset
On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: Only the disassembly is currently dumped. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 78 ++--- 1 file changed, 73 insert

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Bas Nieuwenhuizen
On Tue, Sep 12, 2017 at 8:57 PM, Samuel Pitoiset wrote: > > > On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset >> wrote: >>> >>> Only the disassembly is currently dumped. >>> >>> Signed-off-by: Samuel Pitoiset >>> --- >>> src/amd/vulkan/r

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Nicolai Hähnle
On 12.09.2017 06:25, Ian Romanick wrote: On 09/07/2017 04:26 PM, Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: Hello together! Recently, we had a small discussion (off the list) about the NIR serialization, which was previously discussed in [RFC] ARB_gl_spirv and NIR back

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Samuel Pitoiset
On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 8:57 PM, Samuel Pitoiset wrote: On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: Only the disassembly is currently dumped. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Bas Nieuwenhuizen
On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset wrote: > > > On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Sep 12, 2017 at 8:57 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 12:35 PM, Samuel

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Samuel Pitoiset
On 09/12/2017 09:16 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset wrote: On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 8:57 PM, Samuel Pitoiset wrote: On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 a

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Bas Nieuwenhuizen
On Tue, Sep 12, 2017 at 9:30 PM, Samuel Pitoiset wrote: > > > On 09/12/2017 09:16 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 8:57 PM, Samuel P

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

2017-09-12 Thread Samuel Pitoiset
On 09/12/2017 09:36 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 9:30 PM, Samuel Pitoiset wrote: On 09/12/2017 09:16 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset wrote: On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 a

Re: [Mesa-dev] [PATCH v2 02/12] tgsi/ureg: always emit constants (and their decls) as 2D

2017-09-12 Thread Rob Herring
On Mon, Aug 28, 2017 at 3:58 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Acked-by: Roland Scheidegger > Tested-by: Dieter Nützel > --- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 22 +++--- > 1 file changed, 7 insertions(+), 15 deletions(-) I bisected to this commit b

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

2017-09-12 Thread Paulo Zanoni
Em Seg, 2017-09-11 às 10:10 -0700, Rodrigo Vivi escreveu: > On Mon, Sep 11, 2017 at 04:11:33PM +, Anuj Phogat wrote: > > See Mesa commits: ebc5ccf and b2dae9f > > I believe we need to be in sync between multiple gfx stack > components, > but I  don't believe we should remove ids. > > In the p

[Mesa-dev] [PATCH] (UNTESTED) virgl: filter out 2D constant file accesses and declarations

2017-09-12 Thread Nicolai Hähnle
From: Nicolai Hähnle Sorry for the mess. I suspect something like this patch is needed. Is this sufficient to fix the problem? Cheers, Nicolai --- src/gallium/drivers/virgl/virgl_tgsi.c | 24 1 file changed, 24 insertions(+) diff --git a/src/gallium/drivers/virgl/virg

Re: [Mesa-dev] [PATCH] (UNTESTED) virgl: filter out 2D constant file accesses and declarations

2017-09-12 Thread Nicolai Hähnle
FWIW, this patch should be a no-op without the offending "tgsi/ureg: always emit constants (and their decls) as 2D" commit. On 12.09.2017 22:34, Nicolai Hähnle wrote: From: Nicolai Hähnle Sorry for the mess. I suspect something like this patch is needed. Is this sufficient to fix the problem

[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-09-12 Thread Denis Pauk
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 v2: Patch cleanup proposed by Nicolai Hähnle. * deleted changes in si_translate_texformat. Cc: Nicolai Hähnle Cc: Ilia Mirkin --- src/gallium/auxiliary/util/u_format.c| 4 src/gallium/drivers/r600/r600_state_common

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-12 Thread Jason Ekstrand
On Tue, Sep 12, 2017 at 11:09 AM, Jason Ekstrand wrote: > On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick > wrote: > >> On 09/11/2017 11:17 PM, Kenneth Graunke wrote: >> > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: >> >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >> >>>

[Mesa-dev] [PATCH 1/3] ac: add radeon_info::has_sync_file

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index e5

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format

2017-09-12 Thread Денис Паук
Thank you, i have sent new patch version. Current call sequence in backward order: r600 => * r600_state_common.c::r600_translate_texformat and r600_state_common.c::r600_translate_colorformat is called from evergreen_state::r600_is_colorbuffer_format_supported and r600_state::r600_is_colorbuffer_f

[Mesa-dev] [PATCH 2/3] winsys/amdgpu: implement sync_file import/export

2017-09-12 Thread Marek Olšák
From: Marek Olšák syncobj is used internally for interactions with command submission. --- src/gallium/drivers/radeon/radeon_winsys.h | 12 +++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 115 +++-- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 18 - 3 files changed

[Mesa-dev] [PATCH 1/3] ac: add radeon_info::has_sync_file

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index e5

[Mesa-dev] [PATCH 0/3] RadeonSI sync_file fences

2017-09-12 Thread Marek Olšák
Hi, This series adds support for sync_file fences, enabling EGL_ANDROID_native_fence_sync. Dependencies: Kernel patches (based on drm-next): drm/syncobj: extract two helpers from drm_syncobj_create drm/syncobj: add a new helper drm_syncobj_get_fd drm/amdgpu: add FENCE_TO_HANDLE ioctl

  1   2   >