[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101709 Vinson Lee changed: What|Removed |Added Blocks||101911 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #31 from John --- Created attachment 133190 --> https://bugs.freedesktop.org/attachment.cgi?id=133190&action=edit radv trace Well I somewhat take it back. I restarted my computer (which I hadn't done in my previous reply) and rer

[Mesa-dev] [PATCH] radv: Add suballocation for shaders.

2017-08-02 Thread Bas Nieuwenhuizen
This reduces the number of BOs that we need for the BO lists during a submission. Currently uses a fairly simple linear search for finding free space, that could eventually be improved to a binary tree, which with some per-node info could make a check for space O(1) and finding it O(log n), in the

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-02 Thread Juan A. Suarez Romero
On Wed, 2017-08-02 at 10:47 +1000, Timothy Arceri wrote: > On 06/07/17 19:12, Juan A. Suarez Romero wrote: > > Check if shaders have transform feedback varyings also after the > > post-link step. > > > > This fixes: > > KHR-GL45.enhanced_layouts.xfb_vertex_streams > > piglit/spec/arb_enhanced_layo

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: implement basic parts of PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

2017-08-02 Thread Nicolai Hähnle
On 01.08.2017 22:23, Marek Olšák wrote: Hi Nicolai, Can you add R600_MAX_STREAM = 4 to make the code more readable? Sure. Thanks, Marek On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_query.c | 96 +++

Re: [Mesa-dev] [PATCH 11/13] radeonsi: fix streamout overflow predication on VI+

2017-08-02 Thread Nicolai Hähnle
On 01.08.2017 22:42, Marek Olšák wrote: On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle There is a firmware regression that causes failures. Work around it by using the compute shader for query_buffer_objects to summarize the query results. --- src/amd/common/r60

[Mesa-dev] [AppVeyor] mesa master #5107 failed

2017-08-02 Thread AppVeyor
Build mesa 5107 failed Commit 53485c2d0e by Nicolai Hähnle on 6/28/2017 3:37 PM: radeonsi: add enable_sisched driconf option\n\nReviewed-by: Marek Olšák Configure your notification preferences ___ mesa-dev

[Mesa-dev] [Bug 102012] build failure after git_sha1 changes

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102012 Bug ID: 102012 Summary: build failure after git_sha1 changes Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

2017-08-02 Thread Kenneth Graunke
On Tuesday, August 1, 2017 6:16:31 PM PDT Jason Ekstrand wrote: > Unreal Engine 4 seems to really like VK_FORMAT_R8_SRGB for some reason. > We don't technically have the hardware format but we do have L8_SRGB. > It's easy enough to fake with that and a swizzle. While we're at it, we > may as well

[Mesa-dev] [Bug 102012] build failure after git_sha1 changes

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102012 --- Comment #1 from Marko --- I'm using this patch as a workaround currently on Suse OBS: https://patchwork.freedesktop.org/patch/169894/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

2017-08-02 Thread Mun, Gwan-gyeong
Hi Jason, thanks for your kind explanation. I has totally understood your intention. ( I don't mean to bother you, at first I just wanted to silence of below coverity warning. ---

[Mesa-dev] [PATCH] egl: deduplicate allocations of local buffer over each platform backend.

2017-08-02 Thread Gwan-gyeong Mun
platform_drm, platform_wayland and platform_android have similiar local buffer allocation routines. For deduplicating, it unifies dri2_egl_surface's local buffer allocation routines. And it polishes inconsistent indentations. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

2017-08-02 Thread Lionel Landwerlin
Both are : Reviewed-by: Lionel Landwerlin On 02/08/17 02:16, Jason Ekstrand wrote: Unreal Engine 4 seems to really like VK_FORMAT_R8_SRGB for some reason. We don't technically have the hardware format but we do have L8_SRGB. It's easy enough to fake with that and a swizzle. While we're at it,

Re: [Mesa-dev] [PATCH 2/2] mesa/dri: drop unneeded mm.h include

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 07:27, Dave Airlie wrote: > From: Dave Airlie > > This isn't used in any of these drivers. > Indeed - it's used by the rtasm code. For the series Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [PATCH] pipe-loader: fix driinfo for software and non-radeonsi drivers

2017-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes: 678dadf1237 ("gallium: move driinfo XML to pipe_loader") -- My bad for never actually testing another driver... this should fix it. --- src/gallium/auxiliary/pipe-loader/pipe_loader.c | 2 ++ src/gallium/state_trackers/dri/drisw.c | 8 2 files chan

[Mesa-dev] Gallium driconf aborts

2017-08-02 Thread Thomas Hellstrom
Nicolai, It seems the driinfo_gallium.h file is missing a DRI_CONF_BEGIN and a DRI_CONF_END When running a GL application on master, I get Fatal error in __driConfigOptions line 1, column 0: must be inside . Aborted (core dumped) /Thomas ___

Re: [Mesa-dev] [PATCH] pipe-loader: fix driinfo for software and non-radeonsi drivers

2017-08-02 Thread Thomas Hellstrom
Thanks. Fixes the problem on svga. Reviewed-by: Thomas Hellström On 08/02/2017 11:43 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle Fixes: 678dadf1237 ("gallium: move driinfo XML to pipe_loader") -- My bad for never actually testing another driver... this should fix it. --- src/gallium

[Mesa-dev] [AppVeyor] mesa master #5109 completed

2017-08-02 Thread AppVeyor
Build mesa 5109 completed Commit eb88ece9e3 by Nicolai Hähnle on 8/2/2017 9:48 AM: Fix gallium SCons build Configure your notification preferences ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH 11/13] swr/rast: fixes for 32-bit builds

2017-08-02 Thread Emil Velikov
On 1 August 2017 at 17:36, Rowley, Timothy O wrote: > >> On Jul 31, 2017, at 3:56 PM, Emil Velikov wrote: >> >> Hi Tim, >> >> Some of the inline functions seem unused. >> Very quick search showed the following: >> >> InterpolateComponent >> _simd128_abs_ps >> _simd_abs_ps > > The intent of simdli

Re: [Mesa-dev] [PATCH v2 12/17] swr/rast: fix scons gen_knobs.h dependency

2017-08-02 Thread Emil Velikov
On 1 August 2017 at 20:44, Tim Rowley wrote: > Copy/paste error was duplicating a gen_knobs.cpp rule. Fixes: 5079c277b57 ("swr: [scons] Fix windows build") Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:

[Mesa-dev] [PATCH 2/3] radv: Add VK_EXT_acquire_xlib_display

2017-08-02 Thread Keith Packard
This uses X leases to provide the same API as nVidia, allowing an application to discover available display resources and acquire one from the X server using RandR leases. Signed-off-by: Keith Packard --- configure.ac | 11 + src/amd/vulkan/Makefile.am |

[Mesa-dev] [PATCH 3/3] radv: add VK_EXT_display_control to radv

2017-08-02 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_device.c | 22 ++- src/amd/vulkan/radv_entrypoints_gen

[Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

2017-08-02 Thread Keith Packard
Implements VK_KHR_display and VK_EXT_direct_mode_display using DRM/KMS. Expose ability to get to that using VK_KEITHP_kms_display, which allows the application to provide a master fd to the library which it uses instead of opening its own. Signed-off-by: Keith Packard --- configure.ac

[Mesa-dev] [PATCH 0/3] radv: Add leasing support

2017-08-02 Thread Keith Packard
I've split this into three patches to make review at least a little easier. The first provides the KHR_display extension using the new KEITHP_kms_display extension that allows you to pass in a DRM master to vkCreateInstance. The second provides EXT_acquire_xlib_display, which is an API that nVidi

Re: [Mesa-dev] [PATCH v2 15/17] swr/rast: split gen_knobs templates into .h/.cpp

2017-08-02 Thread Emil Velikov
On 1 August 2017 at 20:44, Tim Rowley wrote: > Switch to a 1:1 mapping template:generated for future maintenance. > --- > src/gallium/drivers/swr/Makefile.am| 3 +- > src/gallium/drivers/swr/SConscript | 2 +- > .../drivers/swr/rasterizer/codegen/gen_knobs.py

Re: [Mesa-dev] [PATCH v2] mesa: Fix swizzling for luminance/intensity in _mesa_readpixels

2017-08-02 Thread Nicolai Hähnle
On 01.08.2017 00:15, Chris Wilson wrote: Quoting Chris Wilson (2017-07-31 22:51:25) Luminance/Intensity when converted to RGB should be replicated to fill the RGB channels, but they differ on how the alpha channel is filled, as luminance is set to 1 (unless alpha is supplied) and intensity is re

Re: [Mesa-dev] [PATCH 04/10] nir/spirv: add plumbing for KHR_shader_ballot and KHR_subgroup_vote

2017-08-02 Thread Nicolai Hähnle
Patches 2 & 3: Reviewed-by: Nicolai Hähnle Patch 4: Acked-by: Nicolai Hähnle On 01.08.2017 04:24, Connor Abbott wrote: From: Connor Abbott --- src/compiler/spirv/nir_spirv.h | 2 + src/compiler/spirv/spirv_to_nir.c | 79 ++ src/compiler/spirv

Re: [Mesa-dev] [Mesa-stable] [7.5/22] i965/wm: Fix number of layers in 3D images

2017-08-02 Thread Emil Velikov
On 19 July 2017 at 20:53, Topi Pohjolainen wrote: > CC: mesa-sta...@lists.freedesktop.org > CC: Kenneth Graunke > Signed-off-by: Topi Pohjolainen Topi, the patch has explicitly dropped the mesa-stable tag upon merge. Note that this is considered self-rejection, so this patch won't be in the sta

Re: [Mesa-dev] [Mesa-dev RESEND 26/26] mesa: add KHR_no_error support to glPolygonMode()

2017-08-02 Thread Samuel Pitoiset
On 08/02/2017 03:14 AM, Timothy Arceri wrote: \o/ 9-26: Reviewed-by: Timothy Arceri Thanks for doing all this :) Please try to knock off a few more piglit tests here and there when time permits, it would be a shame if dev's tried to start turning this stuff on only to run into strange erro

Re: [Mesa-dev] [PATCH 1/2] gallium: add CAPs to support HW atomic counters.

2017-08-02 Thread Nicolai Hähnle
On 02.08.2017 01:00, Dave Airlie wrote: From: Dave Airlie This looks like an evergreen specific feature, but with atomic counters AMD have hw specific counters they use instead of operating on buffers directly. These are separate to the buffer atomics, so require different limits and code paths

Re: [Mesa-dev] [PATCH 2/2] mesa/dri: drop unneeded mm.h include

2017-08-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 2, 2017 at 8:27 AM, Dave Airlie wrote: > From: Dave Airlie > > This isn't used in any of these drivers. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i915/i830_texblend.c | 1 - > src/mesa/drivers/dri/i915/intel_context.h

Re: [Mesa-dev] [PATCH] i965: Delete pitch alignment assertion in get_blit_intratile_offset_el.

2017-08-02 Thread Chris Wilson
Quoting Kenneth Graunke (2017-08-02 02:14:22) > The cacheline alignment restriction is on the base address; the pitch > can be anything. From my understanding of the bug, this is correct and the workaround is to adjust the xoffset as you have done. (And since the chunk is limited to less than 32k

Re: [Mesa-dev] [PATCH 1/2] r300: drop u_mm.h include.

2017-08-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 2, 2017 at 8:27 AM, Dave Airlie wrote: > From: Dave Airlie > > This is not used in any of these files. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r300/r300_emit.c| 1 - > src/gallium/drivers/r300/r300_hyperz.c | 1 - > src/galli

Re: [Mesa-dev] [PATCH] egl: Add swrast support to surfaceless platform

2017-08-02 Thread Emil Velikov
[+Chad] Hi Akihiko Odaki, Thank you for the patch and welcome to Mesa! How you tested this patch? Did you run a test suite like piglit, dEQP, etc? Can you give it a spin with either one of these, comparing HW vs swrast surfacess and share the results. On 1 August 2017 at 06:49, Akihiko Odaki w

Re: [Mesa-dev] [PATCH 1/2] gallium: add CAPs to support HW atomic counters.

2017-08-02 Thread Marek Olšák
It would make sense to add pipe_context::set_atomic_counter_buffers(pipe, start, count, buffers) that are available in all shader stages, because it's how OpenGL works. Only SSBOs are per-shader stage. Marek On Wed, Aug 2, 2017 at 12:56 PM, Nicolai Hähnle wrote: > On 02.08.2017 01:00, Dave Airli

Re: [Mesa-dev] [PATCH 14/14] TEST PIGLIT: ac/surface: compute tile swizzle for GFX9

2017-08-02 Thread Nicolai Hähnle
Assuming no test regressions and printfs are removed, the series is: Reviewed-by: Nicolai Hähnle On 01.08.2017 01:40, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_surface.c| 87 +- src/amd/common/ac_surface.h|

[Mesa-dev] [PATCH] st/mesa: replace st_shader_stage_to_ptarget

2017-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle Use pipe_shader_type_from_mesa instead. --- src/mesa/state_tracker/st_atom_constbuf.c | 2 +- src/mesa/state_tracker/st_context.h| 24 src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +++--

Re: [Mesa-dev] [PATCH] st/mesa: replace st_shader_stage_to_ptarget

2017-08-02 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 08/02/2017 01:13 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Use pipe_shader_type_from_mesa instead. --- src/mesa/state_tracker/st_atom_constbuf.c | 2 +- src/mesa/state_tracker/st_context.h| 24 src/mesa/state_tracker/

Re: [Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

2017-08-02 Thread Emil Velikov
Hi Keith, A couple of questions/suggestions. On 2 August 2017 at 11:12, Keith Packard wrote: > Implements VK_KHR_display and VK_EXT_direct_mode_display using > DRM/KMS. > > Expose ability to get to that using VK_KEITHP_kms_display, which > allows the application to provide a master fd to the lib

Re: [Mesa-dev] [PATCH] st/mesa: replace st_shader_stage_to_ptarget

2017-08-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 2, 2017 at 1:13 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Use pipe_shader_type_from_mesa instead. > --- > src/mesa/state_tracker/st_atom_constbuf.c | 2 +- > src/mesa/state_tracker/st_context.h| 24 > src

[Mesa-dev] [PATCH] i965: Allow manual detiled uploads on !llc

2017-08-02 Thread Chris Wilson
With WC support, we can also use our manual detiling paths for !llc architectures as well. This is even more important for those as the indirection of the GTT is even more significant. Currently, we can only effectively support WC uploads into X-tiling, as we have to uploading into Y is slower tha

[Mesa-dev] [PATCH] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Samuel Pitoiset
Other ones are either unsupported or don't have any helper function checks. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 -- src/compiler/glsl/builtin_variables.cpp | 2 +- src/compiler/glsl/glsl_parser_extras.h | 5 + 3 files changed, 10 insertions(+),

[Mesa-dev] [PATCH 4/4] st/dri2 Plumb the flush_swapbuffer functionality through to dri3

2017-08-02 Thread Thomas Hellstrom
Implement the state tracker manager drawable interface flush_swapbuffer method by plumbing it through to dri3 if available. Signed-off-by: Thomas Hellstrom Reviewed-by: Marek Olšák Reviewed-by: Brian Paul Reviewed-by: Sinclair Yeh --- src/gallium/state_trackers/dri/dri2.c | 16 +++

[Mesa-dev] [PATCH 1/4] dri: Add a flushSwapBuffers method to the image loader extension

2017-08-02 Thread Thomas Hellstrom
This method may be used by dri drivers to make sure all outstanding buffer swaps have been flushed to hardware. Also make sure we're allowed to bump the image loader extension version without actually providing the getCapability method that was introduced with the previous version. Signed-off-by:

[Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

2017-08-02 Thread Thomas Hellstrom
In v2 of the patch series, one freestanding patch has already been committed and the back-to-fake-front flip patch has been dropped since it requires some more work to not break EGL. Remaining is actually only the parts that allow glFinish to be used instead of glXWaitGL. Main changes except some

[Mesa-dev] [PATCH 2/4] glx/dri3: Implement the flush_swapbuffers method

2017-08-02 Thread Thomas Hellstrom
Provide a dri3 implementation for the image loader extension method. Signed-off-by: Thomas Hellstrom --- src/glx/dri3_glx.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index cc11037..64c0b9e 100644 ---

[Mesa-dev] [PATCH 3/4] gallium/st: Add a method to flush outstanding swapbuffers

2017-08-02 Thread Thomas Hellstrom
Add a state tracker interface method to flush outstanding swapbuffers, and add a call to it from the mesa state tracker during glFinish(). This doesn't strictly mean the outstanding swapbuffers have actually finished executing but is sufficient for glFinish() to be able to be used as a replacement

[Mesa-dev] [PATCH] ac: add ac_shader_abi.h in distcheck

2017-08-02 Thread Juan A. Suarez Romero
Fixes: CXXLDaddrlib/libamdgpu_addrlib.la ar: `u' modifier ignored since `D' is the default (see `U') ../../../../src/amd/common/ac_nir_to_llvm.c:33:27: fatal error: ac_shader_abi.h: No such file or directory #include "ac_shader_abi.h" ^ compilation terminated. Mak

[Mesa-dev] [Bug 102012] build failure after git_sha1 changes

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102012 Tobias Klausmann changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] build: Don't bail on OSError in git_sha1_gen.py

2017-08-02 Thread Eric Engestrom
On Wednesday, 2017-08-02 03:05:42 +0200, Tobias Klausmann wrote: > When building sandboxed, we may encounter additional errors. Ignore the > errors, > as we are in a constrained environment. > > This can be observed when building latest git with OBS. > > Signed-off-by: Tobias Klausmann R-b and

Re: [Mesa-dev] [PATCH] build: Don't bail on OSError in git_sha1_gen.py

2017-08-02 Thread Jose Fonseca
Indeed a wildcard exception (ie, a mere `except:`) seems more future proof. Jose From: Eric Engestrom Sent: Wednesday, August 2, 2017 14:46 To: Tobias Klausmann Cc: mesa-dev@lists.freedesktop.org; Emil Velikov; Jose Fonseca Subject: Re: [Mesa-dev] [PATCH] buil

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-08-02 Thread Emil Velikov
On 1 August 2017 at 16:29, Rafael Antognolli wrote: > On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh wrote: >> Rafael, Tomasz, >> >> > -Original Message- >> > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> > Of Rafael Antognolli >> > Sent: Tuesday,

[Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Eric Engestrom
String handling has changed on python3. Before this patch: After: (No change on python2, it always looked ok) Cc: Jose Fonseca Fixes: b99dcbfeb344390fea99 "build: Convert git_sha1_gen script to Python." Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 2 +- 1 file changed, 1 insertion(

[Mesa-dev] Build error since gallium: add pipe_screen_config to screen_create functions

2017-08-02 Thread Andy Furniss
make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/pipe-loader' CC pipe_radeonsi.lo pipe_radeonsi.c: In function ‘create_screen’: pipe_radeonsi.c:15:34: error: ‘flags’ undeclared (first use in this function) rw = amdgpu_winsys_create(fd, flags, radeonsi_screen_crea

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 --- Comment #2 from Thiago Macieira --- SUSE developers think the problem is actually a bug in glibc: the LLVM dependencies in the Radeon driver are causing the dynamic loader confusion. https://bugzilla.opensuse.org/show_bug.cgi?id=1022156 --

Re: [Mesa-dev] Build error since gallium: add pipe_screen_config to screen_create functions

2017-08-02 Thread Andy Furniss
Never mind, I see this is already reported on dri-devel Andy Furniss wrote: make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/pipe-loader' CC pipe_radeonsi.lo pipe_radeonsi.c: In function ‘create_screen’: pipe_radeonsi.c:15:34: error: ‘flags’ undeclared (first use in

Re: [Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Jose Fonseca
Ah, yeah. We only expect an hash, so probably it's better to avoid UTF and presume output is ASCII: diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index 6d13db1e16..61e59e4131 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py @@ -17,4 +17,5 @@ except subprocess.CalledProcessErr

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 --- Comment #3 from Michel Dänzer --- (In reply to Thiago Macieira from comment #2) > https://bugzilla.opensuse.org/show_bug.cgi?id=1022156 BTW, looks like SUSE is building LLVM with BUILD_SHARED_LIBS=ON, which is a bad idea. They should build

Re: [Mesa-dev] [PATCH] ac: add ac_shader_abi.h in distcheck

2017-08-02 Thread Nicolai Hähnle
On 02.08.2017 15:10, Juan A. Suarez Romero wrote: Fixes: CXXLDaddrlib/libamdgpu_addrlib.la ar: `u' modifier ignored since `D' is the default (see `U') ../../../../src/amd/common/ac_nir_to_llvm.c:33:27: fatal error: ac_shader_abi.h: No such file or directory #include "ac_shader_abi.h"

Re: [Mesa-dev] [PATCH] intel/isl: Stop padding surfaces

2017-08-02 Thread Tomasz Figa
On Tue, Aug 1, 2017 at 3:27 AM, Jason Ekstrand wrote: > The docs contain a bunch of commentary about the need to pad various > surfaces out to multiples of something or other. However, all of those > requirements are about avoiding GTT errors due to missing pages when the > data port or sampler a

[Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 --- src/gallium/targets/pipe-loader/pipe_r300.c | 2 +- src/gallium/targets/pipe-loader/pipe_r600.c | 2 +- src/gallium/ta

Re: [Mesa-dev] [PATCH v2 00/17] swr: update rasterizer

2017-08-02 Thread Cherniak, Bruce
Entire set Reviewed-by: Bruce Cherniak > On Aug 1, 2017, at 2:44 PM, Tim Rowley wrote: > > Highlights include enabling the simd16 frontend and code cleanups. > > v2: split previous gen_knobs patch into five chunks: scons fix, > relicense to match rest of tree, code style, template split, >

Re: [Mesa-dev] [PATCH] egl: Add swrast support to surfaceless platform

2017-08-02 Thread Gurchetan Singh
Would kms_swrast + vgem for surfaceless also work for the use case raised in the bug, or is that a no-go because it assumes the presence of a driver? I've been testing it[1], it works pretty well, except for one issue during ChromeOS startup. [1] https://chromium-review.googlesource.com/c/558218

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 16:29, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create > functions") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 Seems like my s/flags/config->flags/ suggestion was way off. Thanks for

Re: [Mesa-dev] [PATCH 1/4] dri: Add a flushSwapBuffers method to the image loader extension

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 13:23, Thomas Hellstrom wrote: > This method may be used by dri drivers to make sure all outstanding > buffer swaps have been flushed to hardware. > Also make sure we're allowed to bump the image loader extension version > without actually providing the getCapability method tha

Re: [Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

2017-08-02 Thread Jason Ekstrand
So, it looks like I'll need some blorp patches before we can land this for real. I'll try and cook some up. On Wed, Aug 2, 2017 at 2:35 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Both are : > > Reviewed-by: Lionel Landwerlin > > > On 02/08/17 02:16, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
On 02.08.2017 18:04, Emil Velikov wrote: On 2 August 2017 at 16:29, Nicolai Hähnle wrote: From: Nicolai Hähnle Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 Seems like my s/flags/config->flags/

[Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 -- I believe this is the right place to add it; the error reported by

Re: [Mesa-dev] [PATCH] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Ilia Mirkin
On Aug 2, 2017 6:56 AM, "Samuel Pitoiset" wrote: Other ones are either unsupported or don't have any helper function checks. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 -- src/compiler/glsl/builtin_variables.cpp | 2 +- src/compiler/glsl/glsl_parser_extr

Re: [Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

2017-08-02 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh On Wed, Aug 02, 2017 at 02:23:52PM +0200, Thomas Hellstrom wrote: > In v2 of the patch series, one freestanding patch has already been committed > and the back-to-fake-front flip patch has been dropped since it requires some > more work to not break EGL. Remaining is act

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 17:14, Nicolai Hähnle wrote: > On 02.08.2017 18:04, Emil Velikov wrote: >> >> On 2 August 2017 at 16:29, Nicolai Hähnle wrote: >>> >>> From: Nicolai Hähnle >>> >>> Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create >>> functions") >>> Bugzilla: https://bugs

Re: [Mesa-dev] [PATCH 2/4] glx/dri3: Implement the flush_swapbuffers method

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 13:23, Thomas Hellstrom wrote: > Provide a dri3 implementation for the image loader extension method. > > Signed-off-by: Thomas Hellstrom > --- > src/glx/dri3_glx.c | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/src/glx

Re: [Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Jose Fonseca
Either way Reviewed-by: Jose Fonseca Thanks On 02/08/17 15:10, Eric Engestrom wrote: String handling has changed on python3. Before this patch: After: (No change on python2, it always looked ok) Cc: Jose Fonseca Fixes: b99dcbfeb344390fea99 "build: Convert git_sha1_gen script to Python."

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Andy Furniss
Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 -- I believe this is

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Nicolai Hähnle
Thanks! I'll take that as a Tested-by. On 02.08.2017 18:43, Andy Furniss wrote: Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions")

[Mesa-dev] [PATCH mesa] egl: check the correct function pointer

2017-08-02 Thread Eric Engestrom
`.swap_interval` != `.SwapInterval`... Fixes: 991ec1b81a76de24fd01 "egl: make platform's SwapInterval() optional" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102015 Cc: Cedric Sodhi Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ src/egl/main/eglapi.c

[Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Brian Paul
We pretty much use the convention that if gl_renderbuffer::NumSamples or gl_texture_image::NumSamples is zero, it's a non-MSAA surface. Otherwise, it's an MSAA surface. This patch changes the sample count checks in st_AllocTextureStorage() and st_renderbuffer_alloc_storage() to test for samples >

[Mesa-dev] [PATCH 2/3] svga: check for sample_count > 0 in svga_is_format_supported()

2017-08-02 Thread Brian Paul
See previous commit for more info. If sample_count=1, we want to return failure here since we don't support 1x MSAA. --- src/gallium/drivers/svga/svga_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/sv

[Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

2017-08-02 Thread Brian Paul
If the texture is multisampled, the coord.w component indicates which sample to fetch. --- src/gallium/docs/source/tgsi.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index d7817cc..5bf9e95 100644 --- a

Re: [Mesa-dev] [PATCH mesa] egl: check the correct function pointer

2017-08-02 Thread Emil Velikov
On 2 August 2017 at 17:47, Eric Engestrom wrote: > `.swap_interval` != `.SwapInterval`... > Had a bit of a brain freeze when I read this - can you please elaborate a bit. Feel free to reuse any of the following: "Earlier commit made the platform .swap_interval optional, at the same time it was ch

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-08-02 Thread Rafael Antognolli
On Wed, Aug 02, 2017 at 02:56:34PM +0100, Emil Velikov wrote: > On 1 August 2017 at 16:29, Rafael Antognolli > wrote: > > On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh wrote: > >> Rafael, Tomasz, > >> > >> > -Original Message- > >> > From: mesa-dev [mailto:mesa-dev-boun...@lis

[Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

2017-08-02 Thread Jordan Justen
To get the extension list: $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \ grep -v disabled | awk '{print $2}' | sed -E 's/(name=)?"//g' | sort To find anv(il) and radv supported extensions: $ git grep -hE "'VK_([A-Z]+)_[a-z]" src/intel/ $ git grep -hE "'VK_([A-Z]+)_[a

Re: [Mesa-dev] [PATCH 2/4] glx/dri3: Implement the flush_swapbuffers method

2017-08-02 Thread Thomas Hellstrom
On 08/02/2017 06:31 PM, Emil Velikov wrote: On 2 August 2017 at 13:23, Thomas Hellstrom wrote: Provide a dri3 implementation for the image loader extension method. Signed-off-by: Thomas Hellstrom --- src/glx/dri3_glx.c | 30 +- 1 file changed, 29 insertions(+),

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

2017-08-02 Thread Jan Vesely
The patch still causes segfaults because you pass NULL at core/device.cpp:45 yet unconditionally access the pointer at pipe_loader.c:130 Jan On Wed, 2017-08-02 at 18:44 +0200, Nicolai Hähnle wrote: > Thanks! I'll take that as a Tested-by. > > On 02.08.2017 18:43, Andy Furniss wrote: > > Building

Re: [Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

2017-08-02 Thread Jason Ekstrand
lgtm On Wed, Aug 2, 2017 at 10:51 AM, Jordan Justen wrote: > To get the extension list: > > $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \ > grep -v disabled | awk '{print $2}' | sed -E 's/(name=)?"//g' | sort > > To find anv(il) and radv supported extensions: > > $ gi

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Roland Scheidegger
I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which isn't possible anywhere else, other apis have no distinction between a multisampled surface with sample count 1 and a non-multisampled surface with

Re: [Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

2017-08-02 Thread Roland Scheidegger
Am 02.08.2017 um 19:07 schrieb Brian Paul: > If the texture is multisampled, the coord.w component indicates which > sample to fetch. > --- > src/gallium/docs/source/tgsi.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/docs/source/tgsi.rst > b/src/gall

Re: [Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

2017-08-02 Thread Brian Paul
On 08/02/2017 12:03 PM, Roland Scheidegger wrote: Am 02.08.2017 um 19:07 schrieb Brian Paul: If the texture is multisampled, the coord.w component indicates which sample to fetch. --- src/gallium/docs/source/tgsi.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/g

[Mesa-dev] [PATCH 1/1] clover: Pass valid config structure to pipe_loader_create_screen

2017-08-02 Thread Jan Vesely
Fixes: Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Signed-off-by: Jan Vesely --- apply with the other build/link fixes src/gallium/state_trackers/clover/core/device.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_

Re: [Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

2017-08-02 Thread Thomas Hellstrom
On 08/02/2017 06:10 PM, Sinclair Yeh wrote: Reviewed-by: Sinclair Yeh On Wed, Aug 02, 2017 at 02:23:52PM +0200, Thomas Hellstrom wrote: In v2 of the patch series, one freestanding patch has already been committed and the back-to-fake-front flip patch has been dropped since it requires some mor

Re: [Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

2017-08-02 Thread Keith Packard
Emil Velikov writes: > Is the VK_KEITHP_kms_display spec available somewhere? I haven't written one yet. I'll go draft one. > Since there are multiple companies [participating in Mesa] with > Khronos membership, could we make this an EXT extension? Once > everything else is settled in, of cours

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

2017-08-02 Thread Brian Paul
On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which isn't possible anywhere else, other apis have no distinction between a multisampled surface with

Re: [Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

2017-08-02 Thread Bas Nieuwenhuizen
Acked-by: Bas Nieuwenhuizen On Wed, Aug 2, 2017 at 7:57 PM, Jason Ekstrand wrote: > lgtm > > On Wed, Aug 2, 2017 at 10:51 AM, Jordan Justen > wrote: >> >> To get the extension list: >> >> $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \ >> grep -v disabled | awk '{print

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 Bug ID: 102017 Summary: Wrong colours in Cities Skyline Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #1 from Marcin Gałązka --- Created attachment 133206 --> https://bugs.freedesktop.org/attachment.cgi?id=133206&action=edit Screenshot from game -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #2 from Marcin Gałązka --- Created attachment 133207 --> https://bugs.freedesktop.org/attachment.cgi?id=133207&action=edit Screenshot from menu -- You are receiving this mail because: You are the QA Contact for the bug. You are t

[Mesa-dev] [PATCH 1/2] configure.ac: unconditionally check for expat

2017-08-02 Thread Emil Velikov
From: Emil Velikov Earlier commits moved the xmlconfig library to a wider userbase. Thus having the check within --enable-dri is insufficient. Upon closer nine needed it from it's early days - 948e6c52282 ("nine: Add drirc options (v2)") Fixes: 601093f95ddf ("xmlconfig: move into src/util") Cc:

[Mesa-dev] [PATCH 2/2] configure.ac: drop support for ancient expat versions

2017-08-02 Thread Emil Velikov
From: Emil Velikov Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra gymnastics to detect it. Version 2.1.0 was released back in Mar 2012 and all major distributions use it. Cc: Michel Dänzer Signed-off-by: Emil Velikov --- Well... almost. Even Debian oldoldstable ships

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #3 from Marcin Gałązka --- Created attachment 133208 --> https://bugs.freedesktop.org/attachment.cgi?id=133208&action=edit Dump from glxinfo -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

2017-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #4 from Marcin Gałązka --- Created attachment 133209 --> https://bugs.freedesktop.org/attachment.cgi?id=133209&action=edit Dump from lspci (gfx only) -- You are receiving this mail because: You are the assignee for the bug. You a

  1   2   >