[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #5 from raffa...@zoho.com --- Sorry but I can't manage to apply this patch, which branch/commit it's supposed to be applied on? (tried on master) patching file src/gallium/state_trackers/nine/device9.c Hunk #1 succeeded at 2915 with

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #6 from Axel Davy --- It applies well for me on master. You can also find the patch here: https://github.com/iXit/Mesa-3D -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug

Re: [Mesa-dev] [PATCH v4 3/4] egl: implement __DRIbackgroundCallableExtension.isThreadSafe

Hi Gregory, On 21 May 2017 at 15:59, Gregory Hainaut wrote: > +static GLboolean > +dri_is_thread_safe(void *loaderPrivate) > +{ > +#ifdef HAVE_X11_PLATFORM > + struct dri2_egl_surface *dri2_surf = loaderPrivate; > + _EGLDisplay *display = dri2_surf->base.Resource.Display; Move these out of

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #7 from raffa...@zoho.com --- ah, I'm on git://anongit.freedesktop.org/mesa/mesa , I'll try iXit then -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

I suppose the failures happen with S2TC lib-dxtn implementation. Because I haven't seen them failing with the old implementation, or when no implementation is present (as the tests will just skip.) We could craft the test cases so they aren't sensitive to S2TC. On the other hand the patent ex

Re: [Mesa-dev] [PATCH v13 20/36] i965/miptree: Allocate mcs_buf for an image's CCS_E

On Fri, May 19, 2017 at 10:38:03AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in > later if preferred. > >

Re: [Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

This fixes WoW for me Thanks On Mon, 22 May 2017 at 00:18 wrote: > *Comment # 4 on > bug 101088 from Axel > Davy * > > Should be fixed > byhttps://lists.freedesktop.org/archives/mesa

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] radeonsi: load patch_id for TES-as-ES when exporting for PS

Hi Emil, I'm not actually aware of a real application affected by this. I noticed it while fixing a corner case for the CTS, and there's a piglit test for it now, but even the CTS isn't affected. So to be honest I'd just drop this patch from stable. Cheers, Nicolai On 18.05.2017 19:52, Emil

Re: [Mesa-dev] [PATCH v13 30/36] i965: Use partial resolves for CCS buffers being scanned out

On Fri, May 19, 2017 at 10:38:13AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > On Gen9 hardware, the display engine is able to scanout a compressed > framebuffer by providing an offset to auxiliary compression information. > Unfortunately, the hardware is incapable of doing the same thing

Re: [Mesa-dev] [PATCH v13 31/36] i965/miptree: Remove dead code assertion

On Fri, May 19, 2017 at 10:38:14AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > We no longer allocate a miptree for the mcs_buf, so this is not a useful > assertion. > > While here, move the CCS disabling so that we only conditionally shut it > off. This helps us dtrt later when CCS is us

Re: [Mesa-dev] [PATCH v2] drirc: Add allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition

Reviewed-by: Samuel Pitoiset On 05/21/2017 11:46 PM, Benedikt Schemmer wrote: From: Benedikt Schemmer This patch sets the allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition. Tested with Mesa git as of today and Dying Light, Dead Island Definitive Edition

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

On 05/20/2017 09:01 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Hi, This series implements ARB_bindless_texture for RadeonSI. Reminder: the GLSL compiler part is already upstream. This series has been mainly tested with Feral games, here's the list of existing game

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

On 05/22/2017 01:26 AM, Roland Scheidegger wrote: Clearly, you forgot the doc bits... Yes, some doc bits could be helpful. :) Roland Am 19.05.2017 um 18:52 schrieb Samuel Pitoiset: Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_context.h | 16 1 file c

Re: [Mesa-dev] [PATCH v13 32/36] i965: Remove scanout restriction from lossless compression

On Fri, May 19, 2017 at 10:38:15AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > v2: Try to keep the assert as recommended by Topi. This requires > modifying the num_samples check to be <= 1 because internally created > buffers set num_samples = 0. > > v3: Buffers are proactively marked as

Re: [Mesa-dev] [PATCH] etnaviv: Don't try to use the index buffer if size is zero

Am Freitag, den 19.05.2017, 12:40 +0200 schrieb Tomeu Vizoso: > If info->index_size is zero, info->index will point to uninitialized > memory. > > Fatal signal 11 (SIGSEGV), code 2, fault addr 0xab5d07a3 in tid 20456 > (surfaceflinger) > > Signed-off-by: Tomeu Vizoso > Cc: etna...@lists.freedes

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #8 from raffa...@zoho.com --- it won't compile due to some issue with llvm (5.0 master branch, which was fine for mesa repo), which version should I use? -- You are receiving this mail because: You are the assignee for the bug. You

Re: [Mesa-dev] [PATCH v4 4/4] glthread/gallium: require safe_glthread to start glthread

Hi Gregory, A minor nit below and this that the series is Reviewed-by: Emil Velikov On 21 May 2017 at 15:59, Gregory Hainaut wrote: > Print an error message for the user if the requirement isn't met, or > we're not thread safe. > > v2: based on Nicolai feedbacks > Check the DRI extension versio

[Mesa-dev] [Bug 100741] Chromium - Memory leak

https://bugs.freedesktop.org/show_bug.cgi?id=100741 Gary Wang changed: What|Removed |Added CC||gary.c.w...@intel.com -- You are receiving

[Mesa-dev] [PATCH] r600: fix compilation error without amdgpu

This fixes the following compilation error when amdgpu is not selected. CC common/common_libamd_common_la-ac_gpu_info.lo In file included from common/ac_gpu_info.c:26:0: common/ac_gpu_info.h:31:10: fatal error: amdgpu.h: No such file or directory #include ^~ compilation

Re: [Mesa-dev] [PATCH v2 0/6] Various fixes to integer GetUniform*()

On Sat, 2017-05-20 at 14:09 -0700, Matt Turner wrote: > On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga m> wrote: > > The main change is that we now use round*() instead of IROUND*() > > which only > > worked for signed integer cases. I have also made it so we write > > converted unsigned valu

[Mesa-dev] Mesa 17.1.1 release candidate

Hello list, The candidate for the Mesa 17.1.1 is now available. Currently we have: - 40 queued - 20 nominated (outstanding) - and 1 rejected patch(es) The current queue consists of: The mesa GLVND GLX library now handles glXGetDriverConfig, as used by driconf. The GBM module has a bugfix fo

[Mesa-dev] [PATCH] egl/wayland: verify event queue was allocated

We're already verified that 'window' wasn't NULL, I'm guess this allocation error is about the newly created queue. CID: 1409754 Signed-off-by: Lionel Landwerlin --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/p

Re: [Mesa-dev] [PATCH 2/3] i965: Use the upload BO for push constants on Gen9+.

Hi, On 13.05.2017 22:26, Kenneth Graunke wrote: Shaders can use quite a bit of uniform data. Better to put it in the upload buffers, like we do for client vertex data, rather than the batch buffer state area, which is primarly used for indirect state. This should free up batch space, allowing

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move building llvm.SI.load.const into ac_build_buffer_load

On Mon, May 22, 2017 at 8:44 AM, Nicolai Hähnle wrote: > On 19.05.2017 17:54, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/amd/common/ac_llvm_build.c | 50 >> >> src/amd/common/ac_llvm_build.h | 3 +- >> src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

On Sun, May 21, 2017 at 10:49 PM, Thomas Helland wrote: > From: Vladislav Egorov > > strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" > only if the identifier starts with '_', which is rare. > > Reviewed-by: Ian Romanick > --- > src/compiler/glsl/glcpp/glcpp-parse.y | 14

Re: [Mesa-dev] [PATCH libdrm] header: update drm_fourcc.h

Am Dienstag, den 02.05.2017, 16:35 +0200 schrieb Lucas Stach: > Mostly to pull in the Vivante tiling format modifiers, but some other > little changes included. > > Signed-off-by: Lucas Stach If there are no objections to this patch, I'm going to push it today. Regards, Lucas > --- > include/

Re: [Mesa-dev] [PATCH libdrm] header: update drm_fourcc.h

Hi Lucas, On 22 May 2017 at 11:53, Lucas Stach wrote: > Am Dienstag, den 02.05.2017, 16:35 +0200 schrieb Lucas Stach: >> Mostly to pull in the Vivante tiling format modifiers, but some other >> little changes included. > > If there are no objections to this patch, I'm going to push it today. The

Re: [Mesa-dev] [PATCH] egl/wayland: verify event queue was allocated

On 22 May 2017 at 11:07, Lionel Landwerlin wrote: > We're already verified that 'window' wasn't NULL, I'm guess this > allocation error is about the newly created queue. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] Please dont remove support for working hardware

I have read on https://phoronix.com/scan.php?page=news_item&px=Mesa-2017-Cleanup-Discussion that there is a discussion about removing still working hardware. Please fix the problems instead. Please, dont remove suppor

Re: [Mesa-dev] [PATCH] egl/wayland: verify event queue was allocated

On 22 May 2017 at 12:16, Daniel Stone wrote: > On 22 May 2017 at 11:07, Lionel Landwerlin > wrote: >> We're already verified that 'window' wasn't NULL, I'm guess this >> allocation error is about the newly created queue. > > Reviewed-by: Daniel Stone Dan, others, please add the following before

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Pekka Paalanen > > The EGL_EXT_dma_buf_import_modifiers extension adds support for a > fourth plane, just like DRM KMS API does. > > Bump maximum dma_buf plane count to four. > > v2: prevent attribute tokens from being parsed if > EXT_image

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

Hey, On 22 May 2017 at 13:43, Emil Velikov wrote: > On 19 May 2017 at 10:37, Daniel Stone wrote: >> The EGL_EXT_dma_buf_import_modifiers extension adds support for a >> fourth plane, just like DRM KMS API does. >> >> Bump maximum dma_buf plane count to four. > > Patch 1 and 2 are > Reviewed-by:

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #9 from Hleb Valoshka <375...@gmail.com> --- Hi Axel, I've tested your patch with Unigine Heaven, HL2 mod Metastasis and STALKER: Shadows of Chernobyl. Everything is fine, no glitches, no crashes. -- You are receiving this mail bec

[Mesa-dev] [PATCH] glsl: Fix g++ initializer order warning

Fixes this warning: In file included from ../../../src/compiler/glsl/ir.cpp:25:0: ../../../src/compiler/glsl/ir.h: In constructor 'ir_swizzle::ir_swizzle(ir_rvalue*, ir_swizzle_mask)': ../../../src/compiler/glsl/ir.h:1955:20: warning: 'ir_swizzle::mask' will be initialized after [-Wreorder] i

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

Hi Dan, On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > query and return supported dmabuf format modifiers for > EGL_EXT_image_dma_buf_import_modifiers. > > v2: move format check to the driver instead of making format queries > here and then checking. > v3: Check DRIima

Re: [Mesa-dev] [PATCH v13 08/36] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > Signed-off-by: Varad Gautam > Reviewed-by: Daniel Stone > Signed-off-by: Daniel Stone > --- > src/egl/drivers/dri2/egl_dri2.c | 6 ++ > src/egl/main/eglapi.c | 1 + > 2 files changed, 7 insertions(+) > With Ja

Re: [Mesa-dev] [PATCH v13 09/36] st/dri: refactor multi-planar YUV import path

Hi Dan, On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > we currently ignore the plane count when converting from > __DRI_IMAGE_FORMAT* tokens to __DRI_IMAGE_FOURCC* for multiplanar > images, and only return the first plane's simplified fourcc. > > this adds a fourcc to __DR

Re: [Mesa-dev] [PATCH v13 11/36] st/dri: implement createImageWithModifiers in DRIimage

On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > adds a pscreen->resource_create_with_modifiers() to create textures > with modifier. > > Signed-off-by: Varad Gautam > Signed-off-by: Daniel Stone > --- > src/gallium/include/pipe/p_screen.h | 18 > src/gallium/st

Re: [Mesa-dev] [PATCH v13 13/36] st/dri: support format queries

On 05/19/2017 08:48 AM, Lucas Stach wrote: Am Freitag, den 19.05.2017, 10:37 +0100 schrieb Daniel Stone: From: Varad Gautam ask the driver for supported dmabuf formats v2: rebase to master. v3: return false on failure. v4: use pscreen->is_format_supported instead of adding a new query. (

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

On 22 May 2017 at 13:47, Daniel Stone wrote: > Hey, > > On 22 May 2017 at 13:43, Emil Velikov wrote: >> On 19 May 2017 at 10:37, Daniel Stone wrote: >>> The EGL_EXT_dma_buf_import_modifiers extension adds support for a >>> fourth plane, just like DRM KMS API does. >>> >>> Bump maximum dma_buf pl

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 20 May 2017 at 01:16, Rob Herring wrote: > On Fri, May 19, 2017 at 12:57 PM, Emil Velikov > wrote: >> On 18 May 2017 at 23:01, Rob Herring wrote: >>> On Thu, May 18, 2017 at 5:25 AM, Emil Velikov >>> wrote: On 18 May 2017 at 05:10, Chih-Wei Huang wrote: > 2017-05-18 12:01 GMT+08:

Re: [Mesa-dev] [PATCH v2] mesa: Avoid leaking surface in st_renderbuffer_delete

On 29 April 2017 at 15:37, Bartosz Tomczyk wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100741 > Fixes: a5e733c6b52 mesa: drop current draw/read buffer when ctx is released > CC: Rob Clark > v2: add comment in code Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] Please dont remove support for working hardware

No one is suggesting we completely drop support for old hardware. The drivers will still exist and work; they will just live in a legacy branch. We will also ensure that they are installable alongside the modern drivers and the expectation is that distros will continue to package them. The thing

[Mesa-dev] [PATCH v2 12/13] egl/drm: use dri2_setup_extensions() over the extensions provided by GBM

From: Emil Velikov Allows us to keep things in sync easier and lets us simplify the interface between the two even further. v2: Don't set GBM's extensions. Cc: Rob Herring Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 9 + 1 file changed, 5 insertions(+), 4 de

[Mesa-dev] [PATCH v2 13/13] gbm: manage only the required set of DRI extensions

From: Emil Velikov Currently GBM attempts to know all the extensions that might be required by EGL/DRM [at some later stage]. That is a bit unclear and we often forget to update GBM as EGL gets attention. To avoid that, simply let EGL manage it's own required extensions based on the base primit

Re: [Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

I'm not so familiar with this code, but it looks good to me. Marek On Mon, May 22, 2017 at 12:22 AM, Axel Davy wrote: > A few cleanups and in particular initializing properly > the new pipe_draw_info fields. > This should fix the regression caused by > 330d0607ed60fd3edca192e54b4246310f06652f >

Re: [Mesa-dev] [PATCH] r600: fix compilation error without amdgpu

Reviewed-by: Marek Olšák Marek On Mon, May 22, 2017 at 11:37 AM, Marc Dietrich wrote: > This fixes the following compilation error when amdgpu is not selected. > > CC common/common_libamd_common_la-ac_gpu_info.lo > In file included from common/ac_gpu_info.c:26:0: > common/ac_gpu_info.h:

Re: [Mesa-dev] i965/gen4: Depth buffer setup cleanup

On Sun, May 21, 2017 at 06:15:46PM +0300, Pohjolainen, Topi wrote: > On Sat, May 20, 2017 at 10:29:51PM +0300, Topi Pohjolainen wrote: > > First this series removes logic considering separate stencil > > gen < 6 only code paths (where we always use combined > > depth-stencil). > > > > Then patch

Re: [Mesa-dev] [PATCH 2/2] radeon: pass flags that can change shaders to disk_cache_create()

Reviewed-by: Marek Olšák Marek On Sat, May 20, 2017 at 3:36 AM, Timothy Arceri wrote: > I wasn't sure if I should filter the flags so that we only use > flags that actually change the shader output. To avoid manual > updates we just pass in everything for now. > --- > src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH] r600: fix compilation error without amdgpu

This patch won't be sufficient since you'll error out at link time, when building w/o radeonsi. There are three possible routes [1]. Let me know which one you prefer :-) -Emil [1] https://lists.freedesktop.org/archives/mesa-dev/2017-May/156429.html ___ m

Re: [Mesa-dev] [PATCH] docs: Document ASTC extension support for SKL and BXT

On Fri, May 19, 2017 at 4:42 PM, Nanley Chery wrote: > Cc: Anuj Phogat > Signed-off-by: Nanley Chery > --- > docs/features.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index e18bf54a48..05d776be08 100644 > --- a/docs/fe

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

Rhys Kidd writes: > On 21 May 2017 at 19:33, Roland Scheidegger wrote: > >> I suppose the s3tc problems should go away rather sooner than later, but >> isn't it possible to just disable the formats tests? >> > > Yes, see USE_TXC_DXTN that was introduced in > 29322daef2b77c4d869d2945fa1226e6b433c

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

Jose Fonseca writes: > I suppose the failures happen with S2TC lib-dxtn implementation. > Because I haven't seen them failing with the old implementation, or when > no implementation is present (as the tests will just skip.) > > We could craft the test cases so they aren't sensitive to S2TC. O

[Mesa-dev] [PATCH] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

This reverts commit e60928f4c4bd4484821d83f2b16a910ea9f5f9d9. PIPE_CC_GCC_VERSION is used by some of our in-house code which hasn't been upstreamed yet. --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_config.h b/src/gallium/i

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > This series adds support for Cannonlake. > > Changes from V1 to V2: > - Incorporated the review comments from V1. > - Rebased 8 months old CNL branch on top of master > - Wired up Linux and Android build files for gen10 > - Replaced the use of

Re: [Mesa-dev] [PATCH] glsl: Fix g++ initializer order warning

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vc4: Remove dead code in vc4_dump_surface_msaa()

Rhys Kidd writes: > Coverity caught the use of dead code copy-paste for > found_colors[] and num_found_colors. Reviewed and pushed. Thanks! signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lis

Re: [Mesa-dev] [PATCH V2 15/24] i965/cnl: Start using CNL MOCS defines

On Tue, May 16, 2017 at 04:01:30PM -0700, Anuj Phogat wrote: > On Tue, May 16, 2017 at 10:34 AM, Anuj Phogat wrote: > > CNL MOCS defines are duplicates of SKL MOCS defines. > > > I can actually drop this patch and continue using SKL MOCS defines for gen10+. > I also noticed that vulkan needs separ

Re: [Mesa-dev] [RFC PATCH 28/65] tc: add ARB_bindless_texture support

On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/util/u_threaded_context.c| 147 > + > .../auxiliary/util/u_threaded_context_calls.h | 4 + > 2 files changed, 151 insertions(+) > > diff --git a/

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

On 22/05/17 17:29, Eric Anholt wrote: Jose Fonseca writes: I suppose the failures happen with S2TC lib-dxtn implementation. Because I haven't seen them failing with the old implementation, or when no implementation is present (as the tests will just skip.) We could craft the test cases so the

[Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

This prevents spurious failures when libtxc-dxtn-s2tc is installed. Note: lp_test_format does need any change since we were already ignoring S3TC failures there. --- src/gallium/tests/unit/u_format_test.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/gallium/t

Re: [Mesa-dev] [RFC PATCH 29/65] tgsi: add new Bindless flag to tgsi_instruction_texture

On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > Old-style images are identified using TGSI_FILE_SAMPLER, but > bindless samplers can be TGSI_FILE_CONSTANT or TGSI_FILE_TEMPORARY. > > To avoid backend compilers to be confused, this adds a new flag > that will only be set for bindless samp

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote: > These declarations will help the code start compiling > once we wire up the makefiles for gen10. Later patches > will start using these functions for gen10. > > Signed-off-by: Anuj Phogat > --- > src/intel/isl/isl_priv.h

Re: [Mesa-dev] [PATCH] mesa: add APPLE_vertex_array_object stubs

WTF? I gave review feedback on IRC, and you said you were going to send a different patch... yet this patch landed. If you're not going to take review feedback, why do you ask for it? On 05/18/2017 07:50 PM, Timothy Arceri wrote: > APPLE_vertex_array_object support was removed in 7927d0378fc7. >

Re: [Mesa-dev] [PATCH 2/9] util: Add tests for the string buffer

New tests should use gtest. Other tests can't be made to produce XML output that can be processed by Jenkins. On 05/21/2017 01:49 PM, Thomas Helland wrote: > More tests could probably be added, but this should cover > concatenation, resizing, clearing, formatted printing, > and checking the lengt

Re: [Mesa-dev] [PATCH v2] drirc: Add allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition

Pushed, thanks. Marek On Sun, May 21, 2017 at 11:46 PM, Benedikt Schemmer wrote: > From: Benedikt Schemmer > > This patch sets the allow_glsl_builtin_variable_redeclaration for Dead > Island Riptide Definitive Edition. > > Tested with Mesa git as of today and Dying Light, Dead Island Definitive

[Mesa-dev] [PATCH 1/7] egl/drm: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov The current __DRI_DRI2 imples __DRI2_FLUSH. At the same time, one can use __DRI_IMAGE_DRIVER alongside the latter, so the current check is confusing at best. Check for what we use. v2: Split out from whitespace changes Reviewed-by: Chad Versace (v1) Signed-off-by: Emil Veli

[Mesa-dev] [PATCH 1.5/7] egl/drm: flatten codeflow

From: Emil Velikov Rework the code to return early and drop an indentation level. No functional change, yet it should be easier to read. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 39 +++-- 1 file changed, 20 insertions(+), 19 deletion

[Mesa-dev] [PATCH 3.5/7] egl/x11: flatten codeflow

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c index 7ca2611b110..becf00547e6 100644 --- a/src/

[Mesa-dev] [PATCH 2/7] egl/x11: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov Analogous to earlier commit. Note that the dri2_x11_post_sub_buffer and dri2_x11_swap_buffers_region paths already implicitly require __DRI2_FLUSH. The corresponding extensions (NV_post_sub_buffer and NOK_swap_region) are enabled only with DRI2. v2: Split cosmetic changes int

Re: [Mesa-dev] [PATCH 2/7] egl/x11: check for dri2_dpy->flush before using the flush extension

On 16 May 2017 at 18:32, Chad Versace wrote: > On Mon 15 May 2017, Emil Velikov wrote: >> From: Emil Velikov >> >> Analogous to previous commit. >> >> Signed-off-by: Emil Velikov >> --- > >> If people prefer I can split the whitespace/indent changes in >> this/previous path from the rest. Don't

Re: [Mesa-dev] [PATCH v3 01/15] st/dri: refactor multi-planar YUV import path

Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam: > From: Varad Gautam > > we currently ignore the plane count when converting from > __DRI_IMAGE_FORMAT* tokens to __DRI_IMAGE_FOURCC* for multiplanar > images, and only return the first plane's simplified fourcc. > > this adds a four

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

Am Dienstag, den 16.05.2017, 21:31 +0200 schrieb Christian Gmeiner: > Hi Wladimir. > > I started working on this topic last week and thought some time on how > to add those ext texture formats in a clean and nice way. I come up > with this patches: > > https://github.com/austriancoder/mesa/commit

[Mesa-dev] [Bug 100988] glXGetCurrentDisplay() no longer works for FakeGLX contexts?

https://bugs.freedesktop.org/show_bug.cgi?id=100988 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |bri...@vmware.com |org

Re: [Mesa-dev] [PATCH 0/9][RFC] GLSL preprocessor/parser improvements

2017-05-22 3:41 GMT+02:00 Timothy Arceri : > I suspect you forgot to test with a debug build, there is issues with the > string buffer changes somewhere. > > ralloc.c:203: reralloc_size: Assertion `ralloc_parent(ptr) == ctx' failed. > > #0 0x770eb91f in raise () from /lib64/libc.so.6 > #1

Re: [Mesa-dev] [PATCH 11/13] egl: refactor dri2_create_screen() into three separate functions

On Thu, May 11, 2017 at 1:57 PM, Emil Velikov wrote: > Split the create_screen into: > - create screen > - setup/bind extensions > - setup screen > > This will allow us to reuse the latter two on egl/drm. Said platform > does create its own screen and attempts to reinvent the later two > functi

Re: [Mesa-dev] How does FakeGLX work since Mesa 10?

On 05/09/2017 12:07 PM, Tom Hudson wrote: I'm trying to upgrade a Mesa 10 installation to Mesa 17. There have been plenty of changes, but only one breakage that's left me perplexed. https://cgit.freedesktop.org/mesa/mesa/commit/?id=c00b250c8061d042d9905e61b9077462ee91008b In this CL, Mesa stopp

Re: [Mesa-dev] [PATCH 00/13] egl: gbm: Misc cleanups and robustness patches

On Thu, May 11, 2017 at 1:57 PM, Emil Velikov wrote: > Hi all, > > I was around the EGL/GBM codebase and I've noticed that we do a few > things, rather badly: > - we have unnessesary layer of abstraction in GBM like the following > gbm_dri_foo -> gbm_drm_foo -> gbm_foo > - the teardown path of p

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli wrote: > On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote: >> These declarations will help the code start compiling >> once we wire up the makefiles for gen10. Later patches >> will start using these functions for gen10. >> >> Signed-o

Re: [Mesa-dev] Mesa 17.1.1 release candidate

> > The candidate for the Mesa 17.1.1 is now available. Excellent! >From build perspective - SWR now ships it's final generated header, thus > Python/mako is no longer required. > Just what I was looking for, thanks! Is a source tarball available that I can test the build with? I would just u

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

Reviewed-by: Roland Scheidegger Thanks! Am 22.05.2017 um 19:06 schrieb Jose Fonseca: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change since we were already ignoring > S3TC failures there. > --- > src/gallium/tests/unit/u_format_

[Mesa-dev] [PATCH 4/6] glsl: Prehash in constant var pass to avoid hashing twice

Should help us reduce some hash table overhead. V2: Fix whitespace error --- src/compiler/glsl/opt_constant_variable.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_constant_variable.cpp b/src/compiler/glsl/opt_constant_variable.cpp index 1c06f

[Mesa-dev] [PATCH 5/6] glsl: Prehash to avoid computing the hash twice

Copy propagation elements is a large user of the hash table. We should not be computing the hash twice when we don't have to. --- src/compiler/glsl/opt_copy_propagation_elements.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_copy_propagation_el

[Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

_mesa_hash_table_search is one of our hottest function according to perf. Callgrind shows the refcounting as one of the major users of the searching functions. We can reduce the pain by prehashing, so that we avoid hashing two times when inserting in the table. On a short shader-db run (with valid

[Mesa-dev] [PATCH 0/6] Prehash all the things

While this doesn't prehash all the things, it does switch quite a lot of places from doing a search and then a subsequent insert to first hash the key, and then use this hash when searching / inserting. While our new pointer hashing function remedied much of our overhead hashing pointers, there is

[Mesa-dev] [PATCH 3/6] glsl: Prehash in constant propagation

This should reduce overhead since we can hash only once. --- src/compiler/glsl/opt_constant_propagation.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/glsl/opt_constant_propagation.cpp index 4039512097.

[Mesa-dev] [PATCH 2/6] nir: Prehash in instr_set to avoid hashing twice

This should prove benefitial in the common case of inserting and not rewriting anything. V2: Use hash_instr directly instead of going through the function pointer embedded in the set --- src/compiler/nir/nir_instr_set.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 6/6] util: Avoid computing hash twice in string_to_uint_map

This is not a hot path, but when we have the functionality we should take advantage of it. --- src/util/string_to_uint_map.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/string_to_uint_map.h b/src/util/string_to_uint_map.h index e0533ec6ea..3248696e88 10064

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

On Mon, May 22, 2017 at 1:07 PM Jose Fonseca wrote: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change s/does/doesn't/ With that commit message fix: Reviewed-by: Rhys Kidd since we were already ignoring > S3TC failures there.

Re: [Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

The crash with STALKER: CoC is fixed with this patch. Tested-by: Edmondo Tommasina Thanks edmondo On Mon, May 22, 2017 at 12:22 AM, Axel Davy wrote: > A few cleanups and in particular initializing properly > the new pipe_draw_info fields. > This should fix the regression caused by > 330d0607e

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: > Hi all, > > I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing > the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine > SPIR-V -> NIR -> LLVM compiler pipeline in radv, so I looked into re-using

[Mesa-dev] [v2 6/7] i965/gen4: Refactor depth/stencil rebase

Effectively there is the same code twice, once for depth and again for stencil. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 243 - 1 file changed, 63 insertions(+), 180 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_

[Mesa-dev] [v2 2/7] i965/gen4: Remove non-existing stencil and hiz buffer setup

Separate stencil and hiz are only enabled for gen6+. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 6 +- src/mesa/drivers/dri/i965/brw_misc_state.c | 120 +++-- 2 files changed, 14 insertions(+), 112 deletions(-) diff --git a/src/mesa

[Mesa-dev] [v2 1/7] i965/gen4: Set depth offset when there is stencil attachment only

Current version fails to set depthstencil.depth_offset when there is only stencil attachment (it does set the intra tile offsets though). Fixes piglits: g45,g965,ilk: depthstencil-render-miplevels 1024 s=z24_s8 g45,ilk:depthstencil-render-miplevels 273 s=z24_s8 CC: mesa-sta...@lists.fre

[Mesa-dev] [v2 7/7] i965/gen4: Tell briefly how workaround depth gets reconciled

CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index 85050ce..fe021b0 100644 --- a/src/mesa/driv

[Mesa-dev] [v2 3/7] i965/gen4: Remove redundant check for depth when rebasing stencil

In case of gen < 6 stencil (if present) is always combined with depth. Both stencil and depth attachments point to the same physical surface. Alignment workaround starts by considering depth and updates stencil accordingly. Current logic continues with stencil and in vain considers the case where d

[Mesa-dev] [v2 4/7] i965/gen4: Simplify depth/stencil invalidate check

There is no separate stencil on gen < 6. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c i

[Mesa-dev] [v2 5/7] i965: Drop depth/stencil miptree pointers in alignment workaround

In brw_workaround_depthstencil_alignment() corresponding renderbuffers are always set to refer to the same temp miptrees. There is no need to carry them in context. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 3 --- src/mesa/drivers/dri/i965/brw_misc_state.c

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On 05/22/2017 12:02 PM, Marek Olšák wrote: > On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: >> Hi all, >> >> I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing >> the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine >> SPIR-V -> NIR -> LLVM com

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

On 05/22/2017 11:55 AM, Thomas Helland wrote: > _mesa_hash_table_search is one of our hottest function according to perf. > Callgrind shows the refcounting as one of the major users of the > searching functions. We can reduce the pain by prehashing, so that we > avoid hashing two times when inserti

  1   2   >