Re: [Mesa-dev] [PATCH 1/3] egl/android: use the image_driver alongside the image_loader

On 05/12/2017 01:22 AM, Emil Velikov wrote: From: Emil Velikov They are meant to be used together. Otherwise we'll need workarounds like egl/wayland. Namely register an image_loader_extension even thought we should be using only DRI2. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/p

[Mesa-dev] [PATCH 3/4] radeonsi: rename tcs_tes_uses_prim_id for clarity

From: Nicolai Hähnle What we care about is whether PrimID is used while tessellation is enabled; whether it's used in TCS/TES or further down the pipeline is irrelevant. --- src/gallium/drivers/radeonsi/si_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state_draw.c| 4 ++-- src/ga

[Mesa-dev] [PATCH 2/4] radeonsi: fix gl_PrimitiveIDIn in geometry shader when using tessellation

From: Nicolai Hähnle This builds on commit 0549ea15ec38 ("radeonsi: fix primitive ID in fragment shader when using tessellation"). Fixes piglit arb_tessellation_shader/execution/gs-primitiveid-instanced.shader_test Cc: 17.1 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 ++ 1 file ch

[Mesa-dev] [PATCH 0/4] ac, radeonsi: one more tess/primid bug fix and some misc stuff

Hi all, Random small patches plus one bug fix that I could've sworn I made earlier, but maybe it got lost during a rebase or I'm just imagining things. Please review! Thanks, Nicolai -- src/amd/common/ac_debug.c | 8 +++- src/gallium/drivers/radeonsi/si_debug.c

[Mesa-dev] [PATCH 4/4] radeonsi: silence a Coverity warning

From: Nicolai Hähnle Coverity doesn't understand that we'll never pass non-NULL for vertex shaders. This is a bit lame, actually. A straightforward cross-procedural analysis limited to this source file should be enough to prove that there's no NULL-pointer dereference. Oh well. CID: 1405999 ---

[Mesa-dev] [PATCH 1/4] ac/debug: handle index field in SET_*_REG correctly

From: Nicolai Hähnle --- src/amd/common/ac_debug.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_debug.c b/src/amd/common/ac_debug.c index 9d051f9..a8f81bf 100644 --- a/src/amd/common/ac_debug.c +++ b/src/amd/common/ac_debug.c @@ -125,23 +125,29 @@

[Mesa-dev] [PATCH 6/9] glsl: remove redundant record_compare check when linking globals

From: Nicolai Hähnle Unnamed struct types are now equal across stages based on the fields they contain, so this additional check has become unnecessary. The check was originally introduced in commit 955c93dc089f ("glsl: Match unnamed record types across stages.") --- src/compiler/glsl/linker.cp

[Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

Hi all, This series aims to simplify how we handle unnamed struct types and fix some bugs on the way. Some of the patches should be uncontroversial, and all of them align with my understanding of the GLSL spec, but the spec isn't exactly explicit, so... At a high level, the series changes two thi

[Mesa-dev] [PATCH 4/9] glsl: give all unnamed structs the same name

From: Nicolai Hähnle As a result, unnamed structs defined in different places of the program are considered the same types if they have the same fields in the same order. This will simplify matching of global variables whose type is an unnamed struct. It also fixes a memory leak when the same s

[Mesa-dev] [PATCH 1/9] glsl: fix a race condition when inserting new types

From: Nicolai Hähnle By splitting glsl_type::mutex into two, we can avoid dropping the hash mutex while creating the new type instance (e.g. struct/record, interface). This fixes a time-of-check/time-of-use race where two threads would simultaneously attempt to create the same type but end up wi

[Mesa-dev] [PATCH 7/9] glsl: simplify varying matching

From: Nicolai Hähnle Unnamed struct types are now equal if they have the same field. --- src/compiler/glsl/link_varyings.cpp | 41 - 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_va

[Mesa-dev] [PATCH 3/9] glsl: do not add unnamed struct types to the symbol table

From: Nicolai Hähnle We removed the need for lookups, and we will assign them all the same name in the future. --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 2221c5

[Mesa-dev] [PATCH 5/9] glsl: stop considering unnamed and named structures equal

From: Nicolai Hähnle Previously, if an unnamed and a named struct contained the same fields, they were considered the same type during linking of globals. The discussion around commit e018ea81bf58 ("glsl: Structures must have same name to be considered same type.") doesn't seem to have considere

[Mesa-dev] [PATCH 9/9] glsl: simplify an assertion in lower_ubo_reference

From: Nicolai Hähnle Struct types are now equal when they're structurally equal. --- src/compiler/glsl/lower_ubo_reference.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_ubo_reference.cpp b/src/compiler/glsl/lower_ubo_reference.cpp index 7118845.

[Mesa-dev] [PATCH 8/9] glsl: simplify validate_intrastage_arrays

From: Nicolai Hähnle Struct types are now equal when they are structurally equal. --- src/compiler/glsl/linker.cpp | 8 1 file changed, 8 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 20465db..adfa3b7 100644 --- a/src/compiler/glsl/linker.c

[Mesa-dev] [PATCH 2/9] glsl: do not lookup struct types by typename

From: Nicolai Hähnle This changes the logic during the conversion of the declaration list struct S { ... } v; from AST to IR, but should not change the end result. When assigning the type of v, instead of looking `S' up in the symbol table, we read the type from the member variable

Re: [Mesa-dev] [PATCH] mesa: don't crash in KHR_no_error uniform variants when location == -1

On 05/14/2017 01:20 PM, Timothy Arceri wrote: On 14/05/17 01:39, Samuel Pitoiset wrote: Mmh, this can still crash if location is < -1 or greater than the number of uniforms. How about: Sorry my commit message went missing it should have something like: "-1 is allowed by the spec so that ina

Re: [Mesa-dev] [PATCH 1/5] mesa: replace _mesa_problem() with assert() in hash table

On 05/09/2017 05:04 AM, Timothy Arceri wrote: There should be no way the OpenGL test suites don't hit the assert() should we do something to cause this code path to be taken. --- src/mesa/main/hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/hash.

Re: [Mesa-dev] [PATCH 4/5] mesa: replace _mesa_problem() with unreachable() in mipmap.c

On 05/09/2017 05:04 AM, Timothy Arceri wrote: --- src/mesa/main/mipmap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 8745dd9..fc36d40 100644 --- a/src/mesa/main/mipmap.c +++ b/src/mesa/main/mipmap.c @@ -750,

Re: [Mesa-dev] [RFC PATCH 02/17] auxiliary: Implement a linker for SPIR-V binaries

This version tries to link builtins, as they are marked as imported, but nothing exports them, resulting in the linker failing and throwing an error. As builtins are target dependent, it is best to let the driver handles those cases. I changed the code locally to also track which IDs are builtins,

Re: [Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

I'm personally fine with this. I have never hit this _mesa_problem() path, or maybe one time but it was me doing something dumb. Except a comment on patch 1, this series is: Reviewed-by: Samuel Pitoiset On 05/09/2017 05:04 AM, Timothy Arceri wrote: There is still more that can be removed I j

Re: [Mesa-dev] [PATCH v2 0/3] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

v2 of this series is: Reviewed-by: Samuel Pitoiset Thanks! On 05/15/2017 07:47 AM, John Brooks wrote: I have made the requested changes. I've also added a Reviewed-by with permission from funfunctor in #radeon (2017-05-14 EDT): [19:31:37] Frogging101: ping [19:32:37] Frogging101:

Re: [Mesa-dev] [PATCH 1/6] mesa/main: fix indentation in _mesa_get_uniform()

On Fri, 2017-05-12 at 10:31 +0200, Nicolai Hähnle wrote: > On 11.05.2017 13:10, Iago Toral Quiroga wrote: > > --- > >  src/mesa/main/uniform_query.cpp | 194 -- > > -- > >  1 file changed, 99 insertions(+), 95 deletions(-) > > > > diff --git a/src/mesa/main/unifo

Re: [Mesa-dev] [PATCH 4/6] mesa/main: add IROUNDD64() helper

On Fri, 2017-05-12 at 10:33 +0200, Nicolai Hähnle wrote: > On 11.05.2017 13:10, Iago Toral Quiroga wrote: > > --- > >  src/mesa/main/imports.h | 7 +++ > >  1 file changed, 7 insertions(+) > > > > diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h > > index ef7c378..416c59b 100644 >

[Mesa-dev] [PATCH 0/4] Various cosmetic patches

Hi, I'm not really a fan of such changes but it improves readability and my ARB_bindless_texture work is based on these patches. Please review, Thanks! Samuel Pitoiset (4): mesa: fix indentation in _mesa_associate_uniform_storage() mesa: fix indentation in _mesa_uniform() mesa: unify _mesa

[Mesa-dev] [PATCH 1/4] mesa: fix indentation in _mesa_associate_uniform_storage()

Signed-off-by: Samuel Pitoiset --- src/mesa/program/ir_to_mesa.cpp | 101 +++- 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 05b042b4e9..0e8623c3f3 100644 --- a/src/mesa/p

[Mesa-dev] [PATCH 4/4] glsl: simplify link_assign_uniform_storage() a bit

Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniforms.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index c5db1d62cb..b11739ce78 100644 --- a/src/compiler/glsl/link_

[Mesa-dev] [PATCH 2/4] mesa: fix indentation in _mesa_uniform()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 0e02a764a9..586b92d2eb 100644 --- a/src/mesa/main/

[Mesa-dev] [PATCH 3/4] mesa: unify _mesa_uniform() for image uniforms

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 586b92d2eb..6aba8ace0e 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/s

[Mesa-dev] [PATCH shader-db] run: set GALLIUM_THREAD=0

From: Marek Olšák without this, I get only 30k shaders instead of 48k in the report. --- run.c | 1 + 1 file changed, 1 insertion(+) diff --git a/run.c b/run.c index 12a78c6..f9bc86a 100644 --- a/run.c +++ b/run.c @@ -389,20 +389,21 @@ main(int argc, char **argv) print_usage(argv[0]);

Re: [Mesa-dev] [PATCH 2/2] bin/get-fixes-pick-list.sh: better identify multiple "fixes:" tags

On 13 May 2017 at 01:11, Andres Gomez wrote: > We were not considering as multiple fixes lines with: > Fixes: $sha_1, Fixes: $sha_2 > > Now, we split the lines so we will consider them individually, as in: > Fixes: $sha_1, > Fixes: $sha_2 > > Additionally, we try to get the SHA from split lines so

Re: [Mesa-dev] [RFC] st/dri: implement createImageWithModifiers

Hi Lucas, On Fri, May 12, 2017 at 4:22 PM, Lucas Stach wrote: > Hi Varad, > > Am Freitag, den 12.05.2017, 15:11 +0530 schrieb Varad Gautam: >> gallium doesn't have a way to pass modifiers to the driver when creating >> resources. we require this to support >> dri2ImageExtension->createImageWithMo

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 Emil Velikov changed: What|Removed |Added Resolution|--- |NOTABUG Status|REOPENED

[Mesa-dev] [AppVeyor] mesa master #4361 failed

Build mesa 4361 failed Commit 7622181cad by Marek Olšák on 2/27/2017 9:26 PM: radeonsi/gfx9: add support for Raven\n\nCc: 17.1 \nReviewed-by: Alex Deucher \nReviewed-by: Nicolai Hähnle Configure your notification preferences

[Mesa-dev] [AppVeyor] mesa master #4362 completed

Build mesa 4362 completed Commit 1c8f7d3be6 by Marek Olšák on 3/2/2017 12:28 AM: radeonsi: enable threaded_context\n\nReviewed-by: Nicolai Hähnle \nTested-by: Dieter Nützel Configure your notification preferences

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

On 13 May 2017 at 20:32, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Note that this is not meant for master, because master doesn't need this fix > anymore. > A tad silly question: is that really the case? AFAICT there's some related changes with commit 156e81f305b although the patch seem a

Re: [Mesa-dev] [PATCH 5/6] mesa: Add conversion from double to uint64/int64 in GetUniform*i64v()

On Fri, 2017-05-12 at 10:36 +0200, Nicolai Hähnle wrote: > On 11.05.2017 13:10, Iago Toral Quiroga wrote: > > --- > >  src/mesa/main/uniform_query.cpp | 14 ++ > >  1 file changed, 14 insertions(+) > > > > diff --git a/src/mesa/main/uniform_query.cpp > > b/src/mesa/main/uniform_query.cp

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 Paviluf changed: What|Removed |Added CC||jeremy9...@gmail.com -- You are receiving thi

Re: [Mesa-dev] [PATCH 02/24] ac/radeonsi: move amdgpu_addr_create to ac_surface

On 14 May 2017 at 22:46, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/amd/Makefile.common.am | 2 + > src/amd/Makefile.sources | 4 + > src/amd/common/ac_surface.c| 198 > + > src/amd/common/

[Mesa-dev] i965/gen6: Switch stencil surfaces to back-to-back layout

This is a re-spin of part of earlier i965-isl work concentrating only on gen6 stencil surfaces. 1) Instead of introducing the layout in ISL patches 5, 6 and 15 simply add the concept locally to i965. Jason expected to see proper layout in ISL - patch 15 adds one but to i965. 2) Instead of a

[Mesa-dev] [v3 01/19] i965/miptree: Refactor mapping table alloc

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 +-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 54ef1ba..f024798

[Mesa-dev] [v3 02/19] i965: Add helper for converting isl tiling to bufmgr tiling

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_blit.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_blit.h b/src/mesa/drivers/dri/i965/intel_blit.h index 2604417..5e4d1f5 100644 --- a/src/mesa/drivers/dri/i965/intel_blit.h

[Mesa-dev] [v3 07/19] i965/miptree: Add isl surface

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index d23ff66..9df0cc3 100644 --- a/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [v3 08/19] i965: Prepare up/downsampling for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46 ++- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index f024798..5f911b9

[Mesa-dev] [v3 05/19] i965/gen6: Add back-to-back surface minify

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_tex_layout.c| 25 + src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex

[Mesa-dev] [v3 03/19] intel/isl: Add extent4d minify

Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl_priv.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/intel/isl/isl_priv.h b/src/intel/isl/isl_priv.h index 3c4cc1e..5ccb860 100644 --- a/src/intel/isl/isl_priv.h +++ b/src/intel/isl/isl_priv.h @@ -151,6 +151,21 @@ is

[Mesa-dev] [v3 06/19] i965/gen6: Add back-to-back size and offset calculators

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_tex_layout.c| 52 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 11 ++ 2 files changed, 63 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/br

[Mesa-dev] [v3 11/19] i965: Prepare framebuffer validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_fbo.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index 21e8e86..252821f 100644 --- a/src/m

[Mesa-dev] [v3 10/19] i965: Prepare slice validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index 9df0cc3..5269a5e 100644 --- a/s

[Mesa-dev] [v3 14/19] i965: Prepare slice copy for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 1ffb674..4804d25 100644 --- a/src/mesa

[Mesa-dev] [v3 04/19] intel/isl/gen6: Allow arrayed stencil

Nothing prevents arrayed stencil surfaces even though hardware doesn't support mipmapping. Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351..dbaf22e 100644 --- a/src/intel/isl/isl.c

[Mesa-dev] [v3 17/19] i965/gen6: Add back-to-back mapping support

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 32 +++ 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 06c05f3..df5a954

[Mesa-dev] [v3 19/19] i965/gen6: Represent mipmapped stencil with isl_surf array

This is only compile tested!! Alternatively one could keep gen6_back_to_back_minify() and gen6_back_to_back_offset() (which in turn relies on gen6_back_to_back_total_height()) and make the loop in make_gen6_stencil_surface() a little simpler. I don't personally like this too much: 1) Precomputed

[Mesa-dev] [v3 13/19] i965: Prepare texture validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_validate.c b/src/mesa/drivers/dri/i965/intel_tex_validate.c index 08cf3bf..d606922 100644 --- a/src/m

[Mesa-dev] [v3 12/19] i965/tex: Prepare image update for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_tex_image.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index 7208d8e..3a26ff3 100644 --- a/s

[Mesa-dev] [v3 15/19] i965/miptree: Add option to resolve offsets using isl_surf

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 20 src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 21 + 2 files changed, 41 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/

[Mesa-dev] [v3 16/19] i965: Add isl based miptree creator

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 9f7c7fc..06c05f3 100644 --- a/src

[Mesa-dev] [v3 09/19] i965: Prepare image validation for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 5f911b9..1ffb674 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [v3 18/19] i965/gen6: Use back-to-back layout for stencil surfaces

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 21 + src/mesa/drivers/dri/i965/gen6_depth_state.c | 26 +++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 34 ++- 3 files changed, 58 insertions(+), 23

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

On Mon, May 15, 2017 at 1:11 PM, Emil Velikov wrote: > On 13 May 2017 at 20:32, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Note that this is not meant for master, because master doesn't need this fix >> anymore. >> > A tad silly question: is that really the case? > AFAICT there's some

Re: [Mesa-dev] [PATCH 1/4] mesa: fix indentation in _mesa_associate_uniform_storage()

Hello Samuel, With the small fix below, the series is: Reviewed-by: Elie Tournier On 15 May 2017 at 11:55, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/program/ir_to_mesa.cpp | 101 > +++- > 1 file changed, 49 insertions(+), 52

Re: [Mesa-dev] [PATCH 4/4] radeonsi: silence a Coverity warning

For the series: Reviewed-by: Marek Olšák Marek On Mon, May 15, 2017 at 11:18 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Coverity doesn't understand that we'll never pass non-NULL for vertex > shaders. > > This is a bit lame, actually. A straightforward cross-procedural analysis > li

Re: [Mesa-dev] [PATCH 02/24] ac/radeonsi: move amdgpu_addr_create to ac_surface

On 15.05.2017 14:01, Emil Velikov wrote: On 14 May 2017 at 22:46, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/amd/Makefile.common.am | 2 + src/amd/Makefile.sources | 4 + src/amd/common/ac_surface.c| 198 ++

Re: [Mesa-dev] [PATCH 12/24] ac: add missing extern "C" guards

For patches 1-12: Reviewed-by: Marek Olšák Marek On Sun, May 14, 2017 at 11:46 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/amd/common/ac_gpu_info.h | 8 > src/amd/common/ac_surface.h | 8 > 2 files changed, 16 insertions(+) > > diff --git a/src/amd/commo

Re: [Mesa-dev] [PATCH v3 7/9] mesa: add *FramebufferTexture() support to frame_buffer_texture helper

On 11.05.2017 14:29, Timothy Arceri wrote: --- src/mesa/main/fbobject.c | 138 +-- 1 file changed, 38 insertions(+), 100 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8e25dfa..0ff31ec 100644 --- a/src/mesa/main/fb

Re: [Mesa-dev] [PATCH v3 9/9] mesa: add KHR_no_error support for NamedFramebufferTexture

Thanks for the update, I think the series is much clearer now. At some point... On 11.05.2017 14:29, Timothy Arceri wrote: V3: use frame_buffer_texture() helper --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/fbobject.c | 8 src/mesa/mai

Re: [Mesa-dev] [PATCH 2/7] mesa: add compressed_tex_sub_image() helper

On 12.05.2017 06:12, Timothy Arceri wrote: This reduces duplication between the dsa and non-dsa function and will also be used in the following commit to add KHR_no_error support. --- src/mesa/main/teximage.c | 82 ++-- 1 file changed, 38 insertions(+)

Re: [Mesa-dev] [PATCH 7/7] mesa: add KHR_no_error support for glCompressedTex*SubImage3D()

Patches 1, 3-7: Reviewed-by: Nicolai Hähnle On 12.05.2017 06:13, Timothy Arceri wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 3 ++- src/mesa/main/teximage.c | 28 +- src/mesa

Re: [Mesa-dev] [PATCH] Android: r600: fix build when LLVM is disabled

On 12.05.2017 18:55, Rob Herring wrote: There's still an error after my recent clean-up if LLVM is not patched to enable AMDGPU target: external/mesa3d/src/amd/common/ac_llvm_util.c:38:2: error: implicit declaration of function 'LLVMInitializeAMDGPUTargetInfo' is invalid in C99 [-Werror,-Wimpl

Re: [Mesa-dev] [PATCH 1/2] Clang doesn't have 64bit __atomic* builtins on i386

On 13.05.2017 11:20, Jan Beich wrote: glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function `disk_cache_remove': disk_cache.c:(.text+0x763): undefined reference to `__atomic_fetch_add_8' glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function `cache_put': disk_cache.

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

On 15 May 2017 at 13:25, Marek Olšák wrote: > On Mon, May 15, 2017 at 1:11 PM, Emil Velikov > wrote: >> On 13 May 2017 at 20:32, Marek Olšák wrote: >>> Reviewed-by: Marek Olšák >>> >>> Note that this is not meant for master, because master doesn't need this fix >>> anymore. >>> >> A tad silly

Re: [Mesa-dev] [PATCH 17/17] mesa: add KHR_no_error support for glDispatchCompute*()

For the series: Reviewed-by: Nicolai Hähnle On 15.05.2017 08:19, Timothy Arceri wrote: --- src/mapi/glapi/gen/ARB_compute_shader.xml | 4 ++-- .../glapi/gen/ARB_compute_variable_group_size.xml | 2 +- src/mesa/main/compute.c| 26 ++

Re: [Mesa-dev] [PATCH shader-db] run: set GALLIUM_THREAD=0

On 15.05.2017 12:55, Marek Olšák wrote: From: Marek Olšák without this, I get only 30k shaders instead of 48k in the report. Reviewed-by: Nicolai Hähnle --- run.c | 1 + 1 file changed, 1 insertion(+) diff --git a/run.c b/run.c index 12a78c6..f9bc86a 100644 --- a/run.c +++ b/run.c @@ -3

Re: [Mesa-dev] [PATCH v2 21/27] st/xvmc: add DRI3 support

On 8 May 2017 at 00:09, Ilia Mirkin wrote: > Tested-by: Ilia Mirkin > > Seems to work with a NV44A (with some hacks to deal with its > non-pcie/agp-ness, but that's entirely separate). The "background" > area when entering full-screen mode appears to not get cleared with > dri3 like it does with

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

On Mon, May 15, 2017 at 4:31 PM, Emil Velikov wrote: > On 15 May 2017 at 13:25, Marek Olšák wrote: >> On Mon, May 15, 2017 at 1:11 PM, Emil Velikov >> wrote: >>> On 13 May 2017 at 20:32, Marek Olšák wrote: Reviewed-by: Marek Olšák Note that this is not meant for master, because

[Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION

From: Marek Olšák for skipping mapped-buffer checking in every GL draw call --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c

[Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

From: Marek Olšák Before: DrawElements (16 VBOs) w/ no state change: 4.34 million/s After: DrawElements (16 VBOs) w/ no state change: 8.80 million/s This inefficiency was uncovered by Timothy Arceri's no_error work. --- src/mesa/main/api_validate.c | 15 ++- 1 file changed, 14 inse

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

On 8 May 2017 at 01:35, Eric Engestrom wrote: > On Thursday, 2017-05-04 17:29:52 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Building EGL/Vulkan/other without X11, while GLX is enabled is confusing >> and misleading. In practise anyone aiming at the former will also >> disable GLX. >>

[Mesa-dev] [PATCH 2/3] mesa: add gl_constants::AllowMappedBuffersDuringExecution

From: Marek Olšák for skipping mapped-buffer checking in every GL draw call --- src/mesa/main/mtypes.h | 3 +++ src/mesa/state_tracker/st_extensions.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 28d3d948..efc6920 1

Re: [Mesa-dev] [PATCH 5/6] mesa: Add conversion from double to uint64/int64 in GetUniform*i64v()

On 15.05.2017 13:29, Iago Toral wrote: On Fri, 2017-05-12 at 10:36 +0200, Nicolai Hähnle wrote: On 11.05.2017 13:10, Iago Toral Quiroga wrote: --- src/mesa/main/uniform_query.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main

Re: [Mesa-dev] [PATCH v2 13/27] st/va: move variable declaration to where its used

On 5 May 2017 at 12:44, Christian König wrote: > Am 04.05.2017 um 18:33 schrieb Emil Velikov: >> >> From: Emil Velikov >> >> ... and make it const, since we shouldn't tinker with it. >> >> Signed-off-by: Emil Velikov >> Reviewed-by: Nayan Deshmukh > > > Patches #13 - #17 are Reviewed-by: Christ

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

On 15.05.2017 16:41, Marek Olšák wrote: From: Marek Olšák Before: DrawElements (16 VBOs) w/ no state change: 4.34 million/s After: DrawElements (16 VBOs) w/ no state change: 8.80 million/s This inefficiency was uncovered by Timothy Arceri's no_error work. Nice one! Series is: Reviewed-by:

[Mesa-dev] [PATCH] i965/blorp: Do and end-of-pipe sync on both sides of fast-clear ops

We've discovered in the Vulkan driver that simply doing the end-of-pipe sync afterwards is insufficient. The specific requirement stated in the PRM is that you have to do one every time you transition between the tree modes of "clear", "render", and "resolve". This is GL, so we could track it but

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec, but the spec isn't >

[Mesa-dev] [PATCH 1/6] vulkan: Update registry and headers to 1.0.49

--- include/vulkan/vulkan.h| 111 -- src/vulkan/registry/vk.xml | 167 + 2 files changed, 262 insertions(+), 16 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index ef0c246..51e5e9e 100644 ---

[Mesa-dev] [PATCH 4/6] vulkan/wsi/x11: Add support for VK_KHR_get_surface_capabilities2

--- src/vulkan/wsi/wsi_common_x11.c | 32 1 file changed, 32 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 3580194..5be56f1 100644 --- a/src/vulkan/wsi/wsi_common_x11.c +++ b/src/vulkan/wsi/wsi_common_x11.c @@ -

[Mesa-dev] [PATCH 5/6] vulkan/wsi/wayland: Add support for VK_KHR_get_surface_capabilities2

--- src/vulkan/wsi/wsi_common_wayland.c | 38 + 1 file changed, 38 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index 5c72c8a..cb6dd79 100644 --- a/src/vulkan/wsi/wsi_common_wayland.c +++ b/src/vulkan/wsi

[Mesa-dev] [PATCH 2/6] vulkan/wsi: Use vk_outarray for surface_get_formats

--- src/vulkan/wsi/wsi_common_wayland.c | 28 +--- src/vulkan/wsi/wsi_common_x11.c | 23 --- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index 5613283..5c

[Mesa-dev] [PATCH 3/6] vulkan/wsi: Ad get_capabilities2 and get_formats2d interface pointers

--- src/vulkan/wsi/wsi_common.h | 8 1 file changed, 8 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 5e77518..8aee9c7 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -87,10 +87,18 @@ struct wsi_interface {

[Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_get_surface_capabilities2

--- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_wsi.c | 27 +++ 3 files changed, 32 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 35e40

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

On Monday, 2017-05-15 15:41:44 +0100, Emil Velikov wrote: > On 8 May 2017 at 01:35, Eric Engestrom wrote: > > I don't seem to have received patches 12-27 of this series though? > > > Git send-email tripped on a malformed email in 12. The rest of the > series is was sent shortly after the first 11

Re: [Mesa-dev] [PATCH v2] egl: fix android logger compilation

On 12 May 2017 at 07:32, Tapani Pälli wrote: > 1ce5853 broken compilation since LOG_ERROR is not defined and also > macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]') > > v2: append 'ANDROID' to egl2alog table and use LOG_PRI > (suggested by Chih-Wei Huang) > > Fixes:

Re: [Mesa-dev] [PATCH] i965/blorp: Do and end-of-pipe sync on both sides of fast-clear ops

On Mon, May 15, 2017 at 07:55:46AM -0700, Jason Ekstrand wrote: > We've discovered in the Vulkan driver that simply doing the end-of-pipe > sync afterwards is insufficient. The specific requirement stated in the > PRM is that you have to do one every time you transition between the > tree modes of

[Mesa-dev] [PATCH 1/3] egl: error out on eglCreateWaylandBufferFromImageWL

From: Emil Velikov Currently f one does the silly thing by probing the entry point w/o checking the extension they will attempt to use the extension even though it cannot work. That is due our of of an assert which gets removed in release builds. Simply error out if the extension is not enabled.

[Mesa-dev] [PATCH 3/3] egl: annotate dri2_egl_display_vtbl as const data

From: Emil Velikov With the final place that modifies the vtbl removed as of last commit we can annotate the symbols accordingly. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 +- src/egl/drivers/dri2/platform_drm.c | 2 +- src/egl/drivers/dri2/platfor

[Mesa-dev] [PATCH 2/3] egl/wayland: don't modify the vtbl if an extension is not available

From: Emil Velikov With previous commit we'll error out should one be using the extension when it's not available. Thus we no longer need to modify the vtbl. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) di

[Mesa-dev] [PATCH 1/7] egl/drm: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov The current __DRI_DRI2 imples __DRI2_FLUSH. At the same time, one can use __DRI_IMAGE_DRIVER alongside the latter, so the current check is confusing at best. Check for what we use. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 41 +++-

[Mesa-dev] [PATCH 3/7] egl/android: use the image_driver alongside the image_loader

From: Emil Velikov They are meant to be used together. Otherwise we'll need workarounds like egl/wayland. Namely register an image_loader_extension even thought we should be using only DRI2. v2: Add missing the bracket to fix the build (Tapani). Signed-off-by: Emil Velikov Reviewed-by: Tapani

[Mesa-dev] [PATCH 7/7] egl/wayland: use the image_driver alongside the image_loader

From: Emil Velikov Analogous to earlier commits - image_driver and image_loader are meant to be used hand in hand. v2: Rebase Cc: Derek Foreman Signed-off-by: Emil Velikov --- Derek, can you try the v2 of the series with alongside git revert 534ea2b5ba0? A very quick test here showed no issue

[Mesa-dev] [PATCH 6/7] egl/wayland: set the resize_callback if the flush extension is available

From: Emil Velikov Strictly speaking __DRI_DRI2 implies __DRI2_FLUSH. Although since we're using the latter in the callback, we want to use the correct guard. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

  1   2   >