Re: [Mesa-dev] [PATCH] egl: polish dri2_to_egl_attribute_map[]

On Sat, Apr 29, 2017 at 1:01 AM, Emil Velikov wrote: > From: Emil Velikov > > Annotate the array as static const and use C99 initialiser to populate > it. > > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/egl_dri2.c | 68 > +++-- > 1 file changed,

Re: [Mesa-dev] [PATCH] egl: polish dri2_to_egl_attribute_map[]

On Mon, May 1, 2017 at 5:06 PM, Tomasz Figa wrote: > On Sat, Apr 29, 2017 at 1:01 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Annotate the array as static const and use C99 initialiser to populate >> it. >> >> Signed-off-by: Emil Velikov >> --- >> src/egl/drivers/dri2/egl_dri2.c | 6

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) On 04/30/2017 08:55 AM, Timothy Arceri wrote: Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix

[Mesa-dev] [PATCH 3/3] glsl: validate memory qualifiers inside structures/interfaces

This relaxes using memory qualifiers for buffer variables because they are allowed. Fixes the following ARB_shader_image_load_store test: memory-qualifier-with-non-image-type.frag Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 12 ++-- 1 file changed, 10 insertio

[Mesa-dev] [PATCH 1/3] glsl: rework validate_image_qualifier_for_type()

It makes more sense to have two separate validate functions, mainly because memory qualifiers are allowed with members of shader storage blocks. validate_memory_qualifier_for_type() will be fixed in a separate patch. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 36 +

[Mesa-dev] [PATCH 2/3] glsl: reject format qualifiers with non-image types everywhere

Including structures, interfaces and uniform blocks. Fixes the following ARB_shader_image_load_store test: format-layout-with-non-image-type.frag Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/glsl/ast_to_h

[Mesa-dev] [PATCH] i965: fix cast in OA performance query code

Fixes the following building error happening on marshmallow-x86 with Ubuntu 16.04 LTS stock build essentials package and by the book Android build system. external/mesa/src/mesa/drivers/dri/i965/brw_performance_query.c: In function 'open_i915_perf_oa_stream': external/mesa/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 09/12] Android: push driver build details to driver makefiles

2017-04-27 21:43 GMT+02:00 Rob Herring : > src/gallium/targets/dri/Android.mk contains lots of conditional for > individual drivers. Let's move these details into the individual driver > makefiles. > > In the process, align the make driver conditionals with automake > (i.e. HAVE_GALLIUM_*). > > Si

[Mesa-dev] [ANNOUNCE] mesa 17.1.0-rc3

Hello all, The third release candidate for Mesa 17.1.0 is not available. Andres Gomez (2): travis: replace Trusty-based LLVM toolchain apt-get with apt addon travis: add the possibility of using the txc-dxtn library Emil Velikov (15): travis: explicitly LD_LIBRARY_PATH the loc

[Mesa-dev] [PATCH 2/3] ac: rename ac_eliminate_const_vs_outputs -> ac_optimize_vs_outputs

From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 10 +- src/amd/common/ac_llvm_build.h | 10 +- src/amd/common/ac_nir_to_llvm.c | 10 +- src/gallium/drivers/radeonsi/si_shader.c | 10 +- 4 files changed, 20 insertions(+), 20 dele

[Mesa-dev] [PATCH 1/3] ac: first parse VS exports before eliminating constant ones

From: Marek Olšák A later commit will make use of this. --- src/amd/common/ac_llvm_build.c | 82 +- 1 file changed, 58 insertions(+), 24 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index ba92e7e..4856c06 10064

[Mesa-dev] [PATCH 3/3] ac: eliminate duplicated VS exports

From: Marek Olšák Only very few shaders have them (from 48486 shaders): shaders/private/left_4_dead_2/765.shader_test - ac: 1 matches 2 shaders/private/left_4_dead_2/877.shader_test - ac: 1 matches 6 shaders/private/left_4_dead_2/2141.shader_test - ac: 1 matches 6 shaders/private/ue4_effects_cav

[Mesa-dev] [PATCH 04/17] st/mesa: remove unused outputSlotToAttr

From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 - src/mesa/state_tracker/st_glsl_to_tgsi.h | 1 - src/mesa/state_tracker/st_program.c| 9 - 3 files changed, 11 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/

[Mesa-dev] [PATCH 02/17] st/mesa: decrease the size of st_vertex_program

From: Marek Olšák --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 8 src/mesa/state_tracker/st_atifs_to_tgsi.h | 4 ++-- src/mesa/state_tracker/st_cb_rasterpos.c | 4 ++-- src/mesa/state_tracker/st_context.h| 2 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16

[Mesa-dev] [PATCH 01/17] st/mesa: remove struct st_tracked_state

From: Marek Olšák It contains only one member: the update function. Let's use the update function directly. --- src/mesa/state_tracker/st_atom.c | 11 ++-- src/mesa/state_tracker/st_atom.h | 9 +--- src/mesa/state_tracker/st_atom_array.c | 7 +-- src/mesa/st

[Mesa-dev] [PATCH 00/17] st/mesa cleanup

Hi, These are mostly cleanups, but the last patches add uploading of zero-stride vertex attributes into st/mesa instead of relying on u_vbuf (which uses a slower path) or drivers. Some patches in this series depend on the pipe_vertex_buffer change sent in my previous gallium series. Most of the

[Mesa-dev] [PATCH 07/17] st/mesa: simplify update_constants functions

From: Marek Olšák --- src/mesa/state_tracker/st_atom_constbuf.c | 45 +-- src/mesa/state_tracker/st_atom_constbuf.h | 4 +-- src/mesa/state_tracker/st_cb_bitmap.c | 2 +- src/mesa/state_tracker/st_cb_drawpixels.c | 4 +-- 4 files changed, 17 insertions(+), 38 d

[Mesa-dev] [PATCH 08/17] st/mesa: simplify code due to unification to st_common_program

From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 51 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 +++--- src/mesa/state_tracker/st_program.c| 9 ++ src/mesa/state_tracker/st_shader_cache.c | 22 +++-- 4 files changed

[Mesa-dev] [PATCH 09/17] st/mesa: use PIPE_MAX_ATTRIBS as the max number of vertex buffers

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index 92485bd..be8c13c 100644 --- a/src/mesa/state_tracker/st_atom_array.c +++ b/src/m

[Mesa-dev] [PATCH 03/17] st/mesa: remove st_context::vertex_result_to_slot

From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c | 2 -- src/mesa/state_tracker/st_cb_feedback.c | 4 ++-- src/mesa/state_tracker/st_cb_rasterpos.c | 3 ++- src/mesa/state_tracker/st_context.h | 3 --- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/mesa/st

[Mesa-dev] [PATCH 05/17] st/mesa: decrease the size of remaining st_translate_program array params

From: Marek Olšák --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 2 +- src/mesa/state_tracker/st_atifs_to_tgsi.h | 2 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++-- src/mesa/state_tracker/st_glsl_to_tgsi.h | 4 ++-- src/mesa/state_tracker/st_mesa_to_tgsi.c | 2 +- src/mesa/state_

[Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 12 ++--- src/mesa/state_tracker/st_atom_constbuf.c | 6 +-- src/mesa/state_tracker/st_atom_shader.c| 24 - src/mesa/state_tracker/st_cb_program.c | 34 ++-- src/mesa/state_tracker/st_context.c|

[Mesa-dev] [PATCH 11/17] st/mesa: fold error handling into setup_(non_)interleaved_attribs

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index 57f0ec1..cb6e355 100644 --- a/src/mesa/state_trac

[Mesa-dev] [PATCH 10/17] st/mesa: fold cso calls into setup_(non_)interleaved_attribs

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 91 +- 1 file changed, 45 insertions(+), 46 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index be8c13c..57f0ec1 100644 --- a/src/mesa/stat

[Mesa-dev] [PATCH 13/17] st/mesa: remove unused st parameter in init_velement_lowered

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index 3e6e3c1..f873460 100644 --- a/src/mesa/state_tracker/st_atom_array.c +++

[Mesa-dev] [PATCH 12/17] st/mesa: remove vpv->num_inputs dereferences in st_update_array

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 40 +- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index cb6e355..3e6e3c1 100644 --- a/src/mesa/stat

[Mesa-dev] [PATCH 14/17] st/mesa: simplify the signature of get_client_array

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index f873460..cc9cac1 100644 --- a/src/mesa/state_tracker/st_atom

[Mesa-dev] [PATCH 15/17] gallium: add PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX

From: Marek Olšák The next patch will use it. This is really for svga and GL2-level drivers. --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_

[Mesa-dev] [PATCH 17/17] radeonsi: remove upload code for zero-stride vertex attribs

From: Marek Olšák st/mesa takes care of it now. --- src/gallium/drivers/radeonsi/si_state.c | 34 - 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index b67667f..4f9

[Mesa-dev] [PATCH 16/17] st/mesa: upload zero-stride vertex attributes here

From: Marek Olšák This is the best place to do it. Now drivers without u_vbuf don't have to do it. --- src/mesa/state_tracker/st_atom_array.c | 56 -- src/mesa/state_tracker/st_context.c| 2 ++ src/mesa/state_tracker/st_context.h| 1 + 3 files changed, 4

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965/vec4: fix register width for DF VGRF and UNIFORM

El Viernes, 28 de abril de 2017 16:27:56 Francisco Jerez escribió: > Samuel Iglesias Gonsálvez writes: > > On gen7, the swizzles used in DF align16 instructions works for element > > size of 32 bits, so we can address only 2 consecutive DFs. As we assumed > > that in the rest of the code and prepa

Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

El Viernes, 28 de abril de 2017 16:08:35 Francisco Jerez escribió: > Samuel Iglesias Gonsálvez writes: > > It was setting XYWZ swizzle and writemask to all uniforms, no matter if > > they were a vector or scalar, so this can lead to problems when loading > > them to the push constant buffer. > >

Re: [Mesa-dev] EGL: Question about deferred context and surface destroy

Hi Tapani, Thank you very much for this explanation! All is clear now, and you are right about function description, they have to be a bit more detailed regarding this. As far as I understood there is a huge GPS navigation framework which depends on wrong behavior regarding deferred context and su

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

Hi all, another try to merge android swrast patches in mesa 17.1 or mesa-dev if they are somehow considered useful for android. Mauro 2017-01-20 20:17 GMT+01:00 Mauro Rossi : > > > Il lunedì 9 gennaio 2017, Zhen Wu ha scritto: > >> Thanks for your review, Rob. Using kms-dri would mean writing

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1: Performance results All testing below was done with radeonsi, and I used the drawoverhead microbenchmark from mesa/demos ported

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

On Mon, May 1, 2017 at 11:17 PM, Mauro Rossi wrote: > Hi all, > > another try to merge android swrast patches in mesa 17.1 or mesa-dev > if they are somehow considered useful for android. > > Mauro > > > 2017-01-20 20:17 GMT+01:00 Mauro Rossi : >> >> >> >> Il lunedì 9 gennaio 2017, Zhen Wu ha scr

Re: [Mesa-dev] [PATCH 8/8] android: egl: add support for software rasterizer

2017-01-06 18:35 GMT+01:00 Wu Zhen : > From: WuZhen > > this commit enable software rendering on android with llvmpipe. > the system boots fine antutu 3D benchmark is passing > > this commit incorporates some further work done by: > Paulo Sergio Travaglia > Mauro Rossi > > Change-Id: Ibe0114333

Re: [Mesa-dev] [PATCH 8/8] android: egl: add support for software rasterizer

+ Karl 2017-05-01 17:02 GMT+02:00 Mauro Rossi : > > > 2017-01-06 18:35 GMT+01:00 Wu Zhen : > >> From: WuZhen >> >> this commit enable software rendering on android with llvmpipe. >> the system boots fine antutu 3D benchmark is passing >> >> this commit incorporates some further work done by: >>

Re: [Mesa-dev] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

I think this is off. It shouldn't matter what the code sequence is, it's all representable. You need to teach replaceZero to not mess things up for SHLADD's src(1). On Sat, Apr 29, 2017 at 12:01 PM, Samuel Pitoiset wrote: > Doing '(a << b) + c' when b is 0 is dumb, ADD should be used > instead. >

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 05/01/2017 08:32 AM, Brian Paul wrote: On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1: Performance results All testing below was done with radeonsi, and I used the drawove

Re: [Mesa-dev] [PATCH 09/12] Android: push driver build details to driver makefiles

2017-04-27 21:43 GMT+02:00 Rob Herring : > src/gallium/targets/dri/Android.mk contains lots of conditional for > individual drivers. Let's move these details into the individual driver > makefiles. > > In the process, align the make driver conditionals with automake > (i.e. HAVE_GALLIUM_*). > > Si

Re: [Mesa-dev] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

On 05/01/2017 05:59 PM, Ilia Mirkin wrote: I think this is off. It shouldn't matter what the code sequence is, it's all representable. You need to teach replaceZero to not mess things up for SHLADD's src(1). It's representable but stupid to do it. We should keep the ADD there and this also a

Re: [Mesa-dev] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset wrote: > On 05/01/2017 05:59 PM, Ilia Mirkin wrote: >> >> I think this is off. It shouldn't matter what the code sequence is, >> it's all representable. You need to teach replaceZero to not mess >> things up for SHLADD's src(1). > > > It's represent

Re: [Mesa-dev] [ANNOUNCE] mesa 17.1.0-rc3

Hi I think this email is sent from a script so just wanted to point out: not available -> now available If it's just a bog standard typo in a manually written email - just ignore me Mike On Mon, 1 May 2017 at 13:24 Emil Velikov wrote: > Hello all, > > The third release candidate for Mesa 17.

Re: [Mesa-dev] [PATCH 2/2] radv: Use correct stage for ready bit.

Haven't noticed any difference in DOOM graphs, but that's not a bad thing I guess. Tested-by: Grazvydas Ignotas On Sun, Apr 30, 2017 at 7:40 PM, Bas Nieuwenhuizen wrote: > Set the bit in the same stage as the timestamp, instead always at top of > pipe. > > Signed-off-by: Bas Nieuwenhuizen > --

Re: [Mesa-dev] [PATCH 02/17] st/mesa: decrease the size of st_vertex_program

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 8 src/mesa/state_tracker/st_atifs_to_tgsi.h | 4 ++-- src/mesa/state_tracker/st_cb_rasterpos.c | 4 ++-- src/mesa/state_tracker/st_context.h| 2 +- src/me

Re: [Mesa-dev] [PATCH 07/17] st/mesa: simplify update_constants functions

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_constbuf.c | 45 +-- src/mesa/state_tracker/st_atom_constbuf.h | 4 +-- src/mesa/state_tracker/st_cb_bitmap.c | 2 +- src/mesa/state_tracker/st_cb_drawpixels.c

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 12 ++--- src/mesa/state_tracker/st_atom_constbuf.c | 6 +-- src/mesa/state_tracker/st_atom_shader.c| 24 - src/mesa/state_tracker/st_cb_program.c | 34 ++

Re: [Mesa-dev] [PATCH 08/17] st/mesa: simplify code due to unification to st_common_program

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 51 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 +++--- src/mesa/state_tracker/st_program.c| 9 ++ src/mesa/state_tracker/st_sha

[Mesa-dev] [Bug 100854] YUV to RGB Color Space Conversion result is not precise

https://bugs.freedesktop.org/show_bug.cgi?id=100854 --- Comment #3 from Kristian Høgsberg --- You can extend this with the problematic YUV value: https://cgit.freedesktop.org/piglit/commit/?id=adc7e03ad59404362141093ae93b091c58bb1018 -- You are receiving this mail because: You are the assignee

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

Johnson Lin writes: > The matrix used for YCbCr to RGB is listed in Wiki > https://en.wikipedia.org/wiki/YCbCr; > There is minor error in the matrix constant: 0.0625=16/256 should be 16.0/255, > and 0.5=128.0/256 should be 128.0/255. > Note that conversion from a 0-255 byte number to 0-1.0 floa

[Mesa-dev] [PATCH 1/2] dri_interface.h: define __DRI_ATTRIB_MAX

From: Emil Velikov Thus we can use the value to explicitly size arrays, insteads of __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE. The latter seems magical and is error prone, as we add more dri attributes. Cc: Tomasz Figa Signed-off-by: Emil Velikov --- include/GL/internal/dri_interface.h | 1 + 1

[Mesa-dev] [PATCH 2/2] eg: explicitly size dri2_to_egl_attribute_map[]

From: Emil Velikov This way we'll get an implicit zero initialization of the remaining members, as required by dri2_add_config(). Fixes: e5efaeb85c3 ("egl: polish dri2_to_egl_attribute_map[]") Cc: Tomasz Figa Signed-off-by: Emil Velikov --- Tomasz, thanks for spotting this! --- src/egl/driver

Re: [Mesa-dev] [PATCH 07/12] Android: remove needless conditional including of child makefiles

On 27 April 2017 at 20:43, Rob Herring wrote: > It is not necessary to filter driver and winsys directories based on the > list of enabled drivers. Selecting the included driver libraries or not is > sufficient to control what is built. > > Signed-off-by: Rob Herring > --- > Android.mk

Re: [Mesa-dev] [PATCH 07/12] Android: remove needless conditional including of child makefiles

On Mon, May 1, 2017 at 1:50 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> It is not necessary to filter driver and winsys directories based on the >> list of enabled drivers. Selecting the included driver libraries or not is >> sufficient to control what is built. >>

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-05-01 3:03 GMT+02:00 Mauro Rossi : > > > 2017-04-28 4:55 GMT+02:00 Chih-Wei Huang : > >> 2017-04-28 3:43 GMT+08:00 Rob Herring : >> > This is a series of clean-ups and fixes to the Android build files. >> > Overall, it removes a lot of the if conditions that aren't necessary for >> > normal b

Re: [Mesa-dev] [PATCH 09/12] Android: push driver build details to driver makefiles

Hi Rob, On 27 April 2017 at 20:43, Rob Herring wrote: > +classic_drivers := i915.HAVE_I915_DRI i965.HAVE_I965_DRI > +gallium_drivers := \ > + swrast.HAVE_GALLIUM_SOFTPIPE \ > + freedreno.HAVE_GALLIUM_FREEDRENO \ > + i915g.HAVE_GALLIUM_I915 \ > + nouveau.HAVE_GALLIUM_NOUVE

Re: [Mesa-dev] [PATCH 10/12] Android: default to building all drivers

On 27 April 2017 at 20:43, Rob Herring wrote: > If BOARD_GPU_DRIVERS is empty, build all the drivers. This doesn't > enable building mesa as that is controlled by including libGLES_mesa in > the product. > > Signed-off-by: Rob Herring > --- > Android.mk | 8 > 1 file changed, 8 insertio

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On 27 April 2017 at 20:43, Rob Herring wrote: > Android O moves to LLVM 3.9 and also has some differences in header > dependencies as LLVM has moved to blueprint files. It seems libLLVMCore > was only needed for header dependencies. > > Signed-off-by: Rob Herring > --- > Android.common.mk

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

Eric Anholt writes: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific and I didn't want to add detection

Re: [Mesa-dev] [PATCH 12/12] Android: Drop linking libgcc

On 27 April 2017 at 20:43, Rob Herring wrote: > Including libgcc breaks on Android O (master). Not exactly sure if it is > still needed on older versions or not. N is build with clang, so it > should be fine at least. > Chih-Wei added it with c5e11e5f7f67fe5a1d28b1446f87af7aa3ba68d8 for Android L.

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On Mon, May 1, 2017 at 3:27 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> Android O moves to LLVM 3.9 and also has some differences in header >> dependencies as LLVM has moved to blueprint files. It seems libLLVMCore >> was only needed for header dependencies. >> >> S

Re: [Mesa-dev] [PATCH 12/12] Android: Drop linking libgcc

On Mon, May 1, 2017 at 3:35 PM, Emil Velikov wrote: > On 27 April 2017 at 20:43, Rob Herring wrote: >> Including libgcc breaks on Android O (master). Not exactly sure if it is >> still needed on older versions or not. N is build with clang, so it >> should be fine at least. >> > Chih-Wei added it

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

On 27 April 2017 at 20:43, Rob Herring wrote: > This is a series of clean-ups and fixes to the Android build files. > Overall, it removes a lot of the if conditions that aren't necessary for > normal builds and also enables "mmma external/mesa3d" to build > everything for easier build testing. > >

[Mesa-dev] [PATCH 00/11] i965: Shader programs in the error state

This series adds the userspace portion required to save the shader programs that were running when a GPU hang occurred in the error state. From there we can feed the error state to aubinator_error_decode, which will parse the batch and find the shader programs, validate them (using brw_eu_validate

Re: [Mesa-dev] [PATCH 11/12] Android: Add LLVM support for Android O

On 1 May 2017 at 21:40, Rob Herring wrote: > On Mon, May 1, 2017 at 3:27 PM, Emil Velikov wrote: >> On 27 April 2017 at 20:43, Rob Herring wrote: >>> Android O moves to LLVM 3.9 and also has some differences in header >>> dependencies as LLVM has moved to blueprint files. It seems libLLVMCore >>

[Mesa-dev] [PATCH 02/11] i965: Pass pointer and end of assembly to brw_validate_instructions

This will allow us to more easily run brw_validate_instructions() on shader programs we find in GPU hang error states. --- src/intel/compiler/brw_eu.h | 3 ++- src/intel/compiler/brw_eu_validate.c | 10 -- src/intel/compiler/brw_fs_generator.cpp | 10 -- src/i

[Mesa-dev] [PATCH 01/11] i965: Mark shader programs for capture in the error state.

When the GPU hangs, the kernel saves some state for us. Until now it has not included the shader programs, which are very often the reason the GPU hang occurred. With the programs saved in the error state, we should be more capable of debugging hangs. Thanks to Chris Wilson and Ben Widawsky who pr

[Mesa-dev] [PATCH 05/11] genxml: Remove brackets from kernel start pointer names

Newer Gens' names don't have the brackets. Having common names will make some later patches simpler. --- src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen6.xml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen4

[Mesa-dev] [PATCH 06/11] genxml: Remove hyphens from pixel dispatch enable names

Newer Gens' names don't have the hyphens. Having common names will make some later patches simpler. --- src/intel/genxml/gen4.xml | 6 +++--- src/intel/genxml/gen45.xml | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen4.xml b/src/intel/genxml/ge

[Mesa-dev] [PATCH 04/11] i965: Add a weak no-op nir_print_instr() symbol

intel_asm_annotation.c is part of libintel_compiler.la, which contains code for disassembling and validating shaders that we want to call in aubinator_error_decode. dump_assembly() calls nir_print_instr() to print annotations, and although dump_assembly() is not called by aubinator_error_decode (n

[Mesa-dev] [PATCH 07/11] genxml: Rename "VS Function Enable" to just "Function Enable"

Other commands have a field with an identical function and call it "Function Enable". --- src/intel/genxml/gen45.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml index 1a5a521..b7f0c8b 100644 --- a/src/intel/genxml/gen4

[Mesa-dev] [PATCH 03/11] i965: Allow brw_eu_validate to handle compact instructions

This will allow the validator to run on shader programs we find in the GPU hang error state. --- src/intel/compiler/brw_eu_validate.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index 39363e4..3856

[Mesa-dev] [PATCH 08/11] intel/decoder: Fix indentation

--- src/intel/common/gen_decoder.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 15bba32..049d1be 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.c @@ -433,8 +433,8 @@

[Mesa-dev] [PATCH 09/11] intel/tools: Refactor gen_disasm_disassemble() to use annotations

Which will allow us to print validation errors found in shader assembly in GPU hang error states. --- src/intel/tools/disasm.c | 71 +--- 1 file changed, 43 insertions(+), 28 deletions(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c

[Mesa-dev] [PATCH 11/11] intel/aubinator_error_decode: Disassemble shader programs

--- src/intel/Makefile.tools.am | 6 +- src/intel/tools/aubinator_error_decode.c | 178 ++- 2 files changed, 180 insertions(+), 4 deletions(-) diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am index 576beea..1175118 100644 --- a/src/

[Mesa-dev] [PATCH 10/11] intel/aubinator_error_decode: Stop decoding after MI_BATCH_BUFFER_END

--- src/intel/tools/aubinator_error_decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 2e62369..244bef8 100644 --- a/src/intel/tools/aubinator_error_decode.c +++ b/src/intel/tools/aubinator_erro

Re: [Mesa-dev] [PATCH 02/12] android: define required __STDC* macros as cflags

On 30 April 2017 at 16:40, Mauro Rossi wrote: > > > 2017-04-30 11:43 GMT+02:00 Emil Velikov : >> >> Hi Rob, >> >> On 27 April 2017 at 20:43, Rob Herring wrote: >> > From: Mauro Rossi >> > >> > Necessary to fix the following radeonsi building errors: >> > >> > In file included from >> > external/

Re: [Mesa-dev] [PATCH 00/17] st/mesa cleanup

This series (on top to the other series) is Tested-by: Edmondo Tommasina Tested on Radeon RX 470: * The Witcher 2 * Two Worlds * Uningine Heaven/Valley/Superposition * Civilization 5 * Wasteland 2 * The Talos Principle (OpenGL) Thanks edmondo On Mon, May 1, 2017 at 2:52 PM, Marek Olšák wrote:

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 EoD changed: What|Removed |Added CC||e...@xmw.de --- Comment #15 from EoD --- I also

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

On Sat 29 Apr 2017, Xu, Randy wrote: > > -Original Message- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Saturday, April 29, 2017 8:36 PM > > To: Chad Versace ; Emil Velikov > > ; Xu, Randy ; mesa- > > d...@lists.freedesktop.org > > Subject: Re: [Mesa-dev] [PATCH] i965

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

On 01/05/17 19:57, Samuel Pitoiset wrote: Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) Yes you should be able to push it again (although wouldn't hurt to give it a run in Jenkins first). I didn't realize the pa

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

On Mon, May 1, 2017 at 11:29 PM, Eric Anholt wrote: > Eric Anholt writes: > > > I wrote this code with reference to pixman, though I've only decided to > > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > > has getauxval() as a cleaner interface to the /proc entry, but

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

On Mon, Apr 24, 2017 at 11:59 PM, Eric Anholt wrote: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific and

[Mesa-dev] [PATCH] anv/tests: Create a dummy instance as well as device

This fixes crashes caused by 35e626bd0e59e7ce9fd97ccef66b2468c09206a4 which made us start referencing the instance in the allocators. With this commit, the tests now happily pass again. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100877 --- src/intel/vulkan/tests/block_pool_no_free.c

Re: [Mesa-dev] [PATCH 07/11] genxml: Rename "VS Function Enable" to just "Function Enable"

Reviewed-by: Jason Ekstrand On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > Other commands have a field with an identical function and call it > "Function Enable". > --- > src/intel/genxml/gen45.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/genxml/

Re: [Mesa-dev] [PATCH 06/11] genxml: Remove hyphens from pixel dispatch enable names

I've already had to make similar changes in gen7 and maybe 6. patches 5 and 6 are Reviewed-by: Jason Ekstrand On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > Newer Gens' names don't have the hyphens. Having common names will make > some later patches simpler. > --- > src/intel/genxml/ge

Re: [Mesa-dev] [PATCH] anv/tests: Create a dummy instance as well as device

On Mon, May 1, 2017 at 4:50 PM, Jason Ekstrand wrote: > This fixes crashes caused by 35e626bd0e59e7ce9fd97ccef66b2468c09206a4 > which made us start referencing the instance in the allocators. With > this commit, the tests now happily pass again. > > Bugzilla: https://bugs.freedesktop.org/show_bug

Re: [Mesa-dev] [PATCH 02/21] anv/cmd_buffer: Use the device allocator for QueueSubmit

On Fri, Apr 28, 2017 at 3:46 PM, Nanley Chery wrote: > On Fri, Apr 14, 2017 at 10:37:49AM -0700, Jason Ekstrand wrote: > > The command is really operating on a Queue not a command buffer and the > > nearest object to that with an allocator is VkDevice. > > > > Cc: "17.0" > > Should this have bee

Re: [Mesa-dev] [PATCH v2] scons: update for LLVM 4.0

On Sat, Apr 29, 2017 at 14:24:28 +0100, Emil Velikov wrote: > Barring any objections from Jose I'll push this in a couple of days. Thanks! > P.S. For future patches please add a brief changelog. Before or after > the --- line. Ah, sorry. When reordering the libraries to look like the 3.9 block,

[Mesa-dev] [PATCH 1/5] radv: provide a helper for comparing an image extents.

From: Dave Airlie This just makes it easier to do the follow in cleanups of the surface. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_clear.c | 4 ++-- src/amd/vulkan/radv_private.h| 9 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv

[Mesa-dev] radv: reduce size of image structs.

Marek cleaned up a lot of this in radeonsi previously, so I'd like to realign our code over time to end up closer to what is there, esp in light of future vega work. This series just reworks in the winsys surface info, and reduces the size of the radv_image struct from 5200 bytes to 4136 bytes, as

[Mesa-dev] [PATCH 2/5] radv: move some image info into a separate struct.

From: Dave Airlie This is to rework the surface code like radeonsi. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 4 +-- src/amd/vulkan/radv_device.c | 14 src/amd/vulkan/radv_image.c | 63 ++- src/amd/vulkan

[Mesa-dev] [PATCH 3/5] radv: remove some members of radeon surface.

From: Dave Airlie We would be storing this info twice per image, no need to, remove it from the surface struct. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_image.c| 19 +++ src/amd/vulkan/radv_radeon

[Mesa-dev] [PATCH 5/5] radv: drop unused surface level members.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h| 3 --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index

[Mesa-dev] [PATCH 4/5] radv/image: drop blk_d

From: Dave Airlie This was pretty much unused. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c| 1 - src/amd/vulkan/radv_radeon_winsys.h| 1 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 2 +- 3 files changed, 1 insertion(+), 3 deleti

Re: [Mesa-dev] [PATCH 1/2] dri_interface.h: define __DRI_ATTRIB_MAX

Hi Emil, On Tue, May 2, 2017 at 3:43 AM, Emil Velikov wrote: > From: Emil Velikov > > Thus we can use the value to explicitly size arrays, insteads of > __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE. > > The latter seems magical and is error prone, as we add more dri > attributes. > > Cc: Tomasz Figa >

Re: [Mesa-dev] [PATCH 2/2] eg: explicitly size dri2_to_egl_attribute_map[]

Hi Emil, On Tue, May 2, 2017 at 3:43 AM, Emil Velikov wrote: > From: Emil Velikov > > This way we'll get an implicit zero initialization of the remaining > members, as required by dri2_add_config(). > > Fixes: e5efaeb85c3 ("egl: polish dri2_to_egl_attribute_map[]") > Cc: Tomasz Figa > Signed-of

Re: [Mesa-dev] [PATCH 05/12] Android: drop LLVM support on Lollipop

2017-04-30 11:49 GMT+02:00 Emil Velikov : > On 27 April 2017 at 20:43, Rob Herring wrote: > > Mesa no longer supports LLVM 3.5 for any targets we support. > > Android-x86 adds support for llvmpipe which could work, but android-x86 > > for L is using mesa 11.0 anyway. > > > Fine with me. An ack fr

[Mesa-dev] [PATCH] radv/image: resize some surface members.

From: Dave Airlie Oops meant to be part of previous series. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index 5614d8b..8

  1   2   >