[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #17 from Chris Rankin --- (In reply to Michel Dänzer from comment #16) > The patch just disables DRI3 for VDPAU, so it cannot be applied anywhere as > is. It would have to be guarded by an environment variable. I only intended that p

[Mesa-dev] [PATCH v2 1/3] etnaviv: Add chipMinorFeatures4 and 5

2017-04-14 Thread Wladimir J. van der Laan
Request chipMinorFeatures bitfields 4 and 5 from the drm driver. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) no changes from v

[Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

2017-04-14 Thread Wladimir J. van der Laan
Update to etna_viv commit 411bd69. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common.xml.h| 10 ++-- src/gallium/drivers/etnaviv/hw/isa.xml.h | 75 +- src/gallium/drivers/etn

[Mesa-dev] [PATCH v2 3/3] etnaviv: SINGLE_BUFFER support on GC3000

2017-04-14 Thread Wladimir J. van der Laan
This patch adds support for the SINGLE_BUFFER feature on GC3000 GPUs, which allows rendering to a single buffer using multiple pixel pipes. This feature is always used when it is available, which means that multi-tiled formats are no longer being used in that case, and all buffers will be normal (

Re: [Mesa-dev] [PATCH v2 3/4] mesa: move glMultiDrawArrays to vbo and fix error handling

2017-04-14 Thread Nils Wallménius
Den 13 apr. 2017 9:29 em skrev "Nicolai Hähnle" : From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. v2: - provide the function in all contexts, including GLES - adjust validation accordingly to include the xfb check --

Re: [Mesa-dev] [PATCH v2 1/2] gallium: Enable ARM NEON/VFP CPU detection.

2017-04-14 Thread Grazvydas Ignotas
On Fri, Apr 14, 2017 at 12:08 AM, Eric Anholt wrote: > I wrote this code with reference to pixman, though I've only decided to > cover Linux (what I'm testing) and Android (seems obvious enough). Linux > has getauxval() as a cleaner interface to the /proc entry, but it's more > glibc-specific an

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-14 Thread Yu, Qiang
Hi Emil, > What happened with the idea of reusing your existing amdgpu_dri.so ? > As mentioned before the DRI loader (libgbm) <> DRI driver (foo_dri.so) > interface is stable, so things should just work. Sorry for the late reply. I've asked our amdgpu_dri.so team for this, they seems have no inte

[Mesa-dev] [PATCH v2] dri: add queryDmaBufFormats and queryDmaBufModifiers to DRIimage

2017-04-14 Thread Varad Gautam
From: Varad Gautam these allow querying the driver for supported dmabuf formats and modifiers. v2: move to __DRIimageExtension version 16. Signed-off-by: Varad Gautam --- include/GL/internal/dri_interface.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH v2] egl: implement eglQueryDmaBufFormatsEXT

2017-04-14 Thread Varad Gautam
From: Varad Gautam allow egl clients to query the dmabuf formats supported on this platform. v2: rebase to master. Signed-off-by: Louis-Francis Ratté-Boulianne Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 17 + src/egl/main/eglapi.c | 18 +++

[Mesa-dev] [PATCH v2] st/dri: support format modifier queries

2017-04-14 Thread Varad Gautam
From: Varad Gautam ask the driver for supported modifiers for a given format. bump __DRIimageExtension to 16. v2: move to __DRIimageExtension v16. Signed-off-by: Varad Gautam --- src/gallium/state_trackers/dri/dri2.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v2] st/dri: support format queries

2017-04-14 Thread Varad Gautam
From: Varad Gautam ask the driver for supported dmabuf formats v2: rebase to master. Signed-off-by: Varad Gautam --- src/gallium/state_trackers/dri/dri2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dr

[Mesa-dev] [PATCH v2] st/dri: implement DRIimage creation from dmabufs with modifiers

2017-04-14 Thread Varad Gautam
From: Varad Gautam support importing dmabufs into DRIimage while taking format modifiers in account, and bump __DRIimageExtension on gallium to version 15. v2: move to __DRIimageExtension v15. Signed-off-by: Varad Gautam --- src/gallium/include/state_tracker/drm_driver.h | 2 ++ src/gallium/

[Mesa-dev] [PATCH v2] gallium: introduce dmabuf format and modifier querying

2017-04-14 Thread Varad Gautam
From: Varad Gautam allows drivers to be queried for supported formats and format modifiers for EGL_EXT_image_dma_buf_import_modifiers. drivers that implement format/modifier queries must advertise these under PIPE_CAP_QUERY_DMABUF_ATTRIBS. v2: rebase to master. Signed-off-by: Varad Gautam ---

[Mesa-dev] [PATCH v2] dri: support DRIimage creation from dmabufs with modifiers

2017-04-14 Thread Varad Gautam
From: Pekka Paalanen add createImageFromDmaBufs2 function which accepts per-plane dmabuf format modifiers. v2: resolve DRIimage version conflict by moving createImageFromDmaBufs2 to v15. Signed-off-by: Pekka Paalanen Signed-off-by: Varad Gautam --- include/GL/internal/dri_interface.h | 2

[Mesa-dev] [PATCH v2] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

2017-04-14 Thread Varad Gautam
From: Varad Gautam v2: check for both queryDmaBufFormats and queryDmaBufModifiers, rebase to master. Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 6 ++ src/egl/main/eglapi.c | 1 + 2 files changed, 7 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dr

[Mesa-dev] [PATCH v2] egl: implement eglQueryDmaBufModifiersEXT

2017-04-14 Thread Varad Gautam
From: Varad Gautam query and return supported dmabuf format modifiers for EGL_EXT_image_dma_buf_import_modifiers. v2: rebase to master. Signed-off-by: Varad Gautam --- src/egl/drivers/dri2/egl_dri2.c | 47 + src/egl/main/eglapi.c | 20

Re: [Mesa-dev] [PATCH V3 2/2] glsl: don't run the GLSL pre-processor when we are skipping compilation

2017-04-14 Thread Timothy Arceri
Ping for a-b/r-b. It would be nice to get this pushed in the next few hours so it can make 17.1. Thanks, Tim On 10/04/17 11:48, Timothy Arceri wrote: Improves Deus Ex start-up times with a warm cache from ~30 seconds to ~22 seconds. Also fixes the leaking of state. V2: fix indentation v3: a

Re: [Mesa-dev] [PATCH 0/5] gallium, radeonsi: enable ARB_shader_viewport_layer_array

2017-04-14 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 04/14/2017 06:30 AM, Nicolai Hähnle wrote: > Hi all, > > This is another small one, as the extension is mostly a merge of > AMD_vertex_shader_layer and AMD_vertex_shader_viewport_index, and > the core Mesa parts are done already. > > Tested wit

[Mesa-dev] [PATCH] nir/print: add compute shader info

2017-04-14 Thread Rob Clark
Signed-off-by: Rob Clark --- noticed this hanging out on a branch.. guess I forgot to send it to list.. src/compiler/nir/nir_print.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index af10555..e6c5c9c 100644 --- a/

Re: [Mesa-dev] [PATCH] nir/print: add compute shader info

2017-04-14 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 14/04/17 16:25, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > noticed this hanging out on a branch.. guess I forgot to send it > to list.. > > src/compiler/nir/nir_print.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/compile

Re: [Mesa-dev] [PATCH] swr: add linux to scons build

2017-04-14 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Apr 13, 2017, at 2:17 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: Make swr compile for both linux and windows. --- src/gallium/drivers/swr/SConscript| 7 +-- src/gallium/targets/libgl-xlib/SConscript | 2

[Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Marek Olšák
From: Marek Olšák This avoids repeated translations of the enum. --- src/mesa/drivers/dri/i965/brw_context.h | 21 -- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 +++--- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 10 +++ src/mesa/drivers/dri/i965/gen

[Mesa-dev] [PATCH 3/7] st/mesa: invalidate the readpix cache in st_indirect_draw_vbo

2017-04-14 Thread Marek Olšák
From: Marek Olšák Cc: --- src/mesa/state_tracker/st_draw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index a781209..dd374ae 100644 --- a/src/mesa/state_tracker/st_draw.c +++ b/src/mesa/state_tracker/st_draw.c @@ -26

[Mesa-dev] [PATCH 2/7] gallium/util: remove util_draw_range_elements helper

2017-04-14 Thread Marek Olšák
From: Marek Olšák min/max_index are typically hints for the u_vbuf module, not the driver. --- src/gallium/auxiliary/util/u_draw.h | 23 --- 1 file changed, 23 deletions(-) diff --git a/src/gallium/auxiliary/util/u_draw.h b/src/gallium/auxiliary/util/u_draw.h index b16f106.

[Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

2017-04-14 Thread Marek Olšák
From: Marek Olšák for lower overhead. --- src/mesa/state_tracker/st_atom_array.c | 469 - 1 file changed, 227 insertions(+), 242 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index 221b2c7..6cfbd24 1006

[Mesa-dev] [PATCH 5/7] st/mesa: put the bitmap_cache structure inside st_context

2017-04-14 Thread Marek Olšák
From: Marek Olšák This is nicer on caches, and the next commit will need to access the structure from a different place. --- src/mesa/state_tracker/st_cb_bitmap.c | 54 +-- src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_context.h | 23 +

[Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Marek Olšák
From: Marek Olšák Most drivers don't need it and shouldn't need it because it can't be used in some cases (indirect draws, primitive restart, count from streamout). --- src/gallium/drivers/etnaviv/etnaviv_context.c | 5 + src/gallium/drivers/freedreno/freedreno_draw.c | 5 + src/galli

[Mesa-dev] [PATCH 4/7] st/mesa: inline and optimize st_invalidate_readpix_cache

2017-04-14 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_readpixels.c | 8 src/mesa/state_tracker/st_context.h | 13 +++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c ind

[Mesa-dev] [PATCH 6/7] st/mesa: check in advance in st_draw_vbo whether the bitmap cache is empty

2017-04-14 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index dd374ae..d710284 100644 --- a/src/mesa/state_tracker/st_draw.c +++ b/src/mesa/state_tracker/st_d

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 13, 2017, at 3:30 PM, George Kyriazis > wrote: > > Add polygon stipple functionality to the fragment shader. > > Explicitly turn off polygon stipple for lines and points, since we > do them using tris. > --- > src/gallium/drivers/swr/swr_context.h | 4 ++

[Mesa-dev] [PATCH 2/7] radeonsi: merge two if (indirect) statements

2017-04-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 52 +--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index aa528ce..0ada60a 100644 --- a/s

[Mesa-dev] [PATCH 4/7] radeonsi: don't set VGT_GS_MODE as part of the GS state

2017-04-14 Thread Marek Olšák
From: Marek Olšák The VS state sets it. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 78c7495..b856fc9 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 6/7] radeonsi: remove local variable 'mod' from si_compile_tgsi_shader

2017-04-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 6242ec1..704c67e 100644 --- a/src/gallium/drivers/radeonsi/si_shade

[Mesa-dev] [PATCH 7/7] gallium/radeon: always flush asynchronously and wait after begin_new_cs

2017-04-14 Thread Marek Olšák
From: Marek Olšák This hides the overhead of everything in the driver after the CS flush and before returning from pipe_context::flush. Only microbenchmarks will benefit. +2% FPS for glxgears. --- src/gallium/drivers/radeon/r600_pipe_common.c | 12 src/gallium/drivers/radeonsi/si_h

[Mesa-dev] [PATCH 5/7] radeonsi: add si_shader_selector::vs_needs_prolog

2017-04-14 Thread Marek Olšák
From: Marek Olšák cleanup --- src/gallium/drivers/radeonsi/si_shader.c| 12 +--- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 4 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 3/7] radeonsi: don't allow user indices with indirect draws

2017-04-14 Thread Marek Olšák
From: Marek Olšák Not possible with GL and it will make future gallium rework easier. (also it's something I wouldn't like to support) --- src/gallium/drivers/radeonsi/si_state_draw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_stat

[Mesa-dev] [PATCH 1/7] radeonsi: don't mark non-dirty textures with CMASK as compressed

2017-04-14 Thread Marek Olšák
From: Marek Olšák because the compression is skipped with non-dirty textures. --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c

Re: [Mesa-dev] [PATCH] swr: update gallium driver docs

2017-04-14 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 13, 2017, at 1:41 PM, Tim Rowley wrote: > > --- > src/gallium/docs/source/drivers/openswr.rst | 2 +- > src/gallium/docs/source/drivers/openswr/usage.rst | 9 +++-- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/docs

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:06 AM, Marek Olšák wrote: > diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h > index d62ab4e..79f7538 100644 > --- a/src/mesa/vbo/vbo.h > +++ b/src/mesa/vbo/vbo.h Should also be possible to remove vbo_sizeof_ib_type from here right? With that changed, this is Revie

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Ilia Mirkin
On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis wrote: > Add polygon stipple functionality to the fragment shader. > > Explicitly turn off polygon stipple for lines and points, since we > do them using tris. > --- > src/gallium/drivers/swr/swr_context.h | 4 ++- > src/gallium/drivers/swr/swr_s

Re: [Mesa-dev] [PATCH 1/7] radeonsi: don't mark non-dirty textures with CMASK as compressed

2017-04-14 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/14/2017 05:08 PM, Marek Olšák wrote: From: Marek Olšák because the compression is skipped with non-dirty textures. --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drive

Re: [Mesa-dev] [PATCH] mesa: rename _mesa_add_renderbuffer* functions

2017-04-14 Thread Brian Paul
Looks ok, just minor formatting nit-picks below. Reviewed-by: Brian Paul On 04/13/2017 09:42 PM, Timothy Arceri wrote: These names so make is easier to understand what is going on in regards to references. Cc: Brian Paul --- src/mesa/drivers/dri/i915/intel_screen.c | 10 +-

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > index bc9b9a1..295c394 100644 > --- a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > +++ b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >

Re: [Mesa-dev] [PATCH 03/14] mesa: add _mesa_is_no_error_enabled() helper

2017-04-14 Thread Brian Paul
On 04/13/2017 06:14 PM, Timothy Arceri wrote: On 13/04/17 12:54, Brian Paul wrote: On 04/12/2017 05:42 PM, Timothy Arceri wrote: --- src/mesa/main/context.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 9704a96..ccb5463 1

Re: [Mesa-dev] [PATCH 2/7] gallium/util: remove util_draw_range_elements helper

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > From: Marek Olšák > > min/max_index are typically hints for the u_vbuf module, not the driver. nv30, nv50, and nvc0 all use them to configure vbo limits to prevent out-of-bounds reads. That said, if nothing uses this function (which appears

Re: [Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

2017-04-14 Thread Ilia Mirkin
Patches 2-7 are Reviewed-by: Ilia Mirkin On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > From: Marek Olšák > > for lower overhead. > --- > src/mesa/state_tracker/st_atom_array.c | 469 > - > 1 file changed, 227 insertions(+), 242 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

2017-04-14 Thread Brian Paul
On 04/14/2017 09:07 AM, Marek Olšák wrote: From: Marek Olšák for lower overhead. --- src/mesa/state_tracker/st_atom_array.c | 469 - 1 file changed, 227 insertions(+), 242 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_trac

[Mesa-dev] [PATCH] i965: perf: fix codegen with single operand equation

2017-04-14 Thread Lionel Landwerlin
We did support single value operand equations, but not single variable operand ones. In particular we were failing on "$Sampler0Bottleneck". Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/dr

[Mesa-dev] [PATCH 3/3] winsys/amdgpu: init buffer_indices_hashlist with memset()

2017-04-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index f068d8ea7a..8a277d08e1 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 2/3] winsys/amdgpu: simplify amdgpu_cs_add_buffer() a bit

2017-04-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 3ae5d33fce..f068d8ea7a 100644 --- a/src/gallium/wins

[Mesa-dev] [PATCH 1/3] gallium/radeon: remove useless cast in radeon_add_to_buffer_list()

2017-04-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_cs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_cs.h b/src/gallium/drivers/radeon/r600_cs.h index 28bdf15b8a..5e6cb1fe1c 100644 --- a/src/gallium/drivers/radeon/r600_cs.h +

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:18 AM, Ilia Mirkin wrote: > On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis > wrote: >> Add polygon stipple functionality to the fragment shader. >> >> Explicitly turn off polygon stipple for lines and points, since we >> do them using tris. >> --- >> src/gallium/driv

Re: [Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

2017-04-14 Thread Marek Olšák
Thanks. I'm amending this: diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c index 6cfbd24..436ea45 100644 --- a/src/mesa/state_tracker/st_atom_array.c +++ b/src/mesa/state_tracker/st_atom_array.c @@ -47,8 +47,9 @@ #include "main/bufferobj.h" #include

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Marek Olšák
On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: > On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >> b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >> index bc9b9a1..295c394 100644 >> --- a/src/gallium/drivers/nouveau/nv30/nv30_

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Marek Olšák
On Fri, Apr 14, 2017 at 5:12 PM, Ilia Mirkin wrote: > On Fri, Apr 14, 2017 at 11:06 AM, Marek Olšák wrote: >> diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h >> index d62ab4e..79f7538 100644 >> --- a/src/mesa/vbo/vbo.h >> +++ b/src/mesa/vbo/vbo.h > > Should also be possible to remove vbo_siz

Re: [Mesa-dev] [PATCH] nir: Destination component count of shader_clock intrinsic is 2

2017-04-14 Thread Jason Ekstrand
On Wed, Apr 12, 2017 at 6:14 AM, Boyan Ding wrote: > This fixes the following error when using ARB_shader_clock on i965: > vec1 32 ssa_0 = intrinsic shader_clock () () () > intrinsic store_var (ssa_0) (clock_retval) (3) /* wrmask=xy */ > error: src->ssa->num_components == num_comp

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 12:42 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: >>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >>> b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >>> index bc9b9a1..29

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 12:45 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 5:12 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 11:06 AM, Marek Olšák wrote: >>> diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h >>> index d62ab4e..79f7538 100644 >>> --- a/src/mesa/vbo/vbo.h >>> +++ b/src

Re: [Mesa-dev] [PATCH] nir: Destination component count of shader_clock intrinsic is 2

2017-04-14 Thread Jason Ekstrand
+Matt, +Ken On Wed, Apr 12, 2017 at 6:09 PM, Boyan Ding wrote: > 2017-04-13 2:25 GMT+08:00 Jason Ekstrand : > > On Wed, Apr 12, 2017 at 6:14 AM, Boyan Ding > wrote: > >> > >> This fixes the following error when using ARB_shader_clock on i965: > >> vec1 32 ssa_0 = intrinsic shader_clock

Re: [Mesa-dev] [PATCH v2] configure.ac: add --enable-sanitize option

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 17:14, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking for undefined symbols: running > the address sanitizer requires additional symbols which s

Re: [Mesa-dev] [PATCH kmscube 3/6] common: include config.h

2017-04-14 Thread Emil Velikov
Hi Ben, On 13 April 2017 at 19:22, Ben Widawsky wrote: > --- > common.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/common.h b/common.h > index 2eceac7..f3d9d32 100644 > --- a/common.h > +++ b/common.h > @@ -32,6 +32,10 @@ > #include > #include > > +#ifdef HAVE_CONFIG_H > +

Re: [Mesa-dev] [PATCH kmscube 4/6] common: Use the create with modifiers interface

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 19:22, Ben Widawsky wrote: > --- > common.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/common.c b/common.c > index 4bf3c5a..e63bb39 100644 > --- a/common.c > +++ b/common.c > @@ -31,10 +31,23 @@ > > static struct gbm gbm; > > +#ifndef DRM_FO

[Mesa-dev] [PATCH] radv: remove irrelevant comment

2017-04-14 Thread Grazvydas Ignotas
A leftover from anv. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5f14394..7857e8f 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vu

[Mesa-dev] [PATCH] radv: report timestampPeriod correctly

2017-04-14 Thread Grazvydas Ignotas
The kernel returns frequency in kHz, so to convert to nanosecond interval that Vulkan uses the dividend should be 100.0 and not 10.0. This fixes the GPU graph in DOOM and matches the amdgpu-pro blob. Signed-off-by: Grazvydas Ignotas Fixes: f4e499ec791 "radv: add initial non-conformant ra

Re: [Mesa-dev] [PATCH kmscube 5/6] common: Use libdrm AddFB with modifiers

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 19:22, Ben Widawsky wrote: > Note: nothing happens here yet since LINEAR == 0. Suggestion for the subject common: use drmModeAddFB2* API over the legacy drmModeAddFB one > --- > configure.ac | 2 +- > drm-common.c | 37 + > 2 files chan

Re: [Mesa-dev] [PATCH kmscube 6/6] common: Give cmdline parameter for forcing modifiers

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 19:22, Ben Widawsky wrote: > --- > common.c | 13 - > common.h | 11 ++- > kmscube.c | 14 +++--- > 3 files changed, 29 insertions(+), 9 deletions(-) > > diff --git a/common.c b/common.c > index e63bb39..eaaa9a4 100644 > --- a/common.c > +++ b/com

[Mesa-dev] [PATCH 02/21] anv/cmd_buffer: Use the device allocator for QueueSubmit

2017-04-14 Thread Jason Ekstrand
The command is really operating on a Queue not a command buffer and the nearest object to that with an allocator is VkDevice. Cc: "17.0" --- src/intel/vulkan/anv_batch_chain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/inte

[Mesa-dev] [PATCH 00/21] anv: Add support for VK_KHX_external*

2017-04-14 Thread Jason Ekstrand
This patch series adds support for a bunch of the VK_KHX_external extensions. This is mostly a re-send but there are a few bugfixes tucked in here and there are also some new patches. Changes of note: 1) It's been freshly rebased on master 2) The BO cache has undergone quite a few bugfixes.

[Mesa-dev] [PATCH 03/21] anv: Set EXEC_OBJECT_ASYNC when available

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_allocator.c | 3 +++ src/intel/vulkan/anv_device.c| 5 + src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/anv_wsi.c | 1 + 4 files changed, 10 insertions(+) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index 784191

[Mesa-dev] [PATCH 04/21] anv: Refactor device_get_cache_uuid into physical_device_init_uuids

2017-04-14 Thread Jason Ekstrand
Reviewed-by: Chad Versace --- src/intel/vulkan/anv_device.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 079b0c5..ad10531 100644 --- a/src/intel/vulkan/anv_device.c +++ b/sr

[Mesa-dev] [PATCH 01/21] anv: Add the pci_id into the shader cache UUID

2017-04-14 Thread Jason Ekstrand
This prevents a user from using a cache created on one hardware generation on a different one. Of course, with Intel hardware, this requires moving their drive from one machine to another but it's still possible and we should prevent it. Reviewed-by: Chad Versace --- src/intel/vulkan/anv_device

[Mesa-dev] [PATCH 05/21] anv/physical_device: Rename uuid to pipeline_cache_uuid

2017-04-14 Thread Jason Ekstrand
We're about to have more UUIDs for different things so this one really needs to be properly labeled. Reviewed-by: Chad Versace --- src/intel/vulkan/anv_device.c | 5 +++-- src/intel/vulkan/anv_pipeline_cache.c | 4 ++-- src/intel/vulkan/anv_private.h| 2 +- 3 files changed, 6 ins

[Mesa-dev] [PATCH 06/21] anv: Implement VK_KHX_external_memory_capabilities

2017-04-14 Thread Jason Ekstrand
From: Chad Versace This is a complete but trivial implementation. It's trivial becasue We support no external memory capabilities yet. Most of the real work in this commit is in reworking the UUIDs advertised by the driver. v2 (chadv): - Fix chain traversal in vkGetPhysicalDeviceImageFormatPr

[Mesa-dev] [PATCH 07/21] anv: Implement VK_KHX_external_memory

2017-04-14 Thread Jason Ekstrand
This is the trivial implementation that just exposes the extension string but exposes zero external handle types. Reviewed-by: Chad Versace --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + 2 files changed, 5 insertions(+) diff --git a/src/inte

[Mesa-dev] [PATCH 08/21] anv/allocator: Add a BO cache

2017-04-14 Thread Jason Ekstrand
This cache allows us to easily ensure that we have a unique anv_bo for each gem handle. We'll need this in order to support multiple-import of memory objects and semaphores. v2 (Jason Ekstrand): - Reject BO imports if the size doesn't match the prime fd size as reported by lseek(). --- src/i

[Mesa-dev] [PATCH 11/21] anv: Move queues, events, and semaphores to their own file

2017-04-14 Thread Jason Ekstrand
Things are about to get more complicated, especially as far as semaphores are concerned. Reviewed-by: Chad Versace --- src/intel/Makefile.sources| 1 + src/intel/vulkan/anv_device.c | 484 --- src/intel/vulkan/anv_queue.c | 515 +

[Mesa-dev] [PATCH 10/21] anv: Implement VK_KHX_external_memory_fd

2017-04-14 Thread Jason Ekstrand
This commit just exposes the memory handle type. There's interesting we need to do here for images. So long as the user doesn't set any crazy environment variables such as INTEL_DEBUG=nohiz, all of the compression formats etc. should "just work" at least for opaque handle types. v2 (chadv): -

[Mesa-dev] [PATCH 13/21] anv: Implement VK_KHX_external_semaphore_capabilities

2017-04-14 Thread Jason Ekstrand
This just stubs things out. Real external semaphore support will come with VK_KHX_external_semaphore_fd. --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_queue.c| 13 + 3 files changed, 18 insertion

[Mesa-dev] [PATCH 09/21] anv: Use the BO cache for DeviceMemory allocations

2017-04-14 Thread Jason Ekstrand
Reviewed-by: Chad Versace --- src/intel/vulkan/anv_device.c | 27 --- src/intel/vulkan/anv_image.c | 2 +- src/intel/vulkan/anv_intel.c | 15 ++- src/intel/vulkan/anv_private.h | 4 +++- src/intel/vulkan/anv_wsi.c | 8 5 files changed, 30 i

[Mesa-dev] [PATCH 12/21] anv: Add a real semaphore struct

2017-04-14 Thread Jason Ekstrand
It's just a dummy for now, but we'll flesh it out as needed for external semaphores. --- src/intel/vulkan/anv_private.h | 28 src/intel/vulkan/anv_queue.c | 32 ++-- 2 files changed, 54 insertions(+), 6 deletions(-) diff --git a/src/intel

[Mesa-dev] [PATCH 14/21] anv: Implement VK_KHX_external_semaphore

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_queue.c| 8 3 files changed, 13 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 41e0fb3..b85cd40 100644 ---

[Mesa-dev] [PATCH 15/21] anv: Pull the guts of cmd_buffer_execbuf into a helper

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 59 ++ 1 file changed, 35 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 3e9fa4c..136f273 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/

[Mesa-dev] [HACK 19/21] anv: Set context priorities based on queue priorities

2017-04-14 Thread Jason Ekstrand
This patch will never be committed because Vulkan queue priorities are supposed to be local to the device and not cross process boundaries. --- src/intel/vulkan/anv_device.c| 12 src/intel/vulkan/anv_gem.c | 13 + src/intel/vulkan/anv_gem_stubs.c | 7 +++ s

[Mesa-dev] [PATCH 18/21] anv: Implement support for exporting semaphores as FENCE_FD

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 96 -- src/intel/vulkan/anv_device.c | 25 ++ src/intel/vulkan/anv_gem.c | 36 ++ src/intel/vulkan/anv_private.h | 24 +++--- src/intel/vulkan/anv_queue.c | 73 ++

[Mesa-dev] [PATCH 17/21] anv/gem: Use EXECBUFFER2_WR when the FENCE_OUT flag is set

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 185086f..1392bf4 100644 --- a/src/intel/vulkan/anv_gem.c +++ b/src/intel/vulkan/anv_gem.c @@ -185,7 +185,10 @@ int anv_gem_execbuffe

[Mesa-dev] [PATCH 16/21] anv: Implement VK_KHX_external_semaphore_fd

2017-04-14 Thread Jason Ekstrand
This implementation allocates a 4k BO for each semaphore that can be exported using OPAQUE_FD and uses the kernel's already-existing synchronization mechanism on BOs. --- src/intel/vulkan/anv_batch_chain.c | 53 ++-- src/intel/vulkan/anv_device.c | 4 + src/intel/vulkan/a

[Mesa-dev] [RFC 20/21] anv/gem: Add a drm syncobj support

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_gem.c | 79 src/intel/vulkan/anv_gem_stubs.c | 24 src/intel/vulkan/anv_private.h | 4 ++ 3 files changed, 107 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index e331fbb..

[Mesa-dev] [RFC 21/21] anv: Use DRM sync objects for external semaphores when available

2017-04-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 69 src/intel/vulkan/anv_device.c | 2 + src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_queue.c | 93 -- 4 files changed, 148 insertions(+), 24 deletions(-) di

Re: [Mesa-dev] [PATCH] swr: add linux to scons build

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 20:17, George Kyriazis wrote: > Make swr compile for both linux and windows. > --- > src/gallium/drivers/swr/SConscript| 7 +-- > src/gallium/targets/libgl-xlib/SConscript | 2 +- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/drive

[Mesa-dev] [PATCH v3 3/4] vc4: Use runtime CPU detection for whether NEON is available.

2017-04-14 Thread Eric Anholt
This will allow Raspbian's ARMv6 builds to take advantage of the new NEON code, and could prevent problems if vc4 ends up getting used on a v7 CPU without NEON. --- src/gallium/drivers/vc4/vc4_screen.c | 3 +++ src/gallium/drivers/vc4/vc4_tiling.h | 25 + 2 files changed,

[Mesa-dev] [PATCH v3 2/4] vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.

2017-04-14 Thread Eric Anholt
Android.mk was setting the flag across the entire driver, so we didn't have non-NEON versions getting built. This was going to be a problem with the next commit, when I start auto-detecting NEON support and use the non-NEON version when appropriate. --- src/gallium/drivers/vc4/Android.mk

[Mesa-dev] [PATCH v3 1/4] gallium: Enable ARM NEON CPU detection.

2017-04-14 Thread Eric Anholt
I wrote this code with reference to pixman, though I've only decided to cover Linux (what I'm testing) and Android (seems obvious enough). Linux has getauxval() as a cleaner interface to the /proc entry, but it's more glibc-specific and I didn't want to add detection for that. This will be used t

[Mesa-dev] [PATCH v3 4/4] vc4: Only build the NEON code on arm32.

2017-04-14 Thread Eric Anholt
NEON is sufficiently different on arm64 that we can't just reuse this code. Disable it on arm64 for now. Signed-off-by: Eric Anholt --- src/gallium/drivers/vc4/vc4_tiling_lt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_tiling_lt.c b/src/

Re: [Mesa-dev] [PATCH] swr: update gallium driver docs

2017-04-14 Thread Emil Velikov
On 13 April 2017 at 19:41, Tim Rowley wrote: > --- > src/gallium/docs/source/drivers/openswr.rst | 2 +- > src/gallium/docs/source/drivers/openswr/usage.rst | 9 +++-- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/docs/source/drivers/openswr.rst > b/sr

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-14 Thread Emil Velikov
On 14 April 2017 at 10:38, Yu, Qiang wrote: > > Hi Emil, > >> What happened with the idea of reusing your existing amdgpu_dri.so ? >> As mentioned before the DRI loader (libgbm) <> DRI driver (foo_dri.so) >> interface is stable, so things should just work. > Sorry for the late reply. I've asked ou

Re: [Mesa-dev] [PATCH] radv: report timestampPeriod correctly

2017-04-14 Thread Bas Nieuwenhuizen
For some reason I thought it did it in 10 KHz. Reviewed-by: Bas Nieuwenhuizen On Fri, Apr 14, 2017 at 7:17 PM, Grazvydas Ignotas wrote: > The kernel returns frequency in kHz, so to convert to nanosecond > interval that Vulkan uses the dividend should be 100.0 and not > 10.0. > > This fi

Re: [Mesa-dev] [PATCH] radv: remove irrelevant comment

2017-04-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Apr 14, 2017 at 7:17 PM, Grazvydas Ignotas wrote: > A leftover from anv. > > Signed-off-by: Grazvydas Ignotas > --- > src/amd/vulkan/radv_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_device.c b/src/

Re: [Mesa-dev] [PATCH v3 4/4] vc4: Only build the NEON code on arm32.

2017-04-14 Thread Emil Velikov
On 14 April 2017 at 18:47, Eric Anholt wrote: > NEON is sufficiently different on arm64 that we can't just reuse this > code. Disable it on arm64 for now. > > Signed-off-by: Eric Anholt > --- > src/gallium/drivers/vc4/vc4_tiling_lt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH v3 4/4] vc4: Only build the NEON code on arm32.

2017-04-14 Thread Eric Anholt
Emil Velikov writes: > On 14 April 2017 at 18:47, Eric Anholt wrote: >> NEON is sufficiently different on arm64 that we can't just reuse this >> code. Disable it on arm64 for now. >> >> Signed-off-by: Eric Anholt >> --- >> src/gallium/drivers/vc4/vc4_tiling_lt.c | 4 ++-- >> 1 file changed, 2

Re: [Mesa-dev] [PATCH] swr: add linux to scons build

2017-04-14 Thread Kyriazis, George
On Apr 14, 2017, at 12:44 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: On 13 April 2017 at 20:17, George Kyriazis mailto:george.kyria...@intel.com>> wrote: Make swr compile for both linux and windows. --- src/gallium/drivers/swr/SConscript| 7 +-- src/gallium/targets/lib

  1   2   >