Re: [Mesa-dev] [PATCH] intel/vec4: Add some fall through comments

2017-04-03 Thread Matt Turner
Thank you. These coverity warnings have been coming back repeatedly it seems. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] intel/vec4: Add some fall through comments

2017-04-03 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 7:24 PM, Jason Ekstrand wrote: > --- > src/intel/compiler/brw_vec4_nir.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/intel/compiler/brw_vec4_nir.cpp > b/src/intel/compiler/brw_vec4_nir.cpp > index 2384265..613c695 100644 > --- a/src/intel/compiler/br

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

2017-04-03 Thread Timothy Arceri
I've pushed this. Thanks! In future please add the version to the subject when sending new revisions. You can do this with the -v option when using git send-email e.g -v2 will result in [PATCH v2] Also please add changes to the patch since v1 in the commit message. e.g. V2: set batch->used =

Re: [Mesa-dev] [PATCH] intel/vec4: Add some fall through comments

2017-04-03 Thread Jason Ekstrand
On Mon, Apr 3, 2017 at 4:43 PM, Ilia Mirkin wrote: > On Mon, Apr 3, 2017 at 7:24 PM, Jason Ekstrand > wrote: > > --- > > src/intel/compiler/brw_vec4_nir.cpp | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/src/intel/compiler/brw_vec4_nir.cpp > b/src/intel/compiler/brw_vec4_nir

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

2017-04-03 Thread Chad Versace
On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match t

Re: [Mesa-dev] [PATCH v2 08/18] anv: Use the BO cache for DeviceMemory allocations

2017-04-03 Thread Chad Versace
On Mon 13 Mar 2017, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 27 --- > src/intel/vulkan/anv_image.c | 2 +- > src/intel/vulkan/anv_intel.c | 14 ++ > src/intel/vulkan/anv_private.h | 4 +++- > src/intel/vulkan/anv_wsi.c | 6 +++--

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

2017-04-03 Thread Jason Ekstrand
On Mon, Apr 3, 2017 at 5:19 PM, Chad Versace wrote: > On Wed 15 Mar 2017, Jason Ekstrand wrote: > > This cache allows us to easily ensure that we have a unique anv_bo for > > each gem handle. We'll need this in order to support multiple-import of > > memory objects and semaphores. > > > > v2 (Ja

Re: [Mesa-dev] [PATCH v2 09/18] anv: Implement VK_KHX_external_memory_fd

2017-04-03 Thread Chad Versace
On Mon 13 Mar 2017, Jason Ekstrand wrote: > v2 (chadv): > - Rebase. > - Fix vkGetPhysicalDeviceImageFormatProperties2KHR when > handleType == 0. > - Move handleType-independency comments out of handleType-switch, in > vkGetPhysicalDeviceExternalBufferPropertiesKHX. Reduces diff in >

Re: [Mesa-dev] [PATCH v2 10/18] anv: Move queues, events, and semaphores to their own file

2017-04-03 Thread Chad Versace
On Mon 13 Mar 2017, Jason Ekstrand wrote: > Things are about to get more complicated, especially as far as > semaphores are concerned. > --- > src/intel/Makefile.sources| 1 + > src/intel/vulkan/Makefile.sources | 86 +++ > src/intel/vulkan/anv_device.c | 440 ---

Re: [Mesa-dev] [PATCH 07/19] tgsi: add BALLOT/READ_* opcodes

2017-04-03 Thread Boyan Ding
2017-04-01 1:14 GMT+08:00 Nicolai Hähnle : > From: Ilia Mirkin > > v2 (Nicolai): > - BALLOT isn't per-channel > - expand the documentation (also for VOTE_*) > > Signed-off-by: Ilia Mirkin > Signed-off-by: Nicolai Hähnle > --- > src/gallium/auxiliary/tgsi/tgsi_info.c | 6 +-- > src/gallium/

Re: [Mesa-dev] [PATCH 07/19] tgsi: add BALLOT/READ_* opcodes

2017-04-03 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 10:01 PM, Boyan Ding wrote: > 2017-04-01 1:14 GMT+08:00 Nicolai Hähnle : >> From: Ilia Mirkin >> >> v2 (Nicolai): >> - BALLOT isn't per-channel >> - expand the documentation (also for VOTE_*) >> >> Signed-off-by: Ilia Mirkin >> Signed-off-by: Nicolai Hähnle >> --- >> src

[Mesa-dev] [PATCH] addrlib: don't use linear aligned when pow2Pad is selected.

2017-04-03 Thread Dave Airlie
From: Dave Airlie The below commit caused a regression on radv with 1D textures, this was because the base level for these small textures was being degraded to a linear level due to this code. This stops the degradation to linear when the pow2Pad bit it set (this is set when there are miplevels).

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

2017-04-03 Thread Bartosz Tomczyk
Thank you Timothy. Sorry about that, I'm still quite to new git/Mesa workflow. I will do better in future. On Apr 4, 2017 01:54, "Timothy Arceri" wrote: I've pushed this. Thanks! In future please add the version to the subject when sending new revisions. You can do this with the -v option whe

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

2017-04-03 Thread Timothy Arceri
On 04/04/17 13:54, Bartosz Tomczyk wrote: Thank you Timothy. Sorry about that, I'm still quite to new git/Mesa workflow. I will do better in future. Not a problem :) Thanks for the patches. On Apr 4, 2017 01:54, "Timothy Arceri" mailto:tarc...@itsqueeze.com>> wrote: I've pushed this.

[Mesa-dev] two radv regressions with latest addrlib import

2017-04-03 Thread Dave Airlie
Just documenting these here, I'm out for a few days so might not get time to fix them: I've sent a patch for the first. 1. Small 1D mipmapped textures tests all failed after Fixes: 36149998 amdgpu/addrlib: Rewrite tile mode optimization code This looks like the 1D base level gets reduced to a li

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-03 Thread Thomas Hellstrom
On 04/03/2017 11:09 PM, Rob Clark wrote: > On Mon, Apr 3, 2017 at 4:57 PM, Rob Clark wrote: >> On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom >> wrote: >>> On 04/03/2017 07:33 PM, Thomas Hellstrom wrote: On 04/03/2017 07:13 PM, Rob Clark wrote: > On Mon, Apr 3, 2017 at 12:56 PM, Thoma

[Mesa-dev] very strange intermittent frame-dropping

2017-04-03 Thread Luke Kenneth Casson Leighton
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848895 there's a really strange and comprehensively cross-application intermittent bug that's only occurring on opengl-based applications, that's been introduced some time in the past year. to be absolutely honest nobody's even sure it's actually

[Mesa-dev] [Bug 68380] flink race on wayland

2017-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68380 --- Comment #1 from Pekka Paalanen --- I would assume this is no longer a problem after we started using file descriptors instead of flink names in wl_drm? Is it even worth fixing the flink path, considering it's insecure to begin with? -- You

<    1   2