[Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

2017-02-22 Thread Iago Toral Quiroga
From: Iago Toral Quiroga From ARB_post_depth_coverage: "This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. This feature can be enabled with the following layout qual

[Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filter.c b/src/gallium/auxiliary/vl/vl_bicubic_filter.c index 570f153..275dd2a 100644 --- a/src/gallium/a

Re: [Mesa-dev] [PATCH] radv: fetch sample index via fmask for image coord as well.

2017-02-22 Thread Bas Nieuwenhuizen
On Wed, Feb 22, 2017 at 5:31 AM, Dave Airlie wrote: > From: Dave Airlie > > This follows the txf_ms code, I can't figure out why amdgpu-pro > doesn't do this in their shaders, they must know someone we don't. > > This fixes: > dEQP-VK.pipeline.multisample_shader_builtin.sample_id.* > > Signed-off

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Christian König
Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've encountered while looking through and testing the video code in preparation for a virtual hardware video driver. Reviewed-by: Christian König for the whole set.

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 09:56 AM, Christian König wrote: > Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: >> A couple of fixes / improvements for things I've encountered while >> looking >> through and testing the video code in preparation for a virtual >> hardware video >> driver. > > Reviewed-by: Christi

Re: [Mesa-dev] [PATCH 3/4] gallium/hud: prevent an infinite loop

2017-02-22 Thread Nicolai Hähnle
On 21.02.2017 22:09, Marek Olšák wrote: From: Marek Olšák v2: use UINT64_MAX / 11 Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/hud/hud_context.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxilia

Re: [Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

2017-02-22 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 21.02.2017 22:05, Marek Olšák wrote: From: Marek Olšák This fixes: vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && "Pass ID not registered!"' failed. v2: use list_

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

2017-02-22 Thread Grazvydas Ignotas
On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: > If there was more than a single directory in the .cache/mesa dir > then it would only remove one (or none) of the directories. > > Apparently Valgrind was also reporting: > Conditional jump or move depends on uninitialised value uninitialis

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 07:23, Michel Dänzer wrote: On 22/02/17 12:45 PM, Timothy Arceri wrote: +get_disk_shader_cache +^ + +Returns a pointer to driver-specific on-disk shader cache. If the driver +failed to create the cache or does not support an on-disk shader cache NULL is +return

Re: [Mesa-dev] [PATCH 4/8] st/mesa: implement a tgsi on-disk shader cache

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 04:45, Timothy Arceri wrote: Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 + src/mesa/state_tracker/st_program.c| 27 +- s

Re: [Mesa-dev] [PATCH 6/8] ddebug/rbug/trace: add get_disk_shader_cache() to pass-throughs

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 04:45, Timothy Arceri wrote: --- src/gallium/drivers/ddebug/dd_screen.c | 9 + src/gallium/drivers/rbug/rbug_screen.c | 9 + src/gallium/drivers/trace/tr_screen.c | 21 + 3 files changed, 39 insertions(+) diff --git a/src/gallium/drivers/ddeb

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 04:45, Timothy Arceri wrote: For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. Reviewed-by: Marek Olšák Reviewed-by: Edward O'Callaghan --- src/gallium/drivers/radeon/r600_pipe

Re: [Mesa-dev] V4 TGSI on-disk shader cache

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 04:45, Timothy Arceri wrote: Changes in V4: - split tgsi cache code into its own file - add missing fallback for tgsi cache miss - share the sha1 generated by the load function with the store function like in the glsl ir cache. - add get_disk_shader_cache() to the pass-throughs -

[Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

2017-02-22 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- v2: make sure the list is in the order C's strcmp uses (Ilia) Ilia: I used LC_ALL instead of LANG, as it takes precedence (ie. LANG=C in this script would be overridden by LC_ALL=en_US in the environment). --- src/glx/tests/Makefile.am

[Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-22 Thread Samuel Iglesias Gonsálvez
From IVB PRM, SURFACE_STATE::Height: "For typed buffer and structured buffer surfaces, the number of entries in the buffer ranges from 1 to 2^27 . For raw buffer surfaces, the number of entries in the buffer is the number of bytes which can range from 1 to 2^30." The minimum value is 1, accord

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

2017-02-22 Thread Timothy Arceri
On 22/02/17 21:43, Grazvydas Ignotas wrote: On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: If there was more than a single directory in the .cache/mesa dir then it would only remove one (or none) of the directories. Apparently Valgrind was also reporting: Conditional jump or move dep

[Mesa-dev] [PATCH 0/3] anv/blorp/i965: pipe control blumping

2017-02-22 Thread Lionel Landwerlin
Hi, While looking at blorp, I noticed we weren't looking at blorp's pipe controls instructions in the i965 driver. As far as I can tell this isn't a problem with regards to workarounds at the moment, but it feels like we should have them centralized just in case something changes. We can also cen

[Mesa-dev] [PATCH 1/3] anv/blorp/i965: blump blorp's pipe controls back into the embedding driver

2017-02-22 Thread Lionel Landwerlin
At the moment, we don't seem to miss any workaround from having blorp's pipe controls not tracked by the embedding driver, but this should make things more robust if something new comes up. Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_genX_exec.h | 18 --

[Mesa-dev] [PATCH 2/3] anv: centralize PIPE_CONTROLs

2017-02-22 Thread Lionel Landwerlin
This allows us to monitor pipe controls and apply workarounds in a single location if needed. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_genX.h| 26 ++ src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/genX_blorp_exec.c | 4 ++-- s

[Mesa-dev] [PATCH 3/3] anv: implement WaCsStallAtEveryFourthPipecontrol for gen7

2017-02-22 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_batch_chain.c | 5 + src/intel/vulkan/anv_pipeline.c| 2 ++ src/intel/vulkan/anv_private.h | 4 src/intel/vulkan/genX_cmd_buffer.c | 21 +++-- 4 files changed, 30 insertions(+), 2 deletions(-) diff --gi

[Mesa-dev] [Bug 99604] kwin_x11 disabling compositing with mesa 17

2017-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99604 --- Comment #1 from Fabio Coatti --- same issue with mesa 17.0.0 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Marc Dietrich
Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. > > Reviewed-by: Marek Olšák > Reviewed-by: Edward O'Callaghan > ---

[Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

2017-02-22 Thread Thomas Hellstrom
mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so before trying the reallocation, check whether we can instead

[Mesa-dev] [PATCH 2/2] st/va: Fix up YV12 to NV12 putImage conversion

2017-02-22 Thread Thomas Hellstrom
Use the utility u_copy_nv12_from_yv12 to implement this similarly to how it's been done in the VPAU state tracker. The old code mixed up planes and fields and didn't correctly handle video surfaces in interlaced format. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/util/u_video.h |

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

2017-02-22 Thread Christian König
Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom: mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so before tr

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 03:00 PM, Christian König wrote: > Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom: >> mplayer likes putting YV12 data, and if there is a buffer format >> mismatch, >> the vdpau state tracker would try to reallocate the video surface as an >> YV12 surface. A virtual driver doesn't lik

[Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

2017-02-22 Thread Iago Toral Quiroga
This fixes a number of new CTS tests that would crash otherwise: dEQP-VK.pipeline.render_to_image.* --- src/intel/vulkan/genX_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 40a72f4..c

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Emil Velikov
On 22 February 2017 at 13:31, Marc Dietrich wrote: > Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: >> For gpu generations that use LLVM we create a timestamp string >> containing both the LLVM and Mesa build times, otherwise we just >> use the Mesa build time. >> >> Reviewed-

[Mesa-dev] [Bug 99604] kwin_x11 disabling compositing with mesa 17

2017-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99604 Emil Velikov changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Marc Dietrich
Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: > On 22 February 2017 at 13:31, Marc Dietrich wrote: > > Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: > >> For gpu generations that use LLVM we create a timestamp string > >> containing both the LLVM and Mesa

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Emil Velikov
On 22 February 2017 at 09:30, Thomas Hellstrom wrote: > On 02/22/2017 09:56 AM, Christian König wrote: >> Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: >>> A couple of fixes / improvements for things I've encountered while >>> looking >>> through and testing the video code in preparation for a

Re: [Mesa-dev] [PATCH] anv/Makefile: Gather all the genX files into one place

2017-02-22 Thread Emil Velikov
On 22 February 2017 at 03:38, Jason Ekstrand wrote: > While we're here, we also fix the alphabetization of the list of > genx_* files. Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedes

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

2017-02-22 Thread Lionel Landwerlin
I can't reproduce on the vulkan-cts-next-dev (I just pull -r, so I shouldn't miss anything right?). On 22/02/17 14:45, Iago Toral Quiroga wrote: This fixes a number of new CTS tests that would crash otherwise: dEQP-VK.pipeline.render_to_image.* --- src/intel/vulkan/genX_cmd_buffer.c | 3 ++-

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

2017-02-22 Thread Michel Dänzer
On 22/02/17 07:58 PM, Nicolai Hähnle wrote: > On 22.02.2017 07:23, Michel Dänzer wrote: >> On 22/02/17 12:45 PM, Timothy Arceri wrote: >>> >>> +get_disk_shader_cache >>> +^ >>> + >>> +Returns a pointer to driver-specific on-disk shader cache. If the >>> driver >>> +failed to cre

[Mesa-dev] [PATCH 1/2] st/vdpau: Provide YV12 to NV12 putBits conversion v2

2017-02-22 Thread Thomas Hellstrom
mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so if we can't support YV12, try an YV12 to NV12 conversion ins

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 04:00 PM, Emil Velikov wrote: > On 22 February 2017 at 09:30, Thomas Hellstrom wrote: >> On 02/22/2017 09:56 AM, Christian König wrote: >>> Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've encountered while looking throu

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Christian König
Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 February 2017 at 09:30, Thomas Hellstrom wrote: On 02/22/2017 09:56 AM, Christian König wrote: Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've

[Mesa-dev] [PATCH 1/1] clover: Dump linked module to a different file

2017-02-22 Thread Jan Vesely
This allows to pass the generated files directly to llc or bugpoint. Note that if program links multiple binaries they will still be in the same file, the module name is "link". Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 ++-- 1 file changed, 2 inser

[Mesa-dev] [PATCH 4/4] docs: update features.txt for GL_ARB_clear_texture with llvmpipe and softpipe

2017-02-22 Thread Lars Hamre
Signed-off-by: Lars Hamre --- CC: Roland Scheidegger NOTE: someone with access will need to commit this post review process docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 01315a0..d7828b1 100644 --- a/do

[Mesa-dev] [PATCH 2/4] llvmpipe: enable clear_texture with util_clear_texture

2017-02-22 Thread Lars Hamre
Passes all corresponding piglit tests. Signed-off-by: Lars Hamre --- CC: Roland Scheidegger NOTE: someone with access will need to commit this post review process src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- src/gallium/drivers/llvmpipe/lp_surface.c | 3 ++- 2 files changed, 4 i

[Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

2017-02-22 Thread Lars Hamre
v3: have util_clear_texture mirror the pipe function (Roland Scheidegger) v2: rework util clear functions such that they operate on a resource instead of a surface (Roland Scheidegger) Creates a util_clear_texture function for implementing the GL_ARB_clear_texture in softpipe and llvmpipe. Si

[Mesa-dev] [PATCH 3/4] softpipe: enable clear_texture with util_clear_texture

2017-02-22 Thread Lars Hamre
Passes all corresponding piglit tests. Signed-off-by: Lars Hamre --- CC: Roland Scheidegger NOTE: someone with access will need to commit this post review process src/gallium/drivers/softpipe/sp_screen.c | 3 ++- src/gallium/drivers/softpipe/sp_texture.c | 2 ++ 2 files changed, 4 in

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 04:46 PM, Christian König wrote: > Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: >> On 02/22/2017 04:00 PM, Emil Velikov wrote: >>> On 22 February 2017 at 09:30, Thomas Hellstrom >>> wrote: On 02/22/2017 09:56 AM, Christian König wrote: > Am 21.02.2017 um 21:52 schrieb Th

Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-22 Thread Jason Ekstrand
Seems reasonable Are you sure this isn't somehow required on old hardware? Reviewed-by: Jason Ekstrand On Wed, Feb 22, 2017 at 3:39 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From IVB PRM, SURFACE_STATE::Height: > > "For typed buffer and structured buffer surfaces, the numb

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Christian König
Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: On 02/22/2017 04:46 PM, Christian König wrote: Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 February 2017 at 09:30, Thomas Hellstrom wrote: On 02/22/2017 09:56 AM, Christian König wrote: A

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 05:54 PM, Christian König wrote: > Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: >> On 02/22/2017 04:46 PM, Christian König wrote: >>> Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: > On 22 February 2017 at 09:30, Thomas Hellst

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

2017-02-22 Thread Jason Ekstrand
On Wed, Feb 22, 2017 at 6:45 AM, Iago Toral Quiroga wrote: > This fixes a number of new CTS tests that would crash otherwise: > dEQP-VK.pipeline.render_to_image.* > --- > src/intel/vulkan/genX_cmd_buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/vulka

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Emil Velikov
On 22 February 2017 at 14:57, Marc Dietrich wrote: > Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: >> On 22 February 2017 at 13:31, Marc Dietrich wrote: >> > Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: >> >> For gpu generations that use LLVM we create a

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Christian König
Am 22.02.2017 um 18:05 schrieb Thomas Hellstrom: On 02/22/2017 05:54 PM, Christian König wrote: Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: On 02/22/2017 04:46 PM, Christian König wrote: Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 F

Re: [Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

2017-02-22 Thread Robert Bragg
On Wed, Feb 22, 2017 at 1:24 AM, Kenneth Graunke wrote: > On Wednesday, February 15, 2017 1:37:36 PM PST Robert Bragg wrote: >> Instead of using the same backend interface as AMD_performance_monitor >> this defines a dedicated INTEL_performance_query interface that is >> modelled more on the ARB_q

Re: [Mesa-dev] [PATCH v2] i965: Implement INTEL_performance_query backend

2017-02-22 Thread Robert Bragg
On Wed, Feb 22, 2017 at 1:26 AM, Kenneth Graunke wrote: > On Thursday, February 16, 2017 5:20:37 AM PST Robert Bragg wrote: > [snip] >> + switch(obj->query->kind) { > > Space after "switch" please. Oh, oops, repeated that in a few places. > > Patch 3 is: > Reviewed-by: Kenneth Graunke Thanks

Re: [Mesa-dev] [PATCH 5/8] gallium: add get_disk_shader_cache() callback

2017-02-22 Thread Nicolai Hähnle
On 22.02.2017 16:19, Michel Dänzer wrote: On 22/02/17 07:58 PM, Nicolai Hähnle wrote: On 22.02.2017 07:23, Michel Dänzer wrote: On 22/02/17 12:45 PM, Timothy Arceri wrote: +get_disk_shader_cache +^ + +Returns a pointer to driver-specific on-disk shader cache. If the driver

Re: [Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

2017-02-22 Thread Kenneth Graunke
On Wednesday, February 22, 2017 10:35:24 AM PST Robert Bragg wrote: > On Wed, Feb 22, 2017 at 1:24 AM, Kenneth Graunke > wrote: > > On Wednesday, February 15, 2017 1:37:36 PM PST Robert Bragg wrote: [snip] > >> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > >> index f3a24df589..e6

[Mesa-dev] [PATCH] st/mesa: inform the driver of framebuffer changes before compute dispatches

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle Even though compute shaders cannot access the framebuffer, there is a synchronization issue when a compute dispatch accesses a texture that was previously bound and drawn to as a framebuffer. Section 9.3 (Feedback Loops Between Textures and the Framebuffer) of the OpenGL 4.5

[Mesa-dev] [PATCH 0/4] Various memory error fixes

2017-02-22 Thread Nicolai Hähnle
Hi, this is a bunch of patches for random problems that were all found by running with -fsanitize=address. Please review! Thanks, Nicolai -- src/compiler/glsl/ast_to_hir.cpp | 55 +++- src/mesa/main/api_loopback.c | 3 +- src/mesa/main/api_validate.c

[Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle MATERIALFV may end up reading up to 4 floats from the passed parameter. This should really set a GL_INVALID_ENUM error in the cases where it matters, but does anybody really care? Found by ASAN in piglit gl-1.0-beginend-coverage. --- src/mesa/main/api_loopback.c | 3 ++- 1

[Mesa-dev] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle When determining whether the array is implicitly sized, we must avoid accessing var->data.mode (around line 5270), because var may have been deleted. Instead of adding yet another ternary condition based on earlier == NULL, refactor get_variable_being_redeclared so that we d

[Mesa-dev] [PATCH 3/4] st/glsl_to_tgsi: avoid iterating past the head of the instruction list

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle exec_node::get_prev() does not guard against going past the beginning of the list, so we need to add explicit checks here. Found by ASAN in piglit arb_shader_storage_buffer_object-rendering. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.c

[Mesa-dev] [PATCH 1/4] mesa/main: fix MultiDrawElements[BaseVertex] validation of primcount

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle primcount must be a GLsizei as in the signature for MultiDrawElements or bad things can happen. Furthermore, an error should be flagged when primcount is negative (plus there is an argument about whether it should be flagged when primcount is 0, but let's worry about that se

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

2017-02-22 Thread Chad Versace
On Mon 20 Feb 2017, Jason Ekstrand wrote: > This just enables basic MSAA compression (no fast clears) for all > multisampled surfaces. This improves the framerate of the Sascha > "multisampling" demo by 76% on my Sky Lake laptop. Running Talos on > medium settings with 8x MSAA, this improves the

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

2017-02-22 Thread Jason Ekstrand
On Wed, Feb 22, 2017 at 11:09 AM, Chad Versace wrote: > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > This just enables basic MSAA compression (no fast clears) for all > > multisampled surfaces. This improves the framerate of the Sascha > > "multisampling" demo by 76% on my Sky Lake laptop. Run

Re: [Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

2017-02-22 Thread Kyle Brenneman
On 02/20/2017 01:32 AM, Hans de Goede wrote: Hi Emil, On 16-02-17 16:38, Emil Velikov wrote: Hi Hans, On 6 February 2017 at 13:09, Hans de Goede wrote: Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices") fixed the sorting of the array initializers in g_glxglvnddispatc

[Mesa-dev] [PATCH 0/6] Removal of PIPE_CAP_USER_INDEX_BUFFERS (take 3)

2017-02-22 Thread Marek Olšák
Hi, This version is hopefully final. I moved the helper code into a separate commit and fixed a pipe_resource leak there. (thanks Brian for the clue) The rest didn't really change. Please review, Marek ___ mesa-dev mailing list mesa-dev@lists.freedes

[Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_USER_INDEX_BUFFERS

2017-02-22 Thread Marek Olšák
From: Marek Olšák all drivers support it Reviewed-by: Nicolai Hähnle --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 - src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/i915/i915_screen.c |

[Mesa-dev] [PATCH 2/6] etnaviv: add support for user index buffers

2017-02-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/etnaviv/etnaviv_context.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c b/src/gallium/drivers/etnaviv/etnaviv_contex

[Mesa-dev] [PATCH 5/6] st/mesa: assume all drivers support user index buffers

2017-02-22 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_context.c | 2 -- src/mesa/state_tracker/st_context.h | 1 - src/mesa/state_tracker/st_draw.c| 50 ++--- 3 files changed, 13 insertions(+), 40 deletions(-) diff --git a/src/mesa/st

[Mesa-dev] [PATCH 4/6] svga: implement user index buffers

2017-02-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/svga/svga_pipe_draw.c | 13 - src/gallium/drivers/svga/svga_screen.c| 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_draw.c b/src/gallium/drivers/svga/svga_pipe_draw.c index c51c

[Mesa-dev] [PATCH 1/6] gallium/util: add new helpers for user index buffer uploading

2017-02-22 Thread Marek Olšák
From: Marek Olšák v3: split from the etnaviv patch; fix new_ib.buffer leak --- src/gallium/auxiliary/util/u_helpers.c | 30 ++ src/gallium/auxiliary/util/u_helpers.h | 5 + 2 files changed, 35 insertions(+) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/

[Mesa-dev] [PATCH 3/6] freedreno: add support for user index buffers

2017-02-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/freedreno/freedreno_draw.c | 12 src/gallium/drivers/freedreno/freedreno_screen.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c b/src/gallium/drivers/freedreno/freed

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

2017-02-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 22, 2017 at 9:06 AM, Iago Toral Quiroga wrote: > From: Iago Toral Quiroga > > From ARB_post_depth_coverage: > >"This extension allows the fragment shader to control whether values in > gl_SampleMaskIn[] reflect the coverage after application o

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Marek Olšák
It would be better to return from the function in that case. Marek On Wed, Feb 22, 2017 at 9:25 AM, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh > --- > src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

2017-02-22 Thread Matt Turner
On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga wrote: > From: Iago Toral Quiroga Oops :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: > It would be better to return from the function in that case. > We can still execute it as it will display the video properly though the edges will be a bit jagged but it won't be much noticeable in most cases. Regards, Nayan > Marek > > On W

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

2017-02-22 Thread Marek Olšák
On Wed, Feb 22, 2017 at 9:11 PM, Matt Turner wrote: > On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga > wrote: >> From: Iago Toral Quiroga > > Oops :) Sneaky product placement. :) Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Marek Olšák
OK sounds good. Reviewed-by: Marek Olšák Marek On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh wrote: > On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: >> It would be better to return from the function in that case. >> > We can still execute it as it will display the video properly though

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

2017-02-22 Thread Chad Versace
On Wed 22 Feb 2017, Jason Ekstrand wrote: > On Wed, Feb 22, 2017 at 11:09 AM, Chad Versace > wrote: > > > On Mon 20 Feb 2017, Jason Ekstrand wrote: > > > This just enables basic MSAA compression (no fast clears) for all > > > multisampled surfaces. This improves the framerate of the Sascha > > >

[Mesa-dev] [PATCH] GLX: Generate the libglvnd dispatch stub functions.

2017-02-22 Thread Kyle Brenneman
This patch adds a script to generate the dispatch stubs for libglvnd, instead of using a manually-edited list of functions. This should avoid problems in the future with the stub lists getting out of sync or out of order. I put the scripts into a new src/generate/ directory, because there's some

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: inform the driver of framebuffer changes before compute dispatches

2017-02-22 Thread Marek Olšák
Makes sense. Reviewed-by: Marek Olšák Marek On Wed, Feb 22, 2017 at 7:59 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Even though compute shaders cannot access the framebuffer, there is a > synchronization issue when a compute dispatch accesses a texture that > was previously bound an

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Can you please push the patch. On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák wrote: > OK sounds good. > > Reviewed-by: Marek Olšák > > Marek > > On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh > wrote: >> On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: >>> It would be better to return from

Re: [Mesa-dev] [PATCH 0/6] Removal of PIPE_CAP_USER_INDEX_BUFFERS (take 3)

2017-02-22 Thread Brian Paul
On 02/22/2017 01:00 PM, Marek Olšák wrote: Hi, This version is hopefully final. I moved the helper code into a separate commit and fixed a pipe_resource leak there. (thanks Brian for the clue) The rest didn't really change. Please review, For the series, Reviewed-by: Brian Paul Tested-by:

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

2017-02-22 Thread Marek Olšák
For 1, 3, 4: Reviewed-by: Marek Olšák I need some time to review patch 2 unless someone else beats me to it. Marek On Wed, Feb 22, 2017 at 8:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > MATERIALFV may end up reading up to 4 floats from the passed parameter. > > This should really

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

2017-02-22 Thread Ian Romanick
I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... On February 22, 2017 11:05:26 AM Nicolai Hähnle wrote: From: Nicolai Hähnle When determining whether the array is implicitly sized, we must avoid accessing var-

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Marek Olšák
Pushed, thanks. Marek On Wed, Feb 22, 2017 at 9:20 PM, Nayan Deshmukh wrote: > Can you please push the patch. > > On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák wrote: >> OK sounds good. >> >> Reviewed-by: Marek Olšák >> >> Marek >> >> On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh >> wrote: >

Re: [Mesa-dev] [PATCH 1/1] clover: Dump linked module to a different file

2017-02-22 Thread Matt Arsenault
> On Feb 22, 2017, at 07:51, Jan Vesely wrote: > > This allows to pass the generated files directly to llc or bugpoint. > Note that if program links multiple binaries they will still be in the same > file, the module name is "link”. Can you add a counter ID or something to ensure unique files?

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Timothy Arceri
On 23/02/17 01:57, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: On 22 February 2017 at 13:31, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: For gpu generations that use LLVM we create a timestamp string con

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Matt Turner
On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. Why not use the build id for Mesa? ___

[Mesa-dev] [PATCH 2/2] st/wgl: flush with ST_FLUSH_WAIT before releasing shared contexts

2017-02-22 Thread Charmaine Lee
Before releasing a shared context, flush the context with ST_FLUSH_WAIT to make sure all commands are executed. This ensures that rendering to any shared resources is completed before they will be referenced by another context. Fixes an intermittent flickering with Photoshop. (VMware bug# 1779340)

[Mesa-dev] [PATCH 1/2] st: add ST_FLUSH_WAIT to st_context_flush()

2017-02-22 Thread Charmaine Lee
When st_context_flush() is called with ST_FLUSH_WAIT, the function will return after the fence is completed. --- src/gallium/include/state_tracker/st_api.h | 1 + src/mesa/state_tracker/st_manager.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/gallium/include/state_tracke

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Timothy Arceri
On 23/02/17 08:46, Matt Turner wrote: On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. Why not use the build id for Mesa? I would

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-22 Thread Matt Turner
On Wed, Feb 22, 2017 at 2:12 PM, Timothy Arceri wrote: > On 23/02/17 08:46, Matt Turner wrote: >> On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri >> wrote: >>> >>> For gpu generations that use LLVM we create a timestamp string >>> containing both the LLVM and Mesa build times, otherwise we just >

Re: [Mesa-dev] [PATCH] anv/blorp/clear_subpass: Only set surface clear color for fast clears

2017-02-22 Thread Jason Ekstrand
This patch is also needed for MSAA compression. On Tue, Feb 21, 2017 at 7:31 PM, Jason Ekstrand wrote: > Not all clear colors are valid. In particular, on Broadwell and > earlier, only 0/1 colors are allowed in surface state. No CTS tests are > affected outright by this because, apparently, th

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-diskcache

2017-02-22 Thread Marc Dietrich
Am Mittwoch, 22. Februar 2017, 22:27:42 CET schrieb Timothy Arceri: > On 23/02/17 01:57, Marc Dietrich wrote: > > Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: > >> On 22 February 2017 at 13:31, Marc Dietrich wrote: > >>> Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timo

[Mesa-dev] [PATCH 2/2] haiku/winsys: fix dt prototype args

2017-02-22 Thread Alexander von Gluck IV
From: Jerome Duval --- src/gallium/winsys/sw/hgl/hgl_sw_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c b/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c index 89dd547..f7bc907 100644 --- a/src/gallium/winsys/sw/hgl/hgl_sw_winsy

[Mesa-dev] [PATCH 1/2] haiku: build fixes around debug defines

2017-02-22 Thread Alexander von Gluck IV
From: Jerome Duval --- src/gallium/auxiliary/util/u_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index 7da7f53..63940b7 100644 --- a/src/gallium/auxiliary/util/u_debug.h +++ b/src/gall

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

2017-02-22 Thread Timothy Arceri
On 23/02/17 07:44, Ian Romanick wrote: I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... It looks like the patches are still waiting on a review: https://patchwork.freedesktop.org/series/19382/ On February 22,

[Mesa-dev] [PATCH 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-22 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_en

[Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions - don

[Mesa-dev] [PATCH 01/13] anv: anv_entrypoints_gen.py: use a main function

2017-02-22 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 93

[Mesa-dev] [PATCH 00/13] cleanup anv_entrpoints_gen.py

2017-02-22 Thread Dylan Baker
There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [PATCH 05/13] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 + 1 file changed, 50 inserti

  1   2   >