[Mesa-dev] [PATCH] mesa/main: fix meta caller of _mesa_ClampColor

2017-01-18 Thread Nicolai Hähnle
From: Nicolai Hähnle Since _mesa_ClampColor properly checks for support of the API function now, it's meta callers need to check support as well. Fixes: 963311b71f ("mesa/main: fix version/extension checks in _mesa_ClampColor") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99401 Tested

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Michel Dänzer
On 17/01/17 09:55 PM, Christian König wrote: > Module: Mesa > Branch: master > Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bfdea99c7b487d2c38d6dd7b88fb44810ef75a > > Author: Nayan Deshmukh > Date: Wed Jan 11 22:45:14 2017 +053

[Mesa-dev] [PATCH] radeonsi: fix texture gather on stencil textures

2017-01-18 Thread Nicolai Hähnle
From: Nicolai Hähnle At least on VI, texture gather doesn't work with a 24_8 data format, so use 8_8_8_8 and a modified swizzle instead. A bit of background: When creating a GL_STENCIL_INDEX8 texture, we select the X24S8 pipe format because we don't support stencil-only render targets properly.

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Steven Newbury
On Mon, 2017-01-16 at 16:52 +0300, Vladislav Egorov wrote: > > 16.01.2017 16:13, Emil Velikov пишет: > > Hi Vladislav, > > > > On 14 January 2017 at 01:50, Vladislav Egorov > > wrote: > > > 14.01.2017 01:45, Timothy Arceri пишет: > > > > I'm asking for a chance to test before we jump in, its pro

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Timothy Arceri
On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote: > On Mon, 2017-01-16 at 16:52 +0300, Vladislav Egorov wrote: > > > > 16.01.2017 16:13, Emil Velikov пишет: > > > Hi Vladislav, > > > > > > On 14 January 2017 at 01:50, Vladislav Egorov > > om > > > > wrote: > > > > 14.01.2017 01:45, Timoth

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Christian König
Am 18.01.2017 um 09:25 schrieb Michel Dänzer: On 17/01/17 09:55 PM, Christian König wrote: Module: Mesa Branch: master Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bfdea99c7b487d2c38d6dd7b88fb44810ef75a Author: Nayan Deshmukh Date

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Michel Dänzer
On 18/01/17 06:47 PM, Christian König wrote: > Am 18.01.2017 um 09:25 schrieb Michel Dänzer: >> On 17/01/17 09:55 PM, Christian König wrote: >>> Module: Mesa >>> Branch: master >>> Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a >>> URL: >>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bf

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Steven Newbury
On Wed, 2017-01-18 at 20:43 +1100, Timothy Arceri wrote: > On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote [SNIP] > > > > Why not leave in a build time option for whichever is the fastest > > (non- > > OpenSSL) external SHA1 implementation but default or fallback to > > whatever gets pulle

[Mesa-dev] [v2 2/4] i965: Make depth clear flushing more explicit

2017-01-18 Thread Topi Pohjolainen
Current blorp logic issues unconditional "flush everything" (see brw_emit_mi_flush()) after each render. For example, all blits issue this unconditionally which shouldn't be needed if they set render cache properly os that subsequent renders do necessary flushing before drawing. In case of piglit:

[Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Topi Pohjolainen
by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). The latter splits the flush in two: brw_emit_pipe_control_flush(brw, PIPE_CONTROL_DEPTH_CACHE_FLUSH | PIPE_CONTROL_RENDER_TARGET_FLUSH |

Re: [Mesa-dev] [RFC] st/mesa: Add both front and back buffers for double-buffer visuals

2017-01-18 Thread Józef Kucia
On Wed, Jan 18, 2017 at 2:25 AM, Boyan Ding wrote: > I don't think I find that. The only place in state tracker where > _mesa_add_renderbuffer is called is st_framebuffer_create and only one > of the front and back buffers is allocated based on the default > behavior. When update_framebuffer_state

Re: [Mesa-dev] [PATCH 01/11] gallium/radeon: adjust constraints for linear texture layout selection

2017-01-18 Thread Marek Olšák
On Jan 18, 2017 3:42 AM, "Michel Dänzer" wrote: On 18/01/17 07:47 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_texture.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/d

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #3 from Eero Tamminen --- Which Graphics -> Performance -> GPU Speed setting you're using? Talos works with Mesa Vulkan/Intel when using "low" or "medium" level, but deadlocks for me with higher levels. There are no issues with them

Re: [Mesa-dev] [PATCH v2 04/20] i965/fs: clamp exec_size to 4 when an instruction has an scalar DF source

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-17 at 12:26 -0800, Francisco Jerez wrote: > Typo in the subject line "an scalar". > > Samuel Iglesias Gonsálvez writes: > > > Then the SIMD lowering pass will get rid of any compressed > > instructions with scalar > > source (whether force_writemask_all or not) and we avoid hitti

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: Matt Turner > > > > On HSW+, scalar DF sources can be accessed using the normal <0,1,0> > > region, but on IVB and BYT DF regions must be programmed in terms > > of > > floats. A <0,2,1> re

Re: [Mesa-dev] [PATCH v2 03/20] i965/fs: double regioning parameters and execsize for DF in IVB/BYT

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-17 at 14:04 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > In IVB and BYT, both regioning parameters and execution sizes are > > measured as > > floats. > > > > So when we have something like: > > > > mov(8) g2<1>D

Re: [Mesa-dev] [PATCH v2 07/20] i965/fs: fix lower SIMD width for IVB/BYT's MOV_INDIRECT

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-17 at 14:15 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > Previous to Broadwell, we have 8 registers for MOV_INDIRECT. > > > > According to the IVB and HSW PRMs: > > > > "2.When the destination requires two regist

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-01-17 at 13:26 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > When converting a DF to F, we set dst stride to 2, to fulfil > > alignment > > restrictions. > > > > But in IVB/BYT, this is not necessary, as each DF conve

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #4 from Ernst Sjöstrand --- I had a similar problem, turns out it was: https://github.com/ValveSoftware/steam-for-linux/issues/4638 If you change to the Steam Client Beta that issue should be fixed. -- You are receiving this mail b

[Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-18 Thread Elie Tournier
Add the following optimisations: min(x, -x) = -abs(x) min(x, -abs(x)) = -abs(x) min(x, abs(x)) = x max(x, -abs(x)) = x max(x, abs(x)) = abs(x) max(x, -x) = abs(x) shader-db: total instructions in shared programs: 13067779 -> 13067775 (-0.00%) instructions in affected programs: 249 -> 245 (-1.61%

Re: [Mesa-dev] [PATCH] nir/spirv/glsl450: rewrite atan2 to deal with denorms / infinities

2017-01-18 Thread Juan A. Suarez Romero
On Tue, 2017-01-17 at 15:07 -0800, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > On Tue, 2017-01-17 at 11:34 +0100, Juan A. Suarez Romero wrote: > > > > The above does not necessarily sum to "we shouldn't fix it" but it > > > > probably does mean it's low-priority at best and we

Re: [Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-18 Thread Manolova, Plamena
Looks good to me :) Reviewed-by: Plamena Manolova > On Wed, Jan 18, 2017 at 11:23 AM, Elie Tournier wrote: > Add the following optimisations: > > min(x, -x) = -abs(x) > min(x, -abs(x)) = -abs(x) > min(x, abs(x)) = x > max(x, -abs(x)) = x > max(x, abs(x)) = abs(x) > max(x, -x) = abs(x) > > shade

[Mesa-dev] [PATCH v2] i965: check if HiZ buffer is available

2017-01-18 Thread Juan A. Suarez Romero
Commit 42011be1e disabled HiZ when sharing depth buffer externally, which free HiZ buffer. But in emit_depth_packets() we use that buffer, which generates a crash in "piglit.spec.egl_khr_gl_image.egl_khr_gl_renderbuffer_image-clear-shared-image gl_depth_component24" test when running in Skylake.

Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-18 Thread Jose Fonseca
On 17/01/17 13:26, Emil Velikov wrote: > On 16 January 2017 at 14:44, Jose Fonseca wrote: >> On 16/01/17 13:46, Emil Velikov wrote: >>> >>> On 14 January 2017 at 08:46, Jose Fonseca wrote: I suspect this might break builds with LLVM 3.6 or higher. The LLVMLinkInJIT must be ins

Re: [Mesa-dev] [PATCH] mesa/main: fix meta caller of _mesa_ClampColor

2017-01-18 Thread Alejandro Piñeiro
Reviewed by: Alejandro Piñeiro On 18/01/17 06:16, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Since _mesa_ClampColor properly checks for support of the API function > now, it's meta callers need to check support as well. > > Fixes: 963311b71f ("mesa/main: fix version/extension checks in >

Re: [Mesa-dev] [PATCH] nir/spirv/glsl450: rewrite atan2 to deal with denorms / infinities

2017-01-18 Thread Juan A. Suarez Romero
On Tue, 2017-01-17 at 12:00 +0100, Juan A. Suarez Romero wrote: > On Tue, 2017-01-17 at 11:34 +0100, Juan A. Suarez Romero wrote: > > > The above does not necessarily sum to "we shouldn't fix it" but it > > > probably does mean it's low-priority at best and we need to be careful. > > > > > > Look

[Mesa-dev] [PATCH v2] nir/spirv/glsl450: rewrite atan2 to deal with infinities

2017-01-18 Thread Juan A. Suarez Romero
Rewrite atan2(y,x) to cover (+/-)INF values. This fixes several test cases in Vulkan CTS (dEQP-VK.glsl.builtin.precision.atan2.*) v2: do not flush denorms to 0 (jasuarez) --- src/compiler/spirv/vtn_glsl450.c | 48 +++- 1 file changed, 42 insertions(+), 6 delet

Re: [Mesa-dev] [PATCH 08/11] radeonsi: use a global dirty mask for shader pointers

2017-01-18 Thread Nicolai Hähnle
On 17.01.2017 23:47, Marek Olšák wrote: From: Marek Olšák Only vertex buffers use a separate bool flag. --- src/gallium/drivers/radeonsi/si_descriptors.c | 85 +++ src/gallium/drivers/radeonsi/si_pipe.h| 2 + src/gallium/drivers/radeonsi/si_state.h | 2 -

Re: [Mesa-dev] [PATCH 11/11] radeonsi: determine in advance which VBOs should be added to the buffer list

2017-01-18 Thread Nicolai Hähnle
Some nice improvements in there. One minor stylistic remark on patch #8, apart from that patches 2-11 are Reviewed-by: Nicolai Hähnle On 18.01.2017 03:11, Marek Olšák wrote: From: Marek Olšák v2: now it should be correct --- src/gallium/drivers/radeonsi/si_descriptors.c | 8 src/g

Re: [Mesa-dev] [PATCH] mesa/main: fix meta caller of _mesa_ClampColor

2017-01-18 Thread Alejandro Piñeiro
On 18/01/17 10:38, Alejandro Piñeiro wrote: > Reviewed by: Alejandro Piñeiro typo (although I saw several "Reviewed by" on the list, I think that the official is "Reviewed-by", and I guess that is what patchwork catches) Reviewed-by: Alejandro Piñeiro > > On 18/01/17 06:16, Nicolai Hähnle wrote:

[Mesa-dev] [AppVeyor] mesa master #3174 failed

2017-01-18 Thread AppVeyor
Build mesa 3174 failed Commit 2d14ae6bea by Tomasz Figa on 12/14/2016 8:00 AM: configure.ac: Respect LLVM_CFLAGS in LLVM version detection\n\nWhen compiling LLVM headers, including llvm-config.h, we need to respect\nLLVM_CFLAGS. This is especially crucial if LL

[Mesa-dev] [PATCH v2] docs: Fix GLSL compiler link

2017-01-18 Thread Elie Tournier
The doc wasn't update since we moved the glsl compiler to src/compiler/glsl. I also updated the description of the standalone compiler. v2: Mention that just-log argument removes headers/separators. Mention that version argument is mandatory. Like version argument is mandatory, add --version to th

[Mesa-dev] [PATCH 1/8] configure.ac: directly print the contents of HAVE_GALLIUM_LLVM

2017-01-18 Thread Emil Velikov
From: Emil Velikov Just ensure that the variable is set and print it's contents. Cc: Tobias Droste Signed-off-by: Emil Velikov --- configure.ac | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 182d0726c3..0f60e13ec7 100644 --- a/con

[Mesa-dev] [PATCH 3/8] configure.ac: remove unused LLVM variables

2017-01-18 Thread Emil Velikov
From: Emil Velikov LLVM_BINDIR is completely unused while others such as LLVM_LIBDIR are used only internally. In the latter case there's no need to AC_SUBST it. Cc: Tobias Droste Signed-off-by: Emil Velikov --- configure.ac | 5 - 1 file changed, 5 deletions(-) diff --git a/configure.ac

[Mesa-dev] [PATCH 2/8] configure.ac: directly print the contents of USE_LLVM

2017-01-18 Thread Emil Velikov
From: Emil Velikov There's no point in the extra conditional. Cc: Tobias Droste Signed-off-by: Emil Velikov --- configure.ac | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 0f60e13ec7..f19164eaf2 100644 --- a/configure.ac +++ b/config

[Mesa-dev] [PATCH 6/8] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed

2017-01-18 Thread Emil Velikov
From: Emil Velikov Earlier refactoring commits started setting the above regardless if LLVM is used or not. Move them to the respective section to restore the original functionality. Since we require the preprocessor flags (includes in particular) for the header version parsing keep those as-is.

[Mesa-dev] [PATCH 4/8] configure.ac: don't use == with test

2017-01-18 Thread Emil Velikov
From: Emil Velikov Although it works, it's not the correct thing to do. Cc: Tobias Droste Signed-off-by: Emil Velikov --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 647c24a895..ea38dfa7f3 100644 --- a/configure.ac +++

[Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Emil Velikov
From: Emil Velikov Already implicitly handled throughout, but keep it clear and disable gallium-llvm. Cc: Tobias Droste Signed-off-by: Emil Velikov --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 7580fd955f..e21041434f 100644 --- a/config

[Mesa-dev] [PATCH 5/8] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10"

2017-01-18 Thread Emil Velikov
As stated in [1] by the LLVM devs, the new versioning scheme will not deploy any minor version (i.e. it will always be zero). As such the patch should not be needed. This reverts commit 0e9a5be7e74fa2a9bd2a634ef60822bd6600ca1d. [1] http://blog.llvm.org/2016/12/llvms-new-versioning-scheme.html Cc:

[Mesa-dev] [PATCH 8/8] configure.ac: correctly manage llvm auto-detection

2017-01-18 Thread Emil Velikov
From: Emil Velikov Earlier refactoring commits changed from one, dare I say it, broken behaviour to another. Namely: Before, as you explicitly enable gallium-llvm your selection was ignored when llvm-config was not present/detected. Today, the "auto" heuristics enables gallium-llvm regardless if

Re: [Mesa-dev] [PATCH v2] docs: Fix GLSL compiler link

2017-01-18 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro I will push it now, as you mentioned that you don't have push rights. Thanks On 18/01/17 11:50, Elie Tournier wrote: > The doc wasn't update since we moved the glsl compiler to src/compiler/glsl. > I also updated the description of the standalone compiler. > > v2:

Re: [Mesa-dev] [PATCH] shader-db: Update the README

2017-01-18 Thread Emil Velikov
On 13 January 2017 at 19:38, Matt Turner wrote: > On Fri, Jan 13, 2017 at 10:04 AM, Elie Tournier > wrote: >> +=== Depreciated === > > Typo: Deprecated > > Otherwise, fine by me. Squashed the typo and pushed to master. Thanks gents ! Emil ___ mesa-de

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 09:57, Steven Newbury wrote: > On Wed, 2017-01-18 at 20:43 +1100, Timothy Arceri wrote: >> On Wed, 2017-01-18 at 08:30 +, Steven Newbury wrote > [SNIP] >> > >> > Why not leave in a build time option for whichever is the fastest >> > (non- >> > OpenSSL) external SHA1 imple

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Nayan Deshmukh
I could simply add an extra parameter to vlVdpOutputSurface which shows that window and surface have the same format and revert to older otherwise. Christian, I was wondering if removing the rendering hack is right since with this vlc will follow the old codepath even with dri3. Should we revert

[Mesa-dev] [AppVeyor] mesa master #3177 completed

2017-01-18 Thread AppVeyor
Build mesa 3177 completed Commit 34041968f8 by Jose Fonseca on 1/18/2017 2:42 PM: configure.ac: Revert recent HAVE_LLVM changes.\n\nThis reverts changes 903eb09b5fb78d47d0f8a4bdf826a113ca2aff40..1a0aa468f354f0ee94dd383cd40ae915584624aa:\n\n Tobias Droste (5):\

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
This change was commited and completely broke scons build. It's also the first time I see HAVE_GALLIUM_LLVM name. I don't mind if people fiddle with autoconf and break it as much as they want, but please don't fiddle with gallium/llvmpipe .C code without me or Roland's review or acked by. I'm

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Christian König
Christian, I was wondering if removing the rendering hack is right since with this vlc will follow the old codepath even with dri3. Should we revert that commit? No, that VLC tries to use 10bit channels on an 8bit X display is the problem here. Even if we fix the X extension to allow that, we

Re: [Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-18 Thread Emil Velikov
On 14 January 2017 at 02:40, Derek Foreman wrote: > On 13/01/17 11:27 AM, Emil Velikov wrote: >> >> >> Not sure how much one should care - just thinking out loud. > > > If one should care, that sounds like a good way to go about it... > > Let me know if you want me to care, and I'll write it up.

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
I've reverted this and took a closer look. I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM and what not. But I'm afraid I can't accept replacing HAVE_LLVM in the .c code, because: - it breaks the other build systems if not updated - but above all, it creates merge co

[Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth matches the window depth, otherwise it returns a BadMatch protocol error. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/output.c| 6 ++ src/gallium/state_trackers/vdpau/presentation.c | 6 +++--- src/gallium/state_tra

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 15:11, Jose Fonseca wrote: > I've reverted this and took a closer look. > > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM > and what not. > > But I'm afraid I can't accept replacing HAVE_LLVM in the .c code, because: > - it breaks the other build

Re: [Mesa-dev] [PATCH v4 3/7] etnaviv: initialize seqno of imported resources

2017-01-18 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner 2016-12-06 17:17 GMT+01:00 Philipp Zabel : > Imported resources already have contents that we want to be copied to > texture resources derived from them. Set initial seqno of imported > resources to 1, just as if it had already been rendered to. > > Signed-off-by: P

Re: [Mesa-dev] [PATCH v4 4/7] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

2017-01-18 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner 2016-12-06 17:17 GMT+01:00 Philipp Zabel : > Implement the resource_changed pipe callback to invalidate internal > resources derived from imported buffers. This is needed to update the > texture for re-imported renderables. > > Signed-off-by: Philipp Zabel > --- >

Re: [Mesa-dev] [PATCH 3/6] gallivm: optimize gather a bit, by using supplied destination type

2017-01-18 Thread Roland Scheidegger
Am 18.01.2017 um 06:56 schrieb Dave Airlie: > On 12 December 2016 at 10:11, wrote: >> From: Roland Scheidegger >> >> By using a dst_type in the the gather interface, gather has some more >> knowledge about how values should be fetched. >> E.g. if this is a 3x32bit fetch and dst_type is 4x32bit v

Re: [Mesa-dev] [PATCH v4 7/7] gallium: add pipe_screen::resource_changed callback wrappers

2017-01-18 Thread Emil Velikov
On 6 December 2016 at 16:17, Philipp Zabel wrote: > Add resource_changed to the ddebug, rbug, and trace wrappers. Since it > is optional, there is no need to add it to noop. > > Signed-off-by: Philipp Zabel > Suggested-by: Nicolai Hähnle > --- > src/gallium/drivers/ddebug/dd_screen.c | 10 +

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Michel Dänzer
On 19/01/17 12:27 AM, Nayan Deshmukh wrote: > PresentPixmap only works if the pixmap depth matches the window > depth, otherwise it returns a BadMatch protocol error. > > Signed-off-by: Nayan Deshmukh > --- > src/gallium/state_trackers/vdpau/output.c| 6 ++ > src/gallium/state_tracke

Re: [Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Jan 18, 2017 2:22 AM, "Topi Pohjolainen" wrote: > by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). > The latter splits the flush in two: > >brw_emit_pipe_control_flush(brw, >PIPE_CONTROL_DEPTH_CACHE_FLUS

Re: [Mesa-dev] [v2 2/4] i965: Make depth clear flushing more explicit

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 2:22 AM, "Topi Pohjolainen" wrote: Current blorp logic issues unconditional "flush everything" (see brw_emit_mi_flush()) after each render. For example, all blits issue this unconditionally which shouldn't be needed if they set render cache properly os that subsequent renders do n

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long time. > Would you like to give it some more testing/benchmarking, or I can consider this ack-by ;-) Thanks

Re: [Mesa-dev] [PATCH] glx: don't expose systemTimeExtension for DRI2/DRI3/DRISW

2017-01-18 Thread Emil Velikov
On 27 September 2016 at 13:39, Emil Velikov wrote: > Used/applicable to only dri1 drivers. > > Signed-off-by: Emil Velikov > --- > If anyone wants to go ahead and start moving the DRI1 only functionality > to src/glx/dri[1] that'll be appreciated. > --- > src/glx/dri2_glx.c | 2 -- > src/glx/dr

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 8:07 AM, "Emil Velikov" wrote: On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long time. > Would you like to give it some more testing/benchm

Re: [Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-18 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Jan 18, 2017 3:23 AM, "Elie Tournier" wrote: Add the following optimisations: min(x, -x) = -abs(x) min(x, -abs(x)) = -abs(x) min(x, abs(x)) = x max(x, -abs(x)) = x max(x, abs(x)) = abs(x) max(x, -x) = abs(x) shader-db: total instructions in shared programs: 130

Re: [Mesa-dev] [PATCH] android: ac/debug: move sid_tables.h generation and IB decode to amd/common

2017-01-18 Thread Emil Velikov
On 12 January 2017 at 10:28, Nicolai Hähnle wrote: > On 12.01.2017 01:14, Mauro Rossi wrote: >> >> Hi, >> >> I'm sending a patch to support recent changes in radeonsi and amd/common, >> in order to fix android building errors due to files moved to amd/common. >> >> The patch has been implemented a

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Emil Velikov
On 10 January 2017 at 15:13, Emil Velikov wrote: > On 10 January 2017 at 00:52, Mauro Rossi wrote: >> >> Hi, >> >> I'm sending a series of 12 patches for android, >> comprising fixes for build errors, LLVMInitializeAMDGPU* declarations, >> Android 7 fixes and a (small) i915 patch for feature pari

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Chuck Atkins
Forgive me, as I'm not too familiar with the rest of the infrastructure surrounding this, but what's the motivation for disabling llvm on non-x86 given that llvm itself is available on a wide variety of platforms? -- Chuck Atkins Staff R&D Engineer, Scientific Computing Kitware, Inc. (518)

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 16:47, Chuck Atkins wrote: > Forgive me, as I'm not too familiar with the rest of the infrastructure > surrounding this, but what's the motivation for disabling llvm on non-x86 > given that llvm itself is available on a wide variety of platforms? > Don't recall the original/e

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
On Wed, Jan 18, 2017 at 9:21 PM, Michel Dänzer wrote: > On 19/01/17 12:27 AM, Nayan Deshmukh wrote: >> PresentPixmap only works if the pixmap depth matches the window >> depth, otherwise it returns a BadMatch protocol error. >> >> Signed-off-by: Nayan Deshmukh >> --- >> src/gallium/state_tracker

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 Bas Nieuwenhuizen changed: What|Removed |Added QA Contact|intel-3d-bugs@lists.freedes |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 Germano Massullo changed: What|Removed |Added CC||germano.massu...@gmail.com -- You ar

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > On 18 January 2017 at 15:11, Jose Fonseca wrote: > > I've reverted this and took a closer look. > > > > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM > > and what not. > > > > But I'm afraid I can't a

Re: [Mesa-dev] [PATCH 1/8] configure.ac: directly print the contents of HAVE_GALLIUM_LLVM

2017-01-18 Thread Tobias Droste
You may want to hold this one until we have a solution for Joses problem. In case the .c file changes stay: Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:57 CET schrieb Emil Velikov: > From: Emil Velikov > > Just ensure that the variable is set and print it's contents. > > Cc

Re: [Mesa-dev] [PATCH 2/8] configure.ac: directly print the contents of USE_LLVM

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:58 CET schrieb Emil Velikov: > From: Emil Velikov > > There's no point in the extra conditional. > > Cc: Tobias Droste > Signed-off-by: Emil Velikov > --- > configure.ac | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(

Re: [Mesa-dev] [PATCH 3/8] configure.ac: remove unused LLVM variables

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:59 CET schrieb Emil Velikov: > From: Emil Velikov > > LLVM_BINDIR is completely unused while others such as LLVM_LIBDIR are > used only internally. In the latter case there's no need to AC_SUBST it. > > Cc: Tobias Droste > Signed-

Re: [Mesa-dev] [PATCH 5/8] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10"

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:54:01 CET schrieb Emil Velikov: > As stated in [1] by the LLVM devs, the new versioning scheme will not > deploy any minor version (i.e. it will always be zero). As such the > patch should not be needed. > > This reverts commit 0e9a5be7

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #5 from Emil Velikov --- (In reply to Kai from comment #4) > The problem was not so much me not seeing that message, the problem was more > that I didn't connect "no DRI3 support" equals "this game won't start and > segfault. Combine

Re: [Mesa-dev] [PATCH 4/8] configure.ac: don't use == with test

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Old habits... sorry :-) Am Mittwoch, 18. Januar 2017, 13:54:00 CET schrieb Emil Velikov: > From: Emil Velikov > > Although it works, it's not the correct thing to do. > > Cc: Tobias Droste > Signed-off-by: Emil Velikov > --- > configure.ac | 4 ++-- > 1 file chan

Re: [Mesa-dev] [PATCH 6/8] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed

2017-01-18 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:54:02 CET schrieb Emil Velikov: > From: Emil Velikov > > Earlier refactoring commits started setting the above regardless if LLVM > is used or not. Move them to the respective section to restore the > original functionality. > > Since we require the preprocessor

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Mauro Rossi
2017-01-18 17:40 GMT+01:00 Emil Velikov : > On 10 January 2017 at 15:13, Emil Velikov wrote: >> On 10 January 2017 at 00:52, Mauro Rossi wrote: >>> >>> Hi, >>> >>> I'm sending a series of 12 patches for android, >>> comprising fixes for build errors, LLVMInitializeAMDGPU* declarations, >>> Androi

Re: [Mesa-dev] [PATCH 8/8] configure.ac: correctly manage llvm auto-detection

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:54:04 CET schrieb Emil Velikov: > From: Emil Velikov > > Earlier refactoring commits changed from one, dare I say it, broken > behaviour to another. Namely: > > Before, as you explicitly enable gallium-llvm your selection was ignored

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
On 18/01/17 17:51, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: On 18 January 2017 at 15:11, Jose Fonseca wrote: I've reverted this and took a closer look. I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM and what not. But I'

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #5 from Germano Massullo --- Everytime I try to enable Vulkan API, I get "Cannot set display mode" error message I attach api trace while trying to enable Vulkan API https://mega.nz/#F!QgBE3LiL!fxvFDEbVZLVR57DpDoEBAg Radeon RX480 F

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Mit freundlichen Grüßen Tobias Droste Am Mittwoch, 18. Januar 2017, 18:12:37 CET schrieb Jose Fonseca: > On 18/01/17 17:51, Tobias Droste wrote: > > Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > >> On 18 January 2017 at 15:11, Jose Fonseca wrote: > >>> I've reverted this and

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 18:09, Mauro Rossi wrote: > 2017-01-18 17:40 GMT+01:00 Emil Velikov : >> On 10 January 2017 at 15:13, Emil Velikov wrote: >>> On 10 January 2017 at 00:52, Mauro Rossi wrote: Hi, I'm sending a series of 12 patches for android, comprising fixes for bu

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Marek Olšák
On Wed, Jan 18, 2017 at 5:59 PM, Emil Velikov wrote: > On 18 January 2017 at 16:47, Chuck Atkins wrote: >> Forgive me, as I'm not too familiar with the rest of the infrastructure >> surrounding this, but what's the motivation for disabling llvm on non-x86 >> given that llvm itself is available on

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 18:12, Jose Fonseca wrote: >>> In order to untangle things we want to have a distinction between the >>> gallium (gallivm afaict) and other users - RADV presently. >>> So how about we update the RADV instances and ensure that the we set >>> the HAVE_{RADV,}_LLVM lot appropri

[Mesa-dev] [PATCH v2] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-18 Thread Alejandro Piñeiro
When the attachment type is NONE (att->Type), FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE too. Note that technically, the current behaviour follows the spec. From OpenGL 4.5 spec, Section 9.2.3 "Framebuffer Object Queries": "If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, the

[Mesa-dev] [AppVeyor] mesa master #3186 failed

2017-01-18 Thread AppVeyor
Build mesa 3186 failed Commit d1efa09d34 by Emil Velikov on 1/13/2017 4:51 PM: util: import sha1 implementation from OpenBSD\n\nAt the moment we support 5+ different implementations each with varying\namount of bugs - from thread safely problems [1], to outrigh

Re: [Mesa-dev] [AppVeyor] mesa master #3186 failed

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 19:13, AppVeyor wrote: > Build mesa 3186 failed > > Commit d1efa09d34 by Emil Velikov on 1/13/2017 4:51 PM: > util: import sha1 implementation from OpenBSD\n\nAt the moment we support 5+ > different implementations each with varying\namount of bugs - from thread > safely prob

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Matt Turner
On Tue, Jan 17, 2017 at 1:33 PM, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> From: Matt Turner >> >> On HSW+, scalar DF sources can be accessed using the normal <0,1,0> >> region, but on IVB and BYT DF regions must be programmed in terms of >> floats. A <0,2,1> region accompl

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Matt Turner
On Wed, Jan 18, 2017 at 2:45 AM, Samuel Iglesias Gonsálvez wrote: > On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: Matt Turner >> > >> > On HSW+, scalar DF sources can be accessed using the normal <0,1,0> >> > region, but on IVB and B

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #6 from Hadrien --- (In reply to Eero Tamminen from comment #3) > Which Graphics -> Performance -> GPU Speed setting you're using? > > Talos works with Mesa Vulkan/Intel when using "low" or "medium" level, but > deadlocks for me with

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #7 from Ernst Sjöstrand --- Germano, I think you have a completely different issue than the original reporter. You should probably file a separate bugreport. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #8 from Hadrien --- (In reply to Ernst Sjöstrand from comment #4) > I had a similar problem, turns out it was: > https://github.com/ValveSoftware/steam-for-linux/issues/4638 > > If you change to the Steam Client Beta that issue shoul

[Mesa-dev] [AppVeyor] mesa master #3189 completed

2017-01-18 Thread AppVeyor
Build mesa 3189 completed Commit ea8b2624c8 by Emil Velikov on 1/18/2017 7:48 PM: utils: really remove the __END_DECLS macro\n\nFixes: d1efa09d342 "util: import sha1 implementation from OpenBSD"\nSigned-off-by: Emil Velikov Configure your notificatio

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #9 from Laurent carlier --- (In reply to Germano Massullo from comment #5) > Everytime I try to enable Vulkan API, I get "Cannot set display mode" error > message > > I attach api trace while trying to enable Vulkan API > https://meg

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-18 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Tue, 2017-01-17 at 13:26 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: "Juan A. Suarez Romero" >> > >> > When converting a DF to F, we set dst stride to 2, to fulfil >> > alignment >> > restrictions. >> > >> > But in I

[Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-18 Thread Marek Olšák
From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0 --- src/gallium/drivers/radeonsi/si_descriptors.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/r

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-18 Thread Samuel Pitoiset
You were too fast for writing the fix, but I was very close. :) Confirmed, it fixes VM faults in Deux Ex: Mankind Divided. Thanks! Reviewed-by: Samuel Pitoiset On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0

Re: [Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Francisco Jerez
Topi Pohjolainen writes: > by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). > The latter splits the flush in two: > >brw_emit_pipe_control_flush(brw, >PIPE_CONTROL_DEPTH_CACHE_FLUSH | >PIPE_CONTROL_RENDER

[Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

2017-01-18 Thread Marek Olšák
From: Marek Olšák This should fix a coverity defect. --- src/gallium/drivers/radeonsi/si_state.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f60a499..5bc1789 100644 --- a/src/gallium/drivers/rad

  1   2   >