Re: [Mesa-dev] [PATCH 2/3] radeonsi: set si_shader_context::input_decls for ranged decls correctly

2017-01-09 Thread Nicolai Hähnle
Patches 1 & 2: Reviewed-by: Nicolai Hähnle On 03.01.2017 20:17, Marek Olšák wrote: From: Marek Olšák This has no effect because no code uses those members with ranged decls. --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Nicolai Hähnle
Interesting, this suggests a bug in the LLVM WQM stuff. Anyway, it makes sense for now. Reviewed-by: Nicolai Hähnle On 05.01.2017 13:58, Marek Olšák wrote: From: Marek Olšák v2: do it properly --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 15 +-- 1 file changed, 13

Re: [Mesa-dev] [PATCH 2/6] mesa: Introduce a compiler enum for tessellation spacing.

2017-01-09 Thread Nicolai Hähnle
On 07.01.2017 09:02, Kenneth Graunke wrote: It feels weird using GL_* enums in a Vulkan driver. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/ast.h | 2 +- src/compiler/glsl/glsl_parser.yy | 8 src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/com

[Mesa-dev] [PATCH] spirv: Move cursor before calling vtn_ssa_value() in phi 2nd pass.

2017-01-09 Thread Kenneth Graunke
vtn_ssa_value() can produce variable loads, and the cursor might be after a return statement, causing nir_builder assert failures about not inserting instructions after a jump. This fixes: dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_if dEQP-VK.spirv_assembly.instruction.graphics.barrier

[Mesa-dev] [PATCH] docs: add Vulkan Float64 capability support for anv driver

2017-01-09 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- docs/relnotes/13.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/13.1.0.html b/docs/relnotes/13.1.0.html index be1ab0d76ef..662f0ceb070 100644 --- a/docs/relnotes/13.1.0.html +++ b/docs/relnotes/13.1.0.html @@ -52,6 +52,7 @@

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Marek Olšák
On Mon, Jan 9, 2017 at 9:40 AM, Nicolai Hähnle wrote: > Interesting, this suggests a bug in the LLVM WQM stuff. Anyway, it makes > sense for now. Or more likely: v_interp is executed after KILL, which breaks WQM. Marek ___ mesa-dev mailing list mesa-de

Re: [Mesa-dev] [PATCH v3 21/22] anv: enable float64 feature on supported platforms

2017-01-09 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-01-05 at 12:46 -0800, Jason Ekstrand wrote: > With the image_ms_array line removed (I don't believe we support > that), 20-22 are > > Reviewed-by: Jason Ekstrand > I have applied all the suggestions and pushed the patches to master. Thanks a lot for the review! Sam __

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Marek Olšák
On Mon, Jan 9, 2017 at 7:25 AM, Michel Dänzer wrote: > On 09/01/17 03:13 PM, Michel Dänzer wrote: >> On 07/01/17 11:46 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> ~/.drirc is created by the driconf tool (GPL license) and it overrides >>> system drirc settings and can't be changed by Mesa

Re: [Mesa-dev] [PATCH 02/25] mesa: don't always set _NEW_PROGRAM when linking

2017-01-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jan 9, 2017 at 6:13 AM, Timothy Arceri wrote: > We only need to set it when linking was successful and the program > being linked is currently active. > > The programs_in_use mask is just used as a flag for now but in > a following patch we will use it to

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Nicolai Hähnle
On 09.01.2017 11:58, Marek Olšák wrote: On Mon, Jan 9, 2017 at 7:25 AM, Michel Dänzer wrote: On 09/01/17 03:13 PM, Michel Dänzer wrote: On 07/01/17 11:46 PM, Marek Olšák wrote: From: Marek Olšák ~/.drirc is created by the driconf tool (GPL license) and it overrides system drirc settings and

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Christian König
Am 09.01.2017 um 11:58 schrieb Marek Olšák: On Mon, Jan 9, 2017 at 7:25 AM, Michel Dänzer wrote: On 09/01/17 03:13 PM, Michel Dänzer wrote: On 07/01/17 11:46 PM, Marek Olšák wrote: From: Marek Olšák ~/.drirc is created by the driconf tool (GPL license) and it overrides system drirc settings

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Nicolai Hähnle
On 09.01.2017 11:40, Marek Olšák wrote: On Mon, Jan 9, 2017 at 9:40 AM, Nicolai Hähnle wrote: Interesting, this suggests a bug in the LLVM WQM stuff. Anyway, it makes sense for now. Or more likely: v_interp is executed after KILL, which breaks WQM. That's only relevant for derivative calcul

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-09 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 01/09/2017 04:38 AM, Grazvydas Ignotas wrote: > Fixes crashes when both glx-tls and asm are enabled on x32. > > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94512 > Signed-off-by: Grazvydas Ignotas > --- > no c

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Edmondo Tommasina
Could be a patch like this useful for power users? Load custom drirc only when specified in env variable. Patch untested, not even compiled. edmondo (on mobile phone) diff --git a/docs/envvars.html b/docs/envvars.html index cf57ca5..a404ced 100644 --- a/docs/envvars.html +++ b/docs/envvars.h

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Marek Olšák
On Mon, Jan 9, 2017 at 12:09 PM, Nicolai Hähnle wrote: > On 09.01.2017 11:40, Marek Olšák wrote: >> >> On Mon, Jan 9, 2017 at 9:40 AM, Nicolai Hähnle wrote: >>> >>> Interesting, this suggests a bug in the LLVM WQM stuff. Anyway, it makes >>> sense for now. >> >> >> Or more likely: v_interp is exe

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Marek Olšák
On Mon, Jan 9, 2017 at 12:16 PM, Edmondo Tommasina wrote: > Could be a patch like this useful for power users? > > Load custom drirc only when specified in env variable. Yes, that sounds like a good alternative. Marek > > Patch untested, not even compiled. > > edmondo (on mobile phone) > > diff

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Nicolai Hähnle
On 09.01.2017 12:28, Marek Olšák wrote: On Mon, Jan 9, 2017 at 12:09 PM, Nicolai Hähnle wrote: On 09.01.2017 11:40, Marek Olšák wrote: On Mon, Jan 9, 2017 at 9:40 AM, Nicolai Hähnle wrote: Interesting, this suggests a bug in the LLVM WQM stuff. Anyway, it makes sense for now. Or more li

Re: [Mesa-dev] [PATCH] radeonsi: fix the Witcher 2 black transitions

2017-01-09 Thread Marek Olšák
On Mon, Jan 9, 2017 at 12:58 PM, Nicolai Hähnle wrote: > On 09.01.2017 12:28, Marek Olšák wrote: >> >> On Mon, Jan 9, 2017 at 12:09 PM, Nicolai Hähnle >> wrote: >>> >>> On 09.01.2017 11:40, Marek Olšák wrote: On Mon, Jan 9, 2017 at 9:40 AM, Nicolai Hähnle wrote: > > >

[Mesa-dev] [Bug 99319] godot engine poor performance

2017-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99319 --- Comment #4 from Vladislav Egorov --- (In reply to Thomas Helland from comment #2) > A small update: It appears we are spending all of the time walking in a > for-loop at the bottom of context_cleanup: > > for (i = 0; i < ARRAY_SIZE(cs->buffe

[Mesa-dev] [PATCH] spirv: gl_PrimitiveID in the fragment shader is handled as an input

2017-01-09 Thread Iago Toral Quiroga
Geometry and Tessellation stages do handle this as a system value instead. Fixes: dEQP-VK.geometry.basic.primitive_id --- src/compiler/spirv/vtn_variables.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-01-09 Thread Zhen Wu
Thanks for your review, Rob. Using kms-dri would mean writing a new gralloc to basically the same thing as gralloc.default and moving to grm_gralloc seems to be a bigger task meant for another day. But I agree we would want to avoid introducing dependency. Would extending drisw loader func and limi

Re: [Mesa-dev] [PATCH] glsl: Do not allow scalar types in vector relational functions

2017-01-09 Thread Boyan Ding
2016-11-23 21:20 GMT+08:00 Boyan Ding : > 2016-11-07 20:27 GMT+08:00 Boyan Ding : >> 2016-11-05 3:23 GMT+08:00 Matt Turner : >>> On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding wrote: According to OpenGL Shading Language 4.50 spec, Section 8.7 "Vector Relational Functions", functions of thi

[Mesa-dev] [PATCH] spirv: replace assert() with unreachable()

2017-01-09 Thread Boyan Ding
To match the usage at other places. Signed-off-by: Boyan Ding --- src/compiler/spirv/vtn_variables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index e3845365bd..26a8ca369b 100644 --- a/src/co

[Mesa-dev] [PATCH] mesa/get: Remove unused extra_ARB_viewport_array

2017-01-09 Thread Boyan Ding
Unused since 0a7691ee (mesa: Enable enums for OES_viewport_array). Silence a warning of unused variable. Signed-off-by: Boyan Ding --- src/mesa/main/get.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 10b40d405d..f0bb041fc3 100644 --- a/src/me

[Mesa-dev] [PATCH] spirv: fix typo in warning message

2017-01-09 Thread Iago Toral Quiroga
--- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index befee1a..2205072 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -559,7 +

Re: [Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-09 Thread Iago Toral
On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > We need to: > - handle the extra array level for per-vertex varyings > - handle the patch qualifier correctly > - assign varying locations > > Signed-off-by: Kenneth Graunke > --- >  src/compiler/spirv/vtn_private.h   |  1 + >  src/compi

Re: [Mesa-dev] [PATCH] spirv: Move cursor before calling vtn_ssa_value() in phi 2nd pass.

2017-01-09 Thread Jason Ekstrand
On Jan 9, 2017 1:48 AM, "Kenneth Graunke" wrote: vtn_ssa_value() can produce variable loads, and the cursor might be after a return statement, causing nir_builder assert failures about not inserting instructions after a jump. This fixes: dEQP-VK.spirv_assembly.instruction.graphics.barrier.in_if

Re: [Mesa-dev] [PATCH 2/6] mesa: Introduce a compiler enum for tessellation spacing.

2017-01-09 Thread Kenneth Graunke
On Monday, January 9, 2017 9:47:36 AM PST Nicolai Hähnle wrote: > On 07.01.2017 09:02, Kenneth Graunke wrote: > > It feels weird using GL_* enums in a Vulkan driver. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/compiler/glsl/ast.h | 2 +- > > src/compiler/glsl/glsl_par

Re: [Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-09 Thread Iago Toral
Patches 1-5 are: Reviewed-by: Iago Toral Quiroga On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- >  src/compiler/spirv/spirv_to_nir.c | 28 ++-- >  1 file changed, 22 insertions(+), 6 deletions(-) > > One totally bogus thin

Re: [Mesa-dev] [PATCH] glsl: fix disk cache eviction issue

2017-01-09 Thread Emil Velikov
On 9 December 2016 at 05:58, Tapani Pälli wrote: > When 'evict_random_item' attempts to remove cache content to make more > space, it may try to remove from new cache directory it just created > which only has '.tmp' content at this phase and not proper cache files, > this will cause eviction to f

Re: [Mesa-dev] [PATCH] glsl: fix disk cache eviction issue

2017-01-09 Thread Emil Velikov
On 9 January 2017 at 15:36, Emil Velikov wrote: > On 9 December 2016 at 05:58, Tapani Pälli wrote: >> When 'evict_random_item' attempts to remove cache content to make more >> space, it may try to remove from new cache directory it just created >> which only has '.tmp' content at this phase and n

Re: [Mesa-dev] radv vs vulkan loader

2017-01-09 Thread Emil Velikov
On 16 December 2016 at 17:25, Gustaw Smolarczyk wrote: > 2016-12-16 18:12 GMT+01:00 Gustaw Smolarczyk : >> 2016-12-16 17:57 GMT+01:00 Emil Velikov : >>> On 16 December 2016 at 15:27, Gustaw Smolarczyk >>> wrote: 2016-12-16 14:50 GMT+01:00 Emil Velikov : > > On 5 October 2016 at 23:1

Re: [Mesa-dev] [PATCH] spirv: gl_PrimitiveID in the fragment shader is handled as an input

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2017 at 4:50 AM, Iago Toral Quiroga wrote: > Geometry and Tessellation stages do handle this as a system value instead. > > Fixes: > dEQP-VK.geometry.basic.primitive_id > --- > src/compiler/spirv/vtn_variables.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

Re: [Mesa-dev] [PATCH] spirv: gl_PrimitiveID in the fragment shader is handled as an input

2017-01-09 Thread Jason Ekstrand
Also, we should probably consider converting it over to a system value one of these days. That would make more sense from a theoretical model perspective. Not sure if it makes sense in any drivers though. On Mon, Jan 9, 2017 at 8:03 AM, Jason Ekstrand wrote: > On Mon, Jan 9, 2017 at 4:50 AM, I

Re: [Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-09 Thread Jason Ekstrand
I hate decorations... 1 and 2 are Reviewed-by: Jason Ekstrand On Mon, Jan 9, 2017 at 7:16 AM, Iago Toral wrote: > On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > > We need to: > > - handle the extra array level for per-vertex varyings > > - handle the patch qualifier correctly > >

Re: [Mesa-dev] [PATCH 03/11] spirv: Silence unsupported tessellation capability warnings.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:38 PM, Dave Airlie wrote: > On 9 January 2017 at 15:26, Kenneth Graunke wrote: > > This is all implemented now. > > Do we want to key these off the nir_spirv_supported_extensions thing I > added? > I think we do unless Dave thinks he can get tess support landed for radv

Re: [Mesa-dev] [PATCH 05/11] anv: Handle patch primitives.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/vulkan/anv_pipeline.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_ > pipeline.c > index 17491e34

Re: [Mesa-dev] [PATCH 06/11] anv: Emit 3DSTATE_HS/TE/DS packets.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/vulkan/anv_private.h | 2 + > src/intel/vulkan/genX_pipeline.c | 87 ++ > ++ > src/intel/vulkan/genX_state.c| 4 -- > 3 files changed, 89 inserti

Re: [Mesa-dev] [PATCH 04/11] nir: Add a pass to lower TES patch_vertices intrinsics to a constant.

2017-01-09 Thread Jason Ekstrand
For similar compute-related things (workgroup sizes) we handle this directly in nir_lower_system_values. On Sun, Jan 8, 2017 at 9:39 PM, Dave Airlie wrote: > On 9 January 2017 at 15:26, Kenneth Graunke wrote: > > In Vulkan, we always have both the TCS and TES available in the same > > pipeline,

Re: [Mesa-dev] [PATCH 04/11] nir: Add a pass to lower TES patch_vertices intrinsics to a constant.

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2017 at 8:40 AM, Jason Ekstrand wrote: > For similar compute-related things (workgroup sizes) we handle this > directly in nir_lower_system_values. > Doing so would probably require adding a vertices_in thing to tes... I don't know how strongly I feel about doing it one way vs. an

Re: [Mesa-dev] [PATCH 07/11] anv: Compile TCS/TES shaders.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/intel/vulkan/anv_pipeline.c | 156 ++ > +- > 1 file changed, 154 insertions(+), 2 deletions(-) > > There's one majorly bogus thing here: caching is totally dis

Re: [Mesa-dev] [PATCH] glsl: Do not allow scalar types in vector relational functions

2017-01-09 Thread Matt Turner
On Mon, Jan 9, 2017 at 6:34 AM, Boyan Ding wrote: > 2016-11-23 21:20 GMT+08:00 Boyan Ding : >> 2016-11-07 20:27 GMT+08:00 Boyan Ding : >>> 2016-11-05 3:23 GMT+08:00 Matt Turner : On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding wrote: > According to OpenGL Shading Language 4.50 spec, S

Re: [Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/spirv/spirv_to_nir.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > One totally bogus thing here: we set CCW backwards. In all three driver >

Re: [Mesa-dev] [PATCH] docs: add Vulkan Float64 capability support for anv driver

2017-01-09 Thread Jason Ekstrand
woohoo Reviewed-by: Jason Ekstrand On Mon, Jan 9, 2017 at 2:38 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > docs/relnotes/13.1.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/13.1.0.html b/docs/re

[Mesa-dev] [PATCH 00/11] i965 Haswell ARB_vertex_attrib_64bit / OpenGL 4.2

2017-01-09 Thread Juan A. Suarez Romero
Hi, This series implements the support for Haswell 64bit vertex attributes. With it, we can enable OpenGL 4.2 in Haswell. This work covers partially https://bugs.freedesktop.org/show_bug.cgi?id=94442. These patches are available in our repository for testing. You can clone it using the following

[Mesa-dev] [PATCH 03/11] i965/vec4: use attribute slots for first non payload GRF

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 5ddbe58..f80162d 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b

[Mesa-dev] [PATCH 02/11] i965: downsize *64*PASSTHRU formats to equivalent *32*FLOAT formats on gen < 8

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro gen < 8 doesn't support *64*PASSTHRU formats when emitting vertices. So in order to provide the equivalent functionality, we need to downsize the format to equivalent *32*FLOAT, and in some cases (R64G64B64 and R64G64B64A64) submit two 3DSTATE_VERTEX_ELEMENTS for each vert

[Mesa-dev] [PATCH 01/11] i965: return PASSTHRU surface types also on gen7

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro Although gen7 doesn't include surface types as a valid conversion format, we return it, as it reflects what we want to achieve, even if we need to workaround it on gen < 8. --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++-- 1 file changed, 6 insertions(+), 2 de

[Mesa-dev] [PATCH 06/11] i965/vec4: emit correctly load_inputs for 64bit data

2017-01-09 Thread Juan A. Suarez Romero
For dvec3 and dvec4 types, a single GRF do not have enough space to allocate two inputs from two different vertices (SIMD4x2). So the GRF only contains first two components for the two vertices, and the next GRF has the remaining components. We want to put all the components for the same vertex i

[Mesa-dev] [PATCH 04/11] i965/vec4/nir: vec4 also need to remap vs attributes

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro Doubles need extra space, so we would need to do a remapping for vec4 too in order to take that into account. We reuse the already existing remap_vs_attrs, but passing is_scalar, so they could remap accordingly. Signed-off-by: Alejandro Piñeiro Signed-off-by: Juan A. Sua

[Mesa-dev] [PATCH 05/11] i965/vec4: take into account doubles when creating attribute mapping

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro Doubles needs more that one slot per attribute. So when filling the attribute_map we check if it is a double in order to allocate one extra register. Signed-off-by: Alejandro Piñeiro Signed-off-by: Juan A. Suarez Romero --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 13 +

[Mesa-dev] [PATCH 09/11] i965: unify the code to enable of ARB_gpu_shader_fp64 and ARB_vertex_attrib_64bit for HSW+

2017-01-09 Thread Juan A. Suarez Romero
From: Samuel Iglesias Gonsálvez Signed-off-by: Samuel Iglesias Gonsálvez Signed-off-by: Juan A. Suarez Romero --- src/mesa/drivers/dri/i965/intel_extensions.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/d

[Mesa-dev] [PATCH 08/11] i965: Enable ARB_vertex_attrib_64bit for Haswell

2017-01-09 Thread Juan A. Suarez Romero
From: Alejandro Piñeiro --- src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 915797a..ac877cc 100644 --- a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 10/11] i965: enable ARB_shader_precision to HSW+

2017-01-09 Thread Juan A. Suarez Romero
From: Samuel Iglesias Gonsálvez Signed-off-by: Samuel Iglesias Gonsálvez Signed-off-by: Juan A. Suarez Romero --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 07/11] i965: check for dual slot attributes on any gen

2017-01-09 Thread Juan A. Suarez Romero
Those not supporting 64 bit input vertex attributes will have the dual_slot value as false. --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload

[Mesa-dev] [PATCH 11/11] i965/gen7: expose OpenGL 4.2 on Haswell when supported

2017-01-09 Thread Juan A. Suarez Romero
GL_ARB_vertex_attrib_64bit was the last piece missing. --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 05/11] anv: Handle patch primitives.

2017-01-09 Thread Kenneth Graunke
On Monday, January 9, 2017 8:26:34 AM PST Jason Ekstrand wrote: > On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke > wrote: > > > Signed-off-by: Kenneth Graunke > > --- > > src/intel/vulkan/anv_pipeline.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/src

[Mesa-dev] [PATCH] mesa: load custom drirc only when specified in env variable

2017-01-09 Thread Edmondo Tommasina
Define a new MESA_CUSTOM_DRIRC environment variable to load a drirc custom file, instead of blindly using the hardcoded ${HOME}/.drirc file created the driconf tool. Some more discussion about the driconf issues can be found in reading following mesa-dev thread: https://lists.freedesktop.org/archi

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-09 Thread Edmondo Tommasina
On Mon, Jan 9, 2017 at 12:37 PM, Marek Olšák wrote: > On Mon, Jan 9, 2017 at 12:16 PM, Edmondo Tommasina > wrote: >> Could be a patch like this useful for power users? >> >> Load custom drirc only when specified in env variable. > > Yes, that sounds like a good alternative. Patch sent to the mai

Re: [Mesa-dev] [PATCH 05/11] anv: Handle patch primitives.

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2017 at 10:07 AM, Kenneth Graunke wrote: > On Monday, January 9, 2017 8:26:34 AM PST Jason Ekstrand wrote: > > On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke > > wrote: > > > > > Signed-off-by: Kenneth Graunke > > > --- > > > src/intel/vulkan/anv_pipeline.c | 9 +++-- > > >

Re: [Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

2017-01-09 Thread Emil Velikov
On 28 July 2016 at 13:45, Marek Olšák wrote: > On Fri, Jul 22, 2016 at 6:22 PM, Rob Herring wrote: >> In order to prevent multiple pipe_screens being created in the same >> process, lookup of the DRM FD and reference counting of the pipe_screen >> are needed. Several implementations of this exist

Re: [Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

2017-01-09 Thread Emil Velikov
On 22 July 2016 at 19:01, Rob Herring wrote: > On Fri, Jul 22, 2016 at 11:46 AM, Ilia Mirkin wrote: >> On Fri, Jul 22, 2016 at 12:22 PM, Rob Herring wrote: >>> In order to prevent multiple pipe_screens being created in the same >>> process, lookup of the DRM FD and reference counting of the pipe

Re: [Mesa-dev] [PATCH] nir: Fix anonymous union initialization with older GCC.

2017-01-09 Thread Jason Ekstrand
Assuming it still builds on newer GCC, Acked-by: Jason Ekstrand On Sun, Jan 8, 2017 at 9:26 AM, Vinson Lee wrote: > Fix this build error with GCC 4.4.7. > > CC nir/nir_opt_copy_prop_vars.lo > nir/nir_opt_copy_prop_vars.c: In function ‘copy_prop_vars_block’: > nir/nir_opt_copy_prop_vars.c

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-09 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Fri, Jan 6, 2017 at 10:42 AM, Samuel Pitoiset wrote: > D3D always computes the absolute value while GLSL says that the > result of inversesqrt() is undefined if x <= 0 (and undefined if > x < 0 for sqrt()). But some apps rely on this specific behaviour > which is

Re: [Mesa-dev] [PATCH v4 08/11] radeon: use common screen ref counting

2017-01-09 Thread Emil Velikov
On 22 July 2016 at 17:22, Rob Herring wrote: > Use the common pipe_screen ref counting and fd hashing functions. The > mutex can be dropped as the pipe loader protects the create_screen() > calls. > > Signed-off-by: Rob Herring > Cc: "Marek Olšák" > Cc: Ilia Mirkin > --- > src/gallium/drivers/

Re: [Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

2017-01-09 Thread Emil Velikov
On 29 July 2016 at 20:08, Marek Olšák wrote: > On Fri, Jul 29, 2016 at 8:01 PM, Rob Herring wrote: >> On Fri, Jul 29, 2016 at 12:51 PM, Marek Olšák wrote: >>> The fd table and reference counting in the winsys is required by the >>> GL-VDPAU interop. >>> >>> radeon_drm_winsys_create and amdgpu_wi

Re: [Mesa-dev] [PATCH v4 00/11] Common pipe screen ref counting

2017-01-09 Thread Emil Velikov
Hi Rob, On 22 July 2016 at 17:22, Rob Herring wrote: > Another version of common pipe_screen reference counting. Please help > test on AMD and Nouveau as those are the more complicated ones and I > don't have h/w to test. > > Changes in v4: > - Move fd dup() back into driver winsys create screen

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: gallium driver for Vivante GPUs

2017-01-09 Thread Emil Velikov
Hi Christian, There's a few nitpicks. Note that neither is a blocker so feel free to send patches in the week(s) to come. On 23 December 2016 at 22:04, Christian Gmeiner wrote: > --- a/configure.ac > +++ b/configure.ac > @@ -76,6 +76,7 @@ LIBDRM_NVVIEUX_REQUIRED=2.4.66 > LIBDRM_NOUVEAU_REQUIRE

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-09 Thread Jason Ekstrand
On Thu, Dec 1, 2016 at 2:09 PM, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used by clients that need to know the number of planes > allocated for them on behalf of the GL or other API. The best current > example of this is when an extra "plane" is allocated to store > compression

Re: [Mesa-dev] [PATCH] radv/ac: add support for multi sample image coords

2017-01-09 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Dec 30, 2016 at 6:22 AM, Dave Airlie wrote: > From: Dave Airlie > > This just adds the nir->llvm support, enabling > the extension causes some failures on llvm 3.9 at least, > but this code seems fine. > > NIR passes the sampler in src[1].x, and we LLVM/SI

Re: [Mesa-dev] [PATCH] mesa: set GLSL 1.20 for the fixed-function fragment shader

2017-01-09 Thread Roland Scheidegger
Am 07.01.2017 um 19:11 schrieb Marek Olšák: > On Sat, Jan 7, 2017 at 5:23 PM, Roland Scheidegger wrote: >> Am 07.01.2017 um 15:51 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> This fixes broken depth texturing after: >>> >>> commit 22639a6e19f95902aef23474ad672bf489231ea7 >>> Author: Timothy

Re: [Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-09 Thread Roland Scheidegger
Am 06.01.2017 um 10:42 schrieb Samuel Pitoiset: > D3D always computes the absolute value while GLSL says that the That should probably say "d3d9" - it is completely wrong for d3d10 and later (which have it to be defined as a guaranteed NaN). (Otherwise, I'm still not quite convinced it's the right

[Mesa-dev] [PATCH] nir: remove duplicated foreach loop

2017-01-09 Thread Thomas Hindoe Paaboel Andersen
The foreach loop was called both in the else case and right after. The indentation seems to indicate that the extra call was from a previous version with an else section with out curly brackets. --- Spotted due to the wrong indentation. The patch is untested as I do not have the neccesary hardware.

Re: [Mesa-dev] [PATCH v3 6/7] i965: Add support for xfb overflow query on conditional render.

2017-01-09 Thread Rafael Antognolli
On Thu, Jan 05, 2017 at 11:22:51AM -0800, Kenneth Graunke wrote: > On Tuesday, December 13, 2016 2:50:58 PM PST Rafael Antognolli wrote: > > Enable the use of a transform feedback overflow query with > > glBeginConditionalRender. The render commands will only execute if the > > query is true (i.e.

Re: [Mesa-dev] [PATCH v3 5/7] i965: Add support for xfb overflow on query buffer objects.

2017-01-09 Thread Rafael Antognolli
Ugh, will update the patch with these changes. Thanks! Rafael On Thu, Jan 05, 2017 at 11:17:51AM -0800, Kenneth Graunke wrote: > On Tuesday, December 13, 2016 2:50:57 PM PST Rafael Antognolli wrote: > > Enable getting the results of a transform feedback overflow query with a > > buffer object. >

Re: [Mesa-dev] [PATCH 1/2] i965: Enable predicate support on gen >= 8.

2017-01-09 Thread Rafael Antognolli
On Thu, Jan 05, 2017 at 11:29:39AM -0800, Kenneth Graunke wrote: > Predication needs cmd parser only on gen7. For newer platforms, it > should be available without it. > > Signed-off-by: Rafael Antognolli > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/intel_screen.c | 2 +- >

Re: [Mesa-dev] [PATCH 01/22] i965/disasm: also print nibctrl in IVB for execsize=8

2017-01-09 Thread Francisco Jerez
Matt Turner writes: > On 01/05, Samuel Iglesias Gonsálvez wrote: >>From: Iago Toral Quiroga >> >>4-wide DF operations where NibCtrl applies require and execsize of 8 >>in IvyBridge/Valleyview. > > Wow, the documentation is bad in this area. The QtrCtrl description in > IVB's Vol4 Part3 explicitl

Re: [Mesa-dev] [PATCH 05/32] [v2] gbm: Export a getter for per plane handles

2017-01-09 Thread Jason Ekstrand
On Wed, Jan 4, 2017 at 8:43 PM, Ben Widawsky wrote: > v2: Make the error return be -1 instead of 0 because I think 0 is > actually valid. > > Cc: Daniel Stone > Signed-off-by: Ben Widawsky > --- > src/gbm/backends/dri/gbm_dri.c | 28 > src/gbm/gbm-symbols-check

Re: [Mesa-dev] [PATCH 05/22] i965/fs: consider execsize can be duplicated in lower_simd_with

2017-01-09 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > In IVB/VLV, for instructions dealing with DF, execsize will be > duplicated in the final code. > > So take this in account when checking if instructions should be split. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 13 +

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > Reviewed-by: Eric Engestrom > Acked-by: Daniel Stone > --- > src/gbm/backends/dri/gbm_dri.c | 26 +- > src/gbm/gbm-symbols-check | 1 + > src/gbm/main/gbm.c | 15 +

Re: [Mesa-dev] [PATCH 02/22] i965/fs: add helper to retrieve instruction data size

2017-01-09 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > The execution data size is the biggest type size of any instruction > operand. > > We will use it to know if the instruction deals with DF, because in Ivy > we need to duplicate the execution size and regioning parameters. > -

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2017 at 3:50 PM, Jason Ekstrand wrote: > On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote: > >> Signed-off-by: Ben Widawsky >> Reviewed-by: Eric Engestrom >> Acked-by: Daniel Stone >> --- >> src/gbm/backends/dri/gbm_dri.c | 26 +- >> src/gbm/gbm-symbo

Re: [Mesa-dev] [PATCH 06/22] i965/fs: double-precision execution does not use 2 channels per DF in IVB/VLV

2017-01-09 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: Iago Toral Quiroga > > It seems to use 1 channel por DF, just like later hardware. The docs say > things > like: > > "Each DF operand uses a pair of channels and all masking and swizzling > should be adjusted appropriately." > > "In Align16, all regio

[Mesa-dev] [PATCH] gallium/tgsi: fix overflow in parse property

2017-01-09 Thread Li Qiang
In parse_identifier, it doesn't stop copying '*pcur' untill encounter the NULL. As the 'ret' has a fixed-size buffer, if the '*pcur' has a long string, there will be a buffer overflow. This patch avoid this. Signed-off-by: Li Qiang --- src/gallium/auxiliary/tgsi/tgsi_text.c | 6 +++--- 1 file ch

[Mesa-dev] [PATCH v2] gallium/tgsi: fix overflow in parse property

2017-01-09 Thread Li Qiang
In parse_identifier, it doesn't stop copying '*pcur' untill encounter the NULL. As the 'ret' has a fixed-size buffer, if the '*pcur' has a long string, there will be a buffer overflow. This patch avoid this. Signed-off-by: Li Qiang --- src/gallium/auxiliary/tgsi/tgsi_text.c | 9 ++--- 1 file

Re: [Mesa-dev] [Mesa-dev, 10/32] dri: Add an image creation with modifiers

2017-01-09 Thread Jason Ekstrand
Somehow I didn't actually get the original e-mail so I'm replying via git-send-email... On 01/02, Ben Widawsky wrote: > Modifiers will be obtains or guessed by the client and passed in during > image creation/import. > > This requires bumping the DRIimage version. > > As of this patch, the modif

[Mesa-dev] [PATCH 02/12] st/dri: remove trailing whitespace

2017-01-09 Thread Mauro Rossi
--- src/gallium/state_trackers/dri/dri_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri_screen.c b/src/gallium/state_trackers/dri/dri_screen.c index aa0ad09..a950f52 100644 --- a/src/gallium/state_trackers/dri/dri_screen.c +++ b/src/g

[Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-09 Thread Mauro Rossi
Hi, I'm sending a series of 12 patches for android, comprising fixes for build errors, LLVMInitializeAMDGPU* declarations, Android 7 fixes and a (small) i915 patch for feature parity with i965. Tested with nougat-x86 and marshmallow-x86 Mauro Changelog: [building errors/trailing whitespaces]

[Mesa-dev] [PATCH 05/12] android: radeonsi: fix LLVMInitializeAMDGPU* functions declaration

2017-01-09 Thread Mauro Rossi
LLVMInitializeAMDGPU* functions need to be explicitly declared and mesa expects them via header, but LLVM needs to be instructed to invoke its own LLVM_TARGET(AMDGPU) macro, or the functions will not be available. A new llvm cflag (-DFORCE_BUILD_AMDGPU) serves this purpose, the same mechanism is

[Mesa-dev] [PATCH 01/12] android: st/mesa: fix building error in libmesa_st_mesa

2017-01-09 Thread Mauro Rossi
Fixes building error due to dependency on nir generated headers --- src/mesa/Android.libmesa_st_mesa.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/Android.libmesa_st_mesa.mk b/src/mesa/Android.libmesa_st_mesa.mk index 3905ddc..92df4ad 100644 --- a/src/mesa/And

[Mesa-dev] [PATCH 06/12] android: amd/common: fix LLVMInitializeAMDGPU* functions declaration

2017-01-09 Thread Mauro Rossi
LLVMInitializeAMDGPU* functions need to be explicitly declared and mesa expects them via header, but LLVM needs to be instructed to invoke its own LLVM_TARGET(AMDGPU) macro, or the functions will not be available. A new llvm cflag (-DFORCE_BUILD_AMDGPU) serves this purpose, the same mechanism is

[Mesa-dev] [PATCH 03/12] android: define HAVE___BUILTIN_{FFS, FFSLL}

2017-01-09 Thread Mauro Rossi
Fixes building errors due to multiple definition of ffs and ffsll as they are provided by bionic in kitkat, in later versions these definitions do no harm. --- Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Android.common.mk b/Android.common.mk index 80cf572..1745b08 10064

[Mesa-dev] [PATCH 10/12] android: gallium/targets/dri: libz static dependency for Android 7.0

2017-01-09 Thread Mauro Rossi
Fixes a series of libz related building errors: target SharedLib: gallium_dri_32 (out/target/prod...SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so) external/elfutils/libelf/elf_compress.c:117: error: undefined reference to 'deflateInit_' ... external/elfutils/libelf/elf_compress

[Mesa-dev] [PATCH 11/12] android: gallium/targets/dri: remove blank static libraries definition

2017-01-09 Thread Mauro Rossi
Removed as unnecessary --- src/gallium/targets/dri/Android.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/targets/dri/Android.mk b/src/gallium/targets/dri/Android.mk index 1564d9d..9067b32 100644 --- a/src/gallium/targets/dri/Android.mk +++ b/src/gallium/targets/dri/Android.m

[Mesa-dev] [PATCH 12/12] i915: add mock implementation of GL_OES_EGL_image_external (v2)

2017-01-09 Thread Mauro Rossi
This is similar to commit 7420c9dab4aaf87e6b840410226c296c4668a48f but for the i915 driver, as neeeded in android-x86. In version v2, as per i965 implementation, the extension GL_OES_EGL_image_external is not enabled by default. The by-the-book way to enable the extension is mesa environment vari

[Mesa-dev] [PATCH 09/12] android: gallium/auxiliary: fix building error in Android 7.0

2017-01-09 Thread Mauro Rossi
Conditional libLLVMCore static library dependency is added, for the case when MESA_ENABLE_LLVM is true Fixes the following building error with Android 7.0: In file included from external/mesa/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp:62: ... external/llvm/include/llvm/IR/Attributes.h:68:14: f

[Mesa-dev] [PATCH 07/12] android: add support for Android 7.0 with llvm 3.8

2017-01-09 Thread Mauro Rossi
Integration of rules that set correct HAVE_LLVM value for Android 7.0 --- Android.common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Android.common.mk b/Android.common.mk index 1745b08..36a44bb 100644 --- a/Android.common.mk +++ b/Android.common.mk @@ -80,7 +80,7 @@ endi

[Mesa-dev] [PATCH 04/12] android: radeon: fix LLVMInitializeAMDGPU* functions declaration

2017-01-09 Thread Mauro Rossi
LLVMInitializeAMDGPU* functions need to be explicitly declared and mesa expects them via header, but LLVM needs to be instructed to invoke its own LLVM_TARGET(AMDGPU) macro, or the functions will not be available. A new llvm cflag (-DFORCE_BUILD_AMDGPU) serves this purpose, the same mechanism is

[Mesa-dev] [PATCH 08/12] android: fix libelf include path for Android 7.0

2017-01-09 Thread Mauro Rossi
LOCAL_C_INCLUDES need to include correct path of libelf, which had exceptions for Android 5.0 (i.e external/elfutils/0.153/libelf) and Android 6.0 (i.e. external/elfutils/src/libelf) In Android 7.0 the path is again external/elfutils/libelf Fixes the following building error: external/mesa/src/ga

Re: [Mesa-dev] [PATCH 11/32] gbm: Introduce modifiers into surface/bo creation

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 2, 2017 at 6:37 PM, Ben Widawsky wrote: > The idea behind modifiers like this is that the user of GBM will have > some mechanism to query what properties the hardware supports for its BO > or surface. This information is directly passed in (and stored) so that > the DRI implementation

  1   2   >