Re: [Mesa-dev] [PATCH 7/7] intel: Share URB configuration code between GL and Vulkan.

2016-11-17 Thread Pohjolainen, Topi
On Tue, Nov 15, 2016 at 05:54:02PM -0800, Kenneth Graunke wrote: > This code is far too complicated to cut and paste. > > Signed-off-by: Kenneth Graunke > --- > src/intel/Makefile.sources | 1 + > src/intel/common/gen_l3_config.h | 6 ++ > src/intel/common/gen_urb_config.c|

[Mesa-dev] [PATCH v2] nir/spirv: implement ordered / unordered floating point comparisons properly

2016-11-17 Thread Iago Toral Quiroga
Besides the logical operation involved, these also require that we test if the operands are ordered / unordered. For ordered operations, both operands must be ordered (and they must pass the conditional test) while for unordered operations it is sufficient if only one of the operands is unordered

Re: [Mesa-dev] [PATCH] mesa: fix empty program log length

2016-11-17 Thread Nicolai Hähnle
On 17.11.2016 08:16, Tapani Pälli wrote: In case we have empty log (""), we should return 0. This fixes Khronos WebGL conformance test 'program-infolog'. From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: "If pname is INFO_LOG_LENGTH , the length of the info log, including a null terminator,

Re: [Mesa-dev] [PATCH 00/20] RadeonSI: Optimized shader variants and other improvements

2016-11-17 Thread Jan Ziak
Marek Olsak wrote: > I've just realized I might have to limit the compilation of optimized shader > variants to only a limited number of threads, so that apps aren't slowed down > by this. As a temporary fix before using a thread pool, the threads can have a lower priority: $ man setpriority s

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-17 Thread Vedran Miletić
On 11/16/2016 11:21 PM, Vinson Lee wrote: > On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely wrote: >> On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: >>> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >>> 3.9 and older versionsin Clover. This patch restores it and refa

Re: [Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

2016-11-17 Thread Iago Toral
Hi Jason, On Wed, 2016-11-16 at 11:31 -0800, Jason Ekstrand wrote: > The lower_input_attachments pass that we're about to add will > generate > additional uses of system values and we want those to be reflected in > gather_info. > --- >  src/intel/vulkan/anv_pipeline.c | 4 ++-- >  1 file changed,

Re: [Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

2016-11-17 Thread Iago Toral
Ah, I had missed this, ignore my comment then  :) On Wed, 2016-11-16 at 21:18 -0800, Jason Ekstrand wrote: > Forget this patch.  It's bogus.  The computation of prog_data- > >nr_params requires gathered info so the earliest we could put it is > at the top of this function.  Instead, we'll just call

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

2016-11-17 Thread Eero Tamminen
Hi, Could you add also note about this to envvars.html? - Eero On 16.11.2016 01:05, Brian Paul wrote: A number of drivers report useful debug/perf information accessible through GL_ARB_debug_output and with debug contexts (i.e. setting the GLX_CONTEXT_DEBUG_BIT_ARB flag). But few appl

Re: [Mesa-dev] [PATCH 05/12] docs/repository: refer to Submitting patches

2016-11-17 Thread Emil Velikov
On 16 November 2016 at 22:21, Eric Engestrom wrote: > On Wednesday, 2016-11-16 18:46:17 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> docs/repository.html | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/docs/repository

Re: [Mesa-dev] [PATCH 2/3] egl/x11: store xcb_screen_t *screen instead of int screen

2016-11-17 Thread Eric Engestrom
On Friday, 2016-11-11 16:31:16 +, Emil Velikov wrote: > From: Emil Velikov > > Just fetch and store it once, rather than doing the > xcb_setup_roots_iterator + get_xcb_screen dance five times. > > Signed-off-by: Emil Velikov > --- > These two patches are an example of the duplication we hav

[Mesa-dev] [PATCH] docs: document MESA_DEBUG=context

2016-11-17 Thread Brian Paul
--- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index af1a30c..5dd7bab 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -60,6 +60,8 @@ sometimes be useful for debugging end-user issues. flush - flush after each drawin

Re: [Mesa-dev] [PATCH] docs: document MESA_DEBUG=context

2016-11-17 Thread Nicolai Hähnle
On 17.11.2016 15:21, Brian Paul wrote: --- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index af1a30c..5dd7bab 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -60,6 +60,8 @@ sometimes be useful for debugging end-user issu

Re: [Mesa-dev] [PATCH] docs: document MESA_DEBUG=context

2016-11-17 Thread Eric Engestrom
On Thursday, 2016-11-17 07:21:53 -0700, Brian Paul wrote: > --- > docs/envvars.html | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/envvars.html b/docs/envvars.html > index af1a30c..5dd7bab 100644 > --- a/docs/envvars.html > +++ b/docs/envvars.html > @@ -60,6 +60,8 @@ sometimes be

Re: [Mesa-dev] [PATCH 11/12] docs: rework/update install.html

2016-11-17 Thread Emil Velikov
On 16 November 2016 at 22:56, Eric Engestrom wrote: > On Wednesday, 2016-11-16 18:46:23 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Still far from perfect, but a few small steps in the right direction. >> >> - Split build systems, compilers, third party tools >> - Mention building me

Re: [Mesa-dev] Stable release process

2016-11-17 Thread Emil Velikov
On 15 November 2016 at 16:57, Marek Olšák wrote: > On Tue, Nov 15, 2016 at 5:30 PM, Emil Velikov > wrote: >> On 15 November 2016 at 16:13, Marek Olšák wrote: >>> I think that if people add the Cc stable tag to patches that are going >>> to land in master first, they shouldn't send it to the sta

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

2016-11-17 Thread Gustaw Smolarczyk
2016-11-16 0:05 GMT+01:00 Brian Paul : > A number of drivers report useful debug/perf information accessible > through GL_ARB_debug_output and with debug contexts (i.e. setting the > GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use > the GL_ARB_debug_output extension. > > This c

[Mesa-dev] [Bug 98474] Linking mesa against [non-standard prefixed] LLVM fails

2016-11-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98474 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2016-11-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Bug 98471 depends on bug 98474, which changed state. Bug 98474 Summary: Linking mesa against [non-standard prefixed] LLVM fails https://bugs.freedesktop.org/show_bug.cgi?id=98474 What|Removed |Added

[Mesa-dev] [PATCH 1/2] gbm: automake: remove unused defines

2016-11-17 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gbm/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gbm/Makefile.am b/src/gbm/Makefile.am index aba8d1e..e34c1d4 100644 --- a/src/gbm/Makefile.am +++ b/src/gbm/Makefile.am @@ -4,8 +4,6 @@ pkgconfigdir = $(libdir)/pkgcon

[Mesa-dev] [PATCH 2/2] loader: automake: whitespace cleanup

2016-11-17 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/loader/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/Makefile.am b/src/loader/Makefile.am index 4aa6ca3..ba2e65c 100644 --- a/src/loader/Makefile.am +++ b/src/loader/Makefile.am @@ -45,7 +45,7 @@

Re: [Mesa-dev] [PATCH 07/14] nir: add a pass to compact clip/cull distances.

2016-11-17 Thread Jason Ekstrand
On Wed, Nov 16, 2016 at 9:11 PM, Kenneth Graunke wrote: > On Wednesday, November 16, 2016 8:37:50 PM PST Jason Ekstrand wrote: > > On Mon, Nov 14, 2016 at 5:41 PM, Kenneth Graunke > > wrote: > > > > > Signed-off-by: Kenneth Graunke > > > --- > > > src/compiler/Makefile.sources

[Mesa-dev] [PATCH v2 07/13] anv: Add an input attachment lowering pass

2016-11-17 Thread Jason Ekstrand
v2: Move the call to anv_nir_lower_input_attachments higher up --- src/intel/vulkan/Makefile.sources | 1 + src/intel/vulkan/anv_nir.h | 2 + src/intel/vulkan/anv_nir_lower_input_attachments.c | 141 + src/intel/vulkan/anv_pipeline.

Re: [Mesa-dev] [PATCH 06/13] anv/pipeline: Move gather_info further down the compilation process

2016-11-17 Thread Jason Ekstrand
On Thu, Nov 17, 2016 at 4:43 AM, Iago Toral wrote: > Ah, I had missed this, ignore my comment then :) > I just sent out a v2 of patch 7 and force-pushed my review branch if you want to test things out. > On Wed, 2016-11-16 at 21:18 -0800, Jason Ekstrand wrote: > > Forget this patch. It's bog

Re: [Mesa-dev] [PATCH 4/5] draw: simplify fetch some more

2016-11-17 Thread Jose Fonseca
On 13/11/16 16:48, srol...@vmware.com wrote: From: Roland Scheidegger Don't keep the ofbit. This is just a minor simplification, just adjust the buffer size so that there will always be an overflow if buffers aren't valid to fetch from. Also, get rid of control flow from the instanced path too.

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-17 Thread Emil Velikov
Hi George, Seems I was unclear as a few suggestions got missed. On 16 November 2016 at 02:26, George Kyriazis wrote: > - Handle dynamic library loading for windows > - Implement swap for gdi > - fix prototypes > - update include paths on configure-based build for swr_loader.cpp > --- > src/gall

Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-17 Thread Emil Velikov
On 16 November 2016 at 02:27, George Kyriazis wrote: > Modify gen_knobs.py so that each invocation creates a single generated > file. This is more similar to how the other generators behave. Nicely done. > mode change 100644 => 100755 src/gallium/drivers/swr/Makefile.am Please don't ! > > env

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-17 Thread Emil Velikov
On 17 November 2016 at 11:29, Vedran Miletić wrote: > On 11/16/2016 11:21 PM, Vinson Lee wrote: >> On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely wrote: >>> On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 an

Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, November 17, 2016 11:22 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} > creation script > > On 16 November 2016 at 02:27,

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

2016-11-17 Thread Brian Paul
On 11/17/2016 08:22 AM, Gustaw Smolarczyk wrote: 2016-11-16 0:05 GMT+01:00 Brian Paul mailto:bri...@vmware.com>>: A number of drivers report useful debug/perf information accessible through GL_ARB_debug_output and with debug contexts (i.e. setting the GLX_CONTEXT_DEBUG_BIT_ARB flag).

Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-17 Thread Emil Velikov
On 17 November 2016 at 17:33, Kyriazis, George wrote: > > >> -Original Message- >> From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >> Sent: Thursday, November 17, 2016 11:22 AM >> To: Kyriazis, George >> Cc: ML mesa-dev >> Subject: Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_kno

[Mesa-dev] test Vulkan with radv

2016-11-17 Thread XoD
Hello, I would like do some test with Vulkan, but I have not been able to use the radv drivers at the moment. I have install vulkan package from Fedora 24, and build mesa with radv drivers. The driver library libvulkan_radeon seems to be found by the system : $ldconfig -p | grep vulkan libvul

[Mesa-dev] [PATCH] configure.ac: invert order for wayland-scanner check

2016-11-17 Thread Gustavo Zacarias
When cross-compiling the .pc file might point to the wrong wayland-scanner binary (target rather than host) resulting in a non-executable and wrong scanner. Try searching the PATH first, and if that fails fall back into pkg-config. Signed-off-by: Gustavo Zacarias --- configure.ac | 8 1

Re: [Mesa-dev] test Vulkan with radv

2016-11-17 Thread XoD
Sorry, forgot my email. The radeon_icd.json file generated by mesa build are not in the path checked by vulkan loader. Just need to found how add an additional path for the vulkan driver json file. 2016-11-17 20:02 GMT+01:00 XoD : > Hello, I would like do some test with Vulkan, but I have not be

[Mesa-dev] [PATCH] i965: Disable depth writes when depth test is GL_EQUAL.

2016-11-17 Thread Kenneth Graunke
There's no point in performing depth writes when the depth test comparison function is set to GL_EQUAL - it would just write out the same value that's already there (if it is written at all). While this is harmless from a functional perspective, it hurts performance. Obviously, writing to memory i

[Mesa-dev] [PATCH] i965: Fix compute shader crash.

2016-11-17 Thread Kenneth Graunke
Fixes crashes when starting Deus Ex: Mankind Divided. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.c b/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH] i965: Disable depth writes when depth test is GL_EQUAL.

2016-11-17 Thread Anuj Phogat
On Thu, Nov 17, 2016 at 11:33 AM, Kenneth Graunke wrote: > There's no point in performing depth writes when the depth test > comparison function is set to GL_EQUAL - it would just write out > the same value that's already there (if it is written at all). While > this is harmless from a functional

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes > > Hi George,

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix compute shader crash.

2016-11-17 Thread Anuj Phogat
On Thu, Nov 17, 2016 at 11:37 AM, Kenneth Graunke wrote: > Fixes crashes when starting Deus Ex: Mankind Divided. > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] i965: Disable depth writes when depth test is GL_EQUAL.

2016-11-17 Thread Jason Ekstrand
On Nov 17, 2016 11:34 AM, "Kenneth Graunke" wrote: > > There's no point in performing depth writes when the depth test > comparison function is set to GL_EQUAL - it would just write out > the same value that's already there (if it is written at all). While > this is harmless from a functional per

[Mesa-dev] UDL & Modeset with Mesa 13.0.1 - Segmentation fault

2016-11-17 Thread poma
Airlie solved everything concerning the kernel, so it seems, now it's user space turn. = mesa-libgbm-12.0.3 - works OK ... [ 714.429] (II) Loading sub module "glamoregl" [ 714.429] (II) LoadModule: "glamoregl" [ 714.430] (II) Loading /usr/lib64/xorg/modules/libglamoregl.so [ 714.480] (II)

Re: [Mesa-dev] test Vulkan with radv

2016-11-17 Thread yavn
Hi, You should consult the docs for the loader and validation layers (e.g. here: https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/loader/LoaderAndLayerInterface.md). How the loader discovers drivers is platform-specific. TL;DR if you want to use a development driver,

Re: [Mesa-dev] [PATCH 00/20] RadeonSI: Optimized shader variants and other improvements

2016-11-17 Thread Edmondo Tommasina
Hi Marek This patch series is Tested-by: Edmondo Tommasina The performance of The Talos Principle benchmark has increased a bit on my configuration (RX 470). I repeated the test about 8 times and it was always better with your patches. Before: 36.5 FPS After: 36.8 FPS Other games tested: - The

[Mesa-dev] [PATCH 1/3] mesa: Add GL and GLSL plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Plamena Manolova
This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. Signed-off-by: Plamena Manolova --- include/GL/glext.h | 4 src/compiler/glsl/ast.h |

[Mesa-dev] [PATCH 3/3] i965: Add i965 plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Plamena Manolova
This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. Signed-off-by: Plamena Manolova --- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 2/3] nir: Add NIR plumbing ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Plamena Manolova
This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. Signed-off-by: Plamena Manolova --- src/compiler/shader_info.h | 1 + src/mesa/main/shaderapi.c | 1 + 2 files changed, 2 inserti

Re: [Mesa-dev] [PATCH v2] mesa: add NV_image_formats extension support

2016-11-17 Thread Ilia Mirkin
I believe the bit in src/mesa/main/mtypes.h can be removed. Otherwise, this is Reviewed-by: Ilia Mirkin It is customary to also include a note in relnotes/version.html that the ext was added. On Tue, Nov 15, 2016 at 6:16 AM, Lionel Landwerlin wrote: > v2: Replace helper function by qualifier s

Re: [Mesa-dev] [PATCH 1/3] mesa: Add GL and GLSL plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Ilia Mirkin
On Thu, Nov 17, 2016 at 3:27 PM, Plamena Manolova wrote: > This extension allows the fragment shader to control whether values in > gl_SampleMaskIn[] reflect the coverage after application of the early > depth and stencil tests. > > Signed-off-by: Plamena Manolova > --- > include/GL/glext.h

Re: [Mesa-dev] [PATCH 3/3] i965: Add i965 plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Ilia Mirkin
On Thu, Nov 17, 2016 at 3:27 PM, Plamena Manolova wrote: > This extension allows the fragment shader to control whether values in > gl_SampleMaskIn[] reflect the coverage after application of the early > depth and stencil tests. > > Signed-off-by: Plamena Manolova > --- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes > > Hi George,

Re: [Mesa-dev] test Vulkan with radv

2016-11-17 Thread Bas Nieuwenhuizen
Hi, One possible reason is that the radv driver can't find any hardware. This can happen for example if you use the radeon kernel driver, as only the amdgpu kernel driver is currently supported. I'm not sure what the error will be if the loader doesn't see radv at all. Yours sincerely, Bas Nieuw

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix empty program log length

2016-11-17 Thread Ian Romanick
Reviewed-by: Ian Romanick On 11/16/2016 11:16 PM, Tapani Pälli wrote: > In case we have empty log (""), we should return 0. This fixes > Khronos WebGL conformance test 'program-infolog'. > >>From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: >"If pname is INFO_LOG_LENGTH , the length of the info

[Mesa-dev] [PATCH] glsl: don't flatten if-blocks with dynamic array indices

2016-11-17 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes the regression of radeonsi in glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr caused by commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2. --- src/compiler/glsl/lower_if_to_cond_assign.cpp | 19 +-- 1 file changed, 17 insertions(+

[Mesa-dev] [PATCH 2/3] glsl/lower_output_reads: bail early in tessellation control shaders

2016-11-17 Thread Nicolai Hähnle
From: Nicolai Hähnle This whole pass is a no-op. --- src/compiler/glsl/lower_output_reads.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/lower_output_reads.cpp b/src/compiler/glsl/lower_output_reads.cpp index 8a375ac..b0045f0 100644 --- a/src/c

[Mesa-dev] [PATCH 3/3] glsl/lower_output_reads: remove unused mem_ctx

2016-11-17 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/compiler/glsl/lower_output_reads.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/glsl/lower_output_reads.cpp b/src/compiler/glsl/lower_output_reads.cpp index b0045f0..851078b 100644 --- a/src/compiler/glsl/lower_output_reads.cpp +++ b/src/com

[Mesa-dev] [PATCH 1/3] glsl/lower_output_reads: fix geometry shader output handling with conditional emit

2016-11-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Consider a geometry shader that contains code like this: some_out = expr; if (cond) { ... EmitVertex(); } else { ... EmitVertex(); } Both branches should see the correct value of some_out. Since this is a rather subtle and rare case, I'

[Mesa-dev] [PATCH] st/mesa: silence warnings in optimized builds

2016-11-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Mark variables and static functions that only occur in assert()s as MAYBE_UNUSED. --- src/mesa/state_tracker/st_sampler_view.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_sampler_view.c b/src/mesa/state_tracker/st_sample

Re: [Mesa-dev] [PATCH 2/3] glsl/lower_output_reads: bail early in tessellation control shaders

2016-11-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Nov 17, 2016 at 5:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This whole pass is a no-op. > --- > src/compiler/glsl/lower_output_reads.cpp | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/glsl/lower_outpu

Re: [Mesa-dev] [PATCH] st/mesa: silence warnings in optimized builds

2016-11-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Nov 17, 2016 at 5:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Mark variables and static functions that only occur in assert()s as > MAYBE_UNUSED. > --- > src/mesa/state_tracker/st_sampler_view.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletio

Re: [Mesa-dev] test Vulkan with radv

2016-11-17 Thread XoD
Thank you Yavn and Bas for the answers. I have successfully launched vulkaninfo, the problem came from the icd.json not loaded because of the path. The VK_ICD_FILENAMES env var will allow me to test correctly. @Bas: I have a R9 290 but I use a kernel with amdgpu (from mystro256) 2016-11-17 21:58

[Mesa-dev] [Bug 98767] [swrast] ralloc.c:84: get_header: Assertion `info->canary == CANARY' failed.

2016-11-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98767 Bug ID: 98767 Summary: [swrast] ralloc.c:84: get_header: Assertion `info->canary == CANARY' failed. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [Bug 98767] [swrast] ralloc.c:84: get_header: Assertion `info->canary == CANARY' failed.

2016-11-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98767 Vinson Lee changed: What|Removed |Added CC||emil.l.veli...@gmail.com,

[Mesa-dev] [AppVeyor] mesa master #2725 failed

2016-11-17 Thread AppVeyor
Build mesa 2725 failed Commit 0cee3fd5c7 by Jordan Justen on 11/16/2016 1:55 AM: i965/gen7: Minify blit size for stencil tree copy\n\nFound by the piglit 'fbo-depth-array stencil-clear' test when\nimplementing blorp blit splitting for gen7.\n\nSigned-off-by: Jo

[Mesa-dev] [PATCH 4/3] i965/hiz: Add debug dump for depth/hiz buffers around hiz ops

2016-11-17 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_blorp.c | 83 --- 1 file changed, 66 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 8aab1a7..d66bf14 1

Re: [Mesa-dev] Stable release process

2016-11-17 Thread Marek Olšák
On Thu, Nov 17, 2016 at 4:06 PM, Emil Velikov wrote: > On 15 November 2016 at 16:57, Marek Olšák wrote: >> On Tue, Nov 15, 2016 at 5:30 PM, Emil Velikov >> wrote: >>> On 15 November 2016 at 16:13, Marek Olšák wrote: I think that if people add the Cc stable tag to patches that are going >>

Re: [Mesa-dev] [PATCH] glsl: don't flatten if-blocks with dynamic array indices

2016-11-17 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 11/18/2016 08:59 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes the regression of radeonsi in > glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr > caused by commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2. > --- > src/compiler

Re: [Mesa-dev] [PATCH 1/3] glsl/lower_output_reads: fix geometry shader output handling with conditional emit

2016-11-17 Thread Edward O'Callaghan
Patches 1 & 3 are, Reviewed-by: Edward O'Callaghan and patch 2 is, Acked-by: Edward O'Callaghan On 11/18/2016 09:00 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Consider a geometry shader that contains code like this: > >some_out = expr; > >if (cond) { > ... > Emi

Re: [Mesa-dev] [PATCH] mesa: Add missing call to _mesa_unlock_debug_state(ctx);

2016-11-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 11/17/2016 08:23 AM, Tom Stellard wrote: > cd724208d3e1e3307f84a794f2c1fc83b69ccf8a added a call to > _mesa_lock_debug_state(ctx) but wasn't unlocking the debug state. > > This fixes a hang in glsl-fs-loop piglit test with MESA_DEBUG=context. > --- > src/galli

[Mesa-dev] [PATCH 1/4] swr: [rasterizer core] actually perform clear before store in GetHotTile

2016-11-17 Thread Ilia Mirkin
When switching render target array indexes (as might happen in a GS, or in a future change, with layered clears), if the previous state is HOTTILE_CLEAR, we should actually clear the tile before saving it off. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp | 1

[Mesa-dev] [PATCH 3/4] swr: [rasterizer core] pipe renderTargetArrayIndex through to clears

2016-11-17 Thread Ilia Mirkin
Currently clears only operate on the 0th array index (ignoring surface layout parameters). Instead normalize to take a RTAI like all the load/store tile logic does, and use ComputeSurfaceAddress to properly take the surface state's lod/array index into account. --- src/gallium/drivers/swr/rasteriz

[Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- With this patch, the layered-rendering clear tests pass, both with fast clear enabled and disabled. src/gallium/drivers/swr/swr_clear.cpp | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/s

[Mesa-dev] [PATCH 2/4] swr: [rasterizer core] clear data now comes in as float

2016-11-17 Thread Ilia Mirkin
The non-fast-clear path was never updated after clear colors were passed in as floats. Remove the now-harmful conversion from unorm8. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --g

[Mesa-dev] [PATCH] mesa: fix old classic drivers to use ralloc for ARB asm programs

2016-11-17 Thread Timothy Arceri
These changes were missed in 0ad69e6b5. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98767 --- src/mesa/program/arbprogparse.c | 4 ++-- src/mesa/program/ir_to_mesa.cpp | 7 +++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/arbprogparse.c b/src/mesa

[Mesa-dev] [Bug 98767] [swrast] ralloc.c:84: get_header: Assertion `info->canary == CANARY' failed.

2016-11-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98767 --- Comment #1 from Timothy Arceri --- I've sent a fix here: https://patchwork.freedesktop.org/patch/122114/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] Determinism in the results of llvmpipe?

2016-11-17 Thread Andrew A.
Hello, I'm using Mesa's software renderer for the purposes of regression testing in our graphics software. We render various scenes, save a screencap of the framebuffer for each scene, then compare those framebuffer captures to previously known-good captures. Across runs of these tests on the sam

Re: [Mesa-dev] Determinism in the results of llvmpipe?

2016-11-17 Thread Ilia Mirkin
On Thu, Nov 17, 2016 at 2:37 AM, Andrew A. wrote: > Hello, > > I'm using Mesa's software renderer for the purposes of regression > testing in our graphics software. We render various scenes, save a > screencap of the framebuffer for each scene, then compare those > framebuffer captures to previous

Re: [Mesa-dev] [PATCH] glsl: don't flatten if-blocks with dynamic array indices

2016-11-17 Thread Dylan Baker
Are you sure this is correct? Marek mentions in the referenced commit message that these pass on softpipe, and they work on i965 and i915 just fine. Dylan Quoting Nicolai Hähnle (2016-11-17 13:59:26) > From: Nicolai Hähnle > > This fixes the regression of radeonsi in > glsl-1.10/execution/varia

[Mesa-dev] [PATCH] swr: mark streamout buffers as written

2016-11-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_state.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp index 1c58d2a..520faea 100644 --- a/src/gallium/drivers/swr/swr_state.cpp +++ b/src/galliu

Re: [Mesa-dev] [PATCH 2/3] nir: Add NIR plumbing ARB_post_depth_coverage for i965 (gen9+).

2016-11-17 Thread Jason Ekstrand
Now that timothy has made shader_info shared, this patch should probably be squashed into the previous one. On Nov 17, 2016 12:28 PM, "Plamena Manolova" wrote: > This extension allows the fragment shader to control whether values in > gl_SampleMaskIn[] reflect the coverage after application of t

Re: [Mesa-dev] [PATCH] vc4: Fix resource leak

2016-11-17 Thread Eric Anholt
Mun Gwan-gyeong writes: > Add missed free() > > CID 1394322 > > Signed-off-by: Mun Gwan-gyeong Pushed this yesterday. Thanks! (I made a little change to the commit message summary, as as time goes on a project will end up with a lot of commits titled "vc4: Fix resource leak") signature.asc

Re: [Mesa-dev] Determinism in the results of llvmpipe?

2016-11-17 Thread Roland Scheidegger
Am 18.11.2016 um 02:11 schrieb Ilia Mirkin: > On Thu, Nov 17, 2016 at 2:37 AM, Andrew A. wrote: >> Hello, >> >> I'm using Mesa's software renderer for the purposes of regression >> testing in our graphics software. We render various scenes, save a >> screencap of the framebuffer for each scene, th

[Mesa-dev] [RFC]: clover: clSetCommandQueueProperty() implementation

2016-11-17 Thread Edward O'Callaghan
This is my initial attempt at implementing this for completeness. Tips and suggestions welcome! Please kindly review, Edward O'Callaghan (1): [PATCH] clover: Implement clSetCommandQueueProperty() from OpenCL 1.0 ___ mesa-dev mailing list mesa-dev@lists

[Mesa-dev] [PATCH] clover: Implement clSetCommandQueueProperty() from OpenCL 1.0

2016-11-17 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- include/CL/cl.h| 6 src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/queue.cpp| 34 ++ src/gallium/state_trackers/clover/core/queue.cpp | 3 +

Re: [Mesa-dev] [PATCH] clover: Implement clSetCommandQueueProperty() from OpenCL 1.0

2016-11-17 Thread Edward O'Callaghan
On 11/18/2016 02:25 PM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > include/CL/cl.h| 6 > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > src/gallium/state_trackers/clover/api/queue.cpp| 34 >

[Mesa-dev] [PATCH] radv: spir-v allows texture size query with and without lod.

2016-11-17 Thread Dave Airlie
From: Dave Airlie The translation to llvm was failing here due to required lod. This fixes some new SteamVR shaders. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/am

Re: [Mesa-dev] [PATCH 12/14] i965/vec4: Handle component qualifiers on non-generic varyings.

2016-11-17 Thread Timothy Arceri
Seems fine to me. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v4 01/10] mesa: removed redundant #else

2016-11-17 Thread George Kyriazis
--- src/util/macros.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index 733bf42..6f55ac6 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -178,7 +178,6 @@ do { \ # elif defined(_MSC_VER) && !defined(__INTEL_COMPILER) #

[Mesa-dev] [PATCH v4 00/10] Support windows builds for OpenSWR

2016-11-17 Thread George Kyriazis
Changes to support Windows scons builds for OpenSWR driver, since scons is the only supported build system for windows. Scons swr build will not work at this point. Also, windows scons swr build requires llvm version 3.9 (and above). Build on windows using the following command line: scons swr=

[Mesa-dev] [PATCH v4 07/10] swr: Windows-related changes

2016-11-17 Thread George Kyriazis
- Handle dynamic library loading for windows - Implement swap for gdi - fix prototypes - update include paths on configure-based build for swr_loader.cpp --- src/gallium/drivers/swr/swr_loader.cpp | 27 --- src/gallium/drivers/swr/swr_public.h | 9 + 2 files chan

[Mesa-dev] [PATCH v4 08/10] scons: Add swr compile option

2016-11-17 Thread George Kyriazis
To buils The SWR driver (currently optional, not compiled by default) --- common.py | 1 + 1 file changed, 1 insertion(+) diff --git a/common.py b/common.py index fb0884e..704ad2e 100644 --- a/common.py +++ b/common.py @@ -110,5 +110,6 @@ def AddOptions(opts): opts.Add(BoolOption('texture_fl

[Mesa-dev] [PATCH v4 05/10] swr: Handle windows.h and NOMINMAX

2016-11-17 Thread George Kyriazis
Reorder header files so that we have a chance to defined NOMINMAX before mesa include files include windows.h --- src/gallium/drivers/swr/swr_context.cpp | 16 src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/drivers/swr/swr_screen.cpp | 25 +++--

[Mesa-dev] [PATCH v4 02/10] scons: ignore .hpp files in parse_source_list()

2016-11-17 Thread George Kyriazis
Drivers that contain C++ .hpp files need to ignore them too, along with .h files, when building source file lists. --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index bdb4039..544b15d 100644 --- a/scons/custom.py +++ b/sco

[Mesa-dev] [PATCH v4 06/10] swr: renamed duplicate swr_create_screen()

2016-11-17 Thread George Kyriazis
There are 2 swr_create_screen() functions. One in swr_loader.cpp, which is used during driver init, and the other is hiding in swr_screen.cpp, which ends up in the arch-specific .dll/.so. Rename the second one to swr_create_screen_internal(), to avoid confusion in header files. --- src/gallium/d

[Mesa-dev] [PATCH v4 04/10] gallium: Added SWR support for gdi

2016-11-17 Thread George Kyriazis
Added hooks for screen creation and swap. Still keep llvmpipe the default software renderer. --- src/gallium/targets/libgl-gdi/libgl_gdi.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/gallium/targets/libgl-gdi/libgl_gdi.c b/src/gallium/tar

[Mesa-dev] [PATCH v4 03/10] scons: add llvm 3.9 support.

2016-11-17 Thread George Kyriazis
--- scons/llvm.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 1fc8a3f..977e47a 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -106,7 +106,24 @@ def generate(env): ]) env.Prepend(LIBPATH = [os.pa

[Mesa-dev] [PATCH v4 10/10] gallium: Add support for SWR compilation

2016-11-17 Thread George Kyriazis
Include swr library and include -DHAVE_SWR in the compile line. --- src/gallium/targets/libgl-gdi/SConscript | 4 src/gallium/targets/libgl-xlib/SConscript | 4 src/gallium/targets/osmesa/SConscript | 4 3 files changed, 12 insertions(+) diff --git a/src/gallium/targets/libgl-

[Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-17 Thread George Kyriazis
Also, modify gen_knobs.py so that each invocation creates a single generated file. This is more similar to how the other generators behave. --- src/gallium/SConscript | 1 + src/gallium/drivers/swr/Makefile.am| 15 +- src/gallium/drivers/swr/SConscri

[Mesa-dev] [PATCH v2 1/6] swr: [rasterizer memory] minify original sizes for block formats

2016-11-17 Thread Ilia Mirkin
There's no guarantee that mip width/height will be a multiple of the compressed block size. Doing a divide by the block size first yields different results than GL expects, so we do the divide at the end. Signed-off-by: Ilia Mirkin --- .../swr/rasterizer/memory/TilingFunctions.h| 36

[Mesa-dev] [PATCH v2 6/6] swr: avoid using exceptions for expected condition handling

2016-11-17 Thread Ilia Mirkin
I was getting a weird segfault from GCC 4.9.3: 0x754f27aa in strlen () from /lib64/libc.so.6 (gdb) bt #0 0x754f27aa in strlen () from /lib64/libc.so.6 #1 0x74f128e5 in get_cie_encoding (cie=cie@entry=0x76e09813) at /gcc-4.9.3/libgcc/unwind-dw2-fde.c:272 #2

[Mesa-dev] [PATCH v2 4/6] swr: remove unnecessary -1 entries in format mapping table

2016-11-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_screen.cpp | 126 - 1 file changed, 126 deletions(-) diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp index bc219bd..81b64a3 100644 --- a/src/gallium/drivers/sw

[Mesa-dev] [PATCH v2 2/6] swr: [rasterizer memory] minify texture width before alignment

2016-11-17 Thread Ilia Mirkin
The minification should happen before alignment, not after. See similar logic on ComputeLODOffsetY. The current logic requires unnecessarily large textures when there's an initial NPOT size. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/memory/TilingFunctions.h | 4 ++-- 1 fi

  1   2   >