Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Nicolai Hähnle
On 10.10.2016 05:45, Dave Airlie wrote: On 10 October 2016 at 13:25, Dave Airlie wrote: From: Dave Airlie This is a bit of a hack due to how llvm currently handles spilling in it's shader ABI. Currently llvm amdgpu backend uses relocations to patch the shader with the address of the tmpring.

[Mesa-dev] [PATCH v2 09/13] st/glsl_to_tgsi: mark "gaps" in input/output arrays as used

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle In some cases, a shader may have an input/output array but not use some entries in the middle. This happens with eON games, for example. We emit declarations that cover the entire array range even if there are some unused gaps. This patch now reflects that in the InputsRead

[Mesa-dev] [PATCH v2 00/13] st/mesa: finally finish ARB_enhanced_layouts

2016-10-10 Thread Nicolai Hähnle
Hi all, I've incorporated the minor comments I've received so far and fixed a regression related to structs that I had missed. Luckily the fix is pretty simple, because struct members cannot have explicit components. So it's enough to force their usage mask to XYZW, which means they will be treate

[Mesa-dev] [PATCH v2 07/13] st/glsl_to_tgsi: simpler fixup of empty writemasks

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Empty writemasks mean "copy everything", so we can always just use the number of vector elements (which uses the GLSL meaning here, i.e. each double is a single element/writemask bit). --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 37 -- 1 file

[Mesa-dev] [PATCH v2 02/13] tgsi/scan: fix num_inputs/num_outputs for shaders with overlapping arrays

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index c7745ce..85ab329 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_scan.c

[Mesa-dev] [PATCH v2 04/13] tgsi/ureg: add ureg_DECL_output_layout

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle For specifying an exact location/component. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 46 +++--- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 9 +++ 2 files changed, 40 insertions(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tg

[Mesa-dev] [PATCH v2 06/13] st/glsl_to_tgsi: explicit handling of writemask for depth/stencil export

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index bb88196..3c2870d 100644 --- a/src/mesa

[Mesa-dev] [PATCH v2 03/13] tgsi/ureg: add layout/component input declarations

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 69 +++--- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 21 +++ 2 files changed, 77 insertions(+), 13 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/

[Mesa-dev] [PATCH v2 05/13] glsl: dump explicit location when printing IR

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/compiler/glsl/ir_print_visitor.cpp | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index fc01be9..c238c16 100644 --- a/src/compiler/glsl/ir_print_visitor.c

[Mesa-dev] [PATCH v2 10/13] st/glsl_to_tgsi: explicitly track all input and output declaration

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle In order to be able to emit overlapping input and output array declarations, we flip the logic of emitting those declarations on its head: rather than iterating over slots and emitting the corresponding declarations, we iterate over the declarations from GLSL and emit those.

[Mesa-dev] [PATCH v2 12/13] st/mesa: enable ARB_enhanced_layouts and turn the cap on

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: mark llvmpipe & softpipe properly as well (Jason Wood) --- docs/features.txt| 18 +- docs/relnotes/12.1.0.html| 2 +- src/gallium/drivers/llvmpipe/lp_screen.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c | 2

[Mesa-dev] [PATCH v2 11/13] st/glsl_to_tgsi: adjust swizzles and writemasks for explicit components

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 68 +- 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 228d0b5..0c27ea5 100644 --- a/sr

[Mesa-dev] [PATCH v2 13/13] radeonsi: enable GLSL 4.50

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 5a3f101..6e7f6a3 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/sr

[Mesa-dev] [PATCH v2 08/13] st/glsl_to_tgsi: disable on-the-fly peephole for 64-bit operations

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle This optimization is incorrect with 64-bit operations, because the channel-splitting logic in emit_asm ends up being applied twice to the source operands. A lucky coincidence of how the writemask test works resulted in this optimization basically never being applied anyway.

[Mesa-dev] [PATCH v2 01/13] gallium: add PIPE_CAP_TGSI_ARRAY_COMPONENTS

2016-10-10 Thread Nicolai Hähnle
From: Nicolai Hähnle This is a screen cap because drivers are expected to support it either for all shader types or for none of them. --- src/gallium/docs/source/screen.rst | 8 src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c

Re: [Mesa-dev] [PATCH 02/22] intel/genxml: Add a uint MOCS field to 3DSTATE_STENCIL_BUFFER

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 08/10/16 05:41, Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml/gen9.xml | 1 + 5 files cha

Re: [Mesa-dev] [PATCH 10/32] genxml: Add a uint MOCS field to VERTEX_BUFFER_STATE

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/08/16 22:15, Jason Ekstrand wrote: --- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml/gen9.xml | 1 + 5 files changed, 5 insertions(+) diff --g

Re: [Mesa-dev] [PATCH 06/32] genxml: Add a uint MOCS field to DEPTH_BUFFER packets

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/08/16 22:15, Jason Ekstrand wrote: This is easier than dealing with structs all the time --- src/intel/genxml/gen6.xml | 2 ++ src/intel/genxml/gen7.xml | 2 ++ src/intel/genxml/gen75.xml | 2 ++ src/intel/genxml/gen8.xml | 2 ++ src/intel/genxml/ge

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Marek Olšák
I'd like the scratch buffer to be the first descriptor in RW_BUFFERS, that means s_load_dwordx2 ptr, s[0:1], 0x0. Please don't add any other user data SGPRs to radeonsi. Marek On Mon, Oct 10, 2016 at 10:06 AM, Nicolai Hähnle wrote: > On 10.10.2016 05:45, Dave Airlie wrote: >> >> On 10 October 2

Re: [Mesa-dev] [PATCH] gallium: Fix install-gallium-links.mk on non-bash /bin/sh

2016-10-10 Thread Nicolai Hähnle
On 07.10.2016 00:41, Eric Anholt wrote: Debian uses dash by default, which doesn't do '+='. Fixes servo's osmesa-based headless testing system, which was looking for libOSMesa in the lib/ directory. Looks straightforward enough to me. Reviewed-by: Nicolai Hähnle --- install-gallium-links.

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Marek Olšák
On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: > > > On 10/08/2016 06:58 PM, Jason Ekstrand wrote: >> >> FYI, we use ralloc for a lot more than just the glsl compiler so the >> first few changes make me a bit nervous. There was someone working on >> making our driver more I undefined-memory

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Marek Olšák
On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: > On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: >> >> >> On 10/08/2016 06:58 PM, Jason Ekstrand wrote: >>> >>> FYI, we use ralloc for a lot more than just the glsl compiler so the >>> first few changes make me a bit nervous. There was s

Re: [Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-10 Thread Emil Velikov
On 6 October 2016 at 18:51, Axel Davy wrote: > On systems with more than 4GB of ram, > os_get_total_physical_memory was triggering an integer > overflow for the linux and haiku path, when on > 32 bits. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94561 > > Signed-off-by: Axel Davy >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] i965/sync: Fix uninitalized usage and leak of mutex

2016-10-10 Thread Emil Velikov
On 7 October 2016 at 19:23, Chad Versace wrote: > On Thu 06 Oct 2016, Emil Velikov wrote: >> Hi Chad, >> >> On 4 October 2016 at 23:37, Chad Versace wrote: >> > We locked an unitialized mutex in the callstack >> > glClientWaitSync >> > intel_gl_client_wait_sync >> > brw_fence_client_w

Re: [Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

2016-10-10 Thread Emil Velikov
Hi Mauro, On 9 October 2016 at 11:13, Mauro Rossi wrote: > New generated headers were introduced by commit 63a366a > "intel: aubinator: generate a standalone binary" > > Once the generated files are listed in Makefile.sources variables, > Android build system requires rules to avoid building err

Re: [Mesa-dev] [PATCH 04/75] st/nine: Fix some check flags

2016-10-10 Thread Emil Velikov
On 6 October 2016 at 19:18, Axel Davy wrote: > On 06/10/2016 11:34, Emil Velikov wrote: >> >> On 5 October 2016 at 21:08, Axel Davy wrote: >>> >>> Uses the new defines introduced in previous commit. >>> >> Please describe why the newly introduced flags are used over the >> present ones. Worth cop

[Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Marek Olšák
From: Marek Olšák The kernel patch has been sent to amd-gfx. --- src/gallium/drivers/radeonsi/si_compute.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 1d1df2f..8a803c9 10064

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Tapani Pälli
On 10/10/2016 01:38 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: On 10/08/2016 06:58 PM, Jason Ekstrand wrote: FYI, we use ralloc for a lot more than just the glsl compiler so the first few changes make

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

2016-10-10 Thread Emil Velikov
On 7 October 2016 at 02:43, Michel Dänzer wrote: > On 07/10/16 05:44 AM, Eric Anholt wrote: >> Marek Olšák writes: >> >>> I'd like to have more feedback on the idea of using jemalloc for ralloc. >>> >>> Right now, I see these options: >>> >>> 1) Use jemalloc for ralloc and make it mandatory for a

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Marek Olšák
On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli wrote: > > > On 10/10/2016 01:38 PM, Marek Olšák wrote: >> >> On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: >>> >>> On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli >>> wrote: On 10/08/2016 06:58 PM, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Tapani Pälli
On 10/10/2016 02:27 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli wrote: On 10/10/2016 01:38 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: On 10/08/2016 06:58 PM, Jason Ekstra

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-10 Thread Marek Olšák
I prefer some of my GLSL fixes in 1-4 over JP's changes, because they seem cleaner to me. Marek On Oct 10, 2016 1:38 PM, "Tapani Pälli" wrote: > > > On 10/10/2016 02:27 PM, Marek Olšák wrote: > >> On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli >> wrote: >> >>> >>> >>> On 10/10/2016 01:38 PM, Ma

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Emil Velikov
Hi Eric, On 4 October 2016 at 10:30, Eric Engestrom wrote: > EGL_KHR_swap_buffers_with_damage is actually already supported, as it is > technically nothing but a rename of EGL_EXT_swap_buffers_with_damage. > > To that effect, both extension are advertised depending on the same > condition, and th

Re: [Mesa-dev] [PATCH] gallium: Fix install-gallium-links.mk on non-bash /bin/sh

2016-10-10 Thread Emil Velikov
On 6 October 2016 at 23:41, Eric Anholt wrote: > Debian uses dash by default, which doesn't do '+='. Fixes servo's > osmesa-based headless testing system, which was looking for libOSMesa in > the lib/ directory. Yes please :-) Reviewed-by: Emil Velikov IIRC Debian has a tool to check for bashi

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
Ping. 2016-10-06 19:50 GMT+02:00 Gustaw Smolarczyk : > It's supposed to be how much at least we want to grow the cs, not the > minimum size of the cs after growth. > > v2: Unbreak use_ib_bos. > Don't mask the ib_size when !use_ib_bos, since it's not needed. > --- > src/amd/vulkan/winsys/amdgp

[Mesa-dev] [Bug 98106] Primitive restart should be disabled for Draw commands when GL >= 4.5

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98106 Martina Kollarova changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] configure.ac: Rework LLVM dependency handling

2016-10-10 Thread Emil Velikov
Hi Tobias, On 8 October 2016 at 16:55, Tobias Droste wrote: > After this change each driver can request LLVM with a specific version > and specific targets/components anywhere. > > For gallium "--enable-gallium-llvm" is only needed if at least one > driver calls "gallium_require_llvm()". > If the

[Mesa-dev] [Bug 98182] Consider setting ctx->Version to the selected version, not highest supported version

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98182 Bug ID: 98182 Summary: Consider setting ctx->Version to the selected version, not highest supported version Product: Mesa Version: 11.2 Hardware: Other OS:

Re: [Mesa-dev] [PATCH] mesa: fix error handling in _mesa_TransformFeedbackVaryings

2016-10-10 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2016-10-10 at 09:49 +0300, Tapani Pälli wrote: > Patch changes function to use _mesa_lookup_shader_program_err both > in TransformFeedbackVaryings and GetTransformFeedbackVarying that > handles errors correctly for invalid values of shader program. > > Fix

[Mesa-dev] Fwd: errors for mesa master Android build 440

2016-10-10 Thread Rob Herring
New Android build error for gen6_xml.h... -- Forwarded message -- From: Date: Sat, Oct 8, 2016 at 3:56 AM Subject: errors for mesa master Android build 440 To: rob.herr...@linaro.org Build URL: https://ci.linaro.org/jenkins/job/robher-aosp/440/ Full log: https://ci.linaro.org/j

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
On Mon, Oct 10, 2016 at 01:07:57PM +0100, Emil Velikov wrote: > Hi Eric, > > On 4 October 2016 at 10:30, Eric Engestrom wrote: > > EGL_KHR_swap_buffers_with_damage is actually already supported, as it is > > technically nothing but a rename of EGL_EXT_swap_buffers_with_damage. > > > > To that eff

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #2 from Steven Toth --- Tests OK on glxgears, glxdemo and glxheads, on my platform (x86_64 Ubuntu 16.04), with NVIDIA GTX 950. I'll look at installing unigine. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #3 from Steven Toth --- I'm not familiar with Unigine and I'm having issues trying to get it to run with mesa tip. Your feedback is welcome. Testing with a Heaven-Unigine 4.0 binary downloaded today. Compiling/installing mesa tip to

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Emil Velikov
On 10 October 2016 at 15:37, Eric Engestrom wrote: >> > +static EGLBoolean EGLAPIENTRY >> > +eglSwapBuffersWithDamageKHR(EGLDisplay dpy, EGLSurface surface, >> > +EGLint *rects, EGLint n_rects) >> > +{ >> > + return eglSwapBuffersWithDamageEXT(dpy, surface, >> > +

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #4 from Christoph Haag --- Only thing I can think of is that you may need LIBGL_DRIVERS_PATH. Try LIBGL_DRIVERS_PATH=$PWD/root/lib/xorg/modules/dri/ or something like that. also LIBGL_DEBUG=verbose to check whether something goes wr

[Mesa-dev] [PATCH] nvc0/ir: fix overwriting of value backing non-constant gather offset

2016-10-10 Thread Ilia Mirkin
Normally the value is an immediate, which is moved to some temporary, so there's no problem. In the case of a non-constant offset (as allowed by ARB_gpu_shader5), we have to take care to copy it first before using it to build up the bits. This fixes a compilation error observed in F1 2015. Signed

[Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxiliary/tgsi/tgsi_text.c index be80842..36dc979 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_text

[Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Eric Anholt
--- I went to test-build my previous bash fix, and another area got broken in the meantime. src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index 8d7d40266383..160a41151795 100644 --- a/s

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Lionel Landwerlin
Thanks, I think that explains a problem I have in another patch. Reviewed-by: Lionel Landwerlin On 10/10/16 17:19, Eric Anholt wrote: --- I went to test-build my previous bash fix, and another area got broken in the meantime. src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertio

Re: [Mesa-dev] [PATCH] nvc0/ir: fix overwriting of value backing non-constant gather offset

2016-10-10 Thread Samuel Pitoiset
Confirmed. Reviewed-by: Samuel Pitoiset On 10/10/2016 06:12 PM, Ilia Mirkin wrote: Normally the value is an immediate, which is moved to some temporary, so there's no problem. In the case of a non-constant offset (as allowed by ARB_gpu_shader5), we have to take care to copy it first before usi

Re: [Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
On Mon, Oct 10, 2016 at 04:57:01PM +0100, Emil Velikov wrote: > On 10 October 2016 at 15:37, Eric Engestrom wrote: > > >> > +static EGLBoolean EGLAPIENTRY > >> > +eglSwapBuffersWithDamageKHR(EGLDisplay dpy, EGLSurface surface, > >> > +EGLint *rects, EGLint n_rects) > >

[Mesa-dev] [PATCH mesa v2] egl: add eglSwapBuffersWithDamageKHR

2016-10-10 Thread Eric Engestrom
EGL_KHR_swap_buffers_with_damage is actually already supported, as it is technically nothing but a rename of EGL_EXT_swap_buffers_with_damage. To that effect, both extension are advertised depending on the same condition, and the new entrypoint simply redirects to the previous one. Signed-off-by:

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Chad Versace
On Mon 10 Oct 2016, Eric Anholt wrote: > --- > > I went to test-build my previous bash fix, and another area got broken > in the meantime. > > src/intel/Makefile.genxml.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Emil Velikov
On 10 October 2016 at 17:19, Eric Anholt wrote: > --- > > I went to test-build my previous bash fix, and another area got broken > in the meantime. > > src/intel/Makefile.genxml.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/Makefile.genxml.am b/src/intel/Ma

Re: [Mesa-dev] [PATCH 10/22] intel/blorp: Add an entrypoint for clearing depth and stencil

2016-10-10 Thread Jason Ekstrand
Topi, There are some patches in this branch: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/i965-blorp-ds That I intend to send or squash in as part of a v2. Feel free to look at them and/or review preemptively. --Jason On Sun, Oct 9, 2016 at 11:00 PM, Pohjolainen, Topi < topi.pohjol

Re: [Mesa-dev] [PATCH] configure.ac: Rework LLVM dependency handling

2016-10-10 Thread Tobias Droste
Hi Emil, comments below. Am Montag, 10. Oktober 2016, 13:36:15 CEST schrieben Sie: > Hi Tobias, > > On 8 October 2016 at 16:55, Tobias Droste wrote: > > After this change each driver can request LLVM with a specific version > > and specific targets/components anywhere. > > > > For gallium "--e

[Mesa-dev] [RFC 01/12] egl: initialize SyncCondition after attr parsing

2016-10-10 Thread Chad Versace
From: Rob Clark Reduce the noise in the next patch. For EGL_SYNC_NATIVE_FENCE_ANDROID the sync condition is conditional on EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute. Signed-off-by: Rob Clark --- src/egl/main/eglsync.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [RFC 02/12] dri: extend fence extension to support native fd fences

2016-10-10 Thread Chad Versace
From: Rob Clark Required to implement EGL_ANDROID_native_fence_sync. Signed-off-by: Rob Clark --- include/GL/internal/dri_interface.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/inte

[Mesa-dev] [RFC 05/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Chad Versace Don't set SyncCondition twice. --- src/egl/main/eglsync.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c index ccfa474..b1b8c43 100644 --- a/src/egl/main/eglsync.c +++ b/src/egl/main/eglsync.c @@ -93,7 +93,6 @@ _eglInitSync(_

[Mesa-dev] [RFC 03/12] egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Rob Clark [chadv]: Resolve rebase conflicts. Signed-off-by: Rob Clark --- src/egl/drivers/dri2/egl_dri2.c | 49 + src/egl/main/eglapi.c | 36 +++--- src/egl/main/eglapi.h | 2 ++ src/egl/main/egldisplay.

[Mesa-dev] [RFC 00/12] egl, i965: Support EGL_ANDROID_native_fence_sync (v2)

2016-10-10 Thread Chad Versace
Background: This extension is needed by Android (via ARC++) on Chrome OS. Essentially, this extension provides a translation between EGLSync and explicit cross-process synchronization points, represented as "sync fds". The relevant documentation is: [1]: https://www.khrono

[Mesa-dev] [RFC 08/12] i965: Add intel_batchbuffer_flush_fence()

2016-10-10 Thread Chad Versace
From: Chad Versace A variant of intel_batchbuffer_flush() with parameters for in and out fence fds. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 25 +++-- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 14 -- 2 files changed, 27 insertions(+), 12 deletions

[Mesa-dev] [RFC 09/12] i965/sync: Add brw_fence::type

2016-10-10 Thread Chad Versace
This a refactor patch; no expected changed in behavior. Add `enum brw_fence_type` and brw_fence::type. There is only one type currently, BRW_FENCE_TYPE_BO_WAIT. This patch reduces a lot of noise in the next, which adds new type BRW_FENCE_TYPE_SYNC_FD. --- src/mesa/drivers/dri/i965/brw_sync.c | 10

[Mesa-dev] [RFC 04/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
Add EGL_KHR_debug tracing to eglDupNativeFenceFDANDROID, because all EGL entrypoints support tracing now. --- src/egl/main/eglapi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 3c0b017..449a2be 100644 --- a/src/egl/main/eglapi.c +++ b/sr

[Mesa-dev] [RFC 06/12] squash! egl: add EGL_ANDROID_native_fence_sync

2016-10-10 Thread Chad Versace
From: Chad Versace Close the sync fd *after* the sync's refcount drops to 0. --- src/egl/drivers/dri2/egl_dri2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 0c15c85..70ee270 100644 ---

[Mesa-dev] [RFC 07/12] i965: Add intel_screen::has_fence_fd

2016-10-10 Thread Chad Versace
From: Chad Versace This bool maps to I915_PARAM_HAS_EXEC_FENCE_FD. TODO: The i915 param is not yet upstream. Wait for the kernel interface before committing. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ src/mesa/drivers/dri/i965/intel_screen.h | 2 +- 2 files changed, 4 insertions(+

[Mesa-dev] [RFC 10/12] i965/sync: Fail sync creation with batchbuffer flush fails

2016-10-10 Thread Chad Versace
Pre-patch, brw_sync.c ignored the return value of intel_batchbuffer_flush(). When intel_batchbuffer_flush() fails during eglCreateSync (brw_dri_create_fence), we now give up, cleanup, and return NULL. When it fails during glFenceSync, however, we blindly continue and hope for the best because the

[Mesa-dev] [RFC 11/12] i965/sync: Rename brw_fence_insert()

2016-10-10 Thread Chad Versace
Rename to brw_fence_insert_locked(). This is correct because the fence's mutex is effectively locked, as all callers are also *creators* of the fence, and have not yet returned the new fence. This reduces noise in the next patch, which defines and uses brw_fence_insert(), an unlocked variant. ---

[Mesa-dev] [RFC 12/12] i965/sync: Implement fences based on Linux sync_file

2016-10-10 Thread Chad Versace
This patch implements a new type of struct brw_fence, one that is based struct sync_file. This completes support for EGL_ANDROID_native_fence_sync. * Background Linux 4.7 added a new file type, struct sync_file. See commit 460bfc41fd52959311ed0328163f785e023857af Author: Gustavo Pado

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 cokochiaki changed: What|Removed |Added CC||mayoc...@icloud.com OS|Linu

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC|lem...@gmail.com, | |pclo...@gmail.com

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC||mayoc...@icloud.com -- You are receiving t

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 cokochiaki changed: What|Removed |Added CC|ern...@gmail.com| -- You are receiving this mail because: Y

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Edmondo Tommasina
Reviewed-by: Edmondo Tommasina On Mon, Oct 10, 2016 at 1:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-10 Thread Alex Deucher
On Mon, Oct 10, 2016 at 7:25 AM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH] nvc0: fix valid range for shader buffers

2016-10-10 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Oct 9, 2016 at 4:17 PM, Samuel Pitoiset wrote: > When offset != 0, the valid range was wrong because the second > argument of util_range_add() is end, not size. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_compute.c|

Re: [Mesa-dev] [RFC 00/12] egl, i965: Support EGL_ANDROID_native_fence_sync (v2)

2016-10-10 Thread Rob Clark
On Mon, Oct 10, 2016 at 1:43 PM, Chad Versace wrote: > Background: > > This extension is needed by Android (via ARC++) on Chrome OS. > Essentially, this extension provides a translation between EGLSync and > explicit cross-process synchronization points, represented as "sync > fds"

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

2016-10-10 Thread Dave Airlie
On 10 October 2016 at 21:45, Arsenault, Matthew wrote: > I don't like adding explicit IR arguments for ABI arguments, especially this > one. Adding a special case for the first index feels dirty. The rest of llvm > also won't be aware of the specialness of the argument. It would be > problematic b

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Dave Airlie
On 11 October 2016 at 02:12, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Is this a problem you've seen somewhere, it's why in virgl I ended up dumping as hex for flt values. Reviewe

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Bas Nieuwenhuizen
Hi Gustaw, The patch is reviewed-by: Bas Nieuwenhuizen What needs to be done too, is checking if the resulting IB becomes too large in the SI case, and handling that gracefully. I don't care if that happens with this patch, or if someone writes a follow up patch though Yours sincerely, Bas Nieu

Re: [Mesa-dev] [PATCH v2 04/13] tgsi/ureg: add ureg_DECL_output_layout

2016-10-10 Thread Dave Airlie
On 10 October 2016 at 18:32, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > For specifying an exact location/component. Any reason you have the args ordering different, that seems like it might get confusing. I'd prefer you kept the output_layout and output_masked ordering the same and stick

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen : > Hi Gustaw, > > The patch is > reviewed-by: Bas Nieuwenhuizen Thanks, please push it since I don't have commit access. > > What needs to be done too, is checking if the resulting IB becomes too > large in the SI case, and handling that gracefully.

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
On Mon, Oct 10, 2016 at 3:59 PM, Dave Airlie wrote: > On 11 October 2016 at 02:12, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) > > Is this a problem you've seen somewhere, it's w

Re: [Mesa-dev] [PATCH 16/22] anv/hiz: Perform HiZ resolves for all partial renders

2016-10-10 Thread Nanley Chery
On Fri, Oct 07, 2016 at 09:41:14PM -0700, Jason Ekstrand wrote: > If we don't, we can end up with corruption in the portion of the depth > buffer that lies outside the render area when we do a HiZ resolve at the > end. The only reason we weren't seeing this before was that all of the > meta-based

[Mesa-dev] [PATCH v2] mesa/extensions: expose OES_vertex_half_float for ES2

2016-10-10 Thread Kevin Strasser
Half float support already exists for desktop GL. Reuse the ARB_half_float_vertex enable bit and account for the different enum to enable the extension for ES2. Signed-off-by: Kevin Strasser Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 2 ++ src/mesa/main/exten

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Roland Mainz
On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c > b/src/gallium/auxiliary/tgsi/tgsi_text.c > inde

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Ilia Mirkin
On Mon, Oct 10, 2016 at 5:36 PM, Roland Mainz wrote: > On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium/auxiliary/tgsi/

Re: [Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-10 Thread Axel Davy
On 10/10/2016 12:44, Emil Velikov wrote: On 6 October 2016 at 18:51, Axel Davy wrote: On systems with more than 4GB of ram, os_get_total_physical_memory was triggering an integer overflow for the linux and haiku path, when on 32 bits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=9456

Re: [Mesa-dev] [PATCH] tgsi: fix parsing nan float inputs

2016-10-10 Thread Roland Mainz
On Mon, Oct 10, 2016 at 11:40 PM, Ilia Mirkin wrote: > On Mon, Oct 10, 2016 at 5:36 PM, Roland Mainz > wrote: >> On Mon, Oct 10, 2016 at 6:12 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/gallium/auxiliary/tgsi/tgsi_text.c | 7 ++- >>> 1 file changed, 6 insertions(

Re: [Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

2016-10-10 Thread Mauro Rossi
2016-10-10 13:04 GMT+02:00 Emil Velikov : > Hi Mauro, > > On 9 October 2016 at 11:13, Mauro Rossi wrote: > >> New generated headers were introduced by commit 63a366a >> "intel: aubinator: generate a standalone binary" >> >> Once the generated files are listed in Makefile.sources variables, >> Andr

[Mesa-dev] [PATCH 1/5] anv/cmd_buffer: Clarify HZ rectangle behavior

2016-10-10 Thread Nanley Chery
This behavior differs from what's described in the PRMs and was observed by analyzing CTS test results. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/

[Mesa-dev] [PATCH 3/5] anv/cmd_buffer: Rename full_surface_op to full_surf_clear

2016-10-10 Thread Nanley Chery
This matches the HW docs and specifies what the variable is actually concerned with. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/gen8_cm

[Mesa-dev] [PATCH 4/5] anv/cmd_buffer: Manage Anv state around HZ op emission

2016-10-10 Thread Nanley Chery
Move the assignment to a less surprising location. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/gen8_cmd_buffer.c index 97a035b..330f7

[Mesa-dev] [PATCH 2/5] anv/cmd_buffer: Delay variable assignment in HZ function

2016-10-10 Thread Nanley Chery
Delay the assignment of some variables until we know they will be used. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan

[Mesa-dev] [PATCH 5/5] anv/cmd_buffer: Enable stencil-only HZ clears

2016-10-10 Thread Nanley Chery
The HZ sequence modifies less state than the meta path and requires less CPU time to be generated. Signed-off-by: Nanley Chery --- src/intel/vulkan/gen8_cmd_buffer.c | 63 ++ 1 file changed, 43 insertions(+), 20 deletions(-) diff --git a/src/intel/vulkan/gen8

[Mesa-dev] V5 Loop unrolling in NIR

2016-10-10 Thread Timothy Arceri
Again thanks to Jason and Connor for their feedback, and to Thomas for getting this work started. V5: Has been updated to reflect Jasons feedback and also some changes from self review after not looking at this for a few weeks. total instructions in shared programs: 8530600 -> 8530365 (-0.00%) i

[Mesa-dev] [PATCH v5 05/10] nir: don't count removal of lcssa_phi as progress

2016-10-10 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_remove_phis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index acaa6e1..d4344b0 100644 --- a/src/compiler/nir/nir_opt_remove_phis.c +++ b/src/compiler/nir/nir_o

[Mesa-dev] [PATCH v5 03/10] nir: Add a loop analysis pass

2016-10-10 Thread Timothy Arceri
From: Thomas Helland This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I don't see it as common enoug

[Mesa-dev] [PATCH v5 02/10] i965: use nir_lower_indirect_derefs() for GLSL

2016-10-10 Thread Timothy Arceri
This moves the nir_lower_indirect_derefs() call into brw_preprocess_nir() so thats is called by both OpenGL and Vulkan and removes that call to the old GLSL IR pass lower_variable_index_to_cond_assign() We want to do this pass in nir to be able to move loop unrolling to nir. There is a increase o

[Mesa-dev] [PATCH v5 01/10] i965: allow sampler indirects on all gens

2016-10-10 Thread Timothy Arceri
Without this we will regress the max-samplers piglit test on Gen6 and lower when loop unrolling is done in NIR. There is a check in the GLSL IR linker that errors when it finds indirects and EmitNoIndirectSampler is set. As far as I can tell there is no reason for not enabling this for all gens re

  1   2   >