Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

Hi Emil, Thanks for taking care so far. On Wednesday, 7 September 2016 12:18:24 CEST Emil Velikov wrote: > On 6 September 2016 at 18:32, Mathias Fröhlich > wrote: > > >> ** EGL_EXT_output_drm > Correction - the above should read: EGL_EXT_{device,output}_drm > > >> *** Using/exposing the card

Re: [Mesa-dev] [PATCH 02/57] i965/vec4: Replace dst/src_reg::reg_offset with dst/src_reg::offset expressed in bytes.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: (...) >  src/mesa/drivers/dri/i965/brw_ir_vec4.h|  4 +- >  src/mesa/drivers/dri/i965/brw_vec4.cpp | 61 > -- >  .../drivers/dri/i965/brw_vec4_cmod_propagation.cpp |  2 +- >  .../drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 03/57] i965/ir: Remove backend_reg::reg_offset.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > --- >  src/mesa/drivers/dri/i965/brw_shader.cpp |  2 -- >  src/mesa/drivers/dri/i965/brw_shader.h   | 15 ++- >  2 files changed, 2 insertions(+), 15 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/sr

[Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

This fixes a crash when using the prefered video format with vaapisink on Nvidia hardwares. Also caught by the following assert: nouveau_vp3_video.c:91: Assertion `templat->interlaced' failed. TEST= gst-launch-1.0 videotestsrc ! video/x-raw, format=NV12 ! vaapisink Signed-off-by: Julien Isorce

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 09/07/2016 04:06 PM, Emil Velikov wrote: On 7 September 2016 at 13:10, Mauro Rossi wrote: 2016-09-07 12:56 GMT+02:00 Emil Velikov : On 7 September 2016 at 11:01, Mauro Rossi wrote: Hi Tapani, does moving the declaration of the dependency to src/mesa/drivers/dri/i965/Android.mk also wo

Re: [Mesa-dev] [PATCH] egl: Document why EGL_OPENGL{, _ES}_API are mostly identical

On 07/09/16 23:41, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > src/egl/main/eglcontext.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c > index ebc004d..057b60f 100644 > --- a/src/egl/main/eglcontext.c >

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Am 08.09.2016 um 09:34 schrieb Julien Isorce: This fixes a crash when using the prefered video format with vaapisink on Nvidia hardwares. Also caught by the following assert: nouveau_vp3_video.c:91: Assertion `templat->interlaced' failed. TEST= gst-launch-1.0 videotestsrc ! video/x-raw, forma

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

Am 08.09.2016 um 08:23 schrieb Michel Dänzer: On 08/09/16 01:13 PM, Nayan Deshmukh wrote: On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer mailto:mic...@daenzer.net>> wrote: On 08/09/16 02:48 AM, Nayan Deshmukh wrote: > use a linear buffer in case of back buffer > > Signed-off-b

Re: [Mesa-dev] [PATCH 04/57] i965/fs: Replace fs_reg::subreg_offset with fs_reg::offset expressed in bytes.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > The fs_reg::subreg_offset and ::offset fields are now redundant, the > sub-GRF offset can just be added to the single ::offset field > expressed in byte units.  The current subreg_offset value can be > recovered by applying the following r

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

On 08/09/16 05:05 PM, Christian König wrote: > Am 08.09.2016 um 08:23 schrieb Michel Dänzer: >> On 08/09/16 01:13 PM, Nayan Deshmukh wrote: >>> On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer >> > wrote: >>> On 08/09/16 02:48 AM, Nayan Deshmukh wrote: >>> > use a

Re: [Mesa-dev] [PATCH 07/57] i965/fs: Replace fs_inst::regs_written with ::size_written field in bytes.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: (...) > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > index 12ab7b3..a678351 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > +++ b/src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

Am 08.09.2016 um 10:42 schrieb Michel Dänzer: On 08/09/16 05:05 PM, Christian König wrote: Am 08.09.2016 um 08:23 schrieb Michel Dänzer: On 08/09/16 01:13 PM, Nayan Deshmukh wrote: On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer mailto:mic...@daenzer.net>> wrote: On 08/09/16 02:48 AM, Naya

[Mesa-dev] [Bug 96737] [GLX] Xsession Log In breakage - Switch User / Switch To Greeter / VT Switch related

https://bugs.freedesktop.org/show_bug.cgi?id=96737 poma changed: What|Removed |Added QA Contact|xorg-t...@lists.x.org |mesa-dev@lists.freedesktop. |

Re: [Mesa-dev] [PATCH 06/57] i965/vec4: Add wrapper functions for vec4_instruction::regs_read and ::regs_written.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > This is in preparation for dropping vec4_instruction::regs_read and > ::regs_written in favor of more accurate alternatives expressed in > byte units.  The main reason these wrappers are useful is that a > number of optimization passes imp

[Mesa-dev] [Bug 96737] [GLX] Xsession Log In breakage - Switch User / Switch To Greeter / VT Switch related

https://bugs.freedesktop.org/show_bug.cgi?id=96737 poma changed: What|Removed |Added Hardware|All |x86-64 (AMD64) -- You are receiving this mail be

[Mesa-dev] [Bug 96737] [GLX] Xsession Log In breakage - Switch User / Switch To Greeter / VT Switch related

https://bugs.freedesktop.org/show_bug.cgi?id=96737 --- Comment #14 from poma --- SW: kernel-4.8.0-0.rc5.git1.1.fc26.x86_64 libdrm-2.4.70-2.fc26.x86_64 xorg-x11-server-Xorg-1.18.4-5.fc26.x86_64 mesa-dri-drivers-12.0.2-1.fc26.x86_64 lightdm-1.19.4-2.fc26.x86_64 lightdm-gtk-2.0.1-8.fc26.x86_64 sddm-

[Mesa-dev] [Bug 96737] [GLX] Xsession Log In breakage - Switch User / Switch To Greeter / VT Switch related

https://bugs.freedesktop.org/show_bug.cgi?id=96737 --- Comment #15 from poma --- dmesg: ... nouveau :02:00.0: disp: ERROR 5 [INVALID_STATE] 0b [] chid 1 mthd 0080 data nouveau :02:00.0: disp: Base 1: nouveau :02:00.0: disp: 0084: nouveau :02:00.

Re: [Mesa-dev] [PATCH 11/57] i965/vec4: Replace vec4_instruction::regs_read with ::size_read using byte units.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > The previous regs_read value can be recovered by rewriting each > reference of regs_read() like 'x = i.regs_read(j)' to 'x = > DIV_ROUND_UP(i.size_read(j), reg_unit)'. > > For the same reason as in the previous patches, this doesn't attem

Re: [Mesa-dev] [PATCH 00/57] i965/ir: Switch representation of register offsets and sizes to byte units.

On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > This series reworks the representation of register region offsets in > the i965 IR to be universally byte-based instead of the rather > awkward > split between reg_offset and subreg_offset we have in the FS back-end > right now, or the reg

Re: [Mesa-dev] [PATCH] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

Ping .. On 08/26/2016 10:47 AM, Tapani Pälli wrote: From: Haixia Shi Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to hard-coded non-zero values. These two attributes are required on Android. v2: use _EGL_MAX_PBUFFER_WIDTH/HEIGHT from egldefines.h (based on discus

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Thu, Sep 8, 2016 at 3:56 AM, Michel Dänzer wrote: > On 07/09/16 11:01 PM, Nicolai Hähnle wrote: >> On 07.09.2016 12:23, Marek Olšák wrote: >>> On Wed, Sep 7, 2016 at 11:47 AM, Michel Dänzer >>> wrote: On 07/09/16 06:02 PM, Marek Olšák wrote: > > Based on the comments so far, it lo

[Mesa-dev] Comments on adding a GLSL_OPT_PASS macro and option in glsl_compiler_options

Hi, I have some old code lying around that I was considering picking up again. The thought basically goes something like this: Have a enum representing the compiler optimization passes in glsl. Have an array of enums that define an optimization pass order. Have a default array for glsl compiler o

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

On 02/09/16 23:13, Kenneth Graunke wrote: > On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: >> This fixes a numerical precision issue that was causing two CTS >> failures: >> >> ES31-CTS.blend_equation_advanced.blend_specific.GL_COLORBURN_KHR >> ES31-CTS.blend_equation_advanced.bl

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 8 September 2016 at 08:19, Mathias Fröhlich wrote: > Hi Emil, > > Thanks for taking care so far. > > On Wednesday, 7 September 2016 12:18:24 CEST Emil Velikov wrote: >> On 6 September 2016 at 18:32, Mathias Fröhlich >> wrote: >> >> >> ** EGL_EXT_output_drm >> Correction - the above should rea

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 7 September 2016 at 19:54, James Jones wrote: > On 09/07/2016 04:18 AM, Emil Velikov wrote: >> >> Hi Mathias, >> >> On 6 September 2016 at 18:32, Mathias Fröhlich >> wrote: >> ** EGL_EXT_output_drm >> >> Correction - the above should read: EGL_EXT_{device,output}_drm >> *** Using/e

[Mesa-dev] swr: Context destruction needs to wait on fences

Still playing with OpenSWR and I found some issues with glmark2 when running on a (OpenSWR originally intended) many core system. glmark2 seems to enjoy creating and destroying GLX contexts without destroying the 'screen' and OpenSWR doesn't seem to have tested such scenarios. The two related iss

[Mesa-dev] swr: RDTSC StopCapture hangs

Again playing with OpenSWR running on a (OpenSWR originally intended) many core system. When enabling RDTSC Buckets profiling sometimes OpenSWR gets stuck on StopCapture. StopCapture waits for all the threads to close all the pending buckets (expects threads to be at bucket level 0) but the probl

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

Ping. This patch fixes a significant amount of CTS tests and it will be nice to have it reviewed. On sáb, 2016-09-03 at 03:04 +0200, Antia Puentes wrote: > - Fixes CTS tests: > > * GL44-CTS.shader_image_size.advanced-nonMS-cs-float > * GL44-CTS.shader_image_size.advanced-nonMS-cs-int > * GL44-CTS.

[Mesa-dev] [PATCH v2] gallium: fix return value check

A possible error (-1) was being lost because it was first converted to an unsigned int and only then checked. Reviewed-by: Nicolai Hähnle Signed-off-by: Martina Kollarova --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

Re: [Mesa-dev] [PATCH] gallium: remove PIPE_BIND_TRANSFER_READ/WRITE

Looks reasonable to me, seems like the transfer stuff didn't quite turn out like initially expected. Reviewed-by: Roland Scheidegger Am 07.09.2016 um 21:37 schrieb Marek Olšák: > From: Marek Olšák > > not used in any useful way > --- > src/gallium/auxiliary/util/u_debug.c| 2

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

On 09/08/2016 03:50 AM, Christian König wrote: Am 08.09.2016 um 09:34 schrieb Julien Isorce: This fixes a crash when using the prefered video format with vaapisink on Nvidia hardwares. Also caught by the following assert: nouveau_vp3_video.c:91: Assertion `templat->interlaced' failed. TEST

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Tue, 2016-08-02 at 19:14 +0300, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- > .dir-locals.el | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/.dir-locals.el b/.dir-locals.el

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Tue, Aug 2, 2016 at 12:14 PM, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- > .dir-locals.el | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index 4b53931..9c89a63 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.e

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

Thanks. Rb On Sep 7, 2016 8:29 PM, "Chad Versace" wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > libraries. > > Cc: Kevin Strasser > Cc: Jason

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 09/08/2016 04:30 AM, Emil Velikov wrote: On 7 September 2016 at 19:54, James Jones wrote: On 09/07/2016 04:18 AM, Emil Velikov wrote: Hi Mathias, On 6 September 2016 at 18:32, Mathias Fröhlich wrote: ** EGL_EXT_output_drm Correction - the above should read: EGL_EXT_{device,output}_d

Re: [Mesa-dev] [v3 4/6] i965/rbc: Consult rb settings for texture surface setup

On Sep 7, 2016 9:30 PM, "Pohjolainen, Topi" wrote: > > On Wed, Sep 07, 2016 at 03:25:30PM -0700, Jason Ekstrand wrote: > >On Sep 7, 2016 10:24 AM, "Topi Pohjolainen" > ><[1]topi.pohjolai...@gmail.com> wrote: > >> > >> Once mcs buffer gets allocated without delay for lossless > >

[Mesa-dev] [Bug 96737] [GLX] Xsession Log In breakage - Switch User / Switch To Greeter / VT Switch related

https://bugs.freedesktop.org/show_bug.cgi?id=96737 poma changed: What|Removed |Added Component|GLX |Drivers/DRI/nouveau QA Contact|mesa-dev@l

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

On 8 September 2016 at 04:29, Chad Versace wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > libraries. > Pretty sure that was the "must fix" part of

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, 2016-09-08 at 09:59 -0400, Ilia Mirkin wrote: > On Tue, Aug 2, 2016 at 12:14 PM, Andres Gomez wrote: > > Signed-off-by: Andres Gomez > > --- > > .dir-locals.el | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/.dir-locals.el b/.dir-locals.el > > ind

Re: [Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

On Thu, Sep 8, 2016 at 12:01 PM, Andres Gomez wrote: > On Thu, 2016-09-08 at 09:59 -0400, Ilia Mirkin wrote: >> On Tue, Aug 2, 2016 at 12:14 PM, Andres Gomez wrote: >> > Signed-off-by: Andres Gomez >> > --- >> > .dir-locals.el | 9 +++-- >> > 1 file changed, 7 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

Should the title the say needed instead of unneeded? - Nanley On Wed, Sep 07, 2016 at 08:29:30PM -0700, Chad Versace wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS,

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

On Thu 08 Sep 2016, Emil Velikov wrote: > On 8 September 2016 at 04:29, Chad Versace wrote: > > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > > But it's needed only if HAVE_PLATFORM_X11. > > > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > > libr

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

On 8 September 2016 at 16:29, James Jones wrote: > On 09/08/2016 04:30 AM, Emil Velikov wrote: >> >> On 7 September 2016 at 19:54, James Jones wrote: >>> >>> On 09/07/2016 04:18 AM, Emil Velikov wrote: Hi Mathias, On 6 September 2016 at 18:32, Mathias Fröhlich wrote

Re: [Mesa-dev] [PATCH] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

On 8 September 2016 at 10:39, Tapani Pälli wrote: > Ping .. > > > On 08/26/2016 10:47 AM, Tapani Pälli wrote: >> >> From: Haixia Shi >> >> Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to >> hard-coded non-zero values. These two attributes are required on Android. >> >> v

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

On Fri, Sep 2, 2016 at 6:04 PM, Antia Puentes wrote: > - Fixes CTS tests: > > * GL44-CTS.shader_image_size.advanced-nonMS-cs-float > * GL44-CTS.shader_image_size.advanced-nonMS-cs-int > * GL44-CTS.shader_image_size.advanced-nonMS-cs-uint > * GL44-CTS.shader_image_size.advanced-nonMS-gs-float > * G

[Mesa-dev] [Bug 97643] Shader crashes radeon driver and brings the whole system down

https://bugs.freedesktop.org/show_bug.cgi?id=97643 Bug ID: 97643 Summary: Shader crashes radeon driver and brings the whole system down Product: Mesa Version: 12.0 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/3] egl: return corresponding offset of EGLImage instead of 0.

Hi, That doesn't seem good to me. With that patch, that means that since no one is implementing __DRI_IMAGE_ATTRIB_OFFSET (yes I know in a later patch you implement it for i965), then what used to work will stop working (as the queryImage will return false). You need to introduce some inte

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

Hi all, On 7 September 2016 at 16:54, Jonathan Gray wrote: > On Wed, Sep 07, 2016 at 11:52:39PM +1000, Timothy Arceri wrote: >> On Wed, 2016-09-07 at 19:26 +1000, Jonathan Gray wrote: >> > LLVM was imported yes, but the integration of it has only >> > started around the same time and it is not en

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

On 1 September 2016 at 18:12, Jonathan Gray wrote: > program_invocation_short_name is a gnu extension. Limit use of it > to glibc and cygwin and otherwise use getprogname() which is available > on BSD and OS X. > > Signed-off-by: Jonathan Gray > --- > src/intel/tools/aubinator.c | 8 +++- >

[Mesa-dev] [Bug 97643] Shader crashes radeon driver and brings the whole system down

https://bugs.freedesktop.org/show_bug.cgi?id=97643 --- Comment #1 from Iaroslav Andrusyak --- works fine on 7970 and mesa-git,llvm-git vo=opengl-hq:user-shaders="/home/pont/CrossBilateral.glsl" http://pastebin.com/6TNTa6ry -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [PATCH 0/7] Implement EGL_KHR_debug (v2)

This rebases Kyle's series atop master (the change to treat GL and GLES identically created some merge conflicts), and ports a fix from glvnd's handling of DebugMessageControl. I'm working on piglits to cover this, and a very basic first test is on the list now. As glvnd's EGL interface essentiall

[Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

From: Kyle Brenneman Updated eglext.h to revision 32074 from the Khronos repository. Added two #includes to egltypedefs.h. Both were in the previous version of eglext.h but not in the new one. Reviewed-by: Adam Jackson --- include/EGL/eglext.h | 36 ++--

[Mesa-dev] [PATCH 5/7] EGL: Record the debug object label in _EGLThreadInfo

From: Kyle Brenneman Added a field to _EGLThreadInfo to hold the object label for the current EGL function call. Changed the _EGL_FUNC_START macro and _eglSetFuncName function to take an object type enum and an _EGLResource pointer, which it uses to fill in the object label. Removed the command

[Mesa-dev] [PATCH 2/7] EGL: Implement eglLabelObjectKHR

From: Kyle Brenneman Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource structs. Implemented the function eglLabelObjectKHR. Reviewed-by: Adam Jackson --- src/egl/main/eglapi.c | 63 +++ src/egl/main/eglcurrent.c | 9 +++ src/

[Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

From: Kyle Brenneman Implemented eglDebugMessageControlKHR and eglQueryDebugKHR. Added entries in _egl_global to hold the debug callback and the set of enabled message types. Added a _eglDebugReport function to report a debug message, plus some macros for each of the message types. Still to do

[Mesa-dev] [PATCH 4/7] EGL: Call the EGL_KHR_debug callback on errors

From: Kyle Brenneman Added a member to _EGLThreadInfo to hold the name of the current EGL function. Each EGL entrypoint will now set that at the beginning. _eglError will now call the debug callback function, using the function name stored in the current _EGLThreadInfo struct. This should allow

[Mesa-dev] [PATCH 6/7] EGL: Fix some command names for EGL_KHR_debug

From: Kyle Brenneman Change a few EGL entrypoints to call a common internal function instead of forwarding to another entrypoint. If one EGL entrypoint calls another, then the second entrypoint would overwrite the current function name in the _EGLThreadInfo struct. That would cause it to pass th

[Mesa-dev] [PATCH 7/7] egl: Fix DebugMessageControl(callback, NULL)

Treat a null attribute list as meaning "don't change attributes". This is semantically equivalent to a list consisting of just EGL_NONE. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/

[Mesa-dev] [PATCH 1/2] isl/state: Don't set QPitch for GEN4_3D surfaces

--- src/intel/isl/isl_surface_state.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index 979e140..f8ea122 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_s

[Mesa-dev] [PATCH 2/2] intel/isl: Divide QPitch by 2 for 3-D stencil textures on SKL+

--- src/intel/isl/isl_surface_state.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index f8ea122..22fef3d 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_sta

[Mesa-dev] [Bug 97643] Shader crashes radeon driver and brings the whole system down

https://bugs.freedesktop.org/show_bug.cgi?id=97643 --- Comment #2 from Cris --- (In reply to Iaroslav Andrusyak from comment #1) > works fine on 7970 and mesa-git,llvm-git > vo=opengl-hq:user-shaders="/home/pont/CrossBilateral.glsl" > > http://pastebin.com/6TNTa6ry I forgot to mention that fo

Re: [Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

On 1 September 2016 at 18:23, Jonathan Gray wrote: > OpenBSD now has strict W^X enforcement. Processes that violate > the policy get killed by the kernel. Don't attempt to use > executable memory on OpenBSD to avoid this. > > Patch from Mark Kettenis. > > --- a/src/gallium/auxiliary/rtasm/rtasm

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

On Wed, Sep 7, 2016 at 1:16 PM, Jason Ekstrand wrote: > On Sep 7, 2016 10:45 AM, "Nanley Chery" wrote: > > > > On Wed, Sep 07, 2016 at 10:26:25AM -0700, Jason Ekstrand wrote: > > > On Wed, Sep 7, 2016 at 9:50 AM, Jason Ekstrand > wrote: > > > > > > > On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery

Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

This one has the a bug in it where it doesn't set the callback if (attrib_list == NULL), plus the more minor bug where it doesn't check for invalid attributes if (callback == NULL). The first one is the same bug you noticed in libglvnd, which got copied over when I adapted it for Mesa. I can fi

Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

On Thu, 2016-09-08 at 11:57 -0600, Kyle Brenneman wrote: > This one has the a bug in it where it doesn't set the callback if  > (attrib_list == NULL), plus the more minor bug where it doesn't check  > for invalid attributes if (callback == NULL). The first one is the same  > bug you noticed in libg

Re: [Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

On Thu, Sep 08, 2016 at 06:57:44PM +0100, Emil Velikov wrote: > On 1 September 2016 at 18:23, Jonathan Gray wrote: > > OpenBSD now has strict W^X enforcement. Processes that violate > > the policy get killed by the kernel. Don't attempt to use > > executable memory on OpenBSD to avoid this. > >

[Mesa-dev] [PATCH 1/2] nir/lower_tex: remove tex_instr_find_src()

Turns out it already exists.. so don't duplicate it. Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_tex.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index 93637a3..b570598 100

[Mesa-dev] [PATCH 2/2] nir: move tex_instr_remove_src

I want to re-use this in a different pass, so move to nir.h Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 16 src/compiler/nir/nir_lower_tex.c | 20 ++-- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/compiler/nir/nir.h b/s

[Mesa-dev] [PATCH] EGL: Fix some errors in eglDebugMessageControlKHR.

Check if the attribute list is valid even if the callback is NULL. Set the callback pointer whether or not the attribute list is NULL. --- src/egl/main/eglapi.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/src/egl/main/eglapi.

Re: [Mesa-dev] [PATCH 2/2] nir: move tex_instr_remove_src

On Thu, Sep 8, 2016 at 11:14 AM, Rob Clark wrote: > I want to re-use this in a different pass, so move to nir.h > > Signed-off-by: Rob Clark > --- > src/compiler/nir/nir.h | 16 > src/compiler/nir/nir_lower_tex.c | 20 ++-- > 2 files changed, 18 insert

Re: [Mesa-dev] [PATCH 2/2] nir: move tex_instr_remove_src

On Thu, Sep 8, 2016 at 11:21 AM, Jason Ekstrand wrote: > > > On Thu, Sep 8, 2016 at 11:14 AM, Rob Clark wrote: > >> I want to re-use this in a different pass, so move to nir.h >> >> Signed-off-by: Rob Clark >> --- >> src/compiler/nir/nir.h | 16 >> src/compiler/nir/n

[Mesa-dev] [Bug 97643] Shader crashes radeon driver and brings the whole system down

https://bugs.freedesktop.org/show_bug.cgi?id=97643 --- Comment #3 from Iaroslav Andrusyak --- still works vo=opengl-hq:user-shaders="/home/pont/CrossBilateral.glsl":cscale=bilinear:dscale=mitchell:tscale=sinc:tscale-radius=2:interpolation-threshold=0.01:scale-radius=3:dither-depth=8:deband-iter

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

Reviewed-by: Jason Ekstrand Sorry for ignoring you. :( On Fri, Sep 2, 2016 at 6:04 PM, Antia Puentes wrote: > - Fixes CTS tests: > > * GL44-CTS.shader_image_size.advanced-nonMS-cs-float > * GL44-CTS.shader_image_size.advanced-nonMS-cs-int > * GL44-CTS.shader_image_size.advanced-nonMS-cs-uint >

Re: [Mesa-dev] swr: RDTSC StopCapture hangs

I’ve seen the bucket hang on stop in the past, but thought this was now a thing of the past. Is there a particular workload that was making this easy to trigger? What workload of glmark2 were you looking at? Watching it run, most of the scenes appear very light in geometry, which would cause

Re: [Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

> From: Emil Velikov > Date: Thu, 8 Sep 2016 18:57:44 +0100 > > On 1 September 2016 at 18:23, Jonathan Gray wrote: > > OpenBSD now has strict W^X enforcement. Processes that violate > > the policy get killed by the kernel. Don't attempt to use > > executable memory on OpenBSD to avoid this. >

[Mesa-dev] [PATCH] doc: document GALLIUM_DRIVER

--- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 789f5e9..24f4d0d 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -217,6 +217,8 @@ Mesa EGL supports different sets of environment variables. See the disable for

[Mesa-dev] [PATCH] doc: document GALLIUM_DRIVER

v2: Add dot at end of sentence --- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 789f5e9..cf57ca5 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -217,6 +217,8 @@ Mesa EGL supports different sets of environment variabl

[Mesa-dev] [PATCH] nir/lower_tex: fix typo with sample_dim

Numeric 2 is actually GLSL_SAMPLER_DIM_3D, which I don't think is what was intended. Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_tex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index a405758

[Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

Changed dri2_query_image to check the return value of resource_get_handle and return GL_FALSE if an error occurs. Similarly changed gbm_dri_bo_get_fd to check the return value of queryImage and return -1 (an invalid file descriptor) if an error occurs. Updated the comment for gbm_bo_get_fd to say

[Mesa-dev] [PATCH 2/2] i915g: add dma-buf support to i915_drm_buffer_get_handle

The implementation of i915_drm_buffer_get_handle now handles DRM_API_HANDLE_TYPE_FD in the same way that intel_winsys_import_handle does, by calling drm_intel_bo_gem_create_from_prime. Tested by successfully running Chrome's ozone_demo [1] with the ozone-gbm backend on an Intel Pineview M machine.

Re: [Mesa-dev] [PATCH 00/23] Remove the hash table in mesa/program

2016-08-23 1:38 GMT+02:00 Timothy Arceri : > Did you get my previous reply about this series breaking a whole bunch > of tests in piglit/cts? It looked like and issue with builtin > functions. > > I attached the results file from jenkins which was rather large so it > didn't get to the list but I a

[Mesa-dev] [PATCH 0/7] mesa/st: support for YUV EGLImages

Since original RFC: + fixed up TODOs, review comments, and added support for NIR path as well as TGSI + Change how we pick which samplers to use for the U/V plane(s), to fill in any holes in SamplersUsed + changed CSC constants to match ITU-R BT.601 conversion (to align with what nir_lo

[Mesa-dev] [PATCH 1/7] mesa/st: add lowering pass for YUV samplers

Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_tgsi_lower_yuv.c | 447 + src/mesa/state_tracker/st_tgsi_lower_yuv.h | 34 +++ 3 files changed, 483 insertions(+) create mode 100644 src/mesa/state_tracker/st_t

[Mesa-dev] [PATCH 2/7] mesa/st: add nir pass to lower tex_src_plane

Signed-off-by: Rob Clark --- Note: the alternative is to fold this logic into nir_lower_tex (ie. make nir_lower_tex support either multiple samplers or the extra nir_tex_src_plane arg. That probably means changing around the order so that nir_lower_tex runs after nir_lower_samplers, but I guess t

[Mesa-dev] [PATCH 4/7] mesa/st: a bit of basic_variant refactoring

Add a helper to initialize the key, and pass the key into the helper that iterates the variants, similar to how it works for vp/fp variants. The 'prog' arg to the helper gets used in a following patch, and is the reason to pass the key into st_get_basic_variant(). Signed-off-by: Rob Clark --- s

[Mesa-dev] [PATCH 04/11] glsl: process local_size_variable input qualifier

This is the new layout qualifier introduced by ARB_compute_variable_group_size which allows to use a variable work group size. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast.h | 5 + src/compiler/glsl/ast_type.cpp | 6 ++ src/compiler/glsl/glsl_pars

[Mesa-dev] [PATCH 6/7] mesa/st: pass prog to st_get_basic_variant()

Needed in a following patch. Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_atom_shader.c | 6 +++--- src/mesa/state_tracker/st_program.c | 16 src/mesa/state_tracker/st_program.h | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

Support multi-planar YUV for external EGLImage's (currently just in the dma-buf import path) by lowering to multiple texture fetch's for each plane and CSC in shader. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_inlines.h | 4 +- src/gallium/include/pipe/p_state.h |

[Mesa-dev] [PATCH 7/7] mesa/st: support for YUV in VS/VS/GS/TCS/TEC..

maybe we don't keep these bits? Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_atom_shader.c | 2 ++ src/mesa/state_tracker/st_context.c | 20 +++ src/mesa/state_tracker/st_program.c | 63 ++--- src/mesa/state_tracker/st_program.h | 4 +++

[Mesa-dev] [PATCH 00/11] add support for ARB_compute_variable_group_size

Hi, This series implements ARB_compute_variable_group_size written against GL 4.3. This extension allows to dispatch variable work group size via a new function called glDispatchComputeGroupSizeARB(). Because this extension is pretty similar to ARB_compute_shader, all Gallium drivers which alread

[Mesa-dev] [PATCH 06/11] glsl/linker: handle errors when a variable local size is used

Compute shaders can now include a fixed local size as defined by ARB_compute_shader or a variable size as defined by ARB_compute_variable_group_size. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/linker.cpp | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) di

[Mesa-dev] [PATCH 08/11] st/mesa: add mapping for SYSTEM_VALUE_LOCAL_GROUP_SIZE

gl_LocalGroupSizeARB can be translated into TGSI_SEMANTIC_BLOCK_SIZE which represents the block size in threads. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/m

[Mesa-dev] [PATCH 10/11] st/mesa: expose ARB_compute_variable_group_size

This extension is only exposed if the underlying driver supports ARB_compute_shader. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_ex

[Mesa-dev] [PATCH 07/11] glsl: add gl_LocalGroupSizeARB as a system value

Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_variables.cpp | 2 ++ src/compiler/shader_enums.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index f47daab..a1768fc 100644 --- a/s

[Mesa-dev] [PATCH 01/11] glapi: add entry points for GL_ARB_compute_variable_group_size

Signed-off-by: Samuel Pitoiset --- .../glapi/gen/ARB_compute_variable_group_size.xml | 25 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 2 ++ src/mesa/main/compute.c| 8 +++

[Mesa-dev] [PATCH 05/11] glsl: reject compute shaders with fixed and variable local size

The ARB_compute_variable_group_size specification explains that when a compute shader includes both a fixed and a variable local size, a compile-time error occurs. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --gi

[Mesa-dev] [PATCH 02/11] mesa/main: add support for ARB_compute_variable_groups_size

Signed-off-by: Samuel Pitoiset --- src/mesa/main/api_validate.c | 94 src/mesa/main/api_validate.h | 4 ++ src/mesa/main/compute.c | 17 src/mesa/main/context.c | 6 +++ src/mesa/main/dd.h | 9 src/m

[Mesa-dev] [PATCH 11/11] nv50/ir: use 1024 threads/block for variable local size

When a variable local size is defined as specified by ARB_compute_variable_group_size, the fixed local size is set to 0 and a SIGFPE occurs when we compute the maximum number of regs. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_target.h | 3 ++- 1 file changed,

[Mesa-dev] [PATCH 03/11] glsl: add enable flags for ARB_compute_variable_group_size

This also initializes the default values for the standalone compiler. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/compiler/glsl/standalone.cpp | 4 src/compiler/glsl/standalone_sc

[Mesa-dev] [PATCH 09/11] st/mesa: add support for dispatching a variable local size

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_compute.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_compute.c b/src/mesa/state_tracker/st_cb_compute.c index 88c1ee2..ccc5dc2 100644 --- a/src/mesa/state_tracke

  1   2   >