[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #12 from Jules Blok --- Created attachment 125624 --> https://bugs.freedesktop.org/attachment.cgi?id=125624&action=edit apitrace file version 3 I've attached an apitrace where I've forced Dolphin to use GLSL version 1.50. Hopefully

Re: [Mesa-dev] [PATCH] ddebug: dump driver states and shaders for apitrace calls

2016-08-09 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.08.2016 00:15, Marek Olšák wrote: From: Marek Olšák I think this was an oversight when the PIPE_DUMP flags were added. --- src/gallium/drivers/ddebug/dd_draw.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug

Re: [Mesa-dev] [PATCH] st/mesa: define ST_NEW_ flags as uint64_t values, not enums

2016-08-09 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.08.2016 00:41, Brian Paul wrote: MSVC doesn't support 64-bit enum values, at least not with C code. The compiler was warning: c:\users\brian\projects\mesa\src\mesa\state_tracker\st_atom_list.h(43) : warning C4309: 'initializing' : truncation of constant value

Re: [Mesa-dev] [PATCH 1/3] gallium: add render_condition_enable param to clear_render_target/depth_stencil

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 00:59, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_clear.h| 5 +++-- src/gallium/auxiliary/vl/vl_bicubic_filter.c| 2 +- src/gallium/auxiliary/vl/vl_compositor.c| 2 +- src/gallium/docs/source/context.rst | 7 -

Re: [Mesa-dev] [PATCH] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 08.08.2016 um 22:10 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header I see where the problem is, but the fix is incorrect. You always search for the emulation prevention three byte even when the previous fill has done so already. So it

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: implement ARB_clear_texture (v3)

2016-08-09 Thread Nicolai Hähnle
Patches 2 & 3: Reviewed-by: Nicolai Hähnle On 09.08.2016 00:59, Marek Olšák wrote: From: Marek Olšák Some ideas copied from Jakob Sinclair's implementation, but the color clearing is completely different. v2: remove leftover code, disable conditional rendering disable render condition c

Re: [Mesa-dev] [PATCH 6/6] gallium/radeon: add HUD queries for mapped VRAM/GTT

2016-08-09 Thread Nicolai Hähnle
The objection to patch 1 makes sense. Adding the marketing name (in _addition_ to the family name) is something that I'd support as well. Patches 2 - 6: Reviewed-by: Nicolai Hähnle On 06.08.2016 20:05, Marek Olšák wrote: From: Marek Olšák mainly for monitoring visible VRAM congestion ---

Re: [Mesa-dev] [PATCH 1/3] gallium: add a pipe_context parameter to fence_finish

2016-08-09 Thread Nicolai Hähnle
Skimming through this, I wonder if PIPE_QUERY_GPU_FINISHED shouldn't use deferred fences. context.rst does say that it "does not imply serialization". But it only seems to be used by nine, and I'm not familiar with D3D expectations. Anyway, this patch is Reviewed-by: Nicolai Hähnle On 06.08

Re: [Mesa-dev] [PATCH 2/3] st/mesa: set the ctx parameter of fence_finish

2016-08-09 Thread Nicolai Hähnle
On 06.08.2016 17:32, Marek Olšák wrote: From: Marek Olšák for deferred flushes --- src/mesa/state_tracker/st_cb_syncobj.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_syncobj.c b/src/mesa/state_tracker/st_cb_syncob

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: use unflushed fences for deferred flushes (v2)

2016-08-09 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 06.08.2016 17:32, Marek Olšák wrote: From: Marek Olšák +23% Bioshock Infinite performance. v2: - use the new fence_finish interface - allow deferred fences with multiple contexts - clear the ctx pointer after a deferred flush --- src/gallium/drivers/ra

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #3 from Nicolas Boichat --- Ok, thanks for trying those out. Can you try again, setting LIBGL_DEBUG=verbose ? Hopefully that'll give us more logs and a better idea of what is going on... -- You are receiving this mail because: You

[Mesa-dev] [PATCH] st/omx/dec/h264: pass default scaling lists in raster format

2016-08-09 Thread Christian König
From: Indrajit Das --- src/gallium/state_trackers/omx/vid_dec_h264.c | 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c b/src/gallium/state_trackers/omx/vid_dec_h264.c index bc7feaa..10f2959 100644 ---

[Mesa-dev] [PATCH 02/19] st_glsl_types: add st_glsl_type_usagemask

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Determine which components of the underlying vec4 storage will be used. --- src/mesa/state_tracker/st_glsl_types.cpp | 33 src/mesa/state_tracker/st_glsl_types.h | 1 + 2 files changed, 34 insertions(+) diff --git a/src/mesa/state_tracker

[Mesa-dev] [PATCH 01/19] tgsi/ureg: allow specifying the UsageMask of array temporaries

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 14 ++ src/gallium/auxiliary/tgsi/tgsi_ureg.h | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c

[Mesa-dev] [PATCH 11/19] gallium/radeon: more descriptive names for LLVM temporaries in debug builds

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 7b96a58..22ff18e 10064

[Mesa-dev] [PATCH 09/19] gallium/radeon: simplify radeon_llvm_emit_fetch for direct array addressing

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle We can use the pointer stored in the temps array directly. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm

[Mesa-dev] [PATCH 00/19] gallium, radeonsi: temporary array improvements

2016-08-09 Thread Nicolai Hähnle
Hi, this series was originally motivated by fixing a VM fault and ended up growing a bit larger :-) The goal of patches 1-7 is to change st/mesa so that it sets the UsageMask field in temporary array declarations. This ends up being helpful for lowering float and vecN arrays with N <= 3. The rem

[Mesa-dev] [PATCH 03/19] st_glsl_to_tgsi: declare temp arrays at the start of translation

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Unused arrays should have been removed earlier anyway, and it allows us to remove st_translate::array_sizes. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_

[Mesa-dev] [PATCH 04/19] st_glsl_to_tgsi: rename st_translate::arrays to temp_arrays

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Analogous to {input,output}_arrays. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 1df4864..aa83f

[Mesa-dev] [PATCH 15/19] gallium/radeon: extract common getelementptr logic into get_pointer_into_array

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 105 + 1 file changed, 66 insertions(+), 39 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 531a8fe..87fc0

[Mesa-dev] [PATCH 13/19] gallium/radeon: extract common lookup code into get_temp_array function

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 73 -- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index e4bfa74..994c7

[Mesa-dev] [PATCH 06/19] st_glsl_to_tgsi: apply usagemasks to array temporaries

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 0913dbb..f2663bc 100644 --- a/src/mesa/state_tracker/st_glsl_

[Mesa-dev] [PATCH 05/19] st_glsl_to_tgsi: add temp_array_decl structure

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle We will use it to save the type-based usagemask. While we're at it, rename the variable to temp_arrays etc. analogous to {input,output}_arrays. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 36 +- 1 file changed, 20 insertions(+), 16 deletions

[Mesa-dev] [PATCH 17/19] gallium/radeon: reduce alloca of temporaries based on usagemask

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_llvm.h | 1 + .../drivers/radeon/radeon_setup_tgsi_llvm.c| 47 +- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h b/src/gallium/drivers/rad

[Mesa-dev] [PATCH 18/19] gallium/radeon: add radeon_llvm_bound_index for bounds checking

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_llvm.h | 4 +++ .../drivers/radeon/radeon_setup_tgsi_llvm.c| 29 ++ src/gallium/drivers/radeonsi/si_shader.c | 19 +- 3 files changed, 34 insertions(+), 18 deletions(-) diff -

[Mesa-dev] [PATCH 07/19] st_glsl_to_tgsi: use calloc the way it's meant to be used

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index f2663bc..f3da77d 100644 --- a/src/mesa/state_tracker/st_glsl_to_t

[Mesa-dev] [PATCH 10/19] gallium/radeon: simplify radeon_llvm_emit_store for direct array addressing

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle We can use the pointer stored in the temps array directly. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_ll

[Mesa-dev] [PATCH 14/19] gallium/radeon: pass indirect register info into get_alloca_for_array

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle To have the same signature as get_array_range. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_set

[Mesa-dev] [PATCH 08/19] gallium/radeon: clean up emit_declaration for temporaries

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle In the alloca'd array case, no longer create redundant and unused allocas for the individual elements; create getelementptrs instead. --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 27 ++ 1 file changed, 18 insertions(+), 9 deletions(-) diff --

[Mesa-dev] [PATCH 12/19] gallium/radeon: clarify the comment on the array alloca heuristic

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 29 ++ 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 22ff18e..e4bfa

[Mesa-dev] [PATCH 19/19] gallium/radeon: protect against out of bounds temporary array accesses

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle They can lead to VM faults and worse, which goes against the GL robustness promises. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/galliu

[Mesa-dev] [PATCH 16/19] gallium/radeon: always do the full store in store_value_to_array

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Doing the write-back of the temporary vector in radeon_llvm_emit_store makes no sense. This also allows us to get rid of get_alloca_for_array. --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 77 -- 1 file changed, 28 insertions(+), 49 deletions(

[Mesa-dev] [PATCH 1/3] gallivm: add create_builder_at_entry helper function

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduces code duplication. --- src/gallium/auxiliary/gallivm/lp_bld_flow.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_flow.c b/src/gallium/auxiliary/gallivm/lp_bld_flow.c index f3b3

[Mesa-dev] [PATCH 3/3] gallium/radeon: use lp_build_alloca_undef

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoid building all those store 0 / store undef instrucction pairs that end up getting removed anyway. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeon/radeo

[Mesa-dev] [PATCH 2/3] gallivm: add lp_build_alloca_undef

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/gallivm/lp_bld_flow.c | 19 +++ src/gallium/auxiliary/gallivm/lp_bld_flow.h | 5 + 2 files changed, 24 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_flow.c b/src/gallium/auxiliary/gallivm/lp_bld_flow.c index

Re: [Mesa-dev] [PATCH 6/8] st/mesa: _NEW_TEXTURE & CONSTANTS shouldn't flag states that aren't used

2016-08-09 Thread Nicolai Hähnle
On 07.08.2016 03:12, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_context.c | 64 - src/mesa/state_tracker/st_context.h | 6 2 files changed, 62 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/

Re: [Mesa-dev] [PATCH 4/8] st/mesa: determine states used or affected by shaders at compile time

2016-08-09 Thread Nicolai Hähnle
On 07.08.2016 03:12, Marek Olšák wrote: From: Marek Olšák At compile time, each shader determines which ST_NEW flags should be set at shader bind time. This just sets the new field for all shaders. The next commit will use it. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 175 +

Re: [Mesa-dev] [PATCH 0/8] More state optimizations for st/mesa

2016-08-09 Thread Nicolai Hähnle
I sent comments on patches 4 & 6. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 07.08.2016 03:12, Marek Olšák wrote: PS: In order to make reviewing easier, all my patches have 10 lines of contexts instead of 3. That will be the default for all my work from now on. I like that

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I was not able to reproduce the problems Andy was facing. Yeah thought so, the reason is probably that you don't have the necessary hardware. Is that why I need to add a PIPE_BIND_LIN

[Mesa-dev] [PATCH] Fix Android compilation when swrast is enabled

2016-08-09 Thread Mathieu Maret
Swrast add dependency on libdrm, but libdrm is not defined for host build (only for the targeted device). So host modules likes mesa_gen_matypes cannot find there libdrm dependency Signed-off-by: Mathieu Maret --- Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Android.co

Re: [Mesa-dev] [PATCH] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
On 08/09/2016 04:26 AM, Christian König wrote: Am 08.08.2016 um 22:10 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header I see where the problem is, but the fix is incorrect. You always search for the emulation prevention three byte even

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Brian Paul
On 08/09/2016 12:30 AM, Mathias Fröhlich wrote: Hi Brian, > I don't know why my local build is failing while appveyor and our > in-house automated build seem OK. But applying your patch 3 alone fixes > things for me. As it fixes something independent, should I push that already? Sure. F

[Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm/addrlib. The question of using addrlib in non

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #4 from Alexandr Zelinsky --- Created attachment 125637 --> https://bugs.freedesktop.org/attachment.cgi?id=125637&action=edit xinit log with LIBGL_DEBUG=verbose seems not very usefull what your nickname on #dri-devel? -- You are

[Mesa-dev] [Bug 97261] vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97261 Bug ID: 97261 Summary: vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Rob Clark
On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

[Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h b/src/gallium

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #5 from Michel Dänzer --- Try EGL_LOG_LEVEL=debug as well. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #6 from Alexandr Zelinsky --- Created attachment 125640 --> https://bugs.freedesktop.org/attachment.cgi?id=125640&action=edit EGL_LOG_LEVEL=debug -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 97261] vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97261 Andy Furniss changed: What|Removed |Added CC||deathsim...@vodafone.de -- You are recei

Re: [Mesa-dev] [PATCH 2/3] gallivm: add lp_build_alloca_undef

2016-08-09 Thread Roland Scheidegger
Am 09.08.2016 um 12:38 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/gallivm/lp_bld_flow.c | 19 +++ > src/gallium/auxiliary/gallivm/lp_bld_flow.h | 5 + > 2 files changed, 24 insertions(+) > > diff --git a/src/gallium/auxiliary/gallivm/lp_b

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Brian Paul
On 08/09/2016 07:46 AM, Brian Paul wrote: On 08/09/2016 12:30 AM, Mathias Fröhlich wrote: Hi Brian, > I don't know why my local build is failing while appveyor and our > in-house automated build seem OK. But applying your patch 3 alone fixes > things for me. As it fixes something independ

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 15:58, Rob Clark wrote: On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 15:47, Nicolai Hähnle wrote: > I think the best way forward is to create a dedicated repository for > addrlib which is then integrated into Mesa as a git submodule. If you really wanna make a lot of people, especially dist-maintainers very unhappy ... > From initial experiments, th

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:56 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/g

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 16:59, Nicolai Hähnle wrote: > So shared linking is right out. Not exactly. Just everything needs to be linked against the matching versions. More a dist-layer problem. addrlibs folks should learn to introduce a proper versioning and provide MVCC-capable build rules. That really is

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 07.08.2016 12:50, Marek Olšák wrote: > It would mainly be a futile task if it had to compete with their > official Mesa driver. Not quite. Would give us all of gallium's capabilities also for the intel chips, for example having lots of different state trackers. (coming back to my original inte

[Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_rb

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Rob Clark
On Tue, Aug 9, 2016 at 11:11 AM, Enrico Weigelt, metux IT consult wrote: > On 07.08.2016 12:50, Marek Olšák wrote: > >> It would mainly be a futile task if it had to compete with their >> official Mesa driver. > > Not quite. Would give us all of gallium's capabilities also for > the intel chips, f

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Me

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:47 schrieb Nicolai Hähnle: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 17:18 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_rbsp.h | 14 -- 1 file changed,

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 8:11 AM, Enrico Weigelt, metux IT consult < enrico.weig...@gr13.net> wrote: > On 07.08.2016 12:50, Marek Olšák wrote: > > > It would mainly be a futile task if it had to compete with their > > official Mesa driver. > > Not quite. Would give us all of gallium's capabilities a

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: > On 09.08.2016 15:58, Rob Clark wrote: >> >> tbh, git submodules are more annoying than they need to be, and I'm >> not really terribly excited to use that for something that is a build >> dependency. Maybe just move it into libdrm instead? >

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #7 from Nicolas Boichat --- Created attachment 125643 --> https://bugs.freedesktop.org/attachment.cgi?id=125643&action=edit Add tracing to egl_dri2.c libEGL debug: EGL user error 0x3001 (EGL_NOT_INITIALIZED) in eglMakeCurrent Is d

[Mesa-dev] [PATCH 3/4] prog_hash_table: Convert to using util/hash_table.h.

2016-08-09 Thread Eric Anholt
Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering engine booting, rendering a page, and exiting) from 1.8s to 1.1s. It uses a large uniform array of structs, making a huge number of separate program resources, and the fixed-size hash table was killing it. Given how many time

[Mesa-dev] [PATCH 1/4] nir: Drop an unused program/hash_table.h include.

2016-08-09 Thread Eric Anholt
--- src/compiler/nir/nir_lower_samplers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_samplers.c b/src/compiler/nir/nir_lower_samplers.c index 4a4326983a65..e878edd9b54b 100644 --- a/src/compiler/nir/nir_lower_samplers.c +++ b/src/compiler/nir/nir_lower_samplers.

[Mesa-dev] [PATCH 4/4] mesa: Use a temporary set to track whether we've added a resource yet.

2016-08-09 Thread Eric Anholt
Saves another .1s on servo.trace. --- src/compiler/glsl/linker.cpp | 76 +--- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index f4049133ee69..ceb86aa0a929 100644 --- a/src/compil

[Mesa-dev] [PATCH 2/4] prog_hash_table: Convert compare funcs to match util/hash_table.h.

2016-08-09 Thread Eric Anholt
I'm going to replace this hash table with util/hash_table.h, and the first step is to compare things the same way. --- src/mesa/program/hash_table.h | 9 - src/mesa/program/prog_hash_table.c | 9 +++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/mesa/progra

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: > On 09.08.2016 17:21, Marek Olšák wrote: >> >> On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: >>> >>> Hi everybody, >>> >>> addrlib is the addressing and alignment calculator which is used by >>> radeonsi. It's developed (and also used

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 19:18, Marek Olšák wrote: On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's deve

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Nayan Deshmukh
Hi Christian, A few questions. On Tue, Aug 9, 2016 at 5:10 PM, Christian König wrote: > I am more than happy to solve these problems, the Lanczos filtering was > getting a little stale > anyway because I was not able to reproduce the problems Andy was facing. > > Yeah thought so, the reason i

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 18:22, Erik Faye-Lund wrote: On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm not really terribly excited to use that for something that is a build dependency. Maybe

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #8 from Alexandr Zelinsky --- Created attachment 125644 --> https://bugs.freedesktop.org/attachment.cgi?id=125644&action=edit EGL_LOG_LEVEL=debug with patches -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH] freedreno/a2xx: add missing casts to silence notices

2016-08-09 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c index 2b62b3a..163c282 100644 --- a/src/galli

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

2016-08-09 Thread Anuj Phogat
On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand wrote: > Does this fix any tests? If so, we should say so in the commit message. > With that updated, > No it doesn't. It surprised me too but it looks like cts don't have enough multisampling tests. > Reviewed-by: Jason Ekstrand > > On Mon, Aug 8,

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 Nicolas Boichat changed: What|Removed |Added Attachment #125643|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 2/2] anv/clear: Clear E5B9G9R9 images as R32_UINT

2016-08-09 Thread Nanley Chery
On Wed, Aug 03, 2016 at 01:06:10PM -0700, Jason Ekstrand wrote: > We can't actually clear these images normally because we can't render to > them. Instead, we have to manually unpack the rgb9e5 color value on the > CPU and clear it as R32_UINT. We still have a bit of work to do to clear > non-pow

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 11:04 AM, Anuj Phogat wrote: > On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand > wrote: > > Does this fix any tests? If so, we should say so in the commit message. > > With that updated, > > > No it doesn't. It surprised me too but it looks like cts don't have enough > mul

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 7:24 PM, Nicolai Hähnle wrote: > > On 09.08.2016 18:22, Erik Faye-Lund wrote: >> >> On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: >>> >>> On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm no

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
Am 09.08.2016 um 19:21 schrieb Nayan Deshmukh: Hi Christian, A few questions. On Tue, Aug 9, 2016 at 5:10 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 Jules Blok changed: What|Removed |Added Attachment #125589|0 |1 is obsolete|

[Mesa-dev] [PATCH] util: Use win32 intrinsics for util_last_bit if present.

2016-08-09 Thread Mathias . Froehlich
From: Mathias Fröhlich v2: Split into two patches. v3: Fix off by one problem. Signed-off-by: Mathias Fröhlich --- src/util/bitscan.h | 12 1 file changed, 12 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bitscan.h index 0743fe7..8afef81 100644 --- a/src/util/bitscan.h

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Mathias Fröhlich
Hi Brian, On Tuesday, 9 August 2016 08:23:41 CEST Brian Paul wrote: > >> As it fixes something independent, should I push that already? > > > > Sure. For 1 & 3, > > Reviewed-by: Brian Paul > > Tested-by: Brian Paul Pushed. > Yes, we need to add one to the index. I'll re-test that patch when y

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #10 from Nicolas Boichat --- Created attachment 125652 --> https://bugs.freedesktop.org/attachment.cgi?id=125652&action=edit Possible fix Possible fix attached, please give it a try. Thanks! -- You are receiving this mail because

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Dave Airlie
> > tbh, git submodules are more annoying than they need to be, and I'm > not really terribly excited to use that for something that is a build > dependency. Maybe just move it into libdrm instead? > I've only had to use git submodules once with spice project, and it was a nightmare. It makes pac

Re: [Mesa-dev] [PATCH] util: Use win32 intrinsics for util_last_bit if present.

2016-08-09 Thread Brian Paul
On 08/09/2016 01:41 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich v2: Split into two patches. v3: Fix off by one problem. Signed-off-by: Mathias Fröhlich --- src/util/bitscan.h | 12 1 file changed, 12 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bit

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

2016-08-09 Thread Haixia Shi
Pinging this thread - any objection to commit this? Thanks. On Thu, Jul 28, 2016 at 8:58 PM, Tomasz Figa wrote: > On Fri, Jul 29, 2016 at 2:51 AM, Haixia Shi wrote: > > On android platform, the width and height of a native window surface may > > be updated after initialization. It is therefore

Re: [Mesa-dev] [PATCH 1/6] gallium/radeon: change the vendor string to Advanced Micro Devices, Inc.

2016-08-09 Thread Marek Olšák
On Sun, Aug 7, 2016 at 12:01 AM, Axel Davy wrote: > Hi, > > This looks like it will perturb driver detection of already written games. > > For example from the dolphin sources, this change would make them detect > catalyst as driver. > > As it is known workarounds are applied depending on the driv

[Mesa-dev] [PATCH V2 2/3] anv/pipeline: Add sample locations for gen7-7.5

2016-08-09 Thread Anuj Phogat
V1: Add multisample positions (Nanley) V2: Fix 8x sample positions to match OpenGL (Anuj) V3: Vulkan has standard sample locations. They need not be same as in OpenGL. (Anuj) Signed-off-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 47 ++

Re: [Mesa-dev] [PATCH V2 2/3] anv/pipeline: Add sample locations for gen7-7.5

2016-08-09 Thread Jason Ekstrand
LGTM On Tue, Aug 9, 2016 at 2:41 PM, Anuj Phogat wrote: > V1: Add multisample positions (Nanley) > V2: Fix 8x sample positions to match OpenGL (Anuj) > V3: Vulkan has standard sample locations. They need not be same as > in OpenGL. (Anuj) > > Signed-off-by: Anuj Phogat > Reviewed-by: Jason

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 1:12 PM, Dave Airlie wrote: > > > > tbh, git submodules are more annoying than they need to be, and I'm > > not really terribly excited to use that for something that is a build > > dependency. Maybe just move it into libdrm instead? > > > > I've only had to use git submod

[Mesa-dev] [PATCH 1/2] glcpp: Track the actual version instead of just the version_resolved flag

2016-08-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/glcpp/glcpp-parse.y | 10 +- src/compiler/glsl/glcpp/glcpp.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/

[Mesa-dev] [PATCH 2/2] glcpp: Only disallow #undef of pre-defined macros on GLSL ES >= 3.00 shaders

2016-08-09 Thread Ian Romanick
From: Ian Romanick Section 3.4 (Preprocessor) of the GLSL ES 3.00 spec says: It is an error to undefine or to redefine a built-in (pre-defined) macro name. The GLSL ES 1.00 spec does not contain this text. Section 3.3 (Preprocessor) of the GLSL 1.30 spec says: #define and #undef func

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 Chad Versace changed: What|Removed |Added CC||c...@kiwitree.net -- You are receiving t

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

2016-08-09 Thread Chad Versace
On 08/09/2016 01:49 PM, Haixia Shi wrote: > Pinging this thread - any objection to commit this? Thanks. I pushed it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 97270] [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg single-sample regression

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97270 Bug ID: 97270 Summary: [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg single-sample regression Product: Mesa Version: git Ha

Re: [Mesa-dev] [PATCH v2 00/27] i965: Rework the blorp API to use ISL

2016-08-09 Thread Chad Versace
On 07/26/2016 03:11 PM, Jason Ekstrand wrote: This patch series builds on the previous one I just sent and reworks the blorp API to be entirely ISL. The last bits of intel_mipmap_tree are removed from the ISL internals and shoved into brw_blorp.c/h which simply serves as a wrapper around the ISL

Re: [Mesa-dev] [PATCH 3/4] prog_hash_table: Convert to using util/hash_table.h.

2016-08-09 Thread Ian Romanick
On 08/09/2016 10:17 AM, Eric Anholt wrote: > Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering > engine booting, rendering a page, and exiting) from 1.8s to 1.1s. It uses > a large uniform array of structs, making a huge number of separate program > resources, and the fixed-s

  1   2   >