Re: [Mesa-dev] [RFC mesa] Introduce .editorconfig

On 18.07.2016 01:46, Eric Engestrom wrote: A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce the formatting of the code, to which Michel Dänzer suggested [1] we start by importing the existing .dir-locals.el settings. This is a first draft, with settings f

Re: [Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

A comment further up in the same file says /* Haiku provides debug_printf in libroot with OS.h */ Is that no longer true? Nicolai On 16.07.2016 16:27, Alexander von Gluck IV wrote: --- src/gallium/auxiliary/util/u_debug.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --gi

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

Jeremy, would you have time to test these changes? Patch 1 was already reviewed by Emil. // Tapani On 06/07/2016 01:33 PM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Cc: Jeremy Huddleston Sequoia --- src/glx/apple/apple_xgl_api_stereo.c | 4 ++-- src/glx/apple/apple_xgl_api_viewport

Re: [Mesa-dev] [PATCH] nv50, nvc0: srgb rendering is only available for rgba/bgra

Reviewed-by: Samuel Pitoiset On 07/17/2016 11:18 PM, Ilia Mirkin wrote: Mark both L8_SRGB and L8A8_SRGB as non-renderable (the latter already didn't have the bind flags). This makes the state tracker pick a different format when rendering is required, or mark the fb as incomplete. This fixes:

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

On 18 July 2016 at 04:19, Nicolas Boichat wrote: > On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov > wrote: >> On 15 July 2016 at 09:28, Nicolas Boichat wrote: >>> android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls >>> eglTerminate, followed by eglReleaseThread. In that case, the >>>

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

Hi Tomasz, On 15 July 2016 at 08:53, Tomasz Figa wrote: > We can support render nodes alone without any private headers, so let's > make support for control nodes depend on presence of private drm_gralloc > headers. > > Signed-off-by: Tomasz Figa > --- > src/egl/Android.mk

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling

Hi Alan, we could adjust the HQ options on either side i.e we could remove L2 as the quality of the output was really bad. I haven't tested the L8 and L9 personally as my hardware won't allow for it. But we can adjust it in case we want to implement other scaling algorithms. Regards, Nayan. On Mo

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

On 15 July 2016 at 08:53, Tomasz Figa wrote: > There are DRI_IMAGE_FOURCC macros, for which there are no corresponding > DRI_IMAGE_FORMAT macros. To support such formats we need to make the > lookup function take the native format directly. As a side effect, it > simplifies all existing calls to t

Re: [Mesa-dev] [PATCH 09/10] egl/android: Add support for YV12 pixel format

On 15 July 2016 at 08:53, Tomasz Figa wrote: > This patch adds support for YV12 pixel format to the Android platform > backend. Only creating EGL images is supported, it is not added to the > list of available visuals. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kalyan Kondapally > --- > sr

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling

Hi Nayan, A couple of suggestions, which I hope will be less controversial than the "s/.f/.0f/" from earlier ;-) On 14 July 2016 at 21:58, Nayan Deshmukh wrote: > HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L9 > uses lanczos filter with number representing the size > of the sinc window. > >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: ensure sample locations are set for line and polygon smoothing

For the series: Reviewed-by: Marek Olšák Marek On Sat, Jul 16, 2016 at 8:44 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Since commit d938b8c, the sample locations are no longer set unconditionally, > so we need to set the atom to dirty on all chips, not just Polaris. > > Cc: 12.0 >

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

On Sat, Jul 16, 2016 at 11:51 PM, Ilia Mirkin wrote: > On Sat, Jul 16, 2016 at 7:47 AM, Józef Kucia wrote: >> This allows Gallium drivers to advertise the subpixel precision >> for floating point viewports bounds. >> >> Signed-off-by: Józef Kucia >> --- >> >> Currently all Mesa drivers return 0

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov wrote: > Hi Tomasz, > > On 15 July 2016 at 08:53, Tomasz Figa wrote: >> We can support render nodes alone without any private headers, so let's >> make support for control nodes depend on presence of private drm_gralloc >> headers. >> >> Signed-off-by

[Mesa-dev] [PATCH 1/4] gallium/radeon: remove RADEON_FLUSH_KEEP_TILING_FLAGS flag

From: Marek Olšák always set --- src/gallium/drivers/r300/r300_flush.c | 2 -- src/gallium/drivers/r600/r600_hw_context.c| 3 --- src/gallium/drivers/radeon/radeon_winsys.h| 3 +-- src/gallium/drivers/radeonsi/si_hw_context.c | 3 --- src/gallium/winsys/radeon/drm/radeon_drm_cs.

[Mesa-dev] [PATCH 4/4] radeonsi: emit PS exports last

From: Marek Olšák This effectively removes s_waitcnt instructions after FP16 exports. Before: v_cvt_pkrtz_f16_f32_e32 v0, v0, v1 ; 5E000300 v_cvt_pkrtz_f16_f32_e32 v1, v2, v3 ; 5E020702 exp 15, 0, 1, 0, 0, v0, v1, v0, v0 ; F800040F 0100 s_waitcnt expcnt(0)

[Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

From: Marek Olšák --- src/gallium/auxiliary/os/os_time.c | 15 +-- src/gallium/auxiliary/os/os_time.h | 4 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/os/os_time.c b/src/gallium/auxiliary/os/os_time.c index 3d2e416..633ee3d 100644 ---

[Mesa-dev] [PATCH 2/4] radeonsi: really wait for the second EOP event and not the first one

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_perfcounter.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index 96007a5..0ced617 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 3/4] radeonsi: set optimal settings in COMPUTE_RESOURCE_LIMITS

From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_compute.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 5a40286..e75f6bd 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

From: Marek Olšák There are 2 uses: - Asynchronous flushing for multithreaded drivers. - Return a fence without flushing (mid-command-buffer fence). The driver can defer flushing until fence_finish is called. This is required to make Bioshock Infinite faster, which creates 1000 fences (flushes

[Mesa-dev] [PATCH 2/2] gallium/radeon: make deferred flushes asynchronous

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index cd4908f..647832b 100644 --- a/src/gallium/drivers/radeon/r600_pipe_common

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

This series is, Reviewed-by: Edward O'Callaghan On 07/18/2016 10:16 PM, Marek Olšák wrote: > From: Marek Olšák > > There are 2 uses: > - Asynchronous flushing for multithreaded drivers. > - Return a fence without flushing (mid-command-buffer fence). The driver > can defer flushing until fenc

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák wrote: > From: Marek Olšák > > There are 2 uses: > - Asynchronous flushing for multithreaded drivers. > - Return a fence without flushing (mid-command-buffer fence). The driver > can defer flushing until fence_finish is called. This should also be u

[Mesa-dev] [PATCH 2/3] gallium/util: don't modify usage in pipe_buffer_write

From: Marek Olšák All drivers were already doing it except virgl. --- src/gallium/auxiliary/util/u_inlines.h | 11 ++- src/gallium/drivers/virgl/virgl_resource.c | 5 + 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/g

[Mesa-dev] [PATCH 1/3] gallium: split transfer_inline_write into buffer and texture callbacks

From: Marek Olšák to reduce the call indirections with u_resource_vtbl. The worst call tree you could get was: - u_transfer_inline_write_vtbl - u_default_transfer_inline_write - u_transfer_map_vtbl - driver_transfer_map - u_transfer_unmap_vtbl - driver_transfer_

[Mesa-dev] [PATCH 3/3] radeonsi: implement buffer_subdata without indirect calls

From: Marek Olšák There is less noise in CPU profile data now. --- src/gallium/drivers/r600/r600_pipe.c| 2 +- src/gallium/drivers/radeon/r600_buffer_common.c | 22 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 13 +++-- src/gallium/drivers/radeon/

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

On Sat, Jul 16, 2016 at 11:51 PM, Ilia Mirkin wrote: > Of course none of this actually changes backends to return > 0 bits... > did you mean to follow up with further patches? Yes, I wanted to try to change GL_VIEWPORT_SUBPIXEL_BITS at least for some drivers (r600, radeonsi, nouveau). ___

[Mesa-dev] [PATCH 5/5] gallium/amdgpu: use pb_cache buckets for fewer pb_cache misses

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 3545b78..1805ce6 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 2/5] gallium/pb_cache: divide the cache into buckets for reducing cache misses

From: Marek Olšák --- src/gallium/auxiliary/pipebuffer/pb_bufmgr_cache.c | 4 +- src/gallium/auxiliary/pipebuffer/pb_cache.c| 49 ++ src/gallium/auxiliary/pipebuffer/pb_cache.h| 12 -- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 4 +- src/galliu

[Mesa-dev] [PATCH 0/5] gallium pb_cache optimizations

Hi, These are small optimizations for reducing pb_cache overhead with Bioshock Infinite. Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/5] gallium/pb_cache: reduce the number of pointer dereferences

From: Marek Olšák --- src/gallium/auxiliary/pipebuffer/pb_cache.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/pipebuffer/pb_cache.c b/src/gallium/auxiliary/pipebuffer/pb_cache.c index 664867b..a1ca678 100644 --- a/src/gallium/auxili

[Mesa-dev] [PATCH 4/5] gallium/radeon: use pb_cache buckets for fewer pb_cache misses

From: Marek Olšák This makes Bioshock Infinite with deferred flushing 2.2% faster. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 29 --- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsy

[Mesa-dev] [PATCH 1/5] gallium/pb_cache: check parameters that are more likely to fail first

From: Marek Olšák This makes Bioshock Infinite with deferred flushing 2% faster. --- src/gallium/auxiliary/pipebuffer/pb_cache.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/pipebuffer/pb_cache.c b/src/gallium/auxiliary/pipebuffer/pb_

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

On Mon, Jul 18, 2016 at 1:35 PM, Marek Olšák wrote: > FWIW, r600 and radeonsi should return 8. > > Marek Thanks, I'll send patches. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

On Mon, Jul 18, 2016 at 02:14:49PM +0200, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/os/os_time.c | 15 +-- > src/gallium/auxiliary/os/os_time.h | 4 > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/auxiliary/os/os_ti

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

Hi, On 15/07/16 22:46, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> On 14/07/16 21:24, Francisco Jerez wrote: >>> Alejandro Piñeiro writes: >>> Without this commit, a image is considered valid if the level of the texture bound to the image is complete, something we can check

[Mesa-dev] [PATCH 0/9] st/mesa state tracking rewrite

Hi, This series rewrites state tracking in st/mesa. The advantages of the new approach are described in the main patch. Here I'll just say it that it was motivated by a little inefficient code in st_validate_state and the mapping of _NEW_* flags to atoms. The new approach works with one ST_NEW_* f

[Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

From: Marek Olšák The goal is to do this in st_validate_state: while (dirty) atoms[u_bit_scan(&dirty)]->update(st); That implies that atoms can't specify which flags they consume. There is exactly one ST_NEW_* flag for each atom. (58 flags in total) There are macros that combine multip

[Mesa-dev] [PATCH 5/9] st/mesa: unreference optional shaders when unbinding

From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c index b3401c4..7a23469 100644 --- a/src/mesa/state_tracker/st_atom_shader.c +++ b/src/mesa/stat

[Mesa-dev] [PATCH 2/9] st/mesa: remove st_tracked_state::name

From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 1 - src/mesa/state_tracker/st_atom_atomicbuf.c | 6 -- src/mesa/state_tracker/st_atom_blend.c | 1 - src/mesa/state_tracker/st_atom_clip.c | 1 - src/mesa/state_tracker/st_atom_constbuf.c |

[Mesa-dev] [PATCH 6/9] st/mesa: remove excessive shader state dirtying

From: Marek Olšák This just needs to be done by st_validate_state. --- src/mesa/state_tracker/st_atom.c | 9 ++ src/mesa/state_tracker/st_cb_program.c | 53 -- 2 files changed, 9 insertions(+), 53 deletions(-) diff --git a/src/mesa/state_tracker/st_ato

[Mesa-dev] [PATCH 8/9] st/mesa: update sampler states when shaders are changed

From: Marek Olšák This bug seems to have always been there. Applications changing shaders but not textures between draw calls would have gotten undefined behavior. --- src/mesa/state_tracker/st_atom.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/mes

[Mesa-dev] [PATCH 1/9] st/mesa: remove atom debugging code

From: Marek Olšák This won't be needed after the rewrite. --- src/mesa/state_tracker/st_atom.c | 70 ++-- 1 file changed, 3 insertions(+), 67 deletions(-) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index b9d3191..9d5cc0f

[Mesa-dev] [PATCH 7/9] st/mesa: don't dirty sample shading on _NEW_PROGRAM

From: Marek Olšák Already done as part of ST_NEW_FRAGMENT_PROGRAM in st_validate_state. --- src/mesa/state_tracker/st_context.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 911bec6..5eb36be

[Mesa-dev] [PATCH 9/9] mesa: remove dd_function_table::UseProgram

From: Marek Olšák finally unused --- src/mesa/main/dd.h | 1 - src/mesa/main/pipelineobj.c | 3 --- src/mesa/main/shaderapi.c | 6 -- 3 files changed, 10 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 114cbd2..a3dc191 100644 --- a/src/mesa/main/dd.h +++ b

[Mesa-dev] [PATCH 4/9] st/mesa: skip updates of states that have no effect

From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 15 ++- src/mesa/state_tracker/st_atom.h | 22 ++ 2 files changed, 28 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index 5843d2a..77f1ec3 10

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

On Mon, Jul 18, 2016 at 2:38 PM, Eric Engestrom wrote: > On Mon, Jul 18, 2016 at 02:14:49PM +0200, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/auxiliary/os/os_time.c | 15 +-- >> src/gallium/auxiliary/os/os_time.h | 4 >> 2 files changed, 13 insertions(+),

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 2:25 PM, Rob Clark wrote: > On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> There are 2 uses: >> - Asynchronous flushing for multithreaded drivers. >> - Return a fence without flushing (mid-command-buffer fence). The driver >> can defer fl

Re: [Mesa-dev] [PATCH 4/9] st/mesa: skip updates of states that have no effect

On Mon, Jul 18, 2016 at 9:11 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_atom.c | 15 ++- > src/mesa/state_tracker/st_atom.h | 22 ++ > 2 files changed, 28 insertions(+), 9 deletions(-) > > diff --git a/src/mesa/state_tracker/st_

Re: [Mesa-dev] [PATCH 02/11] vl: add entry point

Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: Add entrypoint to distinguish H.264 decode and encode. For example, in patch 5/11 when is calling "VaCreateContext", "pps" and "sps" shouldn't be allocated for H.264 encoding. So we need to use the entry_point to determine this is H.264 decode or H.2

Re: [Mesa-dev] [PATCH 05/11] st/va: add encode entrypoint

Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the

Re: [Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

July 18 2016 3:29 AM, "Nicolai Hähnle" wrote: > A comment further up in the same file says > > /* Haiku provides debug_printf in libroot with OS.h */ > > Is that no longer true? > > Nicolai > > On 16.07.2016 16:27, Alexander von Gluck IV wrote: > >> --- >> src/gallium/auxiliary/util/u_debug.h

[Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

subroutine variables are to be used just in the way functions are called. Although the spec doesn't say it explicitely, this means that these variables are not to be used in any other way than those left for function calls. Therefore, a comparison between 2 subroutine variables should also cause a

Re: [Mesa-dev] [PATCH] glsl: use linked shaders rather than compiled shaders

Reviewed-by: Iago Toral Quiroga On Mon, 2016-07-11 at 12:11 +1000, Timothy Arceri wrote: > At this point there is no reason not to be using the linked shaders, > using the linked shaders should be faster and will make things > simpler > for upcoming shader cache work. > > The previous variable

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

Reviewed-by: Iago Toral Quiroga On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > subroutine variables are to be used just in the way functions are > called. Although the spec doesn't say it explicitely, this means that > these variables are not to be used in any other way than those left

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 9:24 AM, Marek Olšák wrote: > On Mon, Jul 18, 2016 at 2:25 PM, Rob Clark wrote: >> On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> There are 2 uses: >>> - Asynchronous flushing for multithreaded drivers. >>> - Return a fence without flus

Re: [Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

On 18 July 2016 at 14:39, Alexander von Gluck IV wrote: > July 18 2016 3:29 AM, "Nicolai Hähnle" wrote: >> A comment further up in the same file says >> >> /* Haiku provides debug_printf in libroot with OS.h */ >> >> Is that no longer true? >> >> Nicolai >> >> On 16.07.2016 16:27, Alexander von G

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

On 18 July 2016 at 14:11, Marek Olšák wrote: > From: Marek Olšák > > The goal is to do this in st_validate_state: >while (dirty) > atoms[u_bit_scan(&dirty)]->update(st); > > That implies that atoms can't specify which flags they consume. > There is exactly one ST_NEW_* flag for each ato

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 3:55 PM, Rob Clark wrote: > On Mon, Jul 18, 2016 at 9:24 AM, Marek Olšák wrote: >> On Mon, Jul 18, 2016 at 2:25 PM, Rob Clark wrote: >>> On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák wrote: From: Marek Olšák There are 2 uses: - Asynchronous flushing f

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. We need this function in VaPutImage call where copying from yv12 image to nv12 surface for encoding. Existing function can't be used because it only work for copying from

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

Hi, On 18.07.2016 16:11, Marek Olšák wrote: torcs is 2% faster between the previous patch and the end of this series. "Driver" & "Driver2" tests included with GFXBench v4 could be good to check with this. They're fully CPU bound, synthetic 3D driver tests doing subset of stuff that the Manh

Re: [Mesa-dev] [PATCH 4/9] st/mesa: skip updates of states that have no effect

On Mon, Jul 18, 2016 at 3:31 PM, Ilia Mirkin wrote: > On Mon, Jul 18, 2016 at 9:11 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/state_tracker/st_atom.c | 15 ++- >> src/mesa/state_tracker/st_atom.h | 22 ++ >> 2 files changed, 28 insertions(+

[Mesa-dev] [PATCH] direct-to-native-GL for GLX clients on Cygwin ("Windows-DRI")

Structurally, this is very similar to the existing Apple-DRI code, except I have chosen to implement this using the __GLXDRIdisplay, etc. vtables (as suggested originally in [1]), rather than a maze of ifdefs. This also means that LIBGL_ALWAYS_SOFTWARE and LIBGL_ALWAYS_INDIRECT work as expected.

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On 18 July 2016 at 13:02, Tomasz Figa wrote: > On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov > wrote: >> Hi Tomasz, >> >> On 15 July 2016 at 08:53, Tomasz Figa wrote: >>> We can support render nodes alone without any private headers, so let's >>> make support for control nodes depend on presenc

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

On Mon, Jul 18, 2016 at 3:14 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/os/os_time.c | 15 +-- > src/gallium/auxiliary/os/os_time.h | 4 > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/auxiliary/os/os_time.c > b/

Re: [Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

July 18 2016 9:20 AM, "Emil Velikov" wrote: > On 18 July 2016 at 14:39, Alexander von Gluck IV > wrote: > >> July 18 2016 3:29 AM, "Nicolai Hähnle" wrote: >>> A comment further up in the same file says >>> >>> /* Haiku provides debug_printf in libroot with OS.h */ >>> >>> Is that no longer t

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Mon, Jul 18, 2016 at 11:58 PM, Emil Velikov wrote: > On 18 July 2016 at 13:02, Tomasz Figa wrote: >> On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov >> wrote: >>> Hi Tomasz, >>> >>> On 15 July 2016 at 08:53, Tomasz Figa wrote: We can support render nodes alone without any private headers

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

Will do. Thanks for pinging me. Early June was very busy and I didn't see this come through. I'll get back to you within a couple days. --Jeremy > On Jul 18, 2016, at 01:12, Tapani Pälli wrote: > > Jeremy, would you have time to test these changes? Patch 1 was already > reviewed by Emil. >

[Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

Thanks to rebase fail, recent surface state changes effectively reverted 727a9b24933 and 367cf3a2e3e which was unintentional. This should bring it back. Signed-off-by: Jason Ekstrand Cc: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 18 ++ 1 file changed,

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling

Hi Emil, On Mon, Jul 18, 2016 at 4:44 PM, Emil Velikov wrote: > Hi Nayan, > > A couple of suggestions, which I hope will be less controversial than > the "s/.f/.0f/" from earlier ;-) > > On 14 July 2016 at 21:58, Nayan Deshmukh > wrote: > > HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L9 >

Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

On 2016-07-18 09:14:48, Jason Ekstrand wrote: > Thanks to rebase fail, recent surface state changes effectively reverted This happened in 09b5a71517fadd6c20b72e7ad9ea1f7539c93a42, right? Should we mention that commit? Reviewed-by: Jordan Justen > 727a9b24933 and 367cf3a2e3e which was unintentio

[Mesa-dev] [PATCH 01/11] swr: [rasterizer core] viewport rounding for disabled scissor

Adjust viewport rounding when scissor rect is disabled during macro tile scissor setup. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterize

[Mesa-dev] [PATCH 09/11] swr: [rasterizer core] rename *_MAX enum values to *_COUNT

Makes these names semantically correct. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 6 +++--- src/gallium/drivers/swr/rasterizer/core/backend.cpp| 18 +- src/gallium/drivers/swr/rasterizer/core/multisample.h | 4 ++-- src/gallium/drivers/swr/rasterizer/core/

[Mesa-dev] [PATCH 03/11] swr: [rasterizer jitter] rework vertex/instance ID storage in fetch

Moved the setting into the existing component control code. Fixes bad interaction between attribute/component setting for vertex/instance ID and component packing. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 78 ++ .../drivers/swr/rasterizer/jitter/fetch_jit.h

[Mesa-dev] [PATCH 02/11] swr: [rasterizer core] avx512 work in progress initial step

Enabling KNOB_SIMD_WIDTH = 16 for AVX512 pre-work and low level simd utils --- .../drivers/swr/rasterizer/common/simdintrin.h | 644 + .../drivers/swr/rasterizer/core/format_types.h | 194 ++- src/gallium/drivers/swr/rasterizer/core/knobs.h| 25 +- src/gallium/

[Mesa-dev] [PATCH 04/11] swr: [rasterizer common] icc declspec definitions

--- src/gallium/drivers/swr/rasterizer/common/os.h | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 45517f6..32eca68 100644 --- a/src/gallium/drivers/swr/ras

[Mesa-dev] [PATCH 06/11] swr: [rasterizer core] ensure adjacent topologies use the cut-aware PA

--- src/gallium/drivers/swr/rasterizer/core/pa.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa.h b/src/gallium/drivers/swr/rasterizer/core/pa.h index 64932af..2b8110f 100644 --- a/src/gallium/drivers/swr/rasterizer/core/pa.h

[Mesa-dev] [PATCH 05/11] swr: [rasterizer] attribute swizzling and linkage

Add support for enhanced attribute swizzling. Currently supports constant source overrides to handle PrimitiveID support. No support yet for input select swizzling or wrap shortest. Removes obsoleted linkageMask and associated code. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 56 +++-

[Mesa-dev] [PATCH 00/11] update swr rasterizer

Highlights are more avx512 work and api cleanup. Tim Rowley (11): swr: [rasterizer core] viewport rounding for disabled scissor swr: [rasterizer core] avx512 work in progress initial step swr: [rasterizer jitter] rework vertex/instance ID storage in fetch swr: [rasterizer common] icc decls

[Mesa-dev] [PATCH 10/11] swr: [rasterizer core] fix for possible int32 overflow condition

--- src/gallium/drivers/swr/rasterizer/core/rasterizer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/rasterizer.cpp b/src/gallium/drivers/swr/rasterizer/core/rasterizer.cpp index 897556a..1909ddb 100644 --- a/src/gallium/drivers/sw

[Mesa-dev] [PATCH 08/11] swr: [rasterizer core] centroid correction

--- .../drivers/swr/rasterizer/core/backend.cpp| 26 ++ 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/backend.cpp b/src/gallium/drivers/swr/rasterizer/core/backend.cpp index b492810..5d83baf 100644 --- a/src/gall

[Mesa-dev] [PATCH 07/11] swr: [rasterizer core] support range of values in TemplateArgUnroller

Fixes Linux warnings. --- .../drivers/swr/rasterizer/core/frontend.cpp | 13 +++-- .../drivers/swr/rasterizer/core/rasterizer.cpp | 6 ++- src/gallium/drivers/swr/rasterizer/core/utils.h| 63 +++--- 3 files changed, 56 insertions(+), 26 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 11/11] swr: [rasterizer core] introduce simd16intrin.h

Refactoring to leave existing simd_* intrinsics in "simdintrin.h" unchanged, adding corresponding simd16_* intrinsics in "simd16intrin.h" on the side, with emulation, that we can use piecemeal, rather than the all-or-nothing approach to bring up avx512. --- src/gallium/drivers/swr/Makefile.sources

Re: [Mesa-dev] [PATCH mesa v2] vl: fix memory leak

Hi Guys, I don't have the push access. Can anyone please push the patch. Thanks, Nayan. On Thu, Jul 14, 2016 at 10:36 AM, Nayan Deshmukh wrote: > Reviewed-by: Nayan Deshmukh > > > On Thu, Jul 14, 2016 at 3:20 AM, Eric Engestrom wrote: > >> CovID: 1363008 >> Signed-off-by: Eric Engestrom >>

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On 18 July 2016 at 16:38, Tomasz Figa wrote: > On Mon, Jul 18, 2016 at 11:58 PM, Emil Velikov > wrote: >> On 18 July 2016 at 13:02, Tomasz Figa wrote: >>> On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov >>> wrote: Hi Tomasz, On 15 July 2016 at 08:53, Tomasz Figa wrote: > We

Re: [Mesa-dev] [PATCH] gallium/util: Fix debug_printf under Haiku

On 18 July 2016 at 16:28, Alexander von Gluck IV wrote: > July 18 2016 9:20 AM, "Emil Velikov" wrote: >> On 18 July 2016 at 14:39, Alexander von Gluck IV >> wrote: >> >>> July 18 2016 3:29 AM, "Nicolai Hähnle" wrote: A comment further up in the same file says /* Haiku provides d

[Mesa-dev] [PATCH 2/3] mesa: scons: list builddir before srcdir

From: Emil Velikov Analogous to previous commit. Cc: "11.2 12.0" Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- Alexander, if my earlier suggestion(s) don't get you past the gl_function_remap build issue. please give this a try. --- src/mesa/SConscript | 8 1 file change

[Mesa-dev] [PATCH 3/3] mesa: scons: remove left over src/glsl include

From: Emil Velikov The path no longer exists. Signed-off-by: Emil Velikov --- src/mesa/SConscript | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index f72e380..05aa660 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@ -14,7 +14,6 @@ env

[Mesa-dev] [PATCH 1/3] mesa: automake: list builddir before srcdir

From: Emil Velikov In the case of building in out-of-tree fashion, while having generated in-tree sources, the latter, likely stale, files will be used by the compiler. Flip the order so prevent any issue that this may cause. Cc: "11.2 12.0" Signed-off-by: Emil Velikov --- src/mesa/Makefile.

Re: [Mesa-dev] [RFC mesa] Introduce .editorconfig

Eric Engestrom writes: > A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files > to try and enforce the formatting of the code, to which Michel Dänzer > suggested [1] we start by importing the existing .dir-locals.el > settings. It's too bad emacs doesn't just do editorconfig ou

Re: [Mesa-dev] [RFC mesa] Introduce .editorconfig

On Sun, Jul 17, 2016 at 7:46 PM, Eric Engestrom wrote: > diff --git a/src/gallium/drivers/freedreno/.editorconfig > b/src/gallium/drivers/freedreno/.editorconfig > new file mode 100644 > index 000..cc8e11f > --- /dev/null > +++ b/src/gallium/drivers/freedreno/.editorconfig > @@ -0,0 +1,2 @@ >

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

https://bugs.freedesktop.org/show_bug.cgi?id=96979 Bug ID: 96979 Summary: Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions Product: Mesa Version: 10.5 Hardware: Other OS: Al

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #1 from Ruslan Kabatsayev --- Created attachment 125133 --> https://bugs.freedesktop.org/attachment.cgi?id=125133&action=edit glxinfo.{i915,haswell} files used in the command leading to the error Here're the lists of OpenGL extensi

[Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

v2: avoiding dividing by zero when calculating lanczos Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 447 +++ src/gallium/auxiliary/vl/vl_lanczos_filter.h | 63 3 files changed,

[Mesa-dev] [PATCH v2 2/2] st/vdapu: use lanczos filter for scaling v2

HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L9 uses lanczos filter with number representing the size of the sinc window. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 116 --- src/gallium/state_trackers/vdpau/query.c | 8 ++

[Mesa-dev] [RFC] gallium/u_queue: add barrier function

Helper to block until all previous jobs are complete. --- So I think this might end up being useful to me in some cases.. but the implementation only works for a single threaded queue (which is all I need). I could also just put a helper in my driver code. Opinions? src/gallium/auxiliary/util/u

[Mesa-dev] [PATCH 1/7] nir: Add new intrinsics for fragment shader input interpolation.

Backends can normally handle shader inputs solely by looking at load_input intrinsics, and ignore the nir_variables in nir->inputs. One exception is fragment shader inputs. load_input doesn't capture the necessary interpolation information - flat, smooth, noperspective mode, and centroid, sample,

[Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

While my intention is that the new intrinsics should be usable by all drivers, we need to make them optional until all drivers switch. This doesn't do anything yet, but I added it as a separate patch to keep the interface churn separate for easier review. Signed-off-by: Kenneth Graunke --- src/

[Mesa-dev] [PATCH 4/7] i965: Add a pass to demote sample interpolation intrinsics.

When working with a non-multisampled render target, asking for "sample" interpolation locations doesn't make sense. We demote them to centroid. In a couple of patches, brw_compute_barycentric_modes will begin looking at these intrinsics to determine the barycentric modes. fs_visitor also will us

[Mesa-dev] [PATCH 3/7] nir: Add nir_load_interpolated_input lowering code.

Now nir_lower_io can optionally produce load_interpolated_input and load_barycentric_* intrinsics for fragment shader inputs. flat inputs continue using regular load_input. Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir_lower_io.c | 94 ++--- 1 file

[Mesa-dev] [PATCH 6/7] i965: Rewrite FS input handling to use the new NIR intrinsics.

This eliminates the need to walk the list of input variables, recurse into their types (via logic largely redundant with nir_lower_io), and interpolate all possible inputs up front. The backend no longer has to care about variables at all, which eliminates complications from trying to pack multipl

  1   2   >