commit 7c8dfa78b98a12c1c5 (i965/draw: Use the real size for vertex
buffers) changed how we programmed the VERTEX_BUFFER_STATE size field.
Previously, we programmed it to the size of the actual underlying BO,
which is page-aligned, and potentially much larger than the GL buffer
object. This violat
On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:
> Hello,
>
> Timothy found that tests with unpacked double vector input varyings
> were failing in i965 driver. For example, this is happening when
> using explicit locations because Mesa disables varying packing for
> that case.
On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez wrote:
> >
> > Hello,
> >
> > Timothy found that tests with unpacked double vector input varyings
> > were failing in i965 driver. For example, this is happening when
> > using
We weren't setting up several of the uniform values for the patch
header, so we'd crash when uploading push constants. We at least
need to initialize them to zero. We also had the isoline parameters
reversed, so it would also render incorrectly (if it didn't crash).
Fixes a new Piglit test(*) (i
I think you forgot to increase the array of commands from 16 to 32 in
nvc0_validate_tsc() (you did it in v1).
With that addressed, this patch is:
Reviewed-by: Samuel Pitoiset
On 05/26/2016 04:55 AM, Ilia Mirkin wrote:
For fermi, this likely will require use of linked tsc mode. However on
bin
On 25.05.2016 22:20, Philipp Zabel wrote:
> This fixes the stride calculation for pipe formats with a block width
> larger than one.
>
> Signed-off-by: Philipp Zabel
> ---
> src/gallium/state_trackers/dri/dri2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/galliu
Alex Deucher wrote:
On Wed, May 25, 2016 at 10:57 AM, Christian König
wrote:
From: Christian König
We support 5.1 for a while now.
Resend as the last one didn't have the CCs.
I know (well think) vdpau doesn't really mention 5.2 anywhere, but for
ffmpeg I've been making this change for some
Hi Marek,
Am Mittwoch, den 25.05.2016, 20:52 +0200 schrieb Marek Olšák:
> On Wed, May 25, 2016 at 4:46 PM, Philipp Zabel wrote:
> > Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák:
> >> On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel
> >> wrote:
> >> > Am Dienstag, den 10.05.2016, 1
Hi Emil,
Am Mittwoch, den 25.05.2016, 23:42 +0100 schrieb Emil Velikov:
[...]
> Or in other words, in case of egl + gbm, egl inherits the screen from
> the gbm device. As such platform_gbm does not call the core egl setup
> function, dri2_create_screen (like everyone else does x11, wayland...)
> b
Hi Michel,
Am Donnerstag, den 26.05.2016, 17:59 +0900 schrieb Michel Dänzer:
> On 25.05.2016 22:20, Philipp Zabel wrote:
> > This fixes the stride calculation for pipe formats with a block width
> > larger than one.
> >
> > Signed-off-by: Philipp Zabel
> > ---
> > src/gallium/state_trackers/dri
Nope, it was one of the irrelevant changes. If I were enabling 32 on Fermi,
it'd matter, but I'm not.
On May 26, 2016 04:37, "Samuel Pitoiset" wrote:
> I think you forgot to increase the array of commands from 16 to 32 in
> nvc0_validate_tsc() (you did it in v1).
>
> With that addressed, this pat
On 05/26/2016 01:22 PM, Ilia Mirkin wrote:
Nope, it was one of the irrelevant changes. If I were enabling 32 on
Fermi, it'd matter, but I'm not.
Right, this function is for fermi only.
Looks good.
On May 26, 2016 04:37, "Samuel Pitoiset" mailto:samuel.pitoi...@gmail.com>> wrote:
I thi
On 26 May 2016 at 11:28, Philipp Zabel wrote:
> Hi Emil,
>
> Am Mittwoch, den 25.05.2016, 23:42 +0100 schrieb Emil Velikov:
> [...]
>> Or in other words, in case of egl + gbm, egl inherits the screen from
>> the gbm device. As such platform_gbm does not call the core egl setup
>> function, dri2_cr
Hi gents,
On 26 May 2016 at 11:28, Philipp Zabel wrote:
> Hi Michel,
>
> Am Donnerstag, den 26.05.2016, 17:59 +0900 schrieb Michel Dänzer:
>> On 25.05.2016 22:20, Philipp Zabel wrote:
>> > This fixes the stride calculation for pipe formats with a block width
>> > larger than one.
>> >
>> > Signed
Hi Jason,
On 26 May 2016 at 02:52, Jason Ekstrand wrote:
> Right now libglsl.la depends on libnir.la so putting it in libnir.la
> adds a dependency on libglsl.la that goes the wrong direction.
> ---
> src/compiler/Makefile.am |2 +
> src/compiler/Makefile.nir.am
Am Donnerstag, den 26.05.2016, 12:43 +0100 schrieb Emil Velikov:
> Hi gents,
>
> On 26 May 2016 at 11:28, Philipp Zabel wrote:
> > Hi Michel,
> >
> > Am Donnerstag, den 26.05.2016, 17:59 +0900 schrieb Michel Dänzer:
> >> On 25.05.2016 22:20, Philipp Zabel wrote:
> >> > This fixes the stride calcu
On Thu, May 26, 2016 at 6:59 AM, Emil Velikov wrote:
> Hi Jason,
>
> On 26 May 2016 at 02:52, Jason Ekstrand wrote:
>> Right now libglsl.la depends on libnir.la so putting it in libnir.la
>> adds a dependency on libglsl.la that goes the wrong direction.
>> ---
>> src/compiler/Makefile.am
Hi,
On 26-05-16 04:44, Ilia Mirkin wrote:
For user-supplied constbufs, fileIndex is 0. In that case, when we
subtract 1, we'll end up loading from constbuf offset -16. This is
illegal, and there are asserts to avoid it. Normally we'd just DCE it,
but no point in generating the instructions if th
On Thu, May 26, 2016 at 8:41 AM, Hans de Goede wrote:
> Hi,
>
>
> On 26-05-16 04:44, Ilia Mirkin wrote:
>>
>> For user-supplied constbufs, fileIndex is 0. In that case, when we
>> subtract 1, we'll end up loading from constbuf offset -16. This is
>> illegal, and there are asserts to avoid it. Norm
Ping.
On Tue, May 17, 2016 at 10:49 AM, Lars Hamre wrote:
> Gentle ping, if nobody has an issues I would appreciate a push.
>
> Regards,
> Lars Hamre
>
> On Mon, May 9, 2016 at 7:00 PM, Lars Hamre wrote:
>> v3/v4:
>> - compare varying slot locations rather than names (Ilia Mirkin)
>> v2:
>> -
Gentle ping for a gallium developer.
If nobody has any issues I would appreciate a push.
Regards,
Lars Hamre
On Thu, May 19, 2016 at 6:16 PM, Matt Turner wrote:
> On Thu, May 19, 2016 at 2:34 PM, Lars Hamre wrote:
>> Fixes the following piglit tests (for softpipe):
>>
>> /spec/glsl-1.30/executi
Hi,
On 26-05-16 14:43, Ilia Mirkin wrote:
On Thu, May 26, 2016 at 8:41 AM, Hans de Goede wrote:
Hi,
On 26-05-16 04:44, Ilia Mirkin wrote:
For user-supplied constbufs, fileIndex is 0. In that case, when we
subtract 1, we'll end up loading from constbuf offset -16. This is
illegal, and there
Will do.
-Brian
On 05/26/2016 06:51 AM, Lars Hamre wrote:
Gentle ping for a gallium developer.
If nobody has any issues I would appreciate a push.
Regards,
Lars Hamre
On Thu, May 19, 2016 at 6:16 PM, Matt Turner wrote:
On Thu, May 19, 2016 at 2:34 PM, Lars Hamre wrote:
Fixes the following
> On May 25, 2016, at 9:16 PM, Ilia Mirkin wrote:
>
> On Wed, May 25, 2016 at 10:03 PM, Tim Rowley
> wrote:
>> v2: only load the clip vertex once
>>
>> v3: fix clip enable logic, add cullDistance
>> ---
>> docs/GL3.txt | 2 +-
>> src/gallium/drivers/swr/swr_context.h
v2: only load the clip vertex once
v3: fix clip enable logic, add cullDistance
v4: remove duplicate fields in vs jit key, fix test of clip fixup needed
---
docs/GL3.txt | 2 +-
src/gallium/drivers/swr/swr_context.h | 2 ++
src/gallium/drivers/swr/swr_screen.cpp | 3
On 26 May 2016 at 13:39, Rob Herring wrote:
> On Thu, May 26, 2016 at 6:59 AM, Emil Velikov
> wrote:
>> Hi Jason,
>>
>> On 26 May 2016 at 02:52, Jason Ekstrand wrote:
>>> Right now libglsl.la depends on libnir.la so putting it in libnir.la
>>> adds a dependency on libglsl.la that goes the wrong
---
src/compiler/glsl/tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/tests/.gitignore
b/src/compiler/glsl/tests/.gitignore
index 13dcdc4..1c38cd2 100644
--- a/src/compiler/glsl/tests/.gitignore
+++ b/src/compiler/glsl/tests/.gitignore
@@ -3,3 +3,4 @@ ralloc
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 138 +++
1 file changed, 69 insertions(+), 69 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drive
We need to copy the VS outputs to memory. I decided to do this
using a shader key, as the value depends on other shaders.
I also switch the fixed function TCS over to monolithic, as
otherwisze many of the user SGPR's need to be passed to the
epilog, which increases register pressure, or complexity
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c| 28 -
src/gallium/drivers/radeonsi/si_shader.h| 3 ++-
src/gallium/drivers/radeonsi/si_state_shaders.c | 9
3 fi
This happens to be in the right position, but that changes
when TCS/TES get new parameters.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --gi
On Thu, May 26, 2016 at 9:11 AM, Tim Rowley wrote:
> v2: only load the clip vertex once
>
> v3: fix clip enable logic, add cullDistance
>
> v4: remove duplicate fields in vs jit key, fix test of clip fixup needed
> ---
> docs/GL3.txt | 2 +-
> src/gallium/drivers/swr/sw
Instead of creating a memory area per patch and per vertex, we put
the same attribute of every vertex & patch together. Most loads
and stores access the same attribute across all lanes, only for
different patches and vertices.
For the TCS this results in tightly packed data for 4-component
stores.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 3 +++
src/gallium/drivers/radeonsi/si_shader.h | 12 ++--
src/gallium/drivers/radeonsi/si_state_draw.c | 9 +++--
3 files changed, 20 inser
v2: - Use llvm.admgcn.buffer.load instrinsics for new LLVM.
- Code style fixes.
v3: - Code style fix.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 114 +++
1 file changed, 114 insertions(+)
diff --git
We always try to use 4-component loads, as LLVM does not combine loads
and they bypass the L1 cache.
We can't use a similar strategy for stores and this is especially
notable with the tess factors, as they are often set with separate
MOV's per component in the TGSI.
We keep storing to LDS and the
The factors may be stored to LDs by another invocation than
the invocation for vertex 0.
Signed-off-by: Bas Nieuwenhuizen
---
src/gallium/drivers/radeonsi/si_shader.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeons
Addressed review comments by Marek.
As part of that the max number of patches per threadgroup was reduced to 40
from 64. This reduced unigine-heaven performance from 43.1 fps to 42.5 fps
(the number varies a little but the magnitude of the difference is pretty
constant)
However it is likely that
They are unused.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähnle
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 4 +---
src/gallium/drivers/radeonsi/si_shader.h | 15 ---
src/gallium/drivers/radeonsi/si_state_draw.c | 4 +---
3 files
Using more than 1 wave per threadgroup does increase performance
generally. Not using too many patches per threadgroup also
increases performance. Both catalyst and amdgpu-pro seem to
use 40 patches as their maximum, but I haven't really seen
any performance increase from limiting the number of pa
The R_028B50_VGT_TESS_DISTRIBUTION value is copied from
amdgpu-pro. Smaller values in the ACCUM fields seem to
decrease the performance advantage from this patch, higher
values don't seem to matter.
v2: Add distribution mode field enums.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicolai Hähn
This allows running the TES on different CU's than the
TCS which results in performance improvements.
v2: Only write the control word from one invocation.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c| 19 +++
src
The buffer is quite large, but should only be allocated if the
application uses tessellation. Most non-games don't.
v2: - Use the correct register for SI.
- Add define for block size.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c
---
src/gallium/auxiliary/indices/u_unfilled_indices.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/src/gallium/auxiliary/indices/u_unfilled_indices.c
b/src/gallium/auxiliary/indices/u_unfilled_indices.c
index fc974f8..fe57fd7 100644
--- a/src/gallium/a
---
src/gallium/auxiliary/indices/u_indices.h | 32 ---
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/indices/u_indices.h
b/src/gallium/auxiliary/indices/u_indices.h
index 4483eb8..7f696ab 100644
--- a/src/gallium/auxiliary/indice
Tested with new piglit gl-3.2-adj-prims test.
---
src/gallium/auxiliary/indices/u_indices.c | 52
src/gallium/auxiliary/indices/u_indices_gen.py | 83 +-
src/gallium/auxiliary/indices/u_indices_priv.h | 2 +-
3 files changed, 134 insertions(+), 3 dele
The unfilled index translator/generator functions should only be
called when the primitive mode is one of the triangle types.
---
src/gallium/auxiliary/indices/u_unfilled_indices.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/auxiliary/indices/u_unfilled_indices.c
b/src/ga
Tested with new piglit gl-3.2-adj-prims test.
---
src/gallium/auxiliary/indices/u_unfilled_gen.py| 26 --
src/gallium/auxiliary/indices/u_unfilled_indices.c | 14
2 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/indices/u_un
---
src/gallium/drivers/svga/svga_draw_private.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_draw_private.h
b/src/gallium/drivers/svga/svga_draw_private.h
index c821742..48e0b60 100644
--- a/src/gallium/drivers/svga/svga_draw_priv
VGPU10 actually supports line-mode triangles. We failed to make use of
that before.
---
src/gallium/drivers/svga/svga_draw_arrays.c | 8 --
src/gallium/drivers/svga/svga_draw_elements.c | 3 +--
src/gallium/drivers/svga/svga_draw_private.h | 38 +--
3 files change
---
src/gallium/auxiliary/indices/u_indices.c | 6 +++---
src/gallium/auxiliary/indices/u_indices.h | 17 +
src/gallium/auxiliary/indices/u_unfilled_indices.c | 10 +-
src/gallium/drivers/svga/svga_draw_arrays.c| 3 ++-
src/gallium/drivers/svga/s
Makes debugging with gdb a little nicer.
---
src/gallium/include/pipe/p_state.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_state.h
b/src/gallium/include/pipe/p_state.h
index eacf9bb..396f563 100644
--- a/src/gallium/include/pipe/p_state.h
+++ b/
---
src/gallium/drivers/svga/svga_resource_buffer.c | 2 +-
src/gallium/drivers/svga/svga_screen_cache.c| 2 +-
src/gallium/drivers/svga/svga_screen_cache.h| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c
b/src/gallium/
Proper enum types were only added recently.
---
src/gallium/drivers/svga/svga_draw.h | 4 ++--
src/gallium/drivers/svga/svga_draw_arrays.c | 6 +++---
src/gallium/drivers/svga/svga_draw_elements.c | 6 +++---
src/gallium/drivers/svga/svga_draw_private.h | 5 +++--
src/gallium/drivers/s
On 19 May 2016 at 10:00, Iago Toral wrote:
> I have just noticed that this was never pushed, right? I noticed this
> while working on providing double-precision implementation for the other
> functions discussed in the thread.
>
You are correct Iago. Gents, can anyone get some light on the status
---
src/gallium/auxiliary/util/u_debug.c | 2 +-
src/gallium/auxiliary/util/u_debug.h | 2 +-
src/gallium/auxiliary/util/u_inlines.h| 6 +++---
src/gallium/auxiliary/util/u_staging.c| 2 +-
src/gallium/auxiliary/util/u_staging.h| 2 +-
src/gallium/auxiliary/util/u_suballoc.c
Hi all,
On 2 March 2016 at 03:22, Ian Romanick wrote:
> Sorry for the delay.
>
> Reviewed-by: Ian Romanick
>
>
> On 02/09/2016 03:28 PM, Anuj Phogat wrote:
>> OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both
>> ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData().
>> So, hand
On 05/24/2016 04:42 PM, Plamena Manolova wrote:
According to the EGL specifications before binding an API
we must check whether it's supported first. If not eglBindAPI
should return EGL_FALSE and generate a EGL_BAD_PARAMETER error.
Signed-off-by: Plamena Manolova
---
src/egl/main/eglapi.c
On 27 April 2016 at 12:36, Emil Velikov wrote:
> On 11 March 2016 at 08:43, Andreas Fänger wrote:
>> This patch makes it possible to build classic osmesa/swrast on windows
>> again. Although there is a gallium version of osmesa now, the swrast version
>> still has more features lacking in llvmpip
Hi all,
On 29 February 2016 at 07:14, Tapani Pälli wrote:
>
> On 02/22/2016 10:16 PM, Ian Romanick wrote:
>>
>> There are 17 total occurrences of
>>
>> grep -r '[(]!gc[)]' src/glx/
>>
>> and
>>
>> grep -r 'gc[[:space:]]*==[[:space:]]*NULL' src/glx/
>>
>> None of these check for dummyCon
For the series:
Reviewed-by: Marek Olšák
Marek
On Wed, May 25, 2016 at 2:35 PM, Tom Stellard wrote:
> We were storing arrays in vectors, which was leading to some really bad
> spill code for large arrays. allocas instructions are a better fit for
> arrays and LLVM optimizations are more geare
Hi guys,
Double-checking through the list and this patch never landed in
master. From a quick read through the log it's not immediately obvious
if an alternative did get pushed.
Can someone shed some light on the topic ?
Thanks
Emil
___
mesa-dev mailin
Reviewed-by: Marek Olšák
Marek
On Wed, May 25, 2016 at 3:17 PM, Philipp Zabel wrote:
> To comply with the requirement from the GL_OES_EGL_image_external
> extension that a call to glBindTexture guarantees that all further
> sampling will return values that correspond to the values in the
> exte
On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel wrote:
> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin:
>> Iirc invalidate_resource is to allow backend to discard the contents...
>
> Thanks, I didn't know that. So this would need a new callback then?
> Specifically I want to discard
On 05/26/2016 04:29 PM, Emil Velikov wrote:
Hi guys,
Double-checking through the list and this patch never landed in
master. From a quick read through the log it's not immediately obvious
if an alternative did get pushed.
Can someone shed some light on the topic ?
Hi Emil,
Oops! I have jus
On Thu, 2016-05-26 at 15:13 +0100, Emil Velikov wrote:
> On 19 May 2016 at 10:00, Iago Toral wrote:
> > I have just noticed that this was never pushed, right? I noticed this
> > while working on providing double-precision implementation for the other
> > functions discussed in the thread.
> >
> Yo
On Thu, May 26, 2016 at 3:33 PM, Bas Nieuwenhuizen
wrote:
> Addressed review comments by Marek.
>
> As part of that the max number of patches per threadgroup was reduced to 40
> from 64. This reduced unigine-heaven performance from 43.1 fps to 42.5 fps
> (the number varies a little but the magnitu
On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote:
> On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel wrote:
>> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin:
>>> Iirc invalidate_resource is to allow backend to discard the contents...
>>
>> Thanks, I didn't know that. So this would
Hi all,
On 18 May 2016 at 00:35, Timothy Arceri wrote:
> On Tue, 2016-05-17 at 15:11 -0700, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Commit 11096ec introduced a regression in some piglit tests (e.g.,
>> arb_program_interface_query-resource-query). I did not notice this
>> regression beca
On Thu, May 26, 2016 at 4:36 PM, Ilia Mirkin wrote:
> On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote:
>> On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel
>> wrote:
>>> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin:
Iirc invalidate_resource is to allow backend to discard t
Hi gents,
On 14 May 2016 at 04:11, Kenneth Graunke wrote:
> On Friday, May 13, 2016 6:42:54 PM PDT Ian Romanick wrote:
>> From: Ian Romanick
>>
>> On my oes_shader_io_blocks branch, this fixes 71
>> dEQP-GLES31.functional.program_interface_query.* tests.
>>
>> Signed-off-by: Ian Romanick
>> Cc:
On 05/26/2016 08:23 AM, Emil Velikov wrote:
On 27 April 2016 at 12:36, Emil Velikov wrote:
On 11 March 2016 at 08:43, Andreas Fänger wrote:
This patch makes it possible to build classic osmesa/swrast on windows
again. Although there is a gallium version of osmesa now, the swrast version
still
Patches 12-13:
Reviewed-by: Marek Olšák
Marek
On Thu, May 26, 2016 at 3:33 PM, Bas Nieuwenhuizen
wrote:
> Using more than 1 wave per threadgroup does increase performance
> generally. Not using too many patches per threadgroup also
> increases performance. Both catalyst and amdgpu-pro seem to
Reviewed-by: Marek Olšák
Marek
On Thu, May 26, 2016 at 4:09 PM, Brian Paul wrote:
> ---
> src/gallium/auxiliary/util/u_debug.c | 2 +-
> src/gallium/auxiliary/util/u_debug.h | 2 +-
> src/gallium/auxiliary/util/u_inlines.h| 6 +++---
> src/gallium/auxiliary/util/u_staging.c|
Reviewed-by: Marek Olšák
Marek
On Thu, May 26, 2016 at 4:09 PM, Brian Paul wrote:
> Makes debugging with gdb a little nicer.
> ---
> src/gallium/include/pipe/p_state.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_state.h
> b/src/gallium/i
Am Donnerstag, den 26.05.2016, 10:36 -0400 schrieb Ilia Mirkin:
> On Thu, May 26, 2016 at 10:31 AM, Marek Olšák wrote:
> > On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel
> > wrote:
> >> Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin:
> >>> Iirc invalidate_resource is to allow backe
Am 26.05.2016 um 02:10 schrieb Tim Rowley:
> ---
> src/gallium/auxiliary/util/u_cpu_detect.c | 17 +
> src/gallium/auxiliary/util/u_cpu_detect.h | 10 ++
> 2 files changed, 27 insertions(+)
>
> diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c
> b/src/gallium/auxilia
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Ben Widawsky
---
include/pci_ids/i965_pci_ids.h | 2 ++
src/mesa/drivers/dri/i965/brw_device_info.c | 22 ++
2 files changed, 24 insertions(+)
diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965
From: Rob Clark
CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local:
Overrunning array of 2 16-byte elements at element index 2 (byte offset
32) by dereferencing pointer &inst.Dst[i].
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/tgsi/tgsi_text.c | 3 +++
1 file changed,
From: Rob Clark
Not sure why coverity calls this an out-of-bounds read vs out-of-bounds
write.
CID 1358920 (#1 of 1): Out-of-bounds read (OVERRUN)9. overrun-local:
Overrunning array r of 3 16-byte elements at element index 3 (byte
offset 48) using index chan (which evaluates to 3).
Signed-off-b
Makes sense.
We should also clamp the index for indirect access as part of the
robustness, but this can be done later.
Reviewed-by: Samuel Pitoiset
On 05/26/2016 04:44 AM, Ilia Mirkin wrote:
For user-supplied constbufs, fileIndex is 0. In that case, when we
subtract 1, we'll end up loading
On 05/26/2016 09:25 AM, Rob Clark wrote:
From: Rob Clark
CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local:
Overrunning array of 2 16-byte elements at element index 2 (byte offset
32) by dereferencing pointer &inst.Dst[i].
Signed-off-by: Rob Clark
---
src/gallium/auxiliar
Am 26.05.2016 um 16:06 schrieb Brian Paul:
> Tested with new piglit gl-3.2-adj-prims test.
> ---
> src/gallium/auxiliary/indices/u_indices.c | 52
> src/gallium/auxiliary/indices/u_indices_gen.py | 83
> +-
> src/gallium/auxiliary/indices/u_indices_pr
Am 26.05.2016 um 16:06 schrieb Brian Paul:
> Tested with new piglit gl-3.2-adj-prims test.
> ---
> src/gallium/auxiliary/indices/u_unfilled_gen.py| 26
> --
> src/gallium/auxiliary/indices/u_unfilled_indices.c | 14
> 2 files changed, 38 insertions(+), 2 delet
On 05/26/2016 09:35 AM, Roland Scheidegger wrote:
Am 26.05.2016 um 16:06 schrieb Brian Paul:
Tested with new piglit gl-3.2-adj-prims test.
---
src/gallium/auxiliary/indices/u_indices.c | 52
src/gallium/auxiliary/indices/u_indices_gen.py | 83 +-
On 05/26/2016 09:37 AM, Roland Scheidegger wrote:
Am 26.05.2016 um 16:06 schrieb Brian Paul:
Tested with new piglit gl-3.2-adj-prims test.
---
src/gallium/auxiliary/indices/u_unfilled_gen.py| 26 --
src/gallium/auxiliary/indices/u_unfilled_indices.c | 14
Am 26.05.2016 um 16:09 schrieb Brian Paul:
> Makes debugging with gdb a little nicer.
> ---
> src/gallium/include/pipe/p_state.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_state.h
> b/src/gallium/include/pipe/p_state.h
> index eacf9bb..396
Am 26.05.2016 um 17:39 schrieb Brian Paul:
> On 05/26/2016 09:35 AM, Roland Scheidegger wrote:
>> Am 26.05.2016 um 16:06 schrieb Brian Paul:
>>> Tested with new piglit gl-3.2-adj-prims test.
>>> ---
>>> src/gallium/auxiliary/indices/u_indices.c | 52
>>> src/gallium/auxilia
On Thu, May 26, 2016 at 11:33 AM, Brian Paul wrote:
> On 05/26/2016 09:25 AM, Rob Clark wrote:
>>
>> From: Rob Clark
>>
>> CID 1271532 (#1 of 1): Out-of-bounds read (OVERRUN)34. overrun-local:
>> Overrunning array of 2 16-byte elements at element index 2 (byte offset
>> 32) by dereferencing point
> On May 26, 2016, at 8:33 AM, Ilia Mirkin wrote:
>
> On Thu, May 26, 2016 at 9:11 AM, Tim Rowley
> wrote:
>> v2: only load the clip vertex once
>>
>> v3: fix clip enable logic, add cullDistance
>>
>> v4: remove duplicate fields in vs jit key, fix test of clip fixup needed
>> ---
>> docs/GL3
What about the Maxwell logic? LDS expects a GPR at def(0) and in case
the dst reg doesn't exist, you move the predicate to def(0).
Are you sure you don't need to check if dst(0) is not a predicate in
emitLDS()?
On 05/26/2016 04:44 AM, Ilia Mirkin wrote:
For a load locked, we might not use th
On 05/26/2016 05:49 PM, Samuel Pitoiset wrote:
What about the Maxwell logic? LDS expects a GPR at def(0) and in case
the dst reg doesn't exist, you move the predicate to def(0).
Are you sure you don't need to check if dst(0) is not a predicate in
emitLDS()?
Oh, actually not because we don't
On 05/26/2016 05:51 PM, Samuel Pitoiset wrote:
On 05/26/2016 05:49 PM, Samuel Pitoiset wrote:
What about the Maxwell logic? LDS expects a GPR at def(0) and in case
the dst reg doesn't exist, you move the predicate to def(0).
Are you sure you don't need to check if dst(0) is not a predicate
On Thu, May 26, 2016 at 8:08 AM, Ben Widawsky wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Ben Widawsky
The numbers check out.
Reviewed-by: Kristian Høgsberg
> ---
> include/pci_ids/i965_pci_ids.h | 2 ++
> src/mesa/drivers/dri/i965/brw_device_info.c | 22 +++
On 26 May 2016 at 02:52, Jason Ekstrand wrote:
> This little series reworks the build a bit so that we can stop linking the
> Vulkan driver to libmesa. This lets us substantially cut down on the size
> of the final binary. The whole series can be found in a branch here:
>
> https://cgit.freedesk
Update the TODO as well. With that, for the series:
Reviewed-by: Kristian Høgsberg
On Wed, May 25, 2016 at 6:52 PM, Jason Ekstrand wrote:
> This brings the final size of an optimized non-debug build of the Vulkan
> driver down to 2.9 MB as opposed to 8.7 MB for the dri driver.
> ---
> src/inte
On Thu, May 26, 2016 at 11:51 AM, Samuel Pitoiset
wrote:
>
>
> On 05/26/2016 05:49 PM, Samuel Pitoiset wrote:
>>
>> What about the Maxwell logic? LDS expects a GPR at def(0) and in case
>> the dst reg doesn't exist, you move the predicate to def(0).
>>
>> Are you sure you don't need to check if ds
This series looks good to me.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, May 26, 2016 7:09 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Roland Scheidegger
Subject: [PATCH 2/2] svga: fix test for unfilled triangles fallback
VG
On Thu, May 26, 2016 at 7:18 AM, Emil Velikov wrote:
> Hi all,
>
> On 2 March 2016 at 03:22, Ian Romanick wrote:
>> Sorry for the delay.
>>
>> Reviewed-by: Ian Romanick
>>
>>
>> On 02/09/2016 03:28 PM, Anuj Phogat wrote:
>>> OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both
>>> ES 1.0
Signed-off-by: Ilia Mirkin
---
src/mesa/main/getstring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c
index c39a076..6e90511 100644
--- a/src/mesa/main/getstring.c
+++ b/src/mesa/main/getstring.c
@@ -80,6 +80,8 @@ shading_language_ver
1 - 100 of 214 matches
Mail list logo
