On Thu, May 05, 2016 at 10:36:07AM -0700, Ben Widawsky wrote:
> On Thu, Apr 21, 2016 at 02:58:56PM +0300, Topi Pohjolainen wrote:
> > Signed-off-by: Topi Pohjolainen
> > ---
> > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 5 -
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > di
On Thu, May 05, 2016 at 10:59:16AM -0700, Ben Widawsky wrote:
> On Thu, May 05, 2016 at 10:51:32AM -0700, Ben Widawsky wrote:
> > On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
> > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c |
https://bugs.freedesktop.org/show_bug.cgi?id=95294
Bug ID: 95294
Summary: Support importing R8 and GR88 dma_bufs on ARM
Product: Mesa
Version: unspecified
Hardware: ARM
OS: Linux (All)
Status: NEW
Severity
On 04.05.2016 00:11, Rob Clark wrote:
> On Tue, May 3, 2016 at 9:56 AM, Daniel Vetter wrote:
>> On Mon, May 02, 2016 at 06:44:34AM -0400, Rob Clark wrote:
>>> On Mon, May 2, 2016 at 2:15 AM, Michel Dänzer wrote:
On 25.04.2016 21:36, Daniel Stone wrote:
> On 20 April 2016 at 00:32, Rob Cl
Also use the opportunity to drop the unused surface type argument.
Signed-off-by: Topi Pohjolainen
Reviewed-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_state.h | 2 ++
src/mesa/drivers/dri/i965/gen8_surface_state.c | 9 -
2 files changed, 6 insertions(+), 5 deletions(-)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Kenneth gave his R-b to this patch on IRC:
"i965/fs: push first double-based uniforms in push constant
buffer" gets my R-b
On 06/05/16 08:56, Samuel Iglesias Gonsálvez wrote:
> When there is a mix of definitions of uniforms with 32-bit or
> 64-bit
On 02.05.2016 20:01, Daniel Stone wrote:
> On 2 May 2016 at 11:44, Rob Clark wrote:
>> On Mon, May 2, 2016 at 2:15 AM, Michel Dänzer wrote:
>>> So, what is this based on? Maybe I'm not looking in the right place, but
>>> out of hundreds of changes in Git touching those files, I see one change
>>>
https://bugs.freedesktop.org/show_bug.cgi?id=95296
Bug ID: 95296
Summary: nir_lower_double_packing.c:79:4: error: void function
'lower_double_pack_impl' should not return a value
[-Wreturn-type]
Product: Mesa
Vers
On Thu, May 05, 2016 at 11:17:41AM -0700, Ben Widawsky wrote:
> On Thu, Apr 21, 2016 at 02:58:59PM +0300, Topi Pohjolainen wrote:
> > v2: Check explicitly against base type of GL_FLOAT instead of
> > using _mesa_is_format_integer_color(). Otherwise we miss
> > GL_UNSIGNED_NORMALIZED.
> >
>
Until now mcs was associated to single sampled buffers only for
fast clear purposes and it was therefore the responsibility of the
clear logic to allocate the aux buffer when needed. Now that normal
3D render or blorp blit may render with mcs enabled also, they need
to prepare the mcs just as well.
Currently, when cross validating global variables, all global variables
seen in the shaders that are part of a program are saved in a table.
When checking a variable this already exist in the table, we check both
are initialized to the same value. If the already saved variable does
not have an ini
On 06.05.2016 02:01, Marek Olšák wrote:
>> There is one more hardware limitation that can cause VM faults with T2L
>> copies and needs a workaround. The exact workaround is still under
>> discussion, but I think this is good enough for review already.
>
> BTW, the T2L VM fault is completely harm
Reviewed-by: Marek Olšák
Marek
On Thu, May 5, 2016 at 10:33 PM, Bas Nieuwenhuizen
wrote:
> No sure where the 36 came from, but we clearly need at least
> 48 bytes per attribute per primitive.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/gallium/drivers/radeonsi/si_shader.c | 9 ++---
>
On Fri, May 6, 2016 at 12:01 PM, Michel Dänzer wrote:
> On 06.05.2016 02:01, Marek Olšák wrote:
>>> There is one more hardware limitation that can cause VM faults with T2L
>>> copies and needs a workaround. The exact workaround is still under
>>> discussion, but I think this is good enough for r
On 06.05.2016 19:09, Marek Olšák wrote:
> On Fri, May 6, 2016 at 12:01 PM, Michel Dänzer wrote:
>> On 06.05.2016 02:01, Marek Olšák wrote:
There is one more hardware limitation that can cause VM faults with T2L
copies and needs a workaround. The exact workaround is still under
dis
https://bugs.freedesktop.org/show_bug.cgi?id=95296
Jose Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Andreas, Adam, could you review?
Br, DS
On Fri, Apr 29, 2016 at 7:54 AM, Dongseong Hwang
wrote:
> This demo shows how ChromeOS renders OpenGL ES2 via kms, drm and gbm.
> This demo consists of
> 1. kms modesetting and vsync
> 2. EGL and GLES2 context creation
> 3. gbm bo creation and EGL Image b
Inout parameters which depended on other inout parameters
where not assigned in the correct order.
Fixes the following piglit tests in shaders/out-parameter-indexing:
vs-inout-index-inout-float-array
vs-inout-index-inout-mat2-col
vs-inout-index-inout-mat2-row
vs-inout-index-inout-vec4
vs-inout-ind
Like other resources, we need to unreference all images.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_context.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_context.c
i
Reviewed-by: Ilia Mirkin
On May 6, 2016 9:09 AM, "Samuel Pitoiset" wrote:
> Like other resources, we need to unreference all images.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/galli
Build mesa 1161 failed
Commit 44de03b0f8 by Samuel Pitoiset on 5/6/2016 2:25 PM:
nvc0: unreference images when the context is destroyed\n\nLike other resources, we need to unreference all images.\n\nSigned-off-by: Samuel Pitoiset \nReviewed-by: Ilia Mirkin
https://bugs.freedesktop.org/show_bug.cgi?id=95294
--- Comment #1 from Nicolas Dufresne ---
Hey, just a note that Stanimir Varbanov reported on both gstreamer and mesa
devel that he added that already for Qualcomm driver. As this is a Gallium
driver, I suppose he also added all the required bits
On Fri, 2016-05-06 at 08:49 -0400, Lars Hamre wrote:
> Inout parameters which depended on other inout parameters
> where not assigned in the correct order.
>
> Fixes the following piglit tests in shaders/out-parameter-indexing:
> vs-inout-index-inout-float-array
> vs-inout-index-inout-mat2-col
> v
Hi Juan,
Sorry I missed that.
It looks like your patch doesn't fix the out parameter indexing for:
vs-inout-index-inout-mat2-col
vs-inout-index-inout-vec4-array
I was able to extend your patch to get these tests passing by:
- if the ir_array->array was a dereferenced_array, copy propagate it's
I think you want a loop there, peeling off all array dereferences, due
to AoA (and maybe throw in some piglit tests to cover that). [Assuming
AoA's can be function arguments... haven't checked the spec.]
On Fri, May 6, 2016 at 10:39 AM, Lars Hamre wrote:
> Hi Juan,
>
> Sorry I missed that.
>
> It
On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote:
> Hi Juan,
>
> Sorry I missed that.
>
> It looks like your patch doesn't fix the out parameter indexing for:
> vs-inout-index-inout-mat2-col
> vs-inout-index-inout-vec4-array
>
> I was able to extend your patch to get these tests passing by:
>
Sounds good to me, go ahead and push the new version!
On Fri, May 6, 2016 at 10:44 AM, Juan A. Suarez Romero
wrote:
> On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote:
>> Hi Juan,
>>
>> Sorry I missed that.
>>
>> It looks like your patch doesn't fix the out parameter indexing for:
>> vs-inout-
Copy propagate is not applied in function parameters when they are out
or inout.
But if the parameter is an array, we can copy propagate the index array.
This also fixes shaders@out-parameter-indexing piglit tests, that
exposes a wrong handling of inout function parameters in Mesa.
This commit d
https://bugs.freedesktop.org/show_bug.cgi?id=95296
--- Comment #2 from Jason Ekstrand ---
(In reply to Jose Fonseca from comment #1)
> GCC (at least 5.2.1) also throws an warning...
>
> src/compiler/nir/nir_lower_double_packing.c: In function
> âlower_double_pack_implâ:
> src/compiler/nir/ni
Several NIR scripts were using `from ... import ...` syntax, which wasn't
supported.
Using Python standard libary's modulefinder solves the problem with less
effort and hacks.
---
scons/custom.py | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/scon
According to the GLSL spec, if the user uses the fma() intrinsic to
generate a precise-consumed value, and you have it in your hardware, you
shouldn't split it. For a while now, we've been splitting all ffma's
up-front and then planned to fuse them later which isn't valid. Correctly
handling the
On 05/06/2016 10:04 AM, Jose Fonseca wrote:
Several NIR scripts were using `from ... import ...` syntax, which wasn't
supported.
Using Python standard libary's modulefinder solves the problem with less
effort and hacks.
---
scons/custom.py | 27 +--
1 file changed, 9 i
Could you add something to piglit which tries this with AoA to make
sure that your logic is right?
On Fri, May 6, 2016 at 11:54 AM, Juan A. Suarez Romero
wrote:
> Copy propagate is not applied in function parameters when they are out
> or inout.
>
> But if the parameter is an array, we can copy p
Build mesa 1162 completed
Commit a1f698881e by Eric Anholt on 5/6/2016 1:04 AM:
vc4: Add support for loading immediate values in QIR.\n\nThis will be used for resetting the uniform stream in the presence of\nbranching, but may also be useful as an optimization
Rob Herring writes:
> Implement support for mapImage/unmapImage functions in version 12 of the
> DRIimage extension.
>
> Signed-off-by: Rob Herring
> ---
> v2:
> - Make READ flag optional
>
> src/gallium/state_trackers/dri/dri2.c | 43
> ++-
> 1 file changed, 42
Rob Herring writes:
> This adds map and unmap functions to GBM utilizing the DRIimage extension
> mapImage/unmapImage functions or existing internal mapping for dumb
> buffers. Unlike prior attempts, this version provides a region to map and
> usage flags for the mapping. The operation follows th
On Thu, May 05, 2016 at 07:08:15PM -0700, Ben Widawsky wrote:
> On Mon, Apr 25, 2016 at 08:10:01PM +0300, Topi Pohjolainen wrote:
> > Signed-off-by: Topi Pohjolainen
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 9 ++
From: Marek Olšák
Ported from the initial amdgpu winsys from the private AMD branch.
The thread creates the buffer list, submits IBs, and cleans up
the submission context, which can also destroy buffers.
3-5% reduction in CPU overhead is expected for apps submitting a lot
of IBs per frame. This
On Thu, May 5, 2016 at 1:43 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeon/r600_pipe_common.c | 16
> src/gallium/drivers/radeon/radeon_winsys.h| 2 ++
> src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8
> src/gallium/winsys/radeo
Would like to get this small change reviewed to help with performance measuring.
Thanks.
-Tim
> On Mar 28, 2016, at 2:29 PM, Rowley, Timothy O
> wrote:
>
> LLVM when configured with "intel jitevents" enabled can inform
> VTune about dynamic code, so individual shaders are attributed
> profili
Am 06.05.2016 um 21:51 schrieb Rowley, Timothy O:
> Would like to get this small change reviewed to help with performance
> measuring.
>
> Thanks.
>
> -Tim
>
>> On Mar 28, 2016, at 2:29 PM, Rowley, Timothy O
>> wrote:
>>
>> LLVM when configured with "intel jitevents" enabled can inform
>> VTu
The conditions for which certain built-in special variables
can be declared invariant were not being checked.
OpenGL ES 1.00 specification "Invariance and linkage":
For the built-in special variables, gl_FragCoord can
only be declared invariant if and only if gl_Position is
declared invariant. Si
On Fri, May 06, 2016 at 10:19:58AM +0300, Pohjolainen, Topi wrote:
> On Thu, May 05, 2016 at 10:59:16AM -0700, Ben Widawsky wrote:
> > On Thu, May 05, 2016 at 10:51:32AM -0700, Ben Widawsky wrote:
> > > On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote:
> > > > Signed-off-by: Topi Po
This change enables the creation of pbuffer
surfaces on the surfaceless platform.
V2: Use double-buffered pbuffer configuration
---
src/egl/drivers/dri2/egl_dri2.h | 8 +-
src/egl/drivers/dri2/platform_surfaceless.c | 219 +++-
2 files changed, 222 insertions
On Fri, May 6, 2016 at 3:32 PM, Gurchetan Singh
wrote:
> This change enables the creation of pbuffer
> surfaces on the surfaceless platform.
>
> V2: Use double-buffered pbuffer configuration
Reviewed-by: Stéphane Marchesin
Chad, do you also want to take a look at it?
> ---
> src/egl/drivers/
On 05/06/2016 03:39 PM, Stéphane Marchesin wrote:
> On Fri, May 6, 2016 at 3:32 PM, Gurchetan Singh
> wrote:
>> This change enables the creation of pbuffer
>> surfaces on the surfaceless platform.
>>
>> V2: Use double-buffered pbuffer configuration
>
> Reviewed-by: Stéphane Marchesin
>
> Chad,
It appears that we can't do this in a single command (like we do for
MI_LOAD_REGISTER_IMM) - the Skylake simulator gets rather grumpy about
the command length if I try to combine them. No matter.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_context.h | 2 ++
src/mesa/
On Haswell, we need version 6 of the kernel command parser in order to
write the math registers. Our implementation of ARB_query_buffer_object
heavily relies on MI_MATH, so we should only advertise it when MI_MATH
is available. We also need MI_LOAD_REGISTER_REG, which requires version
7 of the co
My old implementation accumulated pairs in a buffer,
and eventually processed that data on the CPU. This meant flushing
the batchbuffer and waiting for it to completely execute before we
could map it, resulting in really long stalls. We could also run out
of space in the buffer, and have to do t
On Friday, May 6, 2016 11:42:49 PM PDT Kenneth Graunke wrote:
> My old implementation accumulated pairs in a buffer,
> and eventually processed that data on the CPU. This meant flushing
> the batchbuffer and waiting for it to completely execute before we
> could map it, resulting in really long s
On 2016-04-27 14:52:34, Gurchetan Singh wrote:
> With this change, to enable precise SIN and COS instructions
> on Intel hardware, one can put
>
>
>
> in the proper drirc file.
> ---
> src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 +
> src/mesa/drivers/dri/i965/brw_compiler.c|
51 matches
Mail list logo
