Re: [Mesa-dev] [PATCH] dri2: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Michel Dänzer
On 20.04.2016 19:38, Stefan Dirsch wrote: > According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() > always returns a valid pointer. If no context is made current, it will > contain dummyContext. Thus a test for NULL will always fail. > > Patch author: Egbert Eich Please set

Re: [Mesa-dev] [PATCH] configure.ac: fix the --disable-llvm-shared-libs build

2016-04-21 Thread Michel Dänzer
On 20.04.2016 22:10, Jose Fonseca wrote: > On 19/04/16 19:39, Emil Velikov wrote: >> On 19 April 2016 at 15:47, Chuck Atkins wrote: >>> This still doesn't quite give what you want. One can also have an >>> llvm with >>> component shared libs. So there's three different options for llvm >>> libra

Re: [Mesa-dev] [PATCH] i965: Fix clear code for ignoring colormask for XRGB formats on Gen9+.

2016-04-21 Thread Iago Toral
On Wed, 2016-04-20 at 18:38 -0700, Kenneth Graunke wrote: > In commit cda886a4851ab767fba40e8474d6fa8190347e4f, Neil made us stop > advertising RGBX formats on Gen9+, as the hardware apparently no longer > has working fast clear support for those formats. Instead, we just > fall back to RGBA forma

[Mesa-dev] [Bug 83669] fix build with gcc link time optimizer

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83669 --- Comment #13 from Marc Dietrich --- gcc/clang development is fast and also the mesa supported version numbers of compilers are increasing. So this is a fast moving target. That said, I currently use the _target_ attribute of gcc (not supported

Re: [Mesa-dev] [PATCH] i965/fs: Readd opt_drop_redundant_mov_to_flags().

2016-04-21 Thread Iago Toral
On Wed, 2016-04-20 at 14:22 -0700, Matt Turner wrote: > This reverts commit b449366587b5f3f64c6fb45fe22c39e4bc8a4309. > > I removed the pass thinking that it was now not useful, but that was not > true. I believe I ran shader-db on HSW and saw no results, but HSW does > not use the unlit centroid

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 Frederic Devernay changed: What|Removed |Added CC||frederic.dever...@m4x.org --- Commen

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 --- Comment #2 from Frederic Devernay --- Created attachment 123109 --> https://bugs.freedesktop.org/attachment.cgi?id=123109&action=edit patch for Mesa-11.1.2 -- You are receiving this mail because: You are the assignee for the bug. You are

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-21 Thread Oded Gabbay
On Wed, Apr 20, 2016 at 12:35 PM, Marek Olšák wrote: > On Wed, Apr 20, 2016 at 11:14 AM, Oded Gabbay wrote: >> On Wed, Apr 20, 2016 at 12:04 PM, Michel Dänzer wrote: >>> On 20.04.2016 17:48, Oded Gabbay wrote: On Wed, Apr 20, 2016 at 11:28 AM, Michel Dänzer wrote: > On 20.04.2016 03:13

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Enable loading into CE RAM.

2016-04-21 Thread Marek Olšák
On Thu, Apr 21, 2016 at 1:49 AM, Bas Nieuwenhuizen wrote: > We need to enable a bit in the CONTEXT_CONTROL packet for the > loads to work. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++ > src/gallium/drivers/radeonsi/si_hw_context.c | 5 ++

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Enable loading into CE RAM.

2016-04-21 Thread Bas Nieuwenhuizen
Hi Marek, The hang was most likely related to something else I tried to fix the loads and that started doing something once the loads were enabled. With the kernel patch I had the hang too until I cleaned up the leftovers of all my previous attempts at fixes in mesa. - Bas On Thu, Apr 21, 2016

[Mesa-dev] [PATCH 1/3] dri2: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Stefan Dirsch
From: Egbert Eich According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() always returns a valid pointer. If no context is made current, it will contain dummyContext. Thus a test for NULL will always fail. https://bugzilla.opensuse.org/show_bug.cgi?id=962609 Signed-off-by: Eg

[Mesa-dev] [PATCH mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

2016-04-21 Thread Eric Engestrom
3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all VK_PROTOTYPES to VK_NO_PROTOTYPES This brings the Intel header in line with the rest of the Vulkan code. Signed-off-by: Eric Engestrom --- This might break code that was using the old guard scheme (not sure how that could've worked anyway). Wh

Re: [Mesa-dev] [PATCH] configure.ac: fix the --disable-llvm-shared-libs build

2016-04-21 Thread Jose Fonseca
On 21/04/16 08:37, Michel Dänzer wrote: On 20.04.2016 22:10, Jose Fonseca wrote: On 19/04/16 19:39, Emil Velikov wrote: On 19 April 2016 at 15:47, Chuck Atkins wrote: This still doesn't quite give what you want. One can also have an llvm with component shared libs. So there's three differen

[Mesa-dev] [PATCH] dri2: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Stefan Dirsch
From: Egbert Eich According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() always returns a valid pointer. If no context is made current, it will contain dummyContext. Thus a test for NULL will always fail. https://bugzilla.opensuse.org/show_bug.cgi?id=962609 Signed-off-by: Eg

[Mesa-dev] [PATCH] dri3: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Stefan Dirsch
According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() always returns a valid pointer. If no context is made current, it will contain dummyContext. Thus a test for NULL will always fail. https://lists.freedesktop.org/archives/mesa-dev/2016-April/113962.html Signed-off-by: Stef

Re: [Mesa-dev] [PATCH] dri2: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Stefan Dirsch
On Thu, Apr 21, 2016 at 04:22:26PM +0900, Michel Dänzer wrote: > On 20.04.2016 19:38, Stefan Dirsch wrote: > > According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() > > always returns a valid pointer. If no context is made current, it will > > contain dummyContext. Thus a test

[Mesa-dev] [PATCH v2 1/2] radeonsi: Use defines for CONTEXT_CONTROL instead of magic values.

2016-04-21 Thread Bas Nieuwenhuizen
v2: Use field names provided by Nicolai. Signed-off-by: Bas Nieuwenhuizen --- Sending this with the changed names, as they seem double to me. Should I just lose the register name, and optionally add a CONTEXT_CONTROL prefix? src/gallium/drivers/radeonsi/si_state.c | 4 ++-- src/gallium/drive

[Mesa-dev] [PATCH v2 2/2] radeonsi: Enable loading into CE RAM.

2016-04-21 Thread Bas Nieuwenhuizen
We need to enable a bit in the CONTEXT_CONTROL packet for the loads to work. v2: Style issues. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_descriptors.c | 7 +++ src/gallium/drivers/radeonsi/si_hw_context.c | 5 + src/gallium/drivers/radeonsi/si_state.h |

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix preamble IB size

2016-04-21 Thread Marek Olšák
Pushed, thanks! Marek On Wed, Apr 20, 2016 at 10:34 PM, Thomas Hindoe Paaboel Andersen wrote: > The missing break caused the IB size to be overwritten with > the size of IB_CONST. > > This was introduced in: 7201230582e060aa2eb79c825d3188b437ef7bb8 > --- > src/gallium/winsys/amdgpu/drm/amdgpu_c

[Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

2016-04-21 Thread Eric Engestrom
Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the VK_PROTOTYPES to VK_NO_PROTOTYPES This brings the Intel header in line with the rest of the Vulkan code. Signed-off-by: Eric Engestrom --- This might break code that was using the old guard scheme (not sure how that could've worked

[Mesa-dev] [PATCH 1/2] winsys/amdgpu: Silence possibly uninitialized variable warning.

2016-04-21 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index bbd29fc..69fb9bb 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.

[Mesa-dev] [PATCH 2/2] gallium/radeon: Silence possibly uninitialized variable warning.

2016-04-21 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 7174132..d3f5ae3 100644 --- a/src/gallium/dri

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: Silence possibly uninitialized variable warning.

2016-04-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Apr 21, 2016 at 1:28 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeon/radeon_llvm_emit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeo

[Mesa-dev] [v4 02/11] i965: Relax assertion of halign == 16 for lossless compressed aux

2016-04-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index ae08300..b68575f 100644 --- a/src/mesa/d

[Mesa-dev] [v4 01/11] i965/blorp: Set full resolve for lossless compressed

2016-04-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp index 41ff2a5..b1da935 100644 --- a/src/mesa/dri

[Mesa-dev] [v4] i965: Compression support for single-sampled

2016-04-21 Thread Topi Pohjolainen
This is revised version sitting on top of blorp clears. It also contains patches telling both the standard compiler backend as well as blorp compiler to sample single samples compressed surfaces using normal ld instead of ld2dms and mcs fetch. While ld2dms/mcs fetch combo seems to work in practise

[Mesa-dev] [v4 11/11] i965/gen9: Enable lossless compression

2016-04-21 Thread Topi Pohjolainen
I tried first creating the auxiliary buffer the same time with the color buffer. That, however, led me into a situation where we would later create the rest of the mip-levels and the compression would need to be disabled (it is only supported for single level buffers). Here we try to create it on

[Mesa-dev] [v4 06/11] i965/blorp: Prepare blits for lossless compression

2016-04-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 2 +- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 26 +- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp b/src/mesa/drivers/dri/i

[Mesa-dev] [v4 07/11] i965/blorp: Do not resolve lossless compressed blit sources

2016-04-21 Thread Topi Pohjolainen
Blorp blits use sampling engine which is capable of resolving on the fly. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965

[Mesa-dev] [v4 10/11] i965/wm: Don't sample lossless compressed as multisampled

2016-04-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_wm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c index dbc626c..ced9708 100644 --- a/src/mesa/drivers/dri/i965/brw_wm.c +++ b/src

[Mesa-dev] [v4 04/11] i965: Add helper for lossless compression support

2016-04-21 Thread Topi Pohjolainen
v2: Check explicitly against base type of GL_FLOAT instead of using _mesa_is_format_integer_color(). Otherwise we miss GL_UNSIGNED_NORMALIZED. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 22 ++ src/mesa/drivers/dri/i965/intel_mi

[Mesa-dev] [v4 09/11] i965: Set render state for lossless compressed

2016-04-21 Thread Topi Pohjolainen
v2: Add support for blorp and removed the support for meta Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_draw.c | 7 ++- 3 files changed, 15 insertion

[Mesa-dev] [v4 08/11] i965/gen9: Setup MCS for compressed texture surfaces

2016-04-21 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c index e3593d3..18e7c75 100644 --- a/src/

[Mesa-dev] [v4 03/11] i965/gen9: Prepare surface state setup for lossless compression

2016-04-21 Thread Topi Pohjolainen
v2 (Ben): Use combination of msaa_layout and number of samples instead of introducing explicit type for lossless compression (intel_miptree_is_lossless_compressed()). v3 (Ben): Do not set fast claer state in surface state setup. Moved into brw_postdraw_set_buffers_need

[Mesa-dev] [v4 05/11] i965: Deferred allocation of mcs for lossless compressed

2016-04-21 Thread Topi Pohjolainen
Until not mcs was associated to single sampled buffers only for fast clear purposes and it was therefore the responsibility of the clear logic to allocate the aux buffer when needed. Now that normal 3D render or blorp blit may render with mcs enabled also, they need to prepare the mcs just as well.

[Mesa-dev] [PATCH 2/2] anv: use PUBLIC macro to annotate symbols

2016-04-21 Thread Emil Velikov
From: Emil Velikov The symbols are part of an the VK_DEBUG_MARKER_EXT device extension thus they should be provided statically. Signed-off-by: Emil Velikov --- Right ? Afaics one should even mention the extension name, version plus entry points via the layer section in the json. Then again sin

[Mesa-dev] [PATCH 1/2] an: step one toward correct symbol exports

2016-04-21 Thread Emil Velikov
Annotate the only symbol that should be provided statically as PUBLIC and add VISIBILITY_CFLAGS to hide everything else. Note: with this in place we still have multiple symbols exported. Those will be fixed with follow up commits. Signed-off-by: Emil Velikov --- Does anyone know the section name

[Mesa-dev] [PATCH] anv: remove description about GENX_FUNC macro

2016-04-21 Thread Emil Velikov
From: Emil Velikov The macro has been gone since commit 1f1cf6fcb0e "anv: Get rid of GENX_FUNC" Signed-off-by: Emil Velikov --- src/intel/genxml/gen_macros.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/src/intel/genxml/gen_macros.h b/src/intel/genxml/gen_macros.h index 0

[Mesa-dev] [RFC 0/5] Misc notes about misuse/future work

2016-04-21 Thread Emil Velikov
Hi all, A few patches each of which is an open topic. Please comment in each one individually. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [RFC 1/5] wayland-drm: add a few lovely notes about future work.

2016-04-21 Thread Emil Velikov
--- src/egl/wayland/wayland-drm/wayland-drm.h | 4 1 file changed, 4 insertions(+) diff --git a/src/egl/wayland/wayland-drm/wayland-drm.h b/src/egl/wayland/wayland-drm/wayland-drm.h index 7892d56..33d7fd4 100644 --- a/src/egl/wayland/wayland-drm/wayland-drm.h +++ b/src/egl/wayland/wayland-d

[Mesa-dev] [RFC 4/5] automake: add FINISHME on the topic of platforms

2016-04-21 Thread Emil Velikov
From: Emil Velikov --- FINISHME | 12 1 file changed, 12 insertions(+) create mode 100644 FINISHME diff --git a/FINISHME b/FINISHME new file mode 100644 index 000..63273fd --- /dev/null +++ b/FINISHME @@ -0,0 +1,12 @@ +Retweak all the platform handling, namely; + + - s/egl-pla

[Mesa-dev] [RFC 5/5] anv: add a note about the dispatch table used by meta

2016-04-21 Thread Emil Velikov
Namely it creates a table with 161 entries of which only 15 are ever set/used. To make it even more strange those are set at runtime, when we can do it at build time. --- src/intel/vulkan/anv_private.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/

[Mesa-dev] [RFC 2/5] env: add a note about nasty forward declarations.

2016-04-21 Thread Emil Velikov
From: Emil Velikov From a quick look we should not need any of this. --- src/intel/vulkan/anv_private.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index d8a2194..120696e 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src

[Mesa-dev] [RFC 3/5] anv: add a note about strange looking define

2016-04-21 Thread Emil Velikov
From: Emil Velikov Leaning that gets us into a similar broken ABI state as with libGL. Not 100% sure though. --- src/intel/vulkan/anv_private.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 120696e..3eb0475 100644 ---

Re: [Mesa-dev] [PATCH] gallivm: fix bogus argument order to lp_build_sample_mipmap function

2016-04-21 Thread Jose Fonseca
On 21/04/16 02:04, srol...@vmware.com wrote: From: Roland Scheidegger Screwed up since 0753b135f6e83b171d8a1b08aea967374f3542bc. (Only an issue with different min/mag filters, and then only in some cases, which is probably why it went unnoticed for quite a while. The effect should have simply

[Mesa-dev] [PATCH mesa v2 2/3] nouveau: codegen: LOAD: Do not call fetchSrc(1) if the address is immediate

2016-04-21 Thread Hans de Goede
"off" later gets set to NULL when the address is immediate, so move the fetchSrc(1) call to the non-immediate branch of the if-else. This brings handleLOAD's offset handling inline with how it is done in handleSTORE. Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this patch-s

[Mesa-dev] [PATCH mesa v2 1/3] nouveau: codegen: LOAD: Always use component 0 when getting the address

2016-04-21 Thread Hans de Goede
LOAD loads upto 4 components from the specified resource starting at the passed in x value of the 2nd source operand, the y, z and w components of the address should not be used. Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this patch-set --- src/gallium/drivers/nouveau/co

[Mesa-dev] [PATCH mesa v2 3/3] nouveau: codegen: LOAD: Take src swizzle into account

2016-04-21 Thread Hans de Goede
The llvm TGSI backend uses pointers in registers and does things like: LOAD TEMP[0].y, MEMORY[0], TEMP[0] Expecting the data at address TEMP[0].x to get loaded to TEMP[0].y. But this will cause the data at TEMP[0].x + 4 to be loaded instead. This commit adds support for a swizzle suffix for the

Re: [Mesa-dev] [PATCH 02/10] radeonsi: make RW buffer descriptor array global, not per shader stage

2016-04-21 Thread Bas Nieuwenhuizen
On Wed, Apr 20, 2016 at 5:47 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 50 > +-- > src/gallium/drivers/radeonsi/si_pipe.h| 2 +- > 2 files changed, 25 insertions(+), 27 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-21 Thread Chuck Atkins
> > The MESA_EGL_NO_X11_HEADERS macro is used to check if we're building > without > GLX support. > In configure.ac: # If we don't have the X11 platform, set this define so we don't try to include # the X11 headers. if ! echo "$egl_platforms" | grep -q 'x11'; then DEFINES="$DEFINES -DMESA_EGL

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 --- Comment #3 from Roland Scheidegger --- I'm not really sure about that. It is possible this was intended for multiple contexts rendering to the same buffer (as is possible with "ordinary" GL), which won't work with this. Though you are certain

[Mesa-dev] [PATCH] dri2: Check for dummyContext to see if the glx_context is valid

2016-04-21 Thread Stefan Dirsch
From: Egbert Eich According to the comments in src/glx/glxcurrent.c __glXGetCurrentContext() always returns a valid pointer. If no context is made current, it will contain dummyContext. Thus a test for NULL will always fail. https://bugzilla.opensuse.org/show_bug.cgi?id=962609 Tested-by: Olaf H

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 --- Comment #4 from Chuck Atkins --- > I don't really know anything about osmesa though nor why people still use > it We use OSMesa extensively for rendering on headless servers with no GPUs. It's *MUCH* better than dealing with having to start

[Mesa-dev] [PATCH 03/25] anv: remove no longer needed %.json rule

2016-04-21 Thread Emil Velikov
From: Emil Velikov As of last commit the final file that needed this is gone. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index c943970..4428a25 100644 --- a/sr

[Mesa-dev] [PATCH 02/25] anv: remove unused dev_icd.json

2016-04-21 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/intel/vulkan/.gitignore | 1 - src/intel/vulkan/Makefile.am | 1 - src/intel/vulkan/dev_icd.json.in | 7 --- 3 files changed, 9 deletions(-) delete mode 100644 src/intel/vulkan/dev_icd.json.in diff --git a/src/intel/vulkan/.g

[Mesa-dev] [PATCH 21/25] automake: tweak SUBDIR reorder and comment it

2016-04-21 Thread Emil Velikov
From: Emil Velikov It should ease people with all the interaction and platforms and how they interact (at least from a build POV) with each other. Signed-off-by: Emil Velikov --- Should mention anv as well ? -Emil src/Makefile.am | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 01/25] genxml: ship all the files needed in the tarball

2016-04-21 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/intel/genxml/Makefile.am | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/genxml/Makefile.am b/src/intel/genxml/Makefile.am index 77b2f19..f71076d 100644 --- a/src/intel/genxml/Makefile.am +++ b/src/intel/genxml/Ma

[Mesa-dev] [PATCH 14/25] anv: kill of custom define HAVE_WAYLAND_PLATFORM

2016-04-21 Thread Emil Velikov
From: Emil Velikov Vulkan API already has equivalent, so simplify things as just use it. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 3 +-- src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_wsi.c| 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff -

[Mesa-dev] [PATCH 06/25] anv: split sources lists to Makefile.sources

2016-04-21 Thread Emil Velikov
Will allow others to reuse the lists (scons/android anyone ?) and makes the file a lot shorter and easier to read. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 78 +++- src/intel/vulkan/Makefile.sources | 94 +

[Mesa-dev] [PATCH 11/25] anv: use the GENERATED_FILES variable

2016-04-21 Thread Emil Velikov
From: Emil Velikov ... rather than having duplicates files through the sources lists. Splitting things as is, has the side effect of making things clearer and easing a potential android build. The latter of which automatically adds BUILT_SOURCES to the binary. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 09/25] anv: build the core vulkan only once

2016-04-21 Thread Emil Velikov
From: Emil Velikov Introduce a static library libvulkan_common.la that is used by libvukan_intel.la and libvulkan_test.la. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/Makefile.a

[Mesa-dev] [PATCH 08/25] anv: kill off custom CFLAGS

2016-04-21 Thread Emil Velikov
AM_CFLAGS already does all that we need. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index cd79901..d645542 100644 --- a/src/intel/vu

[Mesa-dev] [PATCH 19/25] configure.ac: remove unused HAVE_EGL_PLATFORM_NULL conditional

2016-04-21 Thread Emil Velikov
From: Emil Velikov Afaict the last user was based on st/egl. Signed-off-by: Emil Velikov --- Note: there's still a bit more work needed in the area. I've deliberatelly stopped here as it's going on a targent from the original goal. -Emil configure.ac | 1 - 1 file changed, 1 deletion(-)

[Mesa-dev] [PATCH 22/25] anv: place the builddir includes before the srcdir ones

2016-04-21 Thread Emil Velikov
Otherwise we risk picking the possibly outdated file in the source dir over the fresh one in the builddir. Signed-off-by: Emil Velikov --- The list feels a tad too large, although I've haven't tried cutting it down. -Emil src/intel/vulkan/Makefile.am | 10 +- 1 file changed, 5 insert

[Mesa-dev] [PATCH 00/25] Vulkan (build et al.) fixes

2016-04-21 Thread Emil Velikov
Hi all, While tryting to get a tarball and things went a bit strange, thus I've 'tweaked' the vulkan makefile and simplified things a fair bit. The series can be found in branch for-upstream/vulkan-makefile-cleanups in my github repo. Comments and review are greatly appreciated. Emil

[Mesa-dev] [PATCH 04/25] anv: tweak the LDFLAGS

2016-04-21 Thread Emil Velikov
From: Emil Velikov Copy/pasta from the rest of mesa, but namely. - The module should be shared only. - We don't need the explicit ".so", as the vulkan loader will retrieve the full filename from the json - No unresolved symbols in the final binary - Use the linker garbage collector to slim do

[Mesa-dev] [PATCH 10/25] anv: fold the tests' makefile

2016-04-21 Thread Emil Velikov
From: Emil Velikov Recent commit removed the winsys defines from anv_private.h thus breaking the tests. To fix that and avoid it in the future, merge the tests makefile in the libvulkan one. Signed-off-by: Emil Velikov --- configure.ac | 1 - src/intel/vulkan/Makefile.am

[Mesa-dev] [PATCH 07/25] anv: add missing link against the math library

2016-04-21 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index edd97f4..cd79901 100644 --- a/src/intel/vulkan/Makefile.am +++ b/src/intel/vulk

[Mesa-dev] [PATCH 05/25] anv: remove custom rule to install the intel_icd.json

2016-04-21 Thread Emil Velikov
From: Emil Velikov Autoconf already does the exact same thing as the manually written rule. Signed-off-by: Emil Velikov --- IMHO we can/should nuke --with-vulkan-icddir all together and/or change it to /usr/share vs /etc (according to the Vulkan docs). If there is something to control that sho

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

2016-04-21 Thread Stefan Dirsch
From: Jimmy Berry Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is consistent with vdpau and general gallium drivers. --- src/gallium/targets/va/Makefile.am | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/targets/va/Makefile.am b/src

[Mesa-dev] [PATCH 18/25] automake: drop "EGL_" from HAVE_EGL_PLATFORM_WAYLAND

2016-04-21 Thread Emil Velikov
Analogous to previous commit. Signed-off-by: Emil Velikov --- configure.ac | 2 +- src/Makefile.am | 2 +- src/egl/Makefile.am | 2 +- src/gbm/Makefile.am | 2 +- src/intel/vulkan/Makefile.am | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

2016-04-21 Thread Emil Velikov
From: Emil Velikov Rather than parsing through the same files (public headers) twice, tweak the python script to create both files at the same time. Chances are that if the public headers change, both files will need to be regenerated. Note to the python masters: this patch aims to be the least

[Mesa-dev] [PATCH 12/25] anv: use a common variable to manage the library dependencies

2016-04-21 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index 92e8f7f..6bf5bd7 100644 --- a/src/intel/vulkan/Makefile.am +++ b/src/inte

[Mesa-dev] [PATCH 24/25] anv: tweak libvulkan_intel.so link libraries

2016-04-21 Thread Emil Velikov
From: Emil Velikov I.e do not use -lfoo directly. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index 21a3abd..2713429 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 15/25] anv: factor out the X11/XCB build

2016-04-21 Thread Emil Velikov
From: Emil Velikov Similar to earlier commit - move all the common bits into a single place, thus improving readability and allowing us to see what's missing. Also don't forget to add the missing bits. This commit should allows us to build wayland only vulkan ;-) Signed-off-by: Emil Velikov --

[Mesa-dev] [PATCH 25/25] anv: automake: tweak anv_entrypoint.[ch] rule

2016-04-21 Thread Emil Velikov
From: Emil Velikov Rather than using cat + cpp feed the file(s) directly into the latter. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index 27134

[Mesa-dev] [PATCH 17/25] automake: drop "EGL_" from HAVE_EGL_PLATFORM_X11

2016-04-21 Thread Emil Velikov
The variable covers more than just EGL, let's try to untangle the confusion it brings. Signed-off-by: Emil Velikov --- configure.ac | 2 +- src/egl/Makefile.am | 2 +- src/intel/vulkan/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/con

[Mesa-dev] [PATCH 13/25] anv: refactor wayland build handling

2016-04-21 Thread Emil Velikov
Rather than having things split out in multiple places, consolidate it and add all the missing bits. Also ensure that we use the already built static library libwayland-drm.la. Signed-off-by: Emil Velikov --- Just realised that we should update the .gitignore as well. Patch for that coming in a

[Mesa-dev] [PATCH 23/25] anv: cosmetic makefile changes

2016-04-21 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index b7d1f87..21a3abd 100644 --- a/src/intel/vulkan/Makefil

[Mesa-dev] [PATCH 16/25] anv: get rid of VULKAN_ENTRYPOINT_CPPFLAGS variable

2016-04-21 Thread Emil Velikov
Add the missing include to AM_CPPFLAGS and use it throughout the makefile. Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index 3169a4d..3

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

2016-04-21 Thread Emil Velikov
Hi Stefan, On 21 April 2016 at 14:05, Stefan Dirsch wrote: > From: Jimmy Berry > > Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is > consistent with vdpau and general gallium drivers. There are two options here afaict: - Use an updated libva which already handles

Re: [Mesa-dev] [PATCH 04/13] nir: add a pass to lower some double operations

2016-04-21 Thread Samuel Iglesias Gonsálvez
On 20/04/16 05:31, Jason Ekstrand wrote: > On Tue, Apr 19, 2016 at 6:45 PM, Connor Abbott wrote: > >> On Tue, Apr 12, 2016 at 4:05 AM, Samuel Iglesias Gonsálvez >> wrote: >>> From: Connor Abbott >>> >>> v2: Move to compiler/nir (Iago) >>> >>> Signed-off-by: Iago Toral Quiroga >>> --- >>> sr

[Mesa-dev] [PATCH] gallium/radeon: nuke the final pre LLVN 3.6 codepath

2016-04-21 Thread Emil Velikov
Missed with commit 100796c15c3 "gallium/radeon: drop support for LLVM 3.5" Cc: Marek Olšák Cc: Nicolai Hähnle Signed-off-by: Emil Velikov --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-21 Thread Emil Velikov
Hi Rob, On 19 April 2016 at 20:38, Rob Herring wrote: > The RGBX/RGBA pixel formats used in the Android EGL don't get configs > created due to the missing formats in the DRI state tracker. This series > adds the necessary formats for configs and DRI images. Support in GBM is > also added as it wi

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-21 Thread Daniel Vetter
On Tue, Apr 19, 2016 at 05:11:29PM -0400, Rob Clark wrote: > From: Rob Clark > > Copied from linux kernel, with minimal changes to script (just to > recognize mesa src tree rather than linux kernel src tree), and slimmed > down MAINTAINER file syntax to recognize that we don't really have > subsy

[Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Hans de Goede
combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into: st u64 # g[$r2+0x0] $r2d But this is only valid if r2 contains an 8 byte aligned address, which is unknown. This commit checks for src0 dim 0 not being indirect when combining loads / stores as combinin

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-21 Thread Rob Clark
On Thu, Apr 21, 2016 at 9:50 AM, Daniel Vetter wrote: > On Tue, Apr 19, 2016 at 05:11:29PM -0400, Rob Clark wrote: >> From: Rob Clark >> >> Copied from linux kernel, with minimal changes to script (just to >> recognize mesa src tree rather than linux kernel src tree), and slimmed >> down MAINTAIN

Re: [Mesa-dev] [PATCH 00/10] RadeonSI: cleanup RW shader slots

2016-04-21 Thread Bas Nieuwenhuizen
On Wed, Apr 20, 2016 at 5:47 PM, Marek Olšák wrote: > Hi, > > This moves all private shader resources to the RW buffer bindings, including > all driver constant buffers, and the poly stipple image (which is converted > into a constant buffer). > > RW buffer descriptors are made global, not per s

Re: [Mesa-dev] [PATCH 0/4] Removing all double semi-colons

2016-04-21 Thread Emil Velikov
On 18 April 2016 at 19:17, Ian Romanick wrote: > With the one typo in the commit message of patch 1 fixed, the series is > > Reviewed-by: Ian Romanick > > If there are no objections or other comments, I'll go ahead and fix it > and push the series in the next day or so. > Aaand it's gone. [South

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-21 Thread Emil Velikov
On 20 April 2016 at 16:52, Mircea Gherzan wrote: > This header should not blindly include the GLX and should also > conditionally define functions that use GLX parameters. The > MESA_EGL_NO_X11_HEADERS macro is used to check if we're building without > GLX support. > Eek, I new this will come to b

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

2016-04-21 Thread Bas Nieuwenhuizen
On Wed, Apr 20, 2016 at 8:33 AM, wrote: > On 2016-04-20 11:46, Nicolai Hähnle wrote: >> >> On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: >>> >>> Signed-off-by: Bas Nieuwenhuizen >>> --- >>> src/gallium/drivers/radeonsi/si_compute.c | 5 - >>> src/gallium/drivers/radeonsi/si_state_sh

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Ilia Mirkin
On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: > combineLd/St would combine, i.e. : > > st u32 # g[$r2+0x0] $r2 > st u32 # g[$r2+0x4] $r3 > > into: > > st u64 # g[$r2+0x0] $r2d > > But this is only valid if r2 contains an 8 byte aligned address, > which is unknown. > > This commit checks

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 --- Comment #5 from Frederic Devernay --- OK, there was another issue, which actually may affect other Gallium drivers as well: st_framebuffer_reuse_or_create() uses pointer comparison to check if it can reuse a framebuffer. The problem is tha

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 Frederic Devernay changed: What|Removed |Added Attachment #123108|0 |1 is obsolete|

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 Frederic Devernay changed: What|Removed |Added Attachment #123109|0 |1 is obsolete|

[Mesa-dev] [PATCH v3 1/4] r600g/radeonsi: send endian info to format translation functions

2016-04-21 Thread Oded Gabbay
Because r600 GPUs can't do swap in their DB unit, we need to disable endianess swapping for textures that are handled by DB. There are four format translation functions in r600g driver: - r600_translate_texformat - r600_colorformat_endian_swap - r600_translate_colorformat - r600_translate_colorsw

[Mesa-dev] [PATCH v3 0/4] Fix OpenGL 1.3 big-endian support in r600g

2016-04-21 Thread Oded Gabbay
Hi, In v3 I removed all changes to gallium and mesa/st as they are no longer needed. All the work to recognize if and when we need to do endian swapping is done inside the r600g driver and no additional flag was added to any structure. This magic is done by understanding that the only use case w

[Mesa-dev] [PATCH v3 3/4] r600g: use do_endian_swap in color swapping functions

2016-04-21 Thread Oded Gabbay
For some formats we need to take "do_endian_swap" into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_state_common.c | 2 +- src/gallium/drivers/radeon/r600_texture.c| 20 +--- 2 files changed, 14 insertions(

[Mesa-dev] [PATCH v3 4/4] r600g: use do_endian_swap in texture swapping function

2016-04-21 Thread Oded Gabbay
For some texture formats we need to take "do_endian_swap" into account when configuring their swizzling. Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_state_common.c | 35 +++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH v3 2/4] r600g: set endianess of 16/32-bit buffers according to do_endian_swap

2016-04-21 Thread Oded Gabbay
This patch modifies r600_colorformat_endian_swap(), so for 16-bit and for 32-bit buffers, the endianess configuration will be determined not only by the color/texture format, but also by the do_endian_swap parameter. The only exception is for array formats, which are always set to not do swapping,

  1   2   3   >