Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread Alejandro Piñeiro
For next time, on the cases were minor changes are suggested, but a RB is granted in any case, you don't need to send the patch again to the list, you can made the changes locally and push directly without re-submitting to the list. BTW, talking about pushing, do you have push permissions? I can d

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Michel Dänzer
On 14.04.2016 11:37, Michel Dänzer wrote: > On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >> >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a4b74d1ba2c156766a7a5dbfef099c7db5d6694 >> Author: Marek Olšák >> Date: Mon Apr 11 19:56:07 2016 +0200 >> >> gallium/ra

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

2016-04-14 Thread Iago Toral
On Wed, 2016-04-13 at 10:57 -0400, Connor Abbott wrote: > On Wed, Apr 13, 2016 at 3:24 AM, Iago Toral wrote: > > On Tue, 2016-04-12 at 13:16 -0400, Connor Abbott wrote: > >> I'm not sure I'm so comfortable with this. For one, this is the sort > >> of thing the backend can (and should) do. Why shou

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-14 Thread Andres Gomez
Hi, this patch is still unreviewed. I'd welcome some help to get this into mesa :) -- Br, Andres signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

2016-04-14 Thread Iago Toral
On Thu, 2016-04-14 at 10:03 +0200, Iago Toral wrote: > On Wed, 2016-04-13 at 10:57 -0400, Connor Abbott wrote: > > On Wed, Apr 13, 2016 at 3:24 AM, Iago Toral wrote: > > > On Tue, 2016-04-12 at 13:16 -0400, Connor Abbott wrote: > > >> I'm not sure I'm so comfortable with this. For one, this is the

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

2016-04-14 Thread Iago Toral
On Wed, 2016-04-13 at 08:29 -0700, Jason Ekstrand wrote: > > On Apr 13, 2016 7:57 AM, "Connor Abbott" wrote: > > > > On Wed, Apr 13, 2016 at 3:24 AM, Iago Toral > wrote: > > > On Tue, 2016-04-12 at 13:16 -0400, Connor Abbott wrote: > > >> I'm not sure I'm so comfortable with this. For one, this

Re: [Mesa-dev] About border values in fp64 conversion tests

2016-04-14 Thread Andres Gomez
Thanks a lot for the comments, Roland. This confirms my understanding. Since there seems not to be any more feedback, I will now send the patch for conversion tests I was working on for piglit's review. Thanks again. :) On Tue, 2016-04-05 at 16:29 +0200, Roland Scheidegger wrote: > Pretty sure t

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Marek Olšák
Alex, Christian, Any idea why GTT is 30% slower on Kaveri than VRAM? See below. On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: > On 14.04.2016 11:37, Michel Dänzer wrote: >> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >>> >>> URL: >>> http://cgit.freedesktop.org/mesa/

Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-14 Thread Jakob Sinclair
On 2016-04-14 00:43, Ian Romanick wrote: It looks like there are a couple other instances dangling around the tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc. I did 'grep -r ';[[:space:]]*;' src/'. Most of the hits were for-loops. On 04/13/2016 09:43 AM, Jakob Sinclair wrote: Tr

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Christian König
Yeah, thinking about this since I've seen Michels response this morning. The only major thing which is different is the TLB pressure, e.g. VRAM is allocated continuously and so you can work much more with setting the fragmentation flag in the VM page tables. If you have a system to test this

[Mesa-dev] [PATCH v2 00/11] Fix OpenGL 1.3 big-endian support in r600g

2016-04-14 Thread Oded Gabbay
Changes in v2: I removed all the places in mesa/st code where I directly set the pipe_resource's endian_format. Instead, the initialization of this field is now done *only* at creation time of the pipe_resource object. To make that work, I had to change the interface of st_create_texture to ac

[Mesa-dev] [PATCH v2 03/11] mesa/st: add helper to return pipe_endian based on pipe_format

2016-04-14 Thread Oded Gabbay
Add a helper function which receives pipe_format value and returns a matching pipe_endian value. It is needed because almost every call to st_create_texture will use this function to send the pipe_endian value Signed-off-by: Oded Gabbay --- src/mesa/state_tracker/st_format.c | 51 +++

[Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Oded Gabbay
This patch adds a new field, called "endian_format", to "struct pipe_resource". The new field is of type "enum pipe_endian" and can receive one of two values: - PIPE_ENDIAN_LITTLE - PIPE_ENDIAN_NATIVE PIPE_ENDIAN_NATIVE is initialized to either PIPE_ENDIAN_LITTLE or PIPE_ENDIAN_BIG during build ti

[Mesa-dev] [PATCH v2 09/11] r600g: set endianess of 16/32-bit buffers according to endian_format

2016-04-14 Thread Oded Gabbay
This patch modifies r600_colorformat_endian_swap(), so for 16-bit and for 32-bit buffers, the endianess configuration will be determined not only by the color/texture format, but also by the resource's endian_format value. The only exception is for 8_8_8_8 formats, which are always set to little-e

[Mesa-dev] [PATCH v2 08/11] r600g: set staging texture endianess

2016-04-14 Thread Oded Gabbay
Set the default endianess of a staging texture to match the original texture's endianess. Signed-off-by: Oded Gabbay --- src/gallium/drivers/radeon/r600_texture.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/rade

[Mesa-dev] [PATCH v2 06/11] r600g: override endian when mapping to read

2016-04-14 Thread Oded Gabbay
When the driver performs a read from the GPU to the CPU, the endianess should always be set to NATIVE. Signed-off-by: Oded Gabbay --- src/gallium/drivers/radeon/r600_texture.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/galli

[Mesa-dev] [PATCH v2 01/11] r600g: fix code indentation

2016-04-14 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_blit.c | 18 +- src/gallium/drivers/r600/r600_pipe.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index 1a4cc42..2

[Mesa-dev] [PATCH v2 05/11] r600g/radeonsi: propagate endian_format to relevant functions

2016-04-14 Thread Oded Gabbay
This patch propagates the pipe_resource's endian_format field to relevant functions in the r600g driver. It doesn't make any use of it though. v2: squash the patch that fixes the calls from radeonsi Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/evergreen_state.c| 24 +-

[Mesa-dev] [PATCH] Don't manually close fds for queryImage. drm uses CLOEXEC

2016-04-14 Thread Chokshi, Mitul
If create_wl_buffer() closes the file descriptor returned by dri2_dpy->image->queryImage then OS hands out the same file descriptor number to other process which then experiences error when fd is closed due to CLOEXEC. Signed-off-by: Mitul Chokshi --- src/egl/drivers/dri2/platform_wayland.c | 2

[Mesa-dev] [PATCH v2 11/11] r600g: use endian_format in texture swapping function

2016-04-14 Thread Oded Gabbay
For some texture formats we need to take endian_format into account when configuring their swizzling. We also need to take into account those formats when we use staging textures. Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_state_common.c | 35 +++- src/g

[Mesa-dev] [PATCH v2 10/11] r600g: use endian_format in color swapping functions

2016-04-14 Thread Oded Gabbay
For some formats we need to take endian_format into account when configuring swapping for color buffers. Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_state_common.c | 5 - src/gallium/drivers/radeon/r600_texture.c| 11 --- 2 files changed, 12 insertions(+), 4 del

[Mesa-dev] [PATCH v2 02/11] r600g: Move R600_BIG_ENDIAN to r600_pipe_common.h

2016-04-14 Thread Oded Gabbay
I need to do this so I could use R600_BIG_ENDIAN in files which include r600_pipe_common.h but not r600_pipe.h Signed-off-by: Oded Gabbay --- src/gallium/drivers/r600/r600_pipe.h | 6 -- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ 2 files changed, 6 insertions(+), 6 de

[Mesa-dev] [PATCH v2 07/11] r600g: update endian_format after operations

2016-04-14 Thread Oded Gabbay
After operations are done, where resources have been copied to the GPU, we need to mark those resources as little-endian for future operations on them. Signed-off-by: Oded Gabbay --- src/gallium/drivers/radeon/r600_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/dri

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Alex Deucher
On Thu, Apr 14, 2016 at 3:29 AM, Michel Dänzer wrote: > On 14.04.2016 11:37, Michel Dänzer wrote: >> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >>> >>> URL: >>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a4b74d1ba2c156766a7a5dbfef099c7db5d6694 >>> Author: Marek Olšák

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Alex Deucher
On Thu, Apr 14, 2016 at 9:21 AM, Alex Deucher wrote: > On Thu, Apr 14, 2016 at 3:29 AM, Michel Dänzer wrote: >> On 14.04.2016 11:37, Michel Dänzer wrote: >>> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a4b7

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Ilia Mirkin
This feels like an incredibly confused interface to me... you talk about CPU <-> GPU, but I think that's a misnomer. What happens if you use up too much VRAM and something gets evicted to GART? Does it get byteswapped to the CPU-endianness? Are you treating everything as 32-bit packed integers impl

Re: [Mesa-dev] [PATCH v3] docs: expand "all drivers" to the list of drivers.

2016-04-14 Thread Emil Velikov
Hi Romain, While I appreciate the effort put in mesamatrix, I feel that things are steering towards the wrong direction here. That is, the file is (was?) meant to coordinate between developers on who's doing what, thus adding/changing policies in order to make it easier to be read/parsed by a PHP

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Oded Gabbay
On Thu, Apr 14, 2016 at 5:01 PM, Ilia Mirkin wrote: > This feels like an incredibly confused interface to me... I agree it's not the prettiest design I made, but considering big-endian is a class F citizen, then that's the best I got right now. I'm open to suggestions, but please guys don't tell m

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-14 Thread Marek Olšák
On Thu, Apr 14, 2016 at 3:21 PM, Alex Deucher wrote: > On Thu, Apr 14, 2016 at 3:29 AM, Michel Dänzer wrote: >> On 14.04.2016 11:37, Michel Dänzer wrote: >>> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a4b7

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Ilia Mirkin
On Thu, Apr 14, 2016 at 10:34 AM, Oded Gabbay wrote: > On Thu, Apr 14, 2016 at 5:01 PM, Ilia Mirkin wrote: >> This feels like an incredibly confused interface to me... > I agree it's not the prettiest design I made, but considering > big-endian is a class F citizen, then that's the best I got rig

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Oded Gabbay
On Thu, Apr 14, 2016 at 5:47 PM, Ilia Mirkin wrote: > On Thu, Apr 14, 2016 at 10:34 AM, Oded Gabbay wrote: >> On Thu, Apr 14, 2016 at 5:01 PM, Ilia Mirkin wrote: >>> This feels like an incredibly confused interface to me... >> I agree it's not the prettiest design I made, but considering >> big-

Re: [Mesa-dev] [PATCH] Don't manually close fds for queryImage. drm uses CLOEXEC

2016-04-14 Thread Daniel Stone
Hi, On 14 April 2016 at 13:19, Chokshi, Mitul wrote: > If create_wl_buffer() closes the file descriptor returned by > dri2_dpy->image->queryImage then OS hands out the same file > descriptor number to other process which then experiences error > when fd is closed due to CLOEXEC. I don't really u

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 Chuck Atkins changed: What|Removed |Added CC||chuck.atk...@kitware.com --- Comment #4 f

Re: [Mesa-dev] [PATCH] install-gallium-links.mk: handle multiple libraries

2016-04-14 Thread Emil Velikov
On 13 April 2016 at 21:06, Tim Rowley wrote: > Need to prevent bash from interpreting whitespace between libraries > as a command line. Reviewed-by: Emil Velikov .. and pushed it alongside the swr patch. Thanks Emil ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 Chuck Atkins changed: What|Removed |Added Attachment #122938|Patch to add the|Patch to add the description|--ena

Re: [Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-14 Thread Emil Velikov
On 13 April 2016 at 20:16, Jason Ekstrand wrote: > I guess I'm ok with the inline. I think it's ugly and nasty but the > compiler should get rid of it just fine. So I've converted this as an Acked-by, squashed the typo (Ian) and pushed the series. Thanks Emil P.S. And yes it does look a bit ug

[Mesa-dev] [PATCH] radeonsi: set SLC for atomics and coherent ops on APUs

2016-04-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- Hi Michel, perhaps we have to set the SLC (system level coherent) bit for images and buffers that may be accessed via GTT. Could you give this patch a try? Thanks, Nicolai --- src/gallium/drivers/radeonsi/si_shader.c | 12 ++-- 1 file changed, 10 insertions(+),

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Ilia Mirkin
On Thu, Apr 14, 2016 at 11:08 AM, Oded Gabbay wrote: >> Wouldn't it make more sense to handle such issues in transfer_map? >> (i.e. create a staging memory area, and decode into it)? This assumes >> that the transfer_map() call has enough information to "do the right >> thing". I don't think it do

Re: [Mesa-dev] [PATCH v3] docs: expand "all drivers" to the list of drivers.

2016-04-14 Thread Romain Failliot
Hi Emil! Actually this patch is less about mesamatrix and more about cleaning the file (IMO). By replacing "all drivers" with the actual list of drivers, I've noticed that it was easier to see which drivers are actually completed or not. I also think this will be problematic when new drivers are

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 --- Comment #5 from Chuck Atkins --- So, based on our discussion, I believe I've addressed this in the attached patch now by adding an --enable-gallium-xlib-glx option to specify gallium or classic xlib-glx implementation. I gave it this behavio

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 --- Comment #6 from Emil Velikov --- (In reply to Chuck Atkins from comment #5) > So, based on our discussion, I believe I've addressed this in the attached > patch now by adding an --enable-gallium-xlib-glx option to specify gallium > or classic

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 --- Comment #7 from Emil Velikov --- > --- a/configure.ac > +++ b/configure.ac > @@ -930,10 +930,9 @@ AC_ARG_ENABLE([xlib-glx], > [make GLX library Xlib-based instead of DRI-based > @<:@default=disabled@:>@])], > [enable_xlib_glx="$e

[Mesa-dev] [PATCH 0/4] Removing all double semi-colons

2016-04-14 Thread Jakob Sinclair
This patch series remove all double semi-colons in the code that were left after my last patch series. These patches should not actually change something. This is just cleanup work. I don't have push access so someone reviewing will have to push this. My last series haven't been pushed yet either.

[Mesa-dev] [PATCH 3/4] glx: Remove every double semi-colon

2016-04-14 Thread Jakob Sinclair
Signed-off-by: Jakob Sinclair --- src/glx/dri2_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 7710349..eae3c0f 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -405,7 +405,7 @@ dri2CreateDrawable(struct glx_screen

[Mesa-dev] [PATCH 2/4] gallium: Remove every double semi-colon

2016-04-14 Thread Jakob Sinclair
Signed-off-by: Jakob Sinclair --- src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 2 +- src/gallium/drivers/ilo/ilo_resource.c| 2 +- src/gallium/drivers/ilo/shader/ilo_shader_gs.c| 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp | 2 +-

[Mesa-dev] [PATCH 1/4] egl: Remove every double semi-colon

2016-04-14 Thread Jakob Sinclair
Removes all acidental semi-colons in egl. Signed-off-by: Jakob Sinclair --- src/egl/drivers/dri2/platform_android.c | 2 +- src/egl/drivers/dri2/platform_surfaceless.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/dr

[Mesa-dev] [PATCH 4/4] mesa: Remove every double semi-colon

2016-04-14 Thread Jakob Sinclair
Signed-off-by: Jakob Sinclair --- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 2 +- src/mesa/math/m_debug_norm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp index 84a

Re: [Mesa-dev] [PATCH v3] docs: expand "all drivers" to the list of drivers.

2016-04-14 Thread Emil Velikov
On 14 April 2016 at 16:48, Romain Failliot wrote: > Hi Emil! > > Actually this patch is less about mesamatrix and more about cleaning > the file (IMO). > By replacing "all drivers" with the actual list of drivers, I've > noticed that it was easier to see which drivers are actually completed > or n

Re: [Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

2016-04-14 Thread Emil Velikov
On 13 April 2016 at 22:03, Dongwon Kim wrote: > There are four different places where the program pointer may jump to > 'cleanup:' while the mutex is still possilby being locked. Two > of those cases are when mtx_lock(pthread_mutex_lock) fails to lock > the mutex. However, this can't be a problem

[Mesa-dev] [PATCH 0/6] nir: Implement a load-combine pass

2016-04-14 Thread Eduardo Lima Mitev
Hi, This is a series adding a new NIR pass that will combine redundant SSBO, shared variable and image load instructions. It is based on a previous series that Iago Toral [1] sent a few months ago, which I have updated to account for changes in NIR since then, and also added support for shared

[Mesa-dev] [PATCH 3/6] i965: use the load-combine pass

2016-04-14 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index fb7fa23..402cc60 100644 --- a/src/mesa/drivers/dri/i965/brw_nir.c +++ b/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 2/6] nir/load_combine: expand the pass to support load-after-store

2016-04-14 Thread Eduardo Lima Mitev
From: Iago Toral --- src/compiler/nir/nir_opt_load_combine.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_load_combine.c b/src/compiler/nir/nir_opt_load_combine.c index 25354c8..09a34c6 100644 --- a/src/compiler/n

[Mesa-dev] [PATCH 4/6] nir/opt_load_combine: Extend the pass to include shared variables

2016-04-14 Thread Eduardo Lima Mitev
--- src/compiler/nir/nir_opt_load_combine.c | 155 ++-- 1 file changed, 129 insertions(+), 26 deletions(-) diff --git a/src/compiler/nir/nir_opt_load_combine.c b/src/compiler/nir/nir_opt_load_combine.c index 09a34c6..3e3d066 100644 --- a/src/compiler/nir/nir_opt_load_

[Mesa-dev] [PATCH 1/6] nir: add a load-combine pass

2016-04-14 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga For now, this pass can handle ssbo load combines within the same block. This is useful, for example, to make code such as this: buffer SSBO { mat4 sm4; }; uniform mat4 um4; void main() { sm4 *= um4; } go from 16 SSBO loads down to only 4. v2: (elima) Updated

[Mesa-dev] [PATCH 5/6] nir/opt_load_combine: Extend the pass to include image load/store

2016-04-14 Thread Eduardo Lima Mitev
--- src/compiler/nir/nir_opt_load_combine.c | 170 +--- 1 file changed, 155 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_opt_load_combine.c b/src/compiler/nir/nir_opt_load_combine.c index 3e3d066..8f3d4d6 100644 --- a/src/compiler/nir/nir_opt_load_

Re: [Mesa-dev] [PATCH v3] docs: expand "all drivers" to the list of drivers.

2016-04-14 Thread Ian Romanick
Sorry for not paying attention sooner... the problem with this is that "all drivers" also means drivers that aren't (and won't be) in the list. It really means *all* drivers. i915 and r300 support ARB_sampler_objects, for example. I think in nearly all cases "all drivers" means that a driver can

Re: [Mesa-dev] [PATCH 0/6] nir: Implement a load-combine pass

2016-04-14 Thread Eduardo Lima Mitev
On 04/14/2016 06:52 PM, Eduardo Lima Mitev wrote: > Hi, > > This is a series adding a new NIR pass that will combine redundant SSBO, > shared variable and image load instructions. It is based on a previous series > that Iago Toral [1] sent a few months ago, which I have updated to account > for

Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread John Sheu
Thanks! I don't have push permissions actually, so all my stuff is going through the mailing list at the moment. -John Sheu On Thu, Apr 14, 2016 at 12:09 AM Alejandro Piñeiro wrote: > For next time, on the cases were minor changes are suggested, but a RB > is granted in any case, you don't nee

Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread Emil Velikov
On 14 April 2016 at 08:09, Alejandro Piñeiro wrote: > For next time, on the cases were minor changes are suggested, but a RB > is granted in any case, you don't need to send the patch again to the > list, you can made the changes locally and push directly without > re-submitting to the list. > > B

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 --- Comment #8 from Chuck Atkins --- (In reply to Emil Velikov from comment #6) > I'd rather not do that, as the current "enable foo when bar is on" feels > quite magic. Sometimes it gives you a warning although in all honestly, I > doubt (m)any

Re: [Mesa-dev] [PATCH] gallium/radeon: handle vertex shaders that disable clipping & viewport

2016-04-14 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.04.2016 10:37, Marek Olšák wrote: From: Marek Olšák This should fix Nine. --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_viewport.c| 20 +++- 2 files changed, 20 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH] nir/lower_io: Add UBOs and SSBOs to get_io_offset_src

2016-04-14 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index 8b660c1..238b86d 100644 --- a/src/compiler/nir/nir_lower_io.c +++ b/src/compiler/nir/nir_lower_io.c @@ -426,10 +426,13 @@ nir_get_io_of

Re: [Mesa-dev] [PATCH 11/16] nir/lower-io: split out some helper fxns

2016-04-14 Thread Rob Clark
On Fri, Apr 1, 2016 at 1:57 PM, Jason Ekstrand wrote: > I don't know that I like the lower-io prefix. Maybe nir/io-to-temp? > Doesn't really matter > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> Prep work to reduce the noise in the next patch. >> >> Signed-off

Re: [Mesa-dev] [RFC 01/24] nvc0: add preliminary support for images

2016-04-14 Thread Pierre Moreau
On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: > This implements set_shader_images() and resource invalidation for > images. As OpenGL requires at least 8 images, we are going to expose > this minimum value even if this might be raised for Kepler, but this > limit is mainly for Fermi because the

Re: [Mesa-dev] [PATCH 08/13] radeonsi: Add CE synchronization.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 24 2 files changed, 26 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH 12/13] gallium/util: Add u_bit_scan_consecutive_range64.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:35, Bas Nieuwenhuizen wrote: For use by radeonsi. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/auxiliary/util/u_math.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index b4ac0db..3a

Re: [Mesa-dev] [PATCH 13/13] radeonsi: Use CE for all descriptors.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:35, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_descriptors.c | 46 +-- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drive

Re: [Mesa-dev] [RFC 04/24] nvc0: bind images on 3D shaders for Kepler

2016-04-14 Thread Pierre Moreau
On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: > Similar to surfaces validation for compute shaders. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 +++- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 26 > - > 2 f

Re: [Mesa-dev] [PATCH 05/13] radeonsi: Create CE IB.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: Based on work by Marek Olšák. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_hw_context.c | 4 +++- src/gallium/dri

Re: [Mesa-dev] [PATCH 00/13] Use the constant engine in radeonsi

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: This series implements updating descriptors using the constant engine. This should result in a 0%-3% improvement for CPU bound applications, as we only have to upload the change descriptors from the CPU. Thanks again for looking at this! There are

Re: [Mesa-dev] [PATCH v2 04/20] radeonsi: implement shared atomics

2016-04-14 Thread Nicolai Hähnle
Patches 2-4 are Reviewed-by: Nicolai Hähnle On 13.04.2016 14:29, Bas Nieuwenhuizen wrote: v2: - Use single region - Use get_memory_ptr Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 77 +++- 1 file changed, 76 insertions(+)

[Mesa-dev] [PATCH 2/2] i965/surface_formats: Update some formats for more recent gens

2016-04-14 Thread Jason Ekstrand
The surface format table hasn't entirely been kept up-to-date. This commit marks a couple more compressed formats as sampleable on gen8+ and adds the A4B4G4R4 format as renderable on gen9. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 24 1 file changed, 12 insert

[Mesa-dev] [PATCH 1/2] i965: Expose the surface format table

2016-04-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_surface_formats.c | 22 +++-- src/mesa/drivers/dri/i965/brw_surface_formats.h | 43 + 3 files changed, 48 insertions(+), 18 deletions(-) create mode 100644 src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH v2 20/20] radeonsi: enable TGSI support cap for compute shaders

2016-04-14 Thread Nicolai Hähnle
Patches 7, 8, 12-14, 17 are Reviewed-by: Nicolai Hähnle On 13.04.2016 14:30, Bas Nieuwenhuizen wrote: v2: Use chip_class instead of family. Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Nicolai Hähnle --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html

[Mesa-dev] [PATCH v3] math: Import isinf and others to global namespace

2016-04-14 Thread Pierre Moreau
Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the namespace, and glibc 2.23 defines the C variants as macros, the C variants in global namespace are not accessible any longer. v2: Move the

[Mesa-dev] [PATCH 2/2] i965: add build rule for brw_nir_trig_workarounds.c on Android

2016-04-14 Thread Rob Herring
Commit bfd17c76c126 ("i965: Port INTEL_PRECISE_TRIG=1 to NIR.") added a generated file brw_nir_trig_workarounds.c which broke the Android build. Add the necessary makefiles to the Android build. Cc: Kenneth Graunke Cc: Emil Velikov Signed-off-by: Rob Herring --- src/mesa/drivers/dri/i965/Andro

[Mesa-dev] [PATCH 1/2] glsl: android: add back missing generated glcpp include path

2016-04-14 Thread Rob Herring
Commit 4db8f15a2576 ("glsl: move the android build scripts a level up") dropped a generated include path for glcpp. Add it back adjusting for the new location. Cc: Emil Velikov Signed-off-by: Rob Herring --- src/compiler/Android.glsl.gen.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/sr

[Mesa-dev] [PATCH 0/2] more Android build fixes

2016-04-14 Thread Rob Herring
A couple more Android build fixes after rebasing to the current tip. Android master builds are still a bit broken because makefiles get processed by kati in a different order. To fix, we need to go thru and eliminate all the variables set by one lower level makefile and used by another one. Ro

[Mesa-dev] [PATCH] glx: Refactor the configure options for glx implementation choice

2016-04-14 Thread Chuck Atkins
Instead of cascading support for various different implementations of GLX, all three options are now mutually exclusive top level options: --enable-glx : Enable the DRI-based GLX --enable-xlib-glx: Enable the classic Xlib-based GLX --enable-gallium-xlib-glx: Enable the gallium

[Mesa-dev] [PATCH] nvc0: do not break the universe on GK110+

2016-04-14 Thread Samuel Pitoiset
I removed that return 0 by mistake. Ooops. Fixes: 6e23fd4 ("nvc0: allow to use compute support on GM200") Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/ga

[Mesa-dev] [PATCH 00/11] update swr rasterizer

2016-04-14 Thread Tim Rowley
Another batch of updates to the swr rasterizer. No huge new features, but should fix at least one of the coverity flagged issues. Tim Rowley (11): swr: [rasterizer core] Use CS spill/fill size in core swr: [rasterizer fetch] Add support for fetching non-uniform component formats swr: [r

[Mesa-dev] [PATCH 06/11] swr: [rasterizer core] TemplateArgUnroller

2016-04-14 Thread Tim Rowley
Switch boolean template arguments to typename template arguments of type std::integral_constant. This allows the template argument unroller to easily be extended to enums. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 41 +-- .../drivers/swr/rasterizer/core/frontend.cpp | 12

[Mesa-dev] [PATCH 04/11] swr: [rasterizer core] Fix global arena allocator bug

2016-04-14 Thread Tim Rowley
- Plus some minor code refactoring --- src/gallium/drivers/swr/rasterizer/core/arena.h| 88 -- .../drivers/swr/rasterizer/core/backend.cpp| 5 +- 2 files changed, 51 insertions(+), 42 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/arena.h b/src

[Mesa-dev] [PATCH 09/11] swr: [rasterizer] Small cleanups

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/core/frontend.cpp | 3 ++- src/gallium/drivers/swr/rasterizer/core/frontend.h | 2 +- src/gallium/drivers/swr/rasterizer/core/utils.cpp | 31 +++--- src/gallium/drivers/swr/rasterizer/core/utils.h| 3 ++- .../drivers/swr/rasterizer/jitte

[Mesa-dev] [PATCH 02/11] swr: [rasterizer fetch] Add support for fetching non-uniform component formats

2016-04-14 Thread Tim Rowley
For example, R10G10B10A2_UNORM. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 190 - 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp inde

[Mesa-dev] [PATCH 01/11] swr: [rasterizer core] Use CS spill/fill size in core

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 4 +++- src/gallium/drivers/swr/rasterizer/core/api.h | 6 -- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 3 +-- src/gallium/drivers/swr/rasterizer/core/context.h | 1 + 4 files changed, 9 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 11/11] swr: [rasterizer memory] Constify load tiles

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp | 12 +++- src/gallium/drivers/swr/swr_memory.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp b/src/gallium/drivers/swr/rasterizer/

[Mesa-dev] [PATCH 07/11] swr: [rasterizer] Interpolation utility functions

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/common/simdintrin.h | 51 -- src/gallium/drivers/swr/rasterizer/core/frontend.h | 12 + src/gallium/drivers/swr/rasterizer/core/state.h| 2 - 3 files changed, 59 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rast

[Mesa-dev] [PATCH 05/11] swr: [rasterizer core] Arena: make most allocated blocks the same size

2016-04-14 Thread Tim Rowley
Reduces sorting cost --- src/gallium/drivers/swr/rasterizer/core/arena.h | 68 +++-- 1 file changed, 52 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/arena.h b/src/gallium/drivers/swr/rasterizer/core/arena.h index d0c0123..b80f6f0 100644

[Mesa-dev] [PATCH 10/11] swr: [rasterizer core] CompleteDrawContext changes for gcc

2016-04-14 Thread Tim Rowley
Add explicit inline and non-inline versions of CompleteDrawContext to make gcc happy. --- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/driv

[Mesa-dev] [PATCH 03/11] swr: [rasterizer core] Fix thread binding for 32-bit windows

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index 4b7a207..21bff4e 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 08/11] swr: [rasterizer scripts] Knob scripts tweaks

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/scripts/knob_defs.py| 4 +++- .../rasterizer/scripts/templates/knobs.template| 25 +- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/scripts/knob_defs.py b/src/gallium/drivers/swr/raste

Re: [Mesa-dev] [PATCH] nvc0: do not break the universe on GK110+

2016-04-14 Thread Ilia Mirkin
Oops indeed. Reviewed-by: Ilia Mirkin On Thu, Apr 14, 2016 at 3:50 PM, Samuel Pitoiset wrote: > I removed that return 0 by mistake. Ooops. > > Fixes: 6e23fd4 ("nvc0: allow to use compute support on GM200") > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

[Mesa-dev] [PATCH 2/2] configure: Add support for the Intel Vulkan driver

2016-04-14 Thread Jason Ekstrand
This adds a --with-vulkan-drivers option with one driver, "intel". In the future, we may add more drivers to this list. --- configure.ac | 66 1 file changed, 66 insertions(+) diff --git a/configure.ac b/configure.ac index 40b08d3..3cf

[Mesa-dev] [PATCH 1/2] configure: Detect valgrind headers

2016-04-14 Thread Jason Ekstrand
We have several places where the Vulkan driver explicitly hooks into valgrind when it's available. We need to be able to detect it. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c426c72..40b08d3 100644 --- a/configure.ac +++ b/config

Re: [Mesa-dev] [PATCH] glx: Refactor the configure options for glx implementation choice

2016-04-14 Thread Chuck Atkins
Thinking more about this, would it be better to implement as a single --enable-glx=dri|xlib|gallium-xlib option instead of three separate conflicting options? Most of the implementation would remain the same but it would certainly simplify the set of configure options a bit. - Chuck On Thu, Apr

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

2016-04-14 Thread Jason Ekstrand
On Thu, Apr 14, 2016 at 1:50 AM, Iago Toral wrote: > On Wed, 2016-04-13 at 08:29 -0700, Jason Ekstrand wrote: > > > > On Apr 13, 2016 7:57 AM, "Connor Abbott" wrote: > > > > > > On Wed, Apr 13, 2016 at 3:24 AM, Iago Toral > > wrote: > > > > On Tue, 2016-04-12 at 13:16 -0400, Connor Abbott wrote

Re: [Mesa-dev] [PATCH 01/13] nir/builder: add nir_imm_uint()

2016-04-14 Thread Jason Ekstrand
On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir_builder.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h > b/src/compiler/nir/nir_builder.h > index 29b13

[Mesa-dev] Mesa 11.2.1 release candidate

2016-04-14 Thread Emil Velikov
Hello list, The candidate for the Mesa 11.2.1 is now available. Currently we have: - 16 queued - 16 nominated (outstanding) - and 5 (self-)rejected patches The current queue fixes crashes in VAAPI and Nine, adds a drirc workaround for Warsow and resolves a few nouveau, radeonsi and i965 fixes.

Re: [Mesa-dev] [PATCH 1/2] configure: Detect valgrind headers

2016-04-14 Thread Matt Turner
On Thu, Apr 14, 2016 at 1:06 PM, Jason Ekstrand wrote: > We have several places where the Vulkan driver explicitly hooks into > valgrind when it's available. We need to be able to detect it. > --- > configure.ac | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/configure.ac b/confi

  1   2   >