Re: [Mesa-dev] [PATCH 05/10] radeonsi: fix calls to r600 functions that take endian_format

On Tue, Apr 12, 2016 at 12:17 AM, Marek Olšák wrote: > > This should be squashed with the patch changing those function signatures. > > Marek Yes, of course you are correct here. Oded > > On Mon, Apr 11, 2016 at 4:34 PM, Oded Gabbay wrote: > > radeonsi calls some r600 functions that now receive

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On 11.04.2016 23:34, Oded Gabbay wrote: > This patch adds a new field, called "endian_format", to > "struct pipe_resource". The new field is of type "enum pipe_endian" and > can receive one of two values: > - PIPE_ENDIAN_LITTLE > - PIPE_ENDIAN_NATIVE > > PIPE_ENDIAN_NATIVE is initialized to either

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 12:15 AM, Marek Olšák wrote: > I haven't read the following patches, but it looks like you can > override endian_format by passing that flag into transfer_map. I think I see what you mean. I'll try to follow that approach. Oded > > Alternatively, you could do the byteswa

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger wrote: > Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pipe_endian" and >> can receive one of two values: >> - PIPE_ENDIAN_LITTLE >

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 10:21 AM, Michel Dänzer wrote: > On 11.04.2016 23:34, Oded Gabbay wrote: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pipe_endian" and >> can receive one of two values: >> - PIPE_ENDIAN_LITTLE >> - PIPE

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On 12.04.2016 16:31, Oded Gabbay wrote: > On Tue, Apr 12, 2016 at 10:21 AM, Michel Dänzer wrote: >> On 11.04.2016 23:34, Oded Gabbay wrote: >>> This patch adds a new field, called "endian_format", to >>> "struct pipe_resource". The new field is of type "enum pipe_endian" and >>> can receive one of

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 10:40 AM, Michel Dänzer wrote: > On 12.04.2016 16:31, Oded Gabbay wrote: >> On Tue, Apr 12, 2016 at 10:21 AM, Michel Dänzer wrote: >>> On 11.04.2016 23:34, Oded Gabbay wrote: This patch adds a new field, called "endian_format", to "struct pipe_resource". The new

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger wrote: > Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pipe_endian" and >> can receive one of two values: >> - PIPE_ENDIAN_LITTLE >

[Mesa-dev] [PATCH 00/13] nir: add lowering passes for double ops

Hello, This series adds NIR-specific lowering passes for opcodes that operate with doubles. These lowering passes can be enabled individually by the drivers, through the respective flags, if the HW does not implement them natively. This series is needed for the i965 patches we are writing. This

[Mesa-dev] [PATCH 01/13] nir/builder: add nir_imm_uint()

From: Connor Abbott --- src/compiler/nir/nir_builder.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 29b13fb..38a1cf7 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -154,6 +154

[Mesa-dev] [PATCH 04/13] nir: add a pass to lower some double operations

From: Connor Abbott v2: Move to compiler/nir (Iago) Signed-off-by: Iago Toral Quiroga --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 7 + src/compiler/nir/nir_lower_double_ops.c | 387 3 files changed, 395 inser

[Mesa-dev] [PATCH 03/13] nir/builder: add nir_imm_double()

From: Connor Abbott --- src/compiler/nir/nir_builder.h | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 84fc9bf..5787ba8 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -116,6 +11

[Mesa-dev] [PATCH 06/13] nir/lower_double_ops: lower floor()

From: Iago Toral Quiroga At least i965 hardware does not have native support for floor on doubles. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_double_ops.c | 29 + 2 files changed, 30 insertions(+) diff --git a/src/compiler/nir/nir.

[Mesa-dev] [PATCH 09/13] nir/lower_double_ops: lower round_even()

From: Iago Toral Quiroga At least i965 hardware does not have native support for round_even() on doubles. --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_double_ops.c | 58 + 2 files changed, 60 insertions(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH 05/13] nir/lower_double_ops: lower trunc()

From: Iago Toral Quiroga At least i965 hardware does not have native support for truncating doubles. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_double_ops.c | 83 + 2 files changed, 84 insertions(+) diff --git a/src/compiler/ni

[Mesa-dev] [PATCH 07/13] nir/lower_double_ops: lower ceil()

From: Iago Toral Quiroga At least i965 hardware does not have native support for ceil on doubles. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_double_ops.c | 27 +++ 2 files changed, 28 insertions(+) diff --git a/src/compiler/nir/nir.h b

[Mesa-dev] [PATCH 10/13] nir: verify destination bit size when checking algebraic optimizations

Some instructions (like flrp in i965) cannot be lowered depending on the bit size because it doesn't support all bit sizes. If the bit size field is defined in nir_opt_algebraic.py, take it into account. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_algebraic.py | 11 +++

[Mesa-dev] [PATCH 13/13] nir/lower_double_ops: optimize set_exponent()

From: Iago Toral Quiroga By using pack_double_2x32_split_y instead of pack_double_2x32 we reduce register pressure since we no longer need to unpack the low 32-bits of the double. --- src/compiler/nir/nir_lower_double_ops.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 02/13] nir/builder: Add bit_size info to nir_build_imm()

Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_builder.h | 15 --- src/compiler/nir/nir_lower_system_values.c | 2 +- src/compiler/nir/nir_lower_tex.c | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/ni

[Mesa-dev] [PATCH 11/13] nir: Add lrp lowering for doubles in opt_algebraic

Some hardware (i965 on Broadwell generation, for example) does not support natively the execution of lrp instruction with double arguments. Add 'lower_lrp_double' flag to lower this instruction in that case. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir.h| 2

[Mesa-dev] [PATCH 08/13] nir/lower_double_ops: lower fract()

From: Iago Toral Quiroga At least i965 hardware does not have native support for fract() on doubles. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_double_ops.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compi

[Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

From: Iago Toral Quiroga This is useful when we only need to modify the high 32-bit chunk of a double. This is a common case, because this is the part that encodes the exponent which we manipulate in some double lowering passes. Although we can accomplish the same by using pack_double_2x32, this

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On 11/04/16 18:49, Ben Widawsky wrote: > This will fix the spurious error message: "Failed to query GPU properties." > that was unintentionally added in cc01b63d730. > > This patch changes the function to return an int so that the caller is able to > do stuff based on the return value. > > The eq

Re: [Mesa-dev] [PATCH 0/3] R600-GCN: Improving performance on APUs & IGPs

Reviewed-by: Edward O'Callaghan Thanks for working on this, Edward. On 2016-04-12 05:02, Marek Olšák wrote: Hi, This disables buffer moves between VRAM and GTT by setting both of them as preferred heaps for APUs and IGPs. Allocations go to VRAM if there is free space. If not, they go to GTT.

[Mesa-dev] [PATCH] i965: Add autogenerated 'brw_nir_trig_workarounds.c' to gitignore

--- src/mesa/drivers/dri/i965/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/.gitignore b/src/mesa/drivers/dri/i965/.gitignore index 8eb9f4e..70aae3f 100644 --- a/src/mesa/drivers/dri/i965/.gitignore +++ b/src/mesa/drivers/dri/i965/.gitignore @@ -1,3 +1,4

Re: [Mesa-dev] [PATCH] nir/clone: Copy bit size when cloning registers

Reviewed-by: Eduardo Lima Mitev On 04/12/2016 01:57 AM, Jason Ekstrand wrote: Reported-by: Mark Janes Cc: Eduardo Lima Mitev --- src/compiler/nir/nir_clone.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_clone.c b/src/compiler/nir/nir_clone.c index e889f19..e2313

Re: [Mesa-dev] [PATCH] i965: Add autogenerated 'brw_nir_trig_workarounds.c' to gitignore

On Tuesday, April 12, 2016 10:16:21 AM PDT Eduardo Lima Mitev wrote: > --- > src/mesa/drivers/dri/i965/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/.gitignore b/src/mesa/drivers/dri/ i965/.gitignore > index 8eb9f4e..70aae3f 100644 > --- a/src/mesa/

Re: [Mesa-dev] [PATCH] glsl: Update hash table comments in constant propagation

On Sunday, April 10, 2016 8:43:25 PM PDT Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > src/compiler/glsl/opt_constant_propagation.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/ glsl/opt_const

Re: [Mesa-dev] Newbie task to get started

On Sun, 2016-04-10 at 21:45 +0200, Jakob Sinclair wrote: > Hi! My name is Jakob Sinclair and I would like to start contributing > to  > mesa development. I was wondering if anyone has any easy tasks that I > as  > a newbie could start working on. I tried looking at  > https://wiki.freedesktop.org/d

Re: [Mesa-dev] [PATCH 2/2 v5] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

On Thursday, April 7, 2016 11:05:09 AM PDT Haixia Shi wrote: > It is incorrect to assume that pixel format is always in BGR byte order. > We need to check bitmask parameters (such as |redMask|) to determine whether > the RGB or BGR byte order is requested. > > v2: reformat code to stay within 80 c

Re: [Mesa-dev] [PATCH 1/2 v2] dri/i965: extend GLES3 sRGB workaround to cover all formats

On Thursday, April 7, 2016 11:05:08 AM PDT Haixia Shi wrote: > It is incorrect to assume BGRA byte order for the GLES3 sRGB workaround. > > v2: use _mesa_get_srgb_format_linear to handle all formats > > Signed-off-by: Haixia Shi > Reviewed-by: Stéphane Marchesin > Cc: kenneth.w.grau...@intel.co

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

On Tue, Apr 12, 2016 at 9:50 AM, Oded Gabbay wrote: > On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger > wrote: >> Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >>> This patch adds a new field, called "endian_format", to >>> "struct pipe_resource". The new field is of type "enum pipe_endian" an

Re: [Mesa-dev] 0001-va-check-null-context-in-vlVaDestroyContext.patch

On 11 April 2016 at 22:24, Iurie wrote: > From d6a5bbd910dc19d4863dbac8eba5bdf07bd1c3ab Mon Sep 17 00:00:00 2001 > From: GreatMaster > Please put your real name and add signed-off stamp: *git config --global user*.name "FirstName LastName" Then run : git commit --amend --reset-author --no-edit

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

On Tue, Apr 12, 2016 at 3:22 AM, Roland Scheidegger wrote: > Am 12.04.2016 um 02:04 schrieb Jason Ekstrand: >> >> >> On Mon, Apr 11, 2016 at 4:31 PM, Roland Scheidegger > > wrote: >> >> Am 12.04.2016 um 00:39 schrieb Brian Paul: >> > Instead of using an array ind

Re: [Mesa-dev] [PATCH mesa v2 1/2] nouveau: codegen: Use FILE_MEMORY_BUFFER for buffers

Hi, On 08-04-16 18:14, Samuel Pitoiset wrote: On 04/08/2016 12:17 PM, Hans de Goede wrote: Hi, On 23-03-16 23:10, Samuel Pitoiset wrote: Are you sure this won't break compute shaders on fermi? Could you please double-check that? I just checked: lspci: 01:00.0 VGA compatible controller: N

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

Hi Brian, I can see that the fix is in, so just a question for posterity. On 11 April 2016 at 23:39, Brian Paul wrote: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums but not updating the

Re: [Mesa-dev] [PATCH 3/4] i965/tiled_memcpy: Provide SSE2 for RGBA8 <-> BGRA8 swizzle.

On 11 April 2016 at 20:05, Matt Turner wrote: > From: Roland Scheidegger > > The existing code uses SSSE3, and because it isn't compiled in a > separate file compiled with that... Just a note (not meant to derail things): One should be able to compile just hunks of the code with sse2/sss3/other.

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: > radeon and r200 have a driconf option that is similar to this. It sets > a default initial max anisotropy value. Maybe that would be better? If driconf didn't copy /etc/drirc into ~/.drirc, it would indeed be better. This needs to be fixed

Re: [Mesa-dev] [PATCH 1/4] mesa: Use STATIC_ASSERT whenever possible.

Good idea! For the whole series: Reviewed-by: Eric Engestrom On Tue, Apr 12, 2016 at 07:37:43AM +0100, Jose Fonseca wrote: > --- > src/mesa/main/imports.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c > index 14cd588..

Re: [Mesa-dev] [PATCH 2/5] radeonsi: use guard band clipping

On Tue, Apr 12, 2016 at 1:53 AM, Marek Olšák wrote: > On Mon, Apr 11, 2016 at 7:37 PM, Nicolai Hähnle wrote: >> On 10.04.2016 17:34, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Guard band clipping speeds up rasterization for primitives that are >>> partially off-screen. This change in

[Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Signed-off-by: Bas Nieuwenhuizen --- src/gallium/docs/source/screen.rst | 5 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_

[Mesa-dev] [PATCH v2 3/3] radeonsi: Mark ARB_robust_buffer_access_behavior as supported.

Signed-off-by: Bas Nieuwenhuizen --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 066889a..423cafa 100644

[Mesa-dev] [PATCH v2 1/3] radeonsi: Expose the ARB_robust_buffer_access_behavior extension.

Signed-off-by: Bas Nieuwenhuizen --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/version.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index ddc

[Mesa-dev] [PATCH v2] va: check null context in vlVaDestroyContext

--- src/gallium/state_trackers/va/context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index b25c381..77be8de 100644 --- a/src/gallium/state_trackers/va/context.c +++ b/src/gallium/state_trackers/va/co

[Mesa-dev] [PATCH v2] va: check null context in vlVaDestroyContext

--- src/gallium/state_trackers/va/context.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index b25c381..77be8de 100644 --- a/src/gallium/state_trackers/va/context.c +++ b/src/gallium/state_trackers/va/co

Re: [Mesa-dev] [PATCH 03/10] mesa/st: add endian_format field to struct pipe_resource

Am 12.04.2016 um 09:50 schrieb Oded Gabbay: > On Mon, Apr 11, 2016 at 6:34 PM, Roland Scheidegger > wrote: >> Am 11.04.2016 um 16:34 schrieb Oded Gabbay: >>> This patch adds a new field, called "endian_format", to >>> "struct pipe_resource". The new field is of type "enum pipe_endian" and >>> can

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

On 04/12/2016 04:56 AM, Emil Velikov wrote: Hi Brian, I can see that the fix is in, so just a question for posterity. On 11 April 2016 at 23:39, Brian Paul wrote: Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression caused by inserting new

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/docs/source/screen.rst | 5 + > src/gallium/drivers/freedreno/freedreno_screen.c | 1 + > src/gallium/drivers/i915/i915_screen.c | 1 + > src/gallium/drivers/ilo/il

Re: [Mesa-dev] [PATCH 3/4] i965/tiled_memcpy: Provide SSE2 for RGBA8 <-> BGRA8 swizzle.

Am 12.04.2016 um 13:00 schrieb Emil Velikov: > On 11 April 2016 at 20:05, Matt Turner wrote: >> From: Roland Scheidegger >> >> The existing code uses SSSE3, and because it isn't compiled in a >> separate file compiled with that... > Just a note (not meant to derail things): > > One should be abl

Re: [Mesa-dev] [PATCH v2 3/3] radeonsi: Mark ARB_robust_buffer_access_behavior as supported.

Whether or not you change the CAP name as Roland suggested, for the series: Reviewed-by: Marek Olšák Marek On Tue, Apr 12, 2016 at 3:12 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > docs/GL3.txt | 2 +- > docs/relnotes/11.3.0.html

Re: [Mesa-dev] [PATCH 3/4] i965/tiled_memcpy: Provide SSE2 for RGBA8 <-> BGRA8 swizzle.

On 12 April 2016 at 14:57, Roland Scheidegger wrote: > Am 12.04.2016 um 13:00 schrieb Emil Velikov: >> On 11 April 2016 at 20:05, Matt Turner wrote: >>> From: Roland Scheidegger >>> >>> The existing code uses SSSE3, and because it isn't compiled in a >>> separate file compiled with that... >> Ju

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger wrote: > Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: >> Signed-off-by: Bas Nieuwenhuizen >> --- >> src/gallium/docs/source/screen.rst | 5 + >> src/gallium/drivers/freedreno/freedreno_screen.c | 1 + >> src/gallium/drive

Re: [Mesa-dev] [PATCH v2] va: check null context in vlVaDestroyContext

On 12 April 2016 at 14:27, iurie wrote: It should be "Firstname Lastname" , click on any commit here https://cgit.freedesktop.org/mesa/mesa/log/ to compare or just type: git log It is a common practice for most open source projects and sometimes a requirement. Not sure if this is strictly require

Re: [Mesa-dev] [PATCH 2/5] radeonsi: use guard band clipping

On 12.04.2016 07:45, Marek Olšák wrote: On Tue, Apr 12, 2016 at 1:53 AM, Marek Olšák wrote: On Mon, Apr 11, 2016 at 7:37 PM, Nicolai Hähnle wrote: On 10.04.2016 17:34, Marek Olšák wrote: From: Marek Olšák Guard band clipping speeds up rasterization for primitives that are partially off-sc

Re: [Mesa-dev] [PATCH 2/5] radeonsi: use guard band clipping

On Apr 12, 2016 8:46 AM, "Marek Olšák" wrote: > > On Tue, Apr 12, 2016 at 1:53 AM, Marek Olšák wrote: > > On Mon, Apr 11, 2016 at 7:37 PM, Nicolai Hähnle wrote: > >> On 10.04.2016 17:34, Marek Olšák wrote: > >>> > >>> From: Marek Olšák > >>> > >>> Guard band clipping speeds up rasterization for

[Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

If the glDrawPixels size changed, we leaked the previously cached texture, if there was one. This patch fixes the reference counting, adds a refcount assertion check, and better handles potential malloc() failures. Tested with a modified version of the drawpix Mesa demo which changed the image si

Re: [Mesa-dev] [PATCH 02/13] nir/builder: Add bit_size info to nir_build_imm()

On Apr 12, 2016 1:06 AM, "Samuel Iglesias Gonsálvez" wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/compiler/nir/nir_builder.h | 15 --- > src/compiler/nir/nir_lower_system_values.c | 2 +- > src/compiler/nir/nir_lower_tex.c | 2 +- > 3 files

Re: [Mesa-dev] [PATCH 0/3] nir: Convert nir_variable_mode to a bitfield

On Apr 12, 2016 7:52 AM, "Eirik Byrkjeflot Anonsen" wrote: > > Jason Ekstrand writes: > > > This tiny series converts nir_var_mode to be a bitfield instead of a > > regular enum and then converts two of the passes that currently take a mode > > to handle the new bitfield. The reason for this is

Re: [Mesa-dev] [PATCH 4/4] gallium: Use STATIC_ASSERT whenever possible.

Am 12.04.2016 um 08:37 schrieb Jose Fonseca: > --- > src/gallium/auxiliary/rtasm/rtasm_x86sse.c | 2 +- > src/gallium/auxiliary/tgsi/tgsi_lowering.c | 2 +- > src/gallium/auxiliary/tgsi/tgsi_parse.c| 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxilia

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On Apr 11, 2016 9:49 AM, "Ben Widawsky" wrote: > > This will fix the spurious error message: "Failed to query GPU properties." > that was unintentionally added in cc01b63d730. > > This patch changes the function to return an int so that the caller is able to > do stuff based on the return value. >

[Mesa-dev] [PATCH 1/2] scons: Allow building with Address Sanitizer.

libasan is never linked to shared objects (which doesn't go well with -z,defs). It must either be linked to the main executable, or (more practically for OpenGL drivers) be pre-loaded via LD_PRELOAD. Otherwise works. I didn't find anything with llvmpipe. I suspect the fact that the JIT compiled

[Mesa-dev] [PATCH 2/2] softpipe: Free tgsi.image elements on context destruction.

Courtesy of address sanitizer. --- src/gallium/drivers/softpipe/sp_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/softpipe/sp_context.c b/src/gallium/drivers/softpipe/sp_context.c index f66fea2..1d62177 100644 --- a/src/gallium/drivers/softpipe/sp_context.c

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: > On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger > wrote: >> Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: >>> Signed-off-by: Bas Nieuwenhuizen >>> --- >>> src/gallium/docs/source/screen.rst | 5 + >>> src/gallium/driv

Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

On 12/04/16 16:15, Brian Paul wrote: If the glDrawPixels size changed, we leaked the previously cached texture, if there was one. This patch fixes the reference counting, adds a refcount assertion check, and better handles potential malloc() failures. Tested with a modified version of the drawp

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger wrote: > Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: >> On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger >> wrote: >>> Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On 04/12/2016 05:21 AM, Marek Olšák wrote: > On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: >> radeon and r200 have a driconf option that is similar to this. It sets >> a default initial max anisotropy value. Maybe that would be better? > > If driconf didn't copy /etc/drirc into ~/.drirc,

Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

Looks good to me too. Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Jose Fonseca Sent: Tuesday, April 12, 2016 9:24 AM To: Brian Paul; mesa-dev@lists.freedesktop.org Cc: 11.2 Subject: Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: > On 04/12/2016 05:21 AM, Marek Olšák wrote: >> On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: >>> radeon and r200 have a driconf option that is similar to this. It sets >>> a default initial max anisotropy value. Maybe that would be be

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 18:26 schrieb Bas Nieuwenhuizen: > On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger > wrote: >> Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: >>> On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger >>> wrote: Am 12.04.2016 um 15:12 schrieb Bas Nieuwenhuizen: > S

Re: [Mesa-dev] [PATCH 1/2] scons: Allow building with Address Sanitizer.

Am 12.04.2016 um 18:03 schrieb Jose Fonseca: > libasan is never linked to shared objects (which doesn't go well with > -z,defs). It must either be linked to the main executable, or (more > practically for OpenGL drivers) be pre-loaded via LD_PRELOAD. > > Otherwise works. > > I didn't find anythi

Re: [Mesa-dev] [PATCH 2/2] softpipe: Free tgsi.image elements on context destruction.

Am 12.04.2016 um 18:03 schrieb Jose Fonseca: > Courtesy of address sanitizer. > --- > src/gallium/drivers/softpipe/sp_context.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/softpipe/sp_context.c > b/src/gallium/drivers/softpipe/sp_context.c > index f66fea2..1d

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On Tue, Apr 12, 2016 at 11:39 AM, Jason Ekstrand wrote: > > On Apr 11, 2016 9:49 AM, "Ben Widawsky" wrote: >> >> This will fix the spurious error message: "Failed to query GPU >> properties." >> that was unintentionally added in cc01b63d730. >> >> This patch changes the function to return an int

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

I'm not sure I'm so comfortable with this. For one, this is the sort of thing the backend can (and should) do. Why should be be adding stuff at the NIR level to help the backend's copy propagation pass? And perhaps more importantly, why should we be adding stuff at the NIR level to workaround the l

[Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

From: Nicolai Hähnle This was triggered by dEQP-GLES3.functional.vertex_array_objects.all_attributes Cc: "11.1 11.2" --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/ra

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On 04/12/2016 09:39 AM, Marek Olšák wrote: > On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: >> On 04/12/2016 05:21 AM, Marek Olšák wrote: >>> On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: radeon and r200 have a driconf option that is similar to this. It sets a default init

Re: [Mesa-dev] [PATCH] i965: Make intel_get_param return an int

On 04/11/2016 09:49 AM, Ben Widawsky wrote: > This will fix the spurious error message: "Failed to query GPU properties." > that was unintentionally added in cc01b63d730. > > This patch changes the function to return an int so that the caller is able to > do stuff based on the return value. > > T

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

https://bugs.freedesktop.org/show_bug.cgi?id=91169 --- Comment #6 from xdshot9...@gmail.com --- It also crashes on Intel graphics with the latest mesa from git. The patch fixes this problem though. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee f

Re: [Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 12, 2016 at 7:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This was triggered by > dEQP-GLES3.functional.vertex_array_objects.all_attributes > > Cc: "11.1 11.2" > --- > src/gallium/drivers/radeonsi/si_state.c | 2 +- > 1 file changed, 1 in

[Mesa-dev] [PATCH] build: Fix LLVM shared library detection on systems with libLLVM.so.

Arch Linux ships libLLVM.so.3.7.1 rather than libLLVM-3.7.1.so; Mesa's configure script failed to find LLVM shared libraries in this case. I believe they build LLVM with CMake, but there is still only one .so file. Signed-off-by: Kenneth Graunke --- configure.ac | 6 ++ 1 file changed, 6 in

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

2016-04-12 19:27 GMT+02:00 Ian Romanick : > On 04/12/2016 09:39 AM, Marek Olšák wrote: >> On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: >>> On 04/12/2016 05:21 AM, Marek Olšák wrote: On Mon, Apr 11, 2016 at 9:33 PM, Ian Romanick wrote: > radeon and r200 have a driconf option that

Re: [Mesa-dev] [PATCH v2 2/3] gallium: Add capability for ARB_robust_buffer_access_behavior

Am 12.04.2016 um 18:45 schrieb Roland Scheidegger: > Am 12.04.2016 um 18:26 schrieb Bas Nieuwenhuizen: >> On Tue, Apr 12, 2016 at 6:09 PM, Roland Scheidegger >> wrote: >>> Am 12.04.2016 um 16:23 schrieb Bas Nieuwenhuizen: On Tue, Apr 12, 2016 at 3:56 PM, Roland Scheidegger wrote:

Re: [Mesa-dev] [PATCH] swr: handle pci cap requests

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: handle pci cap requests > > --- > sr

Re: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders >

[Mesa-dev] [PATCH] mesa/st: Replace GLvoid with void

GLvoid was used before in OpenGL but it has changed to just using void. All GLvoids in mesa's state tracker has been changed to void in this patch. Tested this with piglit and no problems were found. No compiler warnings also. I also don't have push acces to the repository so someone that is revie

[Mesa-dev] [PATCH] xlib: fix memory leak on Display close

The XMesaVisual instances freed in the visuals table on display close are being freed with a free() call, instead of XMesaDestroyVisual(), causing a memory leak. Signed-off-by: John Sheu --- src/mesa/drivers/x11/fakeglx.c | 2 +- src/mesa/drivers/x11/xm_api.c | 1 + 2 files changed, 2 insertion

[Mesa-dev] (no subject)

Thanks for the heads-up. I only found one other place where a similar leak occurs -- and in the case of xm_api.c, I figure that XMesaDestroyVisual() is an "client-facing" call, so in the interest of maintaining layering I've just made the appropriate free() call. _

Re: [Mesa-dev] [PATCH] gallium/radeon: add an env variable to force a level of aniso filtering

On Tue, Apr 12, 2016 at 7:59 PM, Ernst Sjöstrand wrote: > 2016-04-12 19:27 GMT+02:00 Ian Romanick : >> On 04/12/2016 09:39 AM, Marek Olšák wrote: >>> On Tue, Apr 12, 2016 at 6:32 PM, Ian Romanick wrote: On 04/12/2016 05:21 AM, Marek Olšák wrote: > On Mon, Apr 11, 2016 at 9:33 PM, Ian Rom

Re: [Mesa-dev] [PATCH] radeonsi: fix bounds check in si_create_vertex_elements

Reviewed-by: Marek Olšák Marek On Tue, Apr 12, 2016 at 7:25 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This was triggered by > dEQP-GLES3.functional.vertex_array_objects.all_attributes > > Cc: "11.1 11.2" > --- > src/gallium/drivers/radeonsi/si_state.c | 2 +- > 1 file changed, 1 i

Re: [Mesa-dev] [PATCH] xlib: fix memory leak on Display close

On Tue, Apr 12, 2016 at 11:53 AM, John Sheu wrote: > The XMesaVisual instances freed in the visuals table on display close > are being freed with a free() call, instead of XMesaDestroyVisual(), > causing a memory leak. > > Signed-off-by: John Sheu > --- > src/mesa/drivers/x11/fakeglx.c | 2 +- >

[Mesa-dev] [PATCH] radeon/uvd: fix tonga feedback buffer size

This only applies to tonga Signed-off-by: Leo Liu Reviewed-by: Christian König Cc: "11.1 11.2" --- src/gallium/drivers/radeon/radeon_uvd.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/rade

Re: [Mesa-dev] [PATCH] mesa/st: Replace GLvoid with void

On 04/12/2016 12:48 PM, Jakob Sinclair wrote: GLvoid was used before in OpenGL but it has changed to just using void. All GLvoids in mesa's state tracker has been changed to void in this patch. Tested this with piglit and no problems were found. No compiler warnings also. I also don't have push

Re: [Mesa-dev] [PATCH] xlib: fix memory leak on Display close

On 04/12/2016 12:53 PM, John Sheu wrote: The XMesaVisual instances freed in the visuals table on display close are being freed with a free() call, instead of XMesaDestroyVisual(), causing a memory leak. Signed-off-by: John Sheu --- src/mesa/drivers/x11/fakeglx.c | 2 +- src/mesa/drivers/x11/

[Mesa-dev] [PATCH 2/2] meta: Don't botch color masks when changing drawbuffers.

Color clears should respect each drawbuffer's color mask state. Previously, we tried to leave the color mask untouched. However, _mesa_meta_drawbuffers_from_bitfield() ended up rebinding all the color drawbuffers in a different order, so we ended up pairing drawbuffers with the wrong color mask s

[Mesa-dev] [PATCH 1/2] meta: Don't smash ColorMask when using MESA_META_COLOR_MASK save bit.

This allows meta operations to inspect the existing color mask, and then do their own smashing. BlitFramebuffer and Clear already override the color mask, so this was also redundant. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/common/meta.c | 7 ++- src/mesa/drivers/

Re: [Mesa-dev] Newbie task to get started

On 2016-04-12 11:00, Timothy Arceri wrote: On Sun, 2016-04-10 at 21:45 +0200, Jakob Sinclair wrote: Hi! My name is Jakob Sinclair and I would like to start contributing to  mesa development. I was wondering if anyone has any easy tasks that I as  a newbie could start working on. I tried looking

[Mesa-dev] [Bug 94907] codegen/nv50_ir_ra.cpp:1330:29: error: ‘isinf’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=94907 Bug ID: 94907 Summary: codegen/nv50_ir_ra.cpp:1330:29: error: ‘isinf’ was not declared in this scope Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH] glsl: Don't copy propagate or tree graft precise values.

This is kind of a hack. We currently track precise requirements by decorating ir_variables. Propagating or grafting the RHS of an assignment to a precise value into some other expression tree can lose those decorations. In the long run, it might be better to replace these ir_variable decorations

[Mesa-dev] [Bug 94907] codegen/nv50_ir_ra.cpp:1330:29: error: ‘isinf’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=94907 --- Comment #1 from Ilia Mirkin --- Should be fixed by https://patchwork.freedesktop.org/patch/79115/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [PATCH 4/4] glsl/linker: Recurse on struct fields when adding shader variables

From: Kristian Høgsberg Kristensen ARB_program_interface_query requires that we add struct fields recursively down to basic types. Fixes 52 struct test cases in dEQP-GLES31.functional.program_interface_query.* Signed-off-by: Kristian Høgsberg Kristensen --- src/compiler/glsl/linker.cpp | 51 +

[Mesa-dev] [PATCH 3/4] glsl/linker: Pass name and type through to create_shader_variable()

From: Kristian Høgsberg Kristensen No functional change here, but this now lets us recurse throught structs in add_shader_variable(). Signed-off-by: Kristian Høgsberg Kristensen --- src/compiler/glsl/linker.cpp | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff

  1   2   3   >