[Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Ernst Sjöstrand
Hi! Sorry if this is a silly question but I was thinking that there would be a Vulkan Gallium state tracker in development behind closed doors somehow. However I guess that's not the case? I guess the Nouveau and Freedreno people are interested in this at least, and AMD is busy with their closed s

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Dave Airlie
On 17 February 2016 at 18:31, Ernst Sjöstrand wrote: > Hi! > > Sorry if this is a silly question but I was thinking that there would > be a Vulkan Gallium state tracker in development behind closed doors > somehow. However I guess that's not the case? It doesn't make sense to write a vulkan state

Re: [Mesa-dev] intel skylake gpu support

2016-02-17 Thread Jarkko Korpi
From: jarkko_ko...@hotmail.com To: b...@bwidawsk.net CC: mesa-dev@lists.freedesktop.org Subject: RE: [Mesa-dev] intel skylake gpu support Date: Tue, 16 Feb 2016 16:30:44 + Well I have few years of linux experience, but I find this system still so new to me when it comes to modifying syst

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

2016-02-17 Thread Ilia Mirkin
On Feb 17, 2016 2:14 AM, "Kenneth Graunke" wrote: > > On Tuesday, February 16, 2016 6:29:39 PM PST Ilia Mirkin wrote: > > See commit 9db2098d which did it internally to the i965 driver. No > > reason not to have this more globally set though. > > > > This fixes depth in a bunch of dEQP EXT_texture

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Manolova, Plamena
On Mon, Feb 15, 2016 at 10:50 PM, Ilia Mirkin wrote: > In a few places your indentation is off -- please look at the 'git > diff' output, it should be pretty obvious. You used 2 spaces instead > of 3 (in just a handful of places). > Thanks for spotting this, it must've slipped by me. > > On Fr

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Manolova, Plamena
On Wed, Feb 17, 2016 at 1:22 PM, Manolova, Plamena < plamena.manol...@intel.com> wrote: > > > On Mon, Feb 15, 2016 at 10:50 PM, Ilia Mirkin > wrote: > >> In a few places your indentation is off -- please look at the 'git >> diff' output, it should be pretty obvious. You used 2 spaces instead >> o

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 6:29 AM, Manolova, Plamena wrote: >>> > + if (entries_total > 0) >>> > + entries_total -= 1; >>> >>> This seems weird... why are you doing that? > > > According to the spec: > https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt: > "The explicitly

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Manolova, Plamena
You're right, changing the if statement to a > b would be less confusing, I'll go ahead and do that. On Wed, Feb 17, 2016 at 2:35 PM, Ilia Mirkin wrote: > On Wed, Feb 17, 2016 at 6:29 AM, Manolova, Plamena > wrote: > >>> > + if (entries_total > 0) > >>> > + entries_total -= 1; > >>> > >>

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] mapi_abi: Allow more dynamic entries

2016-02-17 Thread Tapani Pälli
On 02/12/2016 07:41 AM, Tapani Pälli wrote: On 02/12/2016 07:32 AM, Matt Turner wrote: On Thu, Feb 11, 2016 at 9:27 PM, Tapani Pälli wrote: On 02/12/2016 02:04 AM, Emil Velikov wrote: On 11 February 2016 at 12:03, Tapani Pälli wrote: From: Bernard Kilarski Here we should have jus

[Mesa-dev] [PATCH] st/mesa: force depth mode to GL_RED for sized depth/stencil formats

2016-02-17 Thread Ilia Mirkin
See commit 9db2098d for the i965 version of this. This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And probably other ones as well. Signed-off-by: Ilia Mirkin Cc: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- This replaces my patch "mesa: default DepthMode to GL_RED

[Mesa-dev] [PATCH] st/mesa: apply DepthMode swizzle to stencil texturing as well

2016-02-17 Thread Ilia Mirkin
Gallium doesn't present these as GL_RED-style. A swizzle is necessary to present the proper data in the unused components. Signed-off-by: Ilia Mirkin --- The GL 4.5 compat spec also makes it clear that sampling from stencil is the same as sampling from depth (except obviously the stencil value i

[Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Plamena Manolova
This patch moves the calculation of current uniforms to link_uniforms, which makes use of UniformRemapTable which stores all the reserved uniform locations. Location assignment for implicit uniforms now tries to use any gaps left in the table after the location assignment for explicit uniforms. Th

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 8:49 AM, Plamena Manolova wrote: > This patch moves the calculation of current uniforms to > link_uniforms, which makes use of UniformRemapTable which > stores all the reserved uniform locations. > > Location assignment for implicit uniforms now tries to use > any gaps left

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-17 Thread Manolova, Plamena
Thank you for reviewing. The change has been run through both Piglit and CTS. I'll ask Tapani to take another look just in case. On Wed, Feb 17, 2016 at 4:20 PM, Ilia Mirkin wrote: > On Wed, Feb 17, 2016 at 8:49 AM, Plamena Manolova > wrote: > > This patch moves the calculation of current unifo

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Jose Fonseca
On 17/02/16 10:24, Dave Airlie wrote: On 17 February 2016 at 18:31, Ernst Sjöstrand wrote: Hi! Sorry if this is a silly question but I was thinking that there would be a Vulkan Gallium state tracker in development behind closed doors somehow. However I guess that's not the case? It doesn't m

[Mesa-dev] [PATCH] i965: Add missing null checks in intel_mipmap_tree.c

2016-02-17 Thread Juha-Pekka Heikkila
Just check miptree_create() returned other than NULL as everywhere else in the file. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dr

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Rob Clark
On Wed, Feb 17, 2016 at 10:04 AM, Jose Fonseca wrote: > On 17/02/16 10:24, Dave Airlie wrote: >> >> On 17 February 2016 at 18:31, Ernst Sjöstrand wrote: >>> >>> Hi! >>> >>> Sorry if this is a silly question but I was thinking that there would >>> be a Vulkan Gallium state tracker in development b

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-17 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 11:22 PM, Olivier Galibert wrote: > I'm actually interested about how one goes about debugging that kind > of problem, if you have pointers. I would have an idea or two on how > to go about it if it was in userspace only, but once it crosses into > the kernel I'm not sure

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-17 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 11:41 PM, Iago Toral wrote: > Hey Jason, > > this is awesome news, congrats to all the people involved! > Thanks! > Did you have a chance to try the new driver with anything other than > conformance tests or small demos? I know it is still in a very early > stage but I'

Re: [Mesa-dev] [PATCH] i965/gen7: Use predicated rendering for indirect compute

2016-02-17 Thread Ilia Mirkin
On Tue, Feb 16, 2016 at 1:09 PM, Jordan Justen wrote: > On gen7 (Ivy Bridge, Haswell), we will get a GPU hang if an indirect > dispatch is used, but one of the dimensions is 0. > > Therefore we use predicated rendering on the GPGPU_WALKER command to > handle this case. > > Fixes piglit test: spec/

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94193 Bug ID: 94193 Summary: [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0x Product: Mesa Version: 10.6 Hardware: Other

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94193 --- Comment #1 from Florian Link --- Created attachment 121811 --> https://bugs.freedesktop.org/attachment.cgi?id=121811&action=edit GL_LINE_STIPPLE disabled -- You are receiving this mail because: You are the assignee for the bug. You are th

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94193 Florian Link changed: What|Removed |Added Attachment #121810|text/plain |image/png mime type|

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Jason Ekstrand
On Wed, Feb 17, 2016 at 7:04 AM, Jose Fonseca wrote: > On 17/02/16 10:24, Dave Airlie wrote: > >> On 17 February 2016 at 18:31, Ernst Sjöstrand wrote: >> >>> Hi! >>> >>> Sorry if this is a silly question but I was thinking that there would >>> be a Vulkan Gallium state tracker in development beh

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-17 Thread Derek Foreman
On 16/02/16 10:37 AM, Daniel Stone wrote: > Hi, > > On 16 February 2016 at 16:34, Derek Foreman wrote: >> +try_damage_buffer(struct dri2_egl_surface *dri2_surf, >> + const EGLint *rects, >> + EGLint n_rects) >> +{ >> +/* The WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 Bug ID: 94194 Summary: New Account Request Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 --- Comment #1 from Plamena Manolova --- Created attachment 121813 --> https://bugs.freedesktop.org/attachment.cgi?id=121813&action=edit Public SSH Key -- You are receiving this mail because: You are the assignee for the bug. You are the QA C

Re: [Mesa-dev] [PATCH] st/mesa: apply DepthMode swizzle to stencil texturing as well

2016-02-17 Thread Roland Scheidegger
Am 17.02.2016 um 14:43 schrieb Ilia Mirkin: > Gallium doesn't present these as GL_RED-style. A swizzle is necessary to > present the proper data in the unused components. > > Signed-off-by: Ilia Mirkin > --- > > The GL 4.5 compat spec also makes it clear that sampling from stencil is the > same

Re: [Mesa-dev] [PATCH] st/mesa: apply DepthMode swizzle to stencil texturing as well

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 11:13 AM, Roland Scheidegger wrote: > Am 17.02.2016 um 14:43 schrieb Ilia Mirkin: >> Gallium doesn't present these as GL_RED-style. A swizzle is necessary to >> present the proper data in the unused components. >> >> Signed-off-by: Ilia Mirkin >> --- >> >> The GL 4.5 compa

[Mesa-dev] [Bug 94195] [llvmpipe] Does not build with LLVM 3.7.x on Windows

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94195 Bug ID: 94195 Summary: [llvmpipe] Does not build with LLVM 3.7.x on Windows Product: Mesa Version: 11.1 Hardware: Other OS: All Status: NEW Severity: norm

Re: [Mesa-dev] [PATCH] st/mesa: apply DepthMode swizzle to stencil texturing as well

2016-02-17 Thread Roland Scheidegger
Am 17.02.2016 um 17:17 schrieb Ilia Mirkin: > On Wed, Feb 17, 2016 at 11:13 AM, Roland Scheidegger > wrote: >> Am 17.02.2016 um 14:43 schrieb Ilia Mirkin: >>> Gallium doesn't present these as GL_RED-style. A swizzle is necessary to >>> present the proper data in the unused components. >>> >>> Sig

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 --- Comment #2 from Brian Paul --- Hi Plamena, I don't recall ever seeing any patches from you on the Mesa-dev list. We generally don't give accounts for Mesa git until the individual has some history of contributing good patches to the mesa-dev

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 --- Comment #3 from Brian Paul --- OK, I just found your emails in my inbox. Looks like those are your first patches, AFAICT. You're on your way... -- You are receiving this mail because: You are the assignee for the bug. You are the QA Conta

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 --- Comment #4 from Plamena Manolova --- (In reply to Brian Paul from comment #3) > OK, I just found your emails in my inbox. Looks like those are your first > patches, AFAICT. You're on your way... Hi Brian, Yes those were my first patches to

[Mesa-dev] [Bug 94194] New Account Request

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94194 --- Comment #5 from Brian Paul --- How about we just leave the bug/request open for now. After you've got a dozen or so good patches under your belt, update this bug to ping us. -- You are receiving this mail because: You are the QA Contact fo

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-17 Thread Kristian Høgsberg
On Tue, Feb 16, 2016 at 11:36 PM, Jose Fonseca wrote: > On 16/02/16 22:19, Brian Paul wrote: >> >> On 02/16/2016 02:41 PM, Dave Airlie wrote: >>> >>> On 17 February 2016 at 04:39, Jason Ekstrand >>> wrote: So, we just pushed a branch containing a Vulkan driver. Naturally, we would

[Mesa-dev] [PATCH] meta/copy_image: use precomputed dst_internal_format to avoid segfault

2016-02-17 Thread Ilia Mirkin
If the destination is a renderbuffer, dst_tex_image will be NULL. This fixes the *to_renderbuffer dEQP copy image tests. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/common/meta_copy_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined but not used [-Wunused-const-variable] static const uint32_t _mesa_fnv32_1a_offset_bias = 2166136261u; ^~ I went w/ enum, rather than #define, mostly because a lowercase #de

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-17 Thread Jason Ekstrand
On Wed, Feb 17, 2016 at 9:28 AM, Kristian Høgsberg wrote: > On Tue, Feb 16, 2016 at 11:36 PM, Jose Fonseca > wrote: > > On 16/02/16 22:19, Brian Paul wrote: > >> > >> On 02/16/2016 02:41 PM, Dave Airlie wrote: > >>> > >>> On 17 February 2016 at 04:39, Jason Ekstrand > >>> wrote: > > S

[Mesa-dev] [PATCH] [v3] i965/skl: Add two missing device IDs

2016-02-17 Thread Ben Widawsky
The Iris part is left unbranded because we did not have these with original SKL. v2: 0x192d is gt3, not gt4 v3: Forgot to update the temporary brand string when I did v2. Cc: "11.0 11.1" Signed-off-by: Ben Widawsky --- include/pci_ids/i965_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) di

Re: [Mesa-dev] [PATCH] [v3] i965/skl: Add two missing device IDs

2016-02-17 Thread Winiarski, Michal
On Wed, 2016-02-17 at 10:06 -0800, Ben Widawsky wrote: > The Iris part is left unbranded because we did not have these with > original SKL. > > v2: 0x192d is gt3, not gt4 > > v3: Forgot to update the temporary brand string when I did v2. > > Cc: "11.0 11.1" Cc: Michał Winiarski Acked-by: Mich

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-17 Thread Jason Ekstrand
On Wed, Feb 17, 2016 at 8:00 AM, Derek Foreman wrote: > On 16/02/16 10:37 AM, Daniel Stone wrote: > > Hi, > > > > On 16 February 2016 at 16:34, Derek Foreman > wrote: > >> +try_damage_buffer(struct dri2_egl_surface *dri2_surf, > >> + const EGLint *rects, > >> +

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

2016-02-17 Thread Matt Turner
On Sat, Feb 13, 2016 at 4:47 PM, Matt Turner wrote: > On Sat, Feb 13, 2016 at 3:30 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez >>> wrote: Matt Turner writes: > On Thu, Feb 11, 2016 at 4:41 PM, Matt Turner wrote: >

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94193 --- Comment #2 from Roland Scheidegger --- So if I understand this right, there's really two issues here: 1) smooth lines don't quite work when line stippling is enabled 2) we don't optimize fake-enabled line stippling away As for 2), this is so

[Mesa-dev] [PATCH] i965: Allow fast-path for glReadPixels sub-rectangle case

2016-02-17 Thread Nanley Chery
From: Nanley Chery Since _mesa_image_row_stride() is used to calculate the destination's row stride, we can read pixels into a destination sub-rectangle (whose width is smaller than the destination buffer). Signed-off-by: Nanley Chery --- The fast-path is confirmed to work with the following p

Re: [Mesa-dev] MesaGL <-> non-Mesa OpenCL interop interface

2016-02-17 Thread Marek Olšák
On Sat, Feb 6, 2016 at 10:43 PM, Marek Olšák wrote: > On Sat, Feb 6, 2016 at 6:53 PM, Jason Ekstrand wrote: >> I'm adding Chad to the Cc. At some point, it would be good to get Beignet >> playing well with mesa. Personally, I have substantial reservations about >> getting the kernel involved in

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

2016-02-17 Thread Francisco Jerez
Matt Turner writes: > On Sat, Feb 13, 2016 at 4:47 PM, Matt Turner wrote: >> On Sat, Feb 13, 2016 at 3:30 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Feb 11, 2016

[Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

2016-02-17 Thread sroland
From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8 +--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH v2] mesa: allow multisampled format info to be returned on GLES 3.1

2016-02-17 Thread Ilia Mirkin
The restriction on multisampled integer texture formats only applies to GLES 3.0, so don't apply it to GLES 3.1 contexts. This fixes a slew of dEQP-GLES31.functional.state_query.internal_format.* tests, which now all pass. Signed-off-by: Ilia Mirkin Cc: Timothy Arceri Cc: Marta Lofstedt ---

Re: [Mesa-dev] [PATCH] mesa: allow multisampled format info to be returned on GLES 3.1

2016-02-17 Thread Ilia Mirkin
On Sun, Feb 14, 2016 at 1:28 PM, Ilia Mirkin wrote: > On Sun, Feb 14, 2016 at 5:36 AM, Timothy Arceri > wrote: >> On Sat, 2016-02-13 at 23:50 -0500, Ilia Mirkin wrote: >>> Marta, perhaps you can have a look? It's pretty similar to your >>> commit >>> b6d014f0b (mesa/es3.1: Pass sample count check

Re: [Mesa-dev] [PATCH] st/mesa: force depth mode to GL_RED for sized depth/stencil formats

2016-02-17 Thread Kenneth Graunke
On Wednesday, February 17, 2016 8:21:32 AM PST Ilia Mirkin wrote: > See commit 9db2098d for the i965 version of this. > > This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And > probably other ones as well. > > Signed-off-by: Ilia Mirkin > Cc: Ian Romanick > Cc: mesa-sta...@li

Re: [Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

2016-02-17 Thread Brian Paul
On 02/17/2016 12:42 PM, srol...@vmware.com wrote: From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8 +--- 2 files changed

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

2016-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94193 --- Comment #3 from Brian Paul --- (In reply to Roland Scheidegger from comment #2) > So if I understand this right, there's really two issues here: > 1) smooth lines don't quite work when line stippling is enabled > 2) we don't optimize fake-ena

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

2016-02-17 Thread Ian Romanick
On 02/16/2016 11:14 PM, Kenneth Graunke wrote: > On Tuesday, February 16, 2016 6:29:39 PM PST Ilia Mirkin wrote: >> See commit 9db2098d which did it internally to the i965 driver. No >> reason not to have this more globally set though. >> >> This fixes depth in a bunch of dEQP EXT_texture_border_cl

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2016-02-17 Thread Rowley, Timothy O
> On Nov 18, 2015, at 12:34 PM, Emil Velikov wrote: > I have no objections against getting this merged, although here are a > couple of things that should be sorted. Some of these are just > reiteration from others: Sorry about the delay responding to this; we’ve been working on a number of the

[Mesa-dev] [PATCH 2/2] nv50/ir: optimize sub(a, 0) to a

2016-02-17 Thread Karol Herbst
helps a 0ad shader in default shader-db: total instructions in shared programs : 102863 -> 102861 (-0.00%) total gprs used in shared programs: 14725 -> 14725 (0.00%) total local used in shared programs : 129 -> 129 (0.00%) total bytes used in shared programs : 943944 -> 943928 (-0.00%)

[Mesa-dev] [PATCH 0/2] more nouveau optimisations

2016-02-17 Thread Karol Herbst
Karol Herbst (2): nv50/ir: add PostRADCE Pass nv50/ir: optimize sub(a, 0) to a src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 77 ++ 2 files changed, 52 insertions(+), 27 deletions(-) -- 2.7.1 ___

[Mesa-dev] [PATCH 1/2] nv50/ir: add PostRADCE Pass

2016-02-17 Thread Karol Herbst
helps shaders in Saints Row IV, bioshock infinite and shadow warrior no change in default shader-db changes in my shader-db total instructions in shared programs : 1801054 -> 1794281 (-0.38%) total gprs used in shared programs: 233059 -> 233059 (0.00%) total local used in shared programs :

[Mesa-dev] [PATCH v3 00/14] nvc0: add compute shaders on Fermi

2016-02-17 Thread Samuel Pitoiset
Hi, This series adds support for ARB_compute_shader only on Fermi. Kepler compute support is really different and I need to fix a bunch of things to make it work correctly. Almost all piglit/dEQP tests pass. The list of fails is available below. Samuel Pitoiset (14): nvc0: allocate an area fo

[Mesa-dev] [PATCH v3 01/14] nvc0: allocate an area for compute user constbufs

2016-02-17 Thread Samuel Pitoiset
For compute shaders, we might need to upload uniforms. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +++--- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c|

[Mesa-dev] [PATCH v3 02/14] nvc0: bind constant buffers for compute on Fermi

2016-02-17 Thread Samuel Pitoiset
Loosely based on 3D. Changs from v3: - invalidate COMPUTE CBs after validating 3D CBs because they are aliased Changes from v2: - get rid of the 's' param to nvc0_cb_bo_push() because it doesn't matter to upload constbufs for compute using the 3d chan Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v3 06/14] nvc0: bind textures/samplers for compute on Fermi

2016-02-17 Thread Samuel Pitoiset
Textures and samplers don't seem to be aliased between COMPUTE and 3D. Changes from v2: - refactor the code to share (almost) the same logic between 3d and compute Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 38 +++-- src/gallium/

[Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
This OP_SELP insn will be used to handle compare and swap subops. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 8 src/gallium/drivers/nouveau/codegen/nv50_ir_inlines.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH v3 07/14] nvc0: add support for indirect compute on Fermi

2016-02-17 Thread Samuel Pitoiset
When indirect compute is used, the size of the grid (in blocks) is stored as three integers inside a buffer. This requires a macro to set up GRIDDIM_YX and GRIDDIM_Z. Changes from v2: - do not launch the grid if the number of groups for a dimension is 0 Signed-off-by: Samuel Pitoiset --- src/g

[Mesa-dev] [PATCH v3 08/14] nvc0: invalidate compute state when switching pipe contexts

2016-02-17 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c b/src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c index e2a4e42..d97267a 1

[Mesa-dev] [PATCH v3 03/14] nvc0: add a new validation state for 3D driver constbuf

2016-02-17 Thread Samuel Pitoiset
This will be used to invalidate 3D driver constbuf when using COMPUTE and vice-versa. This is needed because this CB contains a bunch of useful information like the addrs of shader buffers. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 1 + src/gall

[Mesa-dev] [PATCH v3 05/14] nvc0: bind shader buffers for compute on Fermi

2016-02-17 Thread Samuel Pitoiset
This is loosely based on 3D. Shader buffers are bound on c15 (the driver constbuf) at offset 0x200. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 34 + src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 11 +--- src/gallium/driver

[Mesa-dev] [PATCH v3 14/14] nvc0: enable compute shaders on Fermi

2016-02-17 Thread Samuel Pitoiset
Kepler compute support is really different than Fermi and it's not ready yet. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/dri

[Mesa-dev] [PATCH v3 09/14] nvc0: reduce likelihood of collision for real buffers on Fermi

2016-02-17 Thread Samuel Pitoiset
Reduce likelihood of collision with real buffers by placing the hole at the top of the 4G area. This fixes some indirect draw+compute tests with large buffers. Suggested by Ilia Mirkin. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 4 ++-- 1 file changed,

[Mesa-dev] [PATCH v3 11/14] nv50/ir: add lock/unlock subops for load/store

2016-02-17 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 ++ .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp| 16 ++-- src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp| 10 ++ 3 files changed, 26 insertions(+), 2 delet

[Mesa-dev] [PATCH v3 10/14] nv50/ir: use s[] addr space for shared buffers

2016-02-17 Thread Samuel Pitoiset
Shared memory address space (FILE_MEMORY_SHARED) must be used instead of global memory when a shared memory area is declared. Changes from v2: - oops, do not remove TGSI_FILE_BUFFER in a switch in nv50_ir_from_tgsi.cpp Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_f

[Mesa-dev] [PATCH v3 04/14] nvc0: bind driver constbuf for compute on Fermi

2016-02-17 Thread Samuel Pitoiset
Changes from v3: - add new validation state for COMPUTE driver constbuf Changes from v2: - always bind the driver consts even if user params come in via clover Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 18 ++ src/gallium/driver

[Mesa-dev] [PATCH v3 13/14] nv50/ir: add atomics support on shared memory for Fermi

2016-02-17 Thread Samuel Pitoiset
Changes from v2: - make sure the op is OP_SELP when emitting the predicate and add one assert - use bld.getSSA() for mkOp2() - add cross edge between tryLockAndSetBB and joinBB Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 + .../nouveau/codege

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used [-Wunused-function] >> lo

[Mesa-dev] [PATCH] glsl: fix standalone compiler

2016-02-17 Thread Rob Clark
From: Rob Clark Need to set some non-zero limits for MaxCombinedUniformComponents, otherwise we hit an "Too many shader uniform components" error in the linker. Signed-off-by: Rob Clark --- src/compiler/glsl/main.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/compil

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Ilia Mirkin
Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) On Wed, Feb 17, 2016 at 4:27 PM, Samuel Pitoiset wrote: > This OP_SELP insn will be used to handle compare and swap subops. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

2016-02-17 Thread Thomas Helland
17. feb. 2016 16.37 skrev "Jason Ekstrand" : > > On Tue, Feb 16, 2016 at 11:41 PM, Iago Toral wrote: >> >> Hey Jason, >> >> this is awesome news, congrats to all the people involved! > > > Thanks! > >> >> Did you have a chance to try the new driver with anything other than >> conformance tests or

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function] lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) ^~ The base class method th

Re: [Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

2016-02-17 Thread Jose Fonseca
On 17/02/16 19:42, srol...@vmware.com wrote: From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8 +--- 2 files changed, 11

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty sure that SELP won't be useful for shared+atomics on GK110+ because I don't use it GK104 IIRC. On Wed, Feb 17, 2016 at 4:27 PM, S

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: > > > On 02/17/2016 10:33 PM, Ilia Mirkin wrote: >> >> Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? >> Perhaps just not implemented yet...) > > > Pretty sure that SELP won't be useful for shared+atomics on GK110+ bec

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
On 02/17/2016 10:36 PM, Ilia Mirkin wrote: On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty sure that SELP won't be usefu

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Patrick Baggett
On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined > but not used [-Wunused-function] > lower_discard_flow_visitor::visit_enter(ir_loop_jump

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Dave Airlie
> This category of ideas is something that I have given a bit of thought. The > tentative conclusion I've come to is that it would be possible to implement > GL on Vulkan given a few extensions and a few carefully chosen assumptions > about the underlying Vulkan driver. For instance, we could add

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett wrote: > On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used [-Wunused-fun

[Mesa-dev] [PATCH] i965: Push most TES inputs in vec4 mode.

2016-02-17 Thread Kenneth Graunke
(This is commit 4a1c8a3037cd29938b2a6e2c680c341e9903cfbe for vec4 mode.) Using the push model for inputs is much more efficient than pulling inputs - the hardware can simply copy a large chunk into URB registers at thread creation time, rather than having the thread send messages to request data f

Re: [Mesa-dev] [PATCH 6/7] glx: remove incorrect refcounting of DRIdrawable

2016-02-17 Thread Miklós Máté
On 02/14/2016 02:46 AM, Ian Romanick wrote: On 02/11/2016 12:58 PM, Miklós Máté wrote: On 02/09/2016 05:02 PM, Ian Romanick wrote: On 02/08/2016 05:11 PM, Ian Romanick wrote: On 02/05/2016 01:11 PM, Miklós Máté wrote: dri drawables must never be released when unbound from a context as long as

[Mesa-dev] [PATCH] nv50/ir: emit VOTE instruction

2016-02-17 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 24 + .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 25 ++ .../drivers/nouveau/codegen/nv50_ir_emit_

[Mesa-dev] [PATCH] gallium/cso: only enable compute shaders when TGSI is supported

2016-02-17 Thread Samuel Pitoiset
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94186 Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/

Re: [Mesa-dev] [PATCH v2] mesa: allow multisampled format info to be returned on GLES 3.1

2016-02-17 Thread Timothy Arceri
On Wed, 2016-02-17 at 14:51 -0500, Ilia Mirkin wrote: > The restriction on multisampled integer texture formats only applies > to > GLES 3.0, so don't apply it to GLES 3.1 contexts. This fixes a slew > of > > dEQP-GLES31.functional.state_query.internal_format.* > > tests, which now all pass. > >

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-17 Thread Anuj Phogat
Timothy, I looked at the patch and feel that I'm not the right person to review it. I know very little about tessellation. Maybe Ken has some useful comments. On Fri, Feb 5, 2016 at 5:12 PM, Timothy Arceri wrote: > Hi Anuj/anyone who feels like reviewing, > > As this is the last remaining patch i

Re: [Mesa-dev] [PATCH] nv50/ir: emit VOTE instruction

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 6:16 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 24 + > .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 4:00 PM, Ian Romanick wrote: > I think we need to change DepthMode in GLES when the texture image is > set (by glTexImage or glTexStorage). I think doing the mode swizzle in > the driver means glGetTexParameteriv(GL_DEPTH_MODE) will return the > wrong thing. As you pointe

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2016-02-17 Thread Roland Scheidegger
Am 17.02.2016 um 22:09 schrieb Rowley, Timothy O: >> On Nov 18, 2015, at 12:34 PM, Emil Velikov >> wrote: I have no objections against >> getting this merged, although here are a couple of things that >> should be sorted. Some of these are just reiteration from others: > > Sorry about the delay r

[Mesa-dev] [PATCH] glcpp: Disallow "defined" as a macro name.

2016-02-17 Thread Kenneth Graunke
Both GCC and Clang disallow this, and glslang has recently started disallowing it as well. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94188 Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glcpp/glcpp-parse.y | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/gls

[Mesa-dev] gl_render_buffer->_BaseFormat

2016-02-17 Thread Ilia Mirkin
Hi Brian, In commit commit 45e76d2665b38ba3787548310efc59e969124c01 Author: Brian Paul Date: Thu Oct 8 20:27:27 2009 -0600 mesa: remove a bunch of gl_renderbuffer fields _ActualFormat is replaced by Format (MESA_FORMAT_x). ColorEncoding, ComponentType, RedBits, GreenBits, BlueBit

[Mesa-dev] [PATCH v2] mesa: add GL_OES_texture_stencil8 support

2016-02-17 Thread Ilia Mirkin
It's basically the same thing as GL_ARB_texture_stencil8 except that glCopyTexImage isn't supported, so add STENCIL_INDEX to the list of invalid GLES formats for glCopyTexImage. Signed-off-by: Ilia Mirkin --- v1 -> v2: add checking to es3_error_check_format_and_type. I only get 2 dEQP test fail

Re: [Mesa-dev] [PATCH] mesa: implement a display list / glBitmap texture atlas

2016-02-17 Thread Nicolai Hähnle
On 15.02.2016 11:52, Brian Paul wrote: This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and put them into a texture atlas. To render the bitmap

[Mesa-dev] [PATCH] mesa: check fbo completeness based on internal format, not driver format

2016-02-17 Thread Ilia Mirkin
The underlying format can be anything. Specifically in the stencil-only case, it might be a depth/stencil format. However we still want to refuse such an attachment when bound to GL_DEPTH, so we must check the base format that the texture was created with, rather than backed out from the driver-sup

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Ian Romanick
I ran this through our CI, and I didn't see any regressions cause by it. I think this is correct, so this patch is Reviewed-by: Ian Romanick On 02/17/2016 01:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_v

  1   2   >