Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Check the return value of pipe_loader_probe() when probing for devices

2015-11-29 Thread Francisco Jerez
Emil Velikov writes: > On 28 November 2015 at 17:06, Francisco Jerez wrote: > >> ... you're free to propose such a change as a >> separate series as long as you fix the documentation, all users and >> back-ends of pipe-loader, if you consider it worth doing -- I personally >> don't. >> > That wh

[Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Emil Velikov
Earlier commit factored out the mpeg4 IQ matrix handling into separate function, although it forgot to add a break in its case statement. Thus the data ended up partially overwritten as the mpeg4 and h265 structs are members of the desc union. Spotted by Coverity (CID 1341052) Fixes: 64761a841db

Re: [Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Christian König
On 29.11.2015 12:48, Emil Velikov wrote: Earlier commit factored out the mpeg4 IQ matrix handling into separate function, although it forgot to add a break in its case statement. Thus the data ended up partially overwritten as the mpeg4 and h265 structs are members of the desc union. Spotted by

Re: [Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Emil Velikov
On 29 November 2015 at 11:52, Christian König wrote: > On 29.11.2015 12:48, Emil Velikov wrote: >> >> Earlier commit factored out the mpeg4 IQ matrix handling into separate >> function, although it forgot to add a break in its case statement. >> Thus the data ended up partially overwritten as the

[Mesa-dev] [PATCH v2] gallium/tests: fix build with clang compiler

2015-11-29 Thread Samuel Pitoiset
Nested functions are supported as an extension in GNU C, but Clang don't support them. This fixes compilation errors when (manually) building compute.c, or by setting --enable-gallium-tests to the configure script. Changes from v2: - fix typo Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?

[Mesa-dev] [PATCH] nv50/ir: do not call textureMask() for non-texture ops

2015-11-29 Thread Samuel Pitoiset
This fixes a segmentation fault with the 'test_surface_st' test from src/gallium/tests/trivial/compute.c on Fermi. While we are it, apply the same change for Tesla. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 6 -- 1 file changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH] nv50/ir: do not call textureMask() for non-texture ops

2015-11-29 Thread Ilia Mirkin
Under what circumstances can you get into this code and not be a texture op? On Sun, Nov 29, 2015 at 9:57 AM, Samuel Pitoiset wrote: > This fixes a segmentation fault with the 'test_surface_st' test from > src/gallium/tests/trivial/compute.c on Fermi. > > While we are it, apply the same change fo

Re: [Mesa-dev] [PATCH 3/3] xvmc: force assertion in XvMC tests

2015-11-29 Thread Emil Velikov
Hi Giuseppe, On 28 November 2015 at 15:43, Giuseppe Bilotta wrote: > This follows the src/util/u_atomic_test model of undefining NDEBUG > unconditionally throughouth the XvMC tests, to force asserts regardless > of debug mode. > > Signed-off-by: Giuseppe Bilotta > --- > src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

2015-11-29 Thread Emil Velikov
Hi Giuseppe, On 28 November 2015 at 15:43, Giuseppe Bilotta wrote: > The second and third patches are mostly aimed at removing non-spurious > compiler warnings. The first one is just minor whitespace cleanup in the > general area of code touched by the second patch. > > Giuseppe Bilotta (3): >

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-11-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #8 from Emil Velikov --- (In reply to nerdopolis1 from comment #7) > It seems that mesa master's software rendering also causes some problems > with SDL v2, and the testgl2 application that is in their repository for > Wayland > > Re

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-11-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #9 from Emil Velikov --- For future reference the qtwayland bug is https://bugreports.qt.io/browse/QTBUG-48166 -- You are receiving this mail because: You are the QA Contact for the bug. _

Re: [Mesa-dev] [PATCH] clover: Check the return value of pipe_loader_probe() when probing for devices

2015-11-29 Thread Samuel Pitoiset
This patch fixes the issue for me (eg. https://bugs.freedesktop.org/show_bug.cgi?id=93091#c8). Thanks Tom. Tested-by: Samuel Pitoiset On 11/28/2015 03:52 AM, Tom Stellard wrote: When probing for devices, clover will call pipe_loader_probe() twice. The first time to retrieve the number of dev

[Mesa-dev] [PATCH v2] targets/dri: android: use WHOLE static libraries

2015-11-29 Thread Emil Velikov
By using whole static libraries the android buildsystem provides whole-archive (alike) solution. This means that we don't need to worry about the order of the static libraries and any reverse, recursive or circular dependencies that they have between one another. Without this the linker will disca

[Mesa-dev] [PATCH v2] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

2015-11-29 Thread Emil Velikov
Otherwise the user has no way of using it, and we'll try to access the linear one. v2: - Bail out when KHR_gl_colorspace is missing and srgb is set (Marek) Cc: Mauro Rossi Cc: Chih-Wei Huang Cc: "11.0 11.1" Fixes: c2c2e9ab604(egl: implement EGL_KHR_gl_colorspace (v2)) Bugzilla: https://bugs.f

Re: [Mesa-dev] [PATCH 2/2] vl/buffers: fixes vl_video_buffer_formats for RGBX

2015-11-29 Thread Emil Velikov
On 27 November 2015 at 08:57, Julien Isorce wrote: > Signed-off-by: Julien Isorce > --- > src/gallium/auxiliary/vl/vl_video_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/vl/vl_video_buffer.c > b/src/gallium/auxiliary/vl/vl_video_buffer.c

Re: [Mesa-dev] [PATCH v2] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

2015-11-29 Thread Mauro Rossi
Hi Emil, I confirm I tested on lollipop-x86 with i965 on Intel HD4000, X3100 and nouveau with GT210, and I saw no regressions on android-x86. Mauro 2015-11-29 17:48 GMT+01:00 Emil Velikov : > Otherwise the user has no way of using it, and we'll try to access the > linear one. > > v2: > - Bail

[Mesa-dev] [PATCH 3/3v2] xvmc: force assertion in XvMC tests

2015-11-29 Thread Giuseppe Bilotta
This follows the src/util/u_atomic_test.c model of undefining NDEBUG unconditionally throughouth the XvMC tests, to force asserts regardless of debug mode. The comment on u_atomic_test.c is also fixed (read 'debug' where it should have been 'release'). v2: s/debug/release/ in relevant comments S

Re: [Mesa-dev] [PATCH 1/2] st/va: ensure linear memory for dmabuf

2015-11-29 Thread Emil Velikov
On 27 November 2015 at 08:57, Julien Isorce wrote: > In order to do zero-copy between two different devices > the memory should not be tiled. > > This is currently no way to set pipe_resource template's flag > from pipe_video_buffer template. So disabled_tiling is added. > > Choosed "disable" pref

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

2015-11-29 Thread Giuseppe Bilotta
Hello Emil, On Sun, Nov 29, 2015 at 4:21 PM, Emil Velikov wrote: > With the small comment in patch 3 addressed the series is > Reviewed-by: Emil Velikov Thanks. I was pretty sure the comment was wrong when I copied it over from the other file, but I thought I might have been missing something o

[Mesa-dev] [Bug 93103] llvm symbols leak through, cause trouble with software rendering in llvm-linked software

2015-11-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93103 --- Comment #15 from Emil Velikov --- The commit mentioned addresses only their autoconf (more like gnumake really) build. Current upstream covers both builds with should be identical auto-generated (?) LD version scripts. Small aside (C symbols

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-11-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #10 from nerdopol...@verizon.net --- unfortunately, if I knew how to write a test case... -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH 1/2] st/va: ensure linear memory for dmabuf

2015-11-29 Thread Christian König
On 29.11.2015 18:26, Emil Velikov wrote: On 27 November 2015 at 08:57, Julien Isorce wrote: In order to do zero-copy between two different devices the memory should not be tiled. This is currently no way to set pipe_resource template's flag from pipe_video_buffer template. So disabled_tiling i

Re: [Mesa-dev] [PATCH 15/23] meta: Use internal functions for buffer object and VAO access

2015-11-29 Thread Matt Turner
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 76 > -- > 1 file changed, 43 insertions(+), 33 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c

Re: [Mesa-dev] [PATCH] docs: add freedreno to GL3.txt

2015-11-29 Thread Ian Romanick
On 11/24/2015 12:37 PM, Ilia Mirkin wrote: > The Adreno A4xx GPU should be capable of a large fraction if not > all of the desktop GL 4.5 features. > > Signed-off-by: Ilia Mirkin > --- > docs/GL3.txt | 70 > ++-- > 1 file changed, 35 inser

Re: [Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

2015-11-29 Thread Emil Velikov
On 23 November 2015 at 16:17, Neil Roberts wrote: > I've pushed this patch to master but I think it would be a good > candidate to go on the 11.1 branch as well. Do I have to do something to > make that happen? > You've done enough (adding mesa-stable in the to/cc list). I've pulled the patch for

Re: [Mesa-dev] [PATCH v2] mesa: remove ARB_geometry_shader4

2015-11-29 Thread Ian Romanick
On 11/25/2015 03:16 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > No drivers currently implement ARB_geometry_shader4, nor are there > any plans to implement it. We only support the version of geometry > shaders that was incorporated into OpenGL 3.2 / GLSL 1.50. > > Signed-off-by: Marta

Re: [Mesa-dev] [PATCH v2] mesa: remove ARB_geometry_shader4

2015-11-29 Thread Kenneth Graunke
On Sunday, November 29, 2015 02:17:06 PM Ian Romanick wrote: > On 11/25/2015 03:16 AM, Marta Lofstedt wrote: > > From: Marta Lofstedt > > > > No drivers currently implement ARB_geometry_shader4, nor are there > > any plans to implement it. We only support the version of geometry > > shaders that

[Mesa-dev] [PATCH] r600: split out common alu_writes pattern.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just splits out a common pattern into an inline function to make things cleaner to read. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r

[Mesa-dev] [PATCH] r600: move per-type settings into a switch statement

2015-11-29 Thread Dave Airlie
From: Dave Airlie This will allow adding tess stuff much cleaner later. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600

Re: [Mesa-dev] [PATCH] r600: split out common alu_writes pattern.

2015-11-29 Thread Glenn Kennard
On Mon, 30 Nov 2015 01:18:18 +0100, Dave Airlie wrote: From: Dave Airlie This just splits out a common pattern into an inline function to make things cleaner to read. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c | 19 --- 1 file changed, 12 insertions(

Re: [Mesa-dev] [PATCH] r600: move per-type settings into a switch statement

2015-11-29 Thread Glenn Kennard
On Mon, 30 Nov 2015 01:38:03 +0100, Dave Airlie wrote: From: Dave Airlie This will allow adding tess stuff much cleaner later. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gal

Re: [Mesa-dev] [PATCH v2 21/42] glsl: Add default matrix ordering in lower_buffer_access

2015-11-29 Thread Jordan Justen
On 2015-11-26 01:10:03, Iago Toral wrote: > On Wed, 2015-11-25 at 11:59 -0800, Jordan Justen wrote: > > On 2015-11-25 01:32:37, Iago Toral wrote: > > > > > > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > > > > For compute shader shared variable we will set a default of column > > > > m

Re: [Mesa-dev] [PATCH v2 22/42] glsl: Don't lower_variable_index_to_cond_assign for shared variables

2015-11-29 Thread Jordan Justen
On 2015-11-25 00:12:15, Iago Toral wrote: > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/glsl/lower_variable_index_to_cond_assign.cpp | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/glsl/lower_variable_index_to_con

[Mesa-dev] [RFC] r600g: evergreen/cayman tessellation support

2015-11-29 Thread Dave Airlie
Hi, Patchbomb time, this set of patches is a first pass at add adding ARB_tessellation_shader support to the r600g driver. Only Evergreen and newer GPUs support tessellation. On any of the GPUs that support native FP64, this will enable OpenGL 4.1 on them. The first bunch of patches are a bit of

[Mesa-dev] [PATCH 06/53] r600: move selecting shaders into earlier code.

2015-11-29 Thread Dave Airlie
From: Dave Airlie select the ps/gs/vs in that order then process the results. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/dri

[Mesa-dev] [PATCH 01/53] r600/shader: split address get out to a function.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This will be used in the tess shaders. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index d25fc3

[Mesa-dev] [PATCH 11/53] r600/sb: add support for GDS to the sb decoder/dump.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just adds support to the decoder, not actual SB support. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/sb/sb_bc.h | 6 ++-- src/gallium/drivers/r600/sb/sb_bc_decoder.cpp | 43 ++- src/gallium/drivers/r600/sb/sb_bc_dump.cpp

[Mesa-dev] [PATCH 02/53] r600: introduce HW shader stage defines

2015-11-29 Thread Dave Airlie
From: Dave Airlie Add a list of defines for the HW stages. We will use this for GPR calculations amongst other things. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/r600/r600_pipe.h b/s

[Mesa-dev] [PATCH 09/53] r600: use macros for updating the various stages.

2015-11-29 Thread Dave Airlie
From: Dave Airlie These macros will make things easier to see when tess is added to the mix. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/r600/r

[Mesa-dev] [PATCH 03/53] r600: make adjust_gprs use hw stages.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This changes the r600 specific GPR adjustment code to use the stage defines, and arrays. This is prep work for the tess changes later. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 117 +

[Mesa-dev] [PATCH 12/53] r600: add support for LDS instruction encoding.

2015-11-29 Thread Dave Airlie
From: Dave Airlie These are used in tessellation shaders to read/write values between VS/TCS/TES. This splits the eg alu assembler out to handle these instructions. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 75 + src/gallium/drive

[Mesa-dev] [PATCH 10/53] r600: add support for GDS clause to the assembler.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just adds enough for the tessellation shaders, which require TF_WRITE to work. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 23 +++ src/gallium/drivers/r600/eg_sq.h| 21 ++ src/gallium/drivers/r600/r600_asm.c | 82 +

[Mesa-dev] [PATCH 08/53] r600: add SET_NULL_SHADER macro.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This is used to set a hw shader to NULL. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_stat

[Mesa-dev] [PATCH 07/53] r600: move clip misc and streamout stream updates to a single place

2015-11-29 Thread Dave Airlie
From: Dave Airlie This will be updated in a macro later. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r

[Mesa-dev] [PATCH 19/53] r600/blit: add tcs/tes shader saves.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_blit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index 8a90489..8aa3c97 100644 --- a/src/gallium/drivers/r600/r600_blit.c +++ b

[Mesa-dev] [PATCH 22/53] r600: hook up constants/samplers/sampler view for tessellation

2015-11-29 Thread Dave Airlie
From: Dave Airlie This hooks the resources to the correct hw shaders when tess is enabled. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 90 +++--- src/gallium/drivers/r600/r600_pipe.h | 2 +- 2 files changed, 82 insertions(+), 10 de

[Mesa-dev] [PATCH 15/53] r600: add PATCHES to the pipe conversion.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just converts the value to the hw value. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index bc9

[Mesa-dev] [PATCH 25/53] r600: fix masks for two of the unused evergreen regs.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/evergreend.h b/src/gallium/drivers/r600/evergreend.h index 3f60e3e..ebe8c4a 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH 27/53] r600: workout bitmask for the used tcs inputs/outputs.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This is used later to setup the constants to be given to the tessellation shaders. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h | 3 +++ src/gallium/drivers/r600/r600_state_common.c | 25 + 2 files changed, 28 insertions

[Mesa-dev] [PATCH 13/53] r600g/sb: Support LDS ops in SB bytecode I/O

2015-11-29 Thread Dave Airlie
From: Glenn Kennard This just adds the LDS ops to the SB bytecode reader/writers. Signed-off-by: Glenn Kennard Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/sb/sb_bc.h | 2 + src/gallium/drivers/r600/sb/sb_bc_builder.cpp | 31 +++ src/gallium/drivers/r600/sb/s

[Mesa-dev] [PATCH 05/53] r600: use a macro to remove common shader selection code.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This function is going to get a lot messier with tessellation so I'm going to use some macros to try and clean some bits of common code up. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 21 + 1 file changed, 9 insertions(+),

[Mesa-dev] [PATCH 24/53] r600: add set_tess_state callback.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just stores the values in the context to be used later when emitting the constant buffers. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 12 +++- src/gallium/drivers/r600/r600_pipe.h | 1 + 2 files changed, 12 insertions(+), 1

[Mesa-dev] [PATCH 23/53] r600/eg: init tess registers to defaults

2015-11-29 Thread Dave Airlie
From: Dave Airlie This initialises the tess min/max using fglrx values, and also initialises a number of other registers related to tessellation. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 34 +- 1 file changed, 24 insertions(+), 10

[Mesa-dev] [PATCH 26/53] r600: port over the get_lds_unique_index from radeonsi

2015-11-29 Thread Dave Airlie
From: Dave Airlie On r600 this needs to subtract 9 due to texcoord interactions. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 38 ++ src/gallium/drivers/r600/r600_shader.h | 1 + 2 files changed, 39 insertions(+) diff --git a/src/gal

[Mesa-dev] [PATCH 04/53] r600: move to using hw stages array for hw stage atoms

2015-11-29 Thread Dave Airlie
From: Dave Airlie This moves to using an array of hw stages for the atoms. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 8 +++- src/gallium/drivers/r600/r600_hw_context.c | 8 src/gallium/drivers/r600/r600_pipe.h | 7 ++- src/galli

[Mesa-dev] [PATCH 42/53] r600/shader: handle TES exports and streamout

2015-11-29 Thread Dave Airlie
From: Dave Airlie when tessellation is enabled the TES shader is responsible for handling streamout and exports. This adds the streamout and export workarounds to TES, and also makes sure TES sets up spi_sid. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 23 +

[Mesa-dev] [PATCH 17/53] r600: update correct hw shaders depending on configuration.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This updates the tess hw shaders from the sw ones routing things correctly. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/ga

[Mesa-dev] [PATCH 16/53] r600: add shader key entries for tcs and tes.

2015-11-29 Thread Dave Airlie
From: Dave Airlie with tessellation vs can now run on ls, and tes can run on vs or es, tcs runs on hs. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_hw_context.c | 4 src/gallium/drivers/r600/r600_pipe.h | 4 src/gallium/drivers/r600/r600_shader.c | 1

[Mesa-dev] [PATCH 34/53] r600/eg: workaround bug with tess shader and dynamic GPRs.

2015-11-29 Thread Dave Airlie
From: Dave Airlie When using tessellation on eg/ni chipsets, we must disable dynamic GPRs to workaround a hw bug where the GPU hangs when too many things get queued. This implements something like the r600 code to emit the transition between static and dynamic GPRs, and to statically allocate GP

[Mesa-dev] [PATCH 28/53] r600: hook TES/TCS shaders to the selection logic.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This hooks the TES/TCS bindings to the HW stages up. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 34 ++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/s

[Mesa-dev] [PATCH 36/53] r600/shader: add function to get tess constants info

2015-11-29 Thread Dave Airlie
From: Dave Airlie This function retrieves the tess input/output info from the tess constant buffer that is bound to the shader. This uses a vfetch to get the values into the shader. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 91 +-

[Mesa-dev] [PATCH 41/53] r600/shader: emit tessellation factors to GDS at end of TCS.

2015-11-29 Thread Dave Airlie
From: Dave Airlie When we are finished the shader, we read back all the tess factors from LDS and write them to special global memory storage using GDS instructions. This also handles adding NOP when GDS or ENDLOOP end the TCS. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shad

[Mesa-dev] [PATCH 39/53] r600/shader: handle VS shader writing to the LDS outputs.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This writes the VS shaders outputs to the LDS memory in the correct places. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 76 +- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r6

[Mesa-dev] [PATCH 38/53] r600/shader: handle fetching tcs/tes inputs and tcs outputs

2015-11-29 Thread Dave Airlie
From: Dave Airlie This handles the logic for doing fetches from LDS for TCS and TES. For TCS we need to fetch both inputs and outputs, for TES only inputs need to be fetched. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 298 - 1 file c

[Mesa-dev] [PATCH 20/53] r600/sb: add LS/HS hw shader types.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just adds printing for the hw shader types, and hooks it up. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/sb/sb_bc.h | 2 ++ src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 6 -- src/gallium/drivers/r600/sb/sb_shader.cpp| 4 +++- 3 files change

[Mesa-dev] [PATCH 37/53] r600/shader: add get_lds_offset0 helper

2015-11-29 Thread Dave Airlie
From: Dave Airlie This retrievs the offset into the LDS for a patch or non-patch variable, it takes the RelPatch channel and a temporary register. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 28 1 file changed, 28 insertions(+) diff --g

[Mesa-dev] [PATCH 43/53] r600/shader: allow multi-dimension arrays for tcs/tes inputs/outputs.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just allows multi-dim arrays to be processed. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_s

[Mesa-dev] [PATCH 40/53] r600/shader: handle TCS output writing.

2015-11-29 Thread Dave Airlie
From: Dave Airlie TCS outputs whenever they are written in the shader, need to be written to LDS not temporaries, this handles this case. It also fixes up the case where the output is a relative addressed output, so we don't try to apply the relative address at the wrong time. Signed-off-by: Dav

[Mesa-dev] [PATCH 21/53] r600: add create/bind/delete shader hooks for tessellation

2015-11-29 Thread Dave Airlie
From: Dave Airlie This hooks up the gallium API for the tessellation shaders. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 59 1 file changed, 59 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/galliu

[Mesa-dev] [PATCH 33/53] r600/shader: move get_temp and last_instruction helpers up

2015-11-29 Thread Dave Airlie
From: Dave Airlie These are required for tess to be used earlier. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 36 -- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium

[Mesa-dev] [PATCH 14/53] r600: add functions to update ls/hs state.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just adds the two functions, these will get hooked up later in the shader code. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 25 + src/gallium/drivers/r600/r600_pipe.h | 2 ++ 2 files changed, 27 insertions(+)

[Mesa-dev] [PATCH 32/53] r600: bind geometry shader ring to the correct place

2015-11-29 Thread Dave Airlie
From: Dave Airlie When tess/gs are enabled, the geom shader ring needs to bind to the tess eval not the vertex shader. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 35/53] r600/shader: add a utility function to do single slot arithmatic

2015-11-29 Thread Dave Airlie
From: Dave Airlie This utility is to be used to do things like integer adds and multiplies to be used in calculating the LDS offsets etc. It handles CAYMAN MULLO differences as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 56 ++

[Mesa-dev] [PATCH 30/53] r600: create LDS info constants buffer and write LDS registers.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This creates a constant buffer with the information about the layout of the LDS memory that is given to the vertex, tess control and tess evaluation shaders. This also programs the LDS size and the LS_HS_CONFIG registers, on evergreen only. Signed-off-by: Dave Airlie --- src

[Mesa-dev] [PATCH 31/53] r600: create fixed function tess control shader fallback.

2015-11-29 Thread Dave Airlie
From: Dave Airlie If we have no tess control shader, then we have to use a fallback one that just writes the tessellation factors. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.c | 3 ++ src/gallium/drivers/r600/r600_pipe.h | 2 ++ src/gallium/drivers/r600

[Mesa-dev] [PATCH 46/53] r600/shader: increase number of inputs/outputs to 64.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Tessellation exceeds these sometimes, so increase them for now. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.h b/src/gallium/drivers/r600/r60

[Mesa-dev] [PATCH 29/53] r600/eg: update shader stage emission/tf param for tess.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This update the setting of the shader stages register when tess is enabled and add the setting of the VGT_TF_PARAM register from the tess shader properties. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 74 -- 1 file c

[Mesa-dev] [PATCH 18/53] r600: disable SB for now on tess related shaders.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Note we have to disable on vertex shaders when we are operating in tes mode. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r60

[Mesa-dev] [PATCH 45/53] r600: handle barrier opcode.

2015-11-29 Thread Dave Airlie
From: Edward O'Callaghan This handles the barrier opcode for EG/CM. Signed-off-by: Edward O'Callaghan Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_s

[Mesa-dev] [PATCH 44/53] r600/shader: handle tess related system-values.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This adds handling for TESSINNER/TESSOUTER in the TES where they need to be fetched from LDS, and TESSCOORD which comes in via r0. It also handle primitive ID and invocation ID. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 150 +

[Mesa-dev] [PATCH 47/53] r600: handle SIMD allocation issue with HS/LS

2015-11-29 Thread Dave Airlie
From: Dave Airlie At least one SIMD must be kept away from the HS/LS stages in order to avoid a hw issue on evergreen/cayman. This patch implements this workaround. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH 52/53] r600/asm: enable nstack check for tess ctrl/eval shaders.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This just makes sure they register at least one stack usage frame like vertex shaders. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/dri

[Mesa-dev] [PATCH 49/53] r600: move VGT_VTX_CNT_EN into shader stages atom.

2015-11-29 Thread Dave Airlie
From: Dave Airlie This should be enabled for tessellation shaders as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/ev

[Mesa-dev] [PATCH 48/53] r600: enable tcs/tes dumping for R600_DUMP_SHADERS.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Trivial patch just to enable dumping more. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 64f5fc6..78af4

[Mesa-dev] [PATCH 53/53] r600: enable tessellation for evergreen/cayman

2015-11-29 Thread Dave Airlie
From: Dave Airlie This enables tessellation for evergreen/cayman, This will need changes before committing depending on what hw works etc. Currently known broken are SUMO/CAICOS working are CAYMAN/REDWOOD/BARTS/TURKS. --- src/gallium/drivers/r600/r600_pipe.c | 5 - 1 file changed, 4 inserti

[Mesa-dev] [PATCH 51/53] r600/asm: handle lds read operations.

2015-11-29 Thread Dave Airlie
From: Dave Airlie Reads from the queue shouldn't be merged for now read operations. Reads from the queue shouldn't be merged for now, or put in T slots. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion

[Mesa-dev] [PATCH 50/53] r600/asm: add LDS ops and barrier to the once per group restriction.

2015-11-29 Thread Dave Airlie
From: Dave Airlie LDS ops must be scheduled in X slot, and barrier should be on its own in a group. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/

Re: [Mesa-dev] [PATCH] glsl/dead_builin_varyings: Fix gl_FragData array lowering

2015-11-29 Thread Tapani Pälli
Hi; On 11/27/2015 02:14 PM, Iago Toral Quiroga wrote: The current implementation looks for array dereferences on gl_FragData and immediately then proceeds to lower them, however this is not enough because we can have array access on vector variables too, like in this code: out vec4 color; void