[Mesa-dev] SSO fixes V2

2015-11-21 Thread Timothy Arceri
V2: I've dropped most of my fix from V1 and instead included the fixes from Gregory which I have cleaned up slightly. I've also added a patch to remove inactive varyings with an explicit location. The removal of inactive varyings with an explicit location results in no changes in the public shader

[Mesa-dev] [PATCH 5/7] glsl: add always_active_io attribute to ir_variable

2015-11-21 Thread Timothy Arceri
From: Gregory Hainaut The value will be set in separate-shader program when an input/output must remains active. e.g. when deadcode removal isn't allowed because it will create interface location/name-matching mismatch. v3: * Rename the attribute * Use ir_variable directly instead of ir_variable

[Mesa-dev] [PATCH 4/7] glsl: copy how_declared when lowering interface blocks

2015-11-21 Thread Timothy Arceri
From: Timothy Arceri Cc: Gregory Hainaut --- src/glsl/lower_named_interface_blocks.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/lower_named_interface_blocks.cpp b/src/glsl/lower_named_interface_blocks.cpp index 114bb58..f29eba4 100644 --- a/src/glsl/lower_named_interface_bl

[Mesa-dev] [PATCH 2/7] glsl: only call dead code pass when new inputs/outputs demoted

2015-11-21 Thread Timothy Arceri
From: Timothy Arceri This will help avoid eliminating inputs/outputs needed by SSOs. Cc: Gregory Hainaut --- src/glsl/linker.cpp | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index eac2536..5ff433c 10064

[Mesa-dev] [PATCH 7/7] glsl: don't sort varying in separate shader mode

2015-11-21 Thread Timothy Arceri
From: Gregory Hainaut This fixes an issue where the addition of the FLAT qualifier in varying_matches::record() can break the expected varying order. It also avoids a future issue with the relaxing of interpolation qualifier matching constraints in GLSL 4.50. V2: (by Timothy Arceri) * reworked

[Mesa-dev] [PATCH 6/7] glsl: don't dead code remove SSO varyings marked as active

2015-11-21 Thread Timothy Arceri
From: Gregory Hainaut GL_ARB_separate_shader_objects allow matching by name variable or block interface. Input varyings can't be removed because it is will impact the location assignment. This fixes the bug 79783 and likely any application that uses GL_ARB_separate_shader_objects extension. V2

[Mesa-dev] [PATCH 3/7] glsl: optimise inputs/outputs with explicit locations

2015-11-21 Thread Timothy Arceri
From: Timothy Arceri This change allows used defined inputs/outputs with explicit locations to be removed if they are detected to not be used between shaders at link time. To enable this we change the is_unmatched_generic_inout field to be flagged when we have a user defined varying. Previously

[Mesa-dev] [PATCH 1/7] glsl: move and reused code to find first and last shaders

2015-11-21 Thread Timothy Arceri
From: Timothy Arceri --- src/glsl/linker.cpp | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 331d9a2..eac2536 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -4139,11 +4139,18 @@ li

[Mesa-dev] Mesa 11.0.6

2015-11-21 Thread Emil Velikov
Mesa 11.0.6 is now available. This release brings driver fixes for i965, r600, radeonsi, nouveau, vc4, and llvmpipe including a serious regression for r100/r200 era hardware. Additional patches cover glsl, nir, mesa/meta and VC-1 decoding :-) Alex Deucher (1): radeonsi: enable optimal ras

[Mesa-dev] Mesa 11.1.0 release candidate 1

2015-11-21 Thread Emil Velikov
The first release candidate for Mesa 11.1.0 is now available. The plan is to have one release candidate every Friday, until the final release on December 11th 2015. As a reminder, with the 11.1 branch now created, patches nominated with: CC: will now be candidates only for the new 11.1

Re: [Mesa-dev] [PATCH 3/7] glsl: optimise inputs/outputs with explicit locations

2015-11-21 Thread gregory hainaut
Hello Timoty, The patch introduces a regression on deqp test. (I'm nearly sure there are hidden piglit tests that trigger the same error) DEQP test: deqp-gles31 --deqp-case=dEQP-GLES31.functional.separate_shader.interface.same_location Be awware that you need to patch Mesa (temporary hack) to

Re: [Mesa-dev] [PATCH v2 29/40] {st, targets}/dri: use static/dynamic pipe-loader

2015-11-21 Thread Jon Turney
On 20/11/2015 20:11, Emil Velikov wrote: Covert DRI to use only the pipe-loader interface. With drisw_create_screen and kms_swrast_create_screen replaced by their pipe-loader equivalent, we can now drop them. [...] --- a/src/gallium/targets/dri/Makefile.am +++ b/src/gallium/targets/dri/Makefi

[Mesa-dev] [PATCH] pipe-loader: link against libloader regardless of libdrm presence

2015-11-21 Thread Emil Velikov
Whether or not the loader has libdrm support is up-to it. Anyone using the loader should just include it whenever they depend on it. Reported-by: Jon TURNEY Tested-by: Jon TURNEY Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/Makefile.am | 4 ++-- 1 file changed, 2 insertion

[Mesa-dev] [PATCH 2/3] gallium: add ASTC formats

2015-11-21 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_format.csv | 30 src/gallium/auxiliary/util/u_format.h| 7 ++- src/gallium/auxiliary/util/u_format_pack.py | 2 +- src/gallium/auxiliary/util/u_format_table.py | 2 +- src/gallium/include

[Mesa-dev] [PATCH 1/3] gallium/util: remove the fake format helpers for bptc and etc2

2015-11-21 Thread Ilia Mirkin
This was a silly hack that kept growing and growing. Instead, just write NULLs for those functions. No need to have helpers that just assert(0) when you call them. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_format_fake.c | 3

[Mesa-dev] [PATCH 3/3] st/mesa: add astc support

2015-11-21 Thread Ilia Mirkin
This doesn't account for the ldr/hdr distinction... that will probably have to be exposed via a separate cap. When relevant hardware appears, this can be worked out. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 32 - src/mesa/state_tracker/st_format.c | 231 ++

[Mesa-dev] [PATCH v2] gallium: add ASTC formats

2015-11-21 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: add linear <-> srgb conversions to util_format_linear/srgb src/gallium/auxiliary/util/u_format.csv | 30 + src/gallium/auxiliary/util/u_format.h| 64 +++- src/gallium/auxiliary/util/u_format_pack.py | 2

Re: [Mesa-dev] [PATCH 4/9] i965/fs: respect force_sechalf/force_writemask_all in CSE

2015-11-21 Thread Kenneth Graunke
On Thursday, November 19, 2015 03:29:18 AM Matt Turner wrote: > On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga wrote: > > From: Connor Abbott > > > > Reviewed-by: Iago Toral Quiroga > > --- > > In fact, I think Ken ran into this very bug last week. > > Reviewed-by: Matt Turner >

[Mesa-dev] [PATCH] freedreno/a4xx: add astc formats

2015-11-21 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This passes the miptree_gl test with some caveats: (a) hdr error color doesn't get returned by the sampler, we just get black. (b) there appear to be some tolerance issues with the higher mip levels, making the test have a higher tolerance makes everything

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-21 Thread Kenneth Graunke
On Thursday, November 19, 2015 11:13:15 PM Neil Roberts wrote: > Ian Romanick writes: > > > Am I correct that nothing special is needed in the vec4 backend? It > > seems like mcs should know the register size, and the CMP with 0 > > should just do the right thing. > > I think you probably will h

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add astc support

2015-11-21 Thread Roland Scheidegger
Am 21.11.2015 um 21:03 schrieb Ilia Mirkin: > This doesn't account for the ldr/hdr distinction... that will probably > have to be exposed via a separate cap. When relevant hardware appears, > this can be worked out. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_extensions.c |

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add astc support

2015-11-21 Thread Ilia Mirkin
On Sat, Nov 21, 2015 at 4:09 PM, Roland Scheidegger wrote: > Am 21.11.2015 um 21:03 schrieb Ilia Mirkin: >> This doesn't account for the ldr/hdr distinction... that will probably >> have to be exposed via a separate cap. When relevant hardware appears, >> this can be worked out. >> >> Signed-off-b

Re: [Mesa-dev] [PATCH] pipe-loader: link against libloader regardless of libdrm presence

2015-11-21 Thread Emil Velikov
On 21 November 2015 at 19:43, Emil Velikov wrote: > Whether or not the loader has libdrm support is up-to it. Anyone using > the loader should just include it whenever they depend on it. > > Reported-by: Jon TURNEY > Tested-by: Jon TURNEY > Signed-off-by: Emil Velikov I knew I forgot something

Re: [Mesa-dev] [PATCH 1/3] gallium/util: remove the fake format helpers for bptc and etc2

2015-11-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Nov 21, 2015 at 9:03 PM, Ilia Mirkin wrote: > This was a silly hack that kept growing and growing. Instead, just write > NULLs for those functions. No need to have helpers that just assert(0) > when you call them. > > Signed-off-by: Ilia Mirkin > --- > s

Re: [Mesa-dev] [PATCH v2] gallium: add ASTC formats

2015-11-21 Thread Marek Olšák
Also util_format_is_compressed should be updated. With that done: Reviewed-by: Marek Olšák Marek On Sat, Nov 21, 2015 at 9:16 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > v1 -> v2: add linear <-> srgb conversions to util_format_linear/srgb > > src/gallium/auxiliary/util/u_fo

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add astc support

2015-11-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Nov 21, 2015 at 9:03 PM, Ilia Mirkin wrote: > This doesn't account for the ldr/hdr distinction... that will probably > have to be exposed via a separate cap. When relevant hardware appears, > this can be worked out. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

2015-11-21 Thread Ilia Mirkin
Just ran into this myself and spent a bunch of time investigating... Any reason this wasn't already reviewed/checked in? On Wed, Oct 28, 2015 at 5:50 PM, Nanley Chery wrote: > From: Nanley Chery > > A prior, literal reading of the ASTC spec led to the prohibition > of some compressed formats bei

[Mesa-dev] [PATCH 1/2] vc4: Just put USE_VC4_SIMULATOR in DEFINES.

2015-11-21 Thread Eric Anholt
In the pipe-loader reworks, it was missed in one of the new directories it was used. --- configure.ac | 4 +++- src/gallium/drivers/vc4/Automake.inc | 4 src/gallium/drivers/vc4/Makefile.am | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/configur

[Mesa-dev] [PATCH 2/2] vc4: Take precedence over ilo when in simulator mode.

2015-11-21 Thread Eric Anholt
They're exclusive at build time, but the ilo entry is always present, so we'd try to use it and fail out. --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c

Re: [Mesa-dev] [PATCH 3/3] mesa: return initial value for VALIDATE_STATUS if pipe not bound

2015-11-21 Thread Timothy Arceri
On Tue, 2015-09-01 at 13:53 +0300, Tapani Pälli wrote: > From OpenGL 4.5 Core spec (7.13): > > "If pipeline is a name that has been generated (without > subsequent > deletion) by GenProgramPipelines, but refers to a program > pipeline > object that has not been previously bound, the GL

Re: [Mesa-dev] [PATCH v2 12/42] i965: Add debug flag to print out the new L3 state during transitions.

2015-11-21 Thread Jordan Justen
On 2015-11-17 21:54:44, Jordan Justen wrote: > From: Francisco Jerez > > --- > src/mesa/drivers/dri/i965/gen7_l3_state.c | 17 + > src/mesa/drivers/dri/i965/intel_debug.c | 1 + > src/mesa/drivers/dri/i965/intel_debug.h | 1 + > 3 files changed, 19 insertions(+) > > diff -

[Mesa-dev] [Bug 93063] drm_helper.h:227:1: error: static declaration of ‘pipe_virgl_create_screen’ follows non-static declaration

2015-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93063 Bug ID: 93063 Summary: drm_helper.h:227:1: error: static declaration of ‘pipe_virgl_create_screen’ follows non-static declaration Product: Mesa Version: git