Re: [Mesa-dev] [PATCH 0/9] Early fp64 fixes

On Thu, 2015-11-19 at 11:05 +0100, Iago Toral Quiroga wrote: > These patches are fixes extracted from Connor's fp64 branch that > I would like to review and land ahead of the rest. They are > independent of the rest of the series, some of them are even > general fixes unrelated to fp64 that could f

Re: [Mesa-dev] [PATCH 1/2] i965: Use ldexpf() in VF float test set up.

Reviewed-by: Iago Toral Quiroga On Thu, 2015-11-19 at 22:43 -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp > b

Re: [Mesa-dev] [PATCH 2/2] i965: Test that nonrepresentable floats cannot be converted to VF.

Reviewed-by: Iago Toral Quiroga On Thu, 2015-11-19 at 22:43 -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp > b/src/mesa/d

Re: [Mesa-dev] [PATCH v3 13/14] glsl: add subroutine index qualifier support

Reviewed-by: Tapani Pälli On 11/14/2015 03:42 PM, Timothy Arceri wrote: From: Timothy Arceri ARB_explicit_uniform_location allows the index for subroutine functions to be explicitly set in the shader. This patch reduces the restriction on the index qualifier in validate_layout_qualifiers() t

[Mesa-dev] [Bug 92985] Mac OS X build error "ar: no archive members specified"

https://bugs.freedesktop.org/show_bug.cgi?id=92985 Emil Velikov changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Emil Velikov

Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper

On 20 November 2015 at 05:37, Vinson Lee wrote: > On Thu, Nov 19, 2015 at 9:36 PM, Vinson Lee wrote: >> On Thu, Nov 19, 2015 at 8:32 AM, Emil Velikov >> wrote: >>> On 19 November 2015 at 16:33, Emil Velikov wrote: From: Emil Velikov Seems that creating an empty one does not fai

Re: [Mesa-dev] [PATCH 00/13] auxiliary/vl: winsys' galore

On 10 November 2015 at 22:31, Alex Deucher wrote: > On Mon, Nov 9, 2015 at 8:31 AM, Emil Velikov wrote: >> Hi all, >> >> Inspired by the resent interest in alternative vl winsys, I've decided >> to rework the winsys into a traditional gallium fashion. >> >> Namely: add the destroy() and other fun

Re: [Mesa-dev] [PATCH] xmlconfig: Add support for DragonFly

Hi Francois, On 17 November 2015 at 18:17, Francois Tigeot wrote: > Hi, > > Emil has recently convinced me to send DragonFly support patches present in > our ports tree, so here's the first one. > Glad to hear it :-P Considering how trivial the patch is (and lack of objections) I've pushed it to

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

On 14 November 2015 at 14:43, Mauro Rossi wrote: > Hi Emil, > > I checked with Chih-Wei and LOCAL_EXPORT_C_INCLUDE_DIRS is the preferred > way. > > I took the chance to finally understand why the single line of change you > proposed will suffice, > it's because glsl_compiler module invokes libmesa

[Mesa-dev] [Bug 92985] Mac OS X build error "ar: no archive members specified"

https://bugs.freedesktop.org/show_bug.cgi?id=92985 Emil Velikov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v3 7/9] gallium: add the concept of batch queries

Reviewed-by: Samuel Pitoiset On 11/18/2015 12:49 PM, Nicolai Hähnle wrote: Some drivers (in particular radeon[si], but also freedreno judging from a quick grep) may want to expose performance counters that cannot be individually enabled or disabled. Allow such drivers to mark driver-specific

Re: [Mesa-dev] [PATCH] radeon/llvm: Use llvm.AMDIL.exp intrinsic again for now

On 20.11.2015 03:22, Michel Dänzer wrote: On 20.11.2015 02:11, Nicolai Hähnle wrote: On 19.11.2015 17:37, Tom Stellard wrote: On Thu, Nov 19, 2015 at 11:17:12AM +0100, Nicolai Hähnle wrote: On 19.11.2015 03:55, Tom Stellard wrote: On Thu, Nov 19, 2015 at 11:31:55AM +0900, Michel Dänzer wrote:

Re: [Mesa-dev] [PATCH v3 8/9] gallium/hud: add support for batch queries

Reviewed-by: Samuel Pitoiset On 11/18/2015 12:49 PM, Nicolai Hähnle wrote: v2 + v3: be more defensive about allocations --- src/gallium/auxiliary/hud/hud_context.c | 24 ++- src/gallium/auxiliary/hud/hud_driver_query.c | 270 +++ src/gallium/auxiliary/hud/hud_

[Mesa-dev] Link failure when copying big arrays stored in SSBOs

Hi, Jordan sent a piglit test that produces a link failure with the ssbo code [1]. Doing something like this is sufficient to reproduce the problem: [fragment shader] #version 330 #extension GL_ARB_shader_storage_buffer_object: require #define SIZE 6 layout (std430) buffer SSBO { mat4 m1[SI

Re: [Mesa-dev] Link failure when copying big arrays stored in SSBOs

On Fri, 2015-11-20 at 13:07 +0100, Iago Toral wrote: > Hi, > > Jordan sent a piglit test that produces a link failure with the ssbo > code [1]. Doing something like this is sufficient to reproduce the > problem: > > [fragment shader] > #version 330 > #extension GL_ARB_shader_storage_buffer_object

Re: [Mesa-dev] [PATCH] gallivm: use sampler index 0 for texel fetches

On 20/11/15 03:50, srol...@vmware.com wrote: From: Roland Scheidegger texel fetches don't use any samplers. Previously we just set the same number for both texture and sampler unit (as per "ordinary" gl style sampling where the numbers are always the same) however this would trigger some assert

Re: [Mesa-dev] [PATCH v3 9/9] st/mesa: add support for batch driver queries to perfmon

Reviewed-by: Samuel Pitoiset On 11/18/2015 12:49 PM, Nicolai Hähnle wrote: v2 + v3: forgot null-pointer checks (spotted by Samuel Pitoiset) --- src/mesa/state_tracker/st_cb_perfmon.c | 83 +++--- src/mesa/state_tracker/st_cb_perfmon.h | 6 +++ 2 files changed,

Re: [Mesa-dev] [PATCH v3 1/9] gallium: remove pipe_driver_query_group_info field type

Reviewed-by: Samuel Pitoiset On 11/18/2015 12:49 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor consists of a number of hardware and software counters that

Re: [Mesa-dev] [PATCH v3 0/9] gallium: batch query objects and related cleanups

Hi Nicolai, The whole series is: Reviewed-by: Samuel Pitoiset Tested-by: Samuel Pitoiset Thanks! On 11/18/2015 12:49 PM, Nicolai Hähnle wrote: Hi everybody, this is the next iteration of the series, rebased on current master and with the adjustment to nv50 queries. Please take a look! Samu

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix JIP to properly skip over unrelated control flow.

Kenneth Graunke writes: > On Thursday, November 19, 2015 02:05:44 PM Kenneth Graunke wrote: >> We've apparently always been botching JIP for sequences such as: >> >>do >>cmp.f0.0 ... >>(+f0.0) break >>... >>if >> ... >>else >> ... >

Re: [Mesa-dev] [PATCH v2 10/42] i965: Calculate appropriate L3 partition weights for the current pipeline state.

Kristian Høgsberg writes: > On Thu, Nov 19, 2015 at 4:24 AM, Francisco Jerez > wrote: >> Kristian Høgsberg writes: >> >>> On Tue, Nov 17, 2015 at 9:54 PM, Jordan Justen >>> wrote: From: Francisco Jerez This calculates a rather conservative partitioning of the L3 cache bas

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] radeonsi/compute: Use the compiler's COMPUTE_PGM_RSRC* register values

On 20 November 2015 at 02:26, Michel Dänzer wrote: > On 20.11.2015 05:53, Emil Velikov wrote: >> On 19 November 2015 at 20:37, Tom Stellard wrote: >>> On Wed, Nov 18, 2015 at 05:43:31PM +, Emil Velikov wrote: Hi Tom, Please flip the order of the patches and drop the now patch 1

Re: [Mesa-dev] [PATCH 2/2] i965: Prevent implicit upcasts to brw_reg.

Matt Turner writes: > Now that backend_reg inherits from brw_reg, we have to be careful to > avoid the object slicing problem. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +++-- > .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 +-- > src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Initialize nir_inputs with src_reg().

Matt Turner writes: > nir_locals, nir_ssa_values, and nir_system_values are all dst_reg (not > that that makes a whole lot of sense to me), and only nir_inputs is a > src_reg. Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 2 +- > 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

Chad Versace writes: > On Wed 04 Nov 2015, Jason Ekstrand wrote: >> Previously, we were relying on has_matching_typed_format returning true for >> MESA_FORMAT_NONE which, in turn, relied on _mesa_get_format_bytes returning >> 1 for MESA_FORMAT_NONE. All of this is extremely non-obvious. Instead

Re: [Mesa-dev] [PATCH 3/7] i965: Add an image format metadata array

Jason Ekstrand writes: > This little data structure and associated array contains all of the image > format metadata needed for doing image_load_store work-arounds. This way > we can pull metadata from within the i965 driver without having to go out > to core mesa for it. It is a bit of duplica

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

On 18 November 2015 at 21:59, Ilia Mirkin wrote: > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > wrote: >>> There's not really a consensus I guess, but most people do leave the version >>> information in the final commit message. >> >> I personally feel like that's leaving boredom doodles on a f

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

On 20 November 2015 at 04:08, Ian Romanick wrote: > On 11/19/2015 06:47 AM, Emil Velikov wrote: >> Hi Ian, >> >> Attempting to high-jack the thread :-P >> >> On 18 November 2015 at 23:46, Ian Romanick wrote: >> >>> I really wanted to get this in the next Mesa release. For some reason, >>> I thou

[Mesa-dev] [PATCH] glsl: split ssbo array copies into element copies

Improves register pressure, since otherwise we end up emitting loads for all the elements in the RHS and them emitting stores for all elements in the LHS. Fixes the following piglit test: tests/spec/arb_shader_storage_buffer_object/execution/large-field-copy.shader_test --- Jordan, this fixes the

[Mesa-dev] [PATCH 2/2] radeon/vce: disable two pipe mode for stoney

Only one encoding pipe available for Stoney Signed-off-by: Leo Liu Reviewed-by: Alex Deucher --- src/gallium/drivers/radeon/radeon_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix JIP to properly skip over unrelated control flow.

On Friday, November 20, 2015 02:38:10 PM Francisco Jerez wrote: > Kenneth Graunke writes: > > > On Thursday, November 19, 2015 02:05:44 PM Kenneth Graunke wrote: > >> We've apparently always been botching JIP for sequences such as: > >> > >>do > >>cmp.f0.0 ... > >>(+f0.0) bre

[Mesa-dev] [PATCH 1/2] radeon/vce: add new firmware interface support

Add new interface to create and encode Signed-off-by: Leo Liu Reviewed-by: Alex Deucher --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/radeon_vce.c | 21 ++- src/gallium/drivers/radeon/radeon_vce.h | 3 + src/gallium/drivers/radeon/radeon_vce_52.

Re: [Mesa-dev] [PATCH 1/2] radeon/vce: add new firmware interface support

On 20.11.2015 16:12, Leo Liu wrote: Add new interface to create and encode Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Didn't had a chance to take a look before releasing them, so I thought I better do now. Both patches are Reviewed-by: Christian König --- src/gallium/drivers

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix JIP to properly skip over unrelated control flow.

Kenneth Graunke writes: > On Friday, November 20, 2015 02:38:10 PM Francisco Jerez wrote: >> Kenneth Graunke writes: >> >> > On Thursday, November 19, 2015 02:05:44 PM Kenneth Graunke wrote: >> >> We've apparently always been botching JIP for sequences such as: >> >> >> >>do >> >>c

Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled

On Fri, Nov 20, 2015 at 2:46 AM, Iago Toral wrote: > On Thu, 2015-11-19 at 10:14 -0500, Connor Abbott wrote: >> I think Ken already pushed a similar patch so we can drop this. > > I don't see that in master, but sure, we can hold this back if he is > planning to push the same thing. > > Iago No,

Re: [Mesa-dev] [PATCH 2/2] radeon/vce: disable two pipe mode for stoney

Hi Leo, On 20 November 2015 at 15:12, Leo Liu wrote: > Only one encoding pipe available for Stoney > > Signed-off-by: Leo Liu > Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/radeon_vce.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drive

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez wrote: > Chad Versace writes: > >> On Wed 04 Nov 2015, Jason Ekstrand wrote: >>> Previously, we were relying on has_matching_typed_format returning true for >>> MESA_FORMAT_NONE which, in turn, relied on _mesa_get_format_bytes returning >>> 1 for M

[Mesa-dev] [PATCH 2/2] radeon: re-prepare query buffers on begin_query for predicate queries

The point of prepare_buffer is to ensure that the query buffer contains valid initial data for conditional rendering: as long as the buffer is initialized correctly, the GPU is able to tell whether query results have been written already (and wait or fall back to unconditional rendering if desired)

[Mesa-dev] [PATCH 1/2] radeon: reset query buffers for PIPE_QUERY_TIMESTAMP

Since begin_query is not called for this query type, we need to reset the query buffer state in end_query instead. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93015 --- src/gallium/drivers/radeon/r600_query.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletion

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick wrote: > On 11/19/2015 05:40 PM, Nanley Chery wrote: > > > > On Thu, Nov 19, 2015 at 12:13 PM, Brian Paul > > wrote: > > > > Hi Nanley, > > > > > > Hi Brian, > > > > > > Maybe you can fix an issue I have with the new

[Mesa-dev] [PATCH] radeon/vce: disable Stoney VCE for 11.0

Signed-off-by: Leo Liu "11.0" --- src/gallium/drivers/radeon/radeon_vce.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 0dac6fb..7c5a961 100644 --- a/src/gallium/drivers/radeon/radeon_vce.c +++ b/

[Mesa-dev] [PATCH] radeon/vce: disable Stoney VCE for 11.0

Signed-off-by: Leo Liu Cc: "11.0" --- src/gallium/drivers/radeon/radeon_vce.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 0dac6fb..7c5a961 100644 --- a/src/gallium/drivers/radeon/radeon_vce.c ++

Re: [Mesa-dev] [PATCH] radeon/vce: disable Stoney VCE for 11.0

On Fri, Nov 20, 2015 at 12:07 PM, Leo Liu wrote: > Signed-off-by: Leo Liu > Cc: "11.0" Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/radeon_vce.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/drivers/radeon/radeon_vce.c > b/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

> > My last problem was probably due to uncleaned mesa targets folders in > $OUT > > path, > > now I have checked again and building errors are gone. > > > You might want to take a look and update the CleanSpec.mk for that. > I've pushed the one-liner to master - do we want it in stable (11.0.x) >

[Mesa-dev] [PATCH] freedreno/a4xx: fix dst_alpha blend for RGBX render targets

There are not native RGBX render formats, so we must manually force dst_alpha to be one, same as for a3xx. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a4xx/fd4_blend.c | 13 +++-- src/gallium/drivers/freedreno/a4xx/fd4_blend.h | 7 ++- src/gallium/drivers/freedreno/

Re: [Mesa-dev] [PATCH] xmlconfig: Add support for DragonFly

Emil Velikov wrote: Considering how trivial the patch is (and lack of objections) I've pushed it to master... only to forget the mesa-stable tag (I'll pick it up for the next stable release regardless) :-\ If you have _any_ additional patches do send them over, but please use git send-email - it

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

On Fri, Nov 20, 2015 at 02:18:56PM +, Emil Velikov wrote: > On 18 November 2015 at 21:59, Ilia Mirkin wrote: > > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > > wrote: > >>> There's not really a consensus I guess, but most people do leave the > >>> version > >>> information in the final com

Re: [Mesa-dev] [PATCH] [v2] i965: Add lossless compression to surface format table

On Wed 18 Nov 2015, Ben Widawsky wrote: > On Wed, Nov 18, 2015 at 10:28:27AM -0800, Chad Versace wrote: > > On Tue 17 Nov 2015, Ben Widawsky wrote: > > > The logic in the table works a bit differently than the other columns in > > > the > > > table and therefore deserves a small mention. For mos

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

On Fri, Nov 20, 2015 at 02:18:56PM +, Emil Velikov wrote: > On 18 November 2015 at 21:59, Ilia Mirkin wrote: > > On Wed, Nov 18, 2015 at 4:54 PM, Sarah Sharp > > wrote: > >>> There's not really a consensus I guess, but most people do leave the > >>> version > >>> information in the final com

Re: [Mesa-dev] [PATCH] [v2] i965: Add lossless compression to surface format table

On Wed 18 Nov 2015, Ben Widawsky wrote: > On Wed, Nov 18, 2015 at 10:28:27AM -0800, Chad Versace wrote: > > On Tue 17 Nov 2015, Ben Widawsky wrote: > > > Background: Prior to Skylake and since Ivybridge Intel hardware has had > > > the > > > ability to use a MCS (Multisample Control Surface) as au

Re: [Mesa-dev] [PATCH] glsl: split ssbo array copies into element copies

On 2015-11-20 06:48:27, Iago Toral Quiroga wrote: > Improves register pressure, since otherwise we end up emitting > loads for all the elements in the RHS and them emitting > stores for all elements in the LHS. > > Fixes the following piglit test: > tests/spec/arb_shader_storage_buffer_object/exec

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add KBL PCI IDs and platform information.

On Fri, Nov 20, 2015 at 2:01 PM, Ben Widawsky wrote: >> > FWIW I wholeheartedly agree with this line of reasoning. I never put >> > the version info into my commits either, and find it >> > confusing/misleading when others do. I want to know the final state of >> > things when looking at the commi

[Mesa-dev] [PATCH 1/2] nv50: expose two groups of compute-related MP perf counters

This turns on GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 52 ++ src/gallium/drivers/nouveau/nv50/nv50_query.h | 6 +++ .../drivers/nouveau/nv50/nv50_query_hw_metric.c| 2 +- .../drivers/nouvea

[Mesa-dev] [PATCH 2/2] docs: mark GL_AMD_performance_monitor for nv50

Signed-off-by: Samuel Pitoiset --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 2f462f7..204a665 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -45,6 +45,7 @@ Note: some of the

Re: [Mesa-dev] [PATCH 1/2] nv50: expose two groups of compute-related MP perf counters

Series is Acked-by: Ilia Mirkin . TBH I haven't spent the time to figure out what all this stuff is, but these changes appear to be internally consistent :) On Fri, Nov 20, 2015 at 2:28 PM, Samuel Pitoiset wrote: > This turns on GL_AMD_performance_monitor. > > Signed-off-by: Samuel Pitoiset > -

Re: [Mesa-dev] [PATCH] [v2] i965: Add lossless compression to surface format table

On Fri, Nov 20, 2015 at 11:02:43AM -0800, Chad Versace wrote: > On Wed 18 Nov 2015, Ben Widawsky wrote: > > On Wed, Nov 18, 2015 at 10:28:27AM -0800, Chad Versace wrote: > > > On Tue 17 Nov 2015, Ben Widawsky wrote: > > > > Background: Prior to Skylake and since Ivybridge Intel hardware has had >

Re: [Mesa-dev] Patchwork admin rights

On 13 November 2015 at 12:56, Ilia Mirkin wrote: > On Fri, Nov 13, 2015 at 7:40 AM, Emil Velikov > wrote: >> On 13 November 2015 at 12:34, Antía Puentes wrote: >>> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote: Hello, I would like to have admin permissions to

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix JIP to properly skip over unrelated control flow.

On Friday, November 20, 2015 05:36:35 PM Francisco Jerez wrote: > Kenneth Graunke writes: > > > On Friday, November 20, 2015 02:38:10 PM Francisco Jerez wrote: > >> Kenneth Graunke writes: > >> > >> > On Thursday, November 19, 2015 02:05:44 PM Kenneth Graunke wrote: > >> >> We've apparently alw

[Mesa-dev] [PATCH v2 08/40] pipe-loader: remove HAVE_DRM_LOADER_GALLIUM and HAVE_PIPE_LOADER_DRM

... in favour of HAVE_LIBDRM. After all we solely want to build the code when the latter is available. In the not too distant future we will remove the libudev/sysfs dependency and simplify configure.ac even further. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- configure.ac

[Mesa-dev] [PATCH v2 28/40] pipe-loader: add preliminary Android support

Add a 'static' pipe-loader build, which will be used with follow-up commits. Signed-off-by: Emil Velikov Reviewed-by: Chih-Wei Huang Acked-by: Rob Clark --- src/gallium/Android.mk | 1 + src/gallium/auxiliary/pipe-loader/Android.mk | 49 2 fi

[Mesa-dev] [PATCH v2 29/40] {st, targets}/dri: use static/dynamic pipe-loader

Covert DRI to use only the pipe-loader interface. With drisw_create_screen and kms_swrast_create_screen replaced by their pipe-loader equivalent, we can now drop them. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- .../auxiliary/target-helpers/inline_drm_helper.h | 24 --

[Mesa-dev] [PATCH v2 31/40] {st, targets}/xa: use static/dynamic pipe-loader

Analogous to previous commits. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/state_trackers/xa/Makefile.am | 5 - src/gallium/state_trackers/xa/xa_tracker.c | 16 ++-- src/gallium/targets/xa/Makefile.am | 7 +-- src/gallium/targets/xa/target.c

[Mesa-dev] [PATCH v2 09/40] targets/nine: remove the custom pipe-driver path management

Since the up-streaming of nine, the static target was used by default. The dynamic pipe-drivers being available only via manual tweak of configure.ac. As we'll be removing the library_path argument from the pipe-loader with follow-up commits, we can remove D3D9_DRIVERS_PATH/D3D9_DRIVERS_DIR. Every

[Mesa-dev] [PATCH v2 05/40] targets/nine: use the existing sw_screen_wrap() over our custom version

Cc: Axel Davy Signed-off-by: Emil Velikov Acked-by: Rob Clark --- .../auxiliary/target-helpers/inline_sw_helper.h| 27 -- src/gallium/targets/d3dadapter9/Makefile.am| 1 - src/gallium/targets/d3dadapter9/drm.c | 4 ++-- 3 files changed, 2 insertion

[Mesa-dev] [PATCH v2 07/40] pipe-loader: add pipe_loader_sw_probe_kms() implementation

Will be used as a counterpart for target-helpers' kms_swrast_create_screen(). Signed-off-by: Emil Velikov Acked-by: Rob Clark --- configure.ac | 4 src/gallium/Automake.inc | 5 + src/gallium/auxiliary/pipe-loader/pipe_l

[Mesa-dev] [PATCH v2 12/40] pipe-loader: add pipe_loader_sw_probe_init_common() helper

Allows us to fold the duplication in pipe_loader_sw_probe_*(). Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH v2 18/40] pipe-loader: dlopen/dlsym the pipe-driver at probe time

Rather than giving false hopes that things might work, just check at probe time. This allows us to remove the duplication and consolidate the code wrt the upcomming static pipe-loader. Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov Acked-by: Rob Clark --- .../auxiliary/pipe-

[Mesa-dev] [PATCH v2 24/40] target-helpers: move the DRI specifics to the target

Rather than having all targets include the file, with only some defining the relevant guard macro, just move things where they are used. v2: rebase on top of virgl support. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- .../auxiliary/target-helpers/inline_drm_helper.h | 136

[Mesa-dev] [PATCH v2 00/40] Rework/consolidate the pipe-loader business

Hi all, An update/rebase from the previous series. - updated to handle vl_winsys_drm - included virgl handling - targets should print "foo: driver missing" when built without foo I might be abusing my luck here, but considering the amount of interest the previous round brought (not suprisingl

[Mesa-dev] [PATCH v2 14/40] gallium: keep the libdrm link alongside libkmsdri.la

Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/Automake.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc index 095e6ec..6fe2e22 100644 --- a/src/gallium/Automake.inc +++ b/src/gallium/Automake.inc @@ -7

[Mesa-dev] [PATCH v2 03/40] pipe-loader: remove HAVE_PIPE_LOADER_foo function prototype guards

They serve little to no purpose, as we don't need any additional dependencies (headers and/or symbols). On the other hand dropping them will allow us to use GALLIUM_PIPE_LOADER_DEFINES in only one single place - the pipe-loader. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/au

[Mesa-dev] [PATCH v2 16/40] pipe-loader: teardown the winsys, if create_screen fails

i.e. plug some (hard to hit) memory leaks. v2: fix rebase fallout - really teardown the winsys (Brian) Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/aux

[Mesa-dev] [PATCH v2 01/40] configure: remove obsolete _CLIENT comment

The referenced variable(s) have been removed with commit abc20120e4a (automake: pipe-loader: remove the 'client' pipe-loader) Signed-off-by: Emil Velikov Acked-by: Rob Clark --- configure.ac | 5 - 1 file changed, 5 deletions(-) diff --git a/configure.ac b/configure.ac index 32fb989..027cf

[Mesa-dev] [PATCH v2 06/40] configure: use HAVE_DRISW_KMS when handling kms swrast

Using HAVE_DRI2 to manage it seems counter-intuitive. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- configure.ac | 5 + src/gallium/Makefile.am | 2 +- src/gallium/drivers/softpipe/Automake.inc | 2 +- 3 files changed, 7 insertions(+), 2

[Mesa-dev] [PATCH v2 15/40] pipe-loader: rework the sw backend

Move the winsys into the pipe-target, similar to the hardware pipe-driver. v2: - move int declaration outside of loop (Brian) - fold the teardown into a goto + separate function. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 127

[Mesa-dev] [PATCH v2 13/40] pipe-loader: directly use pipe_loader_sw_probe_null() at probe time

Due to the nature of the other sw winsys' we cannot use them during the generic probe stage. As such there is little point in keeping the abstraction layer. Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_s

[Mesa-dev] [PATCH v2 25/40] target-helpers: add a non-inline drm_helper.h

Unlike the inline ones, here we'd want to have an extern definition of the functions. This is required as with follow-up commits, we'll gradually start using the static pipe-loader, with the latter needing the symbols. These are direct copy from the inline version. v2: - rebase on top of virgl s

[Mesa-dev] [PATCH v2 04/40] automake: use GALLIUM_PIPE_LOADER_DEFINES only where applicable

As of last commit we no longer need the defines in order to have the function prototypes. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/Makefile.am | 1 - src/gallium/state_trackers/clover/Makefile.am | 1 - src/gallium/state_trackers/dri/Makefile.am|

[Mesa-dev] [PATCH v2 02/40] gallium/trace: remove useless NULL check from trace_screen_create()

Currently every target makes sure that the screen is non-null prior to using the debug (trace including) wrappers. If that no longer holds true we want to know and fix this ASAP rather than silently bailing out. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/drivers/trace/tr_sc

[Mesa-dev] [PATCH v2 11/40] gallium/tests: remove unneeded include paths

The tests don't (and shouldn't) need to have anything driver and/or winsys specific. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/tests/trivial/Makefile.am | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/tests/trivial/Makefile.am b/src/gallium/tests/trivia

[Mesa-dev] [PATCH v2 23/40] automake: remove no longer needed HAVE_LOADER_GALLIUM conditional

As of last few commits we have a static and dynamic pipe-loader. Either of which will be used with (almost) all targets.. We can look into allowing the user to select which way the targets are built, be that 'static for all' or 'per target' in follow up commits. After which we can look into buildi

[Mesa-dev] [PATCH v2 10/40] gallium: remove library_path argument from pipe_loader_create_screen()

Currently the location is determined at configure/build time and consistently copied across gallium. Just remove the extra argument, and use PIPE_SEARCH_DIR where appropriate. This will allow us to remove the duplication in the *configuration and *screen_create APIs by moving util_dl_get_proc_addr

[Mesa-dev] [PATCH v2 34/40] st/dri: Don't close the drm fd on failure

Ported from an identically named commit in st/xa commit 35cf3831d71770211f29da6608313dc1f6213d7b Author: Thomas Hellstrom Date: Thu Jul 3 02:07:36 2014 -0700 st/xa: Don't close the drm fd on failure v2 Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/state_trackers/dri/d

[Mesa-dev] [PATCH v2 30/40] {auxiliary, targets}/vl: use static/dynamic pipe-loader

Analogous to previous commit. v2: rebase on top of vl_winsys_drm.c addition Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/Makefile.am| 6 -- src/gallium/auxiliary/vl/vl_winsys_dri.c | 8 src/gallium/auxiliary/vl/vl_winsys_drm.c | 11 +-

[Mesa-dev] [PATCH v2 35/40] st/dri: NULL check the pscreen earlier

We delay the null check only to jump through hoops to work around that. Check early to make our lives easier. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/state_trackers/dri/dri2.c | 22 -- src/gallium/state_trackers/dri/dri_screen.c | 5 - src/

[Mesa-dev] [PATCH v2 26/40] pipe-loader: don't mix code and variable declarations

We cannot use this C99 feature here quite yet, as the code needs to be build with MSVC prior to 2013. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxilia

[Mesa-dev] [PATCH v2 19/40] gallium: rename libpipe_loader to libpipe_loader_dynamic

With the next commits we'll introduce a 'static' version, which will essentially load the statically linked-in pipe-drivers, rather than the standalone pipe-$foo.so ones. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/Makefile.am | 8 src/gallium/

[Mesa-dev] [PATCH v2 27/40] pipe-loader: add preliminary scons support

Add a 'static' pipe-loader build, which will be used with follow-up commits. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/SConscript| 1 + src/gallium/auxiliary/pipe-loader/Makefile.am | 2 ++ src/gallium/auxiliary/pipe-loader/SConscript | 34 ++

[Mesa-dev] [PATCH v2 21/40] pipe-loader: wire up the 'static' drm pipe-loader

Add a list of driver descriptors and select one from the list, during probe time. As we'll need to have all the driver pipe_foo_screen_create() functions provided externally (i.e. from another static lib) we need a separate (non-inline) drm_helper, which contains the function declarations. v2: re

[Mesa-dev] [PATCH v2 37/40] targets/nine: add note about fd owndership

v2: - move autotools hunk into correct patch - correct the note based on Axel's feedback Cc: Axel Davy Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/targets/d3dadapter9/drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/

[Mesa-dev] [PATCH v2 39/40] targets/nine: remove unused static functions

Dead code since commit 8f50614910c40366d94964fe2c5da5772aff2f96 Cc: Axel Davy Cc: Tiziano Bacocco Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/targets/d3dadapter9/drm.c | 36 --- 1 file changed, 36 deletions(-) diff --git a/src/gallium/targe

[Mesa-dev] [PATCH v2 40/40] util: use RTLD_LOCAL with util_dl_open()

Otherwise we risk things blowing up due to conflicting symbols. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/util/u_dl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_dl.c b/src/gallium/auxiliary/util/u_dl.c index

[Mesa-dev] [PATCH v2 17/40] pipe-loader: annotate the ops as const data

Already defined as such in struct pipe_loader_device::ops. Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 4 ++-- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 4 ++-- 2 files changed, 4 in

[Mesa-dev] [PATCH v2 33/40] target-helpers: remove inline_drm_helper.h

As of earlier all the targets use the non inline version. Don't forget to remove the function prototypes/declarations. v2: rebase on top of virgl support. Signed-off-by: Emil Velikov Acked-by: Rob Clark --- .../auxiliary/target-helpers/inline_drm_helper.h | 371 - src/gal

[Mesa-dev] [PATCH v2 32/40] {st, targets}/nine: use static/dynamic pipe-loader

Analogous to previous commits. v2: add the missing winsys libs linkage Cc: Axel Davy Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/targets/d3dadapter9/Makefile.am | 14 +- src/gallium/targets/d3dadapter9/drm.c | 24 +++- 2 files changed,

[Mesa-dev] [PATCH v2 36/40] auxiliary/vl: Don't close the drm fd on failure

Ported from an identically named commit in st/xa commit 35cf3831d71770211f29da6608313dc1f6213d7b Author: Thomas Hellstrom Date: Thu Jul 3 02:07:36 2014 -0700 st/xa: Don't close the drm fd on failure v2 Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/auxiliary/vl/vl_wins

[Mesa-dev] [PATCH v2 38/40] targets/nine: add note about messy header inclusion order

Cc: Axel Davy Signed-off-by: Emil Velikov Acked-by: Rob Clark --- src/gallium/targets/d3dadapter9/drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c index 84cfb94..00e58e0 100644 --- a/src/gallium/targets/d3da

[Mesa-dev] [PATCH v2 22/40] pipe-loader: wire up the 'static' sw pipe-loader

Analogous to previous commit with a small catch. As the sw inline helpers are mere wrappers, and the screen <> winsys split is more prominent (with the latter not being part of the final pipe-driver), things will just work. v2: rebase on top of earlier 'consolitate teardown' changes Signed-off-b

[Mesa-dev] [PATCH v2 20/40] pipe-loader: add a dummy 'static' pipe-loader

It is to be used in contrast of the dynamic one. The state-tracker does not need to know if the pipe-driver is built into the final blob or a separate object. This will allow us to move the logic to the final step (in target) where the appropriate pipe-loader will be chosen. Cc: Tom Stellard Cc:

Re: [Mesa-dev] [PATCH 2/2] radeon: re-prepare query buffers on begin_query for predicate queries

For the series: Reviewed-by: Marek Olšák Marek On Fri, Nov 20, 2015 at 5:38 PM, Nicolai Hähnle wrote: > The point of prepare_buffer is to ensure that the query buffer contains valid > initial data for conditional rendering: as long as the buffer is initialized > correctly, the GPU is able to t

  1   2   >