Re: [Mesa-dev] [PATCH 2/6] mesa: rename gl_shader_program's NumUniformBlocks to NumUniformShaderStorageBlocks

On 2015-09-25 01:24:46, Samuel Iglesias Gonsalvez wrote: > Because it counts shader storage blocks too. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/link_uniform_initializers.cpp | 2 +- > src/glsl/link_uniforms.cpp | 4 ++-- > src/glsl/linker.cpp

Re: [Mesa-dev] [PATCH 6/6] i965: Simplify handling of VUE map changes.

For the v2 series: Reviewed-by: Chris Forbes On Sat, Sep 12, 2015 at 6:58 PM, Kenneth Graunke wrote: > The old code was disasterously complex - spread across multiple atoms > which may not even run, inspecting the dirty bits to try and decide > whether it was necessary to do checks...storing V

[Mesa-dev] [Bug 91797] [r600g] Company of Heroes 2 crash when zooming on the map

https://bugs.freedesktop.org/show_bug.cgi?id=91797 --- Comment #2 from Marek Olšák --- Is it always reproducible? If yes, could you create an apitrace? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [Bug 91643] mesa-demos-8.2.0 (latest released version) fails to build against mesa-10.6.4-2.mga6.tainted.src.rpm

https://bugs.freedesktop.org/show_bug.cgi?id=91643 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91643] mesa-demos-8.2.0 (latest released version) fails to build against mesa-10.6.4-2.mga6.tainted.src.rpm

https://bugs.freedesktop.org/show_bug.cgi?id=91643 Marek Olšák changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #8 from Ma

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

https://bugs.freedesktop.org/show_bug.cgi?id=91020 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] Mesa 11.0.1

Mesa 11.0.1 is now available. With this release we have mostly nouveau and i965 fixes, although there is the odd llvmpipe (big endian) and gbm bugfix. Antia Puentes (2): i965/vec4: Fix saturation errors when coalescing registers i965/vec4_nir: Load constants as integers Anuj Phogat

Re: [Mesa-dev] [PATCH 4/6] main/tests: Enable glShaderStorageBlockBinding() check in dispatch_sanity test

On 25/09/15 18:45, Matt Turner wrote: > Reviewed-by: Matt Turner > > Please commit this one as soon as possible. > Pushed. Thanks, Sam ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: don't leak interface_name

Found by Coverity Signed-off-by: Ilia Mirkin --- src/mesa/main/shader_query.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 99d9e10..e020dce 100644 --- a/src/mesa/main/shader_query.cpp +++ b/src/mesa/main/shader_query.

[Mesa-dev] Returning 0 from std430_base_alignment

Hi Samuel, Coverity is up in a tizzy because std430_base_alignment can return 0 (which in turn would cause tons of errors since it's used with glsl_align). Is there a better starting value that can be used for its is_record() case? For std140 it's 16... I assume for std430 it's 4 or something? Tha

[Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

Found by Coverity Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 2fbf69c..b7b1ece 100644 --- a/src/gallium/auxiliary/u

[Mesa-dev] [PATCH 1/2] state_trackers/hgl: Fix missing include path

--- src/gallium/state_trackers/hgl/SConscript |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/gallium/state_trackers/hgl/SConscript b/src/gallium/state_trackers/hgl/SConscript index 82a0ce0..d2389c8 100644 --- a/src/gallium/state_trackers/hgl/SConscript +++ b/src/gall

[Mesa-dev] [PATCH 2/2] egl: Fix missing Haiku include path

--- src/egl/SConscript |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/egl/SConscript b/src/egl/SConscript index f8102db..8f8b11a 100644 --- a/src/egl/SConscript +++ b/src/egl/SConscript @@ -8,6 +8,7 @@ env = env.Clone() env.Append(CPPPATH = [ '#/include', +

Re: [Mesa-dev] [PATCH 14/24] i965: fix atomic buffer index for bindings other than 0

On Thu, Sep 17, 2015 at 3:02 AM, Timothy Arceri wrote: > Since commit c0cd5b var->data.binding was being used as a replacement > for atomic buffer index, but they don't have to be the same value they > just happen to end up the same when binding is 0. > > Now that we store the atomic uniform locat

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Emil Velikov writes: > Hi all, > > On 10 September 2015 at 00:30, Mark Janes wrote: >> Mark Janes writes: >> >>> Francisco Jerez writes: >>> Mark Janes writes: > When I tested this, I saw an intermittent BSW gpu hang. I haven't been > able to confirm that it is due to the h

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Fix hang on IVB and VLV with image format mismatch.

Emil Velikov writes: > Hi Francisco, > > On 9 September 2015 at 18:04, Ian Romanick wrote: >> On 09/09/2015 05:30 AM, Francisco Jerez wrote: >>> Ian Romanick writes: >>> On 09/03/2015 06:03 AM, Francisco Jerez wrote: > IVB and VLV hang sporadically when an untyped surface read or write

Re: [Mesa-dev] [PATCH] mesa: don't leak interface_name

On 27 September 2015 3:39:22 am AEST, Ilia Mirkin wrote: >Found by Coverity > >Signed-off-by: Ilia Mirkin Reviewed-by: Timothy Arceri >--- > src/mesa/main/shader_query.cpp | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/src/mesa/main/shader_query.cpp >b/src/mesa/main/shader_query.cpp

Re: [Mesa-dev] [PATCH 14/24] i965: fix atomic buffer index for bindings other than 0

On 27 September 2015 6:23:42 am AEST, Ilia Mirkin wrote: >On Thu, Sep 17, 2015 at 3:02 AM, Timothy Arceri >wrote: >> Since commit c0cd5b var->data.binding was being used as a replacement >> for atomic buffer index, but they don't have to be the same value >they >> just happen to end up the same

Re: [Mesa-dev] [PATCH 14/24] i965: fix atomic buffer index for bindings other than 0

On Sat, Sep 26, 2015 at 5:17 PM, Timothy Arceri wrote: > > > On 27 September 2015 6:23:42 am AEST, Ilia Mirkin > wrote: >>On Thu, Sep 17, 2015 at 3:02 AM, Timothy Arceri >>wrote: >>> Since commit c0cd5b var->data.binding was being used as a replacement >>> for atomic buffer index, but they don'

[Mesa-dev] [Bug 92125] make check DispatchSanity_test.GL31_CORE regression

https://bugs.freedesktop.org/show_bug.cgi?id=92125 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] memoryBarrier + SSBO

On 26 September 2015 at 03:32, Ilia Mirkin wrote: > Hi Ian (and other spec experts), > > The ARB_ssbo spec mentions the following: > > OpenGL 4.0 (either core or compatibility profile) is required. > > ... > > Additionally, the shading language provides the memoryBarrier() function > t

Re: [Mesa-dev] memoryBarrier + SSBO

On Sat, Sep 26, 2015 at 6:12 PM, Albert Freeman wrote: > On 26 September 2015 at 03:32, Ilia Mirkin wrote: >> Hi Ian (and other spec experts), >> >> The ARB_ssbo spec mentions the following: >> >> OpenGL 4.0 (either core or compatibility profile) is required. >> >> ... >> >> Additionally,

Re: [Mesa-dev] memoryBarrier + SSBO

On 27 September 2015 at 08:30, Ilia Mirkin wrote: > On Sat, Sep 26, 2015 at 6:12 PM, Albert Freeman > wrote: >> On 26 September 2015 at 03:32, Ilia Mirkin wrote: >>> Hi Ian (and other spec experts), >>> >>> The ARB_ssbo spec mentions the following: >>> >>> OpenGL 4.0 (either core or compatib

Re: [Mesa-dev] memoryBarrier + SSBO

On 27 September 2015 at 08:32, Albert Freeman wrote: > On 27 September 2015 at 08:30, Ilia Mirkin wrote: >> On Sat, Sep 26, 2015 at 6:12 PM, Albert Freeman >> wrote: >>> On 26 September 2015 at 03:32, Ilia Mirkin wrote: Hi Ian (and other spec experts), The ARB_ssbo spec mentions

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

On 27 September 2015 at 03:46, Ilia Mirkin wrote: > Found by Coverity > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_blitter.c > b/src/gallium/auxiliary/util/u_bl

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

On Sat, Sep 26, 2015 at 7:29 PM, Albert Freeman wrote: > On 27 September 2015 at 03:46, Ilia Mirkin wrote: >> Found by Coverity >> >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/util/u_blitter.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/galli

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

On 27 September 2015 at 09:35, Ilia Mirkin wrote: > On Sat, Sep 26, 2015 at 7:29 PM, Albert Freeman > wrote: >> On 27 September 2015 at 03:46, Ilia Mirkin wrote: >>> Found by Coverity >>> >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/gallium/auxiliary/util/u_blitter.c | 2 +- >>> 1 file chang

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

Reviewed-by: Albert Freeman On 27 September 2015 at 09:41, Albert Freeman wrote: > On 27 September 2015 at 09:35, Ilia Mirkin wrote: >> On Sat, Sep 26, 2015 at 7:29 PM, Albert Freeman >> wrote: >>> On 27 September 2015 at 03:46, Ilia Mirkin wrote: Found by Coverity Signed-off-b

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #2 from MWATTT --- This commit also breaks Cities: Skylines. The ground is not rendered. Tested with a AMD JUNIPER chip and LLVMpipe. -- You are receiving this mail because: You are the QA Contact for the bug. __

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

Reviewing diffs of code that generates code is always ick. =( This *looks* right to me, but has it been given a beating for correctness? If not, let me know, and I'll give it a whirl when I have some cycles. Reviewed-by: Jeremy Huddleston Sequoia --- You're right that this used to be use in

Re: [Mesa-dev] [PATCH 06/11] loader: use HAVE_LIBDRM instead of ! __NOT_HAVE_DRM_H

Sorry, been slammed and trying to catch up. I forget if I replied to this or not, but if you're still waiting on me: Reviewed-by: Jeremy Huddleston Sequoia > On Jul 9, 2015, at 10:55, Ian Romanick wrote: > > I can't really speak to the Android.mk or SConscript changes, but the > rest of thi

Re: [Mesa-dev] [PATCH] i965/miptree: Rename intel_miptree_map::mt -> ::linear_mt (v2)

Hi, Am 25/09/2015 um 23:24 schrieb Chad Versace: > Because that's what it is. It's an untiled, *linear* miptree. > > v2: - Add space after /*. - Use one comment per function argument. > --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 > ++- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] Pending issues of lollipop-x86

Hi, Marek's patches solved Camera and Youtube crashes on nouveau and radeonsi. I'm available to test on i965, if needed I think at this point the remaining major problem for lollipop-x86 is the font artifacts/invisible chars on i965GM (X3100) still present in mesa 11.0.0, I need to check with 11.

Re: [Mesa-dev] [PATCH 1/2] st/dri: don't use _ctx in client_wait_sync

On 25 September 2015 at 23:49, Marek Olšák wrote: > From: Marek Olšák > > Not needed and it can be NULL. > > Cc: 10.6 11.0 > --- > src/gallium/state_trackers/dri/dri2.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/state_trackers/dri/dri2.c > b/src/

[Mesa-dev] [PATCH 10/11] freedreno/ir3: add support for ssbo intrinsics

The non-inc/dec encoding can use some work. But for now that's all we get in practice. We add an extra fake register for the benefit of instruction ordering, based on the last memory op. This could be made smarter to work on a per-buffer or even per-address basis, but the current solution is simpl

[Mesa-dev] [PATCH 04/11] tgsi: update atomic op docs

Specify that the operation only applies to the x component, not per-component as previously specified. This is unnecessary for GL and creates additional complications for images which need to support these operations as well. Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 93 +

[Mesa-dev] [PATCH 02/11] ureg: add buffer support to ureg

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 3 ++- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 27 +++ src/gallium/auxiliary/tgsi/tgsi_ureg.h | 3 +++ src/gallium/include/pipe/p_shader_tokens.h | 1 + 4 files changed, 33 insertions(+

[Mesa-dev] [PATCH 05/11] gallium: add PIPE_SHADER_CAP_MAX_BUFFERS

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++ src/gallium/drivers/nouveau/nv30/nv30_

[Mesa-dev] [PATCH 11/11] freedreno: enable ARB_shader_atomic_counters

Signed-off-by: Ilia Mirkin --- docs/relnotes/11.1.0.html| 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index e28fab6..6e59294 100644 --- a/d

[Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

Signed-off-by: Ilia Mirkin --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 +- src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h | 5 + src/mesa/state_tracker/st_atom_atomicbuf.c | 15

[Mesa-dev] [PATCH 00/11] Add atomic counters and partial buffer support to gallium

This series is enough to get atomic counters going on freedreno. I half-heartedly started adding image and generic buffer support, but some freedreno-side issues (to do with instruction encoding) would have prevented me from testing it all the way. The idea is that BUFFER[n] represents a shader bu

[Mesa-dev] [PATCH 01/11] tgsi: add ureg support for image decls

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_build.c| 62 + src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 +-- src/gallium/auxiliary/tgsi/tgsi_parse.c| 4 +- src/gallium/auxiliary/tgsi/tgsi_parse.h| 2 +- src/galliu

[Mesa-dev] [PATCH 07/11] ttn: add buffer support

This adds preliminary support for dealing with buffers. There are a few deficiencies, but nothing that should prevent atomic counters and ssbo buffers from working. This converts to using ssbo intrinsics. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 118 ++

[Mesa-dev] [PATCH 03/11] tgsi: add a is_store property

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 446 - src/gallium/auxiliary/tgsi/tgsi_info.h | 1 + 2 files changed, 224 insertions(+), 223 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tg

[Mesa-dev] [PATCH 09/11] freedreno/ir3: upload shader buffer addresses after ubos

Signed-off-by: Ilia Mirkin --- .../drivers/freedreno/ir3/ir3_compiler_nir.c | 3 +- src/gallium/drivers/freedreno/ir3/ir3_shader.c | 42 ++ src/gallium/drivers/freedreno/ir3/ir3_shader.h | 4 ++- 3 files changed, 47 insertions(+), 2 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 08/11] freedreno: add support for state tracking shader buffers

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/freedreno_context.h | 2 ++ src/gallium/drivers/freedreno/freedreno_draw.c | 8 src/gallium/drivers/freedreno/freedreno_resource.c | 8 src/gallium/drivers/freedreno/freedreno_state.c| 24 ++