[Mesa-dev] [PATCH v2 07/82] glsl: Add ir_binop_ssbo_load expression operation.

From: Kristian Høgsberg This will be used to load the value of a buffer variable from an SSBO, like ir_binop_ubo_load for UBOs. --- src/glsl/ir.cpp | 1 + src/glsl/ir.h| 8 src/glsl/ir_validate.cpp

[Mesa-dev] [PATCH v2 05/82] glsl: link buffer variables and shader storage buffer interface blocks

From: Kristian Høgsberg --- src/glsl/link_interface_blocks.cpp | 15 --- src/glsl/link_uniform_initializers.cpp | 3 ++- src/glsl/link_uniforms.cpp | 8 +--- src/glsl/linker.cpp| 4 ++-- 4 files changed, 21 insertions(+), 9 deletions(-) dif

[Mesa-dev] [PATCH v2 01/82] mesa: define ARB_shader_storage_buffer_object extension

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/glcpp/glcpp-parse.y| 3 ++ src/glsl/glsl_parser_extras.cpp | 63 + src/glsl/glsl_parser_extras.h | 7 + src/mesa/main/extensions.c | 1 + src/mesa/main

[Mesa-dev] [PATCH v2 04/82] glsl: Implement parser support for 'buffer' qualifier

From: Kristian Høgsberg This is used to identify shader storage buffer interface blocks where buffer variables are declared. --- src/glsl/ast.h | 1 + src/glsl/ast_to_hir.cpp | 14 ++ src/glsl/ast_type.cpp | 3 ++- src/glsl/glsl_lexer.ll

[Mesa-dev] [PATCH v2 02/82] glsl: Add ir_var_shader_storage

From: Kristian Høgsberg This will be used to identify buffer variables inside shader storage buffer objects, which are very similar to uniforms except for a few differences, most important of which is that they are writable. Since buffer variables are so similar to uniforms, we will almost alway

[Mesa-dev] [PATCH v2 06/82] glsl: Identify active uniform blocks that are buffer blocks as such.

--- src/glsl/link_uniform_block_active_visitor.cpp | 1 + src/glsl/link_uniform_block_active_visitor.h | 1 + src/glsl/link_uniform_blocks.cpp | 4 src/mesa/main/mtypes.h | 5 + 4 files changed, 11 insertions(+) diff --git a/src/glsl/link_uniform_b

[Mesa-dev] [PATCH v2 00/82] ARB_shader_storage_buffer_object (mesa, i965)

Link to v1: http://lists.freedesktop.org/archives/mesa-dev/2015-May/084196.html Changes in v2: - Drop obsolete FS visitor support - Add FS NIR implementation - Use "is_shader_storage" flag names instead of "is_buffer" (Jordan) - Modify lower_ubo_reference to merge emit_sso_writes and emit_ubo_load

[Mesa-dev] [PATCH v2 10/82] mesa: add MaxShaderStorageBlocks to struct gl_program_constants

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/context.c | 2 ++ src/mesa/main/mtypes.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 8577e43..5759045 100644 --- a/src/mesa/main/contex

[Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

SSBOs are read/write and this CSE pass only handles read-only variables. --- src/glsl/opt_cse.cpp | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/src/glsl/opt_cse.cpp b/src/glsl/opt_cse.cpp index 4b8e9a0..a05ab46 100644 --- a/src/glsl/opt_cse.c

[Mesa-dev] [PATCH v2 11/82] glsl: enable binding layout qualifier usage for shader storage buffer objects

From: Samuel Iglesias Gonsalvez See GLSL 4.30 spec, section 4.4.5 "Uniform and Shader Storage Block Layout Qualifiers". Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ast_to_hir.cpp | 29 - src/glsl/glsl_parser.yy | 3 ++- 2 files changed, 26 insertions(+),

[Mesa-dev] [PATCH v2 16/82] mesa: Implement _mesa_DeleteBuffers for target GL_SHADER_STORAGE_BUFFER

--- src/mesa/main/bufferobj.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index a528787..0e762df 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1264,6 +1264,17 @@ _mesa_DeleteBuffers(GLsizei n, c

[Mesa-dev] [PATCH v2 20/82] mesa: Implement _mesa_BindBufferRange for target GL_SHADER_STORAGE_BUFFER

--- src/mesa/main/bufferobj.c | 37 + 1 file changed, 37 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index fb5331e..4277880 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -3157,6 +3157,40 @@ bind_b

[Mesa-dev] [PATCH v2 24/82] glsl: Don't do constant propagation on buffer variables

Since the backing storage for these is shared we cannot ensure that the value won't change by writes from other threads. --- src/glsl/opt_constant_propagation.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/opt_constant_propagation.cpp b/src/glsl/opt_constant_propagation.

[Mesa-dev] [PATCH v2 08/82] glsl: lower SSBO reads to ir_binop_ssbo_load expressions

From: Kristian Høgsberg The same we do for UBO loads with ir_binop_ubo_load. --- src/glsl/lower_ubo_reference.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 4ea4ccb..4341c34 100644 --- a/src

[Mesa-dev] [PATCH v2 33/82] i965: Upload Shader Storage Buffer Object surfaces

Since these are a special kind of UBOs we emit them together reusing the same infrastructure, however, we use a RAW surface so we can reuse existing untyped read/write/atomic messages which include a pixel mask header that we need to set to obtain correct behavior with helper invocations of the fra

[Mesa-dev] [PATCH v2 29/82] glsl: Do constant folding on ir_ssbo_store

We have ir_rvalues for various fields within ir_ssbo_store, so we want constant folding to know about them. Specifically, the offset of the store operation can be computed as the addition of a constant offset and a constant base offset, so we want that constant addition replaced with its constant r

[Mesa-dev] [PATCH v2 03/82] nir: add nir_var_shader_storage

--- src/glsl/nir/glsl_to_nir.cpp | 4 src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_lower_atomics.c | 3 ++- src/glsl/nir/nir_lower_io.c | 9 ++--- src/glsl/nir/nir_print.c | 5 +++-- src/glsl/nir/nir_validate.c | 6 -- 6 files changed, 20 insertions(+

[Mesa-dev] [PATCH v2 36/82] glsl: add support for unsized arrays in shader storage blocks

From: Samuel Iglesias Gonsalvez They only can be defined in the last position of the shader storage blocks. When an unsized array is used in different shaders, it might be converted in different sized arrays, avoid get a linker error in that case. Signed-off-by: Samuel Iglesias Gonsalvez ---

[Mesa-dev] [PATCH v2 34/82] i965: handle visiting of ir_var_shader_storage variables

--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index a2a75a4..13496a3 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visito

[Mesa-dev] [PATCH v2 13/82] glsl: buffer variables cannot be defined outside interface blocks

From: Samuel Iglesias Gonsalvez Section 4.3.7 "Buffer Variables", GLSL 4.30 spec: "Buffer variables may only be declared inside interface blocks (section 4.3.9 “Interface Blocks”), which are then referred to as shader storage blocks. It is a compile-time error to declare buffer variables at glob

[Mesa-dev] [PATCH v2 27/82] mesa: Add new IR node ir_ssbo_store

Shader storage buffer objects (SSBO) require special handling: when we detect writes to any channel of a shader buffer variable we need to emit the corresponding write to memory. We will later add a lowering pass that detects these writes and injects ir_ssbo_store nodes in the IR so drivers can ge

[Mesa-dev] [PATCH v2 18/82] mesa: Implement _mesa_BindBuffersRange for target GL_SHADER_STORAGE_BUFFER

--- src/mesa/main/bufferobj.c | 110 ++ 1 file changed, 110 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index c8b29a7..70ac638 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -3579,6 +3579,1

[Mesa-dev] [PATCH v2 35/82] i965/fs: Do not split buffer variables

Buffer variables are the same as uniforms, only that read/write, so we want the same treatment. --- src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp b/src/mesa/drivers/dri/i965/brw_fs_ve

[Mesa-dev] [PATCH v2 31/82] i965: Implement DriverFlags.NewShaderStorageBuffer

We use the same dirty state for SSBOs and UBOs because they share the same infrastructure. --- src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.

[Mesa-dev] [PATCH v2 22/82] glsl: Do not kill dead assignments to buffer variables or SSBO declarations.

If we kill dead assignments we lose the buffer writes. Also, we never kill UBO declarations even if they are never referenced by the shader, they are always considered active. Although the spec does not seem say this specifically for SSBOs, it is probably implied since SSBOs are pretty much the sa

[Mesa-dev] [PATCH v2 38/82] nir: add shader storage buffer's unsized array length calculation

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/nir/glsl_to_nir.cpp | 10 ++ src/glsl/nir/nir_intrinsics.h | 9 + 2 files changed, 19 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index f80481b..d2

[Mesa-dev] [PATCH v2 28/82] glsl: Lower shader storage buffer object writes to ir_ssbo_store

Extend the existing lower_ubo_reference pass to also detect SSBO writes and lower them to ir_ssbo_store nodes. --- src/glsl/lower_ubo_reference.cpp | 421 ++- 1 file changed, 287 insertions(+), 134 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/sr

[Mesa-dev] [PATCH v2 14/82] glsl: fix error messages in invalid declarations of shader storage blocks

From: Samuel Iglesias Gonsalvez Due to GL_ARB_shader_storage_buffer_object extension, shader storage blocks have the same limitations as uniform blocks. This patch fixes the corresponding error messages. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ast_to_hir.cpp | 15 ---

[Mesa-dev] [PATCH v2 15/82] mesa: Initialize and free shader storage buffers

--- src/mesa/main/bufferobj.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index c5d4ada..a528787 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -836,6 +836,9 @@ _mesa_init_buffer_objects(

[Mesa-dev] [PATCH v2 32/82] i965: Set MaxShaderStorageBuffers for compute shaders

--- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 5d21747..dffb2d4 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++ b/src/mesa/drivers/dri/i965/brw_context

[Mesa-dev] [PATCH v2 26/82] glsl: Don't do copy propagation on buffer variables

Since the backing storage for these is shared we cannot ensure that the value won't change by writes from other threads. --- src/glsl/opt_copy_propagation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/opt_copy_propagation.cpp b/src/glsl/opt_copy_propagation.cpp

[Mesa-dev] [PATCH v2 17/82] mesa: Implement _mesa_BindBuffersBase for target GL_SHADER_STORAGE_BUFFER

--- src/mesa/main/bufferobj.c | 142 ++ src/mesa/main/mtypes.h| 7 +++ 2 files changed, 149 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0e762df..c8b29a7 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/me

[Mesa-dev] [PATCH v2 25/82] glsl: Don't do constant variable on buffer variables

Since the backing storage for these is shared we cannot ensure that the value won't change by writes from other threads. --- src/glsl/opt_constant_variable.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glsl/opt_constant_variable.cpp b/src/glsl/opt_constant_variable.cpp index

[Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

This includes the array of bindings, the current buffer bound to the GL_SHADER_STORAGE_BUFFER target and a set of general limits and default values for shader storage buffers. --- src/mesa/main/bufferobj.c | 5 + src/mesa/main/config.h| 2 ++ src/mesa/main/context.c | 6 ++ src/me

[Mesa-dev] [PATCH v2 12/82] glsl: shader buffer variables cannot have initializers

From: Samuel Iglesias Gonsalvez Section 4.3.7 "Buffer Variables" of the GLSL 4.30 spec: "Buffer variables cannot have initializers." Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ast_to_hir.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/

[Mesa-dev] [PATCH v2 56/82] nir: implement ir_binop_ssbo_load

--- src/glsl/nir/glsl_to_nir.cpp| 7 +-- src/glsl/nir/nir_intrinsics.h | 2 +- src/glsl/nir/nir_lower_phis_to_scalar.c | 2 ++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 647aa34..2fb4303

[Mesa-dev] [PATCH v2 63/82] nir: Add SSBO atomic operations

--- src/glsl/nir/glsl_to_nir.cpp | 58 +++ src/glsl/nir/nir_intrinsics.h | 12 + 2 files changed, 70 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index dd6bee4..4b31a76 100644 --- a/src/glsl/nir/glsl_to_nir

[Mesa-dev] [PATCH v2 76/82] main/tests: add ARB_shader_storage_buffer_object tokens to enum_strings

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/tests/enum_strings.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp index dc5fe75..be11482 100644 --- a

[Mesa-dev] [PATCH v2 58/82] nir: ignore an instruction's dest if it hasn't any

--- src/glsl/nir/glsl_to_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 2fb4303..dd6bee4 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -932,7 +932,8 @@ nir_visitor::ad

[Mesa-dev] [PATCH v2 57/82] i965/nir/fs: Implement SSBO reads

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 74 1 file changed, 74 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 186d77b..15c1500 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b

[Mesa-dev] [PATCH v2 73/82] glsl: Do not allow assignments to read-only variables

--- src/glsl/ast_to_hir.cpp | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index b26438c..19527b4 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -762,8 +762,15 @@ do_assignment(exec_list *instruct

[Mesa-dev] [PATCH v2 67/82] mesa: add glShaderStorageBlockBinding()

From: Samuel Iglesias Gonsalvez Defined in ARB_shader_storage_buffer_object extension. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/uniforms.c | 52 src/mesa/main/uniforms.h | 4 2 files changed, 56 insertions(+) diff --git

[Mesa-dev] [PATCH v2 68/82] mesa: Add queries for GL_SHADER_STORAGE_BUFFER

These handle querying the buffer name attached to a giving binding point as well as the start offset and size of that buffer. --- src/mesa/main/get.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 8a6c81a..240f2f

[Mesa-dev] [PATCH v2 48/82] glsl: a shader storage buffer must be smaller than the maximum size allowed

From: Samuel Iglesias Gonsalvez Otherwise, generate a link time error as per the ARB_shader_storage_buffer_object spec. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/glsl_types.cpp | 9 +++-- src/glsl/link_uniform_blocks.cpp | 17 + src/glsl/linker.cpp

[Mesa-dev] [PATCH v2 51/82] i965/fs: Do not include the header with a pixel mask in untyped read messages

We need our reads to provide well-defined results for all enabled channels even for helper invocations, which means that we should not use a pixel mask with them. --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 35 -

[Mesa-dev] [PATCH v2 45/82] glsl: propagate interface packing information to arrays of scalars, vectors.

From: Samuel Iglesias Gonsalvez Now std140 is not the only interface packing qualifier that can be used. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ast.h | 10 + src/glsl/ast_to_hir.cpp | 54 + src/glsl/glsl_types.cpp

[Mesa-dev] [PATCH v2 71/82] glsl: Apply memory qualifiers to buffer variables

--- src/glsl/ast_to_hir.cpp | 25 + src/glsl/glsl_types.h | 10 ++ 2 files changed, 35 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 77d8b9e..ab8eda7 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5495,

[Mesa-dev] [PATCH v2 61/82] glsl: Rename atomic counter functions

Shader Storage Buffer Object will add new atomic functions that are not associated with counters, so better have atomic counter-specific functions explicitly include the word "counter" in their names. --- src/glsl/builtin_functions.cpp | 30 +++--- 1 file changed, 15 insert

[Mesa-dev] [PATCH v2 53/82] nir: implement ir_ssbo_store

--- src/glsl/nir/glsl_to_nir.cpp | 18 +- src/glsl/nir/nir_intrinsics.h | 12 ++-- 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index d2c474a..647aa34 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +

[Mesa-dev] [PATCH v2 78/82] mesa: Add getters for the GL_ARB_shader_storage_buffer_object max constants

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 12 2 files changed, 13 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index cd2bde9..6a52356 100644 --- a

[Mesa-dev] [PATCH v2 44/82] glsl: Add parser/compiler support for std430 interface packing qualifier

From: Samuel Iglesias Gonsalvez This commit also adds functions to calculate std430 base alignment and sizes Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ast.h | 1 + src/glsl/ast_to_hir.cpp | 20 +-- src/glsl/ast_type.cpp| 1 + src/glsl

[Mesa-dev] [PATCH v2 47/82] glsl: add std430 interface packing support to ssbo writes and unsized array length

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/lower_ubo_reference.cpp | 64 +++- 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index

[Mesa-dev] [PATCH v2 64/82] i965/nir/fs: Implement SSBO atomics

--- src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 82 2 files changed, 83 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index a02912f..b87fef0 100644 --- a/src/mesa

[Mesa-dev] [PATCH v2 39/82] i965/vec4: Implement unsized array's length calculation

From: Samuel Iglesias Gonsalvez Notice that Skylake needs to include a header in the sampler message so it will need some tweaks to work there. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/lower_ubo_reference.cpp | 182 +++ src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH v2 60/82] glsl: atomic counters can be declared as buffer-qualified variables

From: Kristian Høgsberg --- src/glsl/ast_to_hir.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index d6097ba..77d8b9e 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2764,7 +2764,7 @@ apply_ty

[Mesa-dev] [PATCH v2 55/82] i965/vec4: Implement SSBO reads

--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 56 +- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index a2abc8f..dbdf0ac 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH v2 21/82] glsl: Don't do tree grafting on buffer variables

Otherwise we can lose writes into the buffers backing the variables. --- src/glsl/opt_tree_grafting.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/glsl/opt_tree_grafting.cpp b/src/glsl/opt_tree_grafting.cpp index d47613c..7f2ee6c 100644 --- a/src/glsl/opt_tree

[Mesa-dev] [PATCH v2 74/82] glsl: Do not allow reads from write-only variables

The error location won't be right, but fixing that would require to check for this as we process each type of AST node that can involve a variable read. --- src/glsl/ast_to_hir.cpp | 49 + 1 file changed, 49 insertions(+) diff --git a/src/glsl/ast_t

[Mesa-dev] [PATCH v2 49/82] glsl: number of active shader storage blocks must be within allowed limits

From: Samuel Iglesias Gonsalvez Notice that we should differentiate betweeb shader storage blocks and uniform blocks, since they have different limits. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/linker.cpp | 43 +++ 1 file changed, 39 insertio

[Mesa-dev] [PATCH v2 30/82] i965: Use 16-byte offset alignment for shader storage buffers

This is the same we do for other things like uniforms because it ensures optimal performance. --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 274a237..5d21747 10

[Mesa-dev] [PATCH v2 42/82] i965/wm: emit null buffer surfaces when null buffers are attached

From: Samuel Iglesias Gonsalvez Otherwise we can expect odd things to happen if, for example, we ask for the size of the attached buffer from shader code, since that might query this value from the surface we uploaded and get random results. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mes

[Mesa-dev] [PATCH v2 19/82] mesa: Implement _mesa_BindBufferBase for target GL_SHADER_STORAGE_BUFFER

--- src/mesa/main/bufferobj.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 70ac638..fb5331e 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -3092,6 +3092,37

[Mesa-dev] [PATCH v2 62/82] glsl: Add atomic functions from ARB_shader_storage_buffer_object

--- src/glsl/builtin_functions.cpp | 185 + 1 file changed, 185 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index f220b86..63706b8 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cp

[Mesa-dev] [PATCH v2 43/82] i965/wm: surfaces should have the API buffer size, not the drm buffer size

From: Samuel Iglesias Gonsalvez The returned drm buffer object has a size multiple of 4096 but that should not be exposed to the API user, which is working with a different size. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4 ++-- 1 file chan

[Mesa-dev] [PATCH v2 66/82] glsl: First argument to atomic functions must be a buffer variable

--- src/glsl/ast_function.cpp | 37 + 1 file changed, 37 insertions(+) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 1e77124..b1f1bea 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_function.cpp @@ -141,6 +141,31 @@ verify_i

[Mesa-dev] [PATCH v2 81/82] glsl: Consider active all elements of a shared/std140 block array

From: Antia Puentes Commmit 1ca25ab (glsl: Do not eliminate 'shared' or 'std140' blocks or block members) considers active 'shared' and 'std140' uniform blocks and uniform block arrays but did not include the block array elements. It was possible to have an active uniform block array without any

[Mesa-dev] [PATCH v2 59/82] i965: do not emit_bool_to_cond_code with ssbo load expressions

From: Kristian Høgsberg We do the same with ubo load expressions. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index db

[Mesa-dev] [PATCH v2 69/82] glsl: fix UNIFORM_BUFFER_START or UNIFORM_BUFFER_SIZE query when no buffer object is bound

From: Samuel Iglesias Gonsalvez According to ARB_uniform_buffer_object spec: "If the parameter (starting offset or size) was not specified when the buffer object was bound (e.g. if bound with BindBufferBase), or if no buffer object is bound to , zero is returned." Signed-off-by: Samuel Iglesi

[Mesa-dev] [PATCH v2 54/82] i965/nir/fs: Implement SSBO writes

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 70 1 file changed, 70 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 0cc6a4f..186d77b 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b

[Mesa-dev] [PATCH v2 52/82] i965/vec4: Implement SSBO writes

--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 140 - 1 file changed, 138 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 95f6209..a2abc8f 100644 --- a/src/mesa/drivers/

[Mesa-dev] [PATCH v2 50/82] glsl: ignore buffer variables when counting uniform components

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/link_uniforms.cpp | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 715a8d5..b4b1181 100644 --- a/src/glsl/lin

[Mesa-dev] [PATCH v2 80/82] docs: Mark ARB_shader_storage_buffer_object as done for i965.

--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f2d06f1..18d61d7 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -164,7 +164,7 @@ GL 4.3, GLSL 4.30: GL_ARB_program_interface_query DONE (all drivers)

[Mesa-dev] [PATCH v2 40/82] i965/fs: Implement generator code for unsized array's length calculation

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs.h | 3 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 47

[Mesa-dev] [PATCH v2 37/82] glsl: Add parser/compiler support for unsized array's length()

From: Samuel Iglesias Gonsalvez It also creates unop and triop expressions to tell the driver to calculate the unsized array length. It is needed two expressions to do the calculation: * The unop expression saves the ir_rvalue* whose length should be calculated. * Afterwards, this unop is goi

[Mesa-dev] [PATCH v2 82/82] i965/vec4: Skip dependency control for opcodes emitting multiple instructions

The same we did for the fragment shader with commit 7452f18b. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp b/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp index 7a4bbb4..e6c63ca 100

[Mesa-dev] [PATCH v2 70/82] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

--- src/glsl/glsl_lexer.ll | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index 845deeb..82ad245 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -404,11 +404,11 @@ image2DShadow KEYWORD(13

[Mesa-dev] [PATCH v2 79/82] i965: Enable ARB_shader_storage_buffer_object extension for gen7+

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index cafb774..75ea75e 10064

[Mesa-dev] [PATCH v2 41/82] i965/fs/nir: implement unsized array's length calculation

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 51 1 file changed, 51 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH v2 65/82] i965/vec4: Implement SSBO atomics

--- src/mesa/drivers/dri/i965/brw_vec4.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 103 + 2 files changed, 104 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 5a6c66f..5dbe4b5 100644 --

[Mesa-dev] [PATCH v2 77/82] glapi: add ARB_shader_storage_block_buffer_object

From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- .../glapi/gen/ARB_shader_storage_buffer_object.xml | 36 ++ src/mapi/glapi/gen/GL4x.xml| 18 ++- src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/g

[Mesa-dev] [PATCH v2 75/82] main: Add SHADER_STORAGE_BLOCK and BUFFER_VARIABLE support for ARB_program_interface_query

From: Samuel Iglesias Gonsalvez Including TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE queries. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ir_uniform.h| 5 + src/glsl/link_uniforms.cpp | 16 ++- src/glsl/linker.cpp | 10 +- src/mesa/main/program

[Mesa-dev] [PATCH v2 46/82] glsl: propagate std430 packing qualifier to struct's members and array of structs

From: Samuel Iglesias Gonsalvez When propagating std430 packing qualifier to the struct's members, new glsl_types need to be created because the existing ones are const. The new glsl_types are meant to replace the already defined one taking into account that the field names cannot have different

[Mesa-dev] [PATCH v2 72/82] glsl: Allow memory layout qualifiers on shader storage buffer objects

Since memory qualifiers are also keywords we need to do the same trick we use for other keywords that can be used as layout qualifiers to handle alternate capitalizations in desktop GLSL, like row_major, etc. --- src/glsl/ast_to_hir.cpp | 31 src/glsl/glsl_parser.yy | 75 +

Re: [Mesa-dev] [PATCH resend 7/7] i965: Disable HW-binding tables on batch finish for Broadwell

On 06/02/2015 08:28 PM, Kenneth Graunke wrote: > On Tuesday, June 02, 2015 03:23:35 PM Abdiel Janulgue wrote: >> >> On 06/02/2015 09:31 AM, Kenneth Graunke wrote: >>> On Monday, June 01, 2015 03:14:30 PM Abdiel Janulgue wrote: This is needed since kernel doesn't support RS context save and >>

Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

On Tuesday, June 02, 2015 11:41:56 PM Ben Widawsky wrote: > On Tue, 02 Jun 2015 20:32:13 -0700 > Kenneth Graunke wrote: > > > On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > > > I'm very confused here. It seems pretty clear that since the > > > command has been introduced with support

Re: [Mesa-dev] [PATCH resend 7/7] i965: Disable HW-binding tables on batch finish for Broadwell

On Wed, Jun 03, 2015 at 10:05:25AM +0300, Abdiel Janulgue wrote: > > On 06/02/2015 08:28 PM, Kenneth Graunke wrote: > > On Tuesday, June 02, 2015 03:23:35 PM Abdiel Janulgue wrote: > >> > >> On 06/02/2015 09:31 AM, Kenneth Graunke wrote: > >>> On Monday, June 01, 2015 03:14:30 PM Abdiel Janulgue w

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/6] clover: Call clBuildProgram() notification function when build completes v2

Hi Tom, On 31 March 2015 at 15:29, Francisco Jerez wrote: > Tom Stellard writes: > >> v2: >> - Only call notification for build errors >> - Fix clCompileProgram() >> >> Cc: 10.5 10.4 >> --- >> src/gallium/state_trackers/clover/api/program.cpp | 16 ++-- >> 1 file changed, 14 in

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00

Hi Tapani, On 19 May 2015 at 13:01, Tapani Pälli wrote: > Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. > Earlier versions allow 'constant-index-expression' indexing, where > index can contain a loop induction variable. > > Patch allows dynamic indexing for sampler arrays when

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: set the binding value regardless explicit_binding

Hello gents, On 21 May 2015 at 14:03, Timothy Arceri wrote: > On Thu, 2015-05-21 at 12:22 +0200, Alejandro Piñeiro wrote: >> >> On 20/05/15 23:39, Timothy Arceri wrote: >> > On Thu, 2015-05-14 at 22:49 +0200, Alejandro Piñeiro wrote: >> >> On 14/05/15 20:38, Ian Romanick wrote: >> >>> >> >>> I th

Re: [Mesa-dev] [PATCH] llvmpipe: Implement stencil export

Looks perfect. Thanks! Jose On 03/06/15 00:35, srol...@vmware.com wrote: From: Roland Scheidegger Pretty trivial, fixes the issue that we're expected to be able to blit stencil surfaces (as the blit just relies on util blitter code which needs stencil export to do it). 2 piglits skip->pass, 1

Re: [Mesa-dev] [PATCH] i965/fs: Use UW-typed immediate in multiply inst.

Looks good to me. Thanks for fixing this. I guess I still have more to learn about the ISA. However, should we not also fix the vec4 version? With that, Reviewed-by: Neil Roberts If we wanted to play safe and avoid the MUL, we could change it to this and still avoid having a temporary: /

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: set the binding value regardless explicit_binding

On 03/06/15 13:17, Emil Velikov wrote: > Hello gents, > > On 21 May 2015 at 14:03, Timothy Arceri wrote: >> On Thu, 2015-05-21 at 12:22 +0200, Alejandro Piñeiro wrote: >>> On 20/05/15 23:39, Timothy Arceri wrote: On Thu, 2015-05-14 at 22:49 +0200, Alejandro Piñeiro wrote: > On 14/05/15

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/6] clover: Call clBuildProgram() notification function when build completes v2

Emil Velikov writes: > Hi Tom, > > On 31 March 2015 at 15:29, Francisco Jerez wrote: >> Tom Stellard writes: >> >>> v2: >>> - Only call notification for build errors >>> - Fix clCompileProgram() >>> >>> Cc: 10.5 10.4 >>> --- >>> src/gallium/state_trackers/clover/api/program.cpp | 16 +

[Mesa-dev] [PATCH v2 80/82] docs: Mark ARB_shader_storage_buffer_object as done for i965.

Hi, I think it is common to also add a small note in the release notes for things like this? --Thomas On Jun 3, 2015 09:03, "Iago Toral Quiroga" wrote: > > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index f2d06f1..1

[Mesa-dev] New stable-branch 10.5 candidate pushed

Hello list, The candidate for the Mesa 10.5.7 is now available. Currently we have: - 24 queued - 7 nominated (outstanding) - and 2 rejected (obsolete) patches The present queue consist of over a dozen nouveau fixes (mostly targeting nv30/nv40 era hardware), i965 patches and a crash fix that co

Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

On Wed, Jun 03, 2015 at 12:20:09AM -0700, Kenneth Graunke wrote: > On Tuesday, June 02, 2015 11:41:56 PM Ben Widawsky wrote: > > On Tue, 02 Jun 2015 20:32:13 -0700 > > Kenneth Graunke wrote: > > > > > On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > > > > I'm very confused here. It see

Re: [Mesa-dev] [PATCH] i965/fs: Use UW-typed immediate in multiply inst.

On Wed, Jun 03, 2015 at 01:09:50PM +0100, Neil Roberts wrote: > Looks good to me. Thanks for fixing this. I guess I still have more to > learn about the ISA. > > However, should we not also fix the vec4 version? With that, > > Reviewed-by: Neil Roberts > > If we wanted to play safe and avoid th

Re: [Mesa-dev] [PATCH resend 7/7] i965: Disable HW-binding tables on batch finish for Broadwell

On Wed, Jun 03, 2015 at 12:45:12PM +0300, Ville Syrjälä wrote: > On Wed, Jun 03, 2015 at 10:05:25AM +0300, Abdiel Janulgue wrote: > > > > On 06/02/2015 08:28 PM, Kenneth Graunke wrote: > > > On Tuesday, June 02, 2015 03:23:35 PM Abdiel Janulgue wrote: > > >> > > >> On 06/02/2015 09:31 AM, Kenneth

Re: [Mesa-dev] [PATCH] i965/fs: Use UW-typed immediate in multiply inst.

On Wed, Jun 3, 2015 at 5:09 AM, Neil Roberts wrote: > Looks good to me. Thanks for fixing this. I guess I still have more to > learn about the ISA. > > However, should we not also fix the vec4 version? With that, > > Reviewed-by: Neil Roberts Yes, I'll do that too. I started to... and then notic

[Mesa-dev] Mesa 10.6.0 release candidate 3

The third release candidate for Mesa 10.6.0 is now available. The release "hides" the ARB_direct_state_access extension from legacy (Compatibility profile) GL contexts, plus addresses bugs in the i965 and other dri modules. Note: The final 10.6.0 release (planned for 5th of June) will be delayed

  1   2   >