https://bugs.freedesktop.org/show_bug.cgi?id=90249
Julien Isorce changed:
What|Removed |Added
CC||i...@freedesktop.org
--
You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=90213
Juha-Pekka Heikkilä changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=90310
Bug ID: 90310
Summary: Fails to build gallium_dri.so at linking stage with
clang because of multiple redefinitions
Product: Mesa
Version: git
Hardware: Other
https://bugs.freedesktop.org/show_bug.cgi?id=90311
Bug ID: 90311
Summary: Fail to build libglx with clang at linking stage
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
On 05/05/15 00:08, Matt Turner wrote:
> On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> Commit 7e414b58640aee6e243d337e72cea290c354f632 broke the gl_FragData array
>> into separate gl_FragData[i] variables, so drivers can eliminate useless
>>
On 05/05/15 01:03, Matt Turner wrote:
> On Tue, Feb 24, 2015 at 10:02 AM, Eduardo Lima Mitev wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> If the named uniform block is an array declared with a shared or
>> std140 layout qualifier and no shader instruction has referenced it,
>> then it is nev
On 05/05/15 00:54, Matt Turner wrote:> On Tue, Feb 24, 2015 at 10:02 AM,
Eduardo Lima Mitev wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> When a transform feedback object is bound and not active, the OpenGL ES
>> 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its
>> deletio
I didn't find this being used anywhere.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/hash.c | 28
src/mesa/main/hash.h | 3 ---
2 files changed, 31 deletions(-)
diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index d04cccd..315b5d6 100644
--- a/src
Just simple Klocwork found issues.
/Juha-Pekka
Juha-Pekka Heikkila (3):
mesa/main: Remove _mesa_HashClone()
mesa/main: avoid null access in format_array_table_init()
mesa/main: check for null in invalid_array_element_syntax()
src/mesa/main/formats.c | 10 ++
src/mesa/main
If _mesa_hash_table_create failed we'd get null pointer. Report
error and go away.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/formats.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c
index 8af44e9..f7c9402 100644
--- a/
name string is coming through API call, need to be careful with it.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/program_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c
index b15a132..28918
This is a resend, the earlier set seem to have gone into void.
This set was collected with intentionally failing at context
creation and then fixing all the places where segfault resulted.
Some of the places where null is being checked are a bit funny
but its only because during first time context
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/program/prog_cache.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/mesa/program/prog_cache.c b/src/mesa/program/prog_cache.c
index ed93af7..eef5339 100644
--- a/src/mesa/program/prog_cache.c
+++ b/src/mesa
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/texstate.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c
index 1af9d47..d133104 100644
--- a/src/mesa/main/texstate.c
+++ b/src/mesa/main/texstate.c
@@ -936,8 +936,
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_state_cache.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_state_cache.c
b/src/mesa/drivers/dri/i965/brw_state_cache.c
index 157b33d..f56fd85 100644
--- a/src/mes
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/common/meta.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
index d2ab7b8..b2cb0d5 100644
--- a/src/mesa/drivers/common/meta.c
+++ b/src/mesa/drivers/common/meta.c
@@ -
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/pipelineobj.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c
index 0fefa7d..73a6af8 100644
--- a/src/mesa/main/pipelineobj.c
+++ b/src/mesa/main/pipelineobj
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/transformfeedback.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/transformfeedback.c
b/src/mesa/main/transformfeedback.c
index 103011c..cbf8598 100644
--- a/src/mesa/main/transformfeedback.c
++
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/varray.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index 42e7f89..b65e6ef 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray.c
@@ -1978,6 +1978,8 @@ del
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/queryobj.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index fbccf3f..3adea35 100644
--- a/src/mesa/main/queryobj.c
+++ b/src/mesa/main/queryobj.c
@@ -999,6 +999,
If there was memory allocation failure have to return away from
brw_new_buffer_object
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/intel_buffer_objects.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
b/src/mesa/drivers/d
I guess this should not really be able to segfault but still it
seems to be able to during context creation.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/errors.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/errors.c b/src
Stop context creation if something failed. If something errored
during context creation we'd segfault. Now will clean up and
return error.
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/shared.c | 66 +++---
1 file changed, 62 insertions(+), 4 de
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/performance_monitor.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/performance_monitor.c
b/src/mesa/main/performance_monitor.c
index 2d740da..292086c 100644
--- a/src/mesa/main/performance_monitor.c
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/main/hash.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index d04cccd..533b1d1 100644
--- a/src/mesa/main/hash.c
+++ b/src/mesa/main/hash.c
@@ -152,7 +152,8 @@ _mesa_NewHashTable(
We can do this when the surface index is an immediate, as we do for
reads. Otherwise the visitor should handle this.
---
Francisco, maybe you choose not to do this for a reason? It seems a bit
inconsistent with the reads though. Also, other read/write messages seem
to mark surfaces in the generator
https://bugs.freedesktop.org/show_bug.cgi?id=28130
marius predut changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |marius.pre...@intel.com
Iago Toral Quiroga writes:
> We can do this when the surface index is an immediate, as we do for
> reads. Otherwise the visitor should handle this.
> ---
> Francisco, maybe you choose not to do this for a reason? It seems a bit
> inconsistent with the reads though. Also, other read/write messages
Hi all,
On 16 April 2015 at 21:06, Daniel Stone wrote:
> Hi,
>
> On 9 April 2015 at 17:20, Kristian Høgsberg wrote:
>> On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov
>> wrote:
>>> Hi all,
>>>
>>> Can we get a pair of eyes on this patch please ?
>>
>> Reviewed-by: Kristian Høgsberg
>>
>> Thanks
On 4 May 2015 at 18:11, Ilia Mirkin wrote:
> On Mon, May 4, 2015 at 12:47 PM, Tom Stellard wrote:
>> On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote:
>>> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote:
>>> > On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote:
>>> >> On
Hi Ian,
On 15 April 2015 at 19:36, Ian Romanick wrote:
> From: Ian Romanick
>
> In response to another patch, Emil asked for some clarification how this
> stuff works. Rather than just reply to the e-mail, I decided to update
> the exlanation in the code.
>
Upon a closer look "supported" seems
Hi Ian,
On 30 April 2015 at 00:26, Ian Romanick wrote:
> From: Ian Romanick
>
> The bulk of the change is to prevent overriding the context to
> API_OPENGL_CORE based on the requested version. If the context is
> API_OPENGL_ES2, don't change it.
>
Wouldn't it be better if one just uses another
On Tue, May 05, 2015 at 03:48:29PM +0100, Emil Velikov wrote:
> On 4 May 2015 at 18:11, Ilia Mirkin wrote:
> > On Mon, May 4, 2015 at 12:47 PM, Tom Stellard wrote:
> >> On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote:
> >>> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote:
> >>> >
On Tue, May 5, 2015 at 11:42 AM, Tom Stellard wrote:
>> > How about this -- get rid of --enable-opencl-icd and change it to
>> > --with-opencl-icd-dir where you must supply a directory if you want to
>> > use it. That way if you want the system one, you'd say
>> > /etc/OpenCL/vendors, if you want
On 1 May 2015 at 15:53, Chris Wilson wrote:
> * where is the doubly-linked circular list?
IIRC there was some patches from Jason, that move the the gallium one
to src/util/list.h [1]. Not sure on the status of it though. On a
related note - would be great if one day we nuke the glsl one
(exec_no
On Tue, May 5, 2015 at 3:50 AM, Juha-Pekka Heikkila
wrote:
> Just simple Klocwork found issues.
>
> /Juha-Pekka
>
> Juha-Pekka Heikkila (3):
> mesa/main: Remove _mesa_HashClone()
> mesa/main: avoid null access in format_array_table_init()
> mesa/main: check for null in invalid_array_element_
On 5 May 2015 at 16:42, Tom Stellard wrote:
> On Tue, May 05, 2015 at 03:48:29PM +0100, Emil Velikov wrote:
>> On 4 May 2015 at 18:11, Ilia Mirkin wrote:
>> > On Mon, May 4, 2015 at 12:47 PM, Tom Stellard wrote:
>> >> On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote:
>> >>> On Mon, Ma
On Tue, May 5, 2015 at 4:25 AM, Juha-Pekka Heikkila
wrote:
> This is a resend, the earlier set seem to have gone into void.
>
> This set was collected with intentionally failing at context
> creation and then fixing all the places where segfault resulted.
> Some of the places where null is being c
On Tuesday, May 05, 2015 01:50:59 PM Juha-Pekka Heikkila wrote:
> name string is coming through API call, need to be careful with it.
>
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/program_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa
Kenneth Graunke writes:
> On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote:
>> ---
>> src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++
>> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 9 +
>> 2 files changed, 19 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/
Jason Ekstrand writes:
> On Sat, May 2, 2015 at 8:29 AM, Francisco Jerez wrote:
>> The purpose of this change is threefold: First, it improves the
>> modularity of the compiler back-end by separating the functionality
>> required to construct an i965 IR program from the rest of the visitor
>> go
Jason Ekstrand writes:
> +#define list_for_each_entry(type, pos, head, member)\
> + for (type *pos = container_of((head)->next, pos, member);\
> + &pos->member != (head); \
> + pos = container_of(pos->member.next, p
Jason Ekstrand writes:
> +static inline bool list_empty(struct list_head *list)
> +{
> + return list->next == list;
> +}
It would be good if list.h also included stdbool.h in order to get the
declaration of bool. However, will that cause problems on MSVC? Is the
Gallium code compiled on MSVC i
Jason Ekstrand writes:
> +static inline void list_validate(struct list_head *list)
> +{
> + assert(list->next->prev == list && list->prev->next == list);
> + for (struct list_head *node = list->next; node != list; node = node->next)
> + assert(node->next->prev == node && node->prev->next
On Tue, May 5, 2015 at 11:25 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
>> +static inline void list_validate(struct list_head *list)
>> +{
>> + assert(list->next->prev == list && list->prev->next == list);
>> + for (struct list_head *node = list->next; node != list; node =
>> node->n
On Tue, May 5, 2015 at 11:21 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
>> +static inline bool list_empty(struct list_head *list)
>> +{
>> + return list->next == list;
>> +}
>
> It would be good if list.h also included stdbool.h in order to get the
> declaration of bool. However, will t
On Tue, May 5, 2015 at 11:13 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
>> +#define list_for_each_entry(type, pos, head, member)\
>> + for (type *pos = container_of((head)->next, pos, member);\
>> + &pos->member != (head);
On 05/05/2015 12:21 PM, Neil Roberts wrote:
Jason Ekstrand writes:
+static inline bool list_empty(struct list_head *list)
+{
+ return list->next == list;
+}
It would be good if list.h also included stdbool.h in order to get the
declaration of bool. However, will that cause problems on MSVC
On Wednesday, April 01, 2015 06:19:11 PM Jason Ekstrand wrote:
> This patch series comes with two apologies. First, is for the fact that
> most of it has to be squashed into a single super-commit. Unfortunately,
> this is one of those things that can't really be done incrementally.
> Second, is f
On Wed, Apr 1, 2015 at 6:19 PM, Jason Ekstrand wrote:
> This allows us to get rid of the visitor argument in is_copy_payload
> ---
> src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965
On Tue, May 5, 2015 at 12:22 PM, Matt Turner wrote:
> On Wed, Apr 1, 2015 at 6:19 PM, Jason Ekstrand wrote:
>> This allows us to get rid of the visitor argument in is_copy_payload
>> ---
>> src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 10 +-
>> 1 file changed, 5 insertions(+)
On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke wrote:
> On Wednesday, April 01, 2015 06:19:15 PM Jason Ekstrand wrote:
>> This allows us to combine code in CSE and register coalesce
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++
>> src/mesa/drivers/dri/i96
---
src/glsl/nir/nir_intrinsics.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h
index 4b13c75..3e053b3 100644
--- a/src/glsl/nir/nir_intrinsics.h
+++ b/src/glsl/nir/nir_intrinsics.h
@@ -68,6 +68,13 @@ INTRINSIC(interp_var_a
---
src/glsl/nir/nir_lower_atomics.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c
index e82df01..f6f8902 100644
--- a/src/glsl/nir/nir_lower_atomics.c
+++ b/src/glsl/nir/nir_lower_atomics.c
@@ -78,7 +78,8
---
src/glsl/nir/nir_intrinsics.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h
index 8e28765..4b13c75 100644
--- a/src/glsl/nir/nir_intrinsics.h
+++ b/src/glsl/nir/nir_intrinsics.h
@@ -89,6 +89,33 @@
---
src/glsl/nir/glsl_to_nir.cpp | 125 +++
1 file changed, 114 insertions(+), 11 deletions(-)
diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
index f6b8331..a01ab3b 100644
--- a/src/glsl/nir/glsl_to_nir.cpp
+++ b/src/glsl/nir/glsl_
---
src/glsl/nir/glsl_to_nir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
index a01ab3b..b4ab4ee 100644
--- a/src/glsl/nir/glsl_to_nir.cpp
+++ b/src/glsl/nir/glsl_to_nir.cpp
@@ -634,6 +634,8 @@ nir_visitor::visit(ir_call *i
On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand wrote:
> On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke
> wrote:
>> 2. CSE didn't use equals(), so it allowed things like types to differ,
>>or source modifiers...(which are probably bogus on LOAD_PAYLOADs
>>anyway, so it may be moot...)
>
https://bugs.freedesktop.org/show_bug.cgi?id=90325
Bug ID: 90325
Summary: No static entry point for glQueryCounter and other
entry points in ARB_timer_query
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #1 from nmcve...@gmail.com ---
Created attachment 11
--> https://bugs.freedesktop.org/attachment.cgi?id=11&action=edit
Simple program that demonstrates problem
--
You are receiving this mail because:
You are the QA Contact
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #2 from nmcve...@gmail.com ---
Created attachment 115556
--> https://bugs.freedesktop.org/attachment.cgi?id=115556&action=edit
glxinfo output
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the a
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #3 from nmcve...@gmail.com ---
Created attachment 115558
--> https://bugs.freedesktop.org/attachment.cgi?id=115558&action=edit
Possible fix for the problem
--
You are receiving this mail because:
You are the QA Contact for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #4 from nmcve...@gmail.com ---
Looking at gl_API.xml, it appears to me that static_dispatch="false" should
have been removed when the 3.3 support was added. If I remove static_dispatch
from the functions in the ARB_timer_query category
https://bugs.freedesktop.org/show_bug.cgi?id=90325
nmcve...@gmail.com changed:
What|Removed |Added
CC||nmcve...@gmail.com
--
You are recei
https://bugs.freedesktop.org/show_bug.cgi?id=90311
--- Comment #1 from Julien Isorce ---
The exact error is:
CCLD libGL.la
clang: warning: argument unused during compilation: '-pthread'
Undefined symbols for architecture x86_64:
"_driDispatchRemapTable", referenced from:
_apple_glapi
https://bugs.freedesktop.org/show_bug.cgi?id=90310
Julien Isorce changed:
What|Removed |Added
CC||emil.l.veli...@gmail.com
--
You are rec
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #5 from Emil Velikov ---
This might come a bit harsh, but what makes you think that libGL should provide
static entry points for the said symbols ? Iirc EGL 1.4 had some strange thing
where, core profile functions should be made avail
Kenneth Graunke writes:
> On Saturday, May 02, 2015 06:29:27 PM Francisco Jerez wrote:
>> This v2 is motivated by the less than enthusiastic reception of my
>> last two series implementing the image load, store and atomic
>> intrinsics in the i965 back-end. It substitutes both.
>>
>> The built-
On Tue, May 5, 2015 at 1:34 PM, Matt Turner wrote:
> On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand wrote:
>> On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke
>> wrote:
>>> 2. CSE didn't use equals(), so it allowed things like types to differ,
>>>or source modifiers...(which are probably bo
This resend drops the GLSL IR implementation of the image built-ins as
requested by Ken, and adds a NIR implementation. It depends on the
series sent earlier today adding support for image intrinsics to NIR.
For a branch in a testable form see:
http://cgit.freedesktop.org/~currojerez/mesa/log/?h=i
Until now atomic counter built-ins were handled in a way that
prevented the GLSL visitor from encountering atomic counter IR
variables directly. This makes the handling of atomic counters
consistent with other kinds of GLSL variable dereferences.
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
See "i965/fs: Introduce FS IR builder." for the rationale.
v2: Drop scalarizing VEC4 builder.
---
src/mesa/drivers/dri/i965/Makefile.sources | 1 +
src/mesa/drivers/dri/i965/brw_vec4_builder.h | 579 +++
2 files changed, 580 insertions(+)
create mode 100644 src/mesa/d
These are going to be used to convert an array_reg (chunk of the
register space without fancy regioning parameters) back to a normal
FS/VEC4 register.
---
src/mesa/drivers/dri/i965/brw_fs.cpp| 6 ++
src/mesa/drivers/dri/i965/brw_ir_fs.h | 1 +
src/mesa/drivers/dri/i965/brw_ir_vec4.h |
These functions implement the memory layout of a vecN value in a
message or return payload. The conversion is not always trivial
because the shared unit may not support the SIMD16 or SIMD4x2 vector
layouts, requiring splitting the payload in half and merging the reply
in the former case, or spread
Until now atomic counter built-ins were handled in a way that
prevented the GLSL visitor from encountering atomic counter IR
variables directly. This makes the handling of atomic counters
consistent with other kinds of GLSL variable dereferences.
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |
The purpose of this change is threefold: First, it improves the
modularity of the compiler back-end by separating the functionality
required to construct an i965 IR program from the rest of the visitor
god-object, what in turn will reduce the coupling between other
components and the visitor allowi
Define a few transformations on register arrays which will be used
frequently during the construction of typed and untyped surface
message payloads. Their purpose is simple but the implementation is
rather messy, so it makes a lot of sense to factor them out as
separate functions.
v2: Drop VEC4 s
Define some utility functions to query the bitfield layout of a given
image format and whether it satisfies a number of more or less
hardware-specific properties.
v2: Drop VEC4 suport.
---
src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 147 +
1 file changed, 147 insertio
v2: Update NIR atomic intrinsic handling too (Ken).
Reviewed-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8 ++--
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 +++
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4
src/mesa/drivers/dri/i965/brw_v
Implement helper functions that can be used to construct and send
untyped and typed surface read, write and atomic messages to the
shared dataport unit.
v2: Drop VEC4 suport.
---
.../drivers/dri/i965/brw_fs_surface_builder.cpp| 232 +
src/mesa/drivers/dri/i965/brw_fs_surfa
Define a function to calculate the memory address of the image
location given by a vector of coordinates. This is required in cases
where we need to fall back to untyped surface access, which take a raw
memory offset and know nothing about surface coordinates, type
conversion or memory tiling and
Define bitfield packing, unpacking and type conversion operations in
terms of which the image format conversion code will be implemented.
These don't directly know about image formats: The packing and
unpacking functions take a 4-tuple of bit shifts and a 4-tuple of bit
widths as arguments, determi
Was missing the context parameter. Fixes MSVC warning.
---
src/mesa/state_tracker/st_cb_perfmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_cb_perfmon.c
b/src/mesa/state_tracker/st_cb_perfmon.c
index 4bde679..c8d4490 100644
--- a/src/mesa/state
Rewrite the NIR atomic counter intrinsics translation code making use
of the recently introduced surface builder. This will allow the
removal of some of the functionality duplicated in the visitor and
surface builder.
v2: Drop VEC4 suport.
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 56 ++
These utility functions check whether an image access is valid.
According to the spec an invalid image access should have no effect on
the image and yield well-defined results. Typically the hardware
implements correct bounds and surface checking by itself, but in some
cases (typed atomics on IVB
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 158 +++
1 file changed, 158 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index a166e59..497b8f7 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++
Rewrite the GLSL IR atomic counter intrinsics translation code making
use of the recently introduced surface builder. This will allow the
removal of some of the functionality duplicated in the visitor and
surface builder.
v2: Drop VEC4 suport.
---
src/mesa/drivers/dri/i965/brw_fs.h |
Fixes MSVC build error.
---
src/mesa/state_tracker/st_cb_perfmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_cb_perfmon.c
b/src/mesa/state_tracker/st_cb_perfmon.c
index c8d4490..1bb5be3 100644
--- a/src/mesa/state_tracker/st_cb_perfmon.c
+++ b/s
Silences gcc warning:
builtin_functions.cpp:204:23: warning: suggest parentheses around '&&'
within '||' [-Wparentheses]
---
src/glsl/builtin_functions.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index 1df6
v2: Drop VEC4 suport.
---
.../drivers/dri/i965/brw_fs_surface_builder.cpp| 216 +
src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 17 ++
2 files changed, 233 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp
b/src/mesa/drivers/dri/i965/
Image variables need to allocate additional uniform slots over
nir_shader::num_uniforms. nir_setup_uniforms() overwrites the values
imported from the SIMD8 visitor and then exits early before entering
the nir_shader::uniforms loop, so image uniforms are never re-created.
Instead leave the imported
---
src/mesa/drivers/dri/i965/brw_fs.h | 7 --
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 ++-
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 125 ++-
3 files changed, 10 insertions(+), 135 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
b
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 32
src/mesa/drivers/dri/i965/brw_shader.h | 2 ++
2 files changed, 34 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
b/src/mesa/drivers/dri/i965/brw_shader.cpp
index c1fd859..61ef0c0 100644
-
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 497b8f7..a774f98 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++ b/src/mesa/drivers/dri/i965/
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 889079b..1eaec10 100644
--- a/src/mesa/drivers/dri/i965/
---
src/mesa/drivers/dri/i965/brw_fs.h | 1 +
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 55 +++-
2 files changed, 48 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
b/src/mesa/drivers/dri/i965/brw_fs.h
index aac9c4b..4f7d95e 10064
Reviewed-by: Paul Berry
v2: Disable the extension for the time being if NIR is in use until it
grows the necessary intrinsics.
v3: Drop GLSL IR support. Disable the extension if NIR is *not* in use.
---
src/mesa/drivers/dri/i965/intel_extensions.c | 2 ++
1 file changed, 2 insertions(+)
di
Images take up zero uniform slots in the nir_shader::num_uniforms
calculation, but nir_setup_uniforms needs to be executed even if the
program has no non-image uniforms so the driver-specific image
parameters are uploaded. nir_setup_uniforms is a no-op if there are
really no uniforms, so checking
https://bugs.freedesktop.org/show_bug.cgi?id=90147
--- Comment #2 from Julien Isorce ---
Created attachment 115565
--> https://bugs.freedesktop.org/attachment.cgi?id=115565&action=edit
swrast: Build fix for darwin
Other solution from macports.
--
You are receiving this mail because:
You are
https://bugs.freedesktop.org/show_bug.cgi?id=90325
--- Comment #6 from nmcve...@gmail.com ---
QueryCounters was an extension but it was added to the core profile in 3.3, you
can see it right there in section 5.1
(https://www.opengl.org/registry/doc/glspec33.core.20100311.withchanges.pdf).
--
You
1 - 100 of 176 matches
Mail list logo
