The piglit test glsl-fs-uniform-array-loop-unroll.shader_test was designed
to do an out of bounds access into an uniform array to make sure that we
handle that situation gracefully inside the driver, however, as Ken describes
in bug 79202, Valgrind reports that this is leading to an out-of-bounds a
This especially helps with NIR because we currently emit MOVs at the top
of the shader to copy from various ATTR registers to a giant VGRF array
of all inputs. (This could potentially be done better, but since
there's only ever one write to each register, it should be trivial to
copy propagate awa
OK. What about patches 8 an 9?
Marek
On Thu, Mar 5, 2015 at 8:30 PM, Tom Stellard wrote:
> On Mon, Mar 02, 2015 at 12:54:21PM +0100, Marek Olšák wrote:
>> From: Marek Olšák
>>
>
> Hi Marek,
>
> After discussing with Matt, I think we should use LLVM IR rather than
> intrinsics for IBFE and UBFE
On Tue, Mar 10, 2015 at 12:42:38PM +0100, Marek Olšák wrote:
> OK. What about patches 8 an 9?
>
I think the intrinsics in 9 are OK, but 8 should be using LLVM IR.
-Tom
> Marek
>
> On Thu, Mar 5, 2015 at 8:30 PM, Tom Stellard wrote:
> > On Mon, Mar 02, 2015 at 12:54:21PM +0100, Marek Olšák wro
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/intel_blit.c| 11 ++-
> src/mesa/drivers/dri/i965/intel_blit.h| 3 +++
> src/mesa/drivers/dri/i965/intel_copy_image.c | 7 ---
> src/mesa/drivers/dri
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> The blit engine in GEN hardware has constraints. These constraints are a
> function of tile parameters as well as height. The current code is very dumb
> in
> terms of determine max blit parameters. Since we'll be expanding on it, having
deter
Ben Widawsky writes:
> On Fri, Feb 20, 2015 at 10:31:08PM +, Neil Roberts wrote:
>> The render surface state command for Skylake doesn't have the surface
>> array spacing bit so I don't think it's possible to select this
>> layout. This avoids a kernel panic when running the piglit test below
Hi Ishara,
On 9 March 2015 at 07:18, Ishara Abeysekera wrote:
> I am interested on write tests for OpenGL 4.0 /GLSL 4.00 .
>
> But can you be more specify what areas you are expecting to be tested,
>
Thanks for the interest. Are you planning to do this as a side
project, or as a GSoC or EVoC ?
W
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Ben Widawsky writes:
> This patch will use a new calculation to determine if a surface can be blitted
> from or to. Previously, the "total_height" member was used. Total_height in
> the
> case of 2d, 3d, and cube map arrays is the height of each slice/layer/face.
> Since the GL map APIS only eve
When uploading state for a pipeline, we will save changed state for
the other pipelines.
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/brw_context.h | 1 +
src/mesa/drivers/dri/i965/brw_state_upload.c | 41 ++--
2 files changed, 34 insertions(+), 8 dele
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/brw_context.h | 1 +
src/mesa/drivers/dri/i965/brw_state.h| 1 +
src/mesa/drivers/dri/i965/brw_state_upload.c | 28 ++--
3 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drive
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
src/mesa/drivers/dri/i965/brw_state.h| 2 +-
src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c
b/sr
The implementation of texture <-> pixel-buffer transfers in drivers common layer
includes certain error checks and argument validation that don't belong there,
considering how the Mesa codebase is laid out. These are higher level
validations that, if necessary, should be performed earlier (i.e, in
This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage family
of functions when a pixel buffer object is bound to GL_PIXEL_UNPACK_BUFFER:
- That the buffer is not mapped.
- The total data size is within the boundaries of the buffer size.
It does so by calling auxiliary validation
Internal PBO functions such as _mesa_map_validate_pbo_source() and
_mesa_validate_pbo_compressed_teximage() perform validation and buffer mapping
within the same call.
This patch takes out the validation into separate functions to allow reuse
of functionality by other code (i.e, gl(Compressed)Tex(
On Mon, Mar 9, 2015 at 11:06 PM, Matt Turner wrote:
> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke
> wrote:
> > From: Jason Ekstrand
> >
> > __next and __prev are pointers to the structure containing the exec_node
> > link, not the embedded exec_node. NULL checks would fail unless the
> > e
Humble ping?
2015-02-28 21:19 GMT+01:00 Matt Turner :
> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
> wrote:
>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand" wrote:
>>>
>>> Both patches are
>>>
>>> Reviewed-by: Jason Ekstrand
>>
>> Could you commit them?
>> I don't have commit access.
>
> I'd
On Mon, Mar 09, 2015 at 12:43:08PM +0200, Francisco Jerez wrote:
> "Pohjolainen, Topi" writes:
>
> > On Sat, Mar 07, 2015 at 04:15:08PM +0200, Francisco Jerez wrote:
> >> Topi Pohjolainen writes:
> >>
> >> > The original patch from Curro was based on something that is not
> >> > present in the
On Tue, Mar 10, 2015 at 1:15 PM, Thomas Helland
wrote:
> Humble ping?
Thanks for the reminder. I'd forgotten. :)
I'll commit them now.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
"Pohjolainen, Topi" writes:
> On Mon, Mar 09, 2015 at 12:43:08PM +0200, Francisco Jerez wrote:
>> "Pohjolainen, Topi" writes:
>>
>> > On Sat, Mar 07, 2015 at 04:15:08PM +0200, Francisco Jerez wrote:
>> >> Topi Pohjolainen writes:
>> >>
>> >> > The original patch from Curro was based on someth
On 09/03/15 16:22, Matt Turner wrote:
> On Mon, Mar 9, 2015 at 4:52 AM, Emil Velikov wrote:
>> My passing --force autoreconf will update all the aux files, which would
>
> s/My/By/
>
>> otherwise be ignored if one updates autoconf/automake.
>>
>> Quote the ORIGDIR variable to prevent fall-outs,
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> The blit engine is limited to 32Kx32K transfer. In cases where we have to fall
> back to the blitter, and when trying to blit a slice of a 2d texture array, or
> face of a cube map, we don't need to transfer the entire texture.
>
> I doubt this
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> IMHO, intel_miptree_choose_tiling() is an unfortunate incarnation because it
> conflates what is permitted vs. what is desirable. This makes doing any sort
> of
> "fallback" operations after the fact somewhat kludgey.
>
> The original code bas
I've looked into how to recognize BFM and BFI and discovered that if
TGSI_OPCODE_BFI is expanded, it's _impossible_ to recognize the
pattern in the backend due to LLVM transformations. The reason it's
impossible is that one particular simplification of the expanded IR
can always be done and it alwa
On Tue, Mar 10, 2015 at 11:01:21PM +0100, Marek Olšák wrote:
> I've looked into how to recognize BFM and BFI and discovered that if
> TGSI_OPCODE_BFI is expanded, it's _impossible_ to recognize the
> pattern in the backend due to LLVM transformations. The reason it's
> impossible is that one partic
LGTM.
Reviewed-by: Laura Ekstrand
On Tue, Mar 10, 2015 at 11:33 AM, Eduardo Lima Mitev
wrote:
> The implementation of texture <-> pixel-buffer transfers in drivers common
> layer
> includes certain error checks and argument validation that don't belong
> there,
> considering how the Mesa codeb
On Tue, Mar 10, 2015 at 10:49 AM, Jordan Justen
wrote:
> When uploading state for a pipeline, we will save changed state for
> the other pipelines.
>
> Signed-off-by: Jordan Justen
> ---
> src/mesa/drivers/dri/i965/brw_context.h | 1 +
> src/mesa/drivers/dri/i965/brw_state_upload.c | 41
>
On 02/28/2015 12:19 PM, Matt Turner wrote:
> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
> wrote:
>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand" wrote:
>>>
>>> Both patches are
>>>
>>> Reviewed-by: Jason Ekstrand
>>
>> Could you commit them?
>> I don't have commit access.
>
> I'd like to wai
On Mon, Mar 9, 2015 at 5:09 PM, Samuel Pitoiset
wrote:
> This enables GL_AMD_performance_monitor for freedreno.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/drivers/freedreno/freedreno_query.c | 9 +
> src/gallium/drivers/freedreno/freedreno_query.h | 1 +
> 2 files changed, 10
On 2015-03-10 16:11:08, Kristian Høgsberg wrote:
> On Tue, Mar 10, 2015 at 10:49 AM, Jordan Justen
> wrote:
> > When uploading state for a pipeline, we will save changed state for
> > the other pipelines.
> >
> > Signed-off-by: Jordan Justen
> > ---
> > src/mesa/drivers/dri/i965/brw_context.h
---
src/mesa/drivers/dri/i915/i915_debug_fp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i915/i915_debug_fp.c
b/src/mesa/drivers/dri/i915/i915_debug_fp.c
index 3f09902..d107c5a 100644
--- a/src/mesa/drivers/dri/i915/i915_debug_fp.c
+++ b/src/mesa/driv
On Tue, Mar 10, 2015 at 4:20 PM, Ian Romanick wrote:
> On 02/28/2015 12:19 PM, Matt Turner wrote:
>> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
>> wrote:
>>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand" wrote:
Both patches are
Reviewed-by: Jason Ekstrand
>>>
>>> Could you
On Tue, Mar 10, 2015 at 4:50 PM, Matt Turner wrote:
> On Tue, Mar 10, 2015 at 4:20 PM, Ian Romanick wrote:
> > On 02/28/2015 12:19 PM, Matt Turner wrote:
> >> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
> >> wrote:
> >>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand"
> wrote:
>
> Bot
On Tue, Mar 10, 2015 at 4:32 PM, Jordan Justen
wrote:
> On 2015-03-10 16:11:08, Kristian Høgsberg wrote:
>> On Tue, Mar 10, 2015 at 10:49 AM, Jordan Justen
>> wrote:
>> > When uploading state for a pipeline, we will save changed state for
>> > the other pipelines.
>> >
>> > Signed-off-by: Jordan
Creating/recreating the strings in eglQueryString() is extra work and
isn't thread-safe, as exhibited by shader-db's run.c using libepoxy.
Multiple threads in run.c call eglReleaseThread() around the same time.
libepoxy calls eglQueryString() to determine whether eglReleaseThread()
exists, and our
On Wed, Mar 11, 2015 at 12:09 AM, Tom Stellard wrote:
> On Tue, Mar 10, 2015 at 11:01:21PM +0100, Marek Olšák wrote:
>> I've looked into how to recognize BFM and BFI and discovered that if
>> TGSI_OPCODE_BFI is expanded, it's _impossible_ to recognize the
>> pattern in the backend due to LLVM tran
On Tue, Mar 10, 2015 at 1:09 PM, Jason Ekstrand wrote:
> How about we do things slightly differently and check "(__node)->field.next
> != NULL" just like we do on regular versions. Since the check happens
> between the increment step and running the user's code, __node is valid for
> every invoca
On Tue, Mar 10, 2015 at 5:45 PM, Matt Turner wrote:
> On Tue, Mar 10, 2015 at 1:09 PM, Jason Ekstrand
> wrote:
> > How about we do things slightly differently and check
> "(__node)->field.next
> > != NULL" just like we do on regular versions. Since the check happens
> > between the increment st
That's embarrassing! :)
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Use 3-space indents, not 4. Move some comments after the case statements.
---
src/mesa/main/querymatrix.c | 229 ++--
1 file changed, 115 insertions(+), 114 deletions(-)
diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c
index 095817c..
---
src/mesa/main/querymatrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c
index ccd5c5e..18361c9 100644
--- a/src/mesa/main/querymatrix.c
+++ b/src/mesa/main/querymatrix.c
@@ -75,7 +75,7 @@ _mesa_QueryMatrixxOES(GL
---
src/mesa/main/querymatrix.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c
index ca6b023..ccd5c5e 100644
--- a/src/mesa/main/querymatrix.c
+++ b/src/mesa/main/querymatrix.c
@@ -49,13 +49,12 @@ _mesa_QueryMatrix
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c
b/src/gallium/state_trackers/glx/xlib/glx_api.c
index d1bd760..f9572b7 100644
--- a/src/gallium/state_trackers/glx/xlib/glx_api.c
+
---
include/c99_math.h | 52 +
src/mesa/main/querymatrix.c | 51 +---
2 files changed, 53 insertions(+), 50 deletions(-)
diff --git a/include/c99_math.h b/include/c99_math.h
index 0a49950..f1a6685 100644
We were already using strdup() in various places in Mesa. Get rid
of the _mesa_strdup() wrapper. All the callers pass a non-NULL
argument so the NULL check isn't needed either.
---
src/mesa/main/imports.c | 18 --
src/mesa/main/imports.h | 3 ---
src/mesa
Not actually used anwhere in Mesa.
---
src/mesa/main/compiler.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 95581fb..06c4b5c 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -57,9 +57,6 @@ extern "C" {
# el
This is the only remnant of AIX-specific code in Mesa. Probably long
unused.
---
src/mesa/main/compiler.h | 8
1 file changed, 8 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 06c4b5c..6fded88 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main
---
src/mesa/main/compiler.h | 21 -
src/util/macros.h| 20
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index f56dc3e..b0d8c8f 100644
--- a/src/mesa/main/compiler.h
+++ b/src/m
---
src/mesa/main/compiler.h | 4
1 file changed, 4 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 6fded88..7cd7947 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -124,12 +124,8 @@ extern "C" {
#else
#define _ASMAPI
#endif
-#if
---
src/mesa/swrast/s_blend.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/mesa/swrast/s_blend.c b/src/mesa/swrast/s_blend.c
index 7cb1194..a9945f6 100644
--- a/src/mesa/swrast/s_blend.c
+++ b/src/mesa/swrast/s_blend.c
@@ -48,9 +48,6 @@
#if define
__cdecl is the MSVC directive use to indicate caller stack cleanup.
We typically annotate code-generated functions with __cdecl so we can
use the same code on all platforms.
A new #define like CDECL would be nicer, but CDECL is already defined
in minwindef.h on Windows.
---
src/mesa/main/compiler
First step to simplifying _ASMAPI cdecl wrapper macros.
Don't bother checking USE_X86_ASM. Just use the cdecl tag all the time
as we do in gallium.
---
src/mesa/math/m_clip_tmp.h | 8 +++
src/mesa/math/m_norm_tmp.h | 18 +++---
src/mesa/math/m_xform.h | 14 +++
src/mesa
Since removing PTR_DECL_IN_FRONT it's no longer needed. Just use
"_ASMAPI *" instead.
---
src/mesa/main/compiler.h| 1 -
src/mesa/math/m_xform.h | 6 +++---
src/mesa/swrast/s_context.h | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/me
On Wed, Mar 11, 2015 at 01:27:32AM +0100, Marek Olšák wrote:
> On Wed, Mar 11, 2015 at 12:09 AM, Tom Stellard wrote:
> > On Tue, Mar 10, 2015 at 11:01:21PM +0100, Marek Olšák wrote:
> >> I've looked into how to recognize BFM and BFI and discovered that if
> >> TGSI_OPCODE_BFI is expanded, it's _im
On Tue, Mar 10, 2015 at 6:41 PM, Brian Paul wrote:
> ---
Patches 1-2 are
Acked-by: Matt Turner
(I didn't verify the moved code didn't change)
Patches 3-4 are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://
This patch is
Reviewed-by: Ian Romanick
On 03/10/2015 06:43 PM, Brian Paul wrote:
> This is the only remnant of AIX-specific code in Mesa. Probably long
> unused.
> ---
> src/mesa/main/compiler.h | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/src/mesa/main/compiler.h b/src/me
This patch is
Reviewed-by: Ian Romanick
On 03/10/2015 06:43 PM, Brian Paul wrote:
> Not actually used anwhere in Mesa.
> ---
> src/mesa/main/compiler.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> index 95581fb..06c4b5c 100644
On 03/10/2015 06:42 PM, Brian Paul wrote:
> We were already using strdup() in various places in Mesa. Get rid
> of the _mesa_strdup() wrapper. All the callers pass a non-NULL
> argument so the NULL check isn't needed either.
> ---
> src/mesa/main/imports.c | 18 --
>
On 03/10/2015 07:47 PM, Ian Romanick wrote:
> On 03/10/2015 06:42 PM, Brian Paul wrote:
>> We were already using strdup() in various places in Mesa. Get rid
>> of the _mesa_strdup() wrapper. All the callers pass a non-NULL
>> argument so the NULL check isn't needed either.
>> ---
>> src/mesa/mai
Series is
Reviewed-by: Ian Romanick
On 03/10/2015 06:43 PM, Brian Paul wrote:
> ---
> src/mesa/main/compiler.h | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> index 6fded88..7cd7947 100644
> --- a/src/mesa/main/compiler.h
> +++
On 03/09/2015 06:36 PM, Kenneth Graunke wrote:
> From: Jason Ekstrand
>
> __next and __prev are pointers to the structure containing the exec_node
> link, not the embedded exec_node. NULL checks would fail unless the
> embedded exec_node happened to be at offset 0 in the parent struct.
Wait...
On Tue, Mar 10, 2015 at 10:54 PM, Ian Romanick wrote:
> On 03/09/2015 06:36 PM, Kenneth Graunke wrote:
>> From: Jason Ekstrand
>>
>> __next and __prev are pointers to the structure containing the exec_node
>> link, not the embedded exec_node. NULL checks would fail unless the
>> embedded exec_no
On 03/10/2015 05:20 PM, Matt Turner wrote:
> Creating/recreating the strings in eglQueryString() is extra work and
> isn't thread-safe, as exhibited by shader-db's run.c using libepoxy.
>
> Multiple threads in run.c call eglReleaseThread() around the same time.
> libepoxy calls eglQueryString() to
On 03/10/2015 08:04 PM, Connor Abbott wrote:
> On Tue, Mar 10, 2015 at 10:54 PM, Ian Romanick wrote:
>> On 03/09/2015 06:36 PM, Kenneth Graunke wrote:
>>> From: Jason Ekstrand
>>>
>>> __next and __prev are pointers to the structure containing the exec_node
>>> link, not the embedded exec_node. N
On Tuesday, March 10, 2015 05:48:20 PM Jason Ekstrand wrote:
> On Tue, Mar 10, 2015 at 5:45 PM, Matt Turner wrote:
>
> > On Tue, Mar 10, 2015 at 1:09 PM, Jason Ekstrand
> > wrote:
> > > How about we do things slightly differently and check
> > "(__node)->field.next
> > > != NULL" just like we do
On Tuesday, March 10, 2015 05:41:28 PM Brian Paul wrote:
> ---
> src/mesa/drivers/dri/i915/i915_debug_fp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i915/i915_debug_fp.c
> b/src/mesa/drivers/dri/i915/i915_debug_fp.c
> index 3f09902..d107c5a 100
On Tue, Mar 10, 2015 at 8:19 PM, Ian Romanick wrote:
> On 03/10/2015 05:20 PM, Matt Turner wrote:
>> Creating/recreating the strings in eglQueryString() is extra work and
>> isn't thread-safe, as exhibited by shader-db's run.c using libepoxy.
>>
>> Multiple threads in run.c call eglReleaseThread()
On Thursday, February 26, 2015 03:42:52 PM Ben Widawsky wrote:
> From: Kristian Høgsberg
>
> v2 by Ben:
> Rebase with conflict resolution
> Add the SKL scaling factors
I'd probably keep those as a separate patch, but commit that before this
one.
> Squashed in i965/skl: Dont zero surf[12]. The p
On 2015-03-10 17:09:14, Kristian Høgsberg wrote:
> On Tue, Mar 10, 2015 at 4:32 PM, Jordan Justen
> wrote:
> > On 2015-03-10 16:11:08, Kristian Høgsberg wrote:
> >> On Tue, Mar 10, 2015 at 10:49 AM, Jordan Justen
> >> wrote:
> >> > + const struct brw_tracked_state *atoms =
> >> > + brw_pip
On Thursday, February 26, 2015 03:42:53 PM Ben Widawsky wrote:
> Keep this as a separate patch for review, but I will squash it with the
> previous
> patch before pushing.
>
> We don't support 16x MSAA yet, but I entered it in here while I was at the
> table.
>
> I'm having trouble getting throu
On Tue, Mar 10, 2015 at 8:31 PM, Ian Romanick wrote:
> Also... I'm not a fan of these ever-growing macros. They're a lot like
> alligators. They're pretty cute when they're small, but when they grow
> up they drown you in a river and eat you. I feel like the users of
> this macro should just us
On Tue, Mar 10, 2015 at 6:44 PM, Brian Paul wrote:
> __cdecl is the MSVC directive use to indicate caller stack cleanup.
> We typically annotate code-generated functions with __cdecl so we can
> use the same code on all platforms.
>
> A new #define like CDECL would be nicer, but CDECL is already d
On Tue, Mar 10, 2015 at 6:44 PM, Brian Paul wrote:
> ---
> src/mesa/main/compiler.h | 21 -
> src/util/macros.h| 20
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> index f
On Tue, Mar 10, 2015 at 09:43:26PM -0700, Kenneth Graunke wrote:
> On Thursday, February 26, 2015 03:42:53 PM Ben Widawsky wrote:
> > Keep this as a separate patch for review, but I will squash it with the
> > previous
> > patch before pushing.
> >
> > We don't support 16x MSAA yet, but I entered
On Tue, Mar 10, 2015 at 09:19:30PM -0700, Kenneth Graunke wrote:
> On Thursday, February 26, 2015 03:42:52 PM Ben Widawsky wrote:
> > From: Kristian Høgsberg
> >
> > v2 by Ben:
> > Rebase with conflict resolution
> > Add the SKL scaling factors
>
> I'd probably keep those as a separate patch, bu
76 matches
Mail list logo
