Re: [Mesa-dev] [PATCH] i965/fs: Implement SIMD16 dual source blending.

On Sat, 2015-03-07 at 13:35 -0800, Jason Ekstrand wrote: > > > On Thu, Mar 5, 2015 at 9:39 PM, Jason Ekstrand > wrote: > This looks fine to me. I just kicked off a build on our test > farm and, assuming that looks good (I'll send another e-mail > in the morning if it doe

Re: [Mesa-dev] [PATCH] meta: Plug memory leak in blit shader creation

On Friday, March 06, 2015 06:22:00 PM Ben Widawsky wrote: > It looks like this has existed since: > commit f5a477ab76b6e0b268387699cd2253a43db0dfae > Author: Ian Romanick > Date: Mon Dec 16 11:54:08 2013 -0800 > > meta: Refactor shader generation code out of mipmap generation path > > Valg

[Mesa-dev] [PATCH] Mesa: Add generated files to .gitignore

src/egl/main/.install-mesa-links src/glx/.install-mesa-links src/mapi/.install-mesa-links src/mesa/drivers/dri/i965/test_fs_cmod_propagation src/mesa/drivers/dri/i965/test_fs_saturate_propagation added to .gitignore files on their own directories Signed-off-by: Juha-Pekka Heikkila --- src/egl/m

[Mesa-dev] [PATCH 1/9] i965/fs: Store a pointer to brw_sampler_prog_key_data in the visitor.

The NIR backend hardcodes brw_wm_prog_key at the moment, which won't work when we support scalar VS. We could use get_tex(), but it's a static method. I was going to promote it to fs_visitor, but then realized that both parameters (stage and key) are already members. It then occured to me that w

[Mesa-dev] [PATCH 6/9] i965/fs: Refactor fs_visitor::nir_setup_inputs().

No functional change. In preparation for supporting vertex shaders, this adds a switch statement on shader stage (since vertex attributes and fragment shader varyings will need different handling). It also renames "varying" to "input", to be more general. Signed-off-by: Kenneth Graunke --- src

[Mesa-dev] [PATCH 8/9] i965/fs: Add VS output support to nir_setup_outputs().

Adapted from fs_visitor::visit(ir_variable *). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp in

[Mesa-dev] [PATCH 2/9] i965/nir: Optimize after nir_lower_var_copies().

Array variable copy splitting generates a bunch of stuff we want to clean up before proceeding. Signed-off-by: Kenneth Graunke Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/m

[Mesa-dev] [PATCH 9/9] i965: Use NIR for scalar VS when INTEL_USE_NIR is set.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 428234f..ee5bc4a 100644 --- a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 4/9] nir: Add intrinsics for SYSTEM_VALUE_BASE_VERTEX and VERTEX_ID_ZERO_BASE

Ian and I added these around the time Connor was developing NIR. Now that both exist, we should make them work together! Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_intrinsics.h | 2 ++ src/glsl/nir/nir_lower_system_values.c | 6 ++ 2 files changed, 8 insertions(+) diff --

[Mesa-dev] [PATCH 3/9] i965/nir: Lower to registers a bit later.

We can't safely call nir_optimize() with register present, since several passes called in the loop can't handle registers, and will fail asserts. Notably, nir_lower_vec_alus() and nir_opt_algebraic() really don't want registers. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 7/9] i965/fs: Handle VS inputs in the NIR backend.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 3baafc4..1734d03 100644 --- a/src/mesa

[Mesa-dev] [PATCH 5/9] i965: Implement NIR intrinsics for loading VS system values.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 51 1 file changed, 51 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index c5ed55c..d700523 100644 --- a/src/mesa/drive

Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup

On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer wrote: > The shortlog of patch 4 should be prefixed by gallium: as well. Duh, I forgot the prefix everywhere. And the signoff line. Specifically about the last patch, the one that actually touches clover, is there a criteria for when to use gallium:

Re: [Mesa-dev] [RFC] i965: Factor out descriptor building for indirect send messages

"Pohjolainen, Topi" writes: > On Sat, Mar 07, 2015 at 04:15:08PM +0200, Francisco Jerez wrote: >> Topi Pohjolainen writes: >> >> > The original patch from Curro was based on something that is not >> > present in the master yet. This patch tries to mimick the logic on >> > top master. >> > I wan

Re: [Mesa-dev] GSoC 2015 Proposal : Porting Glean tests to piglit

On 04/03/15 11:21, Juliet Fru wrote: > Hello, > > Here is my proposal for Adding Porting Glean tests to piglit. I'll like > to get your comments and tweaks. > > Thanks, > Juliet​ > Porting Glean tests to Piglit framework OPW Proposal >

Re: [Mesa-dev] [PATCH 1/3] Revert "common: Fix PBOs for 1D_ARRAY."

Hi Emil, The resolve looks good, however I think it would also make sense to cherry pick a44606 to the stable branch. It doesn't do any harm either way but it should be slightly faster and cleaner with that patch as well. Regards, - Neil Emil Velikov writes: > On 4 March 2015 at 23:15, Emil Ve

[Mesa-dev] [PATCH] autogen.sh: pass --force to autoreconf, quote ORIGDIR

My passing --force autoreconf will update all the aux files, which would otherwise be ignored if one updates autoconf/automake. Quote the ORIGDIR variable to prevent fall-outs, when it's name contains space. Signed-off-by: Emil Velikov --- autogen.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

On 07/03/15 19:38, Emil Velikov wrote: On 07/03/15 07:23, Jose Fonseca wrote: ... we still didn't eliminate the use of non-portable _MTX_INITIALIZER_NP from Mesa tree gave me pause. The only way I can think about resolving this, is to use call_once() to initialize the mutex, Yes, I'm afraid

Re: [Mesa-dev] GSoC 2015 Proposal : Porting Glean tests to piglit

Hello, Thanks for the email. I am currently updating the proposal now. Best, Juliet On Mon, Mar 9, 2015 at 12:32 PM, Emil Velikov wrote: > On 04/03/15 11:21, Juliet Fru wrote: > > Hello, > > > > Here is my proposal for Adding Porting Glean tests to piglit. I'll like > > to get your comments an

Re: [Mesa-dev] [PATCH 4/4] Clover: use get_device_vendor instead of get_vendor

Giuseppe Bilotta writes: > The pipe's get_vendor method returns something more akin to a driver > vendor string in most cases, instead of the actual device vendor. Use > get_device_vendor instead, which was introduced specifically for this > purpose. For this patch: Reviewed-by: Francisco Jerez

[Mesa-dev] GSoC 2015 Proposal: Porting Glean tests to piglit.

Hello, Here is my proposal: Porting Glean Tests to Piglit GSoC Proposal Contact Informaion:Names:Achere Juliet F. Forchibe E-mail address: juliet...@gmail.com IRC Nick: Jul13t Mentors: Brian Paul, Laura Ekstrand Project Information Porting Glean Tests to the Piglit framework. Brief Summa

[Mesa-dev] [PATCH] i965: Do not render primitives in non-zero streams then TF is disabled

Haswell hardware seems to ignore Render Stream Select bits from 3DSTATE_STREAMOUT packet when the SOL stage is disabled even if the PRM says otherwise. Because of this, all primitives are sent down the pipeline for rasterization, which is wrong. If SOL is enabled, Render Stream Select is honored an

[Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 test as well as the precision part of Wine's 3dc format test (fd.o bug 89156). The Z component seems to contain a lower precision version of the result, probably a temporary value from the decompression computation. The Y and

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

On Mon, Mar 9, 2015 at 11:15 AM, Stefan Dösinger wrote: > This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 > test as well as the precision part of Wine's 3dc format test (fd.o bug > 89156). This is often identified in the commit message with Bugzilla: https://bugs.freedes

Re: [Mesa-dev] [PATCH] i965: Silence GCC maybe-uninitialized warning.

On Fri, Mar 6, 2015 at 10:10 PM, Vinson Lee wrote: > brw_shader.cpp: In function ‘bool brw_saturate_immediate(brw_reg_type, > brw_reg*)’: > brw_shader.cpp:618:31: warning: ‘sat_imm.brw_saturate_immediate(brw_reg_type, > brw_reg*)ud’ may be used uninitialized in this function > [-Wmaybe-unin

Re: [Mesa-dev] [PATCH] i915: Fix GCC unused-but-set-variable warning in release build.

On Fri, Mar 6, 2015 at 9:56 PM, Vinson Lee wrote: > i915_fragprog.c: In function ‘i915ValidateFragmentProgram’: > i915_fragprog.c:1453:11: warning: variable ‘k’ set but not used > [-Wunused-but-set-variable] >int k; >^ > > Signed-off-by: Vinson Lee > --- > src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand wrote: > Adds a useful comment and some whitespace. Fixes an error message. > > v2: Review from Anuj Phogat >- Split rebase of Tex[ture]Buffer[Range] > --- > src/mesa/main/teximage.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deleti

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Thanks for the quick feedback! Am 2015-03-09 um 16:20 schrieb Ilia Mirkin: > I don't suppose you've tried adding RGTC1_SNORM/LATC1_SNORM into > that condition? No, because the codepath isn't entered for them at all. There's an if(format != RGTC1_

Re: [Mesa-dev] [PATCH] Add macro for unused function attribute.

On 07/03/15 22:09, Vinson Lee wrote: > Suggested-by: Emil Velikov > Signed-off-by: Vinson Lee Reviewed-by: Emil Velikov Looks great. Thanks. Emil > --- > configure.ac | 1 + > scons/gallium.py | 1 + > src/util/macros.h | 6 ++ > 3 files changed, 8 insertions(+) > > diff --git a/co

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 16:53 schrieb Stefan Dösinger: > I did test if LATC_UNORM and LATC_SNORM still work after my fix. > LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and > LATC_UNORM now has the proper precision like RGTC_UNORM. I think

Re: [Mesa-dev] [PATCH] autogen.sh: pass --force to autoreconf, quote ORIGDIR

On Mon, Mar 9, 2015 at 4:52 AM, Emil Velikov wrote: > My passing --force autoreconf will update all the aux files, which would s/My/By/ > otherwise be ignored if one updates autoconf/automake. > > Quote the ORIGDIR variable to prevent fall-outs, when it's name contains s/it's/its/ > space. > >

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 17:19 schrieb Ilia Mirkin: > It also has the additional problem that it doesn't do the swizzle > workaround which apparently is necessary even for single-component > textures. Do you mean the change I made in my patch? That part work

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify some tests in update_array_format()

On Thursday 05 March 2015, Ian Romanick wrote: > On 03/05/2015 10:56 AM, Fredrik Höglund wrote: > > There is no need to check if these extensions are supported here; > > if the data type is not supported, we will already have returned a > > GL_INVALID_ENUM error. > > From where would GL_INVALID_EN

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

On Mon, Mar 9, 2015 at 12:26 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2015-03-09 um 17:19 schrieb Ilia Mirkin: >> It also has the additional problem that it doesn't do the swizzle >> workaround which apparently is necessary even for single-component >> te

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

On Mon, Mar 9, 2015 at 12:11 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2015-03-09 um 16:53 schrieb Stefan Dösinger: >> I did test if LATC_UNORM and LATC_SNORM still work after my fix. >> LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and >>

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

I'm confused which hunk you talking about. Can you be more specific? On Mon, Mar 9, 2015 at 8:47 AM, Anuj Phogat wrote: > On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand > wrote: > > Adds a useful comment and some whitespace. Fixes an error message. > > > > v2: Review from Anuj Phogat > >-

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

https://bugs.freedesktop.org/show_bug.cgi?id=89477 Mark Janes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH v2] i965/skl: Fix the order of the arguments for the LD sampler message

In Skylake the order of the arguments for sample messages with the LD type are u, v, lod, r whereas previously they were u, lod, v, r. This fixes 144 Piglit tests including ones that directly use texelFetch and also some using the meta stencil blit path which appears to use texelFetch in its shade

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

On Mon, Mar 9, 2015 at 9:43 AM, Laura Ekstrand wrote: > I'm confused which hunk you talking about. Can you be more specific? > > On Mon, Mar 9, 2015 at 8:47 AM, Anuj Phogat wrote: >> >> On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand >> wrote: >> > Adds a useful comment and some whitespace. Fixe

Re: [Mesa-dev] [PATCH 0/7] v2 of Tex[ture]Buffer[Range] functions

On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand wrote: > This divides a major rework of Tex[ture]Buffer[Range] into multiple patches as > recommended by Anuj Phogat. > > Laura Ekstrand (7): > main: Add utility function _mesa_lookup_bufferobj_err. > main: Use _mesa_lookup_bufferobj_err to simpli

Re: [Mesa-dev] [PATCH 0/6] v2 of Compressed Textures Cube Map Support

On Mon, Mar 9, 2015 at 11:09 AM, Anuj Phogat wrote: > On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand wrote: >> This cleans up ARB_direct_state_access texture cube map functions >> (mostly in response to reviews from Anuj Phogat). >> >> Laura Ekstrand (6): >> main: _mesa_cube_level_complete chec

Re: [Mesa-dev] [PATCH 0/6] v2 of Compressed Textures Cube Map Support

On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand wrote: > This cleans up ARB_direct_state_access texture cube map functions > (mostly in response to reviews from Anuj Phogat). > > Laura Ekstrand (6): > main: _mesa_cube_level_complete checks NumLayers. > main: Remove redundant NumLayers checks. >

Re: [Mesa-dev] [PATCH 2/9] i965/nir: Optimize after nir_lower_var_copies().

LGTM Reviewed-by: Jason Ekstrand On Mon, Mar 9, 2015 at 1:58 AM, Kenneth Graunke wrote: > Array variable copy splitting generates a bunch of stuff we want to > clean up before proceeding. > > Signed-off-by: Kenneth Graunke > Cc: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cp

Re: [Mesa-dev] [PATCH 4/5] i965/fs: Make get_timestamp() pass back the MOV rather than emitting it.

On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke wrote: > This makes another part of the INTEL_DEBUG=shader_time code emittable > at arbitrary locations, rather than just at the end of the instruction > stream. > > v2: Don't lose smear! Caught by Topi Pohjolainen. > v3: Don't set smear on the dest

Re: [Mesa-dev] INTEL_DEBUG=shader_time scalar backend fixes

On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke wrote: > Welcome to the rabbit trail. In order to fix Football Manager, I had to > rework INTEL_DEBUG=shader_time in the FS backend. While doing that, I > hit two assertion failures. After fixing that, I compared numbers. > I noticed that VS again

[Mesa-dev] [PATCH] [v2] meta: Plug memory leak

It looks like this has existed since commit f5a477ab76b6e0b268387699cd2253a43db0dfae Author: Ian Romanick Date: Mon Dec 16 11:54:08 2013 -0800 meta: Refactor shader generation code out of mipmap generation path Valgrind was complaining on fbo-generatemipmap-formats v2: Instead, do the all

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

I'm going to push this shortly. Thanks. Marek On Mon, Mar 9, 2015 at 4:15 PM, Stefan Dösinger wrote: > This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 > test as well as the precision part of Wine's 3dc format test (fd.o bug > 89156). > > The Z component seems to contain

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

Oh, thanks! I didn't see the new line there when I read your review. I will remove it. On Mon, Mar 9, 2015 at 10:45 AM, Anuj Phogat wrote: > On Mon, Mar 9, 2015 at 9:43 AM, Laura Ekstrand > wrote: > > I'm confused which hunk you talking about. Can you be more specific? > > > > On Mon, Mar 9,

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

Can you go and manually mark this commit and the "Add entry point for TextureBufferRange" as accepted in Patchwork? I don't have admin access, and my refactor of the new line caused a rebase. Thanks. Laura On Mon, Mar 9, 2015 at 1:13 PM, Laura Ekstrand wrote: > Oh, thanks! I didn't see the n

Re: [Mesa-dev] [PATCH] [v2] meta: Plug memory leak

On Monday, March 09, 2015 11:44:18 AM Ben Widawsky wrote: > It looks like this has existed since > commit f5a477ab76b6e0b268387699cd2253a43db0dfae > Author: Ian Romanick > Date: Mon Dec 16 11:54:08 2013 -0800 > > meta: Refactor shader generation code out of mipmap generation path > > Valgr

[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defin

[Mesa-dev] [PATCH 03/15] gallium: add new numeric types to pipe_query_result

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index cb42cef..c5721d4 100644 --- a/sr

[Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for freedreno. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c | 9 + src/gallium/drivers/freedreno/freedreno_query.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_

[Mesa-dev] [PATCH 15/15] nvc0: all queries use an unsigned 64-bits integer by default

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index be6be69..1898260 100644 --- a/s

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 50 ++ src/gallium/auxil

[Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

Hello, A series I have waited too long to re-submit, but I recently refactored the code and fixed some minor issues. This patchset enables GL_AMD_performance_monitor for svga, freedreno, r600, radeonsi and nvc0 drivers. This code has been tested with Nouveau (NVD9 and NVE7) but it should also wo

[Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for radeon. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

[Mesa-dev] [PATCH 04/15] gallium: replace pipe_driver_query_info::max_value by a union

This allows queries to return different numeric types. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 src/gallium/drivers

[Mesa-dev] [PATCH 06/15] st/mesa: implement GL_AMD_performance_monitor

From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) As for the Gallium HUD, we keep a list of busy queries in a ring buffer in order to prevent stalls when reading queries. Drivers must implement get_

[Mesa-dev] [PATCH 01/15] gallium: add pipe_screen::get_driver_query_group_info

Driver queries are organized as a single hierarchy where queries are categorized into groups. Each goup has a list of queries and a maximum number of queries that can be sampled. The list of available groups can be obtained using pipe_screen::get_driver_query_group_info. This will be used by GL_AM

[Mesa-dev] [PATCH 11/15] nvc0: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for nvc0. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 +++ 3 files changed, 14 insertions(+)

[Mesa-dev] [PATCH 05/15] gallium: make pipe_context::begin_query return a boolean

GL_AMD_performance_monitor must return an error when a monitoring session cannot be started. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_

[Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for svga. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/svga/svga_context.h | 1 + src/gallium/drivers/svga/svga_screen.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium/dr

[Mesa-dev] [PATCH 14/15] nvc0: make begin_query return false when all MP counters are used

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index 445110f..be6be69 100644 --- a/src

[Mesa-dev] [PATCH 13/15] nvc0: expose more driver-specific query groups

This patch exposes "Driver statistics" and "MP counters" groups. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 -- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 11 + 2 files changed, 69 insertions(+), 3 deletions(-) diff -

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.6.0 release

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno, r600 and radeonsi. Signed-off-by: Samuel Pitoiset --- docs/relnotes/10.6.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html index a396109..596a236 100644 --- a/docs/rel

Re: [Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

Done. On Mon, Mar 9, 2015 at 1:37 PM, Laura Ekstrand wrote: > Can you go and manually mark this commit and the "Add entry point for > TextureBufferRange" as accepted in Patchwork? I don't have admin access, > and my refactor of the new line caused a rebase. > > Thanks. > > Laura > > On Mon, Mar

Re: [Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: > According to the spec of GL_AMD_performance_monitor, valid type values > returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. > This also introduces the new field group_id in order to categorize > queries into groups. > > S

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

It would be better to add this function to u_helpers.c/.h instead of adding new files. Marek On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: > This function can be used to get a generic group of driver-specific > queries when a driver doesn't expose any groups. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info

Reviewed-by: Marek Olšák Marek On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: > This enables GL_AMD_performance_monitor for radeon. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 9 + > src/gallium/drivers/radeon/r600_pipe_common.h

Re: [Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

On 03/09/2015 10:36 PM, Marek Olšák wrote: On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add this function to u_helpers.c/.h instead of adding new files. Mmh, I'll probably introduce other functions related to queries when nouveau-perfkit will be ready. Are you sure it's a good idea to drop this file? Marek On

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

If you plan to add more functions, this file can stay. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset wrote: > > > On 03/09/2015 10:43 PM, Marek Olšák wrote: >> >> It would be better to add this function to u_helpers.c/.h instead of >> adding new files. > > > Mmh, I'll probably introduce

Re: [Mesa-dev] [PATCH v2] r600g: Use R600_MAX_VIEWPORTS instead of 16

Pushed, thanks. Marek On Wed, Feb 25, 2015 at 7:50 AM, Alexandre Demers wrote: > Lets define R600_MAX_VIEWPORTS instead of using 16 here and there > in the code when looping through viewports and scissors. It is > easier to understand what this number represents. > > v2: Missed a case where R600

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On 03/09/2015 11:00 PM, Marek Olšák wrote: If you plan to add more functions, this file can stay. Yes, it's my plan. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset wrote: On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add this function to u_helpers.c/.h inste

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 86747, which changed state. Bug 86747 Summary: Noise in Football Manager 2014 textures https://bugs.freedesktop.org/show_bug.cgi?id=86747 What|Removed |Added

Re: [Mesa-dev] [PATCH] [v2] i965/skl: Disable partial resolve in VC

On Thu, Feb 26, 2015 at 6:14 PM, Ben Widawsky wrote: > Recomendation [sic] is to set this field to 1 always. Programming it to > default > value of 0, may have -ve impact on performance for MSAA WLs. > > Another don't suck bit which needs to get set. > > Totally untested. > > v2: v1 was a mix of

Re: [Mesa-dev] [PATCH 3/4] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev wrote: > Internal PBO functions such as _mesa_map_validate_pbo_source() and > _mesa_validate_pbo_compressed_teximage() perform validation and buffer > mapping > within the same call. > > This patch takes out the validation into separate function

Re: [Mesa-dev] [PATCH 4/4] mesa: Check for valid PBO access in gl(Compressed)Tex(Sub)Image calls

Looks good to me. Reviewed-by: Laura Ekstrand On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev wrote: > This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage > family > of functions when a pixel buffer object is bound to GL_PIXEL_UNPACK_BUFFER: > > - That the buffer is not

[Mesa-dev] [PATCH 2/2] nir: Fix non-determinism in nir_lower_vars_to_ssa().

Previously, we stored derefs in a hash table, using the malloc'd pointer as the key. Then, we walked through the hash table and generated code, based on the order of the hash table's elements. Memory addresses returned by malloc are pretty much random, which meant that the hash was random, and th

[Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

From: Jason Ekstrand __next and __prev are pointers to the structure containing the exec_node link, not the embedded exec_node. NULL checks would fail unless the embedded exec_node happened to be at offset 0 in the parent struct. Signed-off-by: Jason Ekstrand Reviewed-by: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH 5/6] i965/skl: Align compressed textures to four times the block size

On Fri, Feb 20, 2015 at 10:31:07PM +, Neil Roberts wrote: > On Skylake it is possible to choose your own alignment values for > compressed textures but they are expressed as a multiple of the block > size. The minimum alignment value we can use is 4 so we effectively > have to align to 4 times

Re: [Mesa-dev] [PATCH 2/2] nir: Fix non-determinism in nir_lower_vars_to_ssa().

Reviewed-by: Connor Abbott I was in the middle of rewriting this pass for making derefs instructions, which hasn't been going nearly as nicely as I would like (ugh...), so if it pans out then I'll have to think about it a little more to make sure the new version is deterministic too. On Mon, Mar

Re: [Mesa-dev] [PATCH 2/2] nir: Fix non-determinism in nir_lower_vars_to_ssa().

Push it! On Mar 9, 2015 7:03 PM, "Connor Abbott" wrote: > Reviewed-by: Connor Abbott > > I was in the middle of rewriting this pass for making derefs > instructions, which hasn't been going nearly as nicely as I would like > (ugh...), so if it pans out then I'll have to think about it a little >

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

Reviewed-by: Connor Abbott On Mon, Mar 9, 2015 at 9:36 PM, Kenneth Graunke wrote: > From: Jason Ekstrand > > __next and __prev are pointers to the structure containing the exec_node > link, not the embedded exec_node. NULL checks would fail unless the > embedded exec_node happened to be at off

[Mesa-dev] GL/GLSL tests for GL 4.0 and newer

*I am interested on write tests for OpenGL 4.0 /GLSL 4.00 .* *But can you be more specify what areas you are expecting to be tested, Thank you!* ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-

[Mesa-dev] [PATCH ] vbo: improve the code style by adjust the preprocessing c code directives.

From: Marius Predut Brain Paul review suggestion: there's more macro use here than necessary. Removed and redefine some #define preprocessing directives. Removed the directive input parameter 'T' . No functional changes. Signed-off-by: Marius Predut --- src/mesa/vbo/vbo_attrib_tmp.h | 74 +++

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke wrote: > From: Jason Ekstrand > > __next and __prev are pointers to the structure containing the exec_node > link, not the embedded exec_node. NULL checks would fail unless the > embedded exec_node happened to be at offset 0 in the parent struct. >

Re: [Mesa-dev] [PATCH 2/2] nir: Fix non-determinism in nir_lower_vars_to_ssa().

On Mon, Mar 9, 2015 at 7:04 PM, Jason Ekstrand wrote: > Push it! Our policy is to wait a day for most things. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: > On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke > wrote: > > From: Jason Ekstrand > > > > __next and __prev are pointers to the structure containing the exec_node > > link, not the embedded exec_node. NULL checks would fail unless the > > em

Re: [Mesa-dev] [PATCH 2/2] nir: Fix non-determinism in nir_lower_vars_to_ssa().

On Mon, Mar 9, 2015 at 7:28 PM, Matt Turner wrote: > On Mon, Mar 9, 2015 at 7:04 PM, Jason Ekstrand > wrote: > > Push it! > > Our policy is to wait a day for most things. > Sure. Not really arguing for early pushing. Mostly just surprised that Connor picked up on it that fast. --Jason ___

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: > On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke wrote: >> From: Jason Ekstrand >> >> __next and __prev are pointers to the structure containing the exec_node >> link, not the embedded exec_node. NULL checks would fail unless the >> embedded e

Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup

On 09.03.2015 18:06, Giuseppe Bilotta wrote: > On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer wrote: >> The shortlog of patch 4 should be prefixed by gallium: as well. > > Duh, I forgot the prefix everywhere. And the signoff line. > > Specifically about the last patch, the one that actually touch

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner wrote: > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: >> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke >> wrote: >>> From: Jason Ekstrand >>> >>> __next and __prev are pointers to the structure containing the exec_node >>> link, not the embe

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott wrote: > On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner wrote: > > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: > >> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke > wrote: > >>> From: Jason Ekstrand > >>> > >>> __next and __prev are pointers

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:32 PM, Jason Ekstrand wrote: > > > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: >> >> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke >> wrote: >> > From: Jason Ekstrand >> > >> > __next and __prev are pointers to the structure containing the exec_node >> > link,

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand wrote: > > > On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott wrote: >> >> On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner wrote: >> > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: >> >> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke >> >> wrote:

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:58 PM, Matt Turner wrote: > On Mon, Mar 9, 2015 at 7:32 PM, Jason Ekstrand > wrote: > > > > > > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner wrote: > >> > >> On Mon, Mar 9, 2015 at 6:36 PM, Kenneth Graunke > >> wrote: > >> > From: Jason Ekstrand > >> > > >> > __next an

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 7:59 PM, Connor Abbott wrote: > On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand > wrote: > > > > > > On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott > wrote: > >> > >> On Mon, Mar 9, 2015 at 10:35 PM, Matt Turner > wrote: > >> > On Mon, Mar 9, 2015 at 7:24 PM, Matt Turner

Re: [Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

On Mon, Mar 9, 2015 at 11:02 PM, Jason Ekstrand wrote: > > > On Mon, Mar 9, 2015 at 7:59 PM, Connor Abbott wrote: >> >> On Mon, Mar 9, 2015 at 10:54 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Mon, Mar 9, 2015 at 7:48 PM, Connor Abbott >> > wrote: >> >> >> >> On Mon, Mar 9, 2015 at 10:35 PM,

  1   2   >