[Mesa-dev] [PATCH] auxilary/os: correct sysctl use in os_get_total_physical_memory()

2015-02-22 Thread Jonathan Gray
The length argument passed to sysctl was the size of the pointer not the type. The result of this is sysctl calls would fail on 32 bit BSD/Mac OS X. Additionally the wrong pointer was passed as an argument to store the result of the sysctl call. Cc: "10.4, 10.5" Signed-off-by: Jonathan Gray --

[Mesa-dev] [Bug 89260] macros.h:34:25: fatal error: util/u_math.h: No such file or directory

2015-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89260 Fabio Pedretti changed: What|Removed |Added CC||e...@lclark.edu --- Comment #1 from Fab

[Mesa-dev] [Bug 89260] macros.h:34:25: fatal error: util/u_math.h: No such file or directory

2015-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89260 Fabio Pedretti changed: What|Removed |Added CC||jfons...@vmware.com --- Comment #2 from

Re: [Mesa-dev] [PATCH 2/2] r600g: add doubles support for CAYMAN

2015-02-22 Thread Benjamin Bellec
Hello all, Do you know a game or app using doubles ? 2015-02-20 21:08 GMT+01:00 Ilia Mirkin : > On Fri, Feb 20, 2015 at 3:07 PM, Ilia Mirkin wrote: > > On Thu, Feb 19, 2015 at 9:59 PM, Glenn Kennard > wrote: > >>> + if ((write_mask & 0x3) != 0x3 && > >>> + (write_mask & 0xc) !=

[Mesa-dev] Segfault in r300_compiler_tests' peephole_mul_omod()

2015-02-22 Thread Matt Turner
Hi Tom, I've gotten a report about a segfault in the r300 compile tests. See Gentoo bug https://bugs.gentoo.org/show_bug.cgi?id=540970 It seems to be dependent on optimization level whether the test segfaults or not. Program received signal SIGSEGV, Segmentation fault. 0x004013fd in test

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-22 Thread Ben Widawsky
On Wed, Feb 11, 2015 at 04:05:57PM -0800, Matt Turner wrote: > On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick wrote: > > On 02/11/2015 02:54 PM, Matt Turner wrote: > >> We propagate negations to the right-most leaves of the multiplication > >> expression trees: > >> > >> - mul(neg(x), neg(y)) -> m

Re: [Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

2015-02-22 Thread Ben Widawsky
On Wed, Feb 11, 2015 at 02:54:51PM -0800, Matt Turner wrote: > total instructions in shared programs: 5932832 -> 5932736 (-0.00%) > instructions in affected programs: 8184 -> 8088 (-1.17%) > helped:52 > HURT: 14 > GAINED:

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-22 Thread Jason Ekstrand
On Feb 12, 2015 1:28 AM, "Kenneth Graunke" wrote: > > On Wednesday, February 11, 2015 04:14:20 PM Ian Romanick wrote: > > On 02/11/2015 04:05 PM, Matt Turner wrote: > > > On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick wrote: > > >> On 02/11/2015 02:54 PM, Matt Turner wrote: > > >>> We propagate ne

Re: [Mesa-dev] [PATCH] nir/gcm: Add some missing break statements

2015-02-22 Thread Connor Abbott
Reviewed-by: Connor Abbott Whoops, I should've caught that... On Sun, Feb 22, 2015 at 1:31 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opt_gcm.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/glsl/nir/nir_opt_gcm.c b/src/glsl/nir/nir_opt_gcm.c > index bf565b9..b4f5fd3

Re: [Mesa-dev] [PATCH] i965/fs: Combine tex/fb_write operations (opt)

2015-02-22 Thread Ben Widawsky
On Sun, Feb 08, 2015 at 02:48:02PM -0800, Matt Turner wrote: > On Sun, Feb 8, 2015 at 1:59 PM, Ben Widawsky > wrote: > > Certain platforms support the ability to sample from a texture, and write > > it out > > to the file RT - thus saving a costly send instructions (and before Topi's > > recent p

Re: [Mesa-dev] [PATCH] svga: fix sid corruption in vmw_drm_surface_from_handle()

2015-02-22 Thread Van Der Wath, DanielX J
Thanks for looking at this. I tried adding the checks you suggested, but it turns out the problem I'm seeing was actually caused by a mismatch between the kernel and user side versions of the SVGA3dSize struct (the kernel version is bigger, and so when it was copied back into user space it was o

Re: [Mesa-dev] [PATCH 0/2 v3] add visibility hidden to tls entry points

2015-02-22 Thread Sedat Dilek
On Tue, Feb 17, 2015 at 1:55 PM, Sedat Dilek wrote: > On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich wrote: >> Patch 1 adds a check for the compilers visibility macro to configure.ac. >> Patch 2 avoids redefined symbol errors in clang of the tls entry points. >> Based on a suggestion from Rafael

[Mesa-dev] [PATCH] svga: add missing padding to SVGA3dSize

2015-02-22 Thread Van Der Wath, DanielX J
From: Daniel van der Wath The kernel side equivalent of struct SVGA3dSize (struct drm_vmw_size) has an extra padding word that SVGA3dSize lacks. This was causing data to be written past the end of "size" in vmw_drm_surface_from_handle(), corrupting other data and in this case leading to Weston be

[Mesa-dev] [PATCH 2/2] nvc0/ir: improve precision of double RCP/RSQ results

2015-02-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Not sure how many steps are needed for the necessary accuracy. Just doing 2 because that seems like a reasonable number. .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 42 -- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH 1/2] nv50/ir: add fp64 support on G200 (NVA0)

2015-02-22 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Untested beyond compiling a few shaders to see if they look like they might work. nvdisasm agrees with envydis's decoding of these things. Will definitely get ahold of a G200 to run tests on before pushing this. .../drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp

[Mesa-dev] [PATCH 2/3] gallium/util: Use HAVE___BUILTIN_* macros.

2015-02-22 Thread Matt Turner
--- SCons already defines these, and more precisely than just is-it-gcc. src/gallium/auxiliary/util/u_math.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index dd2ce01..1e1bdf0 100644 ---

[Mesa-dev] [PATCH 1/3] mesa: Move C99 MSVC compatibility code from u_math.h to c99_compat.h.

2015-02-22 Thread Matt Turner
--- This series is attempting to make some progress towards moving u_math.h to src/util. include/c99_compat.h| 143 src/gallium/auxiliary/util/u_math.h | 143 2 files changed, 143 insertions(+), 143 deletion

[Mesa-dev] [PATCH 3/3] gallium: Use util_cpu_to_le{16, 32} in many more places.

2015-02-22 Thread Matt Turner
... and util_le{16,32}_to_cpu. I think I've used the right ones for describing the actual operation performed (even though they're both just "byte-swap this if I'm on big-endian"). The Linux Kernel has typedefs __le32/__be32 and friends that static analysis tools can use to check that byte-orderin

[Mesa-dev] [PATCH] mesa/vbo: Use unreachable to silence uninitialized var warning.

2015-02-22 Thread Matt Turner
--- src/mesa/vbo/vbo_exec_array.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index f75ca38..cae04cb 100644 --- a/src/mesa/vbo/vbo_exec_array.c +++ b/src/mesa/vbo/vbo_exec_array.c @@ -181,8 +181,7 @@ vbo_get_mi

[Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-22 Thread Matt Turner
--- I can't believe this is beneficial, especially since it came from the i915tex import. src/mesa/drivers/dri/i965/brw_context.h | 27 --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 2/2] i915: Remove hand-rolled memcpy implementation.

2015-02-22 Thread Matt Turner
--- src/mesa/drivers/dri/i915/intel_batchbuffer.c | 2 +- src/mesa/drivers/dri/i915/intel_context.h | 28 --- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_batchbuffer.c b/src/mesa/drivers/dri/i915/intel_batchbuffer.c i

[Mesa-dev] [PATCH 2/5] mesa: Remove CHECK macro.

2015-02-22 Thread Matt Turner
There's some commentary about how it's defined by other "modules", and maybe that was true in 2000 when the code was added. --- src/mesa/main/compiler.h| 6 src/mesa/math/m_trans_tmp.h | 76 ++--- src/mesa/math/m_translate.c | 6 3 files chan

[Mesa-dev] [PATCH 1/5] mesa: Remove dead CAPI define.

2015-02-22 Thread Matt Turner
--- src/mesa/main/compiler.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index cdc843d..6653bb2 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -174,11 +174,6 @@ static inline GLuint CPU_TO_LE32(GLuint x)

[Mesa-dev] [PATCH 4/5] mesa: Remove definition of NULL.

2015-02-22 Thread Matt Turner
If your stdlib.h doesn't define this you should fix your stdlib.h. --- src/mesa/main/compiler.h | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 9a5dbcf..d513284 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@

[Mesa-dev] [PATCH 5/5] mesa: Move START/END_FAST_MATH macros to their only use.

2015-02-22 Thread Matt Turner
--- src/mesa/main/compiler.h | 79 --- src/mesa/tnl/t_pipeline.c | 78 ++ 2 files changed, 78 insertions(+), 79 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index d513284..088

Re: [Mesa-dev] [PATCH 3/5] mesa: Use assert() instead of ASSERT wrapper.

2015-02-22 Thread Matt Turner
On Sun, Feb 22, 2015 at 9:13 PM, Matt Turner wrote: > --- > src/gallium/drivers/softpipe/sp_tex_sample.c | 2 +- > src/gallium/state_trackers/glx/xlib/glx_api.c | 2 +- > src/gallium/state_trackers/glx/xlib/xm_api.c | 4 +- > src/mesa/drivers/common/meta.c| 10 +- > src/m

Re: [Mesa-dev] [PATCH 3/5] mesa: Use assert() instead of ASSERT wrapper.

2015-02-22 Thread Matt Turner
On Sun, Feb 22, 2015 at 9:27 PM, Matt Turner wrote: > or > http://cgit.freedesktop.org/~mattst88/mesa/commit/?h=header-cleanup&id=70614b1d1e4cbab30add208bfacd5fe4469dc712 Ilia noticed I cast too wide a net with sed, so I've force pushed a new branch, so this commit is no longer valid. __

Re: [Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-22 Thread Eric Anholt
Matt Turner writes: > --- > I can't believe this is beneficial, especially since it came from the > i915tex import. I don't recall any good justification for it, and I don't see any branches I have laying around with evidence recorded for why we have to keep it (which actually kind of surprises

Re: [Mesa-dev] [PATCH 1/5] mesa: Remove dead CAPI define.

2015-02-22 Thread Eric Anholt
I like all of this. 4 is Acked-by, and the rest are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] mesa: Move C99 MSVC compatibility code from u_math.h to c99_compat.h.

2015-02-22 Thread Eric Anholt
Matt Turner writes: > --- > This series is attempting to make some progress towards moving u_math.h > to src/util. Hmm, looks like for other headers we've got include/c99/whatever.h that includes the system version and fixes it up. I think it should probably go there, instead. signature.asc D

Re: [Mesa-dev] [PATCH 3/3] gallium: Use util_cpu_to_le{16, 32} in many more places.

2015-02-22 Thread Eric Anholt
Matt Turner writes: > ... and util_le{16,32}_to_cpu. I think I've used the right ones for > describing the actual operation performed (even though they're both just > "byte-swap this if I'm on big-endian"). > > The Linux Kernel has typedefs __le32/__be32 and friends that static > analysis tools c

Re: [Mesa-dev] [PATCH] mesa/vbo: Use unreachable to silence uninitialized var warning.

2015-02-22 Thread Eric Anholt
Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] glsl: add double support for packing varyings

2015-02-22 Thread Dave Airlie
On 21 February 2015 at 04:56, Ilia Mirkin wrote: > Doubles are always packed, but a single double will never cross a slot > boundary -- single slots can still be wasted in some situations. I can't say I'm going to know if this is designed right, but the patch looks good to me and it seems like th