[Mesa-dev] [PATCH v2 08/10] glsl: A shader cannot redefine or overload built-in functions in GLSL ES 3.00

2015-02-19 Thread Samuel Iglesias Gonsalvez
Create a new search function to look for matching built-in functions by name and use it for built-in function redefinition or overload in GLSL ES 3.00. GLSL ES 3.0 spec, chapter 6.1 "Function Definitions", page 71 "A shader cannot redefine or overload built-in functions." While in GLSL ES 1.0

Re: [Mesa-dev] [PATCH v2 08/10] glsl: A shader cannot redefine or overload built-in functions in GLSL ES 3.00

2015-02-19 Thread Kenneth Graunke
On Thursday, February 19, 2015 09:55:35 AM Samuel Iglesias Gonsalvez wrote: > Create a new search function to look for matching built-in functions by name > and use it for built-in function redefinition or overload in GLSL ES 3.00. > > GLSL ES 3.0 spec, chapter 6.1 "Function Definitions", page 71

Re: [Mesa-dev] [PATCH v2 08/10] glsl: A shader cannot redefine or overload built-in functions in GLSL ES 3.00

2015-02-19 Thread Samuel Iglesias Gonsálvez
On Thursday 19 February 2015 00:59:56 Kenneth Graunke wrote: > On Thursday, February 19, 2015 09:55:35 AM Samuel Iglesias Gonsalvez wrote: > > Create a new search function to look for matching built-in functions by > > name and use it for built-in function redefinition or overload in GLSL ES > > 3.

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

2015-02-19 Thread Neil Roberts
Ian Romanick writes: > There aren't any compressed formats that support 1D textures, so I > don't think this can occur. Does the bspec say anything about > compressed 1D textures? Ah yes, you're right. I just copied it from brw_miptree_layout_2d without really thinking it through. The SKL bspec

[Mesa-dev] [PATCH] radeonsi: don't use SQC_CACHES to flush ICACHE and KCACHE on SI

2015-02-19 Thread Marek Olšák
From: Marek Olšák This reverts 73c2b0d18c51459697d8ec194ecfc4438c98c139. It doesn't seem to be reliable. It's probably missing a wait packet or something, because it's just a register write and doesn't wait for anything. SURFACE_SYNC at least seems to wait until the flush is done. Just guessing.

Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1

2015-02-19 Thread Lucas Stach
Am Freitag, den 07.11.2014, 01:19 -0800 schrieb Matt Turner: > On Fri, Nov 7, 2014 at 1:07 AM, Thierry Vignaud > wrote: > > On 5 November 2014 04:44, Matt Turner wrote: > >I tried to reproduce this today and couldn't. > > > > (...) > > > Thanks. Maybe you could give a little more informa

[Mesa-dev] [PATCH] install-lib-links: don't depend on .libs directory

2015-02-19 Thread Lucas Stach
This snippet can be included in Makefiles that may, depending on the project configuration, not actually build any installable libraries. In that case we don't have anything to depend on and this part of the makefile may be executed before the .libs directory is created, so do not depend on it bei

Re: [Mesa-dev] [PATCH] radeonsi: don't use SQC_CACHES to flush ICACHE and KCACHE on SI

2015-02-19 Thread Alex Deucher
On Thu, Feb 19, 2015 at 7:10 AM, Marek Olšák wrote: > From: Marek Olšák > > This reverts 73c2b0d18c51459697d8ec194ecfc4438c98c139. > > It doesn't seem to be reliable. It's probably missing a wait packet or > something, because it's just a register write and doesn't wait for anything. > SURFACE_SY

Re: [Mesa-dev] [PATCH v4] Fixing an x86 FPU bug.

2015-02-19 Thread Brian Paul
Looks better, just a bunch of nit-picks... First, I think the summary/subject line can be improved. How about "mesa: use fi_type in vertex attribute code" On 02/18/2015 10:00 AM, marius.pre...@intel.com wrote: From: Marius Predut On 32-bit, for floating point operations is used x86 FPU r

[Mesa-dev] [PATCH 1/2] nir: add missing GLSL_TYPE_DOUBLE case in type_size()

2015-02-19 Thread Brian Paul
To silence compiler warning about unhandled switch case. --- src/glsl/nir/nir_lower_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index ddbc249..23499e5 100644 --- a/src/glsl/nir/nir_lower_io.c +++ b/src/glsl/nir/nir_lower_io.c @

[Mesa-dev] [PATCH 2/2] st/mesa: add GSL_TYPE_DOUBLE, new ir_unop_* switch cases

2015-02-19 Thread Brian Paul
To silence compiler warnings about unhandled switch cases. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 3dac004..9969fac 100644 --- a/s

[Mesa-dev] [Bug 89199] u_math.h:591:4: error: implicit declaration of function 'ffsll'

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89199 --- Comment #2 from Brian Paul --- Hi Vinson, Is that with gcc? Which compiler version? I'll attach a patch proposal for you to try... -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bu

[Mesa-dev] [Bug 89199] u_math.h:591:4: error: implicit declaration of function 'ffsll'

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89199 --- Comment #3 from Brian Paul --- Created attachment 113670 --> https://bugs.freedesktop.org/attachment.cgi?id=113670&action=edit proposed patch If you're using gcc, maybe a gcc version check would be better. This patch also assumes the radeo

[Mesa-dev] [PATCH] mesa: Check that draw buffers are valid for glDrawBuffers on GLES3

2015-02-19 Thread Eduardo Lima Mitev
Section 4.2 (Whole Framebuffer Operations) of the OpenGL 3.0 specification says: "Each buffer listed in bufs must be BACK, NONE, or one of the values from table 4.3 (NONE, COLOR_ATTACHMENTi)". Fixes 1 dEQP test: * dEQP-GLES3.functional.negative_api.buffer.draw_buffers --- src/mesa/main/

Re: [Mesa-dev] [PATCH v2] mesa: Check first that draw buffers are valid for glDrawBuffers on GLES3

2015-02-19 Thread Eduardo Lima Mitev
On 02/18/2015 09:09 PM, Matt Turner wrote: > On Tue, Jan 13, 2015 at 3:29 AM, Eduardo Lima Mitev wrote: >> This patch was updated and is pending review. > > I think we're waiting on a new version with Tapani's comment addressed. > > The patch looks right, FWIW. > Hi Matt, I completely missed

Re: [Mesa-dev] [PATCH] mesa: Check that draw buffers are valid for glDrawBuffers on GLES3

2015-02-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 5:53 AM, Lucas Stach wrote: > Am Freitag, den 07.11.2014, 01:19 -0800 schrieb Matt Turner: >> On Fri, Nov 7, 2014 at 1:07 AM, Thierry Vignaud >> wrote: >> > On 5 November 2014 04:44, Matt Turner wrote: >> >I tried to reproduce this today and couldn't. >> > >> > (...)

Re: [Mesa-dev] [PATCH] install-lib-links: don't depend on .libs directory

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 5:52 AM, Lucas Stach wrote: > This snippet can be included in Makefiles that may, depending on the > project configuration, not actually build any installable libraries. > > In that case we don't have anything to depend on and this part of > the makefile may be executed bef

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add GSL_TYPE_DOUBLE, new ir_unop_* switch cases

2015-02-19 Thread Anuj Phogat
On Thu, Feb 19, 2015 at 8:27 AM, Brian Paul wrote: > > To silence compiler warnings about unhandled switch cases. > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/stat

Re: [Mesa-dev] [PATCH 9/9] i965/vec4: Print "VS" or "GS" when compiles fail, not "vec4".

2015-02-19 Thread Kristian Høgsberg
On Wed, Feb 18, 2015 at 9:37 PM, Jason Ekstrand wrote: > Series is > Reviewed-by: Jason Ekstrand Me too: Reviewed-by: Kristian Høgsberg > On Feb 18, 2015 9:00 PM, "Kenneth Graunke" wrote: >> >> This is now trivial to do right. >> >> Signed-off-by: Kenneth Graunke >> --- >> src/mesa/drivers

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Jason Ekstrand
On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez wrote: > Hey Matt, > > Matt Turner writes: > > > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez > wrote: > >> MRFs cannot be read from anyway so they cannot possibly be a valid > >> source of LOAD_PAYLOAD. > >> --- > > > > The function only seems

Re: [Mesa-dev] [PATCH] glsl: don't allow invariant qualifiers for interface blocks

2015-02-19 Thread Ian Romanick
On 12/09/2014 02:52 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > GLSL 1.50 and GLSL 4.40 specs, they both say the same in > "Interface Blocks" section: > > "If no optional qualifier is used in a member-declaration, the qualification > of > the member includes all in, out,

Re: [Mesa-dev] [PATCH 3/9] glsl: Create a _mesa_shader_stage_to_abbrev() function.

2015-02-19 Thread Ian Romanick
On 02/18/2015 09:00 PM, Kenneth Graunke wrote: > This is similar to _mesa_shader_stage_to_string(), but returns "VS" > instead of "vertex". > > Signed-off-by: Kenneth Graunke > --- > src/glsl/glsl_parser_extras.cpp | 17 + > src/glsl/glsl_parser_extras.h | 3 +++ > 2 files cha

Re: [Mesa-dev] [PATCH 3/9] glsl: Create a _mesa_shader_stage_to_abbrev() function.

2015-02-19 Thread Ian Romanick
On 02/19/2015 11:43 AM, Ian Romanick wrote: > On 02/18/2015 09:00 PM, Kenneth Graunke wrote: >> This is similar to _mesa_shader_stage_to_string(), but returns "VS" >> instead of "vertex". >> >> Signed-off-by: Kenneth Graunke >> --- >> src/glsl/glsl_parser_extras.cpp | 17 + >> src

[Mesa-dev] [PATCH] glsl: Use the without_array predicate

2015-02-19 Thread Timothy Arceri
--- src/glsl/ir.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index a0f48b2..9c60b07 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -450,11 +450,8 @@ public: */ inline bool is_interface_instance() const { - const gls

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez > wrote: > >> Hey Matt, >> >> Matt Turner writes: >> >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez >> wrote: >> >> MRFs cannot be read from anyway so they cannot possibly be a valid >> >> source of LOAD_PAYLOAD. >>

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add GSL_TYPE_DOUBLE, new ir_unop_* switch cases

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 11:27 AM, Brian Paul wrote: > To silence compiler warnings about unhandled switch cases. > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state

[Mesa-dev] [PATCH 2/2] st/mesa: add GSL_TYPE_DOUBLE, new ir_unop_* switch cases

2015-02-19 Thread Brian Paul
To silence compiler warnings about unhandled switch cases. v2: move GSL_TYPE_DOUBLE case to the "Invalid type in type_size" section, per Ilia. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 1/2] nir: add missing GLSL_TYPE_DOUBLE case in type_size()

2015-02-19 Thread Brian Paul
To silence compiler warning about unhandled switch case. v2: move GLSL_TYPE_DOUBLE to the "not reached" section, per Ilia. --- src/glsl/nir/nir_lower_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index ddbc249..207f8da 100644 ---

Re: [Mesa-dev] [PATCH 1/2] nir: add missing GLSL_TYPE_DOUBLE case in type_size()

2015-02-19 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin On Thu, Feb 19, 2015 at 3:51 PM, Brian Paul wrote: > To silence compiler warning about unhandled switch case. > v2: move GLSL_TYPE_DOUBLE to the "not reached" section, per Ilia. > --- > src/glsl/nir/nir_lower_io.c | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Jason Ekstrand
On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez > > wrote: > > > >> Hey Matt, > >> > >> Matt Turner writes: > >> > >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez < > curroje...@riseup.net> > >> wrote:

Re: [Mesa-dev] [PATCH] glsl: Use the without_array predicate

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 11:57 AM, Timothy Arceri wrote: > --- > src/glsl/ir.h | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/glsl/ir.h b/src/glsl/ir.h > index a0f48b2..9c60b07 100644 > --- a/src/glsl/ir.h > +++ b/src/glsl/ir.h > @@ -450,11 +450,8 @@ public: >

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view reference counting bug in glDraw/CopyPixels

2015-02-19 Thread Brian Paul
Ping. On 02/18/2015 11:20 AM, Brian Paul wrote: Use pipe_sampler_view_reference() instead of ordinary assignment. Also add a new sanity check assertion. Fixes piglit gl-1.0-drawpixels-color-index test crash. But note that the test still fails. Cc: "10.4, 10.5" --- src/mesa/state_tracker/st

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Francisco Jerez
Jason Ekstrand writes: > On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez >> > wrote: >> > >> >> Hey Matt, >> >> >> >> Matt Turner writes: >> >> >> >> > On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jere

Re: [Mesa-dev] [PATCH 1/3] gallium: add double opcodes and TGSI execution (v3.1)

2015-02-19 Thread Dave Airlie
I've addressed most of these, >> >> + /* double modifiers handled by caller */ >> + if (dtype) >> + return; > > Should the below code just get moved to fetch_source? Or does it rely > on local args which makes that a pain? If it's not too hard, I think > it'd be a lot cleaner / clearer th

[Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v4.1)

2015-02-19 Thread Dave Airlie
This patch adds support for a set of double opcodes to TGSI. It is an update of work done originally by Michal Krol on the gallium-double-opcodes branch. The opcodes have a hint where they came from in the header file. v2: add unsigned/int <-> double v2.1: update docs. v3: add DRSQ (Glenn), fix

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Jason Ekstrand
On Thu, Feb 19, 2015 at 1:25 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Thu, Feb 19, 2015 at 12:13 PM, Francisco Jerez > > > wrote: > > > >> Jason Ekstrand writes: > >> > >> > On Fri, Feb 6, 2015 at 4:01 PM, Francisco Jerez < > curroje...@riseup.net> > >> > wrote: > >> > > >>

Re: [Mesa-dev] [PATCH 1/2] nir: add missing GLSL_TYPE_DOUBLE case in type_size()

2015-02-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Feb 19, 2015 at 12:51 PM, Brian Paul wrote: > To silence compiler warning about unhandled switch case. > v2: move GLSL_TYPE_DOUBLE to the "not reached" section, per Ilia. > --- > src/glsl/nir/nir_lower_io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view reference counting bug in glDraw/CopyPixels

2015-02-19 Thread Ilia Mirkin
On Wed, Feb 18, 2015 at 1:20 PM, Brian Paul wrote: > Use pipe_sampler_view_reference() instead of ordinary assignment. > Also add a new sanity check assertion. > > Fixes piglit gl-1.0-drawpixels-color-index test crash. But note > that the test still fails. Fails on nvc0 as well, for the record.

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Remove type parameter from emit_vs_system_value().

2015-02-19 Thread Anuj Phogat
On Wed, Feb 18, 2015 at 9:00 PM, Kenneth Graunke wrote: > Every VS system value has type D. We can always add this back if that > changes, but for now, it's extra typing. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 +- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v4.1)

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 4:53 PM, Dave Airlie wrote: > This patch adds support for a set of double opcodes > to TGSI. It is an update of work done originally > by Michal Krol on the gallium-double-opcodes branch. > > The opcodes have a hint where they came from in the > header file. > > v2: add uns

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view reference counting bug in glDraw/CopyPixels

2015-02-19 Thread Brian Paul
On 02/19/2015 02:55 PM, Ilia Mirkin wrote: On Wed, Feb 18, 2015 at 1:20 PM, Brian Paul wrote: Use pipe_sampler_view_reference() instead of ordinary assignment. Also add a new sanity check assertion. Fixes piglit gl-1.0-drawpixels-color-index test crash. But note that the test still fails. F

[Mesa-dev] [PATCH] glsl: add lowering for double divide to rcp/mul

2015-02-19 Thread Dave Airlie
From: Dave Airlie It looks like no hw does div anyways, so we should just lower at the GLSL level. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructi

Re: [Mesa-dev] [PATCH] glsl: add lowering for double divide to rcp/mul

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 5:47 PM, Dave Airlie wrote: > From: Dave Airlie > > It looks like no hw does div anyways, so we should just > lower at the GLSL level. Sounds like radeonsi has helpers for DDIV, but they can work this out when they add support in mesa. Like not using DIV_TO_MUL_RCP loweri

[Mesa-dev] [PATCH] intel: fix EGLImage renderbuffer _BaseFormat

2015-02-19 Thread Frank Henigman
Correctly set _BaseFormat field when creating a gl_renderbuffer with EGLImage storage. Signed-off-by: Frank Henigman Reviewed-by: Stéphane Marchesin --- src/mesa/drivers/dri/i915/intel_fbo.c | 3 +-- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] st/mesa: add st fp64 support (v7)

2015-02-19 Thread Dave Airlie
From: Dave Airlie v2 : add double to int/unsigned conversion v3: handle fp64 consts better v4: use DRSQ v4.1: add d2b v4.2: drop DDIV v5: split out some prep patches. v5.1: add some comments. v5.2: more comments v6: simplify down the double instruction generation loop. v7: Merge Ilia's two

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Add unit tests for saturate propagation pass.

2015-02-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/11/2015 02:54 PM, Matt Turner wrote: > Cc: > --- > src/mesa/drivers/dri/i965/Makefile.am | 7 + > .../dri/i965/test_fs_saturate_propagation.cpp | 355 > + > 2 files changed, 362 insertions(+) > create mode

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Use fs_inst::overwrites_reg() in saturate propagation.

2015-02-19 Thread Ian Romanick
On 02/11/2015 02:54 PM, Matt Turner wrote: > This is safer and matches the conditional_mod propagation pass. > > Cc: > --- > .../dri/i965/brw_fs_saturate_propagation.cpp | 8 ++--- > .../dri/i965/test_fs_saturate_propagation.cpp | 40 > ++ > 2 files changed, 44 i

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Consider MOV.SAT to interfere if it has a source modifier.

2015-02-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/11/2015 02:54 PM, Matt Turner wrote: > The saturate propagation pass recognizes that the second instruction > below does not interfere with an attempt to propagate the saturate > modifier from instruction 3 to 1. > > 1: add(8) dst0 src0 src

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Use fs_inst::overwrites_reg() in saturate propagation.

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 3:25 PM, Ian Romanick wrote: > On 02/11/2015 02:54 PM, Matt Turner wrote: >> This is safer and matches the conditional_mod propagation pass. >> >> Cc: >> --- >> .../dri/i965/brw_fs_saturate_propagation.cpp | 8 ++--- >> .../dri/i965/test_fs_saturate_propagation.cpp

Re: [Mesa-dev] [PATCH 1/4] i965: Don't emit saturates for instructions without destinations.

2015-02-19 Thread Ian Romanick
On 02/10/2015 11:09 AM, Matt Turner wrote: > We were special casing OPCODE_END but no other instructions that have no > destination, like OPCODE_KIL, leading us to emitting MOVs with null > destinations. Should we (or do we somehow already) handle instructions with null destinations? So...

Re: [Mesa-dev] [PATCH 2/4] i965: Use greater-equal cmod to implement maximum.

2015-02-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/10/2015 11:09 AM, Matt Turner wrote: > The docs specifically call out SEL with .l and .ge as the > implementations of MIN and MAX respectively. Among other things, SEL > with these conditional mods are commutative. > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 3/4] i965/blorp: Optimize clamping tex coords.

2015-02-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/10/2015 11:09 AM, Matt Turner wrote: > Each emit_cond_mov() emits a CMP of its first to arguments using the > specified conditional mod, followed by a predicated MOV of the fifth > argument into the fourth. In all four cases here, it was just > imple

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965/fs: Use fs_inst::overwrites_reg() in saturate propagation.

2015-02-19 Thread Ian Romanick
On 02/19/2015 03:29 PM, Matt Turner wrote: > On Thu, Feb 19, 2015 at 3:25 PM, Ian Romanick wrote: >> On 02/11/2015 02:54 PM, Matt Turner wrote: >>> This is safer and matches the conditional_mod propagation pass. >>> >>> Cc: >>> --- >>> .../dri/i965/brw_fs_saturate_propagation.cpp | 8 ++--

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Emit MADs.

2015-02-19 Thread Ian Romanick
Assuming that my assumption / recollection that blorp is only for GEN6+, this patch is Reviewed-by: Ian Romanick On 02/10/2015 11:10 AM, Matt Turner wrote: > Low hanging fruit: cuts a couple of instructions. > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 6 ++ > src/mesa/drivers/dr

[Mesa-dev] [PATCH] i965: just avoid warnings with fp64

2015-02-19 Thread Dave Airlie
This just fills in some blanks to avoid warnings in the i965 driver. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 13 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

Re: [Mesa-dev] [PATCH 1/4] i965: Don't emit saturates for instructions without destinations.

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 3:31 PM, Ian Romanick wrote: > On 02/10/2015 11:09 AM, Matt Turner wrote: >> We were special casing OPCODE_END but no other instructions that have no >> destination, like OPCODE_KIL, leading us to emitting MOVs with null >> destinations. > > Should we (or do we somehow alre

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Emit MADs.

2015-02-19 Thread Matt Turner
On Thu, Feb 19, 2015 at 3:35 PM, Ian Romanick wrote: > Assuming that my assumption / recollection that blorp is only for GEN6+, > this patch is Indeed, that's correct. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Add and use byte-MOV instruction for unpack 4x8.

2015-02-19 Thread Ian Romanick
FWIW, this patch is Reviewed-by: Ian Romanick On 02/11/2015 06:17 PM, Matt Turner wrote: > Previously we were using a B/UB source in an Align16 instruction, which > is illegal. It for some reason works on all platforms, except Broadwell. > > Cc: "10.5" > Bugzilla: https://bugs.freedesktop.org/

Re: [Mesa-dev] [PATCH] st/mesa: add st fp64 support (v7)

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 6:09 PM, Dave Airlie wrote: > From: Dave Airlie > > v2 : add double to int/unsigned conversion > v3: handle fp64 consts better > v4: use DRSQ > v4.1: add d2b > v4.2: drop DDIV > > v5: split out some prep patches. > v5.1: add some comments. > v5.2: more comments > > v6: sim

[Mesa-dev] [PATCH] i965/fs: Set pixel/sample mask for compute shaders atomic ops

2015-02-19 Thread Jordan Justen
For fragment programs, we pull this mask from the payload header. The same mask doesn't exist for compute shaders, so we set all bits to enabled. Note: this mask is ANDed with the execution mask, so some channels may not end up issuing the atomic operation. Signed-off-by: Jordan Justen Cc: Ben W

Re: [Mesa-dev] [PATCH 1/4] i965: Don't emit saturates for instructions without destinations.

2015-02-19 Thread Ian Romanick
On 02/19/2015 03:38 PM, Matt Turner wrote: > On Thu, Feb 19, 2015 at 3:31 PM, Ian Romanick wrote: >> On 02/10/2015 11:09 AM, Matt Turner wrote: >>> We were special casing OPCODE_END but no other instructions that have no >>> destination, like OPCODE_KIL, leading us to emitting MOVs with null >>> d

Re: [Mesa-dev] [PATCH] i965: just avoid warnings with fp64

2015-02-19 Thread Chris Forbes
Looks reasonable, if it's going to be a while before an i965 backend is ready.. Reviewed-by: Chris Forbes On Fri, Feb 20, 2015 at 12:38 PM, Dave Airlie wrote: > This just fills in some blanks to avoid warnings in the i965 driver. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] i965: just avoid warnings with fp64

2015-02-19 Thread Ian Romanick
Yes, please. Reviewed-by: Ian Romanick On 02/19/2015 03:38 PM, Dave Airlie wrote: > This just fills in some blanks to avoid warnings in the i965 driver. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + > src/mesa/drivers/dri/i965/brw_fs_c

[Mesa-dev] [PATCH 4/6] st/mesa: add support for new double opcodes

2015-02-19 Thread Ilia Mirkin
Not having SQRT is assumed to tacitly mean that RSQ is available. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgs

[Mesa-dev] [PATCH 3/6] gallium: add shader cap for dldexp/dfracexp support

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ src/gallium/drivers/r600/r600_pipe.c |

[Mesa-dev] [PATCH 6/6] st/mesa: lower DFRACEXP/DLDEXP when they are not supported

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index e170217..4d91ca6 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 5/6] st/mesa: disable lowering of dops to dfrac when dround is available

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 63b779d..e170217 100644 --- a/src/mesa/state_

[Mesa-dev] [PATCH 2/6] gallium: add a cap to enable double rounding opcodes

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 2 ++ src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 1/6] gallium: add some more double opcodes to avoid unnecessary lowering

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 5 src/gallium/docs/source/tgsi.rst | 39 ++ src/gallium/include/pipe/p_shader_tokens.h | 7 +- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/src/gallium/a

[Mesa-dev] [PATCH 0/6] add nvc0 fp64 prereqs to gallium + st/mesa

2015-02-19 Thread Ilia Mirkin
With these features, nvc0 can implement fp64 fairly easily (will send patches after these are in). The st/mesa changes depend on the fp64 enablement page Dave just sent out. Ilia Mirkin (6): gallium: add some more double opcodes to avoid unnecessary lowering gallium: add a cap to enable double

[Mesa-dev] [Bug 89199] u_math.h:591:4: error: implicit declaration of function 'ffsll'

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89199 --- Comment #4 from Vinson Lee --- $ gcc --version gcc (NetBSD nb2 20110806) 4.5.3 Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY

Re: [Mesa-dev] [PATCH 07/23] main: Add entry point for NamedBufferData.

2015-02-19 Thread Laura Ekstrand
On Wed, Feb 18, 2015 at 7:40 AM, Martin Peres wrote: > > On 12/02/15 04:05, Laura Ekstrand wrote: > >> v2: review from Ian Romanick >> - Fix space in ARB_direct_state_access.xml. >> - Remove "_mesa" from the name of buffer_data static fallback. >> - Restore VBO_DEBUG and BOUNDS_CHECK.

Re: [Mesa-dev] [PATCH 06/23] main: Add entry point for NamedBufferStorage.

2015-02-19 Thread Laura Ekstrand
This is NamedBufferStorage, not NamedBufferData. The storage function uses a bitfield instead of an enum. On Wed, Feb 18, 2015 at 7:04 AM, Martin Peres wrote: > On 12/02/15 04:05, Laura Ekstrand wrote: > >> --- >> src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ >> src/mesa/main/buff

Re: [Mesa-dev] [PATCH 0/6] add nvc0 fp64 prereqs to gallium + st/mesa

2015-02-19 Thread Dave Airlie
On 20 February 2015 at 09:52, Ilia Mirkin wrote: > With these features, nvc0 can implement fp64 fairly easily (will send > patches after these are in). The st/mesa changes depend on the fp64 > enablement page Dave just sent out. Apart from the style nitpick and the using 0.0 in the docs I mention

Re: [Mesa-dev] [PATCH 10/32] i965/fs: Remove logic to keep track of MRF metadata in lower_load_payload().

2015-02-19 Thread Jason Ekstrand
I'm still a little pensive. But Reviewed-by: Jason Ekstrand Now for a little aside. I have come to the conclusion that I made a grave mistake when I did the LOAD_PAYLOAD stuff. In retrospect, I should have just subclassed fs_inst for load_payload. The problem is that we need to snag a bunch

Re: [Mesa-dev] [PATCH] glapi: Do not use backtrace on FreeBSD.

2015-02-19 Thread Vinson Lee
On Thu, Feb 5, 2015 at 4:02 AM, Ian Romanick wrote: > On 01/24/2015 05:46 AM, Vinson Lee wrote: >> Fix build error. >> >> CCLD libGL.la >> libglapi.a(glapi_libglapi_la-glapi_gentable.o): In function >> `__glapi_gentable_NoOp': >> glapi_gentable.c:76: undefined reference to `backtrace' >> >>

[Mesa-dev] [PATCH 1/2] tgsi/scan: add uses_doubles to tgsi scanner

2015-02-19 Thread Dave Airlie
From: Dave Airlie This allows drivers to work out if a shader contains any double opcodes easily. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gal

[Mesa-dev] [RFC] cayman fp64 support

2015-02-19 Thread Dave Airlie
This just implements FP64 on cayman but disables the sb compiler for now. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] r600g: add doubles support for CAYMAN

2015-02-19 Thread Dave Airlie
From: Dave Airlie Only a subset of AMD GPUs supported by r600g support doubles, CAYMAN and CYPRESS are probably all we'll try and support, however I don't have a CYPRESS so ignore that for now. This disables SB support for doubles, as we think we need to make the scheduler smarter to introduce d

Re: [Mesa-dev] [PATCH 1/2] tgsi/scan: add uses_doubles to tgsi scanner

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 7:54 PM, Dave Airlie wrote: > From: Dave Airlie > > This allows drivers to work out if a shader contains any > double opcodes easily. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 > src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 +- >

[Mesa-dev] [Bug 89238] "nir/nir.h", line 643: Error: In this declaration "src" is of an incomplete type "nir_alu_src[]".

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89238 Bug ID: 89238 Summary: "nir/nir.h", line 643: Error: In this declaration "src" is of an incomplete type "nir_alu_src[]". Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH 01/11] nvc0/ir: add emission of dadd/dmul/dmad opcodes, fix minmax

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 66 +- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp inde

[Mesa-dev] [PATCH 08/11] nvc0/ir: handle zero and negative sqrt arguments

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp| 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.

[Mesa-dev] [PATCH 02/11] gk110/ir: add emission of dadd/dmul/dmad opcodes

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 80 +- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp in

[Mesa-dev] [PATCH 10/11] nvc0/ir: remove merge/split pairs to allow normal propagation to occur

2015-02-19 Thread Ilia Mirkin
Because the TGSI interface creates merges for each instruction source and then splits them back out, there are a lot of unnecessary merge/split pairs which do essentially nothing. The various modifier/etc propagation doesn't know how to walk though those, so just remove them when they're unnecessar

[Mesa-dev] [PATCH 09/11] nvc0/ir: add support for new TGSI double opcodes (v2)

2015-02-19 Thread Ilia Mirkin
v2: drop DDIV Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 196 + 1 file changed, 196 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp inde

[Mesa-dev] [PATCH 06/11] nvc0/ir: fix lowering of RSQ/RCP/SQRT/MOD to work with F64

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 4 +- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 4 +- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 4 +- .../nouveau/codegen/nv50_ir

[Mesa-dev] [PATCH 04/11] gm107/ir: fix DSET boolean float flag

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp index 9f4c435..73a65fa 100644 ---

[Mesa-dev] [PATCH 07/11] nvc0/ir: no instruction can load a double immediate

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp index 817ceb8..7d4a859 100644

[Mesa-dev] [PATCH 05/11] gm107/ir: fix F2F flipped stype/dtype flags

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp index 73a65fa.

[Mesa-dev] [PATCH 11/11] nvc0: enable double support

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index 8546ac8..686d892 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 03/11] gm107/ir: fix DMUL opcode encoding

2015-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp index 944ceb

[Mesa-dev] [Bug 89238] "nir/nir.h", line 643: Error: In this declaration "src" is of an incomplete type "nir_alu_src[]".

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89238 Jason Ekstrand changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Jason Ekst

[Mesa-dev] [PATCH] fp64: disable varying packing for doubles.

2015-02-19 Thread Dave Airlie
From: Dave Airlie I'm not sure we really care about this, but we need to write better support if we do. For now just disable it. piglit test: tests/spec/arb_gpu_shader_fp64/execution/vs-out-fs-in-double-2.shader_test Signed-off-by: Dave Airlie --- src/glsl/lower_packed_varyings.cpp | 3 +++

Re: [Mesa-dev] [PATCH] fp64: disable varying packing for doubles.

2015-02-19 Thread Ilia Mirkin
On Thu, Feb 19, 2015 at 9:43 PM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure we really care about this, but we need to > write better support if we do. For now just disable it. > > piglit test: > tests/spec/arb_gpu_shader_fp64/execution/vs-out-fs-in-double-2.shader_test > > Signed-of

Re: [Mesa-dev] [PATCH 2/2] r600g: add doubles support for CAYMAN

2015-02-19 Thread Glenn Kennard
On Fri, 20 Feb 2015 01:54:03 +0100, Dave Airlie wrote: From: Dave Airlie Only a subset of AMD GPUs supported by r600g support doubles, CAYMAN and CYPRESS are probably all we'll try and support, however I don't have a CYPRESS so ignore that for now. This disables SB support for doubles, as we

[Mesa-dev] [Bug 89238] "nir/nir.h", line 643: Error: In this declaration "src" is of an incomplete type "nir_alu_src[]".

2015-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89238 --- Comment #2 from Connor Abbott --- See this thread: http://lists.freedesktop.org/archives/mesa-dev/2015-February/077137.html looks like there are a few (mostly trivial) patches needed. -- You are receiving this mail because: You are the QA

[Mesa-dev] [PATCH v5] mesa: use fi_type in vertex attribute code

2015-02-19 Thread marius . predut
From: Marius Predut For 32-bit builds, floating point operations use x86 FPU registers, not SSE registers. If we're actually storing an integer in a float variable, the value might get modified when written to memory. This patch changes the VBO code to use the fi_type (float/int union) to store

[Mesa-dev] [PATCH] st/glsl_to_tgsi: fix ir_assignment hack doing bad things for doubles

2015-02-19 Thread Dave Airlie
From: Dave Airlie This hack for fixing gl_FragDepth apparantly caused a GLSL shader outputting a single double to try and output a dvec4, but we hadn't assigned outputs for the secondary bit. This avoids going into the hack code for scalar doubles. Signed-off-by: Dave Airlie --- src/mesa/stat

  1   2   >